GitLab

I'm currently looking at this.
Review URL: https://chromiumcodereview.appspot.com/10825309

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151147 0039d316-1c4b-4281-b951-d872f2087c98

Consider the following scenario:
1. Type "g" in the omnibox.
--> The omnibox inline autocompletes "oogle.com".
2. Hit Tab.
--> You're now in keyword mode.

Here, inline_autocomplete_text_ is still "oogle.com", though the display text
is a blank string. The previous code caused a crash. Now, we check properly
that the inline text is a suffix of the display text.

Arguably, the inline text should always be a suffix of the display text, say by
clearing it in OmniboxEditModel::AcceptKeyword(): http://crbug.com/141890

R=pkasting@google.com
BUG=141878
TEST=Scenario in CL description above shouldn't crash.

Review URL: https://chromiumcodereview.appspot.com/10824261

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151146 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137676
TBR=jamiewalch,tony

Review URL: https://chromiumcodereview.appspot.com/10825302

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151142 0039d316-1c4b-4281-b951-d872f2087c98

Need check size of both arrays before calling std::equal.

BUG=141904
Review URL: https://chromiumcodereview.appspot.com/10854099

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151140 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ivankr@chromium.org
BUG=141986

Review URL: https://chromiumcodereview.appspot.com/10854103

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151139 0039d316-1c4b-4281-b951-d872f2087c98

This CL:
- eliminates unnecessary dispatches
- correctly handles devices that are discovered before interest is
registered

TEST=ran api test
BUG=133179

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150898

Review URL: https://chromiumcodereview.appspot.com/10815072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151138 0039d316-1c4b-4281-b951-d872f2087c98

Adding the selection text direction to the notification that the selection
bounds have changed. This is used with touch UI.

BUG=138944
TEST=All tests should pass.


Review URL: https://chromiumcodereview.appspot.com/10855036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151137 0039d316-1c4b-4281-b951-d872f2087c98

BUG=130212


Review URL: https://chromiumcodereview.appspot.com/10855109

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151136 0039d316-1c4b-4281-b951-d872f2087c98

Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.

The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.

BUG=139346


Review URL: https://chromiumcodereview.appspot.com/10855075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151135 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151134 0039d316-1c4b-4281-b951-d872f2087c98

Move VideoDecoder initialization into VideoRendererBase to simplify implementing codec config changes during playback.

BUG=141533
TEST=Existing PipelineTest.*, VideoRendererBaseTest.*

Review URL: https://chromiumcodereview.appspot.com/10836167

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151132 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141037
TEST=Confirm no memory leaks in ReloadButton.

Review URL: https://chromiumcodereview.appspot.com/10827252

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151131 0039d316-1c4b-4281-b951-d872f2087c98

Fix: Add handling the case when both USE_X11 and USE_AURA are defined.

BUG=121235
TEST=Click middle mouse button in tab window on Linux Desktop; no crash


Review URL: https://chromiumcodereview.appspot.com/10828233

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151130 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151129 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r9404: (sehr) Get MCFragment field reordering.
r9405: (kschimpf) Remove data-66 prefix allowance for x87 memory instructions.
r9406: (mseaborn) Debug stub: Remove superfluous file 'gdb_rsp/host.cc'
r9407: (khim) Simplify string instructions support
r9408: (mseaborn) Debug stub tests: Handle EOF on socket gracefully rather than by spinning
r9409: (dschuff) Allow override of BUILD_ARCH in pnacl build
r9410: (robertm) Adding test family targets for xxx_irt to scons.
r9411: (mseaborn) Debug stub: Simplify the startup code
r9412: (mseaborn) Debug stub: Remove dubious test code in 'gdb_rsp/target_test.cc'
r9413: (dschuff) Make windows pnacl build work with recent cygwin
r9414: (sergeyu) Fix untrusted.gyp to detect changes in the list of sources.
r9415: (jvoung) Bump nacl_perf_expectations for pnacl x86-64 runtime_ammp.
r9416: (mseaborn) Debug stub: Test single-stepping/continuing with other threads suspended
r9417: (halyavin) Checkout from scratch if git pull fails.
r9418: (halyavin) Update gdb revision.
r9419: (sergeyu) Fix build_nexe.py to unescape quotes in the list of defines.
r9420: (arbenson) Drop stale NaClMprotectGuards.
r9421: (tysand) Buildbot change to VS2010
r9422: (kschimpf) Disallow data16 prefix with rex.w prefix on instructions that allow both
r9423: (jvoung) Allow -rdynamic in pnacl driver to appease CMake and OpenAL builds.
r9424: (dschuff) Remove clang shared lib from pnacl toolchain tarball
r9425: (sehr) Update to get MCFragment memory improvements.
r9426: (kschimpf) Optimze insertion of rule patterns into arm validator decoders.
r9427: (arbenson) Add a "hello world" test for the zero-based sandbox.
r9428: (bradchen) Fix enuminst to properly check base register usage.
r9429: (dschuff) Build Pnacl in hermetic cygwin
r9430: (khim) Implement couple of warts to make ragel-based validator more compatible with production one.
r9431: (mcgrathr) Extend infoleak test to cover ARM VFP state
r9432: (arbenson) Run gcc spec2k benchmark with zero-based sandbox
r9433: (shcherbina) Validator_ragel: add benchmark
r9434: (halyavin) GDB: Test that we can step inside function.

BUG=none
TEST=nacl_integration

Review URL: https://chromiumcodereview.appspot.com/10828256

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151128 0039d316-1c4b-4281-b951-d872f2087c98

Also adds the utility to stop clicks on any page to util.js and makes the NTP a
user of this function.

BUG=136338
TEST=Inspect a background view, options, or reload an extension while scrolled
without being forced to the top of the page.

Review URL: https://chromiumcodereview.appspot.com/10832196

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151127 0039d316-1c4b-4281-b951-d872f2087c98

Templates now show "Apps" for apps and "Extensions" for extensions.

BUG=141576

Review URL: https://chromiumcodereview.appspot.com/10834255

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151126 0039d316-1c4b-4281-b951-d872f2087c98

Moves the definitions in gdata_params.h to each appropriate file.

BUG=135306
TBR=ben@chromium.org
# for chrome/chrome_browser.gypi (two files removed)

Review URL: https://chromiumcodereview.appspot.com/10855034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151125 0039d316-1c4b-4281-b951-d872f2087c98

Test extension should be well-formed. Having warnings is often an early
indicator that something else is wrong (see for example https://chromiumcodereview.appspot.com/10852016/).

Review URL: https://chromiumcodereview.appspot.com/10826157

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151123 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=noelallen@chromium.org
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/10823275

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151122 0039d316-1c4b-4281-b951-d872f2087c98

BUG=134465
TEST=by hand


Review URL: https://chromiumcodereview.appspot.com/10836186

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151121 0039d316-1c4b-4281-b951-d872f2087c98

Change 150041 - Revert 143421 to disable Chrome to Mobile by default on trunk (for M22 branch).

Change 143421 - Revert 142809 to re-enable Chrome to Mobile by default on trunk (after M21 branch).

Change 142809 - Revert 135840 to disable Chrome to Mobile by default on trunk (for M21 branch).

Change 135840 - Revert 135442 to re-enable Chrome to Mobile by default on trunk.
We passed the M20 branch point with Chrome to Mobile disabled, as intended.

Change 135442 - Disable Chrome To Mobile by default; enable via chrome://flags.
This feature should be disabled-by-default on M19; for immediate merge.

Don't revert http://crrev.com/130312 to keep the AboutFlags_disable-chrome-to-mobile UMA bin.
Note: Mac's ViewIDTests don't yet support VIEW_ID_CHROME_TO_MOBILE_BUTTON.

BUG=102709, 120905
TEST=Chrome To Mobile is enabled on trunk (after M22 branch point).
TBR=msw@chromium.org,sky@chromium.org,nyquist@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10827285

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151120 0039d316-1c4b-4281-b951-d872f2087c98

A follow-up change will change gcapi to always install chrome
as current user (as determined by the CGSession owner), so that
chrome can set up user keystone itself on first run.

Also change the supported OS X versions from 10.5+ to 10.6-10.8.

BUG=128462

Review URL: https://chromiumcodereview.appspot.com/10854100

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151119 0039d316-1c4b-4281-b951-d872f2087c98

NOTE: THIS IS NOT A CRASH FIX!!! It's only an adjustment to reduce unnecessary work in potentially crashy code paths :-/

BUG=141702
TEST=no location bar layout regressions; fewer crashes?


Review URL: https://chromiumcodereview.appspot.com/10831253

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151118 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138846

Review URL: https://chromiumcodereview.appspot.com/10826247

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151117 0039d316-1c4b-4281-b951-d872f2087c98

Also some OOBE polishing:
*) fixed (top: 0) position for body to prevent scrolling;
*) oobe.html/login.html made structure elements.
*) 2x icons for user image screen.

BUG=129799,139169
TBR=jhawkins
(for browser_resources.grd)

Review URL: https://chromiumcodereview.appspot.com/10827169

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151116 0039d316-1c4b-4281-b951-d872f2087c98

- RemoveEntryFromDirectory() was a misnomer. It removes an entry if it's
  not on the root directory. The |dir_path| parameter was unnecessary
  as it can be obtained from |file_path|.
  New name: RemoveEntryFromNonRootDirectory()

- RemoveEntryFromDirectoryOnFileSystem() was a misnomer. It moves an
  entry to the root directory on the client side
  New name: MoveEntryToRootDirectoryOnClientSide()

- Rename *OnFileSystem() with *OnClientSide() to make it clear these are
  client side operations

- Rename OnMoveEntryToDirectoryWithFileMoveCallback() to
  NotifyAndRunFileMoveCallback() based on what it does

- Rename OnMoveEntryToDirectoryWithFileOperationCallback() to
  NotifyAndRunFileOperationCallback() based on what it does

Along the way, eliminate if (!callback.is_null()) and PostTask() from
places where these are unnecessary.

BUG=126634, 139446
TEST=moving and renaming of files on Drive works as before

Review URL: https://chromiumcodereview.appspot.com/10832233

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151115 0039d316-1c4b-4281-b951-d872f2087c98

OWNER rubber stamp, since I only changed a set of VLOG(1) to VLOG(9)...
TBR=thestig

BUG=141691
TEST=Make sure that the text to be translated doesn't show up in vlogs unless you set them level to 9.

Review URL: https://chromiumcodereview.appspot.com/10831264

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151114 0039d316-1c4b-4281-b951-d872f2087c98

BUG=121174


Review URL: https://chromiumcodereview.appspot.com/10834160

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151113 0039d316-1c4b-4281-b951-d872f2087c98

Revert 151104 - Re-revert part of my previous cl r151036 to see if this is the line that caused the regression.

http://crbug.com/133762
TBR=sky@chromium.org
TEST=
http://build.chromium.org/f/chromium/perf/mac-release-10.6/intl1/report.html?history=150&rev=-1
Review URL: https://chromiumcodereview.appspot.com/10831267

TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10829287

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151112 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138571

Review URL: https://chromiumcodereview.appspot.com/10828214

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151111 0039d316-1c4b-4281-b951-d872f2087c98

CC/CXX/AR now refer to target compilation.
We need to specifically set the host toolchain (CC_host, CX_host, AR_host) as well.

Review URL: https://chromiumcodereview.appspot.com/10836192

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151110 0039d316-1c4b-4281-b951-d872f2087c98

(originally broken by r141977)

Review URL: https://chromiumcodereview.appspot.com/10855105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151109 0039d316-1c4b-4281-b951-d872f2087c98

1 - fix a crash
2 - remove an ifdef that's no longer required

BUG=134929

Review URL: https://chromiumcodereview.appspot.com/10855087

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151108 0039d316-1c4b-4281-b951-d872f2087c98

Add RegisterHandler() and UnregisterHandler(), which should be called before and after calls to UpdateRegisteredIds().  Use UnregisterHandler() on
shutdown instead of UpdateRegisteredIds(_, ObjectIdSet()).

Make SyncNotifierHelper non-thread-safe.  Fix test breakages that this revealed.  Also add GetAllRegisteredIds() instead of making it the return value of UpdateRegisteredIds().

Propagate UpdateRegisteredIds()/RegisterHandler()/UnregisterHandler() all
the way up to ProfileSyncService.

Make FakeSyncManager be created on the sync thread.

Clean up SyncBackendHost startup/shutdown behavior a bit.

BUG=140325

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150990

Review URL: https://chromiumcodereview.appspot.com/10824161

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151107 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=nacl mono buildbots
Review URL: https://chromiumcodereview.appspot.com/10825287

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151106 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/125937

TBR=sky@chromium.org,jochen@chromium.org,sadrul@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10827271

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151105 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/133762
TBR=sky@chromium.org
TEST=
http://build.chromium.org/f/chromium/perf/mac-release-10.6/intl1/report.html?history=150&rev=-1
Review URL: https://chromiumcodereview.appspot.com/10831267

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151104 0039d316-1c4b-4281-b951-d872f2087c98

It should be prohibited to copy list observer object because otherwise
it would be impossible to guarantee that network monitor resource
is destroyed when the list observer is destroyed. Also the copied
list observer would not work properly anyway.

Review URL: https://chromiumcodereview.appspot.com/10832229

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151103 0039d316-1c4b-4281-b951-d872f2087c98

Added a new kUserRemovedLoginItem pref that is used to track if the user has
previously removed a login item for chrome. This is so we don't keep re-creating
the login item every time the user enables/installs a background app if they
have indicated that they don't want chrome to open at login.

BUG=140017
TEST=Install background app on mac, uncheck "Open at Login" checkbox in dock menu, disable and re-enable the app via Tools->Extension, make sure Open at Login checkbox does not get re-enabled.


Review URL: https://chromiumcodereview.appspot.com/10823221

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151102 0039d316-1c4b-4281-b951-d872f2087c98