- 18 Nov, 2017 40 commits
-
-
Sky Malice authored
Per guidance at about data coming from untrusted sources, such as disk or network, removed DCHECKs when handling data Loopback storage, see https://groups.google.com/a/chromium.org/d/msg/chromium-dev/LU6NWiaSSRc/oolO8fg5AAAJ Instead null entities are returned which are essentailly just dropped. Also includes some minor cleanup, including deletion of un-used fake_server_entity.cc file, consistent usage of un-templated WrapUnique, nullptr for empty unique_ptrs, and pushed test constant back to test file (single_client_wallet_sync_test.cc). Bug: 771811 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I73045ed11982e6c44d5b623855163e61c1961fa2 Reviewed-on: https://chromium-review.googlesource.com/713556Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mike Baxley <baxley@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#517667}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0844d0e4444c..276e0454b797 $ git log 0844d0e44..276e0454b --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I2b2eebd702461162110cdc0a5399a8e9d460a0bf Reviewed-on: https://chromium-review.googlesource.com/777847Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#517666}
-
Xiaohui Chen authored
BUG=b:69178309 TEST=login as supervised user, see assistant settings gone Change-Id: Ib84d9dc34288b9edaffcddd3f42ecdacd0e7d0a8 Reviewed-on: https://chromium-review.googlesource.com/777961Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#517665}
-
Tim Brown authored
Change-Id: I852031b2c7dcf210c05ed9f2b0f0cea7ee9faf3e Reviewed-on: https://chromium-review.googlesource.com/778048Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Tim Brown <timbrown@chromium.org> Cr-Commit-Position: refs/heads/master@{#517664}
-
James Cook authored
Enable all passing tests. Categorize all failing tests and file bugs for the most common ones. Bug: 678687 Test: browser_tests --mash Change-Id: I13bbf84322aaa3d6dcceb36a2fceff1fc16280f1 Reviewed-on: https://chromium-review.googlesource.com/777848Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#517663}
-
Ryan Landay authored
changwan@ pointed out it would be a good idea to add a test for the autocorrect attribute (e.g. <input autocorrect="off">) since we don't appear to have one already. Change-Id: Ifb21a7e68950e60d66a1a5c8ee618b436c4620c6 Reviewed-on: https://chromium-review.googlesource.com/740373 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#517662}
-
Renjie Liu authored
Original owner: amoylan@chromium.org Original cl: https://chromium-review.googlesource.com/c/chromium/src/+/754254 This CL is part of the implementation of public-IP-only geolocation as described in the design doc: https://docs.google.com/document/d/1oSQM3GEMTL1raWLYv8S6_Yyt93FF2zQbANI4bKJ6LDs This part is the implementation of the centralized PublicIpAddressLocationNotifier that issues IP-geolocation requests to handle any/all clients. This reuses the NetworkLocationRequest class from the existing Geolocation service (which provides web-platform geolocation) in //device/geolocation. This CL creates //services/device/geolocation/ and includes a "+net" DEPS entry. (This "+net" dependency, among others, will eventually be needed when all of //device/geolocation eventually moves into //services/device/geolocation as part of Geolocation Servicification.) Tests: Unit tests for PublicIpAddressGeolocationNotifier covering the logic to do with responding to different sequences of "network change detected" and "client wants a new/next position". Add PartialNetworkTrafficAnnotation as well. Bug: 718694, 769158 Bug: Change-Id: I792a1793a54b283949b97f411b70a71ea27ec6c8 Reviewed-on: https://chromium-review.googlesource.com/757821Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Renjie Liu <renjieliu@chromium.org> Commit-Queue: Renjie Liu <renjieliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#517661}
-
Menglu Huang authored
Bug: Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib3c61bb6351d79be433fea84842580ab4f950cad Reviewed-on: https://chromium-review.googlesource.com/777781Reviewed-by:
-
Kenneth Russell authored
Core Animation doesn't have the ability to honor this flag. Fall back to the regular OpenGL-based composition path in this case. Finally add a pixel test for this. BUG=599285 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I06ffe41b5080bab6d767472b0deb4b97142ead21 Reviewed-on: https://chromium-review.googlesource.com/776218 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#517659}
-
Weiyong Yao authored
Android VEA currently doesn't preserve the timestamps in the input frames, causing trouble for WebRTC. The reason is MediaCodec assumes the presentation timestamp to be monotonically-growing value. But in chromium the video capture maybe paused a while or drop some frames, so the timestamps in input frames won't be continious as expected. Then we have to generate a seperate monotonically-growing timestamp for encoding instead. Here we cache the timestamps in input frames, mapping to the generated timestamp, and read them out after encoding. Then encoder can work happily and we can preserve the input timestamps. Bug: 785407 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I594190436f18437afb937c4f0667a5b1e3019280 Reviewed-on: https://chromium-review.googlesource.com/775144 Commit-Queue: Weiyong Yao <braveyao@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#517658}
-
Jialiu Lin authored
PPAPIDownloadRequest.RequestDuration is always zero. This is because UMA_HISTOGRAM_TIMES macro cannot handle negative number. This Cl fixes this issue. Bug: 633341 Change-Id: I8dd1200ed7f28e746469b4d82ef0e927a5080a88 Reviewed-on: https://chromium-review.googlesource.com/777887 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Commit-Queue: Nathan Parker <nparker@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#517657}
-
mark a. foltz authored
We want to consolidate how route descriptions passed to the UX by using MediaRoute.description instead of MediaStatus.description. This adds comments explaining what the route description should be used for, and notes that MediaStatus.description will be deprecated once MRPs are updated to use MediaRoute.description instead. It also removes the "Casting" prefix which was sometimes inserted before MediaRoute.description, as we want to customize the description to say "Casting," "Remoting," or "Mirroring." The template string remains so we can use it in a future change for proper localization of the description. This change does not make the UX any worse than it is right now (and will be followed soon by an MRP changes to add "Casting" back where it makes sense). The Media Router elements are refactored to use "description" consistently and to better share CSS, which makes rendering more consistent between MediaStatus.description and MediaRoute.description. TBR=estark@chromium.org for comment-only .mojom changes Bug: 786208 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9356fa917f0d77eeac5b7b32d6175aa03a943e5c Reviewed-on: https://chromium-review.googlesource.com/776130 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#517656}
-
Wenzhao Zang authored
The functions listed in the mojo interface are all from WallpaperManager. The next step is to move their implementation to //ash one by one. By the time they are all moved, WallpaperManager can basically be deleted. TBR=michaelpg@chromium.org Bug: 779221 Change-Id: I90efac15662d32d96670f56af3145a9c42270ef3 Reviewed-on: https://chromium-review.googlesource.com/762126Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
-
Eric Roman authored
concatenation. The former is a direct reading of RFC 6960 Change-Id: Iaadd14838f41524330345c488eab81d49e406fe4 Reviewed-on: https://chromium-review.googlesource.com/777733Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#517654}
-
Jonathan Metzman authored
Bug: 784014 Change-Id: Id7b5b16debfa4cbb3aebf3d84c30b34fe67b64d0 Reviewed-on: https://chromium-review.googlesource.com/766514 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#517653}
-
Philip Rogers authored
These root layer scrolling expectations are now correct. paint/invalidation/window-resize/window-resize-frameset.html paint/invalidation/window-resize/window-resize-viewport-percent.html paint/invalidation/window-resize/window-resize-positioned-percent-top.html paint/invalidation/window-resize/window-resize-positioned-bottom.html paint/invalidation/window-resize/window-resize-percent-width-height.html paint/invalidation/window-resize/window-resize-percent-html.html paint/invalidation/window-resize/window-resize-no-layout-change2.html paint/invalidation/window-resize/window-resize-no-layout-change1.html paint/invalidation/window-resize/window-resize-media-query.html paint/invalidation/window-resize/window-resize-centered-inline-under-fixed-pos.html paint/invalidation/window-resize/window-resize-background-image-non-fixed.html paint/invalidation/window-resize/window-resize-background-image-generated.html paint/invalidation/window-resize/window-resize-background-image-fixed-centered-composited.html paint/invalidation/window-resize/window-resize-background-image-fixed-centered.html window-resize-vertical-writing-mode.html has not been rebaselined because it fails for underinvalidation and needs to be fixed. Bug: 781419 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls Change-Id: If96694875991c95895deeca322c1e5b20612d5c2 Reviewed-on: https://chromium-review.googlesource.com/777482Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#517652}
-
Nate Fischer authored
No change to behavior. There were a few method calls in content layer where a comment is used to indicate the parameter name, but the comment's param name doesn't match the real parameter name. This CL changes the comment to match the parameter name. This is another errorprone compile warning. Test: ninja system_webview_apk (warnings go away) Change-Id: I6080a30f6656a1e6d2221521fbb9c11a250e8376 Reviewed-on: https://chromium-review.googlesource.com/777551Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#517651}
-
Kenneth Russell authored
This runs essentially the same tests as the desktop bots. BUG=786572 NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I36718069f2a786e3f7e274645d3ff6f58404f492 Reviewed-on: https://chromium-review.googlesource.com/777728 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#517650}
-
Bill Orr authored
There were a number of issues with lifetime that would cause issues, such as multiple initializations of OpenVR, multiple conflicting OpenVRDevices, and leaking objects. This change fixes those so OpenVRDeviceProvider owns OpenVRDevice, which owns OpenVRRenderLoop, and OpenVRRenderLoop correctly cleans up its bindings. Change-Id: I32ee8abaa70a8a13155448e697d318c675f1d9ed Reviewed-on: https://chromium-review.googlesource.com/777787Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#517649}
-
Greg Kerr authored
FontObjectsServer access is needed on not just macOS version 10.11, and the new sandbox was blocking the accees and causing renderer crashes. Bug: 786615 Change-Id: If94af99e476325155d9262ac3e3dc75831aa8c5f Reviewed-on: https://chromium-review.googlesource.com/777976Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#517648}
-
David Jacobo authored
In chrome://settings we already have a definition for AndroidAppsInfo so reusing instead of duplicating. Bug: None Test: Build. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie7a24d9c9df7fe3d22e3e85d067c140944f85db4 Reviewed-on: https://chromium-review.googlesource.com/773479Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#517647}
-
Eric Karl authored
This change adds the OOP Raster transfer cache. Subsequent changes will hook these objects up to the OOP Raster serialize/deserialize mechanisms. The transfer cache includes four main classes/interfaces: --ClientTransferCacheEntry-- Represents an object that can be added to the transfer cache. Includes methods for serializing the object for transport to the GPU process. --ClientTransferCache-- Provides methods for inserting, locking, unlocking, and deleting ClientTransferCacheEntry objects. Handles sending these objects to the ServiceTransferCache. --ServiceTransferCacheEntry-- Represents an object that can be stored in the GPU process' ServiceTransferCache. Includes methods for deserializing the serialized data produced by the ClientTransferCacheEntry. --ServiceTransferCache-- Includes methods for receiving new objects from the ClientTransferCache, looking up existing objects, and enforcing memory limits. This system is built around the existing DiscardableHandle system used in GPU discardable textures. Bug: 777622 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5bf2ed467147d6dbcd5690a3997280806c4d7763 Reviewed-on: https://chromium-review.googlesource.com/747273 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#517646}
-
Jayson Adams authored
The ColorPanelCocoa sets itself as the target and delegate of the NSColorPanel, and on dealloc it clears the NSColorPanel's target and delegate settings if it sees that it is the delegate. On 10.13 it appears that the NSColorPanel's delegate can get set to nil while leaving the target intact, preventing -dealloc from clearing the ColorPanelCocoa target and leading to a Zombie crash. This cl uses a private method to check the NSColorPanel's target in -dealloc and clear it if it's still the ColorPanelCocoa. R=rsesek@chromium.org,avi@chromium.org Bug: 767598 Change-Id: I86557f3dadc65b8e0d455156457d960d8f45044e Reviewed-on: https://chromium-review.googlesource.com/685394 Commit-Queue: Jayson Adams <shrike@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Steven Bennetts authored
C++ -> JS listeners are relatively expensive and having more than one for a particular event is unnecessary, more complex, and confusing. Instead, make <internet-page>, which contains the other elements, the primary listener and dispatch JS events to the other elements when a networkingPrivate event occurs. Bug: 784026 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I834797a2d814cde563144bac816c69d55ad78633 Reviewed-on: https://chromium-review.googlesource.com/775661 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#517644}
-
rbpotter authored
Bug: 773928 Change-Id: I2980d8833df8abd31b231efd5bc531c4479d171d Reviewed-on: https://chromium-review.googlesource.com/777459Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#517643}
-
Lei Zhang authored
Change-Id: I84e036d5c71373ce3572d4b67b06fcadb25bb347 Reviewed-on: https://chromium-review.googlesource.com/777963 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#517642}
-
CrystalFaith authored
Image in notification was removed, but the name of the image in notification was not updated. Bug: None Change-Id: I121a86bf592601933d1f4ae0730e5c049b743dd4 Reviewed-on: https://chromium-review.googlesource.com/769655Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Cr-Commit-Position: refs/heads/master@{#517641}
-
Bailey Berro authored
Bug: Change-Id: I79fa779041a90182dc839b00fc404f6f80acd6a7 Reviewed-on: https://chromium-review.googlesource.com/777395 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#517640}
-
chrome://flagsEdward Jung authored
iOS doesn't show unavailable experiments which broke the tab layout. Additionally set the viewport max scale so the page doesn't jump around when the keyboard is activated, Bug: 783837 Change-Id: I691b3efca6ad24870d195357783e6016d30b0cee Reviewed-on: https://chromium-review.googlesource.com/769949Reviewed-by:
-
Yash Malik authored
This CL add the necessary glue to wire up the keyboard API to its implementation in the Daydream Keyboard APK. The keyboard can be temporarily be summoned via the app button by turning on the vr-browser-keyboard runtime flag. Follow-up CLs will introduce the keyboard element and remove the temporary code in VrShellGl. Bug: 641470 Change-Id: I3d1372aa335db69c1e38adbb00a67993f9eea1e0 Reviewed-on: https://chromium-review.googlesource.com/731568 Commit-Queue: Yash Malik <ymalik@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#517638}
-
kylechar authored
This call originates in the browser process and is passed back to a SyntheticBeginFrameSource in the GPU process. This is pretty simple plumbing. The change requires RootCompositorFrameSinkImpl knowing it has a SyntheticBeginFrameSource. Wrap up the results of DisplayProvider into a struct so that we can handle the ExternalBeginFrameSource case too without adding more output parameters. Bug: 772524 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I9af43d4278475d07d19aefe7a03b6ee2426b536d Reviewed-on: https://chromium-review.googlesource.com/767352 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#517637}
-
Tim Brown authored
The new libraries include dconf. Bug: 768027 Change-Id: I724aa27893f37891103de2cf0898d48ea7a4d406 Reviewed-on: https://chromium-review.googlesource.com/777968Reviewed-by:
Evgeniy Stepanov <eugenis@chromium.org> Commit-Queue: Tim Brown <timbrown@chromium.org> Cr-Commit-Position: refs/heads/master@{#517636}
-
Philip Rogers authored
Just needed a mac10.11-specific baseline (non-RLS also needs this): paint/invalidation/background/change-text-content-and-background-color.html The difference is: - "rect": [30, 30, 45, 23], + "rect": [30, 30, 44, 23 Just needed a fixed win10 baseline: paint/invalidation/selection/japanese-rl-selection-clear.html The difference is: - "rect": [230, 123, 542, 394], + "rect": [273, 123, 499, 394], Bug: 781419 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls Change-Id: Iff5add970393cc19e3f803ec738b2f7d09db8310 Reviewed-on: https://chromium-review.googlesource.com/777943Reviewed-by:
-
Takumi Fujimoto authored
WiredDisplayMediaRouteProvider will record the number of sinks each time it notifies MediaRouter of sink updates. Bug: 783850 Change-Id: Ifc7c6e21b9253016ba3ec139ce50e11f313a08bf Reviewed-on: https://chromium-review.googlesource.com/767854Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#517634}
-
Gang Wu authored
change ModelTypeController::BridgeTask from Callback to OnceCallback. Bug: 786478 Change-Id: I5d559aafefa3917b5cde5e06f398078989b3bc10 Reviewed-on: https://chromium-review.googlesource.com/777386 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#517633}
-
Hans Wennborg authored
This reverts commit dbc676c1. Reason for revert: This broke Android ASan. Original change's description: > Roll clang 317263:318369. > > Bug: 782281 > > Change-Id: Ia7f42af4cc63771dcb6d83f6a0fa0f98e2602c13 > Reviewed-on: https://chromium-review.googlesource.com/774119 > Commit-Queue: Hans Wennborg <hans@chromium.org> > Reviewed-by: Evgeniy Stepanov <eugenis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517269} TBR=eugenis@chromium.org,hans@chromium.org,rnk@chromium.org Change-Id: Ib4ff2dd46d05a386e286713f49722cd826b26ca4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 782281,786449 Reviewed-on: https://chromium-review.googlesource.com/777483Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#517632}
-
Cait Phillips authored
Bug: 700812 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib3d0a17e24b6b3c08e34de68400c0a1fe3a855f4 Reviewed-on: https://chromium-review.googlesource.com/761239 Commit-Queue: Cait Phillips <caitkp@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#517631}
-
Candice Sy authored
Clean up because is_loaded() is no longer used. The function was removed from OfflinePageModel and classes that overrode it. Bug: 784653 Change-Id: I72f38e5621ba67762d0086d5a1c1cafbb614e6b3 Reviewed-on: https://chromium-review.googlesource.com/772977 Commit-Queue: Candice Sy <cmsy@google.com> Reviewed-by:
Yafei Duan <romax@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#517630}
-
Min Qin authored
TBR=dtrainor@chromium.org Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I5bbf63d772762bb672097d8323672f8747e2d91c Reviewed-on: https://chromium-review.googlesource.com/778045Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#517629}
-
Daniel Murphy authored
R: mek@chromium.org Bug: 770307 Change-Id: If5dfbdb3064e1b4f336680d45dfcff1d1ef27add Reviewed-on: https://chromium-review.googlesource.com/775674 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#517628}
-
