- 07 Nov, 2019 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ed392790fed1..866bde58907c git log ed392790fed1..866bde58907c --date=short --no-merges --format='%ad %ae %s' 2019-11-06 treehugger-gerrit@google.com Merge "Disable fdsan after clone(2)." Created with: gclient setdep -r src/third_party/perfetto@866bde58907c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I07202cbe452b7987965b80ab4e335568cc8798d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902190Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713302}
-
Kuo-Hsin Yang authored
Some log messages are incorrectly identified as IPv6 address, e.g. function identifiers with namespace. Requiring word boundaries around IPv6 address with alphanumeric character at the start/end, e.g. "e::ab" in "State::abort" is not an IPv6 address. Also avoid adding empty string to identifier_space. Bug: 1019577 Test: components_unittests --gtest_filter="AnonymizerToolTest.*" Change-Id: Ib57508a3189f5518c10e4169120eece02ec2dfde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893486Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#713301}
-
Chris Lu authored
This new property will be important for Infobars whose actions will take some time and require the banner persisting to visualize that process. This change also adds InfobarTranslateCoordinator as implementing InfobarCoordinatorImplementation. Bug: 1014959 Change-Id: Iaa21fd9f3025e9797f9d0b63f6337efd0e3cb89a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899635 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#713300}
-
Jenny Zhang authored
TBR=xiyuan@chromium.org Bug: 1016026 Change-Id: I22637b311ac3c69029504ff7cedf5df5943f145d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899802 Commit-Queue: Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#713299}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/714f8cc3ff4b..67d43fe58187 git log 714f8cc3ff4b..67d43fe58187 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 csmartdalton@google.com Rename stencil face terminology to clockwise/counter-clockwise 2019-11-06 herb@google.com Allow more sub-pixel position bits Created with: gclient setdep -r src/third_party/skia@67d43fe58187 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: Ia2603d7acd27b36a9c0eb37efd682e7dc50dc561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902470Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4dffa04d4f00..361d1c3e5ab4 git log 4dffa04d4f00..361d1c3e5ab4 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 peah@webrtc.org Simplifications/refactoring of the analog AGC to make it multichannel 2019-11-06 alessiob@webrtc.org RNN VAD: Optimize GRU (recurrent) weights optimized layout 2019-11-06 yvesg@webrtc.org Expose OpusTest class for re-use as chromium test. Created with: gclient setdep -r src/third_party/webrtc@361d1c3e5ab4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:1002973 Change-Id: Ieda0e47db3b117ef433dfe3a3b14dd66fb15ea8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902469Reviewed-by:
-
Christian Biesinger authored
See stack trace below. We set the override container logical height to -1 for the initial layout of a flex item so that we compute the correct size for min-height. However, that messes with our cache for definite heights because we would always set it to indefinite in such a case. Instead, just don't cache these values. That way we will later compute the right thing for resolving flex-basis, etc. (FlexNG can't come soon enough...) #0 blink::LayoutBox::ContainingBlockLogicalHeightForPercentageResolution (this=0x3dda8d434198, out_cb=0x7f6e7d42d8c0, out_skipped_auto_height_containing_block=0x0) at ../../third_party/blink/renderer/core/layout/layout_box.cc:3833 #1 0x00007f6ee84ad0a1 in blink::LayoutFlexibleBox::MainAxisLengthIsDefinite (this=0x3dda8d434010, child=..., flex_basis=Length(0%, Percent), add_to_cb=false) at ../../third_party/blink/renderer/core/layout/layout_flexible_box.cc:762 #2 0x00007f6ee84af930 in blink::LayoutFlexibleBox::MainSizeIsDefiniteForPercentageResolution ( this=0x3dda8d434010, child=...) at ../../third_party/blink/renderer/core/layout/layout_flexible_box.cc:1125 #3 0x00007f6ee84ad7f5 in blink::LayoutFlexibleBox::UseOverrideLogicalHeightForPerentageResolution ( this=0x3dda8d434010, child=...) at ../../third_party/blink/renderer/core/layout/layout_flexible_box.cc:1137 #4 0x00007f6ee83f2b9d in blink::LayoutBlock::AvailableLogicalHeightForPercentageComputation ( this=0x3dda8d434198) at ../../third_party/blink/renderer/core/layout/layout_block.cc:2333 #5 0x00007f6ee845e745 in blink::LayoutBox::ContainingBlockLogicalHeightForPercentageResolution ( this=0x3dda8d4243d0, out_cb=0x0, out_skipped_auto_height_containing_block=0x0) at ../../third_party/blink/renderer/core/layout/layout_box.cc:3830 #6 0x00007f6ee86dcc5c in blink::LayoutBoxUtils::AvailableLogicalHeight (box=..., cb=0x3dda8d434198) at ../../third_party/blink/renderer/core/layout/ng/layout_box_utils.cc:64 #7 0x00007f6ee86eafea in blink::LayoutNGMixin<blink::LayoutBlockFlow>::ComputeIntrinsicLogicalWidths ( this=0x3dda8d4243d0, min_logical_width=0px, max_logical_width=0px) at ../../third_party/blink/renderer/core/layout/ng/layout_ng_mixin.cc:48 #8 0x00007f6ee83ef53a in blink::LayoutBlock::ComputePreferredLogicalWidths (this=0x3dda8d4243d0) at ../../third_party/blink/renderer/core/layout/layout_block.cc:1509 #9 0x00007f6ee8451f01 in blink::LayoutBox::MaxPreferredLogicalWidth (this=0x3dda8d4243d0) at ../../third_party/blink/renderer/core/layout/layout_box.cc:1395 #10 0x00007f6ee84adba2 in blink::LayoutFlexibleBox::ComputeInnerFlexBaseSizeForChild (this=0x3dda8d434198, child=..., main_axis_border_and_padding=0px, child_layout_type=blink::LayoutFlexibleBox::kForceLayout) at ../../third_party/blink/renderer/core/layout/layout_flexible_box.cc:890 #11 0x00007f6ee84ae5d1 in blink::LayoutFlexibleBox::ConstructAndAppendFlexItem (this=0x3dda8d434198, algorithm=0x7f6e7d42ed70, child=..., layout_type=blink::LayoutFlexibleBox::kForceLayout) at ../../third_party/blink/renderer/core/layout/layout_flexible_box.cc:1203 #12 0x00007f6ee84aa27b in blink::LayoutFlexibleBox::LayoutFlexItems (this=0x3dda8d434198, relayout_children=true, layout_scope=...) at ../../third_party/blink/renderer/core/layout/layout_flexible_box.cc:934 #13 0x00007f6ee84a9cff in blink::LayoutFlexibleBox::UpdateBlockLayout (this=0x3dda8d434198, relayout_children=true) at ../../third_party/blink/renderer/core/layout/layout_flexible_box.cc:369 Bug: 1019138 Change-Id: Ie94e69a5f3fe6accc3623d358315b174088d5597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902514 Commit-Queue: David Grogan <dgrogan@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#713296}
-
Becca Hughes authored
The Media.Engagement.SessionFinished UKM event has lots of fields from when we were experimenting. We should remove these prior to our storage cleanup. BUG=998685 Change-Id: I87bbd5221d97161e042345e00b778096c3729523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775195Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#713295}
-
Tsuyoshi Horo authored
This reverts commit 3e01d61b. Reason for revert: Caused build failure https://ci.chromium.org/p/chromium/builders/ci/linux-archive-dbg/5699 [56914/72140] CXX obj/content/test/content_browsertests/render_frame_impl_browsertest.o FAILED: obj/content/test/content_browsertests/render_frame_impl_browsertest.o /b/s/w/ir/cache/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF...(too long) ../../content/renderer/render_frame_impl_browsertest.cc:50:10: fatal error: 'third_party/blink/public/mojom/frame/frame_host_test_interface.mojom.h' file not found #include "third_party/blink/public/mojom/frame/frame_host_test_interface.mojom.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Original change's description: > [mojo] Remove DocumentInterfaceBroker > > This change removes the DocumentInterfaceBroker mojom interface and all > related plumbing. No functional changes since the interface was not used > by anything (clients migrated to BrowserInterfaceBroker). > > TBR=tommycli@chromium.org,rbpotter@chromium.org,arthursonzogni@chromium.org,kenrb@chromium.org,alexmos@chromium.org,rdevlin.cronin@chromium.org,haraken@chromium.org > > Bug: 985120 > Change-Id: I893f940bc2c5d237aac5fb6b3962c06bfa98e938 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881394 > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713278} TBR=dcheng@chromium.org,kenrb@chromium.org,tommycli@chromium.org,rdevlin.cronin@chromium.org,haraken@chromium.org,alexmos@chromium.org,chcunningham@chromium.org,rbpotter@chromium.org,arthursonzogni@chromium.org,oksamyt@chromium.org Change-Id: I6c25e96111dca691e007353a27710251b125659e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 985120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902181Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#713294}
-
Oriol Brufau authored
There are already some perf tests with lots of grid items, but they only span a single track. The track sizing algorithm handles contributions from items with a span of 1 in a simpler way than when the span is greater than 1. So testing the >1 case is useful. This patch adds a copy of the auto-grid-lots-of-data.html perf test, but using items with a span of 2 instead of 1. Spec: https://drafts.csswg.org/css-grid/#algo-spanning-items Bug: 1021929 Change-Id: Ifd73e28a72128113416b20d7934b96c353e93969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901286Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#713293}
-
Takashi Sakamoto authored
This reverts commit f7860793. Reason for revert: suspect causing compile failure on linux-chromeos-google-rel. Sample build: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/8776 Original change's description: > assistant: add audio ducking for internal media > > Bug: b/135064564 > Test: locally build and run with multiple media playing > Change-Id: I3814cfc3bc619077ca6781493fd369c27d50eb4e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899184 > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713200} TBR=xiaohuic@chromium.org,wutao@chromium.org Change-Id: I6595ecc2d3ea93a762996386f3af9bf297daed70 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/135064564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902180Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#713292}
-
Ahmed Mehfooz authored
Bug: 1021639 Change-Id: If65812f8a2d961f88fc66c9b060671e7b7d8e8ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900293Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#713291}
-
Theresa Wellington authored
Move android_chrome_strings.grd to its own separate build target and merge ui widget strings back into android_chrome_strings.grd. BUG=1002534 Change-Id: I179e2d74ba8dc169574fd2596915067ebb357787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895971Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#713290}
-
Chris Lu authored
The banner should not be dismissed if the Infobar's action has not finished. This is because Infobars that have a non-instantaneous action will persist the banner until completion. Bug: 1014959 Change-Id: I3b9a442c60163a29ef37ec6a1e39ae66734e74d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900136 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
-
Junbo Ke authored
Bug: b/143499157 Test: CQ Merge-With: eureka-internal/332932 Change-Id: I98b2331231a85c84dda4f894bf5336fae37a16af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894298Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Junbo Ke <juke@chromium.org> Cr-Commit-Position: refs/heads/master@{#713288}
-
Zhongyi Shi authored
The QuicChromiumPacketReader upon finishing the socket read, will dereference the socket to get local and peer addresses and report packet back to the visitor unconditionally even if the connection is closed. The patch landed in crrev.com/c/1900569 nulls out the socket upon connection close, leading to null dereference when fetching local and peer addresses. Bug: 1014092, 1021938 Change-Id: I9af79f03b3e2ffbe1ed036af8980efa6b6d1478c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901946 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#713287}
-
Marina Sakai authored
Remove a macro-generated function for a private property of MessageEvent and all the macros in v8_private_property.h This CL removes a macro-generated function for a private property of MessageEvent, and replaces it with the new API GetSymbol, which uses an instance address of V8PrivateProperty::SymbolKey as a key to get Symbol. Now we can remove all the macros in v8_private_property.h. Bug: 715418 Change-Id: Id4ce8e9cc45deea7e9e8bf2064bc44b8559cc0be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899227Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Marina Sakai <marinasakai@google.com> Cr-Commit-Position: refs/heads/master@{#713286}
-
Anupam Snigdha authored
Display attributes may not be available for all compositions so added a null check to avoid crashes in ui::TSFTextStore::GetDisplayAttribute while querying for attribute info using ITfDisplayAttributeInfo object. Bug: 1017313 Change-Id: Icac383a03729ba62cca0b45a67c324eb359e2283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902111Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#713285}
-
Alan Cutter authored
This text used to be for a model dialog but is now used by a bubble. Bubble dialogs don't use title text on any platform. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=419504&signed_aid=U0mvxY1dLrVi4TEDJKYtrA==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=419505&signed_aid=_YtJNSAFtjqMsLVgd1Foqg==&inline=1 Fixed: 1020310 Change-Id: Ia613fe934041fec7326550d8a438a4ab07f0d4c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898905 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#713284}
-
Rahul Arakeri authored
This CL deletes this VirtualTestSuite because it is not a configuration that is shipped on Windows or Linux. This config is run only on Mac which already has coverage. Bug: 1022096 Change-Id: Ia54bbd71c458c51fdbbe058c7564801f62b28afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901640Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#713283}
-
Sajjad Mirza authored
This fixes link-time undefined symbol errors that occur because the Clang profiling runtime uses symbols from the C runtime. Bug: 1020445 Change-Id: Ic7b1f9cb970ff26592a934675ee5bc204249f4db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896238Reviewed-by:
Tien Mai <tienmai@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Cr-Commit-Position: refs/heads/master@{#713282}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6072d056a7cb..322220a0b205 git log 6072d056a7cb..322220a0b205 --date=short --no-merges --format='%ad %ae %s' 2019-11-06 timvp@google.com Vulkan: Ignore VK_INCOMPLETE from vkGetPipelineCacheData Created with: gclient setdep -r src/third_party/angle@322220a0b205 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: Ia934d70c5748bc80c845e831afde719855b76709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902082Reviewed-by:
-
Michael Spang authored
This shouldn't be necessary any longer; it was fixing small errors introduces by computing rotations using trig functions. Bug: 1019015 Change-Id: Ia6c273454f96c556f34d0adca391eb0e121a98b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885635 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#713280}
-
Erik Chen authored
We only need to run these checks once. We run them on android_compile_dbg because that's the fastest cycling builder. Bug: 1020704 Change-Id: I0a088dbf23c23fd56ce82b457ed70c73297ae1f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900921 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#713279}
-
Oksana Zhuravlova authored
This change removes the DocumentInterfaceBroker mojom interface and all related plumbing. No functional changes since the interface was not used by anything (clients migrated to BrowserInterfaceBroker). TBR=tommycli@chromium.org,rbpotter@chromium.org,arthursonzogni@chromium.org,kenrb@chromium.org,alexmos@chromium.org,rdevlin.cronin@chromium.org,haraken@chromium.org Bug: 985120 Change-Id: I893f940bc2c5d237aac5fb6b3962c06bfa98e938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881394Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#713278}
-
Natalie Chouinard authored
Move Download Location feature-specific methods from PrefServiceBridge to the dedicated DownloadLocationDialogBridge as static methods. Bug: 1016957 Change-Id: I513fe4a6919754305fc19568b8149d01069bbd4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898508 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#713277}
-
Etienne Pierre-doray authored
This extract parts of CFIBacktraceAndroid into a dedicated utility class for parsing Chrome CFI tables. This is meant for direct use by ChromeUnwinderAndroid to eventually replace CFIBacktraceAndroid. CFIBacktraceAndroid originally implements caching of recent entries. This was ditched in this CL for simplicity and might be re-introduced in a follow-up if performance/memory is an issue. This CL does not attempt to reuse the extracted reader implementation in CFIBacktraceAndroid, in order to avoid introducing bugs in StackUnwinderAndroid due to the differing implementations. Bug: 989103 Change-Id: I3a34d55c7b61d336dd998ac8d863af9f041dab59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872838Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#713276}
-
Kai Ninomiya authored
Prepares us to roll the vertex state CTS changes along with the vertex state changes in Dawn and Chrome. TBR: enga@chromium.org Change-Id: I5ed5eebdff7d8e7559b0044686caacea9defd850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902131Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#713275}
-
Clark DuVall authored
The classes were renamed in http://crrev.com/c/1898536, this just cleans up the variable names and references in comments. Also removes NewBrowserCallbackProxy.java which was replaced by NewTabCallbackProxy.java. Change-Id: Id84989f5fb603fe521ff22f959156c8993236abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902530Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#713274}
-
Steven Bennetts authored
Bug: 965089 Change-Id: I659a95d604806bf7cf0305206e1239010253521b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875384 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#713273}
-
Natalie Chouinard authored
Migrate some simple feature-specific getters/setters to use the generic feature-agnostic methods instead. Bug: 1016957 Change-Id: Ia37263b9e66c99bab8ebce3385d71d4308a9b0b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898390Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#713272}
-
Ana Salazar authored
This change will allow users to use the mousewheel to scroll over the contents of the scrollable shelf. Bug: 1018016 Change-Id: I949eb241a74be365b0a366f56c59cba04ce6099b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901354Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#713271}
-
Avery Musbach authored
The present CL is a new way to serve the same purpose as [1]. As SplitViewDragIndicators::WindowDraggingState has values called kFromOverview and kFromTop, I think it is most intuitive to add one called kFromShelf, with the caveat that the difference between kNoDrag and kFromShelf is all about animations. Compared to [1], I think it is nice to avoid adding a whole extra member variable. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1894754 Test: ash_unittests DragWindowFromShelfControllerTest.SplitViewDragIndicatorsWindowDraggingStates Test: ash_unittests SplitViewDragIndicatorsTest.SplitViewDragIndicatorsVisibility Fixed: 1020349 Change-Id: I69aefae3a68579d2f0d0c61a8d8f5588689d0b13 Bug: 1020349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898771 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
-
Luum Habtemariam authored
The new CupsProxyService adds more libCUPS dependent code to Chrome, but it doesn't look like any of the trybots currently run them. This change combines the new tests into a new target set to run in the ChromeOS VM trybot (chromeos-amd64-generic-rel). Bug: chromium:945409 Test: trybot runs and passes Change-Id: I4ef5724a3d4b0923fba3abcd7fde8bb744209c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797002Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#713269}
-
Miguel Casas authored
This CL continues crrev.com/c/1897358 by substituting LOG_ASSERT()s in test code with ASSERT_TRUE()s, avoiding crashing the test binary. m/g/t/video_frame_validator.cc is an easy one-to-one substitution, whereas video_frame_helpers.cc need to add a macro to return an invalid value when the predicate doesn't hold up. Bug: 1020776 Change-Id: I8e0671dce792b479c91c722c652bd387f4cd5faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900559Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#713268}
-
Yuchen Liu authored
This reverts commit 3fe28bd3. Reason for revert: Break Android. Revert to unblock internal CQ. Original change's description: > [chromecast] Enable new QueryableData bindings on Linux > > Set the new QueryableData JS bindings feature on. > > Bug: internal b/138623432 > Test: E2E manually test > Change-Id: Ia1a3e4f650aeabee3aae90f9e764a63c2d9213b5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891738 > Auto-Submit: Jiawei Li <lijiawei@chromium.org> > Reviewed-by: Yuchen Liu <yucliu@chromium.org> > Commit-Queue: Jiawei Li <lijiawei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711043} TBR=yucliu@chromium.org,lijiawei@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: internal b/138623432 Change-Id: I798ac7fbf55e16597347748ba7f2c4af4156761c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902710Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#713267}
-
John Abd-El-Malek authored
The script to generate Java versions handles both cases. Change-Id: I6ae9373da9658a6c509ad1dd473cd8e4cfc1f3c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902517 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Akihiro Ota authored
This change refactors Output.format_ to take a parameters object. This helps maintain code readability in instances where optional parameters need to be passed in. Change-Id: I3e24f9d809b745aaef1bef16d376a16c35742a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820044 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#713265}
-
Marc Treib authored
Bug: 1021147 Change-Id: Iaa557f133ba9f4d517bac952ba2d7807915b31d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900987 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
-
Anand K. Mistry authored
Bug: 1007813 Change-Id: I0fbb86cd6d2fae4e9a8d2ead2079a706c8e57ae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898157Reviewed-by:
-
