- 31 Oct, 2019 40 commits
-
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for media::Renderer using PendingReceiver and SelfOwnedReceiverRef. Bug: 955171 Change-Id: Ibbd108219a3f3eac175e4122376f1a78ed976aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886070Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#711112}
-
Jon Mann authored
Previously the configRequiresPassphrase_ value wasn't always updating when the security type changed, this resulted in the password field getting shown/hidden at incorrect times. Bug: 1019495 Change-Id: I127ad6bf57595afc1a244455a14386c00585eab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889470 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#711111}
-
Sven Zheng authored
When tests run in parrallel, the dialog get randomly closed with reason lost focus. For bubble dialog, when they get deactivate they will close themselves: https://cs.chromium.org/chromium/src/ui/views/bubble/bubble_dialog_delegate_view.cc?l=237&rcl=c32f919eb9638bd8b1030a460c016c6b75a1c286 There's also test trying to tackle the problem: https://cs.chromium.org/chromium/src/chrome/browser/ui/views/tabs/tab_hover_card_bubble_view_browsertest.cc?l=345&rcl=2e48cb8072cdcf0a4da0c3e04e196a100838ebcc This cl will fix it by block close the dialog temporarily. Why it wasn't an issue when pixel test not enabled? It's because there's no wait/async in ShowAndVerifyUi(). But with pixeltest, there are several async calls and wait for callback, which give the browser chance to close the dialog. Eg the async in snapshot: https://cs.chromium.org/chromium/src/ui/snapshot/snapshot_aura.cc?l=51&rcl=07fe9cc024d6c20514423412c9c3aead11d9767c When running in 36 launcher jobs, this issue contributes ~2% flakiness. I've also observed that in very rare cases, dialog can get closed with ESC pressed. But I didn't figure out which test mis-sending the ESC key press to the system. So the block close will block all reasons instead of lost focus only. Bug: 958242 Change-Id: I51037dd7070fc4c35195d0e07c408763906dcdd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889949 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#711110}
-
John Lee authored
- Track thumbnails only if they are currently in view or are just a standard finger swipe away. - Do not track thumbnails for pinned tabs. - Do not track thumbnails when the tab strip is closed. Note that this CL does not implement actually untracking thumbnails. It merely calls the method in the C++ side that will eventually do it. Bug: 1015132 Change-Id: I86f7a8ea284395fc97dfed60fbb0452a0dfaa8ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885504 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#711109}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a25f3386ca1a..69a6c2e64544 git log a25f3386ca1a..69a6c2e64544 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 pprabhu@chromium.org Stop running irrelevant pre-cq on LCQ Created with: gclient setdep -r src/third_party/chromite@69a6c2e64544 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I2832dbc1c24a1639a10f55e6156793b40ad86a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892099Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711108}
-
Li, Hao authored
- Align VideoFrameMetadata structure following https://github.com/dalecurtis/video-animation-frame/blob/master/explainer.md - Rename WebGLVideoFrameInfo to WebGLVideoFrameMetadata - Add the definition for optional attributes Bug: 776222 Change-Id: Iee967cce45de0423e9ba327cdd462587e52aec7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879998Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Hao Li <hao.x.li@intel.com> Cr-Commit-Position: refs/heads/master@{#711107}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I588967029bbfd17df5932ae8b7e8677bf64676bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892251Reviewed-by:
-
Shengsong Tan authored
autotest JS Some Tast Tests need to know the statement of ARC window caption, such as whether caption buttons enable or visible. But currently there isn't any function to get these information. This CL add caption information of arc window in GetAppWindowList. Bug: b/142446508 Bug: b/141978622 Test: tast -verbose run my_crbook arc.CompanionLibrary Change-Id: Ib9c0ebde1ec2304fd5cd9d77523207b64deb7767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883453 Commit-Queue: Shengsong Tan <sstan@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#711105}
-
Dirk Pranke authored
Two tests appear to have started becoming flak(ier) after r710862. TBR=aboxhall@chromium.org Bug: 10200183 Change-Id: I075bee4409114a46db3833f5c2cc5fef0ff72e77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892292Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#711104}
-
Michael Spang authored
This reverts commit 43dc520f. Reason for revert: Fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1891457 Original change's description: > Revert "X11Window: Avoid size hack for tests" > > This reverts commit da320a9f. > > Reason for revert: Unfortunately this seems to be causing a CI failure: > https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8898137098615237856/+/steps/aura_unittests/0/logs/Deterministic_failure:_WindowTreeHostTest.DPIWindowSize__status_FAILURE_/0 > > Original change's description: > > X11Window: Avoid size hack for tests > > > > The default configuration of TestScreen is to create one display and one > > WindowTreeHost with the same size. > > > > X11 is now incompatible with this requirement as of b14e13fd ("Reland > > "X11 and Ozone: DWTHPlatform handles Show/Hide/Max/Restore/Full""). > > > > Several aura tests are only passing currently due to another bug in > > DisplayList::UpdateDisplay, which prevents X11Window from > > seeing the current display size and enforcing the constraint. > > > > Other tests only work because TestScreen resizes the display to match > > the WindowTreeHost /after/ X11Window deletes the last row and column. > > i.e., X11Window tries to adjust the size to not match the display, > > and then TestScreen re-adjusts the display to match the window. This > > behavior is not convergent and causes small changes in initialization > > order to affect the dimensions of test windows. > > > > This hack should likely be removed altogether and the bug it's addressing > > fixed another way, but for now disable it in the test harness because it > > is blocking other changes such as a fix for the UpdateDisplay bug noted > > above. > > > > Bug: 1019015 > > > > Change-Id: I79e830b9c35df3df29dc8af50ac424076682d180 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889294 > > Commit-Queue: Michael Spang <spang@chromium.org> > > Reviewed-by: Michael Spang <spang@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#710955} > > TBR=sky@chromium.org,spang@chromium.org,thomasanderson@chromium.org,msisov@igalia.com > > Change-Id: I1177d258e4957dc1f216e18c6df95067f7cbb0ed > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1019015 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890458 > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Commit-Queue: Alice Boxhall <aboxhall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711094} TBR=sky@chromium.org,spang@chromium.org,aboxhall@chromium.org,thomasanderson@chromium.org,msisov@igalia.com Change-Id: I2caa075079f5f260c007cc553a94a77ab7bcd14e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1019015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892059Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#711103}
-
Jimmy Gong authored
- Fixes a bug where some large error text would appear misplaced in both add and edit printer dialog. - Update browsertest to reflect this change. Bug: 1019432 Test: browsertests and end to end Change-Id: I24c2c96f4cf68c647a16d8cb69580cdf66ae43f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888950 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#711102}
-
rbpotter authored
Patch Polymer so that whitespace is always removed, since the legacyOptimizations flag does not seem to have this effect in Polymer 3. Bug: 965770 Change-Id: I050522e98cf3b8d606b964cd5def734e7cb0d16b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891462 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
kylechar authored
Add a new scoped_refptr constructor for creating from nullptr. This is to better understand how many callers rely on the scoped_refptr(T*) constructor and what would need to be fixed for it to be made explicit. Also fix a few places where NULL is still being implicitly converted to scoped_refptr<T>. This causes a compilation error with the new constructor as NULL is defined as 0. TBR=marq@chromium.org Bug: 589048 Change-Id: I117703b4db3472e191bf64629ec7ac7966ba10d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876908 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#711100}
-
Hwanseung Lee authored
text_direction_ is not used anymore since the patch[1] merged. so get rid of text_direction_ variable. [1] https://codereview.chromium.org/1151263002 Bug: None Change-Id: I3745bed0c6ccb911e07d46d9dd7690d0e081b470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891815Reviewed-by:
-
Glen Robertson authored
Moves LoadWebAppAndCheckInstallability from being the only non-virtual method defined in the parent InstallManager class to exist alongside other similar methods in web_app_install_manager child class. This also allows it to use the web_app_install_task to run the async parts and use some shared machinery. This is a step towards unifying and de-duplicating various web app loading, checking, and installing steps. In prep for changing behaviour in http://crrev.com/c/1847609 Bug: 1007860 Change-Id: Ib18356719fc0f321cd6bd100d2ce6ec0a450ee0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873817 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#711098}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e6d7ff710e36..6d4996c3785c Created with: gclient setdep -r src-internal@6d4996c3785c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ieb433af6461d33f2453b09bec0bab6a36949efe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892097Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711097}
-
Vitaly Buka authored
This just enables the same flag as crrev.com/c/1795632 The following are still disabled: Windows: blocked by llvm roll, which will make clang-cl recognize -ftrivial-auto-var-init. Android: android-kitkat-arm-rel consistently fails a test. Clang shipped with XCode can be too old to support this flag. Bug: 977230 Change-Id: I622ba8fea93ed65cf8cb01fab26df0fb5f26f12b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838383Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#711096}
-
Ben Pastene authored
A few of them have been consistently timing out. Looks like it's natural growth, so this increases their test shards. Note that linux-chromeos-dbg is CI-only, so the increase in bot usage should be minimal. Bug: 985588 Change-Id: I959507e5ba6892e56680bea707d5fd50b05850e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892071Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#711095}
-
Alice Boxhall authored
This reverts commit da320a9f. Reason for revert: Unfortunately this seems to be causing a CI failure: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8898137098615237856/+/steps/aura_unittests/0/logs/Deterministic_failure:_WindowTreeHostTest.DPIWindowSize__status_FAILURE_/0 Original change's description: > X11Window: Avoid size hack for tests > > The default configuration of TestScreen is to create one display and one > WindowTreeHost with the same size. > > X11 is now incompatible with this requirement as of b14e13fd ("Reland > "X11 and Ozone: DWTHPlatform handles Show/Hide/Max/Restore/Full""). > > Several aura tests are only passing currently due to another bug in > DisplayList::UpdateDisplay, which prevents X11Window from > seeing the current display size and enforcing the constraint. > > Other tests only work because TestScreen resizes the display to match > the WindowTreeHost /after/ X11Window deletes the last row and column. > i.e., X11Window tries to adjust the size to not match the display, > and then TestScreen re-adjusts the display to match the window. This > behavior is not convergent and causes small changes in initialization > order to affect the dimensions of test windows. > > This hack should likely be removed altogether and the bug it's addressing > fixed another way, but for now disable it in the test harness because it > is blocking other changes such as a fix for the UpdateDisplay bug noted > above. > > Bug: 1019015 > > Change-Id: I79e830b9c35df3df29dc8af50ac424076682d180 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889294 > Commit-Queue: Michael Spang <spang@chromium.org> > Reviewed-by: Michael Spang <spang@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710955} TBR=sky@chromium.org,spang@chromium.org,thomasanderson@chromium.org,msisov@igalia.com Change-Id: I1177d258e4957dc1f216e18c6df95067f7cbb0ed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1019015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890458Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#711094}
-
Andrew Luo authored
Bug: 765833 Change-Id: I9558db3934ebae0252f0fd4f2861c3c4441d7020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871639 Auto-Submit: Andrew Luo <aluo@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#711093}
-
Andrew Luo authored
Bug: 1016864 Change-Id: I881410c752768d51782f1ac921ff4fa63f3b2505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879563Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#711092}
-
Sajjad Mirza authored
Temporarily turn off the sandbox coverage file injection on Android platform. Also remove a stale TODO for Windows. Bug: 985574 Change-Id: If5a9906cb5c9ef865e91c787d9046428ba78cb6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891468Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Cr-Commit-Position: refs/heads/master@{#711091}
-
Jon Mann authored
This reverts commit 44f15333. Original change's description: > Revert "[Wifi Sync] Implement the SyncedNetworkUpdater class." > > This reverts commit a6f0d9ae. > > Reason for revert: Causing failures in chromeos_components_unittests. > Bug: https://crbug.com/1018633 > > Original change's description: > > [Wifi Sync] Implement the SyncedNetworkUpdater class. > > > > This is responsible for updating the local network stack to match > > incoming WifiConfigurationSpecifics protos from the sync backend. > > > > Bug: 966270 > > Change-Id: Ib4bdf1c22604b2528bc2abad5bc2ac1672e58290 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768877 > > Commit-Queue: Jon Mann <jonmann@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#709627} > > TBR=xiyuan@chromium.org,stevenjb@chromium.org,khorimoto@chromium.org,jonmann@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 966270 > Change-Id: Idce7f0208c06412b9c950e3f833f50b5f15a816b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882201 > Reviewed-by: Meredith Lane <meredithl@chromium.org> > Commit-Queue: Meredith Lane <meredithl@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709792} Change-Id: I5d934901deba2aeb7e1b8fb968270cdf75beaf22 Bug: https://crbug.com/1018633, 966270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884361Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5da6f444eff6..841b01678c49 git log 5da6f444eff6..841b01678c49 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 ynovikov@chromium.org Suppress flaky dEQP-GLES3 test on Win7 NVIDIA D3D11 Created with: gclient setdep -r src/third_party/angle@841b01678c49 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: I67af42c798b0b286efcaa140b7e8a39f47b6ff99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891785Reviewed-by:
-
Johannes Henkel authored
New revision: 112f668538cf71ee033fb7687e6dcdff46f95716 This changes the directory for the C++ library and the namespace. Upstream change and review: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1884662 Bug:1018411 Change-Id: I88d16237066efce8698d71ae90e49746bc491cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881117Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Auto-Submit: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#711088}
-
Derek Schuff authored
The nacl-gcc toolchain no longer runs on recent version of MacOS. Coverage of the glibc toolchain's use of the Pepper ABIs will continue on Linux/Win. Change-Id: Id60229cfde0fca368a28f708994b26c479326606 Bug: 1013169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888723Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#711087}
-
Tsuyoshi Horo authored
Currently the argument type of this completion callback is MojoResult. The callback is called from BundledExchangesReader::ReadResponseBody() and the argument is the result of mojo::DataPipeProducer::Write(). This argument is converted to net::OK or net::ERR_UNEXPECTED in BundledExchangesURLLoaderFactory::EntryLoader::FinishReadingBody() and is passed network::URLLoaderCompletionStatus.error_code. This completion callback will be called also from MojoBlobReaderDelegate of BundledExchangesBlobDataSource (https://crrev.com/c/1886271). In this case, MojoBlobReaderDelegate receives the completion result as a net::Error. To avoid redundant conversion, this CL changes the argument type of BundledExchangesReader's BodyCompletionCallback from MojoResult to net::Error. Bug: 1018640 Change-Id: I99783eb4744784a09f838db8b1062f6a90e8e455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890452Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#711086}
-
Kai Ninomiya authored
Change-Id: I568496f29b5bd4c0f202142003ad3f1794663582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890020Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#711085}
-
Bettina authored
Rename leaked_credentials files to compromised_credentials files so it's easier to check blame when changing the code in the future. Bug: 1015671 Change-Id: I966ab45d9a90e3b9f6d5215474549600462029fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888392 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#711084}
-
Bruce Dawson authored
Control Flow Guard is a security feature that can help stop exploits. It is primarily need on our official builds. On the debug and component builds where Chromium is primarily developed it just adds a bit of extra size to the object files. This was fine until it triggered a spurious link error in component builds when symbol_level=2 was selected. This wasn't caught by the bots because most (all?) of them build with symbol_level=1, or non-component. This turns off CFG for debug and component builds, thus getting those builds working again for developers. Bug: 1019970 Change-Id: I7a56af177452e62a5f3ad1daa608970cb9518d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891991Reviewed-by:
-
Caleb Raitto authored
We're keeping these enum values only for conversion of old DB values and UMA metrics. Bug: 953995 Change-Id: I98681a90c81ee3d6d27dc1e8ea0100334cfc0897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890537Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#711082}
-
Xinghui Lu authored
Protego's allowlist on Android is hardcoded in internal repository. It doesn't need to be controlled by kRealTimeUrlLookupFetchAllowlist. Bug: 1014202 Change-Id: I12875ce7e3426eb8a772be7393aa2a63e21fbe43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888128 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
-
Karan Bhatia authored
This CL adds the rule priority to RequestAction. This helps us simplify implementation of GetRedirectOrUpgradeActionByPriority. Also: - Move GetRedirectOrUpgradeActionByPriority from RulesetMatcherInterface to RulesetMatcher, since only RulesetMatcher needs it. - Change the type of |rule_id| in RequestAction from int to uint32_t since that's what is used by url_pattern_index::flat::UrlRule. Any casting to int can happen in client code. - Improve comments in ruleset_matcher_interface.h and extension_url_pattern_index_matcher.h to clarify that we return the highest priority redirect and upgrade actions. This CL does not have any behavior change. BUG=974391 Change-Id: I02385141cfd9dbddf46abd99eeee0bdaf318f40e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888599 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#711080}
-
Daniel Rubery authored
This feature is no longer needed, it had only been kept around for testing. Bug: 1018756 Change-Id: Ic41d3a35356b76c7d39774bcdc87f33df9359190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885222 Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
Preview tab was using URL for title. This should be properly updated with the title info when available. Also caption URL was not updated as the page navigates. This CL fixes the 2 problems by adding: - OverlayContentDelegate.onTitleUpdated - the missing |invalidate| call on caption view Change-Id: I2a0ae8122c9bc637a304456e677b3d5bdd49647a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888852 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#711078}
-
Hiroki Nakagawa authored
Bug: 932363, 1019145 Change-Id: Id4f552f8e5038f2f1c7207172ad53c45cbac33c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888617 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#711077}
-
Zhongyi Shi authored
When QuicChromiumClientSession closes sockets, notify corresponding QuicChromiumPacketReaders to stop future read from the closed sockets. This change also adds metrics to verify if there are any reads on the closed sockets in the old code. Bug: 1014092 Change-Id: Ib92ffefa7aa9c8bdaec5e359b6a482b397f5b1c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891578 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#711076}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c7a8df8b1cdb..549325c87e9d git log c7a8df8b1cdb..549325c87e9d --date=short --no-merges --format='%ad %ae %s' 2019-10-30 egdaniel@google.com Have GrTextureOp use GrSurfaceProxyViews instead of just proxys. 2019-10-30 herb@google.com Remove unused API 2019-10-30 brianosman@google.com Use SkYUVMath in asyncRescaleAndReadPixelsYUV420 2019-10-30 hop2deep@gmail.com build: fix compilation on macOS with 10.14 SDK 2019-10-30 brianosman@google.com Print out a warning if trying to use a cross context image on two contexts Created with: gclient setdep -r src/third_party/skia@549325c87e9d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: chromium:none Change-Id: I267d238ed4fc2dd2183b36acca366a5429dc29d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891551Reviewed-by:
-
Lily Chen authored
Bug: None Change-Id: I8b5163209c54a98f5807adb91df90f362cb4644c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890951 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9bc823dd. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Id9bf6b8c596847d51a00a7d92179ffe8e8ab1b53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891076Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711073}
-
