GitLab

This is to diagnose the bug referenced below. I think it is possible that a third party DLL is hooking TerminateProcess with a replacement that uses the wrong calling convention or has the wrong number of arguments, which causes Process::Terminate to return to the wrong address, causing a crash.

I put it in ThreadFunc because this is visible on the stack when the crash happens and because it is a windows specific .cc file.

BUG=81449

Review URL: http://codereview.chromium.org/7606016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96266 0039d316-1c4b-4281-b951-d872f2087c98

wait for page loads.
Also, be able to launch chromium and chrome regardless of what branding
we're built with.
BUG=89757
TEST=none


Review URL: http://codereview.chromium.org/7582005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96265 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83609
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/7462023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96264 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90443
TEST=none


Review URL: http://codereview.chromium.org/7604033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96263 0039d316-1c4b-4281-b951-d872f2087c98

Committing for rogerm@google.com, original review at http://codereview.chromium.org/7583042/.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/7461149
Patch from Roger McFarlane <rogerm@google.com>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96262 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92274
TEST=Browser does not crash if Chromoting client is used to connect from a machine with at least one network interface with no IP address.

Review URL: http://codereview.chromium.org/7552030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96261 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:18984
TEST=manual testing in chromeos-chrome on linux

Review URL: http://codereview.chromium.org/7462022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96260 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=sync_performance_tests

Review URL: http://codereview.chromium.org/7605012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96259 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7613001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96258 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7590005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96256 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92396
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/7611004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96255 0039d316-1c4b-4281-b951-d872f2087c98

No functional change.

R=cmp@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7461145

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96254 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: http://codereview.chromium.org/7608032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96252 0039d316-1c4b-4281-b951-d872f2087c98

alter the HTML.

This is a follow up to http://codereview.chromium.org/5151006/ .

Review URL: http://codereview.chromium.org/7606007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96251 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92389
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/7583048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96250 0039d316-1c4b-4281-b951-d872f2087c98

BUG=80654
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/7583046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96249 0039d316-1c4b-4281-b951-d872f2087c98

- Flapper specific installer
- a small bug fix on the updater_configurator
- wired into chrome startup in browser_init
- changes to chrome_paths to override flapper path


TEST=see bug
BUG=89248
Review URL: http://codereview.chromium.org/7604023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96247 0039d316-1c4b-4281-b951-d872f2087c98

- Use flexbox on toplevel div so timeline fills window
- Fix overlay_test, which was regressing
- Shrink "title" header to h3 and reduce padding
- Send gpuInfo and clientInfo to tracing_controller so saved files get those fields

Review URL: http://codereview.chromium.org/7497049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96246 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Manual

Review URL: http://codereview.chromium.org/7610001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96245 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90530
Review URL: http://codereview.chromium.org/7538006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96244 0039d316-1c4b-4281-b951-d872f2087c98

Add OVERRIDE to a bunch of overridden functions.

BUG=91861
TEST=


Review URL: http://codereview.chromium.org/7604019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96243 0039d316-1c4b-4281-b951-d872f2087c98

Because we aren't using it for anything anymore.
Review URL: http://codereview.chromium.org/7538008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96238 0039d316-1c4b-4281-b951-d872f2087c98

This is from the old user data dir multi profile thingy that was removed ages
ago.

BUG=23581

Review URL: http://codereview.chromium.org/7497050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96236 0039d316-1c4b-4281-b951-d872f2087c98

The mini_installer is linked with /FIXED to avoid creating RELOCs, saving size (about 3K ... is it worth it?).

Review URL: http://codereview.chromium.org/7606005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96235 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96234 0039d316-1c4b-4281-b951-d872f2087c98

/bin/true doesn't exist on Mac OS X. However, true seems to be in the path on Linux and Mac OS X, so let's use that.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96233 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:18665,chromium-os:18702
TEST=Should see createAccount/guestSignin links to the right of the gaia signin iframe. chrome://settings/accounts has checkboxes to control the visibility of these links. Clicking these links should work as you'd expect.
Review URL: http://codereview.chromium.org/7497060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96232 0039d316-1c4b-4281-b951-d872f2087c98

The new functions will be used to implement other classes
that will be added in a separate patch.

BUG=90036
TEST=run unit tests


Review URL: http://codereview.chromium.org/7569020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96231 0039d316-1c4b-4281-b951-d872f2087c98

Automation for step 1-9 testplan @ go/NACL-SDK-testing
BUG=89467, 89470, 89479, 89610, 89612
TEST=None

Review URL: http://codereview.chromium.org/7541046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96230 0039d316-1c4b-4281-b951-d872f2087c98

generation is a blocking operation.

BUG=88782
TEST=None

Review URL: http://codereview.chromium.org/7565023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96229 0039d316-1c4b-4281-b951-d872f2087c98

Remove carriage return characters and set "svn:eol-style" to "LF".

The commit bot will not handle patches to this file otherwise.

BUG=89730
TEST=none
Review URL: http://codereview.chromium.org/7612007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96228 0039d316-1c4b-4281-b951-d872f2087c98

Add a separate histogram label for GWS based prerendering.
R=cbentzel@chromium.org, dominich@chromium.org
Review URL: http://codereview.chromium.org/7605020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96227 0039d316-1c4b-4281-b951-d872f2087c98

blocked on an extension with a webrequest API event handler.

BUG=82618
TEST=no


Review URL: http://codereview.chromium.org/7523042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96226 0039d316-1c4b-4281-b951-d872f2087c98

When not signed in the wrench menu says "Sign in to Chrome". When signed in it says "Signed in to Chrome as pat@example.com".

BUG=91009
TEST=Ran and verified that the wrench menu updated after signing into sync.


Review URL: http://codereview.chromium.org/7604017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96225 0039d316-1c4b-4281-b951-d872f2087c98

This works around the fact that the Java2 plugin is no longer officially supported for 10.5, and is thus no longer included in the Internet Plug-Ins directories where we expect to find plugins.

BUG=89543
TEST=Open about:plugins on 10.5; Java should be listed.


Review URL: http://codereview.chromium.org/7601022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96224 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96222 0039d316-1c4b-4281-b951-d872f2087c98

BUG=87094
TEST=none
Review URL: http://codereview.chromium.org/7612003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96216 0039d316-1c4b-4281-b951-d872f2087c98

Now that r96121 has landed, this should not cause compile failures when compiling base/ on the host.

Original comments follow.

Numerous changes, including:
  * Handle trailing dots in LastTwoLabels() as in http://codereview.chromium.org/7518035/ .  Rename this function to LastTwoComponents() to match the terminology used in the RegistryControlledDomainService and elsewhere in Chrome.
  * Since callers are using std::string anyway, make the functions in the header take const std::string& instead of char*.  This also allows doing string operations on them.
  * Use string operations (like find_last_of()) in place of hand-written algorithms, for brevity, clarity, and safety.
  * Avoid "unsigned", which the style guide forbids, and use allowed types like size_t, uint32, or int (depending on the situation).
  * Avoid #define and "using".
  * Use standard algorithms for similar reasons as using string ops.
  * Use file_util functions to significantly abbreviate file reading/writing code.
  * Use wmain() (on Windows) in combination with FilePath to avoid issues if the provided pathname has extended characters that don't flatten losslessly to the default codepage (thanks Darin for pointing out this issue).
  * Avoid casting where possible.  Avoid some casts for printf()-style calls by using a string stream, which also allows for slightly less boilerplate.
  * Convert non-error uses of stderr to the chrome-standard VLOG(1).
  * Correctly handle hostnames with trailing dots in the input file.
  * In general, shorten code where possible.

Because this adds a dependency on base, and ssl_false_start_blacklist_process has the "#host" specifier in net.gyp, bradnelson tells me that base and its dependencies need an explicit "host, target" toolchain list for the Linux builds to work correctly.  It would be nice if we could avoid this but I guess gyp would have to be smarter or something.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7550002

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/7529035

TBR=fischman@chromium.org
Review URL: http://codereview.chromium.org/7587003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96211 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96210 0039d316-1c4b-4281-b951-d872f2087c98

1. improve custom context menus (for all webui pages)
2. make dragged + clicked apps a little larger. They grow when you click 'em.

BUG=92180,92103
TEST=manual

Review URL: http://codereview.chromium.org/7611001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96209 0039d316-1c4b-4281-b951-d872f2087c98