GitLab

Convert WebViewTranslateClient to directly track the
registration with the observed WebState instead of
relying on the deprecated code in WebStateObserver.

Bug: 775684
Change-Id: Ifdf8f2ba5e113f67269d4329500d1693e772eeae
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/768877
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517793}

This change removes the deprecated SetDictionaryWithoutPathExpansion in
the //chromeos directory and replaces it with the new base::Value API.

Bug: 646113
Change-Id: Ia3be13e49959224db93a1dd67408590af780a98e
Reviewed-on: https://chromium-review.googlesource.com/776656
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517792}

Convert SadTabTabHelper to directly track registration
with the observed WebState instead of relying on the
deprecated code in WebStateObserver.

Pass the WebState to SadTabTabHelperTestDelegate to
fix the unit test (as WebStateObserver method web_state
always return nullptr).

Bug: 775684
Change-Id: I7908650e3612645eddf03eb7ea01f88dfba4d395
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/768724
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517791}

Using wpt-import in Chromium 790d985e.
With Chromium commits locally applied on WPT:
23705631 "service worker: Upstream sandboxed iframe test to WPT."


Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/5666

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=lukebjerring

No-Export: true
Change-Id: I85165dbd213aef03b0bd9f2fea81b60d564d6b62
Reviewed-on: https://chromium-review.googlesource.com/778779
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517790}

This patch measures how often getter returns anything
other than non null.

Bug: 695891
Change-Id: I62ea96d6ccf9c0dea0804dcab221e71b55ffca37
Reviewed-on: https://chromium-review.googlesource.com/773520
Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517789}

Add an option to override flags during serialization and use it do
alpha folding for SaveLayer/Draw/Restore during serialization. The
overridden flags will also be used to replace images in shaders.

R=enne@chromium.org

Bug: 758350
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Iff0a9fd81bd9dee9b932dc95e194208e34dc4069
Reviewed-on: https://chromium-review.googlesource.com/777844
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517788}

This change removes the deprecated SetDictionaryWithoutPathExpansion in
the //chrome directory and replaces it with the new base::Value API.

Bug: 646113
Change-Id: Ia951cab83174b7816f99500b50f03ad0980dbfd7
Reviewed-on: https://chromium-review.googlesource.com/775340
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517787}

Provide the hit test wrapper for AtkComponent interface, using
an implementation that is compatible with the one in
BrowserAccessibleAuraLinux.

Bug: 784583
Change-Id: Ie1dcae846db9aabf06e636eaf3054c87d2e8bcc9
Reviewed-on: https://chromium-review.googlesource.com/767428
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517786}

This patch excludes editing adjustment part from
ComputeVisibleSelection() to a function which returns
SelectionTemplate<Strategy> for code health.

We will have ComputeVisibleSelection(passed_selection) {
const SelectionTemplate<Strategy>& xxx_adjusted_selection =
 AdjustSelectionXXX(passed_selection);
const SelectionTemplate<Strategy>& yyy_adjusted_selection =
 AdjustSelectionYYY(xxx_selection);
const SelectionTemplate<Strategy>& zzz_adjusted_selection =
 AdjustSelectionZZZ(yyy_selection);
 return zzz_adjusted_selection.
}

Bug: 775701
Change-Id: I0cb1e34156f3792a1ca67443370f862c2cf268ba
Reviewed-on: https://chromium-review.googlesource.com/749567Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517785}

Updated the test file for Android WebView and ManualTests/
to address http://crbug.com/756965.

This is a reland of 33c9d62c
Original change's description:
> Remove layoutTestController, an alias to testRunner
>
> Bug:
> Change-Id: I5a3cc233bfc3daa96f8fa5258dc2cba0d1740fa1
> Reviewed-on: https://chromium-review.googlesource.com/618432
> Reviewed-by: Mike West <mkwst@chromium.org>
> Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#495525}

Change-Id: I71dd446fcf025cee113593f889e34d9566257728
Bug: 
Reviewed-on: https://chromium-review.googlesource.com/622171
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517784}

Bug: 782487
Change-Id: Ied52b6322d1e66f11ae589256680b48706a62b67
Tbr: jochen@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/778601Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517783}

This CL adds an extra string to the Desktop PWA window title that
denotes which app the window belongs to and the domain of the start URL.
The window title is painted such that the page title will elide first,
followed by the app name then the domain. Further work is required to
maintain this property for all languages.

Bug: 762401
Change-Id: Ibcc697b02fa643df9c2618ca0ef0249c6f887b64
Reviewed-on: https://chromium-review.googlesource.com/768601
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517782}

According to latest specification, DOMString types were updated to
either ByteString or USVString. So this CL changes DOMString with them
based on the updated specification partially, because there are unexpected
test results on getResponseHeader, setRequestHeader, and open functions
when updating. Following CLs will solve them.

Spec: https://xhr.spec.whatwg.org/#the-send()-method
      https://github.com/whatwg/xhr/commit/cea2b9e1187921453434bc245208660edefa4c58
      https://github.com/whatwg/xhr/commit/cbbc56ab2dc5049eb59c69f760038d62b3439cca

Bug: none
Change-Id: I8ed56dcbd5fa0451d82539d50659819fd117b710
Reviewed-on: https://chromium-review.googlesource.com/776516
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517781}

Bug: 786626
Change-Id: I8a5a3d5673f7a1fc57bb87791fb93411ae16adf2
Tbr: qinmin@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/778342Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517780}

From discussion on chromium-dev, it was decided to remove 'chrome'
namespace.

Bug: 289619
Change-Id: Ibc473af04b1e28f59ebcec8a4e1cb5616d4eb8cb
Reviewed-on: https://chromium-review.googlesource.com/771091Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#517779}

LayoutText::CaretMaxOffset() requires clean layout, but currently can be
called from DeleteSelectionCommand when layout is dirty. This patch adds
layout update before the call sites to fix it.

Bug: 781698
Change-Id: I17b7596e93f025d61836e39cca4bf736713d3422
Reviewed-on: https://chromium-review.googlesource.com/778050
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517778}

Bug: 754679
Change-Id: Icabfdc8f753595cd9b586b721ac58c607e7b660d
Tbr: qinmin@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/778646Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517777}

This reverts commit 1e2e99ef.

Reason for revert: Suspected to be the cause of fast/mediastream/MediaStreamTrack-gc-no-crash.html failure

Original change's description:
> Enable video capture service by default on platforms where it is rolling
> out with M61.
> 
> Bug: 721812
> Change-Id: I1de0f625a1fb106e2dea664675e94267e66fc2fd
> Reviewed-on: https://chromium-review.googlesource.com/719416
> Commit-Queue: Christian Fremerey <chfremer@chromium.org>
> Reviewed-by: Emircan Uysaler <emircan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517761}

TBR=emircan@chromium.org,chfremer@chromium.org

Change-Id: Icdb2af1cf68e1774d57c1d8b3c529e86e0a2a48e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 721812
Reviewed-on: https://chromium-review.googlesource.com/778603Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517776}

Made ObserverListBase's iterator and const_iterator the same type. ObserverListBase::iterator doesn't allow to modify the collection anyway. There was no good reason for const_iterator and iterator to be different types. Making them the same type just makes the code simpler.
Inlined ObserverListBase methods.
Removed unnecessary friend declarations.
Removed old MSVC workarounds.

In the end: less code to do exactly the same thing.

Change-Id: I0448a8a52f904635a2e30d094bcc2b48780e4d64
Reviewed-on: https://chromium-review.googlesource.com/773758
Commit-Queue: François Degros <fdegros@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517775}

IsTabSpanElement() checks the 'white-space' style of an element, but
may be called with dirty style, and hence causing crash. This patch
adds a style update in the function to stop the crash.

Bug: 778901, 779527
Change-Id: I0c0d22f1a94ce06abd5fd146421cf00e4dbf6ac1
Reviewed-on: https://chromium-review.googlesource.com/772832Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517774}

This aligns Blink's behavior with Firefox and the Mixed Content spec,
and updates web platform tests accordingly.

Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/x0ROz-Io2bc/B9-sd6_dBwAJ

Bug: 785287
Change-Id: Ic50a23419b95709bab0abd370df6c2e16c3bb7b7
Reviewed-on: https://chromium-review.googlesource.com/771192Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517773}

The construction of offset mapping used to have some hacks to work around the
LayoutText writeback. The hacks are no longer necessary if fragment painting is
enabled.

This patch makes the hacks disabled when fragment painting is enabled, so that
we can remove the hacks easier in the future.

Bug: 699017
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I57e28f32f318d118e8ebe4a89999e3f07a9a806a
Reviewed-on: https://chromium-review.googlesource.com/777964Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517772}

Bug: 761254
Change-Id: I6d85d36bd47b845da8e904f2c2f0999f8b958a70
Reviewed-on: https://chromium-review.googlesource.com/777591Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517771}

Before we would keep same origin navigations in the browser, but that
would mean that navigating from https://www.google.com/ to
https://www.google.com/maps wouldn't open the app.

Now, we compare the app for the current URL with that of the target app
and if they don't match we open the app, otherwise we keep the navigation
in the same context.


Bug: 783487
Change-Id: I0ecafbf006b502f60c665d91b9f3c838a4157dc2
Reviewed-on: https://chromium-review.googlesource.com/778401
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517770}

Bug: 699017
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I4588bad36c3b38e1722bf4b8ef8b33d313cbe1d2
Reviewed-on: https://chromium-review.googlesource.com/777732Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517769}

The event is dispached before OnSurfaceFocusing is invoked, and used by
DataDevice to send selection wayland message.

Bug; 773978
Test: exo_unittests

Change-Id: I2a2edc659e23c381059585d30395c3cfe4304087
Reviewed-on: https://chromium-review.googlesource.com/776534
Commit-Queue: Daichi Hirono <hirono@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517768}

According to the spec [1] we need to include optional components
and add leading zeros if required for timestamp construction.
[1]: https://w3c.github.io/webvtt/#dom-construction-rules

Bug: 786382
Change-Id: I2b7320bd6b187cb3b85a5532c0a0fd398b3888cf
Reviewed-on: https://chromium-review.googlesource.com/773763
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#517767}

This patch moves the atomic inline handling code before the block flow
handling code, so that there is no longer fall through from block flow
to atomic inline.

Bug: 771398
Change-Id: Idb4013e5616a2e81a13f4c6829c3afb2b86faa68
Reviewed-on: https://chromium-review.googlesource.com/775550
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517766}

As a follow up of http://crrev.com/c/765611 and http://crrev.com/c/763029,
this CL removes no-longer-needed SoftwareReleaseCallback, and updates
users of it for OnceCallback migration.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I95df100e141710fbe5fedec4f033e1186475e75e
Reviewed-on: https://chromium-review.googlesource.com/776475
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517765}

This CL adds an argument for listener task runner to IPC::ChannelMojo::
Create{Server,Client} so that we can have more flexible task scheduling.
Now all arguments are base::ThreadTaskRunnerHandle::Get() and this CL
doesn't change the behavior. This CL is just a preparation.

Doc: https://docs.google.com/document/d/1yOhE6-1HLb3aeNWmoa9O2LlnegWjd4awYUn2OhUL4vk/edit#
Change-Id: I2f5c70ff3af499766e7b42de8e33f13dafcefbff
Reviewed-on: https://chromium-review.googlesource.com/756821Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517764}

We want to deprecate ListHashSet in favor of LinkedHashSet. The main
difference between them is that ListHS iterators remain valid after
modification of the container, whereas LinkedHS iterators do not.
These usages of ListHashSet don't rely on iterators remaining valid
after modification, so it's a straightforward replacement.

Bug: 614112
Change-Id: I31839044b2267cd0a9749b1907e6237686909f65
Reviewed-on: https://chromium-review.googlesource.com/778639Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Chris Watkins <watk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517763}

AddKeyEx now takes AuthorizationRequest and AddKeyRequest directly.

Bug: 741274
Change-Id: I200b7bd8255010b51376d15bcff3e190b651fb13
Reviewed-on: https://chromium-review.googlesource.com/776518
Commit-Queue: Maajid <maajid@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517762}

out with M61.

Bug: 721812
Change-Id: I1de0f625a1fb106e2dea664675e94267e66fc2fd
Reviewed-on: https://chromium-review.googlesource.com/719416
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517761}

Bug: 
Change-Id: Ia32d500ba42bdd485f0c35e1a34659332002a162
Reviewed-on: https://chromium-review.googlesource.com/648909
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517760}

Update TestExpectations to mark fetch-request-fallback.https.html
as [ Crash Failure ] rather than [ Crash ].

This is a reland of 0326c088
Original change's description:
> Plumb extra errors from ResourceRequestCompletionStatus to Blink
>
> This patch plumbs CORSError and HTTP response headers
> from ResourceRequestCompletinoStatus to Blink's ResourceError.
>
> Test: ./Tools/Scripts/run-webkit-tests virtual/outofblink-cors
> Bug: 736308
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: I20e4ec9a2e7ca93ce692a5a8312dadf59eb0f345
> Reviewed-on: https://chromium-review.googlesource.com/749024
> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> Reviewed-by: Mike West <mkwst@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517388}

Bug: 736308
Change-Id: I8439662f9363e180839060c5245d2327324d1583
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Tbr: kinuko@chromium.org, tyoshino@chromium.org, yhirano@chromium.org, mkwst@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/778220Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517759}

The "Cookies", "Certificate" and "Site settings" links are all buttons in
Harmony mode, so update the Page Info bubble to match.

Screenshot - https://drive.google.com/open?id=1DdlG3W-a7K5E73PRLCo0u_9cT5I_JYbV

Bug: 535074
Change-Id: I4f715ccae231dbadfdbceee2408753671e17829c
Reviewed-on: https://chromium-review.googlesource.com/754468
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517758}

This CL fixes some comments in permission_context_base.h which are
outdated or incorrect, and moves PermissionDecided from protected to
private.

Change-Id: I62ed3d82f46dc8680656c6072d9e45f4585197dd
Reviewed-on: https://chromium-review.googlesource.com/776493Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517757}

This patch prunes the deprecated function from EditorCommand.cpp, which
is safe because layout is already clean at the call sites, updated
in Editor::Command::Execute() before calling the ExecuteFoo() functions.

Bug: 698633
Change-Id: I011cb5dbc95a8b2a5d2b9289db6610471688094a
Reviewed-on: https://chromium-review.googlesource.com/777476Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517756}

This change should make it easier to make HomeDirMethods completely
pass-through, and eventually the method should live with CryptohomeClient.

Bug: 741274
Change-Id: I478f0de229cda544121fa57de870a6082f603961
Reviewed-on: https://chromium-review.googlesource.com/776533
Commit-Queue: Maajid <maajid@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517755}

This patch makes |LayoutObject::EnclosingNGBlockFlow()| to return |nullptr| if
LayoutNG runtime feature enabled without calling |EnclosingBox())|, which
requires traversing ancestors, for ease of writing LayoutNG enabled code and
improving readability.

Before this patch, we should write:

if (RuntimeEnabledFeatures::LayoutNGEnabled()) {
  if (LayoutBlock* block_flow = EnclosingNGBlockFlow()) {
    ... code for LayoutNG
    return;
  }
}
... code for legacy layout

After this patch, we can write:

if (LayoutBlock* block_flow = EnclosingNGBlockFlow()) {
  ... code for LayoutNG
  return;
}
... code for legacy layout
}

This patch also changes |LayoutInline::DirtyLinesFromChangedChild()| as
demonstration of shorter code and correctness of |EnclosingNGBlockFlow()|
change.

This patch is a preparation of the patch[1].

[1] http://crrev.com/c/768599: [LayoutNG] Make LayoutInline::LinesBoundingBox()
to work with fragments

Change-Id: Ic36f84d3f5a1e65ac432ff0df65fe2449d8830a9
Reviewed-on: https://chromium-review.googlesource.com/776413Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517754}