GitLab

Also, on an unrelated note, change BidirectionalStreamTest base class
from TestWithParam<> to Test, since no parameters are used.

Review-Url: https://codereview.chromium.org/2936663002
Cr-Commit-Position: refs/heads/master@{#478786}

API change to pass GURL by reference.

Bug: 646586
Change-Id: I993cd98e3c8f17ac9fb85c632dcc0d253fcf358a
Reviewed-on: https://chromium-review.googlesource.com/531739Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Mike Baxley <baxley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478785}

Now that we have no DisplayItems and DisplayItemList is holding a
PaintOpBuffer, there are no consumers of cc::ContiguousContainer. The
PaintOpBuffer does a similar job for PaintOps. So we can remove this
class from the codebase.

R=weiliangc@chromium.org

Bug: 671433
Change-Id: Id11741b42bb0a75ab4a6c6db11779773741df2fd
Reviewed-on: https://chromium-review.googlesource.com/531669Reviewed-by: Weiliang Chen <weiliangc@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478784}

This reverts commit 1c7e3e09.

Breaks PhoneSimulator and TabletSimulator bots:

Failed steps failed ios_chrome_integration_egtests (iphone 5 ios 10.0) on mac failed ios_chrome_settings_egtests (iphone 5 ios 10.0) on mac failed ios_chrome_ui_egtests (iphone 5 ios 10.0) on mac failed ios_chrome_external_url_egtests (iphone 5 ios 10.0) on mac failed ios_internal_chrome_external_url_egtests (iphone 5 ios 10.0) on mac failed failure reason

[0612/124347.435892:FATAL:browser_view_controller.mm(995)] Check failed: _isShutdown. -shutdown must be called before dealloc.

TBR=sdefresne@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2930363003
Cr-Commit-Position: refs/heads/master@{#478783}

Today we pass in both |requires_secure_codec| and
|require_software_codec| which may cotradict with each other given
secure codecs are all hardware codecs. Add an enum to avoid this issue.

Also fixes a bug where if both |requires_secure_codec| and
|require_software_codec| are true, we would still create a secure (and
hence hardware) codec which may hang the GPU process. In this case, we
should just fail to create the codec.

BUG=459414

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Icd8a403fe5a63b68cfe4045da7057be64ea9de66
Reviewed-on: https://chromium-review.googlesource.com/530098Reviewed-by: Chris Watkins <watk@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478782}

Revert of Move ObjectContentType entirely to HTMLPlugInElement (patchset #2 id:20001 of https://codereview.chromium.org/2927703003/ )

Reason for revert:
Looks like schenney's unavailable at the moment; speculatively reverting for layout test virtual/new-remote-playback-pipeline/media/controls/controls-cast-overlay-slow-fade.html failures (e.g. https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/57955)

Original issue's description:
> Move ObjectContentType entirely to HTMLPlugInElement
>
> There's no need to go to LocalFrameClientImpl to determine how to load
> a plugin element, that was a purely pre-blink necessity.
>
> Simplify a bunch of logic around HTMLPlugInElement to assume that url_
> and service_type_ are always set and correct by the time the
> ObjectContentType is being determined.
>
> BUG=
>
> Review-Url: https://codereview.chromium.org/2927703003
> Cr-Commit-Position: refs/heads/master@{#478683}
> Committed: https://chromium.googlesource.com/chromium/src/+/2718186cc8ac74b38b9a7304764642f05c76bb81

TBR=schenney@chromium.org,japhet@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2933213002
Cr-Commit-Position: refs/heads/master@{#478781}

In ScriptContext::OnResponseReceived(), instead of immediately executing
JS, request execution. This means we don't receive a result from the
execution. According to comments,

// In debug, the js will validate the callback parameters and return a
// string if a validation error has occured.

This appears to have been true at some point [1], but some time in the
last seven years, has been updated to no longer be the case. As such,
just remove any reference to the result value.

[1] https://chromium.googlesource.com/chromium/src/+/5c21a2eeaa92326a6a771e27c70b11b1ea52441a/chrome/renderer/resources/extension_process_bindings.js#114

BUG=629431

Review-Url: https://codereview.chromium.org/2932913004
Cr-Commit-Position: refs/heads/master@{#478780}

A Lazy(Sequenced|SingleThread|COMSTA)TaskRunner lazily creates a TaskRunner.

A Lazy(Sequenced|SingleThread|COMSTA)TaskRunner is meant to be instantiated in
an anonymous namespace and used to post tasks to the same sequence/thread
from pieces of code that don't have a better way of sharing a TaskRunner.
Adding a Lazy(Sequenced|SingleThread|COMSTA)TaskRunner to an anonymous
namespace doesn't generate a static initializer.

Bug: 730170
Change-Id: Idb35cfe9a5ca5501b7057d7b90b9df3f702faff1
Reviewed-on: https://chromium-review.googlesource.com/524141
Commit-Queue: Francois Doray <fdoray@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478779}

Right now, NotificationsNativeHandler::GetNotificationImageSizes()
builds a DictionaryValue and then passes that to V8ValueConverter to
convert it to a v8::Object. Instead, we can use gin::DataObjectBuilder,
which should be faster (since it's much more lightweight, and doesn't
require setting up a DictionaryValue we won't use - not to mention
fewer heap allocations).

BUG=None

Review-Url: https://codereview.chromium.org/2937543002
Cr-Commit-Position: refs/heads/master@{#478778}

This patch prevent hover state change for touch event on mobile.

We have 2 checks for this:
1. Event is from touch.
2. Viewport enabled (on mobile).
3. Page with viewport meta.

TESTS:
Review-Url: https://codereview.chromium.org/2931433002
Cr-Commit-Position: refs/heads/master@{#478777}

Calling start() or stop() with negative time values should throw
RangeError, not InvalidAccessError.  This also includes the offset and
duration parameters for AudioBufferSourceNode.start().

constant-source-basic.html,
oscillator-basic.html

Bug: 731242
Test: audiobuffersource-basic.html,
Change-Id: Ide02d22a66712ba46aa1f0007c71ae24e78b88fe
Reviewed-on: https://chromium-review.googlesource.com/528479Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478776}

After crrev.com/478051 It2Me host expects to get IceConfig from
the webapp. The config is used to connect to TURN servers when using
WebRTC. This CL updates the webapp to fetch IceConfig from the server
and pass it to the host.

Change-Id: I194f3602fad9bdd3445d843860a585a739187de2
Reviewed-on: https://chromium-review.googlesource.com/530446
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478775}

This patch introduces a separate code path for browser side navigation. Instead of
using pending and current, we keep track of a single RenderFrameHostImpl instance via
standard WebContentsObserver notifications.

While any navigations are active (determined by the navigation_handles_ set), we put messages
to suspended_messages_ instead of sending them to the renderer, resuming once navigations
commit to a specific RenderFrameHostImpl instance.

While navigation is not active, we send messages to renderer and put them to
waiting_for_response_messages_, which are exactly the messages received after last
state cookie update (see DevToolsMessageChunkProcessor).

BUG=727517
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2927983004
Cr-Commit-Position: refs/heads/master@{#478774}

This is required otherwise the second include in any component will
trigger multiply defined symbol errors.

BUG=708303

Change-Id: I857cb001f3310a4c35e24768e0fbbd25d6ec22a3
Reviewed-on: https://chromium-review.googlesource.com/531802Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478773}

The V4UsageStatus is a desktop-specific check, because Android is already
shipped with V4.

Additionally, this exposed an issue with our implementation when there
is a remote db: synchronous failure (e.g. when visiting chrome:// urls)
cause our db client to cancel a non-existent request in its destructor.

This is easily fixed by marking request_complete_ in that code path.

Another small (but important!) fix is that the Android check for the
subresource filter also includes the phishing list.

Bug: 609747
Change-Id: I477361117380fcb7e14b30a677b24c5d41027e1c
Reviewed-on: https://chromium-review.googlesource.com/528393Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478772}

marked as broken, mark the session as going away.

BUG=731303

Review-Url: https://codereview.chromium.org/2933773002
Cr-Commit-Position: refs/heads/master@{#478771}

BUG=chromium:720002

Review-Url: https://codereview.chromium.org/2933173002
Cr-Commit-Position: refs/heads/master@{#478770}

RTCVideoEncoder.SupportsNativeHandle() means it can handle frames of
type kNative, which in Chromium represents wrapped media::VideoFrames.

Also, before accessing I420 data, i.e. DataY/U/V or StrideY/U/V, the
function ToI420 should be called on webrtc::VideoFrameBuffer (these
I420 functions will be removed from webrtc::VideoFrameBuffer soon).

BUG=732345,732418

Review-Url: https://codereview.chromium.org/2939493002
Cr-Commit-Position: refs/heads/master@{#478769}

This fully removes trust in WoSign and StartCom, as announced at https://security.googleblog.com/2016/10/distrusting-wosign-and-startcom.html

BUG=731838

Review-Url: https://codereview.chromium.org/2927383002
Cr-Commit-Position: refs/heads/master@{#478768}

Adds the Night Light automatic schedule settings.

Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=705816#c15

BUG=705816
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2915753003
Cr-Commit-Position: refs/heads/master@{#478767}

A world with the display compositor in the GPU process is a world
without GpuProcessTransportFactory and ImageTransportFactory.
ImageTransportFactory is a singleton. This CL makes FrameSinkManagerHost
owned by BrowserMainLoop that can be accessed from both content/ and ui/
and does not depend on ImageTransportFactory/GpuProcessTransportFactory.

BUG=730193

Review-Url: https://codereview.chromium.org/2932893002
Cr-Commit-Position: refs/heads/master@{#478766}

The new functions process individual quads into overlays or underlays.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2931833005
Cr-Commit-Position: refs/heads/master@{#478765}

Before: info menu item shows when user clear edit text in search mode
Now: info menu item does not show in search mode

BUG=732516

Review-Url: https://codereview.chromium.org/2939523002
Cr-Commit-Position: refs/heads/master@{#478764}

- Voice interaction keyboard shortcut should bring up voice interaction
  value prop screen if voice interaction is disabled.
- If playstore is already set up, start voice interaction setup wizard.
- Otherwise show playstore terms, and start voice interaction setup
  wizard afterwards if user accept.

BUG=b/38263948

Review-Url: https://codereview.chromium.org/2929963002
Cr-Commit-Position: refs/heads/master@{#478763}

This allows FontBuilder to work without a Document, as it was designed
to.

Bug: 730692
Change-Id: I43d3a67a2565ca7b4c199685f5c2b0bdcc42b79d
Reviewed-on: https://chromium-review.googlesource.com/531666Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Rune Lillesveen <rune@opera.com>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478762}

Add a counter to see how often we successfully resolve hostnames, tracking
whether or not |net::IsValidHostLabelCharacter| returns true for all characters
in all labels in the name.

BUG=695474

Review-Url: https://codereview.chromium.org/2921553002
Cr-Commit-Position: refs/heads/master@{#478761}

This is a new version of the benchmark used to find memory leaks in the
browser process.

The browser process stay alive for the whole duration of the benchmark.
A memory dump using memory-infra is periodically taken.
An external diff tool is used to find remaining objects allocated between
two memory dumps.

see:
  https://docs.google.com/a/google.com/document/d/1ULZRYBElYmBDGswF3f4yYpl77SD9sa0RgFNfl1FueWU/edit?usp=sharing
  https://codereview.chromium.org/2906113002/

CC: erikchen@chromium.org
R: perezju@chromium.org, primiano@chromium.org
Bug: 705656
Change-Id: I697892a6df881d19e3aace5a44e8a395717767c0
Reviewed-on: https://chromium-review.googlesource.com/530527Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478760}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/de09009b..c7d2d216

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2935803002
Cr-Commit-Position: refs/heads/master@{#478759}

This CL primarily adds test support code; the password view is still
WIP.

BUG=719015

Review-Url: https://codereview.chromium.org/2896533002
Cr-Commit-Position: refs/heads/master@{#478758}

WebApkSandboxedProcessService accesses ChildProcessServiceImpl (which is
in content) through reflection and needs to be exposed to WebAPK.
Introducting a new chrome class that exposes this and forwards to
ChildProcessServiceImpl.
This also prepares for the move of ChildProcessServiceImpl to base where
more work will need to be done when creating a ChildProcessServiceImpl.

BUG=702316

Change-Id: Ib70f72c430a8a48b8ee84db5c6359f4c6f6dddfb
Reviewed-on: https://chromium-review.googlesource.com/528669Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478757}

When an entry on the history page is deleted, we create history
deletion directives that are sent through sync. These are required to
support offline history deletions, and make sure these are properly
propagated. However, these deletion directives rely on exact matches in
timestamps, which are in microseconds since the epoch.

The History page on Android converted microsecond timestamps to
millisecond timestamps for Java compatibility, but when these
timestamps were handed to the logic that created history deletion
directives, they were now slightly off. This change simply plumbs
through microsecond timestamps through the java code and back.

BUG=729020

Review-Url: https://codereview.chromium.org/2935783002
Cr-Commit-Position: refs/heads/master@{#478756}

I'm adding support in Chrome for the Android spellcheck menu in
https://codereview.chromium.org/2931443003. When a user taps on a misspelled
word, I need to highlight the word in a color based on the color of the
spellcheck underline (we add some transparency). We're trying to avoid
hard-coding the spellcheck color in editing code. Therefore, we think it makes
sense to move the colors for spelling/grammar markers out of
InlineTextBoxPainter into LayoutTheme, so other code can make use of them.

BUG=715365
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2932913002
Cr-Commit-Position: refs/heads/master@{#478755}

Add a section about binary size sheriffing.

Bug: None
Change-Id: I1bca09d9c3148395c896b406ecbb9bff217988a7
Reviewed-on: https://chromium-review.googlesource.com/531565
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478754}

This CL:

1) Set page count to unknown for PrintDocumentInfo in onLayout
stage since we don't need to report pages count of a file. Android
framework will get page count from the file produced from onWrite
stage. This change will fix crbug/593387.

2) Removed printing jobs started from onLayout. We don't need to
report pages count of the file at that stage, hence no need to
start printing jobs from onLayout. As a replacement, starting all
printing jobs from onWrite. It is related to crbug/612315, but
crbug/612315 is not really true about saving file generating time
since we didn't generate a file twice.

3) With other cleanup because variables such as mLastKnownMaxPages
is not useful anymore.

Bug: 593387, 612315
Change-Id: Ic52d9aa12b4aeb659156e1e2eb21f2f11afbd60c
Reviewed-on: https://chromium-review.googlesource.com/521205
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478753}

BUG=672225
R=skym@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2920853004
Cr-Commit-Position: refs/heads/master@{#478752}

Include host IP address and port and net_error for requests in callbacks for PageLoadMetricsObservers

Currently, the ChromeResourceDispatcherHostDelegate does not pass a request's host IP address and port or network error status to the MetricsWebContentsObserver for use by PageLoadMetricsObservers. We are trying to write an observer that examines local network requests from non-local pages and would need the host IP address and port and error status to collect our metrics. The GURL object passed to the MetricsWebContentsObserver contains the hostname as a domain name, but the domain name is insufficient for distinguishing between local network and public requests without additional network calls to a DNS server. The host IP address and error status information we pass could also potentially be useful for other page load metrics observers.

This CL refactors ChromeResourceDispatcherHostDelegate, MetricsWebContentsObserver, and PageLoadMetricsObserver::ExtraRequestCompleteInfo to include the HostPortPair for the hostname and port for completed requests. The hostname and port for completed requests are taken from URLRequest.GetSocketAddress() if the request was successful, and from URLRequest::GetRemoteEndpoint if URLRequest::GetSocketAddress returns an empty value, which can happen if the request failed or was canceled.

This CL also updates all unit tests and test harnesses that create mock ExtraRequestCompleteInfo objects and/or invoke the request complete callbacks in ChromeResourceDispatcherHostDelegate or MetricsWebContentsObserver.

BUG=

Change-Id: I56be75c23cba543ff82f16e639676e5e112c61a8
Reviewed-on: https://chromium-review.googlesource.com/526478
Commit-Queue: U Thakore <uthakore@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478751}

To fix base_unittests in
https://build.chromium.org/p/chromium.fyi/builders/Fuchsia%20(dbg)

Bug: 706592
Change-Id: I22a305103dc54f2a5fde3e4d8e903db1586d8941
Reviewed-on: https://chromium-review.googlesource.com/528542Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478750}

LayerTreeHost didn't keep track of the number of surface layers for each
SurfaceId. When there are multiple SurfaceLayers for the same SurfaceId
both SurfaceLayerIds() and needs_surface_ids_sync() were potentially
wrong.

Make LayerTreeHost track the number of layers for each SurfaceId. Also
add tests for this case.

Bug: 731263
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ifd6efe1b02c9ec4f728490b4487756b5319b681f
Reviewed-on: https://chromium-review.googlesource.com/529566Reviewed-by: enne <enne@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478749}

This will need to be reimplemented later using
__sanitizer_cov_trace_pc_guard.

BUG=728684,729822

Change-Id: I1f979b3ceac8a59e27f96428b77ec1d983ac4cef
Reviewed-on: https://chromium-review.googlesource.com/529972Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Oliver Chang <ochang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478748}

Bug: 728324
Change-Id: Id007d43ea6468ce3ed8601c4e848861c224ef578
Reviewed-on: https://chromium-review.googlesource.com/529684
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478747}