- 21 Jan, 2020 40 commits
-
-
Thiemo Nagel authored
This reverts commit 0fde9a92. Reason for revert: Test breakage in * virtual/scalefactor200withzoom/fast/hidpi/static/validation-bubble-appearance-hidpi.html * virtual/scalefactor150/fast/hidpi/static/validation-bubble-appearance-hidpi.html at https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29 Original change's description: > Revert "Fix 0,0-0x0 turning into PaintOp::kUnsetRect." > > This reverts commit 0156c949. > > Reason for revert: series of review fixes resulted in a no-op code. The completely different approach should be used to fix the bug correctly. > > Original change's description: > > Fix 0,0-0x0 turning into PaintOp::kUnsetRect. > > > > When a paint chunk having 0,0-0x0 rect is processed inside an effect, an early > > return prevents the effect_bounds_stack_.back() update in a > > ConversionContext::UpdateEffectBounds call. This results in keeping default > > PaintOp::kUnsetRect in SaveLayerOp::bounds instead of 0,0-0x0 rect. > > > > This is probably a reason for a related bug 918240 (see bug thread Comment 4 for > > details). Application of this patch fixes the lagging print preview. > > > > R=fmalita@chromium.org, samans@chromium.org > > > > Bug: 918240 > > Change-Id: I022ae01418e83184421cff7e22566228a2f7c6d3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1396958 > > Commit-Queue: Denis Bessonov <dbessonov@yandex-team.ru> > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#714293} > > Bug: 918240 > Change-Id: I89a55d39a53559b37168b91adf3f331dbbf8b106 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007409 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Auto-Submit: Denis Bessonov <dbessonov@yandex-team.ru> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733491} TBR=wangxianzhu@chromium.org,pdr@chromium.org,dbessonov@yandex-team.ru Change-Id: If99b75af33c3a00f64eec91b4c711879f3665ce0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 918240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011843Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#733558}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0fee6ccc2e6e..f2ed2482a449 git log 0fee6ccc2e6e..f2ed2482a449 --date=short --first-parent --format='%ad %ae %s' 2020-01-21 cwallez@chromium.org Reorder wgpu::BackendType to match webgpu.h Created with: gclient setdep -r src/third_party/dawn@f2ed2482a449 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I0db157191236ca75077dfdf2ab122dbfe3356674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011449Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733557}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c9d4207d. With Chromium commits locally applied on WPT: 0f8fd66b "[WPT/common/security-features] Support sub projects and split referrer-policy 4K tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ieb254fd9e1cac234fdf4b2ef99a111c0fbd60c3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011661Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733556}
-
Maya Lekova authored
Also reorder the experiments so that Enabled is first and gets tested by the perf bots and the waterfall. Fixes the field trial config as required for cl/285382195 Bug: chromium:1031988 Change-Id: I824a4ef052d694e790e8261377ff920ea49ef2f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010843Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#733555}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d53a082f1e62..08a04042c18c Created with: gclient setdep -r src-internal@08a04042c18c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I697fafe210400222161ff5906f2818567d9c3a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011447Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733554}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=pkl@chromium.org Bug: 1042208 Change-Id: Ie8a877a9f2a073e891ce7da50d6d517756a7c5da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010766 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#733553}
-
Eric Willigers authored
Previously, Label would only update colors in response to theme changes if the text_style was STYLE_PRIMARY. CustomTabBarView now uses CONTEXT_LABEL for the title and the origin. As the origin has STYLE_SECONDARY, this causes the origin to be faded relative to the title. Screen shots before and after: https://docs.google.com/document/d/1YRuzw0Bh9IyjmbtwBa0NpwNvu7ttbMM8mdRF0K3YWzc/edit?usp=sharing Bug: 1033298 Change-Id: Iff4dbc7dfe611cd4c3a38da0b39fc790dae29bcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010757 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#733552}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=msarda@chromium.org Bug: 1042208 Change-Id: I0c94aaa09f0e3c9b949e76f001fda36c8aa0b7ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007462 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#733551}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bf7181f7..056f1769 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I24fc4ef32eb973dd3a2a6fd98a1c9ff432389d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011660Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733550}
-
Sylvain Defresne authored
The provider are not permitted to have dependency on //ios/chrome, however they were able to forward-declare ChromeBrowserProvider so they ended up with indirect dependency. To allow moving the class to the global namespace, allow them to include the forwarding header since this does not increase the amount of "bad" dependency. This is a reland of https://crrev.com/c/2010796 with the correct path (sorry for the spam). Bug: 1042208, 1043657 Change-Id: I9abe0f492ab1ff86ca095dc22beb437459e8e239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010984 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#733549}
-
Jan Wilken Dörrie authored
This reverts commit 28376809. Reason for revert: This change addresses the compilation error. Original change's description: > Revert "[base] Migrate PostTaskAndReplyWithResult to OnceCallbacks" > > This reverts commit 0593d72b. > > Reason for revert: Compiles failing, examples: > https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/1791 > https://ci.chromium.org/p/chrome/builders/ci/win32-builder-perf/148062 > > Looks mostly like ifdefed callsites that weren't migrated. > > Original change's description: > > [base] Migrate PostTaskAndReplyWithResult to OnceCallbacks > > > > This change migrates users of base::PostTaskAndReplyWithResult to > > use base::OnceCallbacks. This allows removing the CallbackType template > > from the API, making sure future users are required to use OnceCallbacks. > > > > TBR=danakj > > > > Bug: 714018 > > Change-Id: I8453c351e406a98fc8b9fddce2637331fdbbf5c4 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965664 > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > > Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org> > > Reviewed-by: danakj <danakj@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#732403} > > TBR=lambroslambrou@chromium.org,danakj@chromium.org,jdoerrie@chromium.org > > Change-Id: I9a417e1d289c750f5ce5e1f43972bf09c0b23e4f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 714018 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004968 > Reviewed-by: Leonard Grey <lgrey@chromium.org> > Commit-Queue: Leonard Grey <lgrey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732414} TBR=lambroslambrou@chromium.org,danakj@chromium.org,lgrey@chromium.org,jdoerrie@chromium.org Change-Id: I7cfc4ef768e4020e4d87300f7e8b57cdfff05fb3 Bug: 714018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005028Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#733548}
-
Eriko Kurimoto authored
This change is still behind the flag. Bug: 824646 Change-Id: I8a82c9b1fe499c4cf8ba182c308054c5dc9e5d0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009598 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#733547}
-
Isabella Scalzi authored
As mentioned in CL:2010236 we should avoid race conditions when setting file tasks of an entry. Only save tasks for an entry once the Quick View content panel has been successfully updated. Test: covered by existing tests Bug: 1038799 Change-Id: I46697284d9d0690aa66a760a27da3b82caef5b94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011584Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#733546}
-
Mirko Bonadei authored
The old binary will be removed in favor of binaries that don't violate package boundaries. Bug: webrtc:11289 Change-Id: I338dc11a98dbe3c7c892b056aa9f82069280c02a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010981Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#733545}
-
Rachel Sugrono authored
Add a helper that opens Quick View in check-select mode. This helper verifies that the given file names matches the selected files. Bug: 1038799 Change-Id: I5915404725adf6a75c82a193362caa1dd1426990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011587 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/992e227af7f1..e07936314c2b git log 992e227af7f1..e07936314c2b --date=short --first-parent --format='%ad %ae %s' 2020-01-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 579c59400f86..845a09b8241e (4 commits) Created with: gclient setdep -r src/third_party/skia@e07936314c2b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC benjaminwagner@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: benjaminwagner@google.com Change-Id: I0fd9c5f39d6d80bf926432df031d2c0d603e4725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010055Reviewed-by:
-
Kenichi Ishibashi authored
The purpose of this change is to have a single point of creating ServiceWorkerRegistration. This way, * We can hide NewRegistrationId() inside ServiceWorkerRegistry. This is useful because we plan to move id management into the Storage Service and we don't want to expose it other than ServiceWorkerRegistry. * ServiceWorkerRegistry can track all live registrations. In subsequent CLs we plan to hook ServiceWorkerRegistration creation so that ServiceWorkerRegistry can detect if the registration is stored or not. Bug: 1039200 Change-Id: Ieeeb4c3b156488de8fe6a527515ec23998c5ea3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010599 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Alexandre Courbot authored
Avoid creating a NativePixmapHandle now that we have one ready to be used. This code was a remainder from the time where we passed dmabuf FDs to CreateGLImage(). BUG=b:146842214 TEST=E2E video playback in Chromium working on Kukui and Kevin. Change-Id: Icf54bacc0d62d9ca74d69174227ec7a1511aa4aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010589 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#733541}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dc9588f19d70..d53a082f1e62 Created with: gclient setdep -r src-internal@d53a082f1e62 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I1fa2a0f610d97371eb781970185d55de49a5dfa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011600Reviewed-by:
-
Alexandre Courbot authored
The size of the EGL image is supposed to be the visible size, while the buffer itself shall be imported with its own coded size and stride. Before crrev.com/c/1982499, we did not pass any size information with the buffer, so as a workaround the size was set to the coded size and the buffer imported with its coded size into the GPU or DC, which resulted in visible green lines on the right or lower end of the image when coded_size != visible_size. Now that we are importing the buffer using a NativePixmapHandle, we can set the EGL image to be the correct visible size. BUG=b:141579960 TEST=240p h.264 video plays in Youtube web without visible green line on Hana. Change-Id: Ia7631998b7e47c5f8d1001b26e5a154fdffebcb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010588 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
-
Greg Thompson authored
BUG=1023080 R=ganesh@chromium.org Change-Id: I4fd2e2c2fc7365f1977221e99993cea870d587be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007766 Commit-Queue: S. Ganesh <ganesh@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#733538}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=mastiz@chromium.org Bug: 1042208 Change-Id: If00ecce091d5f71b8d55e7197d71b5ed75e70727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007641 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#733537}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/71b8b765a231..992e227af7f1 git log 71b8b765a231..992e227af7f1 --date=short --first-parent --format='%ad %ae %s' 2020-01-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 6c56a01a..4c751358 (270 commits) Created with: gclient setdep -r src/third_party/skia@992e227af7f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC benjaminwagner@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: benjaminwagner@google.com Change-Id: Ib61686a1744b9c3ff81787282d5fa728b1446230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011366Reviewed-by:
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=dvallet@chromium.org Bug: 1042208 Change-Id: Ic014ac6c3dc2cdaec2cbf7a088a32d7d6ce529f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007423 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Commit-Queue: David Vallet <dvallet@chromium.org> Cr-Commit-Position: refs/heads/master@{#733535}
-
Imranur Rahman authored
and FFTFrame::ImagData(). FFTFrame::RealData() and FFTFrame::ImagData() previously return raw float* to the underlying arrays. But only the FFTFrame knows the how long the arrays are. Now we are returning the AudioFloatArray, so the caller can check lengths appropriately. Bug: 966128 Change-Id: I3829eaea1fcc15c4c4dabf706716ba38c7c7e278 Signed-off-by:
Imranur Rahman <i.rahman@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844914Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#733534}
-
Shakti Sahu authored
Updated flag expiration milestones for two experiments 1 - download-auto-resumption-native 2 - enable-new-download-backend Change-Id: If5ab4573e06843767f8387e5cea95d218dc84ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008625Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#733533}
-
Rakina Zata Amni authored
This test is flaky on the Mac10.11 builder. TBR=connily@chromium.org Bug: 1043554 Change-Id: Ib169231bc9deb1b54b64c167ab3d183331736f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011470Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#733532}
-
David Munro authored
Users are presented (currently behind a flag) with an extra screen to choose their disk size when installing Crostini. As part of this change all Crostini disks will now be preallocated fixed-size disks whereas before they'd be sparsely-allocated automatically-sized (more convenient but with a chance of data corruption). Bug: chromium:858815 Test: Unit, Manual (with and without flag) Cq-Depend: chromium:2004184 Change-Id: Iff0a2d1f064628968bda3d84e79706887e4b5760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004185Reviewed-by:
David Munro <davidmunro@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: David Munro <davidmunro@google.com> Auto-Submit: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#733531}
-
Chris Davis authored
Move the location of the FreeLibrary call to after the LocalFree of the string returned from CommandLineToArgvW to remove noise from AppVerifier. Bug: 1043533 Change-Id: I4d32ebdd274cbdd1d081d711ba849bbc8cc55323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010065Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Cliff Smolinsky <cliffsmo@microsoft.com> Commit-Queue: Chris Davis <chrdavis@microsoft.com> Cr-Commit-Position: refs/heads/master@{#733530}
-
nancy authored
BUG=1038487 Change-Id: I0b6239c3fb2361fc25b6990f2529a1c1ec8025e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010231 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
Chris Davis authored
leaked. This change fixes a leak of a IWSCProduct instance in FillAntiVirusProductsFromWSC. Bug: 1043532 Change-Id: I3c501f833b5a37b240c6de0350f6d304a2a34f40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009382Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Chris Davis <chrdavis@microsoft.com> Cr-Commit-Position: refs/heads/master@{#733528}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=amoylan@chromium.org Bug: 1041419 Change-Id: I74c66ddca81f15a70cbd52643a9ee6817181c0dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998577 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#733527}
-
Alexander Dunaev authored
This CL is purely a beautifying one, no changes to any logic are done. Bug: 1014860 Change-Id: I6e2aa1fd125cafea70bfdcac0a077268ef4baefb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011224 Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#733526}
-
nancy authored
Add Shelf menu items for Crostini in AppService: https://cs.chromium.org/chromium/src/chrome/browser/ui/ash/launcher/crostini_shelf_context_menu.cc?l=55 Update the menu related interface to add display id, because Crostini ueses display id for UI scaling menu items. BUG=1038487 Change-Id: Ifd9c711dcbec5e7345178339c29f6c8436970e9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010603 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
Takashi Sakamoto authored
Change-Id: I2da825079e801a7e983eae65ad39333feb41bfda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000407 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#733524}
-
Takashi Toyoshima authored
Some TAO tests do not work with Blink CORS, and virtual tests running them should also do not work. NOTRY=true Bug: 1042580 Change-Id: Id31c4633e61837af2012ae8b2837d17bd362bdc7 TBR: npm@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011471Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#733523}
-
nancy authored
The OPTIONS menu item is not added for menu in Shelf, and it is available for Chrome apps menu item in app list only. So add a menu type checking for it. BUG=1038487 Change-Id: If36587f33cc7cba886ab67509d59a4b6f4dc7963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010605Reviewed-by:
-
Kent Tamura authored
file-input-disabled.html is merged into the new test. Bug: 1040828 Change-Id: I3eeca8ff9f44011f0efb023ee15f1a13463967ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011463Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#733521}
-
Kent Tamura authored
They are merged into FileInputType::UpdateView(). This CL has no behavior changes. Bug: 1040828 Change-Id: Ie08598ce562842eee02b15575bcf278c4ce58b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011464Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/03acc60fb5fc..8265f5d3dc2a git log 03acc60fb5fc..8265f5d3dc2a --date=short --first-parent --format='%ad %ae %s' 2020-01-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@8265f5d3dc2a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I02dbc38d07ff73347582fe805388ee3b30291e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011446Reviewed-by:
-
