GitLab

Allow the Chrome-internal bookmarks manager extensions to specify
the chrome_settings_overrides manifest key in all channels, so that
they can use the bookmarks_ui subkey. Specifying subkey channels in
manifest_features.json would be better, but this is not fully supported
yet.

BUG=333362
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/134843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244279 0039d316-1c4b-4281-b951-d872f2087c98

Causing webkit_unit_tests to fail.

> base: Fix registering of memory pressure listeners used when emulating discardable memory.
> 
> Memory pressure listeners need to be created on a thread with a message
> loop current. Discardable memory is often used on worker threads that
> don't have a message loop and with the current system where listeners
> are registered on first use, the result is that we're most likely never
> notified of memory pressure.
> 
> This adds a function to the discardable memory interface that allows us
> to register memory pressure listeners on a thread, and at a time, when
> we know a message loop is current.
> 
> BUG=332570
> TBR=jamesr@chromium.org
> 
> Review URL: https://codereview.chromium.org/129963002

TBR=reveman@chromium.org

Review URL: https://codereview.chromium.org/135113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244278 0039d316-1c4b-4281-b951-d872f2087c98

A recent version of Clang warned about this:

  ../../ash/system/user/tray_user.cc:1055:20: error: field 'listener_' is uninitialized when used here [-Werror,-Wuninitialized]
      : CustomButton(listener_),
                     ^
BUG=323668
R=jennyz@chromium.org

Review URL: https://codereview.chromium.org/133743004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244277 0039d316-1c4b-4281-b951-d872f2087c98

R=vadimt@chromium.org

Review URL: https://codereview.chromium.org/134513004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244275 0039d316-1c4b-4281-b951-d872f2087c98

> IndexedDBFactory now ForceCloses databases.
> 
> Also, IndexedDBContextImpl used to maintain a map of open
> connections. This change also deletes this map, and instead
> relies on one which already exists in IndexedDBFactory.
> 
> BUG=259564
> 
> Review URL: https://codereview.chromium.org/93873017

TBR=cmumford@chromium.org

Review URL: https://codereview.chromium.org/134503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244273 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244272 0039d316-1c4b-4281-b951-d872f2087c98

Roll passed all of the trybots (see
https://codereview.chromium.org/134273002). Dcommitting due
to CQ slowness.

BUG=none
TBR=tdanderson@chromium.org

Review URL: https://codereview.chromium.org/134423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244271 0039d316-1c4b-4281-b951-d872f2087c98

Modifying attributes on webview prior to attaching the internal_ to <webview>
would throw a javascript error. This CL addresses this.

BUG=333302

Review URL: https://codereview.chromium.org/134393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244270 0039d316-1c4b-4281-b951-d872f2087c98

Adding this parameter lets the same object act as an observer for multiple
RenderFrames.

BUG=329618
TEST=unit,trybot

Review URL: https://codereview.chromium.org/134183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244269 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/133383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244268 0039d316-1c4b-4281-b951-d872f2087c98

This implements both fchdir and adds an absolute path to the
Descriptor_t struct.  Typically on Linux systems this information can be
obtained by querying the /proc file system, but in absence of that, we
can track it ourselves.  For pipes and sockets, the path is the empty
string.

By enabling this behavior, fchdir can also be implemented.  This also
returns expected errno values from fchdir.  This opens up the ability to
do relative path operations like openat.  While these currently can be
executed in user code in a race condition prone way, they could be moved
into the KernelProxy, where the absolute paths can be both accessed and
resolved with AcquireHandleAndPath.

R=binji@chromium.org, sbc@chromium.org
BUG=

Review URL: https://codereview.chromium.org/99203014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244267 0039d316-1c4b-4281-b951-d872f2087c98

> [Android] Enable lint warnings by default.
> 
> Lint has been running on FYI bots for a while,
> time to enable them by default on bots and for developers.
> 
> BUG=None
> R=yfriedman@chromium.org
> 
> Review URL: https://codereview.chromium.org/127383002

TBR=frankf@chromium.org

Review URL: https://codereview.chromium.org/134923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244266 0039d316-1c4b-4281-b951-d872f2087c98

BUG=304341
R=jam@chromium.org

Review URL: https://codereview.chromium.org/129813006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244265 0039d316-1c4b-4281-b951-d872f2087c98

TBR=torne@chromium.org

Review URL: https://codereview.chromium.org/134483004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244264 0039d316-1c4b-4281-b951-d872f2087c98

deterministic.

An uninitialized member variable was at fault.

R=thakis@chromium.org

Review URL: https://codereview.chromium.org/131933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244260 0039d316-1c4b-4281-b951-d872f2087c98

BUG=284553
TEST=none due to that this is a tool
R=fgorski@chromium.org, zea@chromium.org

Review URL: https://codereview.chromium.org/132193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244259 0039d316-1c4b-4281-b951-d872f2087c98

Lint has been running on FYI bots for a while,
time to enable them by default on bots and for developers.

BUG=None
R=yfriedman@chromium.org

Review URL: https://codereview.chromium.org/127383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244256 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/134203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244255 0039d316-1c4b-4281-b951-d872f2087c98

Replace content::InputEvent usage with blink::WebInputEvent usage in synthetic
gesture dispatch.  This affords the SyntheticGestureTarget a chance to generate
the necessary ui::LatencyInfo components prior to event dispatch, simplifying
the hooks necessary for telemetry and easing the burden on the gesture dispatch
caller.

BUG=246034

Review URL: https://codereview.chromium.org/134123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244254 0039d316-1c4b-4281-b951-d872f2087c98

BUG=328742
R=skuhne@chromium.org

Review URL: https://codereview.chromium.org/134653005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244253 0039d316-1c4b-4281-b951-d872f2087c98

Release builds of Android use specialized code for loading shared libraries.
The code queries |isLowEndDevice()| before about:flags has propagated to the
process command-line, yielding inconsistent low-end device configurations
between processes.  This can potentially lead to a state where all tabs are
blank, forcing the user to re-install Chrome. Remove the about:flags entry
until the query can be either deferred or removed entirely.

BUG=331931
NOTRY=true

Review URL: https://codereview.chromium.org/133133005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244252 0039d316-1c4b-4281-b951-d872f2087c98

Merges the settings for use_alsa and use_pulseaudio for selection
based on use_cras.  As a consequence, removes linking of ALSA when
use_cras=1, which should result in a small binary size savings.

BUG=none
TEST=Pulse is available along with ALSA when chromeos=1.
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244098

Review URL: https://codereview.chromium.org/132773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244251 0039d316-1c4b-4281-b951-d872f2087c98

First time broke the build with a non-ASCII character in a comment.

BUG=320090
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/131833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244250 0039d316-1c4b-4281-b951-d872f2087c98

BUG=333092

Review URL: https://codereview.chromium.org/132533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244249 0039d316-1c4b-4281-b951-d872f2087c98

The behavior is equivalent to taking the screenshot via VKEY_PRINT keyboard shortcut.

BUG=196658

Review URL: https://codereview.chromium.org/132233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244248 0039d316-1c4b-4281-b951-d872f2087c98

Addresses a flaky ASAN failure where I believe callbacks from ImpulseCallbackCounter with an unretained reference were being held too long by ProcessManager.

This clears the callbacks immediately when the impulse count is reached, and does not call the quit closure repeatedly.

BUG=332440

Review URL: https://codereview.chromium.org/129243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244247 0039d316-1c4b-4281-b951-d872f2087c98

Removes individual instances of Details structure in WindowResizer subclasses and adds DragDetails to WindowState. It is possible to access the current WindowResizer during the drag via window_state->drag_details()->window_resizer.
Simplifies construction of WindowResizer chain by creating DragDetails once at a point where creation of the resizer chain is imminent (after all checks that would return empty WindowResizer object are made).

Keeps track of whether currently dragged window is a panel attached to the shelf and if so prevents it from indicating that it can be docked (and from getting docked).

BUG=310931

Review URL: https://codereview.chromium.org/121153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244246 0039d316-1c4b-4281-b951-d872f2087c98

In http://src.chromium.org/viewvc/chrome?view=revision&revision=243849
I accidently caused the startup tests to run the default navigate
step. This reverts this, while still making the start with URL tests
run their navigate steps (which they need to do).

BUG=333052
R=dtu@chromium.org

Review URL: https://codereview.chromium.org/134793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244245 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
http://crbug.com/308846

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244005

Review URL: https://codereview.chromium.org/128753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244244 0039d316-1c4b-4281-b951-d872f2087c98

BUG=241277, 333263
R=rdsmith@chromium.org
TBR=rdsmith@chromium.org

Review URL: https://codereview.chromium.org/134803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244243 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244242 0039d316-1c4b-4281-b951-d872f2087c98

Finally! GetDefaultProfile goes away for good!

With that I also cleaned up that class and ripped out ancient unneeded functions / type-defs. Re-ordered the function declarations and so on. I am sure that more could be done here, but please first get rid of this function before it gets more children...

BUG=322682
TEXT=covered by existing unit tests

Review URL: https://codereview.chromium.org/132713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244241 0039d316-1c4b-4281-b951-d872f2087c98

Also, IndexedDBContextImpl used to maintain a map of open
connections. This change also deletes this map, and instead
relies on one which already exists in IndexedDBFactory.

BUG=259564

Review URL: https://codereview.chromium.org/93873017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244240 0039d316-1c4b-4281-b951-d872f2087c98

After refactoring there is no need for a separate DeviceData class
anymore, so removing it.

BUG=261165

Review URL: https://codereview.chromium.org/59403004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244239 0039d316-1c4b-4281-b951-d872f2087c98

r1263: Run svn propdel svn:executable on source code files.
r1264: Fix warnings from the Windows build.
r1265: Switch scoped_ptr.h to a compatible google3 implementation.
r1266: Use a proper ignore_result() to fix a warn_unused_result warning.
r1267: Windows: Fix remaining level 4 warnings.
r1268: Fix build with Mac OS X 10.9 SDK.
r1269: Fix #include order from r1268.
r1270: Don't do work inside assert(). Ever.

BUG=331268
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/131833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244238 0039d316-1c4b-4281-b951-d872f2087c98

> Add support for using expressions as enum values.
> 
> BUG=320090
> R=darin@chromium.org
> 
> Review URL: https://codereview.chromium.org/130443003

Broke the android build: http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20Builder%20%28dbg%29&number=50248

TBR=mpcomplete@google.com

Review URL: https://codereview.chromium.org/133843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244237 0039d316-1c4b-4281-b951-d872f2087c98

The default preference values are fine for app_shell's pages (as they are
for content_shell, which doesn't use PrefsTabHelper).  Delegate out the
creation of PrefsTabHelper so we only create them in Chrome.

With this patch app_shell can launch a renderer before crashing.

BUG=332435
TEST=browser_tests, manual testing that extensions still work

Review URL: https://codereview.chromium.org/132993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244236 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244235 0039d316-1c4b-4281-b951-d872f2087c98

(platform_channel_posix.cc gets moved to platform_channel_pair_posix.cc
entirely.)

R=darin@chromium.org

Review URL: https://codereview.chromium.org/133533007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244234 0039d316-1c4b-4281-b951-d872f2087c98

BUG=320090
R=darin@chromium.org

Review URL: https://codereview.chromium.org/130443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244233 0039d316-1c4b-4281-b951-d872f2087c98