GitLab

BUG=404631

Review URL: https://codereview.chromium.org/493213004

Cr-Commit-Position: refs/heads/master@{#291629}

Adds whitelist to commands API to relax restrictions on:
- global accelerator keys
- maximum number of commands
- override previously taken accelerators

This cl also involved fixing the use of the search key while using the global commands listener. The 'command' modifier was being dropped while making its way to the renderer and back.

BUG=404768
TEST=With a sample extension binding
"Search+Shift+L" and
"global": true

press and verify callback when
focus is inside of web content
focus is on the status tray

Review URL: https://codereview.chromium.org/399783002

Cr-Commit-Position: refs/heads/master@{#291628}

Selects one on top overlay, if possible, from a main plane + single overlay combination

BUG=370522

Review URL: https://codereview.chromium.org/489193002

Cr-Commit-Position: refs/heads/master@{#291627}

Even the 40-character hash causes problems when the pieces of the string before
it push the length to >64 characters. Truncating it is a temporary fix until
we discuss ways to accept strings longer than 64 chars.

R=cmp@chromium.org, scottmg@chromium.org
NOTRY=True
BUG=406783

Review URL: https://codereview.chromium.org/499133003

Cr-Commit-Position: refs/heads/master@{#291626}

No longer need this change on trunk now that it has been tested and
merged to M37 branch.

This reverts commit fd85a93b.

BUG=405983
TBR=bartfab@chromium.org

Review URL: https://codereview.chromium.org/499923002

Cr-Commit-Position: refs/heads/master@{#291625}

HID report sizes are unsigned values. In addition they should (because
of the limited size of USB control transfers) never be larger than 64k.
In reality that would be an absolutely enormous report and unlikely to
ever been seen in the wild. By limiting the storage size for report
lengths to a uint16_t we therefore also limit our exposure to being
convinced to allocate unreasonably large buffers by a malicious device.
The Windows HID parser already limits report sizes to a USHORT value.

BUG=

Review URL: https://codereview.chromium.org/492963007

Cr-Commit-Position: refs/heads/master@{#291624}

It makes presubmit error:
The test file path has been changed by the following CL.
- https://codereview.chromium.org/477153005

TBR=mtklein@chromium.org,caryclark@google.com,fmalita@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/497403002

Cr-Commit-Position: refs/heads/master@{#291623}

BUG=403813
R=oshima@chromium.org
TEST=athena_unittests

Review URL: https://codereview.chromium.org/498823002

Cr-Commit-Position: refs/heads/master@{#291622}

 - Add the extension's icon to the header
 - Add a drop shadow below the header to differentiate the extension
   content from the WebUI overlay

BUG=405796

Review URL: https://codereview.chromium.org/488293003

Cr-Commit-Position: refs/heads/master@{#291621}

This is the set of tests that do not require any change to run as part
of extensions_unittests suite.

BUG=397165
TEST=extensions_unittests
R=jamescook@chromium.org
TBR=yoz@chromium.org

Review URL: https://codereview.chromium.org/504593002

Cr-Commit-Position: refs/heads/master@{#291620}

Cr-Commit-Position: refs/heads/master@{#291619}

Make ExtensionFunctionDispatcher::DispatchOnIOThread()
return early if the extension that was passed to it doesn't
exist anymore.

BUG=406062

Review URL: https://codereview.chromium.org/489033003

Cr-Commit-Position: refs/heads/master@{#291618}

Cr-Commit-Position: refs/heads/master@{#291617}

This reverts commit 1d8498da.

This didn't need to bump because the earlier, failed branching run never got
far enough to create 2134 branch.

Cr-Commit-Position: refs/heads/master@{#291616}

The tool has trouble handling substitutions for these macros, since the
macros wrap helper functions that perform the actual comparison. This
causes the tool to emit replacements for the code inside the helper
functions, when the proper fix is to emit replacements for the macro
arguments.

This patch adds matchers to catch calls to these helper functions with
a raw T* and a scoped_refptr<T>, so the main matcher can ignore these
replacements and let a logging/gtest specific MatchCallback process
these results instead.

BUG=110610
R=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/488933002

Cr-Commit-Position: refs/heads/master@{#291615}

This pulls in the following Native Client changes:

db60e9b: (sbc@chromium.org) Update glibc revision in tools/REVISIONS (9b15f6a->150657d)
c64c70d: (mseaborn@chromium.org) PNaCl dynamic loading: Add ELF dynamic loader
90f0c78: (jvoung@google.com) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
6850127: (mseaborn@chromium.org) Use uint32_t for untrusted pointer args: fstat() and some other syscalls
f128665: (dschuff@chromium.org) Build PNaCl target libraries on mac and run SCons tests on the toolchain bot
9151ed1: (petarj@mips.com) [MIPS] Change output-format to elf32-tradlittlemips-nacl
6ef6c97: (petarj@mips.com) PNaCl: Update binutils revision in pnacl/COMPONENT_REVISIONS
9ae0959: (mseaborn@chromium.org) Use uint32_t for untrusted pointer args: gettimeofday() syscall
a2d9190: (yyanagisawa@chromium.org) Re-enable use of goma on Windows.
b9da09f: (jvoung@chromium.org) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
3637eb0: (zhenyu.liang@intel.com) Support Android x86 platform
328c7552: (jvoung@chromium.org) Update revision for PNaCl r13625->r13647
b17c53c: (dyen@chromium.org) Pre-Submit script no longer depends on cwd being in NaCl root.
47107a8: (mseaborn@chromium.org) Reduce bot cycle time: Don't run the "noragel" Gyp build
6ab1ae1: (kschimpf@google.com) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
c81a09f: (mcgrathr@chromium.org) toolchain_build: Update binutils revision
bb09389: (mseaborn@chromium.org) Revert r13646: "Re-enable use of goma on Windows."
3f998aa: (mseaborn@chromium.org) Fix regression in loading of mmap()'able nexes on Windows

BUG=406632
TEST=browser_tests and nacl_integration

Review URL: https://codereview.chromium.org/471173004

Cr-Commit-Position: refs/heads/master@{#291614}

TBR=maruel@chromium.org
R=szager@chromium.org
BUG=362394

Review URL: https://codereview.chromium.org/484393003

Cr-Commit-Position: refs/heads/master@{#291613}

This CL changes the platform check from Linux to X11.

Review URL: https://codereview.chromium.org/500713002

Cr-Commit-Position: refs/heads/master@{#291612}

Cr-Commit-Position: refs/heads/master@{#291611}

BUG=406854
Bug: b/17177684

Enabling channel ID causes problems for apps that use multiple network
stacks (such as httpurlconnection and webview) or multiple webviews
and want to share cookies. Disable until we provide some solution.

Review URL: https://codereview.chromium.org/497963002

Cr-Commit-Position: refs/heads/master@{#291610}

Review URL: https://codereview.chromium.org/497083004

Cr-Commit-Position: refs/heads/master@{#291609}

We used to test the state of the occlusion tracker by making queries
for various input rects to try and guess what its occlusion state
must be. This is bad. Instead, we can query the state directly.

This removes all state queries from tests that are verifying the
occlusion tracker's internal state changes correctly. And adds some
new tests that just set internal state and verify the query methods
work correctly.

R=enne

Review URL: https://codereview.chromium.org/497493004

Cr-Commit-Position: refs/heads/master@{#291608}

Also fix a dependency issue in
chromeos_test_support_without_gmock, make
ExtensionsTestSuite call
GLSurface::InitializeOneOffForTests(), and avoid
double-initializating Aura in app_shell.

BUG=405967

Review URL: https://codereview.chromium.org/468393005

Cr-Commit-Position: refs/heads/master@{#291607}

Add 'Initialize' method that takes an enum value to specify hardware
acceleration policy. Policies are always, with fallback and only software.

BUG=406194

Review URL: https://codereview.chromium.org/496203002

Cr-Commit-Position: refs/heads/master@{#291606}

When a frame is queued on a surface, a callback can queued that will be called when that surface is used to draw a frame. This can be used to create backpressure on renderers or the browser compositor.

BUG=

Review URL: https://codereview.chromium.org/465673003

Cr-Commit-Position: refs/heads/master@{#291605}

When PictureLayerImpl chooses a scale to raster at, we should accept
tiles at that scale as complete, and not try wait for tiles at some
other scale to be filled in. Such a tiling may not even exist.

R=enne, vmpstr
BUG=406433

Review URL: https://codereview.chromium.org/484363003

Cr-Commit-Position: refs/heads/master@{#291604}

Have TabAndroid to implement the SearchTabHelperDelegate interface to provide the necessary functionality to SearchTabHelper.

This will allow us to turn off search term replacement (by updating the location bar displayed url) when the underlying page doesn't support embedded search.

Server side bug: b/17140979

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/488093003

Cr-Commit-Position: refs/heads/master@{#291603}

With the recent EME spec changes, ReleaseSession() got replaced by
CloseSession() and RemoveSession(). Until all the changes to support
both methods are in place, calls to ReleaseSession() should call
RemoveSession() in order for existing prefixed EME applications
to continue to work.

Unprefixed Close() calls now call RemoveSession(), and thus don't do
the correct thing. This will be fixed when both CloseSession() and
RemoveSession() are passed through Pepper.

BUG=406606
TEST=All EME browser_tests pass

Review URL: https://codereview.chromium.org/497153005

Cr-Commit-Position: refs/heads/master@{#291602}

Review URL: https://codereview.chromium.org/502593003

Cr-Commit-Position: refs/heads/master@{#291601}

The menu model needs to be cleaned up if the menu is suppressed for being
too short.

BUG=406609
TEST=manual, see bug

Review URL: https://codereview.chromium.org/486193004

Cr-Commit-Position: refs/heads/master@{#291600}

BUG=402207

Review URL: https://codereview.chromium.org/490373002

Cr-Commit-Position: refs/heads/master@{#291599}

In the new profile management world, you can find yourself using a super old
profile named by default "Default Profile". These names should be migrated to
the new style default names ("Person 1").

The code is fantastically special because the ProfileInfoCache re-sorts itself after
each rename, so doing a batch rename is really not a thing it wants to do.

BUG=406409

Review URL: https://codereview.chromium.org/490363002

Cr-Commit-Position: refs/heads/master@{#291598}

Based on the hotword extension, but heavily modified.

BUG=397019

Review URL: https://codereview.chromium.org/464213002

Cr-Commit-Position: refs/heads/master@{#291597}

Redundant requests to observe the window are harmless, and should be supported
given the undefined relationship and timing between
|RWHVAndroid::SetContentViewCore()| and |RWHVAndroid::WasShown()|, both of which
can trigger observing of the root window.

BUG=406651,394604
NOTRY=true
TBR=sievers@chromium.org

Review URL: https://codereview.chromium.org/493053004

Cr-Commit-Position: refs/heads/master@{#291596}

BUG=406532

Review URL: https://codereview.chromium.org/500653002

Cr-Commit-Position: refs/heads/master@{#291595}

We can trigger this case by adding a webview that is not in DOM through
newwindow API.

Fix so that deferred attachment would not throw error, this is done by
returning true in attachWindow() method in this case.

BUG=None
Test=Load a <webview> in a chrome app. Make a newwindow request from
that webview. When the newwindow event fires, call e.window.attach
with a <webview> that is not on DOM, this should work as intended,
when the later <webview> is attached to DOM, it should load properly.

Review URL: https://codereview.chromium.org/497833003

Cr-Commit-Position: refs/heads/master@{#291594}

bookmarks.

R=benjhayden@chromium.org
BUG=405717
TEST=visual

Review URL: https://codereview.chromium.org/492163004

Cr-Commit-Position: refs/heads/master@{#291593}

Add a Renderer interface to manage all audio/video (and in the future text) rendering. With Renderer, Pipeline only needs to manage a Demuxer and a Renderer, which helps move a lot of complicated logic out of Pipeline.

On Desktop Chrome, we use RendererImpl, which manages AudioRendererImpl and VideoRendererImpl.

On other platforms, we could add different Renderer implementation. For example, we could support Browser side decoding/rendering.

BUG=392259

Review URL: https://codereview.chromium.org/418143005

Cr-Commit-Position: refs/heads/master@{#291592}

There will be a follow-up CL to switch some fields to non-nullable.

BUG=406580
TEST=None

Review URL: https://codereview.chromium.org/488533005

Cr-Commit-Position: refs/heads/master@{#291591}

BUG=406537

Review URL: https://codereview.chromium.org/491483005

Cr-Commit-Position: refs/heads/master@{#291590}