- 29 Nov, 2018 40 commits
-
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I8edcf318977ab7e92f8e09869d851385be4473bb Reviewed-on: https://chromium-review.googlesource.com/c/1355367Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612352}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b88aa2d8ba8e..ee85992c5c61 git log b88aa2d8ba8e..ee85992c5c61 --date=short --no-merges --format='%ad %ae %s' 2018-11-29 mlopatkin@yandex-team.ru Fix atrace_agent on pre-M devices Created with: gclient setdep -r src/third_party/catapult@ee85992c5c61 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:908761 TBR=sullivan@chromium.org Change-Id: Ibdddb4067a1cd003f68b4a2127aebd55180d2011 Reviewed-on: https://chromium-review.googlesource.com/c/1355620Reviewed-by:
-
Mike Wasserman authored
Bug: 910224 Change-Id: Ie1d13e6d2c41b4096ce7912ba494db2fe468c678 Reviewed-on: https://chromium-review.googlesource.com/c/1355196Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#612350}
-
Martin Kreichgauer authored
This changes CtapGetAssertionRequest to carry the unhashed AppID rather only its hashed form, the "Alternative Application Parameter". The unhashed value is passed to the Windows WebAuthn API for U2F sign requests. Bug: 898718 Change-Id: I2d9e6b80463859adba9a786e0c478c9d63e4164b Reviewed-on: https://chromium-review.googlesource.com/c/1354689 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#612349}
-
Krishna Govind authored
R=kariah@chromium.org Change-Id: I410f2c3c78edc2ef684dbd8fce935dbdb50be14b Reviewed-on: https://chromium-review.googlesource.com/c/1355851Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#612348}
-
agrieve authored
This reverts commit b74cdf4b. Reason for revert: Broke compile of remoting_me2me_host_archive (see bug) Original change's description: > Cronet: Simplify repackage rules > > * Use dist_jar() rather than a custom script > * Avoids needing to extract .jars. > * Avoids needing to reference ".javac.jar" files, which > are somewhat of an implementation detail. > > * Added jar_excluded_patterns support to dist_jar() > > * Merges zip.py and dist_jar.py, since they were doing the > same thing. > > Spot checked that these two jars are the same before/after: > * cronet/cronet_impl_common_java.jar > * cronet/cronet_impl_native_java.jar > > Change-Id: I4d5a5f495ce0376ef2e53b6d4e3c9ebbc3d75ae1 > Reviewed-on: https://chromium-review.googlesource.com/c/1349872 > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Reviewed-by: Eric Stevenson <estevenson@chromium.org> > Commit-Queue: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612210} TBR=pauljensen@chromium.org,agrieve@chromium.org,estevenson@chromium.org Bug: 910311 Change-Id: I0d06a36a1694e378bdfafda21f63fd2e5f258239 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1355887Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#612347}
-
sebsg authored
There were failing. * css1/font_properties/font.html * css1/font_properties/font_family.html * css2.1/t1503-c522-font-family-00-b.html * css2.1/t1508-c527-font-03-b.html * fast/block/float/016.html * fast/text/international/complex-character-based-fallback.html * fonts/cursive.html * svg/text/ligature-queries.html Tbr: drott@chromium.org Bug: 910263 Change-Id: If5a9291579bff7d8c3184a8c02813088df6c06f5 Reviewed-on: https://chromium-review.googlesource.com/c/1355523Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#612346}
-
David Tseng authored
Bug: 882261 Change-Id: I8226d70905146da97e9d1e1846a4e6a8e2cd01be Reviewed-on: https://chromium-review.googlesource.com/c/1336656 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#612345}
-
Hui(Andy) Wu authored
Avoid blocking important part of the underlying page. Screenshots: https://drive.google.com/file/d/1QHMmX0s2uIE1v82TNmj7KwR-3PJIipGO/view?usp=sharing https://drive.google.com/file/d/13EipCdWx5sJDn8-BTeS9f3vb_v5poJQA/view?usp=sharing Bug: 119282188 Change-Id: I4a5c5144f0dd4ef6803c270129d18cb716438a17 Reviewed-on: https://chromium-review.googlesource.com/c/1340940Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Hui Wu <wuandy@chromium.org> Cr-Commit-Position: refs/heads/master@{#612344}
-
Paul Jensen authored
Previously my DNS histograms incorrectly thought the internal resolver was not used when it in fact was. Bug: 908535 Change-Id: I1c3a8d41298b91d23236649de72299c47cf93926 Reviewed-on: https://chromium-review.googlesource.com/c/1351742 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#612343}
-
Eugene But authored
Made Stop and Reload no-op during session restoration. For embedder WebState should behave as idle during session restoration, so ignoring Reload and Stop is fine. Reload will eventually happen after the restoration is complete and stop should be actually no-op for an idle WebState. Bug: 877671 Change-Id: I14c4b1d06122aad03406510c9b3e3d57d80e5f93 Reviewed-on: https://chromium-review.googlesource.com/c/1354035Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#612342}
-
Ryan Tseng authored
https://chromium-review.googlesource.com/c/chromium/src/+/1252625 was supposed to do a DCHECK to ensure the semantics of ToIsolate() remained unchanged, but the check was incorrect. This fixes the semantics. The next step is to remove ToIsolate(ExecutionContext). Bug: 889542 Change-Id: Ic0a84fa74cafef47e43858f4dae4880b2f7757ec Reviewed-on: https://chromium-review.googlesource.com/c/1355190Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#612341}
-
Peter Wen authored
Now that CrashKeys.java and related files are in components/, tiborg@ and I can help isherman@ co-own these files to reduce maintenance burden. Bug: None Change-Id: I790545b5976cdbd2109bfc57f8c615eacdbb6a90 Reviewed-on: https://chromium-review.googlesource.com/c/1355483 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#612340}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3ee605d7ccb9..8ce3dbabb8b5 git log 3ee605d7ccb9..8ce3dbabb8b5 --date=short --no-merges --format='%ad %ae %s' 2018-11-29 zoddicus@users.noreply.github.com Merge two implementations of ValidateExecutionScope (#2131) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@8ce3dbabb8b5 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I630443223412245a2f9250cbca06de98376327de Reviewed-on: https://chromium-review.googlesource.com/c/1355621Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9af233a50848..dd530811aba9 git log 9af233a50848..dd530811aba9 --date=short --no-merges --format='%ad %ae %s' 2018-11-29 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@dd530811aba9 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I45f77bd1ed1f30a6c5a038907d4c12dc7deaea28 Reviewed-on: https://chromium-review.googlesource.com/c/1355622Reviewed-by:
-
Fabrice de Gans-Riberi authored
This changes the optimization level for debug builds on Fuchsia to optimize for size. This fixes an issue where the KVM would run out of space on the Fuchsia debug component bot. Bug: 910243 Change-Id: I7b1257c26b820af97b7c29151cde8f1a52692f5e Reviewed-on: https://chromium-review.googlesource.com/c/1352621 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#612337}
-
Matthew Wang authored
FT pref used to be a dictionary with a single boolean field. Make it a boolean instead. Bug: 909753 TEST: shill unittests, browser_tests Change-Id: I80304f6be20ebc9e7eec56f0dd2f36e2e8cf5af5 Reviewed-on: https://chromium-review.googlesource.com/c/1354343 Commit-Queue: Matthew Wang <matthewmwang@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#612336}
-
manuk authored
This CL intends to style the output table to approximately resemble the end goal. There will be more styling changes in future as 1) a single CL for all the styling changes would be too large, and 2) some of the styling changes depend on changes to how we generate and manage the HTML elements from the JS code. In addition to 1) trivial CSS styling, this CL also 2) scales the table and column widths with the page width (down to a minimum width) and therefore gives all tables the equal width and consistent column widths; and 3) merges the combined results and individual provider results tables into a single table delimited with inner header rows. Bug: 891303 Change-Id: Ifc823456a8404ade90f34a2c07545c1f643cb96d Reviewed-on: https://chromium-review.googlesource.com/c/1354132 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#612335}
-
Peng Huang authored
Bug: 905337 Change-Id: I14e4188def4719f0b04151bf9d76731a46889612 Reviewed-on: https://chromium-review.googlesource.com/c/1351266Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#612334}
-
Alex Leung authored
This reverts commit f1854090. Reason for revert: Causes internal b/120143260. Change-Id: I83286ee7cb9d5e96e63be66bc47efda802421232 Reviewed-on: https://chromium-review.googlesource.com/c/1354326 Commit-Queue: Alex Leung <alexleung@google.com> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#612333}
-
Jonathan Backer authored
When we access RasterDecoderContextState::gr_context, the RasterDecoderImpl::context_state may become inconsistent with actual GL context state and we should set need_context_state_reset Bug: 910274 Change-Id: I834ce6e4cf9b5fe549de432b3bc6c06fa2a6ccbd Reviewed-on: https://chromium-review.googlesource.com/c/1355438 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#612332}
-
Troy Hildebrandt authored
SharedProtoDatabaseClient inherited from UniqueProtoDatabase which was potentially risky since we can accidentally use some of UniqueProtoDB's functionality resulting in incorrect keys/entries from the database because we're not stripping/adding prefixes. We now inherit from ProtoDatabase to ensure that any functions added in the future must also be implemented in SharedProtoDatabase. Bug: 870813 Change-Id: I270afdb9dcffa0ba045756272a2f36af9cc93048 Reviewed-on: https://chromium-review.googlesource.com/c/1355423Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#612331}
-
Dale Curtis authored
This is part 1/4 CLs to move the <audio>/<video> elements off of a synchronous API that can lead to renderer hangs and premature audio renderer errors. BUG=905506 TEST=updated tests, compiles. Change-Id: I9b26ed5ed8faea2f691b3a415dbdc79e18f5125a Reviewed-on: https://chromium-review.googlesource.com/c/1347588 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#612330}
-
Eric Roman authored
Bug: 910212,729849 Change-Id: Iff0a02015b4b6dabfeff5b3865468df70748ddd6 Reviewed-on: https://chromium-review.googlesource.com/c/1355492Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#612329}
-
Xi Han authored
Bug: 902311 Change-Id: I6f39faecc38ad002a70bfda7fd355ab83afc0889 Reviewed-on: https://chromium-review.googlesource.com/c/1337487Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#612328}
-
Clark DuVall authored
ChromeMockCertVerifier was forgetting to call the parent class methods that set up the in-process NS cert verifier. Bug: 908993 Change-Id: I15251a705006c7f5dd1dc99027999e1b8739e416 Reviewed-on: https://chromium-review.googlesource.com/c/1355194Reviewed-by:
-
bsheedy authored
Adds a TL;DR to the XR instrumentation test documentation on how to locally reproduce most VR issues since many VR breakages at this point are caused by non-VR CLs, and their authors often need to ask how to reproduce the issue. Change-Id: I2a4585969a859cb9c9256c8cfa0715d9cc07b71c Reviewed-on: https://chromium-review.googlesource.com/c/1352488Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#612326}
-
Mason Freed authored
This set includes a few more known issues, and changes the definition of opacity to match our more recent proposal. Under that proposal, the opacity of the backdrop-filter element applies to the filtered backdrop image as well. Bug: 497522 Change-Id: I2fa0bbb710b7a4ba5592c9a4b9ea5ecaaf5b9ddf Reviewed-on: https://chromium-review.googlesource.com/c/1354347Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#612325}
-
Donn Denman authored
Adds the ability to specify a threshold replacement to apply when predicting using an Assist-Ranker model. For Contextual Search the threshold is read from a FieldTrial variations parameter associated with the existing ContextualSearchRankerQuery Feature. For Translate, threshold setting is supported but unused. BUG=899134 Change-Id: Ia0b664ce1e0949f755e7d8898fb2769fc91ae536 Reviewed-on: https://chromium-review.googlesource.com/c/1312296 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#612324}
-
Avi Drissman authored
This avoids it getting triggered by URL requests to quit/restart. BUG=909592, 142944 Change-Id: I353c1334decd556554399349bb207e63fca1352b Reviewed-on: https://chromium-review.googlesource.com/c/1354399Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#612323}
-
John Delaney authored
Add a browsertest to verify that we are not counting overhead for responses with "Transfer-Encoding: chunked" towards network body bytes. Rename PageLoadMetricsTestWaiter methods to use "network bytes" instead of "resource bytes". Bug: 894168 Change-Id: Id83af484f210063761dcbf4552406f08cdd5a171 Reviewed-on: https://chromium-review.googlesource.com/c/1351383Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#612322}
-
Matthew Denton authored
Adds periodic pausing/resuming of random mojo bindings, to test whether Mojo users are relying on FIFO ordering of messages sent over different message pipes. Bug: 830815 Change-Id: Ie765813235a6ff720b2c4c3be550ad474b7be566 Reviewed-on: https://chromium-review.googlesource.com/c/1325551 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#612321}
-
Jonathan Metzman authored
These are needed to stand up a builder for libFuzzer on Chrome OS Bug: 909849, 906214 Change-Id: Ifade90c138a7297a2cd5cc02e7d00628c3408d46 Reviewed-on: https://chromium-review.googlesource.com/c/1355433Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#612320}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f38fffb7aa2f..9dbf638d6f75 Created with: gclient setdep -r src-internal@9dbf638d6f75 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ifc8506cc400887fd8ba4c5b874b50606dc88f555 Reviewed-on: https://chromium-review.googlesource.com/c/1355363Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612319}
-
Pavel Shmakov authored
The following metrics were added. TWA usage: - TrustedWebActivity.TimeInVerifiedOrigin and TrustedWebActivity.TimeOutOfVerifiedOrigin - time histograms for the time spent in and out of verified origin. - Enabled Ukm recording, as implemented in org.chromium.chrome.browser.browserservices.UkmRecorder Disclosure: - TrustedWebActivity.DisclosureShown - TrustedWebActivity.DisclosureAccepted Clear Data Dialog - Boolean histograms TrustedWebActivity.ClearDataDialogOnUninstallAccepted, TrustedWebActivity.ClearDataDialogOnClearAppDataAccepted - Enum histogram SingleWebsitePreferences.NavigatedFromToReset recorded when user clicks “Clear & Reset” to tell which way did the user navigate into settings. Manage Data Activity - TrustedWebActivity.OpenedSettingsViaManageSpace - Included in enum histogram above Notification Delegation - SystemNotificationType.TRUSTED_WEB_ACTIVITY_SITES entry. - TrustedWebActivity.DelegatedNotificationSmallIconFallback which tells which fallback (if any) was used for the small icon of a delegated notification. Bug: 888961 Change-Id: If1cfe70754f474536c1d242a554a8ae517c5d15b Reviewed-on: https://chromium-review.googlesource.com/c/1353925 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#612318}
-
Devlin Cronin authored
Update the underlying BaseSetOperators<T>::Map type to use std::unique_ptrs instead of linked_ptrs. Bug: 907661 Change-Id: I2161ca2acc513ee5d78cc32b14f27199f5a7d1b7 Reviewed-on: https://chromium-review.googlesource.com/c/1351422 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#612317}
-
John Abd-El-Malek authored
Revert "Alias the url for webui code with network service to get more information in debugging the crash." This reverts commit 660d336d. Got the information I needed. Original change's description: > Alias the url for webui code with network service to get more information in debugging the crash. > > Bug: 891074 > Change-Id: I8904c8d0285b8b2f245456509d88206f4789fc8d > Reviewed-on: https://chromium-review.googlesource.com/c/1330064 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606965} TBR=jam@chromium.org,reillyg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 891074 Change-Id: Id739d25531997bcdacafa5c49a13bfd849edd32a Reviewed-on: https://chromium-review.googlesource.com/c/1355430Reviewed-by:
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome/browser/find_in_page. This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 589840 Change-Id: I9741755b7ed101a5baf4e6bacc38abd7ad0a4029 Reviewed-on: https://chromium-review.googlesource.com/c/1351955Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#612315}
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome. This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 589840 Change-Id: Ibcc14267aaa966b1833dd1537989a7bc5ae9a010 Reviewed-on: https://chromium-review.googlesource.com/c/1351952Reviewed-by:
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome/browser/sessions. This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 589840 Change-Id: Ia6e2ae8b3dc9334e9cec18328d7dda086f7ab57a Reviewed-on: https://chromium-review.googlesource.com/c/1351961Reviewed-by:
-
