GitLab

Bug: 931826, 916806
Change-Id: Id48042e7f7c567e3174d9afa6f9fc09b2b85ae31
Reviewed-on: https://chromium-review.googlesource.com/c/1470717Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632002}

The argument filter is required to make sure only whitelisted arguments
are present in traces from users. To be able to use Perfetto backend in
slow reports in JSON mode, this CL implements argument filtering as it
exists in TraceLog. The metadata filtering is done by
TracingControllerImpl with both backends.

BUG=925148

Change-Id: I65ad53a8ccfea8f721b7fbf4dd7e66969e50fda2
Reviewed-on: https://chromium-review.googlesource.com/c/1464433
Commit-Queue: ssid <ssid@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632001}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/dd4d1d64..9c2fa40d

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I100cc9925a626faa1902246dee02f05b98312234
Reviewed-on: https://chromium-review.googlesource.com/c/1470722Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632000}

The experiment has been at 100% for several milestones now and seems
stable.  There have not been serious problems reported.  To complete
the feature, let's remove the feature flag, and then set an end
milestone in finch (that will be in a separate changelist).

Remove the "Offline pages sharing" flag

Bug: 885285
Change-Id: I508e2210233f5678b30120f6ccd4d3e8a420cab0
Reviewed-on: https://chromium-review.googlesource.com/c/1468765Reviewed-by: Jian Li <jianli@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Auto-Submit: Peter Williamson <petewil@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631999}

EntryListItme.sortEntries uses the first item to determine the volume
it's sorting, when the array to be sorted was empty it was failing.

Bug: 904658
Change-Id: I1442d10bd40ddaa246873b135b4e1ddebd5fccf3
Reviewed-on: https://chromium-review.googlesource.com/c/1469815
Commit-Queue: Sam McNally <sammc@chromium.org>
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631998}

Bug: 931502
Change-Id: I081a32b007d9dad40007b04821548df9ae5c3619
Reviewed-on: https://chromium-review.googlesource.com/c/1471022
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631997}

Change-Id: I6824e1a3a90ade940b07931ee6d473ee33b6892f
Reviewed-on: https://chromium-review.googlesource.com/c/1471029Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631996}

This patch is aligning various @IntDef to some standard used with many other CLs:

1. @IntDef is first, @Retention second and related @interface third
2. NUM_ENTRIES declaring number of entries is not included into @IntDef
3. there is used @Retention(RetentionPolicy.SOURCE)

BUG=919666

Change-Id: I0a2e0600e09ec1919b83e7bafc7e4ff6698dfa9d
Reviewed-on: https://chromium-review.googlesource.com/c/1461041Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#631995}

Add on device head serving component in omnibox, which will be used by on device head suggest provider later.

Tested on iPhone (https://photos.app.goo.gl/6T49WV6fxMcbP4Gy7; using https://crrev.com/c/1388125)

Bug: 925072
Change-Id: If5b0a3a3402ebd35158c3d319f406db720e42f26
Reviewed-on: https://chromium-review.googlesource.com/c/1452367
Commit-Queue: Ce Chen <cch@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631994}

DialogDelegate and BubbleDialogDelegateView default drawing rounded
corners during creation of the NonClientFrameView. ExtensionPopups
do not draw rounded borders. This prevents the regression of ugly border
colors not matching the ClientView. FindBarView border manually updated
due to not being a Bubble. Also updated corner radius emphasis metrics
in LayoutProvider to match the material design updates. Increased top
and bottom margins of PageInfo to prevent corners being drawn over.

Bug: 822075
Change-Id: I7fe0a07e4cad7a84fbf54a0dc92e52d36501be9c
Reviewed-on: https://chromium-review.googlesource.com/c/1444275
Commit-Queue: Sajad Maysam <sajadm@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631993}

The SimpleURLLoader work mentioned in the bug seems to be done, and
the try jobs are passing. Enable it and see what happens?

Bug: 140976
Change-Id: Ic85aaa4352801fcc4be21a0d1dc7e1d4ed8df7c7
Reviewed-on: https://chromium-review.googlesource.com/c/1469293
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631992}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/01a85176b3e4..e67fcf9ed6c6


git log 01a85176b3e4..e67fcf9ed6c6 --date=short --no-merges --format='%ad %ae %s'
2019-02-13 chrome-bot@chromium.org Update config settings by config-updater.


Created with:
  gclient setdep -r src/third_party/chromite@e67fcf9ed6c6

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I7af08581fe8e70fbe983faaab784ee848a0938d2
Reviewed-on: https://chromium-review.googlesource.com/c/1470956Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#631991}

@IntDef/@StringDef annotation are preferred way for declaring
set of String/int values

1. they need less space in APK than enum, see
https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
2. they give more control over allowed values than "static final" values

Patch is migrating BrowserServices code to @IntDef with form common with other Chrome @IntDef:

1. with @IntDef first, @Retention second
   and related @interface third
2. with values inside @interface
3. with @Retention(RetentionPolicy.SOURCE)
4. without "static final" in the @interface

BUG=919666

Change-Id: I9d725fc0401d3203f133cfb47b1ee76aae45029f
Reviewed-on: https://chromium-review.googlesource.com/c/1450130Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#631990}

Change-Id: I02623445a38902900fc80f00a98040712cd6b951
Reviewed-on: https://chromium-review.googlesource.com/c/1468164
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631989}

This test times out on the clang tot windows debug bots (32 & 64):
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ToTWin%28dbg%29/2360
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ToTWin64%28dbg%29/2335

TBR=tommi@chromium.org

Bug: 902310
Change-Id: I0ac5995fd573ff6505127ce5ef93ea26f4e8f164
Reviewed-on: https://chromium-review.googlesource.com/c/1471302Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631988}

The None filter quality uses a nearest-neighbor approach for blurring,
which leads to poor representation of the colors within the block.
Instead, we use a block mean approach, for consistency with the backend.
Also fixes some problems with RGB vs BGR byte ordering which can lead
to incorrect colors on the backend.

Bug: 922226
Change-Id: I666d29c557d3c86870332394b9838951d04a2d21
Reviewed-on: https://chromium-review.googlesource.com/c/1467462
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631987}

It times out on the clang Windows debug bots.

TBR=scottchen@chromium.org

Bug: 902310
Change-Id: I7687103ddf44a7ef9860c8b8d8d07cf880fae991
Reviewed-on: https://chromium-review.googlesource.com/c/1471228Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631986}

Googletest is (at last) converging with industry-standard terminology
[1]. We previously called test suites "test cases", which was rather
confusing for folks coming from any other testing framework.

Chrome now has a googletest version that supports _TEST_SUITE_ macros
instead of _TEST_CASE_, so this CL cleans up some of the outdated usage.

[1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature

Bug: 925652
Change-Id: Iac0bef29d129c3e48c24d6bff14605f1a116fdd8
Reviewed-on: https://chromium-review.googlesource.com/c/1471372
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631985}

The new behavior matches to the standard, Firefox, and Safari.

Bug: 927626
Change-Id: Ifc6687992c10fbca13faaaeb4a56e59f5469f594
Reviewed-on: https://chromium-review.googlesource.com/c/1469843Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631984}

https://skia.googlesource.com/skia.git/+log/da5e03954dd3..5105d68f93e9


git log da5e03954dd3..5105d68f93e9 --date=short --no-merges --format='%ad %ae %s'
2019-02-13 brianosman@google.com Use half-floats for out-of-gamut color in GrAAFillRRectOp
2019-02-13 nigeltao@google.com Keep scaledHeight calculation across oID calls
2019-02-13 reed@google.com work to fix bookmaker
2019-02-13 jvanverth@google.com Fix drag events in Mac viewer.
2019-02-13 herb@google.com Use SkStrikeSpec to consolidate SkDescriptor, Effects and Typeface.
2019-02-13 mtklein@google.com rewrite SkMasks::CreateMasks to work in bytesPerPixel
2019-02-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d3fac74a236e..6fc22a13d45d (7 commits)


Created with:
  gclient setdep -r src/third_party/skia@5105d68f93e9

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stephana@chromium.org

Change-Id: I5dba42616bfa9b108289ee470d58573c5282a927
Reviewed-on: https://chromium-review.googlesource.com/c/1471192Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#631983}

https://chromium.googlesource.com/angle/angle.git/+log/6fc22a13d45d..3805122b0297


git log 6fc22a13d45d..3805122b0297 --date=short --no-merges --format='%ad %ae %s'
2019-02-13 syoussefi@chromium.org Revert "Roll Vulkan repos"


Created with:
  gclient setdep -r src/third_party/angle@3805122b0297

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: Ie5bb05a2da1b44ad303b4692bb45957008d7f667
Reviewed-on: https://chromium-review.googlesource.com/c/1471270Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#631982}

Bug: 924176
Change-Id: Icf2e64886ad574cfb43a60823e2ce9035d925857
Reviewed-on: https://chromium-review.googlesource.com/c/1471296Reviewed-by: Kyle Milka <kmilka@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631981}

https://dawn.googlesource.com/dawn.git/+log/a594f8fdb4d7..1809ff74233d


git log a594f8fdb4d7..1809ff74233d --date=short --no-merges --format='%ad %ae %s'
2019-02-13 jiawei.shao@intel.com Vulkan: Remove RenderPassDescriptorVk
2019-02-13 tikuta@chromium.org [dawn] small fix for BUILD.gn


Created with:
  gclient setdep -r src/third_party/dawn@1809ff74233d

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:931596
TBR=cwallez@chromium.org

Change-Id: I285f4a614d70d32449c0794542bff8655bed4ad4
Reviewed-on: https://chromium-review.googlesource.com/c/1470954Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#631980}

This reverts commit ab746aa2.

Reason for revert: Re-enabling this report revealed that this issue is still happening. We'll disable it again until we have another idea for a fix.

Original change's description:
> Re-enable the ReportBubblingScrollToSameView DumpWithoutCrashing
> 
> We believe that this issue is now fixed, so we'll re-enable this
> DumpWithoutCrashing to confirm that there are no more occurrences of
> this.
> 
> Bug: 828422
> Change-Id: I3ab2b9b949ee50bf15d883b86a938bde46eafa9c
> Reviewed-on: https://chromium-review.googlesource.com/c/1456875
> Commit-Queue: Nasko Oskov <nasko@chromium.org>
> Auto-Submit: Kevin McNee <mcnee@chromium.org>
> Reviewed-by: Nasko Oskov <nasko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#629797}

TBR=nasko@chromium.org,mcnee@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 828422
Change-Id: I37d3b72aa6ea4f748fdd755883ec6926e698a128
Reviewed-on: https://chromium-review.googlesource.com/c/1471222Reviewed-by: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631979}

This CL adds a permission field to the ArcPackageInfo struct so that ARC
app permission data can be passed from ARC to Chrome OS through the AppHost
function OnPackageAppListRefreshed. This data is then passed through to
arc_apps in the App Service.

BUG=916380

Change-Id: If1df4c4fd8b3d85df153fbb9d3355a2d5af1ea78
Reviewed-on: https://chromium-review.googlesource.com/c/1433339
Commit-Queue: Melissa Zhang <melzhang@google.com>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631978}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ae2acf7bf997..3b1e64245a0b


git log ae2acf7bf997..3b1e64245a0b --date=short --no-merges --format='%ad %ae %s'
2019-02-13 jbudorick@chromium.org presubmit: use depot_tools.on_path rather than a handrolled equivalent.


Created with:
  gclient setdep -r src/third_party/depot_tools@3b1e64245a0b

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:925774
TBR=agable@chromium.org

Change-Id: I1f292a4a70e6a819a36c59642148f7c9ea7d495b
Reviewed-on: https://chromium-review.googlesource.com/c/1471191Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#631977}

This CL removes ProfileOAuth2TokenService and
ProfileOAuth2TokenServiceIOSDelegate from CWVSyncController and
uses IdentityManager instead of them.

Bug: 913927
Change-Id: I49970068e663c10af5472d083ef3621d83748db8
Reviewed-on: https://chromium-review.googlesource.com/c/1461203Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#631976}

No flag change

Make QuicSpdyStream only reports ack on body, excluding headers bytes acked. Protected by version 99.

Merge internal change: 233167078

https://chromium-review.googlesource.com/c/1471111/

Add |frame_len| argument to HttpDecoder::Visitor::OnHeadersFrameEnd().

This will be used in cr/231494986.  That one is a quite large CL, so I'm trying
to carve out pieces of it for easier review.

Also, change HttpDecoder member and argument and return value and local variable types from size_t or uint64_t to QuicByteCount wherever it expresses number of bytes.

n/a.  Change types in class used in QUIC v99 only.  Not flag protected.

Merge internal change: 233149295

https://chromium-review.googlesource.com/c/1470999/

Create a QuartcEndpoint abstraction which creates sessions asynchronously.

For now, this is just a wrapper around QuartcFactory.  It creates sessions
asynchronously by scheduling a callback on a QuicAlarm.

The only point to this construct is to force users to wait for a callback.

QuartcEndpoint will serve a greater purpose in the future:  it will own
session/dispatcher dependencies that the caller doesn't need, serve as a unified
API for both client and server perspectives (useful because Quartc is
peer-to-peer and application layer code is the same on both perspectives), and
handle session establishment.

We will start by migrating users from calling QuartcFactory directly to calling
QuartcEndpoint instead, then replace QuartcFactory with an implementation of
QuicDispatcher (for server-side version negotiation) or a version negotiation
agent (for the client).  QuartcFactory will eventually cease to exist.

Creating QuartcEndpoint and migrating callers away from QuartcFactory first
makes it significantly easier to cannibalize the parts of the factory that
handle connection and session creation without breaking callers.  These pieces
need to be reorganized to allow use from the dispatcher.

n/a (Quartc only)

Merge internal change: 233082878

https://chromium-review.googlesource.com/c/1468263/

Remove unused ack_listener argument from QuicSpdyStream::WriteOrBufferBody. No functional change expected, not protected.

Merge internal change: 233065023

https://chromium-review.googlesource.com/c/1468262/

Change a LOG(ERROR) to LOG(WARNING) in QuicPacketReader, and add a histogram for the size of dropped packets. Log & stats only, not protected.

Merge internal change: 233055771

https://chromium-review.googlesource.com/c/1468023/

Add a new method to allow QuicClientBase to change local ports to simulate NAT rebinding and add a command line arg, --num_requests, to QuicClientBin to use it.

n/a (Test only tools)

Merge internal change: 233054987

https://chromium-review.googlesource.com/c/1468003/

Simplify the implementation of QuicFramer::BuildConnectivityProbingPacket(). Protected by FLAGS_quic_reloadable_flag_quic_simplify_build_connectivity_probing_packet

Merge internal change: 232996256

https://chromium-review.googlesource.com/c/1467981/

Remove QuicFramer::BuildIetfDataPacket and make BuildDataPacket do the needful. Rename the guts of BuildIetfDataPacket to AddIetfFrame().

n/a - Moving code around. No functional change.

Merge internal change: 232985714

https://chromium-review.googlesource.com/c/1467668/

Split QuicConnectionHelperInterface from QuartcFactory.  Required for QuicDispatcher/QuartcEndpoint.

When we adopt QuicDispatcher for server-side version negotiation, it needs to
own its own instance of QuicConnectionHelperInterface.  The factory will
eventually go away, so it can no longer serve as the connection helper for
Quartc.  Instead, the factory will own a separate implementation of the
connection helper interface, which can be used without the factory in the near
future.

n/a (Quartc only)

Merge internal change: 232965722

https://chromium-review.googlesource.com/c/1467381/

Deprecate FLAGS_quic_reloadable_flag_quic_fix_last_packet_is_ietf_quic.

Remove unused last_header_form_ from QuicFramer.

Merge internal change: 232921237

https://chromium-review.googlesource.com/c/1465982/

Deprecate FLAGS_quic_reloadable_flag_quic_fix_mark_for_loss_retransmission.

Merge internal change: 232913254

https://chromium-review.googlesource.com/c/1466864/

In QUIC, move ack_listener_ from QuicStream to QuicSpdyStream. No functional change expected. Not protected.

Merge internal change: 232900726

https://chromium-review.googlesource.com/c/1464114/

Deprecate FLAGS_quic_reloadable_flag_quic_disallow_peer_ack_0.

Merge internal change: 232899487

https://chromium-review.googlesource.com/c/1464452/

Initialize server address in QUIC tests.  Previously, GetProof would sometimes get called with an uninitialized server address.

n/a (test only code)

Merge internal change: 232559024

https://chromium-review.googlesource.com/c/1464356/

In QUIC, fix a potential BUILD error because of trying to get min of different types.

Merge internal change: 232551850

https://chromium-review.googlesource.com/c/1464133/

Disable QUIC v39. Protected by BLOCKED FLAGS_quic_reloadable_flag_quic_disable_version_39.

Merge internal change: 232527607

https://chromium-review.googlesource.com/c/1464447/

Rename QuicSimpleServerStreamPeer to TestStream and make it not a peer.

n/a (test-only change)

QuicSimpleServerStreamPeer is kind of a regular peer class: it is friend of QuicSimpleServerStream, and has static methods taking a QuicSimpleServerStream* argument.  At the same time, it is also a subclass of QuicSimpleServerStream, and has non-static methods that operate on base class members.  I find this confusing.

This CL turns QuicSimpleServerStreamPeer into a regular derived class:
no static methods, no friendship.  It also renames it accordingly.

Merge internal change: 232526479

https://chromium-review.googlesource.com/c/1464350/

Add serializer/deserializer for IETF MAX_STREAMS and STREAMS_BLOCKED frames

These replace the MAX_STREAM_ID and STREAM_ID_BLOCKED frames.
The serializer/deserializer converts between the internal QuicMaxStreamIdFrame
and QuicStreamIdBlockedFrame objects, which use absolute stream IDs, and the
wire form of the new frames, which uses stream ID counts. The translation
between the two is simple and straight forward.

A number of tests have been changed to accomodate the new formats and
logic -- in particular, dealing with the stream ID formats for  uni- &
bi-directional streams and server- & client- initiated streams.

A follow on CL will replace teh Quic..Frame objects with new ones
for the new frames, with associated logic changes.

N/A all code is V99 only and protected by the V99 flag.

Merge internal change: 232523736

https://chromium-review.googlesource.com/c/1464132/

Change QuicDispatcher to take a pointer to QuicConfig.

The constructor currently binds the config to a reference member.  This means
the caller is required to keep the referred-to object alive for the lifetime of
the QuicDispatcher.

This behavior tripped me up when trying to adopt QuicDispatcher in Quartc, as I
assumed QuicDispatcher would create a copy of the config.

Changing this to a pointer conforms with advice from go/totw/116.  It makes it
clearer that the caller is responsible for ensuring that the config outlives the
dispatcher.

Merge internal change: 232516491

https://chromium-review.googlesource.com/c/1464446/

(n/a) Deprecate FLAGS_quic_reloadable_flag_quic_aggregate_acked_stream_frames_2.

Merge internal change: 232511987

https://chromium-review.googlesource.com/c/1464107/

R=rch@chromium.org

Change-Id: I7f982c27514d17bc6947f420d42a0ed7b569002f
Reviewed-on: https://chromium-review.googlesource.com/c/1471234Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Dan Zhang <danzh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631975}

Incognito windows (WebContents) are backed by OffTheRecord profiles.

Make BMO behavior match the legacy behavior.

This is tested in HostedAppPWAOnlyTest.PopOutDisabledInIncognito
(I've found that prototyping unified BMO install).

Bug: 915043
Change-Id: I5b3e7491989fb690538ea5892a5463ecec35770c
Reviewed-on: https://chromium-review.googlesource.com/c/1469755Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631974}

There may be a follow-up CL that changes the class to have
only RandInt() accessed through a virtual method and thus remove
the non-deterministic part of the test.  However, in order to merge
easily, this meat of this change is only the fix from "!=" to "=="
and a test to verify the correction.

Bug: 931710
Change-Id: Idfe0cef847148aa99b19974f29b53388d0141e2f
Reviewed-on: https://chromium-review.googlesource.com/c/1470943
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631973}

Broken case is WebContents::WasHidden is called before the first load
then page visibility remains visible because nothing handles
PageMsg_WasHidden, and nothing rechecks the state after first load.
Note RenderView is invisible due to
EnsureRenderFrameHostVisibilityConsistent.

A related bug is that in this case RenderView is created to be visible
and then marked visible after. Turns out fixing this will also
correctly set page visibility, so this CL fixes this bug instead.

Bug: 929860
Change-Id: I30e5e7d9488eb68299fbb524363d01a9b5b4e558
Reviewed-on: https://chromium-review.googlesource.com/c/1467641
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631972}

Bug: 930212
Change-Id: I99100d4fd6fd952f29763de8b33ce277a85ffb58
Reviewed-on: https://chromium-review.googlesource.com/c/1471258Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631971}

This CL was uploaded by git cl split.

R=mgiuca@chromium.org

Bug: 926235
Change-Id: Idcdbb010ed84fa6a679af7d20b889a3f272e41e5
Reviewed-on: https://chromium-review.googlesource.com/c/1464341
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631970}

Microsoft runs tests in a Hyper-V VM. The test external/wpt/resource-timing/resource-timing-level1.sub.html leverages wptserve's SyntheticResponse.py to request that each step of a response is delayed by 250ms. In our environment, even with the extra 15ms "padding" in sleep.py, we're seeing the timer return 5ms early which in turn causes the test to fail. This change updates the sleep_at_least function to, in a loop, explicitly check that it slept long enough and, if not, sleep again for a short interval.

Change-Id: I2dbd8e6bd586dc661b45f94454d3b6b4613db1a5
Reviewed-on: https://chromium-review.googlesource.com/c/1469655Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Erik Anderson <Erik.Anderson@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#631969}

Now that the binary size is less significantly impacted by introducing
additional ProtoDatabase instances (crrev.com/c/1419199), switch to
using a unique ProtoDatabase for each proto message type.

Bug: 921133
Change-Id: Ieae1fc5ba98c574c8e4f9a2587bffa4333fa80df
Reviewed-on: https://chromium-review.googlesource.com/c/1471266
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631968}

This adds a flag and the corresponding boilerplate to let the user
configure the flag via chrome://flags.

BUG=chromium:927840
TEST=Manual

Change-Id: I5e1e292a9f7b81283149dbb4673cf7e7ed26c553
Reviewed-on: https://chromium-review.googlesource.com/c/1456069
Commit-Queue: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631967}

Change client code to work as if IdentityManager::GetPrimaryAccount
where returning a CoreAccountInfo instead of an AccountInfo. Method
will be updated in a followup CL.

This CL was uploaded by git cl split.

Bug: 926204
Change-Id: If5f1ff20dc836ecd394236ed3d6d21ed363a12d5
Reviewed-on: https://chromium-review.googlesource.com/c/1470695
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631966}

This is followup of
https://chromium-review.googlesource.com/c/1461680

Change-Id: I52bdce131b2979f695863230225c78c6801cf3c7
Reviewed-on: https://chromium-review.googlesource.com/c/1470284
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631965}

In order to make debugging easier, instead of serializing url::Origin
logging code should call the newly added GetDebugString method. It adds
more information, such as the nonce and precursor origin for opaque
origins, which can be useful in investigating bugs.

Bug: 918565, 919144, 931895
Change-Id: I1155a4c1f2df0adccd34b890feba8ab4164ec14d
Reviewed-on: https://chromium-review.googlesource.com/c/1470727
Auto-Submit: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631964}

Change-Id: Ic1d9541d6404f3259cbf47a68fd0f3d0660de482
Reviewed-on: https://chromium-review.googlesource.com/c/1471260Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631963}