- 20 Aug, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b8f58d1bec6f..b85e471255be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hendrich@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1055811,chromium:1085419,chromium:1093825 Tbr: hendrich@google.com Change-Id: I14375f7c102f4e76a37dd1efa3b180437dbada16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366238Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800054}
-
Greg Thompson authored
BrowserProcessImpl must take ownership of both ChromeBrowserPolicyConnector and the Local State PrefService at the same time. Failure to do so can result in the policy connector being destroyed before the pref service, resulting in crashes. This CL also cleans up some dead code left behind when creation of these things was moved earlier in startup. BUG=948265 Change-Id: Ia9bf5b9860381d8f865d1447c16d1674d22c4e4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362800Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#800053}
-
Friedrich Horschig authored
This CL applies two suggestions make check strings more understandable. Translation screenshots for ... ... IDS_PASSWORD_CHECK_SET_SCREEN_LOCK_TEXT: https://storage.cloud.google.com/chromium-translation-screenshots/9a004f2cd3ef2455825109125bcc24ad603f04a5 ... IDS_PASSWORD_CHECK_CREDENTIAL_ROW_REASON_LEAKED_AND_PHISHED: https://storage.cloud.google.com/chromium-translation-screenshots/77ebda6a4718dfbac692ee29e226d4605aac690d Bug: 1092444 Change-Id: If750597161e628acc3de765da626c8c72fd031b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366773Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#800052}
-
Alan Cutter authored
This CL hooks up the document's background color as the active tab background color for experimental tabbed web app. Tabbed web apps are hidden behind the DesktopPWAsTabStrip feature flag. This CL plumbs background color through from the renderer process along the same route as document theme color. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=460591&signed_aid=NcgKQaq5Y47QkcbQbbgNiw==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=460590&signed_aid=RlnBzb7mQq1SIW1fGBY-oA==&inline=1 Bug: 1104083 Change-Id: If1c3e2172f80375a1a4619c17ee52594ef813005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342426 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#800051}
-
Mitch McDermott authored
This change is required since the API was updated in http://crrev/c/2360597. Bug: b/165769795 Change-Id: I918d5bfa0ab7887e356f91465425d28f6b73c1bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366380 Commit-Queue: Mitchell McDermott <mcdermottm@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#800050}
-
Hirokazu Honda authored
From this CL, the test evaluates the stream quality by the average of SSIM of the frames. Additionally this CL also cleans up the code of initializing validators and enables to dump bitstream even if --disable-validator. Bug: 1045825 Test: video_encode_accelerator_tests on rammus Change-Id: Ie6fb22eed130dee0e4181a9bc3b2679cc4db6623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359817 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#800049}
-
Yuki Yamada authored
This is a reland of 944fde32. It was reverted because WebSocketChannelImpl::ProcessSendQueue() accessed an unbound HeapMojoRemote, which was guaranteed to be bound without this CL. The issue was fixed in another CL: https://crrev.com/c/2362042 Original change's description: > Reland "Change HeapObserverList to HeapObserverSet" > > This is a reland of f29d2ae1 > > ExecutionContext::NotifyContextDestroyed() has relied on the > deterministic iteration order of ObserverList, so landing the original > CL caused a problem. It is fixed in another CL: > https://crrev.com/c/2352588 > > Original change's description: > > Change HeapObserverList to HeapObserverSet > > > > The previous CL for HeapObserverList https://crrev.com/c/2060348 > > addressed two things: changing HeapObserverList to HeapObserverSet and > > allowing removal while iteration, and was reverted for performance > > reasons. This CL only does the former and avoids performance > > implications of the latter. > > > > This CL is for migration of NewLinkedHashSet. > > See: https://crrev.com/c/2134039 > > > > Bug: 1100257 > > Change-Id: I2426d14d77a68f200bf1398b16638e1605dd4ff1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319087 > > Commit-Queue: Yuki Yamada <yukiy@chromium.org> > > Reviewed-by: Keishi Hattori <keishi@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#797115} > > Bug: 1100257, 1115411 > Change-Id: Id8e1b9a4141777de89bbc471f6ac8c6508a0adff > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352292 > Commit-Queue: Yuki Yamada <yukiy@chromium.org> > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > Reviewed-by: Keishi Hattori <keishi@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798576} Bug: 1100257 Bug: 1115411 Change-Id: I796232c723d4295599832672c9eeedc8e979e757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359657 Commit-Queue: Yuki Yamada <yukiy@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
Add a few new tests, as coverage seemed low. Fix PhysicalBoxSides writing-mode converter to handle vertical-lr, and skip sideways-lr and sideways-rl, since those aren't even supported by the CSS parser. Update BackgroundRoundedRectAdjustedForBleedAvoidance() to skip the borders that aren't part of the fragment. I suppose inline fragmentation wasn't using this code path, but block fragmentation uses it. Bug: 829028 Change-Id: I7e3f78a4fde54c7da1442efdabe609651cd27d10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362902Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#800047}
-
Zain Afzal authored
Previously the media app had an issue where some operations could update the launch.js side entryIndex without the receiver.js side knowing about it, i.e A navigation request is sent to launch.js and actioned but the media_app has unsaved changes and doesn't load the new file in. In these cases the user sees file 1 but the entryIndex is file 2, making navigating to the next file confusing as they jump to file 3. This CL fixes this by making all navigation requests provide the file that is currently loaded, launch.js then uses this to inform what the next file should be rather then relying on the possibly incorrect entry index. Google 3 side of this change: cl/327574130 BUG: b/163662946 Change-Id: Iece116c5161b8ba4a2345fe343ce9e343eed986b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366212Reviewed-by:
-
arthursonzogni authored
Based on the useful doc: docs/use_counter_wiki.md Add a WebFeature for the CrossOriginOpenerPolicyReporting, so that its usage could be monitored during the Origin Trial. Bug: 1116413 Change-Id: I4230613345f3eee6749bb5e669f41b38d032ccbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364492Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#800045}
-
Friedrich Horschig authored
This CL adds a hint string that advises users to match stored with actually used passwords. The string will be used on different editing surfaces (e.g. pwd check and pwd editing from settings). This location also simplifies visibility constraints due to modularization. Translation screenshot for IDS_PASSWORD_EDIT_HINT: https://storage.cloud.google.com/chromium-translation-screenshots/836fe6204aa775e50fa379738191cf32dd4f4f71 Bug: 1119424, 1092444 Change-Id: Iaf44a9a0b719545ecbbf43b28314de18bf51f703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364636Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#800044}
-
Sreeja Kamishetty authored
This CL disables back-forward cache for the tests which want to cover scenarios without documents being preserved in the cache and adds new tests which require to test the functionality when BackForwardCache is enabled. BUG=1102629 Change-Id: Ib26902c1a590d252030ec5d5105299cb0ef895c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354242Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#800043}
-
Takashi Sakamoto authored
Bug: 1086388, 1101421 Change-Id: I3b4bcb7f9df934963cff68609bd9960f1e1249ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348738 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
-
Milica Selakovic authored
Bug: 1086114, 1092444 Change-Id: I94968b0566d303c42c20a75eb04bdcfd453af16f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362905 Commit-Queue: Milica Selakovic <selakovic@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#800041}
-
Maria Kazinova authored
Enables to share FieldDataManager between PasswordManager and Autofill. This change does not affect any Autofill logic, only stores the data filled by Autofill, which can be used later by both components. Having this data fixes a PasswordManager bug that causes credentials to be saved incorrectly when username comes from Autofill filling. Bug: 1109185 Change-Id: Ic76290a37f5a7e4c1d52ff3faf33b4316dbf5341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339345 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#800040}
-
Kuo Jen Wei authored
Makes setting view get available capture resolutions from ConstraintsPreferrer instead of DeviceInfoUpdator. The PhotoConstraintsPreferrer will first pair capture and preview resolution so as to filter out capture resolution without corresponding preview and feed the correct available options to settings view. Bug: 1113589 Test: Plugin c930e webcam, see will photo resolution options are togglable. Test: tast run -verbose <DUT> "camera.CCAUI*" Change-Id: Ifa305d48d41c7dde7bd2b5ea1f3168bfd36609ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358939 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#800039}
-
Morten Stenshorne authored
When calculating the inner border radius, just like when calculating the outer border radius, we need to specify which borders that are present, to get it right. Bug: 1119323 Change-Id: I144eea827fc7222bd4919a0be57c4cba442ed8da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362613Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#800038}
-
Cathy Li authored
This reverts commit ac85bf58. Reason for revert: We are going back to client-side change for margins, since server-side margin fix does not get the full UX we need. Original change's description: > Revert "[Feed V2] Update margins to render the external surface cards correctly." > > This reverts commit d6d62019. > > Reason for revert: We want to keep control over the margins from the Chrome side. > > Original change's description: > > [Feed V2] Update margins to render the external surface cards correctly. > > > > Bug: 1106425, b/161142289 > > Change-Id: If3c89644289b6eb1d5b61f6680f03bf95e3b6888 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303172 > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > Reviewed-by: Carlos Knippschild <carlosk@chromium.org> > > Commit-Queue: Justin DeWitt <dewittj@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#789547} > > TBR=dewittj@chromium.org,dtrainor@chromium.org,carlosk@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1106425 > Bug: b/161142289 > Change-Id: I5b01fbb8167caaa027a9d7423c1272d66c35a56b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347220 > Reviewed-by: Cathy Li <chili@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Carlos Knippschild <carlosk@chromium.org> > Commit-Queue: Cathy Li <chili@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797373} TBR=dewittj@chromium.org,dtrainor@chromium.org,carlosk@chromium.org,chili@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1106425 Bug: b/161142289 Change-Id: If95f91faa9511f8eb83f73680d92814422433377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363005Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#800037}
-
James Hollyer authored
This is part of the Core Location implementation in Chrome. This change deals with the UI element. It checks the permission from the UI side and prompts the user accordingly Bug: 1035290 Change-Id: I4af18d0d7a374336d83c1fce2e31282bf9d32cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353018 Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#800036}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Id1631a7910ff79305c95ebd52bc3576aa7c402d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366565Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800035}
-
Ravjit Singh Uppal authored
As part of the flash deprecation roadmap, this change removes the ability for extensions to use the `chrome.contentSettings.plugins.set()` API. It also invalidates already set Plugin content settings by the extensions Bug: 1115155 Change-Id: I091ec413677c434a829346de069b7e54efca1daa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355906 Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/52e107037d09..550dc4dab51d 2020-08-20 alexrudenko@chromium.org Extract node text into separate component If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1109177 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifc95db251b4dbd52c11915783626de55edee617b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366564Reviewed-by:
-
Guido Urdaneta authored
This CL adds the readable and writable fields to the RTCInsertableStreams dictionary. These are equivalent to and will replace readableStream and writableStream. The reason for this is consistency with other APIs that use stream pairs. Drive-by: rename RTCCodedVideoFrameType to RTCEncodedVideoFrameType to match the spec and update tests to comply with other API changes. Bug: 1119653 Change-Id: I64bcafb2602fb952722f1845abaeebd09f3e77d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366592Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#800032}
-
Rakina Zata Amni authored
Since unload-in-commit is not supported yet on same-site bfcache/BI/RFH swap, it's possible for unload handlers to run after the new RFH commits. We should track how often this happen to determine how risky this behavior change is. Bug: 977562, 1110744 Change-Id: I3887bec4e999c0f3d26ce0d47e48d674a727edf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348491 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#800031}
-
My Nguyen authored
Same issue as suggestion label. Fix: b/165755383 Change-Id: I144b0a4e7bb3c4c3c1a5eccd3894ae2774e90e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366379 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#800030}
-
Alice Wang authored
This CL redirects the continue URL after the signed-in account is in the cookie jar. Bug: 1093741 Change-Id: Ia19a856fa50b1a27e2373d42499908461ba8573b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339355 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#800029}
-
Ankit Kumar 🌪️ authored
Update pdf/ to use gfx::Point/gfx::Vector2d instead of pp::Point based on context. Apart from OutOfProcessInstance all other files in pdf/ now use gfx::Point/gfx::Vector2d instead of pp::Point. In the Pepper model, we have used pp::Point to denote a point as well as a 2D vector. Based on the usage of the pp::Point migrate it to gfx::Point or gfx::Vector2d. A position is represented by gfx::Point while an offset is represented by gfx::Vector2d. Bug: 1101101 Change-Id: I784fb886ff378cc7fd20722dfba6dd5ed3a55952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329105 Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:Lei Zhang <thestig@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#800028}
-
Alexander Hendrich authored
This reverts commit 95cff9e7. Reason for revert: failing tests, see https://crbug.com/1109621#c7 Original change's description: > lacros: gnubby support for LaCrOS (hid_manager) > > Because Gnubby and power gnubby in chromium would be considered as > HID devices, and this CL would enable HID devices support for LaCrOS. > > Before this CL: Lacros would try to access /dev/hidraw*, but the > permission of it is root:hidraw 660, and lacros is running in chronos > user permission. By the way, CrOS it is using dbus to access the > permission_broker, and permission_broker would access these files for CrOS. > > In this CL: Open a HidManager mojo between ash-chrome service and lacros service. > Lacros would use AddReceiver to add a receiver to ash-chrome's HidManager. > And the HidManager on ash-chrome would use permission_broker to access > /dev/hidraw* files. In this solution, we wouldn't need to compile the > permission_broker into lacros. > > BUG=chromium:1109621 > TEST=tested gnubby manually on soraka > > Change-Id: I18cfe9b5e93e260b9347df4b57ebe12a621f44a8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319089 > Commit-Queue: joe Chou <yich@google.com> > Reviewed-by: Greg Kerr <kerrnel@chromium.org> > Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800003} TBR=sky@chromium.org,jorgelo@chromium.org,reillyg@chromium.org,erikchen@chromium.org,kerrnel@chromium.org,yich@google.com Change-Id: I7cd325c2704a0b4cd18522acc977f3b45159b313 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1109621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366892Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#800027}
-
Chris Hall authored
bumping language detection switch expiry to m87. AX-Relnotes: Language detection experiment. Change-Id: I3c836fe0feca9e564afb50eeea9173096443f3de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355655 Commit-Queue: Chris Hall <chrishall@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#800026}
-
dpapad authored
- printing_icon_test.js - viewport_test.js Bug: 1000989 Change-Id: I61bf0423cca7bf6f3758ae0f7d870f29c64639a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364793 Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#800025}
-
Sundoo Kim authored
Explicitly remove the copy constructor and assignment operator with the delete keyword. Bug: 1010217 Change-Id: I3c833e16f6075c9a8ce754e5e6842c105e90265f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366514Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#800024}
-
Alex Rudenko authored
This CL adds UMA tracking histogram for the new feature of automatically fixing low-contrast colors to help answer the questions: - how often is the feature used? - what contrast threshold is being primarily used? The frontend CL: https://crrev.com/c/2360010 Bug: 1093227 Change-Id: I20d08a6049821ffb6506307bb66b0ffc1ef36ac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360069 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#800023}
-
Nidhi Jaju authored
Change-Id: Id0c704a0c67f2ff570ae1771416e5a2e8d9ffb63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362796Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju127@gmail.com> Cr-Commit-Position: refs/heads/master@{#800022}
-
Regan Hsu authored
* Plumbs PhoneHubManager from OsSettingsManager to MultideviceSection, and from there NotificationAccessManager to MultideviceHandler. * MultideviceHandler will receive NotificationAccessSetupOperation Status and notify the JS layer. * MultideviceHandler listens to Cancel and Start setup events. Bug: 1106937 Change-Id: I28a755da5f535b6b3039f1950f3458e6b3444952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364020 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/853d4ed2ff41..dc594f21c09a 2020-08-20 mtklein@google.com Revert "Add utilities to SkGeometry for quad and cubic rotation angles" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Change-Id: Id9ca0d8576b74152536c46dbdcd2f8f1fba73288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366233Reviewed-by:
-
Solomon Kinard authored
Bug: 1108940 Example: chrome.search.query({"search": "search words"}); Change-Id: I53c79a73411588596c49225482c16822257795a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333031Reviewed-by:Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#800019}
-
Wenyu Fu authored
Bug: 1108564 Change-Id: I6dc0625bdd9fe7a3f3d6329087661f2548520537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364959 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#800018}
-
Risan authored
Changing it to /storage/MyFiles-read, which provides a readable view of the MyFiles from app with WRITE_EXTERNAL_STORAGE permission. BUG=b:162791183 TEST=Photos can see file changes. Change-Id: Ibdb218f426339bf14fc8a571581a86c7849153ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359595Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Satoshi Niwa <niwa@chromium.org> Commit-Queue: Risan <risan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800017}
-
Mike Dougherty authored
Bug: 1117667 Change-Id: I3f2fb6a013697ad414c7d5458d0bebb68ee2749b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363702 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
-
Caleb Raitto authored
Bug: 973801 Change-Id: Ifa4df0c66f71f7ce2af57968b33b0127ab569067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350481 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
-
