GitLab

Bug: 803259
Change-Id: I56e270bce85c07dc2b6975ce95771916f25c8426
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049423
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740215}

This CL renames GetAppScope() to GetAppScopeInternal() and adds a new
GetAppScope() implementation that returns a default value if there's no
scope.

This is in preparation to migrate all existing uses of
GetAppScopeInternal() over to the new GetAppScope() such that PWAs
behave the same whether they passed install promotability checks or not.

There are no behavioural changes in this CL. The follow up CLs will
convert GetAppScopeInternal() calls back to GetAppScope() with slight
behaviour changes.

Bug: 910016
Change-Id: Ifd0f39beb74ff7e4de4a0f8a407c47e33cf41e1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049463
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Glen Robertson <glenrob@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740214}

This CL adds a way of creating JavaScript to replace the content of the
page with some HTML in ErrorPageHelper.

Bug: 991608
Change-Id: I31b703fee025387e20215dd6edfa6b8b2e4e8b83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027787
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740213}

https://pdfium.googlesource.com/pdfium.git/+log/72f2915aa3b4..4a0f1a01ac8a

git log 72f2915aa3b4..4a0f1a01ac8a --date=short --first-parent --format='%ad %ae %s'
2020-02-11 maawas@microsoft.com Add a null check on return value of CPDF_StructTree::AddPageNode().

Created with:
  gclient setdep -r src/third_party/pdfium@4a0f1a01ac8a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I2bf9ea862c7e9109d1b99c6154d47b2f19a5174c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049666Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740212}

This provides a central location to add content internal throttles.

Bug: 1025612
Change-Id: I6e3323f0cfa605b520a5079255e6001ab445093e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046138Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740211}

Notify WebLocalFrameClient explicitly about initial empty document
and javascript url navigations. This makes it easier to merge the following
regular case callbacks:
- DidStartProvisionalLoad;
- DidCreateDocument;
- call_before_attaching_new_document;
- DidCommitProvisionalLoad.

We should also audit whether any RenderFrameObserver actually relies on
callbacks for initial empty document and/or javascript url navigations, and
cleanup unnecessary calls.

See also RenderFrameObserver callbacks proposal:
https://docs.google.com/document/d/1uS-DrJ7fyi7ireZD3ebQdf6pRf9pjREF2wD9pQW9Yeo/view

Bug: 855189, 555773
Change-Id: Ia2650b16d8c986676c16c199f0c2abff878cd7d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879607
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740210}

Remove these support statements from documentation.

Bug: 1041827
Change-Id: I20810ed3f0d1241e76b5f742056c4c7bab88687f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044531Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740209}

This CL adds a histogram to record the state of web and app activity.
The histogram is recorded on the completion of the request. The main
goal is to track how many users have sWAA On/Off and to monitor the rate
of failure to fetch this value.

Bug: 1050070
Change-Id: Ie4b0b4020b097a29850bb4f38b34e66ea62d084b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044214
Commit-Queue: Monica Basta <msalama@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740208}

This is a reland of 9df89fda

Original change's description:
> Simplify TabStripUIEmbedder interface to avoid ThemeProvider*.
>
> This is more power than the caller needs, and requires implementers
> to have a ThemeProvider instance, which is a burden on tests.
>
> Bug: none
> Change-Id: I925890d31c4b271a1d4d80e78c3bf496391bf93f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047927
> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
> Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
> Auto-Submit: Peter Kasting <pkasting@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#740188}

Bug: none
Change-Id: I107b35c7c1baa3f10c203572e00174281044223f
TBR: tluk
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048915Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740207}

Make the export/import settings page UI more consistent:
* Use the same indent as other pages instead of the larger list item
indent
* Use the blacker primary text colour instead of the grey secondary
colour

Before:
https://drive.google.com/file/d/1-1NOHeGJQOvAtru8xjPVWE3ry2jBuDRK/view?usp=sharing
After:
https://drive.google.com/file/d/1dKCh7Jo2K4Ob3lGgiRsePIMgnxwJCktI/view?usp=sharing

Test: Manual
Bug: None

Change-Id: I294a70345b07ab2870327f30007398ebec791b26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049146Reviewed-by: David Munro <davidmunro@google.com>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: David Munro <davidmunro@google.com>
Cr-Commit-Position: refs/heads/master@{#740206}

This reverts commit 26f2d0fd.

Reason for revert: suspect it caused a complication failure.
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8888771017627327120/+/steps/compile/0/stdout
https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20Full/155985
 
Original change's description:
> Added a mojo generated Pagehandler for chrome://media-app.
> 
> This CL defines a mojom file for the mojo interface
> between the Browser and the chrome://media-app page and
> implements the relevant CPP (Page Handler) and JS
> (mojo_api_bootstrap.js) interfaces. This interface is leveraged to
> expose the native browser open feedback dialog functionality
> to the page via a MediaAppUIDelegate.
> 
> This Cl also adds the kFeedbackSourceMediaApp constant to
> the chrome::FeedbackSource enum to allow feedback dialogs
> opened by the media app to be correctly logged.
> 
> Bug: 996088,1045222
> Change-Id: Ia6f28c2330cfb592f9440778b94ebf45da89dbc2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015874
> Commit-Queue: Zain Afzal <zafzal@google.com>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Reviewed-by: Sam McNally <sammc@chromium.org>
> Reviewed-by: Trent Apted <tapted@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#740168}

TBR=xiyuan@chromium.org,tapted@chromium.org,sammc@chromium.org,ortuno@chromium.org,zafzal@google.com

Change-Id: I03751d7c0e3689bc9036134050d1aafc1c3ececa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 996088, 1045222
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050363Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740205}

Python 3 only accepts bytes and bytestrings as input for hashing.
encode() so it works on both Python 2 and Python 3.

Traceback (most recent call last):
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 557, in <module>
    sys.exit(main())
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 552, in main
    return args.func(args, remaining_args)
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 268, in _Generate
    processor._GenerateModule(args, remaining_args, generator_modules,
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 213, in _GenerateModule
    ScrambleMethodOrdinals(module.interfaces, salt)
  File "../../mojo/public/tools/bindings/mojom_bindings_generator.py", line 132, in ScrambleMethodOrdinals
    sha256.update(interface.mojom_name)
TypeError: Unicode-objects must be encoded before hashing

Bug: 941669
Change-Id: Icfb5d7b9762763b12c7795ac23261fb614eef014
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044078Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Raul Tambre <raul@tambre.ee>
Cr-Commit-Position: refs/heads/master@{#740204}

https://pdfium.googlesource.com/pdfium.git/+log/30d75835830c..72f2915aa3b4

git log 30d75835830c..72f2915aa3b4 --date=short --first-parent --format='%ad %ae %s'
2020-02-10 tsepez@chromium.org Add JS test for constructing FXJSOBJTYPE_DYNAMIC objects.
2020-02-10 tsepez@chromium.org JavaScript test for many of the possible <items> types.
2020-02-10 tsepez@chromium.org Make dump_tree.js tolerate nodes without a .children property.
2020-02-10 tsepez@chromium.org Call CJX_Template methods from JavaScript.
2020-02-10 tsepez@chromium.org Cover some more CJX_Field JavaScript callbacks.
2020-02-10 tsepez@chromium.org Add test for more CJX_Object special access methods
2020-02-07 nigi@chromium.org Roll third_party/catapult/ f7d73bb52..ea794b87a (53 commits)
2020-02-07 nigi@chromium.org Roll third_party/googletest/src/ 5395345ca..10b1902d8 (139 commits)
2020-02-07 nigi@chromium.org Roll third_party/skia/ 81d35a72a..511af2e08 (23 commits; 3 trivial rolls)

Created with:
  gclient setdep -r src/third_party/pdfium@72f2915aa3b4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I8fdee7729ae2f57397644011b7e1e8e51deafeda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049213Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740203}

In this CL, DEFINE_AX_OBJECT_TYPE_CASTS is removed and new downcast
helpers are used for below classes,
- AXImageMapLink
- AXLayoutObject
- AXListBox
- AXMenuList
- AXMenuListOption
- AXMenuListPopup
- AXMockObject
- AXRadioInput

Bug: 891908
Change-Id: Ie767c53a9b1c78ee3054b44b005cafd71edc73ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046666Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#740202}

This change addresses a couple different NGFieldset painting crashes:

1. DCHECK failure in
   NGPaintFragment::PositionForPointInInlineFormattingContext.
2. Crash inside NGPaintFragment::DebugName().

To fix this, treat legends like a box rather than its own type.
(As discussed here:
https://chromium-review.googlesource.com/c/chromium/src/+/1252581/3/third_party/blink/renderer/core/paint/ng/ng_box_fragment_painter.cc#368)

Bug: 993782,875235
Change-Id: I7ef8cb5093fb89804e68cf55dc9f0facf01d827a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042146
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740201}

The test doesn't actually care about the theme provider, only about
verifying that the bubble's theme provider was routed via the right
object.  Anything that pointer-compares differently will work.

This is part of a larger goal of trying to eliminate
DefaultThemeProvider (and ultimately ThemeProvider) from ui/ entirely.

A couple minor related fixups while I'm at it.

Bug: none
Change-Id: I666106b4fb776e2cd06aa76345513f3fb8bb0780
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048406
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740200}

This CL has two goals,
  1. Use To<TouchEvent> and DynamicTo<TouchEvent> as new
   downcast helper
  2. Use IsA<TouchEvent>(element) in place of
   IsTouchEvent(element)

Bug: 891908
Change-Id: I359b7531384fb9ccf83b0aeb0fe2123215445e0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046805
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740199}

This scope is used to map Frame to just-about-to-commit DocumentLoader.

With https://crrev.com/706529, we now call ReadyToCommitNavigation
after the commit (as opposite to before the commit). Therefore,
WebLocalFrame::GetDocumentLoader is already the right one and we don't
need a scoped mapping.

Bug: 855189
Change-Id: I95621b00ee4391986f063e56f20d8d7d25b5c532
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046210Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740198}

Previously the credits file was hard-coded and is based on an out-dated
file. In this CL, we load the credits file from the component itself, so
it will always be up-to-date and have a (relatively) conformant UI.

If we can't load the component's credits file for any reason (mount
fails, termina is out of date, termina is not installed) then we will
load the old default instead.

In a future cl we will have a specific placeholder page that says
"install crostini if you want to see credits" or similar, and remove
the hard-coded one altogether.

Bug: 876898
Change-Id: I3e94761ac48890167e6dd8fddf8e748c0bf8a557
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040792Reviewed-by: David Munro <davidmunro@google.com>
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Nic Hollingum <hollingum@google.com>
Cr-Commit-Position: refs/heads/master@{#740197}

This is more power than the controller needs, and requires implementers
to have NativeTheme and ThemeProvider instances, which is a burden on
tests.

Bug: none
Change-Id: I1afff69cbd8e02cbbe7e4663979d52e818b3007b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047928
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740196}

httpConnect2 became preferred in CUPS 1.7.  We expect that all supported
clients are now past this CUPS version.

Bug: 1020356
Change-Id: Id97a50beac7ac1d6b7f6ecd10a8e8c6303b3d4e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043031
Auto-Submit: Sean Kau <skau@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740195}

Prior to this change, SurfaceAggregator would assign a ColorSpace to
each RenderPass, based on the alpha and content needs of that
RenderPass.

This starts falling apart because SurfaceAggregator doesn't know the
final answer of "what alpha is needed by this RenderPass" and "what
color spaces are present in this RenderPass". This is because the
DirectRenderer's OverlayProcessor can add the need for alpha (because
of hole punching) or remove the need for HDR (by taking an HDR video
and promoting it to an overlay).

Change the RenderPass to store the ContentColorUsage, from which the
DirectRenderer computes the required color space.

Change the way that SurfaceAggregator decides if an HDR pass needs to
be added by calling ColorSpace::IsSuitableForBlending on what is the
expected output color space. Note that this decision is not correct
(or was it before), because it assumes that the OverlayProcessor will
not change the content or alpha needs of the RenderPass. A more
comprehensive fix would be a more substantial refactor, moving the
OverlayProcessor to be more closely tied to SurfaceAggregator.

Bug: 1049334
Change-Id: I0d21a291cf20231946e3e8fdda77742deedd5ba4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047453Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740194}

Use a flat_map instead of std::map to store node edges. This improves
the memory consumption of SubstringSetMatcher since flat_map is
internally a sorted vector.

Also, for each node, after the size of the edge map is fixed, call
shrink_to_fit on the map. This should free up any unneeded memory.

This should have no behavior change. The memory consumption of the
corresponding SubstringSetMatcher perf test reduces from ~50 Mb to ~33
Mb with small improvement in runtime.

BUG=974391

Change-Id: Ibbe055c7cffadff8f34c7cce1c7c72d7efa030fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045313
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740193}

Bug: 634140
Change-Id: Ia62211efcc09ce196e510eef639ac812657758e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035457Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740192}

This reverts commit 9df89fda.

Reason for revert: Compile failure
https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/10065

Original change's description:
> Simplify TabStripUIEmbedder interface to avoid ThemeProvider*.
> 
> This is more power than the caller needs, and requires implementers
> to have a ThemeProvider instance, which is a burden on tests.
> 
> Bug: none
> Change-Id: I925890d31c4b271a1d4d80e78c3bf496391bf93f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047927
> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
> Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
> Auto-Submit: Peter Kasting <pkasting@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#740188}

TBR=pkasting@chromium.org,tluk@chromium.org

Change-Id: I60eafb9cea18eb8468588dd2d4756ae00d36f299
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048913Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740191}

This issue was introduced in
https://chromium-review.googlesource.com/c/chromium/src/+/1196623/

This probably doesn't really matter, but once we have computed
new_coded_size, we should stop using coded_size and use new_coded_size
instead.

Bug: N/A
Change-Id: I5f4aa8ae9cdcb84dd74b310780b5082952e2dbad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043297
Commit-Queue: Wan-Teh Chang <wtc@google.com>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740190}

Add Closure type check for integration tests file_dialog.js and fix
error pointed by Closure compiler.

Add typedef for the return type of extractElementInfo() which is a JSON
object sent from the UI to the test: |ElementObject|. This replaces the
repeated definition of the same object across different function
arguments and  make the type check stronger between UI and test.

Change "remote_call.js" to depend on runtime_loaded_test_util, because
it uses it to make the remote call and to have the |ElementObject|.

Bug: 778674
Change-Id: Ief15cf5120ea11afafb64a14ceceb3e555265616
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045700Reviewed-by: Alex Danilo <adanilo@chromium.org>
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740189}

This is more power than the caller needs, and requires implementers
to have a ThemeProvider instance, which is a burden on tests.

Bug: none
Change-Id: I925890d31c4b271a1d4d80e78c3bf496391bf93f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047927
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740188}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/71d30b9c1aff..26a68eeffcd0

git log 71d30b9c1aff..26a68eeffcd0 --date=short --first-parent --format='%ad %ae %s'
2020-02-11 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@26a68eeffcd0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I9bb8b911cc612a66dd4a9f53649a61a4d777ceb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048932Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740187}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome

BUG=762641
TBR=chrome-os-gardeners@google.com

Change-Id: I3dad2666367c06cfa698fa19987de94e87abc745
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047459Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740186}

This CL creates InfobarModalCompletionNotifier, which notifies observers
when all the OverlayRequests for modal UI for an InfoBarIOS are
completed.  This is owned by InfobarOverlayRequestInserter, and is used
by InfobarBannerOverlayRequestCancelHandler to cancel banners after
the completion of the detail sheet and modal UI for that InfoBarIOS is
finished.  To facilitate this animation, the default behavior for UI
cancellation via OverlayPresenter was updated to become animated.

This CL also creates FakeOverlayRequestCancelHandler, which is used
by OverlayRequestQueueImplTest and InfobarModalCompletionNotifierTest.

Bug: 1030357
Change-Id: If0bb73537ea6d7304725a580b0de27b345dbb8de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031767
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740185}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8ebf72467db7..549953bc1d82


Created with:
  gclient setdep -r src-internal@549953bc1d82

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: Ibc49d57e8aae68334485927378794f67611c212c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048930Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740184}

This is the first of three patches to allow Web Authentication in Clank
to perform origin checks in the browser process.

This CL refactors the security checks into a separate class, and
adds content APIs that allow them to be invoked by WebAuthn request
handlers outside content. The refactor also adds a central place that
hopefully makes it easier to make changes to the security policies in
specific situations, in future.

The second CL will have the WebAuthn request handler code in Clank
internal to call these APIs.

The third will remove the security checks currently performed in the
renderer process.

Bug: 827542
Change-Id: Icf5cc4df2e02c5dee8c2211adac34e90832cae90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031548
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740183}

Test got disabled by mistake on CL:1797843.

Change-Id: I4f0030a7936cf324929acfcf785891ca600dfcda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049405
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Austin Tankiang <austinct@chromium.org>
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Austin Tankiang <austinct@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740182}

In this CL, DEFINE_TRANSFORM_TYPE_CASTS is removed and new downcast
helpers are used for below classes,
- Matrix3DTransformOperation
- MatrixTransformOperation
- PerspectiveTransformOperation
- RotateTransformOperation
- RotateAroundOriginTransformOperation
- ScaleTransformOperation
- SkewTransformOperation
- TranslateTransformOperation

Bug: 891908
Change-Id: Ie5f51f1133cb7fbef2c67ca2be493ba6d0d25eb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046943Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#740181}

fprintf is often times not useful on Windows. OTOH, DLOG is
is often sent to a more visible location. This makes
NGLayoutInputNode::ShowNodeTree() use DLOG instead of
fprintf.

BUG=none
TEST=none

Change-Id: I973fe8354beefbf2622ed8f4040bbaed86ee22e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047985Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740180}

Currently, in each AhoCorasickNode we store the ids of all patterns
which are a suffix of the current node.

Change this to store an output link at each node. The output link would
point to the longest proper suffix of the current node which is also a
leaf node (represents a patterns). This should improve the memory usage
from SubstringSetMatcher.

Additionally, disallow duplicate patterns as inputs. This should have no
behavior change since all SubstringSetMatcher clients already  don't
provide duplicate strings as inputs.

Also, add some comments regarding the complexity of various operations.

This CL should have no behavior change. It reduces the memory
consumption in the corresponding SubstringSetMatcher perftest on my
machine from ~55 Mb to ~50 Mb.

BUG=974391

Change-Id: Ib7923842b2963187346d8902ba1244ca906a0443
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042327
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740179}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: I549df10109b220e1c3c6a92353ffdec5c6ec3452
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049305Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740178}

https://skia.googlesource.com/skia.git/+log/f83d0346c06a..88c3793a4eaa

git log f83d0346c06a..88c3793a4eaa --date=short --first-parent --format='%ad %ae %s'
2020-02-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/skia@88c3793a4eaa

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC stani@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: stani@google.com
Change-Id: Iec68ea92c3625690bc35675183a1905a48c1ba6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048928Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#740177}

This reverts commit ef2cc102.

Reason for revert: The failing tests just need rebaselines.

Original change's description:
> Reland "Fix 0,0-0x0 turning into PaintOp::kUnsetRect."
> 
> This reverts commit 0fde9a92.
> 
> Reason for revert: Test breakage in 
> * virtual/scalefactor200withzoom/fast/hidpi/static/validation-bubble-appearance-hidpi.html
> * virtual/scalefactor150/fast/hidpi/static/validation-bubble-appearance-hidpi.html
> 
> at https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29
> 
> Original change's description:
> > Revert "Fix 0,0-0x0 turning into PaintOp::kUnsetRect."
> > 
> > This reverts commit 0156c949.
> > 
> > Reason for revert: series of review fixes resulted in a no-op code. The completely different approach should be used to fix the bug correctly.
> > 
> > Original change's description:
> > > Fix 0,0-0x0 turning into PaintOp::kUnsetRect.
> > >
> > > When a paint chunk having 0,0-0x0 rect is processed inside an effect, an early
> > > return prevents the effect_bounds_stack_.back() update in a
> > > ConversionContext::UpdateEffectBounds call. This results in keeping default
> > > PaintOp::kUnsetRect in SaveLayerOp::bounds instead of 0,0-0x0 rect.
> > >
> > > This is probably a reason for a related bug 918240 (see bug thread Comment 4 for
> > > details). Application of this patch fixes the lagging print preview.
> > >
> > > R=​fmalita@chromium.org, samans@chromium.org
> > >
> > > Bug: 918240
> > > Change-Id: I022ae01418e83184421cff7e22566228a2f7c6d3
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1396958
> > > Commit-Queue: Denis Bessonov <dbessonov@yandex-team.ru>
> > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#714293}
> > 
> > Bug: 918240
> > Change-Id: I89a55d39a53559b37168b91adf3f331dbbf8b106
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007409
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Auto-Submit: Denis Bessonov <dbessonov@yandex-team.ru>
> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#733491}
> 
> TBR=wangxianzhu@chromium.org,pdr@chromium.org,dbessonov@yandex-team.ru
> 
> Change-Id: If99b75af33c3a00f64eec91b4c711879f3665ce0
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 918240
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011843
> Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
> Commit-Queue: Thiemo Nagel <tnagel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#733558}

TBR=wangxianzhu@chromium.org,pdr@chromium.org,tnagel@chromium.org,dbessonov@yandex-team.ru

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 918240
Change-Id: I886c70eec38907fd51c0f3a00ba50ba7c3acdfe1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047766Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740176}