- 14 Sep, 2020 40 commits
-
-
Matt Menke authored
Rename URLRequestJobFactory::ProtocolHandler::MaybeCreateJob() to CreateJob(), since it can't fail, and make it return a unique_ptr, which is plubmed up through URLRequestJobFactory to URLRequest. Also remove the unused URLRequestTestJob::CreateProtocolHandler() method and the implementation of ProtocolHandler it returned. Bug: 354158 Change-Id: I277b1e367a39b8d0d345f78d9196fe9db6430f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401328 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#806583}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1960f3b2. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I091899197285fea96c70ff1fc8edb2121760b2c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407380Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806582}
-
Jan Wilken Dörrie authored
This change adds a CHECK(str) into BasicStringPiece's constructor from `const value_type* str`. This prepares the code base for switching to std::string_view, since std::string_view(nullptr) would invoke undefined behavior. Bug: 1049498 Change-Id: Id5d832bc0586dc16a5e1045ba67602e4dc57317d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407712 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#806581}
-
Pavol Marko authored
It has been flaky on Chrome OS for a while. TBR=afakhry@chromium.org Bug: 1127805 Change-Id: I16d3b25015a6785ccef0edd6db45e7c910dfd4b8 sheriff: Only call GetPreviousURL on committed/error navigations Speculative fix for https://crbug.com/1127797 TBR=estark@chromium.org Bug: 1127797 Test: CQ Change-Id: I0ebc142960a4f9bea3df626123210367df6f8d35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409433Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#806580}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/183a454b9d54..75d257686e00 2020-09-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from fe51fcb5 to 1960f3b2 (467 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Change-Id: I00f0e4258e167e7e36919813b6e533071088a92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409373Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806579}
-
Frédéric Wang authored
This CL aligns with a recent resolution from the CSSWG: https://github.com/w3c/csswg-drafts/issues/5385#issuecomment-690462275 This also ensures that LayoutObjectFactory::CreateMath always receives a MathML element. The new test fails when MathML Core (in particular LayoutNG) is disabled because math display values are not supported. Subtests fail when MathML Core is enabled because multiple display values are not supported. Bug: 1127222, 6606 Change-Id: Ica5558f221960d0f80609dfe0e56c029de7e9c3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404789Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#806578}
-
Richard Knoll authored
This makes it clear which device will have to have the NearbyShare UI open in order to be visible. Bug: b/167692425 Change-Id: Iaef8a0bdba3a00c40249787972feec06ec13a53c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400979Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#806577}
-
Ye Kuang authored
https://chromium.googlesource.com/infra/infra/+/18502e6a01811b0c2dd2a0250e81bd82e47d2c2d Bug: 1127205 Change-Id: Ia58d7727f1b877bd4c48b62fa4c0872bd449be50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409393 Commit-Queue: Ye Kuang <yekuang@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#806576}
-
Yoshisato Yanagisawa authored
All builders using lib/try.star will use the task service account by default. All the task service accounts used for accessing Goma have already been granted. Bug: crbug.com/1105814 Change-Id: Ib0bfd2feb6d04453f87801a56c276eae13bfb6a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408882Reviewed-by:
Fumitoshi Ukai <ukai@google.com> Reviewed-by:
-
Nohemi Fernandez authored
Currently we use default initialization for creating ManageAccountParams in SigninHeaderHelper, which causes the uninitialized variables to be undefined and crash on a physical device. https://ci.chromium.org/p/chrome/builders/ci/ipad-device/12249 Bug: 1126746c Change-Id: I04e10d69925ad1887d3cf144d45fc5465680d63d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404794 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#806574}
-
Roberto Moura authored
As specified in the "Thumb Strip Layout" subsection of the Thumb Strip design doc (go/bling-thumb-strip-design): - Create a new Horizontal Layout class. - Create a Tab Switcher Layout class that will contain the intersection of the new Horizontal Layout and the existing Grid Layout. - Make the Grid Layout and Horizontal Layout subclasses of the Tab Switcher Layout. Bug: 1127604 Change-Id: I8da3e43563e6a18abb3bf0234db26aeccefc8e06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367092 Commit-Queue: Roberto Moura <mouraroberto@google.com> Reviewed-by:
-
Matthias Körber authored
This CL adds a structured component tree for addresses and regular expressions to parse address lines into their components are introduced. Additionally, for most structured address component types the zero-argument constructors are removed, since they are not supposed to be used as root nodes and should always be constructed with a supplied parent-node pointer. Change-Id: Ie7e2548d9f52a61c003cb263111bce2ab9d97602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388460 Auto-Submit: Matthias Körber <koerber@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#806572}
-
Maria Kazinova authored
This histogram was initially introduced to verify an assumption and now it's done. Change-Id: Iaef07a9977d13379c7d41f267a88d8f52ef8ca44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405577Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#806571}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2de7d3af0c0e..726af6f78f80 2020-09-11 afdx@google.com Add missing file to BUILD.gn (#3798) 2020-09-11 antonikarp@google.com spirv-fuzz: Add TransformationDuplicateRegionWithSelection (#3773) 2020-09-11 afdx@google.com spirv-reduce: Support reducing a specific function (#3774) 2020-09-10 afdx@google.com spirv-reduce: Refactoring (#3793) 2020-09-10 afdx@google.com Favour 'integrity' over 'coherence' as a replacement for 'sanity'. (#3619) 2020-09-10 antonikarp@google.com spirv-fuzz: Fix header guards in transformations/fuzzer passes (#3784) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,jmadill@google.com Change-Id: Ic402f57e4e234b9ee88f01864cc5ba2c9fb1e27a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409372Reviewed-by:
-
Colin Blundell authored
This flake was likely caused by https://bugs.chromium.org/p/chromium/issues/detail?id=1116311, as indicated on https://bugs.chromium.org/p/chromium/issues/detail?id=1116247 ; re-enabling to verify that that is the case. Original change's description: > Disable flaky test InfoBarTest.testTabDestruction > > org.chromium.weblayer.test.InfoBarTest.testTabDestruction is flaky on > Android, > https://analysis.chromium.org/p/chromium/flake-portal/flakes/ > occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVydwsSBUZsYWtlImxjaHJvbWl1bUB3ZWJs > YXllcl9wcml2YXRlX2luc3RydW1lbnRhdGlvbl90ZXN0X2Fwa0BvcmcuY2hyb21pdW0ud2Vi > bGF5ZXIudGVzdC5JbmZvQmFyVGVzdCN0ZXN0VGFiRGVzdHJ1Y3Rpb24M, > disable it for now until it is fixed. > > TBR=blundell@chromium.org > > Bug: 1116247 > Change-Id: I98a6348a7120de2adb121b221084965ab6cac1e8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355389 > Reviewed-by: Lan Wei <lanwei@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797974} TBR=blundell@chromium.org,lanwei@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1116247 Change-Id: Ie1e34760d5b3e2f82bcbc39a057c85bcb718b71f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407256Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#806569}
-
Matt Falkenhagen authored
The callback must only be invoked with a ready registration, which can only be guaranteed if we don't post a task to run the callback once the registration is ready. Bug: 1127724 Change-Id: If847409a61b3ce0f77de1370acb5b6b9acb29c02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407934 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#806568}
-
arthursonzogni authored
This task was first mentioned in comment: https://chromium-review.googlesource.com/c/chromium/src/+/2320508/comment/3a3a75de_c928db32/ and reported in: https://crbug.com/1113294 At the moment, there are a number of attributes hold by the NavigationRequest passed to the new document when it commits. Some are set before calling DidNavigate, some after. DidNavigate calls the content/public DidFinishNavigation event. We need to ensure that all the navigation-related observer-visible state is set before that to ensure that the arbitrary observer code can see the consistent state of the world (DidFinishNavigation implies that the navigation has finished and all navigation-related states have been updated). This patch sets all the attributes in DidCreateNewDocument() Moreover, there are a number of states updated no matter whether the navigation created a new document or not. They are likely all wrong. This patch added TODO and future patches will update them by CCing the appropriates feature owners. Bug: 1113294 Change-Id: I6fd75f5163ccd6308bae7ce27a0a925aa155437a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395777 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#806567}
-
arthursonzogni authored
Disable this test on Marshmallow, because it it consistently failing since it was added. TBR=jds@google.com,dtrainor@chromium.org Bug: 1127786 Change-Id: Iacf3ac30bdabad95c510548920c872ed0cb8c7af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409432Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#806566}
-
Zhuoyu Qian authored
There is a typo in the last commit[1], we should use LegacyOverrideBuiltIns. The last three letters are "Ins", not "ins". This patch rename it. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/2359880 Bug: 1072773 Change-Id: I195ace9d6c9def3103b9d790179e737329543b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404513Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#806565}
-
Austin Tankiang authored
This adds a field to DriveConnectionState that indicates whether hosted files can currently be pinned or not depending on extension and flag state. Bug: 1115028 Change-Id: I903789655b72badbc70392dd792774a302d85d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400018 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#806564}
-
Sigurd Schneider authored
The network handler was not converting raw HTTP headers from the (expected) Latin1 encoding to UTF8 before sending them to the DevTools front-end. This resulted in characters being missing from the string. Bug: chromium:1119729 Change-Id: I054d66f7fb6ce51945e4b8817b334fa0e28cb8da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404928 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#806563}
-
Gauthier Ambard authored
This CL makes sure that the popup menu view controller isn't computing a new preferred content size while it is getting dismissed. This is to prevent a hang. Fixed: 1126618 Change-Id: I865b4ae7ee7f7483434746fae88f7e7de8ae6dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404935 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#806562}
-
Christopher Cameron authored
GpuMemoryBuffers from capture are backed by CVPixelBuffers, which need to be specially annotated because their IOSurfaces will always report IOSurfaceIsInUse as true. The MACOS_VIDEO_TOOLBOX usage flag can be used to indicate that IOSurfaceIsInUse is not usable. Bug: 1125879 Change-Id: I9cdcb57d6c47a8ac0aa5cd3bb120b7b91113a508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409215Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#806561}
-
Henrik Boström authored
This reverts commit ca1323fe. Reason for revert: When resolving a merge conflict, some of the changes were accidentally not included in the patch that landed, causing NV12 not to be recognized. Original change's description: > [macOS Capture] Recognize NV12 and prefer it by default. > > The current default is YUVY, which despite not being supported by any > cameras we've tested, is preferred[1] over the currently recognized > YUY2, which IS supported by most cameras we've tested. See [2] and > https://crbug.com/1124647. > > This CL changes the default to NV12 and makes it a recognized format. > This pixel format is more preferred (according to [1]) than both YUVY > and YUY2. An alternative would be to default to YUY2 instead, and YUVY > wouldn't be picked because it isn't in the list of supported formats, > but we have reason to believe that NV12 is a better choice for future > WebRTC patches and that this format is supported by the Chrome > rendering pipeline. > > NV12 is a planar pixel format, it has 2 planes and is contiguous in > memory. To support this, this CL adds support for planar (along with > the old nonplanar) contiguous buffers. We don't care how many planes > there are, as long as the buffer remains contiguous. > > [1] https://source.chromium.org/chromium/chromium/src/+/master:media/capture/video_capture_types.cc;l=18;drc=9e9c1706881c9a04f124ade622c10460d14fd9f5?q=media::VideoCaptureFormat::ComparePixelFormatPreference&originalUrl=https:%2F%2Fcs.chromium.org%2F > > [2] https://docs.google.com/document/d/1kcJ0Km5kAvrNFB6o7RG89bpvjOhgEo-0qorg5qm7KyA/edit?usp=sharing > > Bug: chromium:1124647 > Change-Id: I5c92e1de73922fd9ee87d8a5892438f61f2f56bd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391064 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: ccameron <ccameron@chromium.org> > Commit-Queue: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806084} TBR=ccameron@chromium.org,hbos@chromium.org,guidou@chromium.org,handellm@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1124647 Change-Id: Ic18244136bd9ddb4144b2ff077bbb8198b457cb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408313Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#806560}
-
Kuo-Hsin Yang authored
Implement the OOM Kills histogram by checking the oom_kill field in /proc/vmstat instead of monitoring the kernel log. Bug: 1124182 Change-Id: I8e992933e394104658ac01c4f123ece411f7bc26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402778Reviewed-by:
Cheng-Yu Lee <cylee@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#806559}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1600041484-c6ff66b09b98954e0f795d944deaf8a778f8e0c8.profdata to chrome-mac-master-1600062449-eb397872f2f81f98b45c4ec794b206b9a087897d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I901b2c550c54dd303f5a6e25698602a807fdc04b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409169Reviewed-by:
-
Makoto Shimazu authored
Bug: 824858 Change-Id: I28cae38ddfa0dd451917ce699868e722f5ffb177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407628 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#806557}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6e621a98a0b7..01a6665d9a38 2020-09-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I054fd18992cddaf5772a78d593c41aa7af9cd323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409162Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I6faa7b6726fa85a8e4bd65785fe3ce98a9c93be7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409164Reviewed-by:
-
Antonio Sartori authored
The feature out-of-blink-CSPEE moves the check for Content-Security-Policy: Embedded Enforcement from blink to the browser. The feature has been fully implemented in several CLs, and it should now be safe to turn it on by default. Bug: 1094909 Change-Id: Ifa59513a5e2bb97d47b197866af492fedaf44c7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397697Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
-
Mark Cogan authored
This CL enables iPad multi-window on trunk by default. Change-Id: I919f62fc8f0068071358a9148ba0533a9abedbfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404929 Auto-Submit: Mark Cogan <marq@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
The crash is likely because the function posted a task to call the callback. By the time the task runs, the registration may no longer be ready. The callback accesses active_version() which is now null. The fix is to require the function to be called on the core thread, so the callback can be called on that thread without posting a task. We should do this for all the Find* functions too, in subsequent commits. Bug: 1062538, 1127724 Change-Id: I5b2f943c50be576dbd1dfb89eee5536e83b41766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405754Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/81a7629b202f..081bc32703b7 2020-09-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from d14e6a0b to 2ab7a04e (486 revisions) 2020-09-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 0c8f66c7169c to 183a454b9d54 (14 revisions) 2020-09-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 41974f57973e to dc552fcef1fe (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1078754 Tbr: scroggo@google.com Change-Id: If045c5eb0f9778ecd5824ed6c75c96be23b23793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409163Reviewed-by:
-
sandromaggi authored
This continues the effort to make |WebController| actions use |ElementFinder::Result| instead of |Selector|. It also adds some missing tests to cover the new scenarios. Bug: b/168107066 Change-Id: If4dd4271972ae30f9c3344d976342f9f6d864024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406165 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#806550}
-
Khushal Sagar authored
Currently the logic is limited to cases with multiple videos onscreen but we can be more aggressive with enabling this for single video cases as well if the site opts-in. R=zmo@chromium.org Bug: 1114184 Change-Id: Ic418132e960a8f98e3cf722a406100639c023bdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405993 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#806549}
-
Rune Lillesveen authored
Bug: 891944, 881752 Change-Id: Ib1f291cf6c19adf50c97138d3bb1e9705aafee7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409292Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#806548}
-
John Chen authored
Unit test Device.StartStopApp is failing on msan builds due to an uninitialized variable, introduced by crrev.com/806405. Fixing it. TBR=shengfa@google.com Bug: chromedriver:2421 Change-Id: I26e5bceb30d3ba82de5c6502f71a5297617240be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408884Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#806547}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600041484-5728f1bbdb3072c9a2ada1afd02e69514bec4d41.profdata to chrome-linux-master-1600062449-3179a4da9bad3e513a066b6120519028fcbec2a4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com Change-Id: Ia3282bdca7304442edf5026b71fb5e20fbc627b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409167Reviewed-by:
-
Ben Wells authored
In a multiprofile session, windows can be sent to other desktops. This can be done to the Files app, and when files are opened when it is in this state the apps may open on the original desktop (i.e. that of the profile that owns the files). When this occurs an info message is displayed as otherwise it appears to the user as though nothing happened. The files app shows this message for web apps even though they are opened on the current desktop. This change stops the info message being shown in this case. This change also adds some clarifying comments and also adds some TODOs for other situations that might have similar bugs. Bug: 1109589 Change-Id: I9ceab68fc6547813d4e83f879e04adbcf07a1093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359870Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#806545}
-
Alexey Baskakov authored
Disable CrExtensionsManagerTestWithIdQueryParam.UrlNavigationToActivityLogFail TBR=rdevlin.cronin@chromium.org Bug: 1127741 Change-Id: I43680caf65185718fcfce1e2d2f3a8484b6a1c30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409055Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#806544}
-
