- 30 Aug, 2019 40 commits
-
-
Danyao Wang authored
Skip-to-GPay is an experimental flow that skips the payment sheet for {basic-card, GPay} hybrid requests. Today requests for shipping and contact information is fulfilled using autofill data, this requires the payment sheet to be shown to the user to confirm the information. Since the Payment Handler API does not yet support a general mechanism for delegating shipping and contact information to payment handlers, this patch is part of a bridge solution customized for GPay. With this patch, the renderer process will detect {basic-card, GPay} hybrid requests that are eligible for the skip-to-GPay flow. Then it creates a copy of the merchant-provided GPay-specific-data, and sets additional parameters to request shipping and contact information from GPay based on the merchant-provided PaymentOptions. The copy is passed to the browser process to make a final decision (based on a Feature flag) whether to invoke the skip-to-GPay flow. The browser process changes will be landed in a separate patch. Design Doc: https://docs.google.com/document/d/1rCA4tk1xS3nwiRqmAk1eCAh64K55wHOE1JWYNTqm9LQ/edit# Bug: 877284 Change-Id: I7822fe0157fa6ee77e48035a2c1c0fae41168c8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769853 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#692072}
-
Becca Hughes authored
Remove deprecated media engagement fields from the chrome://media-engagement WebUI. BUG=998892 Change-Id: I5dadab504404602c22c5773411816eb4c7518b71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776398 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
-
Eric Stevenson authored
Bug: 995405 Change-Id: I3a82aed914760f2bc7076ae7710daac23e3f1bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776484Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#692070}
-
Bailey Berro authored
Replace the subpage arrow with an external link icon for the "Report an issue" row in chrome://settings/help and chrome://os-settings/help Bug: 999331 Change-Id: Iaf14bc19781df1d5129e89a2c27a9bf96d29d6b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777140 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#692069}
-
Finnur Thorarinsson authored
Bug: 999102, 860467 Change-Id: Ie56145c9e838f3942ac0ce04b4bb4e996e162b6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778050 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#692068}
-
Maksim Ivanov authored
This adds implementation that displays a message to the user when a problem occurs in the security token PIN dialog during SAML user sign-in (a.k.a. smart card login). The problem message consists of an icon, the error's text and the number of left attempts. Bug: 964069 Change-Id: Ia4014ebbbac49e59db2864ea8fe50a6b94034bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753002Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#692067}
-
Sophie Chang authored
Maybe this will fix the error on O phone since I have no debug info in those logs... Bug: 999349 Change-Id: Ie7fc3927b2c27acf0204e9fa339e1ac7e805575c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777122Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#692066}
-
Evan Stade authored
This partially reverts commit 5fce07b7. It might have caused flaky failures in BrowserCloseManagerBrowserTest. Also re-enable the tests. TBR=avi@chromium.org Bug: 997649 Change-Id: I2c0766a0a51affc01f76c14c64e9f7ca27d8c0de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776606Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#692065}
-
kylechar authored
On mac the browser process gets vsync parameters and sends them over IPC to the display compositor. We don't need to provide a callback so the GPU can also provide vsync parameter updates. At best the GPU never uses the callback, at worst the GPU uses the callback when it shouldn't. Bug: none Change-Id: Idf0a3833d620bee6393080b059fbde2bf4592510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700462Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#692064}
-
sebsg authored
Bug: 999535 Change-Id: I309d06116d5432867d4dedee0606e15c5164c4b6 Tbr: tkent@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778402Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Auto-Submit: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#692063}
-
Vladislav Kuzkokov authored
'printers-added' event adds destinations without capabilities. Capabilities and policies are pulled by getPrinterCapabilities() native call but only capabilities are applied. This happens most often in managed guest session where there isn't last selected printer most of the time (for which it works a bit differently). Bug: 998103 Change-Id: Ibcb0965a01ff06bbd503edcc57a54b142df04903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772163Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#692062}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/25eb47ccf18f..8b14b0dea605 git log 25eb47ccf18f..8b14b0dea605 --date=short --no-merges --format='%ad %ae %s' 2019-08-30 hbos@webrtc.org Revert "Refactor SCTP data channels to use DataChannelTransportInterface." 2019-08-30 sakal@webrtc.org Interface for monitoring ref counts of texture buffers created by SurfaceTextureHelper. 2019-08-30 nisse@webrtc.org Delete unused logic for audio RtcpMode::kOff 2019-08-30 ilnik@webrtc.org Revert "Add core multi-channel pipeline in AEC3" 2019-08-30 ilnik@webrtc.org Use HasOneRef to ensure safe reallocation of buffer in EncodedImage 2019-08-30 nisse@webrtc.org Delete audio methods SignalNetworkState 2019-08-30 kkinnunen@nvidia.com Fix test_support_unittests with enable_iterator_debugging=true 2019-08-30 terelius@webrtc.org Add support for unsigned parameters in FieldTrialParser 2019-08-30 peah@webrtc.org Add core multi-channel pipeline in AEC3 2019-08-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 71facea1..ea980c90 (691823:691937) 2019-08-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3a1d849d..71facea1 (691713:691823) 2019-08-29 peah@webrtc.org Increase the maximum supported sample rate to 384000 Hz and add tests 2019-08-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 52323b9f..3a1d849d (691589:691713) 2019-08-29 mellem@webrtc.org Refactor SCTP data channels to use DataChannelTransportInterface. 2019-08-29 tommi@webrtc.org Remove lock for process thread pointer from PacedSender. Created with: gclient setdep -r src/third_party/webrtc@8b14b0dea605 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:b/139745386,chromium:None,chromium:none,chromium:None,chromium:None,chromium:None,chromium:None,chromium:none Change-Id: I2caca99d25229750bf3e5c408c8b67ee9fb2677d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777970Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692061}
-
Tom McKee authored
To get L3 behaviour before, users would have to pass a special command-line flag, --enable-blink-features=CustomUserTiming. This changes makes L3 the default behaviour. The intent-to-ship for L3 can be found here: https://groups.google.com/a/chromium.org/d/topic/blink-dev/CWN34Qo8icI/discussion Users can opt-out of L3 by passing --disable-blink-features=CustomUserTiming. Bug: 758385 Change-Id: I316b2a929fc0748c3b9a9c1ef3d4c551ae00eafa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758715Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#692060}
-
sebsg authored
This reverts commit b9e16d2b. Reason for revert: Speculative revert for Unexpected Failures: * http/tests/devtools/a11y-axe-core/elements/event-listeners-a11y-test.js * http/tests/devtools/a11y-axe-core/security/security-origin-a11y-test.js * http/tests/devtools/a11y-axe-core/sources/sources-editor-pane-a11y-test.js See builds https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/3809 to https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/3842 Original change's description: > devtools: Prepare for service worker UI thread core. > > The thread ServiceWorkerContextCore lives on (the "core thread") will move from > the IO thread to the UI thread when the ServiceWorkerOnUI feature is enabled. > > This CL makes DevTools aware of the core thread instead of assuming the IO > thread. This makes https/tests/devtools web_tests pass when the feature is > enabled. > > Bug: 824858 > Change-Id: I20e38f50998f4b0cd9d8b8cc43526665d92dbf94 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775655 > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691689} TBR=falken@chromium.org,caseq@chromium.org Change-Id: I2d49a0fe27f033a7b8bd74e3a50fd9d78a4f1f58 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 824858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778403Reviewed-by:
-
Avi Drissman authored
Before, Views menus closed when the main menu was opened; make it so that they close when any menu opens. BUG=985675 TEST=as in bug Change-Id: I269a1e699def76abc79c4e496ec734936ae18f59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775735 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#692058}
-
Jeevan Shikaram authored
This CL adds a new app permission view settings subpage to display the different permission views. Bug: 919531 Change-Id: I85896670dd3ca9d8e9514d337265cbf73b26e181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772873 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#692057}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 39eca077. With Chromium commits locally applied on WPT: 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." 2d090a27 "[WPT/referrer-policy] Call getRequestURLs() for each subtest" c906513f "[WPT/common/security-features] Rename source context names" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I403312d49db5296a46fc1f30a25b9d76c2c03936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778004Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692056}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/575699569e91..b30ba90aec5b git log 575699569e91..b30ba90aec5b --date=short --no-merges --format='%ad %ae %s' 2019-08-30 rmistry@google.com Fix spreadsheets page set for RecreateSKPs bot Created with: gclient setdep -r src/third_party/skia@b30ba90aec5b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: None Change-Id: I645a120ac25f4df5a70f8e189ce2413626c55b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778341Reviewed-by:
-
Vasilii Sukhanov authored
That way the experiment group 'Enable' will only apply to those who use the feature. Bug: 986298 Change-Id: I282b75c43ecfd941c032a6d3f275e46fb5d5e82d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777926 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#692054}
-
Xida Chen authored
We have kFrameSequenceTrackerTypeNames defined in the compositor_frame_reporter.cc and kBuiltinSequences defined in the frame_sequence_tracker.cc, where these two essential represents the same thing. This is problematic, that when we add an entry in one place, the other place must be adding that entry too. This CL defines kFrameSequenceTrackerTypeNames as static in the CompositorFrameReporter class and then FrameSequenceTracker can just use it. No behavior change should be introduced. Bug: None Change-Id: I0dc9e40be82d147615e1aa61afb1a7d8750390e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774831 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#692053}
-
Igor authored
When the device is disabled, we receive from the server RESTORE_MODE_DISABLED mode. The client has no information if the policy forces to re-enroll or not. In the initial implementation it was treated as device not being forced to re-enroll. This change fixes that case, so that the flags from VPD don't get deleted for disabled device. Also with a test image, the install_attributes file is deleted while the checksum remain on disk. This has yet to be investigated, but to avoid any problems when install_attributes file is corrupted, we set the device as being in DEVICE_MODE_ENTERPRISE if auto_enrollment detects the device is disabled. BUG=chromium:996059 TEST=Manual tests and unit tests Change-Id: I8bc30028af043fdb563e6374d7e5db4b30830218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771966Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#692052}
-
Takuto Ikuta authored
Largest file is 11MB in xcode_binaries cipd package, so I think copying these files fine. symlinks point to cipd cache do not work correctly on swarming. This fixes that by using copy. Bug: 988079 Change-Id: I00861c59d637d5931fbf6aa0f7b169b1e80ebe7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777846 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#692051}
-
Huanzhong Huang authored
Follow-up to crrev.com/c/1685382; naming adjustment on cookie controls. Bug: 967668 Change-Id: I34b65d59764d489e390d6dffbe5042a07b20a4f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777867 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Commit-Queue: Florian Uunk <feuunk@chromium.org> Reviewed-by:
Florian Uunk <feuunk@chromium.org> Cr-Commit-Position: refs/heads/master@{#692050}
-
Stephen McGruer authored
This is a reland of 6caf7e08. The original patch had a nullptr crash when the Settings was null - this version fixes that. Original change's description: > Hook up animations to ValidationMessageOverlayDelegate > > ValidationMessageOverlayDelegate hosts an internal blink::Page > which is not properly integrated into the normal BeginMainFrame > flow. As such, it needs to be manually prodded in various places. > Integration already existed for layout and paint - this CL adds > animations as well. > > This previously worked because blink::AnimationClock would advance > its own time (against the spec), and so the internal Page would see > advancing time and the animation would keep ticking. When we fixed > blink::AnimationClock to be by the spec, we also broke this. > > This CL also makes sure that the animation used by > ValidationMessageOverlayDelegate is not composited; the internal Page > has no compositor so composited animations will not work. > > Bug: 990680 > Change-Id: I16aaddbfa57eaefadfb557fc9cb435d94672e637 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763162 > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691673} Bug: 990680, 999333 Change-Id: I16c9138b63eefe0b32e66ebc562ffa836181b07c TBR=flackr@chromium.org,pdr@chromium.org Change-Id: I16c9138b63eefe0b32e66ebc562ffa836181b07c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777109Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#692049}
-
Sebastien Marchand authored
Bug: 998546 Change-Id: Ibad528d47add2430955af8142aa1372fee5d0648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774792Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#692048}
-
Ilya Bizyaev authored
Implement Ansible playbook generation for APT package management in the Crostini container. The code is not wired up with preferences or policies at this point and accepts strings of JSON input. This code will be used in a handler for an experimental enterprise policy on Chrome OS. Bug: 993321 Change-Id: Ifb07f787a1daf6b2829a8cce73e30b990e25116e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751253 Commit-Queue: Ilya Bizyaev <ilyabiz@google.com> Reviewed-by:
Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#692047}
-
Julie Jeongeun Kim authored
This CL replaces |client_binding_| with |client_receiver_| from WebSocketHandleImpl to use new Mojo types. Bug: 955171, 978694 Change-Id: I3a60e4c4a60b8edb769f006d92f2339ffe32101b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777341Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#692046}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f24c9f2dff49..4c470eee0063 Created with: gclient setdep -r src-internal@4c470eee0063 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: If10fc6e3e49fbea8a52320309034dfea0a1ec010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778263Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692045}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/321c5840..66a74a65 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I663a4067e4b7cb5daf39459dfca0ca221e837cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778002Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692044}
-
Philip Rogers authored
In the following example, we do not need to composite the first transform: <div id="first" style="transform: translate(10px, 10px); width: 100px; height: 100px;"> <div id="second" style="will-change: transform; width: 50px; height: 50px;"></div> </div> Pre-BlinkGenPropertyTrees, this was required to ensure a composited cc::TransformNode existed, but this can now happen without a composited cc::Layer. This should reduce memory: On the top 10k pages, 2% of GPU tile memory is due to layers with the kTransformWithCompositedDescendants compositing reason. This was determined using a metrics collection patch on cluster telemetry: https://docs.google.com/spreadsheets/d/1cCFRHDG9Uu0dbGETmHcjM-QI2nMZe8_lfA8Mgm7H23I/edit#gid=2004092469 Bug: 989251 Change-Id: I2b111eb2fe5cdbbfe073846f4e1271fb454bd887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696112Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#692043}
-
Javier Ernesto Flores Robles authored
On iOS 13 the keyboard hierarchy was updated. Composing a layout guide makes it transparent to the current while staying compatible with iOS 12. Bug: 996669 Change-Id: I480c9955f911731ac4a30acc83519c9de03ecfdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765669 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#692042}
-
David Maunder authored
This is a generic component for making GET and POST requests and supports authentication. Error reporting is not included which will be added in a separate patch. Bug: 985015 Change-Id: I42f4ee93c680be26e9bbe388ba52808c915532d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706874 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#692041}
-
Robbie Gibson authored
The root cause here for both tests is that the iPhone SE is short. Using the new modal presentation style on iOS 13 (maybe CL crrev.com/c/1719455), the view the tests are looking for, "First URL" is hidden below the keyboard. Switching to tap on "French URL", a bookmark that is earlier in the list and still on screen, fixes the tests. Bug: 999079, 999080 Change-Id: I78ae1360c264283413aa98cd6b5b50960aa9b9f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776264Reviewed-by:
-
Mark Cogan authored
This CL adds regression tests for some of the PDF snapshot bugs fixed in prior CLs (see http://crbug/981893). Specifically tests are added for: - Switching back and forth quickly between a complex PDF and a regular tab. - Switching back and forth quickly between two PDF tabs. - Opening a PDF and then entering the tab grid and waiting ~5 seconds. A known-crashing PDF (from www.irs.gov) is added to the test data for these tests. Since there's no good single component that "owns" these tests, this CL creates a ui/integration_tests directory. Since this test needs a way to locate the toolbar for swiping to change tabs, this CL adds a utility matcher for that. TEST=I verified that the crashes fixed before could be retriggered by at least one of these tests. The root cause of the crash was that WebKit was calling snapshotting callbacks more than once, and the implementation of the callback was a OnceCallback. The fix was to change this to a RepeatingCallback. I verified that these tests would have found this regression by CHECKing the second time the callback was called. Bug: 993395 Change-Id: Iea130d4ed82017096ad3420161fb59a224d128d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768707 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#692039}
-
sebsg authored
This reverts commit 8caebe30. Reason for revert: WebUsbTest.AddRemoveDevice fails pretty consistently after this CL was landed. See https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/28669 other builds: 28670-28671-28672-... Original change's description: > Convert UsbDeviceManagerClient to new Mojo types > > This CL converts UsbDeviceManagerClient{AssociatedPtr, AssociatedPtrInfo} > in chrome, components, extensions and services to the new Mojo types, > and uses pending_associated_remote<device.mojom.UsbDeviceManagerClient> > in usb_manager.mojom and web_usb_service.mojom.mojom. > > Bug: 955171, 978694 > Change-Id: Ic64f0e43ef60cb184a35b5bf6391a7fb3bc38dd8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772837 > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691951} TBR=kinuko@chromium.org,thestig@chromium.org,rockot@google.com,hidehiko@chromium.org,myid.shin@igalia.com Change-Id: I3b7939240adbcb8cede49dcb30ad9e7a6ddc89b5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 955171, 978694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778185Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d10eb04b772a..e69fbd1b2db5 git log d10eb04b772a..e69fbd1b2db5 --date=short --no-merges --format='%ad %ae %s' 2019-08-30 perezju@chromium.org [Telemetry] Provide --experimental-proto-trace-format command line flag Created with: gclient setdep -r src/third_party/catapult@e69fbd1b2db5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:990304 Change-Id: I732cf6092a17948aeec2d93d904f94e8fdb4cf79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778261Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7409b73fa546..575699569e91 git log 7409b73fa546..575699569e91 --date=short --no-merges --format='%ad %ae %s' 2019-08-30 brianosman@google.com Update sample particle data in canvaskit demo Created with: gclient setdep -r src/third_party/skia@575699569e91 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: None Change-Id: I251e8793c50c9d68f246a5dcc07bceac46711f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778201Reviewed-by:
-
Vladislav Kuzkokov authored
This reverts commit cae62756. Reason for revert: Breaks build with target_os="chromeos" FAILED: libmedia_gpu.so libmedia_gpu.so.TOC python "../../build/toolchain/gcc_solink_wrapper.py" --readelf="readelf" --nm="nm" --sofile="./libmedia_gpu.so" --tocfile="./libmedia_gpu.so.TOC" --output="./libmedia_gpu.so" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared -Wl,-soname="libmedia_gpu.so" -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed -fuse-ld=lld -Wl,--color-diagnostics -m64 -Werror -Wl,--gdb-index -nostdlib++ --sysroot=../../build/linux/debian_sid_amd64-sysroot -L../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-rpath=\$ORIGIN -Wl,-rpath=\$ORIGIN -o "./libmedia_gpu.so" @"./libmedia_gpu.so.rsp" ld.lld: error: undefined symbol: media::VideoDecoderPipeline::Create(scoped_refptr<base::SequencedTaskRunner>, std::__Cr::unique_ptr<media::DmabufVideoFramePool, std::__Cr::default_delete<media::DmabufVideoFramePool> >, std::__Cr::unique_ptr<media::VideoFrameConverter, std::__Cr::default_delete<media::VideoFrameConverter> >) >>> referenced by chromeos_video_decoder_factory.cc:54 (../../media/gpu/chromeos/chromeos_video_decoder_factory.cc:54) >>> obj/media/gpu/chromeos/chromeos/chromeos_video_decoder_factory.o:(media::ChromeosVideoDecoderFactory::Create(scoped_refptr<base::SequencedTaskRunner>, std::__Cr::unique_ptr<media::DmabufVideoFramePool, std::__Cr::default_delete<media::DmabufVideoFramePool> >, std::__Cr::unique_ptr<media::VideoFrameConverter, std::__Cr::default_delete<media::VideoFrameConverter> >)) clang: error: linker command failed with exit code 1 (use -v to see invocation) Original change's description: > media/gpu: make VideoDecoderPipeline select VD implementation during Initialize(). > > Some devices select the video decoder implementation by the video > configuration (e.g. codec). VideoDecoderPipeline needs to select a > proper video decoder in Initialize() when a video configuration is > specified. > > This CL implements the mechanism of selecting VD at Initialize() > instead of Create() method. > > BUG=chromium:952730 > TEST=Run video_decode_accelerator_tests on Kevin and Eve > > Change-Id: I76077df0bc1e1eeae730e618a62c6e1049e02500 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708693 > Reviewed-by: David Staessens <dstaessens@chromium.org> > Reviewed-by: Alexandre Courbot <acourbot@chromium.org> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691946} TBR=deanliao@chromium.org,akahuang@chromium.org,hiroh@chromium.org,acourbot@chromium.org,dstaessens@chromium.org Change-Id: I2edea554734a766fce1d61943297547159c8cbeb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:952730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778048Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Vladislav Kuzkokov <vkuzkokov@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#692035}
-
Fredrik Söderquist authored
This reverts commit d030e251. Reason for revert: Tickled ClusterFuzz Original change's description: > Remove SVGUseElement::target_element_instance_ > > This reference should always be the same as the first child of the > shadow root. Since we don't make heavy use of it though - and it > shouldn't be too slow to access via the ShadowRoot, just get rid of it > to have less state to keep up-to-date. > > Bug: 997176 > Change-Id: I798bbc7ac64934d5eda1250b32150b50b4d2acdb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771960 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Fredrik Söderquist <fs@opera.com> > Cr-Commit-Position: refs/heads/master@{#691722} TBR=pdr@chromium.org,fs@opera.com Change-Id: Ia7c4b5fde76e97a50e6c670622029750672ca0f0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 997176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777927Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#692034}
-
Roman Sorokin authored
Bug: 954572 Change-Id: Ic682f73b52a24c1acb0e40df200e0724160d2e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774447Reviewed-by:
-
