- 05 Jan, 2019 40 commits
-
-
Esmael El-Moslimany authored
Bug: 862839 Change-Id: Ie45e2332b468841cecb3283d93d3761a29326bba Reviewed-on: https://chromium-review.googlesource.com/c/1394876 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#620162}
-
Mark Mentovai authored
e5ff36fb9586 Use CrashpadInfoReader in ModuleSnapshotWin 3678bff13fe0 Separates generating & fixing Mach interfaces with MIG bc1b4e833e82 Update comment to reflect current state cc166d71f48f Use base::size where appropriate, and ArraySize elsewhere b3eeffaa18c2 Use << instead of , to log "NtQueryInformationProcess" Bug: 919262 Change-Id: I7e3d535ac9bd26475fd82b946c20db3d2640425f Reviewed-on: https://chromium-review.googlesource.com/c/1396456 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#620161}
-
Avi Drissman authored
This is purely a mechanical change; there is no intended behavior change. BUG=837308 Change-Id: I387e328cbcb7d51342bfa3736a06d7a12e292e0f Reviewed-on: https://chromium-review.googlesource.com/c/1391710Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3d5b488e5cd7..5e710e13a55b git log 3d5b488e5cd7..5e710e13a55b --date=short --no-merges --format='%ad %ae %s' 2019-01-05 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@5e710e13a55b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I4a7b7a932e7fbf475696fd68676bac4c83b5d47e Reviewed-on: https://chromium-review.googlesource.com/c/1396366Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#620159}
-
Dmitry Gozman authored
These are actually not an empty document, so there is no real need to load them synchronously. Bug: none Change-Id: I15f02787be8316e34b2443b52f8ff5920314933b Reviewed-on: https://chromium-review.googlesource.com/c/1390259 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#620158}
-
Anastasia Helfinstein authored
Revamps the file-level comment to detail available functions. Re-orders the methods in switch_access_predicate.js for clarity. Also updates comments and names of methods to focus on intended behavior over implementation details. This is a pure refactor, with no change to functionality. Bug: 881080 Change-Id: I612869926fb2656c5fe2d9d8841817ebb752ff5b Reviewed-on: https://chromium-review.googlesource.com/c/1394921Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#620157}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a64cf3b1e0f3..fccd9e7db52d Created with: gclient setdep -r src-internal@fccd9e7db52d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8f8319aca3ae32babaefeac6e5ca7f5721b1e417 Reviewed-on: https://chromium-review.googlesource.com/c/1396878Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#620156}
-
Nasko Oskov authored
As of https://crrev.com/617708 the expectation is that all renderer initiated navigations must specify the origin of the document that started the navigation. This CL adds initiator origin serialization into Java and back into C++ to allow Clank popup handling to supply the initiator origin for renderer-initiated navigations. Bug: 882053 Change-Id: I416ec4ad7b8fd20679c107aa67f45ed6b4c9e023 Reviewed-on: https://chromium-review.googlesource.com/c/1396838 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#620155}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2528a1ff. With Chromium commits locally applied on WPT: 1c633d48 "Snap the snapped_dest_rect for backgrounds" 1061788d "Reland "Add quota usage details tests for all other storage backends."" bcd3934d "Add a test for ServiceWorker and AppCache interaction with claim()" 4836c563 "Change web platform test with mouse inputs under "pinterevents/"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: ksakamoto@chromium.org: external/wpt/resource-timing NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Idf4ca584f504568cf7464ef5689a5e7f94d367c2 Reviewed-on: https://chromium-review.googlesource.com/c/1396782Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#620154}
-
Peter Kasting authored
Bug: none Change-Id: I019ac7bfcb08254490c86f7f837e1f393ca84409 TBR: kylixrd Reviewed-on: https://chromium-review.googlesource.com/c/1396848Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#620153}
-
Jamie Madill authored
This is in prepraration for migration to the new driver version. Bug: 887241 Change-Id: I76c7244211003ca6e8b94d83103234c501d86da9 Reviewed-on: https://chromium-review.googlesource.com/c/1396604 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#620152}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/390028fd6b76..c0641b8e9304 git log 390028fd6b76..c0641b8e9304 --date=short --no-merges --format='%ad %ae %s' 2019-01-04 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@c0641b8e9304 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I0cea7cf4178770ac6ff2314929d5bbad0c3302bb Reviewed-on: https://chromium-review.googlesource.com/c/1396365Reviewed-by:
-
Robert Ogden authored
This clears it in two places, normal navigations using CCBC, and in the Lite Page NavThrottle as well. Bug: 917133 Change-Id: Id59b7a3b3b5429f506baa503ba019d418093bebd Reviewed-on: https://chromium-review.googlesource.com/c/1395891Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#620150}
-
Aleks Totic authored
This is a possible way to fix: external/wpt/css/CSS2/abspos/abspos-in-block-in-inline-in-relpos-inline.html The problem: Split inlines generate LayoutTree that looks something like this: LayoutNGBlockFlow DIV style="height:200px;" LayoutNGBlockFlow (anonymous) LayoutInline (relative positioned) continuation=0x3c190 SPAN id="containingBlock" LayoutNGBlockFlow (anonymous) (relative positioned) LayoutNGBlockFlow (positioned) DIV id="target" LayoutNGBlockFlow (anonymous) LayoutInline (relative positioned) SPAN id="notContainingBlock" LayoutInline (relative positioned) 0x3c190 SPAN id="containingBlock" #target is OOF, with SPAN.#containingBlockOfTarget OOF containing block. Containing block boundaries are defined by LayoutInline which is split by continuations into 2 LayoutInline. Even worse, #target does not have containingBlock in parent chain. Legacy handles only parts of this problem: containing block static position, and width are found by traversing anonymous parent continuation chain. Location/height of containing LayoutInline are not handled. I think we can fix this correctly, but it is a little tricky. Step 1 is to detect when our NGOutOfFlowLayoutPart container is Anonymous + Relative Position (signal Legacy uses to trigger). When this happens, we can traverse Anonymous continuation to find LayoutInline which is the true css container. Then we let #target bubble to parent, and let parent position it. Step 2 is positioning by anonymous's parent. This is slightly different from what we did before, because parent needs to find inline containing block bounds, but is not ChildrenInline(). Instead, it needs to find those bounds by traversing anonymous children's lineboxes. Step 3 is correcting offset generated by NGOutOfFlowLayoutPart::LayoutDescendant Paint layer expect offset from css containing block, so we generate that. This is very much an edge case in our test suite. There are only 3 tests that hit "split inline is a containing block". They all pass now. Bug: 740993 Change-Id: I694dfa277d6579ee1b775122d8216cfbbad81301 Reviewed-on: https://chromium-review.googlesource.com/c/1374910 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#620149}
-
rbpotter authored
- Methods in coordinate2d.js were unused in both old and new UI. - Native Layer SERIALIZED_STATE_VERSION_ is unused in both old and new UI. - setSystem is unused since the new UI does not create the MeasurementSystem until the initial settings are known, so it never needs to reset it. Bug: None Change-Id: Id2812244481e56b56fb083906ddb92eab60fcda4 Reviewed-on: https://chromium-review.googlesource.com/c/1396786Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#620148}
-
Hector Carmona authored
email-chooser and apps-chooser share a lot of the same code with only small differences between the two. This CL combines the two components into a new one: app-chooser that can be used in both modules where email-chooser and apps-chooser were used before. Bug: NONE Change-Id: Iad18a8b8d89d4ba803f537f86c4f45743f95c387 Reviewed-on: https://chromium-review.googlesource.com/c/1391993Reviewed-by:
-
Peter Kasting authored
This is primarily two changes: (1) Expand ReleaseMouseAsync() to ReleaseInputAsync() (which just does the same thing for touch as ReleaseInput()), and use it to collapse some conditionalized logic. Along the way, converted a lot of calls to ReleaseMouseAsync() into calls to ReleaseInput() since the asyncness is not necessary for most. (2) Change one test fixture to inherit such that it can use DragTabAndNotify(). This allows removing some custom logic at the expense of parametrizing the test, but a similar tradeoff has already been made for other fixtures. Bug: none Change-Id: I9ac38d1ef434eaa107dc7cfba706de5f4e80453f TBR: kylixrd Reviewed-on: https://chromium-review.googlesource.com/c/1396454Reviewed-by: -
Avi Drissman authored
This is purely a mechanical change; there is no intended behavior change. BUG=837308 R=thakis@chromium.org Change-Id: I3246cd4e8c500e9b5cf1192a381d349ef60263fa Reviewed-on: https://chromium-review.googlesource.com/c/1391953Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8061ba857072..3d5b488e5cd7 git log 8061ba857072..3d5b488e5cd7 --date=short --no-merges --format='%ad %ae %s' 2019-01-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 e4109f27136d..9db8df4c3e6e (1 commits) 2019-01-04 herb@google.com Separate cache lookup from run font setup 2019-01-04 csmartdalton@google.com Revert "ccpr: Rework the path cache to support sporadic flushing" 2019-01-04 reed@google.com paint is losing its text-related fields Created with: gclient setdep -r src/third_party/skia@3d5b488e5cd7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I15da505e3b902786937a1dd2753e6c6f70273466 Reviewed-on: https://chromium-review.googlesource.com/c/1396686Reviewed-by:
-
Dmitry Gozman authored
This is a preparation to not using WebURLLoader for main resource. See step 6.d in the doc linked to the bug. Bug: 855189 Change-Id: Ib075d20ff2fedf655275c5fd788a83e648e4d07f Reviewed-on: https://chromium-review.googlesource.com/c/1392744Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#620143}
-
Dan Beam authored
In https://crrev.com/c/1393442, I changed this code: /* Google Blue 900 with 40% opacity. */ box-shadow: 0 0 0 2px rgba(26, 115, 232, 0.4); to box-shadow: 0 0 0 2px rgba(var(--google-blue-900-rgb), 0.4); Unfortunately, the comment read "900", but it was actually "600". So I fixed that (and checked that "26, 115, 232" is google-blue-600 in shared_vars_css.html) and also converted another duplicate Google Blue instance in this file. R=hcarmona@chromium.org BUG=918824 Change-Id: Ifa4795cfe05f00273fe61759138dfbf3b23025af Reviewed-on: https://chromium-review.googlesource.com/c/1396781Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#620142}
-
Zhongyi Shi authored
Original change message: Use PendingStreams to buffer incoming streams. Behavior changes protected by QUIC version 99 Allow QuicSession to buffer frames for incoming streams in a PendingStream until the first byte arrives, if ShouldBufferIncomingStream() returns true. Change QuicSpdySession to return true for v99 unidirectional streams. Merge internal change: 226538637 Bug: 919184, 919073, 919048, 919014, 918890, 918834, 918888, 918832, 918849 Change-Id: I14be0f9d97de31bf6ea0d40afe5e457a318e8f02 Reviewed-on: https://chromium-review.googlesource.com/c/1396312Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#620141}
-
Shakti Sahu authored
This reverts commit 96f52874. Reason for revert: Crash Original change's description: > Added AutoResumptionHandler with task scheduling in native > > Added AutoResumptionHandler to handle downloads auto-resumption in native. > This class will observe all download items and also listen to network changes. > Based on the current network conditions and download network requirements, it > will use a task scheduler to schedule a resumption task with the OS. It is expected > to handle download completions/interruptions etc correctly and based on the state of downloads, > either notify about task completion with cleaning up any already scheduled > tasks or scheduling a new task for resumption when network conditions are met. > > Bug: 910878 > Change-Id: Ia4aabc21e85afee523e78f10956df99e7e02c9dc > Reviewed-on: https://chromium-review.googlesource.com/c/1356311 > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: Min Qin <qinmin@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619491} TBR=peter@chromium.org,qinmin@chromium.org,shaktisahu@chromium.org,xingliu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 910878 Change-Id: I691d3c1d61a3fa4de9ddcd85d4b9f19b7285f3ab Reviewed-on: https://chromium-review.googlesource.com/c/1395830Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#620140}
-
Evan Stade authored
-PDFAnnotationsTest.AnnotationsFeatureEnabled TBR=jamescook@chromium.org Bug: 919256 Change-Id: I967bcd6aae5d70148e5b235e721e351077b9ded4 Reviewed-on: https://chromium-review.googlesource.com/c/1395836Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#620139}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f6b46a78785b..a64cf3b1e0f3 Created with: gclient setdep -r src-internal@a64cf3b1e0f3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id1d6a75e3950dbd4ecc78d3662ad6304c238f5c7 Reviewed-on: https://chromium-review.googlesource.com/c/1396688Reviewed-by:
-
rbpotter authored
- Remove utils functions that are now unused due to deletion of old UI - Remove arrayContains usage in favor of Array.includes - Remove utils unittests. Page range tests have been migrated to chrome/test/data/webui/print_preview/pages_settings_test.js. Bug: 908705 Change-Id: I832bbfd095e8ab671fa71300fef554f49fcf512f Reviewed-on: https://chromium-review.googlesource.com/c/1396682 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Chris Harrelson authored
The calls to LayoutObject::RecalcVisualOverflow() are for recursion to children, not "adding in" children visual overflow. Change-Id: I8b5e44e49d1e1bea889afd5764d865a4342739dd Reviewed-on: https://chromium-review.googlesource.com/c/1396785Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#620136}
-
John Abd-El-Malek authored
Change-Id: I34c6a44f8da52e5f256e7fa686cc4cb6df69d15b Reviewed-on: https://chromium-review.googlesource.com/c/1396683 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#620135}
-
Dan Beam authored
This CL was generated with: $ eslint --fix $SRC $ git cl format --js Note: I reverted serviceworker_internals.js because of all the existing lint violations / jstemplate cruft; will do separately. BUG=916782 R=nasko@chromium.org Change-Id: If383e822e50d7e2f7140879e9da4a68aa3b6519b Reviewed-on: https://chromium-review.googlesource.com/c/1396708Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#620134}
-
Dmitry Gozman authored
We now buffer all the data to |data_buffer_| similarly to other buffering scenarios, and then use that buffer to create an archive. This removes an unneeded dependency on Resource. Bug: none Change-Id: I940eaf035b0376d76d6502c219a7c40d277f08a1 Reviewed-on: https://chromium-review.googlesource.com/c/1392504Reviewed-by:
-
Antoine Labour authored
Because client and service may be of different bitness, offsets in command buffers have to fit in a uint32_t, effectively limiting transfer buffers to 4GB. Make this clear in CommandBuffer::CreateTransferBuffer by taking a uin32_t instead of a size_t (fixing callers as appropriate), avoiding potential security issues with silent clamping. Bug: 905509 Change-Id: I8392f2e73e95bf65e08fa9896e2acc53afa0d268 Reviewed-on: https://chromium-review.googlesource.com/c/1396132Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#620132}
-
siyua authored
Bug: 918793 Change-Id: Ia818f785d5ea848a3d8af3c91b8368ee9be6c144 Reviewed-on: https://chromium-review.googlesource.com/c/1396616Reviewed-by:
-
Katie D authored
Autoclick menu allows users to change which type of automatic click action will happen after the autoclick time elapses, directly from the tray. The menu also has a shortcut to jump to the automatic clicks settings page. This is part of the new autoclick feature set. See more UI details at go/cros-dwell-ux. Some UX is still in flux. Assets are not completed and some other TODOs exist, but this menu is hidden behind a flag. All TODOs will be completed before launch! Bug: 894907 Change-Id: I9207f13d75101afdf8bc18ca704000e7a89e9c9a Reviewed-on: https://chromium-review.googlesource.com/c/1391851Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
-
Dmitry Gozman authored
This brings two benefits: - Dump what we actually call on RenderFrameObservers. - Remove dependency on DocumentLoader::GetRequest which goes away (see the doc linked to bug). Bug: 855189 Change-Id: I7c869d870dcb2d51cddea1998335af0e6162af5e Reviewed-on: https://chromium-review.googlesource.com/c/1390237Reviewed-by:
-
rbpotter authored
- Make DocumentInfo a Polymer element so that its properties can notify paths - Since DocumentInfo is a Polymer element, it can now inherit WebUIListenerBehavior, and take over responsibility for updating various document properties from PreviewArea - Update pages settings and scaling settings to observe only the sub-properties of DocumentInfo that they actually use. Bug: None Change-Id: I7289526b2ad0bdf2fcbd49a956b797ec5525bbcd Reviewed-on: https://chromium-review.googlesource.com/c/1395424 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/599dad1eadaf..1457e48474e7 git log 599dad1eadaf..1457e48474e7 --date=short --no-merges --format='%ad %ae %s' 2019-01-04 vapier@chromium.org cros_extract_deps: sort output 2019-01-04 vapier@chromium.org cros_extract_deps: clean up cli parser a bit Created with: gclient setdep -r src/third_party/chromite@1457e48474e7 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I340c72f4d78eb5543dc4de920119184819383741 Reviewed-on: https://chromium-review.googlesource.com/c/1396685Reviewed-by:
-
Dmitry Gozman authored
After we started calling CreatePlaceholderDocumentLoader [1] for empty-document navigations, existing logic which checks for placeholder DL handles the case of empty documents as well. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1380552 Bug: none Change-Id: I2b1f9d73e00cd8ed3ab1f3f7f54ea930930c35dd Reviewed-on: https://chromium-review.googlesource.com/c/1390236Reviewed-by:
-
Zhiqiang Zhang authored
There was a crash in SDK before version 16.0.2. This CL works around the issue by generating the low-level message directly. Bug: 711860 Change-Id: I262143fae845ae6e8d4f9042487f554f7f5d94a1 Reviewed-on: https://chromium-review.googlesource.com/c/1396380Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#620125}
-
Takuto Ikuta authored
base::hash_map is alias of std::unordered_map now. I applied following command to make this CL. $ git grep -l 'base::hash_map' | fgrep -v base/ | xargs sed -i -e 's/base::hash_map/std::unordered_set/g' -e 's/\(#include <[a-z_]*>\)/\1\n#include <unordered_map>/' -e 's/BASE_HASH_NAMESPACE/std/' $ git cl format $ # Added IntPairHash and replaced BASE_HASH_NAMESPACE with std in some places. TBR: dcheng@chromium.org Bug: 576864 Change-Id: I38941d9f9bcb05ec474b8dee5230c4c5dcd2211f Reviewed-on: https://chromium-review.googlesource.com/c/1390892 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#620124}
-
Ryan Tseng authored
It looks like someone added these builders to buildbot after I mirrored chromium.clang, but did not add the LUCI entries. This will fix the console. Bug: 919081 Change-Id: I3839c9aad4e4570ba9963546da5d57acd1657dcf Reviewed-on: https://chromium-review.googlesource.com/c/1396492 Commit-Queue: Eric Foo <efoo@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Eric Foo <efoo@chromium.org> Reviewed-by:
-
