GitLab

Adds an IPH for switching from Tap triggering to Long-press triggering
as part of the ContextualSearchLongpressResolve experiment.

There are two strings that can show in the bubble, one for users that
have opened the panel in the past, and one for the general user-base
that has not opened the panel recently.

The IPH triggering logic is:
1) Show when the user taps and we would have tap-triggered.
2) Only show 3 times in a 90 day window.
3) Don't show if the user has done any longpress selection (which
   triggers Contextual Search) in the 90 day window.
4) Don't show if the user has opened the panel after a longpress in a
   1 year window (the max allowed).

BUG=1086724

Change-Id: I19335076afeb8a349c77e93a794d9adf8bfcfb95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233861Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780030}

Previously, we set the share button position to the position sent in the
doodle response and hardcoded the share button size to 26x26px. This
works fine as long as the doodle is shown with the same dimensions as
its intrinsic size. However, we limit the doodle height to 230px (or
potentially more in the future for boxed themed mode doodles) and scale
the doodle image accordingly. Therefore, the share button can end up
at a different position and size relative to the doodle image as
originally intended. This CL fixes that by setting the share button size
and position as a percentage of the intrinsic doodle image size.

Bug: 688960
Change-Id: I55261f46d9ae074b81c03a7563bc068b1fd247bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250512
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780029}

Roll Chrome Win64 PGO profile from chrome-win64-master-1592495797-d903a1fb107ff5cf8693e66337654c7b30cfb050.profdata to chrome-win64-master-1592503157-30b63e57baf9882593dc962ba95100f29c6397c5.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win64-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: I9d71b89596842d0be1a1358077baddce19268f03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252528Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#780028}

|FeaturePolicyFeature::kAccessibilityEvent| appears in
feature_policy_feature.mojom but is missing in
feature_policy_features.json5.

The original owner(dmazzoni@) who added the feature agreed
that it can be removed for now.

Change-Id: Ica187050353607e79e4b29027efc256f188b2e35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250340Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#780027}

Copy-paste the body of SharedImageBackingGLCommon into identical
instances for SharedImageBackingGLTexture and SharedImageBackingGLImage.

These will diverge more in later patches.

Bug: 1092155
Change-Id: I2b6f8a820225c5764d3ebf5f571e08a9ca657026
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250591
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780026}

This reverts commit d3872f63.

Reason for revert:  Reland of revert for MSAN failure, crbug.com/1096592

Original change's description:
> Reland "Desktop PWAs: Unit test helper method InstallWebApp"
> 
> This reverts commit 359f3700.
> 
> Reason for revert: Broke build due to dependent CLs existing.
> 
> Original change's description:
> > Revert "Desktop PWAs: Unit test helper method InstallWebApp"
> >
> > This reverts commit 7db3de6c.
> >
> > Reason for revert: MSAN failure, crbug.com/1096592
> >
> > Original change's description:
> > > Desktop PWAs: Unit test helper method InstallWebApp
> > >
> > > Extract unit test helper method InstallWebApp from unit tests to
> > > web_app_unittest_util.h/cc and retire duplicate implementations.
> > >
> > > Drive-by: retire unused method FinalizeInstall
> > > in web_app_install_manager_unittest.cc
> > >
> > > TBR=agawronska@chromium.org
> > >
> > > Change-Id: I5f7574ef89dfe1543727c2376d8002e2e6fce822
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247991
> > > Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
> > > Reviewed-by: Alexey Baskakov <loyso@chromium.org>
> > > Reviewed-by: Dominick Ng <dominickn@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#779607}
> >
> > TBR=ericwilligers@chromium.org,loyso@chromium.org,dominickn@chromium.org
> >
> > Change-Id: I1b50d2ed80fbe29b9e742c7a533d3a0b65e0df7e
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252561
> > Reviewed-by: Aleks Totic <atotic@chromium.org>
> > Commit-Queue: Aleks Totic <atotic@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#779872}
> 
> TBR=ericwilligers@chromium.org,loyso@chromium.org,atotic@chromium.org,dominickn@chromium.org
> 
> No-Presubmit: true
> No-Try: true
> No-Tree-Checks: true
> Change-Id: I73d0c4893bd9f1f3dd397818faeaa743b0c9a97e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252643
> Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
> Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#779884}

TBR=ericwilligers@chromium.org,loyso@chromium.org,atotic@chromium.org,dominickn@chromium.org,smcgruer@chromium.org

Change-Id: If326b224e12ce775e841105646cb33891ac4fff3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252934Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780025}

//components/browser_ui/media holds media notification java as well as
assets that are unique to media.

Some assets are also used by other features, so they're moved into
//components/browser_ui/styles/ instead of media/.

A couple tests are moved along with the code, but most tests depend
on Chrome code still (MediaNotificationManager, ListenerService, etc)
so they stay in //chrome.

Bug: 1066263
Change-Id: I743411f3a56fc11bdf10fc657b7b74f7164e5700
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249391Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780024}

This reverts commit b617e4df.

Reason for revert: Dependency on CL that must be reverted for MSAN failure.

Original change's description:
> Desktop PWAs: Add ChromeLauncherController unit test using a web app
> 
> ChromeLauncherControllerWebAppTest tests ChromeLauncherController
> with a web app.
> 
> 
> Bug: 1087686
> Change-Id: I7c4ec3c1b7949e8b4835a6df1f2998b7af9cd578
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247992
> Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#779622}

TBR=ericwilligers@chromium.org,dominickn@chromium.org

Change-Id: I47c11d66073cf5d5f8f634cda05d80ec858088a4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1087686
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252933Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780023}

Option is currently unused in chrome, so went unnoticed when it broke in
d95b3aba

Bug: 1078484
Change-Id: I14b71a0c81f6cfebad527f4ef5131a39dae08896
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252605
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780022}

https://webrtc.googlesource.com/src.git/+log/f46902c540c3..79ca92d952ae

2020-06-18 tommi@webrtc.org Add workaround method for deprecated code.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: If4c4cb42eef2a8d442dda610718a026a8780c441
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252527Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#780021}

When use_x11 && use_ozone are set to true at the same
time, compiler throws an error about multiple definitions
of the gl_factory and gl_initializer.

Thus, to fix that, make X11 use ozone's definition of the
gl_factory and the gl_initializer and add a check for
usage of the OzonePlatform that will be used in the future
when use_x11 && use_ozone are both set.

Please note that it's impossible to build use_x11 && use_ozone without
some hacks in PlatformCursor code. The changes to that are on their
way to upstream.

Bug: 1085700
Change-Id: Icc4d54c0910627c90869a7c41e3e709021d77b4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247639
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780020}

Since owned_resources_dirs was removed, using lint_resource_sources
instead.

Android Studio only supports editing resources, so there is no longer a
need to store/unzip generated resource zips.

Also fixes distribution url for latest canary (which is actually beta on
gLinux).

Bug: 620034,1092741
Change-Id: I51ef5b0b36de009ab46f820aaf45772f2f7da94b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253078
Commit-Queue: Peter Wen <wnwen@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780019}

This change eliminates hardcoded color kNotificationDefaultAccentColor
and creates a new native color ID for it.

Bug: 1056950
Change-Id: I3430d10367a7dd6b680a61ab5af95731fcbd64f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219407Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Maria Villarreal <mavill@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#780018}

https://aomedia.googlesource.com/aom.git/+log/2aa13c436e4d..e1ebb418ebdc

$ git log 2aa13c436..e1ebb418e --date=short --no-merges --format='%ad %ae %s'
2020-06-17 jianj Free allocated memory before allocating again in svc init.
2020-06-17 vishesh.garg Group decoder model config in AV1EncoderConfig
2020-06-16 chiyotsai Remove speed features with no quality/speed impact
2020-06-16 paulwilkins Updated comment.
2020-06-16 mufaddal.chakera Disable TPL when resizing is enabled
2020-06-12 mufaddal.chakera Fix crash in generating PSNR packet with resizing enabled
2020-06-15 sarahparker Doxygen for motion mode search
2020-06-12 chiyotsai Add Doxygen comments for palette mode
2020-06-12 chiyotsai Refactor intra_mode_search files
2020-06-15 sarahparker Doxygen for HandleInterModeArgs
(...)
2020-06-03 urvang Doxygen doc for CommonQuantParams, CommonContexts.
2020-06-01 urvang Doxygen doc for 3 structs in av1_common_int.h
2020-06-03 marpan rtc: Add some settings to svc_encoder_rtc.c
2020-06-03 sanampudi.venkatarao Fix bug in rd_pick_rect_partition()
2020-06-02 paulwilkins Fix regression with fixed Q encode
2020-06-02 vishesh.garg Group compound type elements in AV1EncoderConfig
2020-06-02 vishesh.garg Group txfm size/type config in AV1EncoderConfig
2020-06-01 vishesh.garg Group intra mode config params in AV1EncoderConfig
2020-05-29 kmalladi Modified av1_highbd_dr_prediction_z2_avx2
2020-06-02 sanampudi.venkatarao Abstract common code in rectangular partitions search

Created with:
  roll-dep src/third_party/libaom/source/libaom
R=jzern@google.com

Change-Id: Ia0748980aa1852ba28fbd644dc9037429ef84053
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250944Reviewed-by: James Zern <jzern@google.com>
Commit-Queue: Jerome Jiang <jianj@google.com>
Cr-Commit-Position: refs/heads/master@{#780017}

This will help us explain odd results from
Net.AlternateProtocolUsage that we think
could be coming from other server providers.

R=renjietang@chromium.org

Change-Id: I09490c9a3eca936664b02c887daf472f925b84fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250665
Auto-Submit: David Schinazi <dschinazi@chromium.org>
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Reviewed-by: Renjie Tang <renjietang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780016}

https://chromium.googlesource.com/external/github.com/google/re2.git/+log/e6613e91b26e..14d3193228e3

$ git log e6613e91b..14d319322 --date=short --no-merges --format='%ad %ae %s'
2020-06-18 junyer Write tests for the move semantics.
2020-06-18 junyer Improve RE2::Set and FilteredRE2 move semantics.

Created with:
  roll-dep src/third_party/re2/src

R=thakis@chromium.org
CC=mmoroz@chromium.org

Change-Id: I62d38cb0ea903e6824ab4f1b530a98b0bb956382
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252562
Commit-Queue: Paul Wankadia <junyer@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780015}

This change replaces the CPU usage WebView metric with the one that
estimates power usage using power profiles.
The initial version calculates the power usage of WebView slices.

Bug: b/158665114
Change-Id: I9bfc646ba38cb298f5cc5c977c928ab16fe79024
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247348Reviewed-by: Mikhail Khokhlov <khokhlov@google.com>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780014}

This also updates the WebUI calls since BinaryUploadService is where
the chrome://safe-browsing page gets its updates.

Follow-ups to this CL
will be updates to DeepScanning{DialogDelegate|Request} to use the new
Connector proto path.

Bug: 1069066,1069069
Change-Id: I170384dc8fee55e239996b623fab672e56c5810a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243441
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780013}

The process of extracting the TabState from a Tab does not need to be
coupled with the definition of the TabState entity.

Bug: 1090048
Change-Id: I1aad14c0263fd560f4d538fb8eb26b1e0bfa219e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243537
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: David Maunder <davidjm@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780012}

At the beginning of this refactor there were 2 SharedImageBacking
classes: passthrough vs not-passthrough.

This is towards having 2 SharedImageBacking: GLImage vs normal
GL texture. The classes still inherit from a single Common class.
This moves some of the common code into static methods in the
Common class. In particular
* Make separate InitializeGLTexture functions, and move much of
  the common code into SharedImageBackingGLCommon::
  MakeTextureAndSetParameters.
* Make SharedImageRepresentationSkiaImpl have a method to take a
  callback to make on BeginReadAccess, rather than calling a
  method on SharedImageBackingGLCommon.
  - De-common-ize SharedImageBackingGLCommon::ProduceSkia.
  - Change it to have the caller create the SkPromiseImageTexture.
* Add SharedImageBackingGLImage::InitializePixels
  - For now this just calls glTexSubImage2D
  - In the future this will write to the GpuMemoryBuffer.

Bug: 1092155
Change-Id: If5f60356d683673e610192b7c851664a138a9951
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248413
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780011}

aw_browser_terminator.cc was including the JNI header file for
AwBrowserProcess so that it can call TriggerMinidumpUploading, but this
prevents any native methods being added to AwBrowserProcess since each
JNI header can only be safely included by one source file.

Move the JNI header include to aw_browser_process.cc and expose a C++
function for AwBrowserTerminator to call instead of calling the Java
method directly.

Change-Id: If230bfc3d1fb8c3c1eeb7efa2f01b0b45c4d32a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252282
Commit-Queue: Richard Coles <torne@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Auto-Submit: Richard Coles <torne@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780010}

If RemoveFrameContainerForReason() successfully removes a frame, the
|this| pointer will become invalid. This CL removes a member function
invocation that occurs when |this| might be invalid.

Bug: 1088187
Change-Id: I5abc6f03ff326ebbcfb696205deb5058ec977c78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250580
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780009}

This CL affects debugging UI only.
It extracts the Network State related UI to a new component,
network-state-ui.

Bug: 921726
Change-Id: I8df48464a6604e1b605d97df21e498927f582b88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240236Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780008}

TBR=govind@chromium.org

Change-Id: Id5d9e05cbb783022c7cfca42a4756a37c260815d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252689Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780007}

Add direct includes for things provided transitively by logging.h
(or by other headers including logging.h).

This is in preparation for cleaning up unnecessary includes of
logging.h in header files (so if something depends on logging.h,
it needs include it explicitly), and for when logging.h no longer
includes check.h, check_op.h, and notreached.h.

(This doesn't add direct includes for all uses of CHECK etc, only the
ones that will be broken by subsequent CLs to cleanup includes.)

Bug: 1031540
Change-Id: Ie8e24df57a4ca317a7932b13aee4ea8f39c84d27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248577
Commit-Queue: Hans Wennborg <hans@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780006}

We had this feature to better support Query in Omnibox.

Now that Query in Omnibox has been deleted this is no longer needed,
since plaintext URLs are generally handled somewhat better than links.

This CL also removes some stale references to Query in Omnibox in
some comments.

Bug: 874592
Change-Id: Ia1cf70d0a0598897202e3241a90e459d470d3620
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250831Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780005}

Reset the baselines for:
compositing/masks/mask-with-added-filters.html
compositing/masks/mask-with-removed-filters.html

TBR=jonross@chromium.org

Bug: 1096568
Change-Id: I4527a0b6868a7e9112330ab05e6fdb108e08b26a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252679Reviewed-by: Sean Gilhuly <sgilhuly@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Auto-Submit: Sean Gilhuly <sgilhuly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780004}

An EXCEPTION_ACCESS_VIOLATION_READ crash was reported in
CaptionBubble::GetNumLinesInLabel. I believe the cause is that
CaptionBubble::GetNumLinesInLabel calls Label::GetRequiredLines, which
is a const function. To fix this, I mark
CaptionBubble::GetNumLinesInLabel as const.

While I am here, I am also performing a check that observer_ is not
null in CaptionBubbleModel::CommitPartialText, which would cause a
different crash.

Bug: 1055150, 1096366
Change-Id: Ic039de789f4ce5dc34b3dff0ee11e38bcfabb4b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252198
Commit-Queue: Abigail Klein <abigailbklein@google.com>
Reviewed-by: Katie Dektar <katie@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780003}

This is equivalent to the existing DeleteFile(path, false). It will help
migrate the existing callers to the 2-parameter function incrementally,
and remain after the 2-parameter function goes away.

Also put this and DeleteFileRecursively() above the 2-parameter
function, so readers will see them first and hopefully use them.

Convert the unit tests to use this new version of DeleteFile().

Fix a few pieces of code that have trouble distinguishing between the
two variations of DeleteFile().

Bug: 1009837
Change-Id: I8befdc95dc9ed4d9da501126bf545334011b048a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952387
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780002}

Roll Chrome Win32 PGO profile from chrome-win32-master-1592492320-3ab827aecaa4186da1d1047a6b75e711e06263db.profdata to chrome-win32-master-1592495797-0ce2a459124ac0074ced31c25e7b4057cfe18bea.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: I37a330d56053d370e4490c5a5f72ae44dc90e833
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252522Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#780001}

The actual flag was removed a while ago, but traces of it remained:
- in flag_descriptions
- in flag-metadata.json
- in fieldtrial_testing_config.json

This CL cleans them all up.

Bug: 1010397
Change-Id: I300b7808788ff873249ec62935cc9870a91712f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250105Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Auto-Submit: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780000}

Test fast/canvas/canvas-composite-text-alpha.html keep failing due to
timeout. Add it to the slow test list.

Bug: 1093836
Change-Id: I636b75378855af72869fbc5c1295fa0f8aafd3f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252683Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779999}

This will help move its tests over to LMY48M from LMY48I, for
consistency with the the release tester.

Bug: 1091539
Change-Id: Icbf74b9c766e836f74cf61abafb92861a8e62871
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252840Reviewed-by: Haiyang Pan <hypan@google.com>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779998}

Ideally, if an event is associated with a compositor frame, it means
that the event was created before the compositor frame is submitted to
viz for presentation. So, the time stamp of the event should be smaller
than the start time of viz stage in CompositorFrameReporter. However, it
seems that it's not the case all the time (see the associated bug). For
now, let's silently ignore such cases instead of a DCHECK. Hopefully,
our work on investigating discrepancies between the new EventLatency and
the old Event.Latency would reveal the cause of the issue. If not, we
should reconsider this case.

Bug: 1093698
Change-Id: I4ce943fe2c9ed69caba82b34b652fa14e027d549
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252678Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779997}

Bug: chromedriver:3376
Change-Id: I88f1ea001b600743be4f158a44cc4ac68652c257
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250082
Auto-Submit: Shengfa Lin <shengfa@google.com>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779996}

Also add screenshots for these to aid translators.

Bug: b/158618555
Change-Id: Ia41fcbc18b36f42b050c790fb9d71e1097245376
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252651
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779995}

This will help translators come up with an appropriate localized string
in their languages.

Bug: b/158612775
Change-Id: I807363055ffe36d1416a9f92e0a12a1e28160612
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252843Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779994}

... instead of WebMediaStreamTrack.

This is part of the effort to reduce the needless use of
public Blink APIs (wrappers) within renderer/modules.

BUG=704136
R=guidou@chromium.org

Change-Id: I20c6b61c96f12319f1b81f19b16a94bd025993d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248220Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#779993}

Remove reading from command line to obtain cast display rotation from
CastDisplayConfigurator. The display rotation is now read from kernel
for https://chromium-review.googlesource.com/c/chromium/src/+/2229725

Bug: b/77900197
Test: build and run on device.
Change-Id: I8d1f4c49c4a0ae12ea01c982d72af7f2c8617f92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252938Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Yuanyao Zhong <yyzhong@google.com>
Cr-Commit-Position: refs/heads/master@{#779992}

This allows LaCrOS crashes to be triaged separately from
Chrome_Linux crashes.

Change-Id: I1b441519dffb508593915a93d5ccbc44e83f0dce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252625Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779991}