GitLab

* Normal strings can't be used for operations with a file opened in binary mode. Fixed by using bytestrings.
* Due to being opened in binary mode bytes are read instead of strings in Python 3. Thus use ord() only in Python 2.

Still works with Python 2.

Fixed errors:
Traceback (most recent call last):
  File "../../components/language/content/browser/ulp_language_code_locator/ulp_serialized_to_static_c.py", line 79, in <module>
    Main()
  File "../../components/language/content/browser/ulp_language_code_locator/ulp_serialized_to_static_c.py", line 72, in Main
    models = [ReadSerializedData(data_path) for data_path in args.data]
  File "../../components/language/content/browser/ulp_language_code_locator/ulp_serialized_to_static_c.py", line 72, in <listcomp>
    models = [ReadSerializedData(data_path) for data_path in args.data]
  File "../../components/language/content/browser/ulp_language_code_locator/ulp_serialized_to_static_c.py", line 28, in ReadSerializedData
    linebreak = data.index('\n')
TypeError: argument should be integer or bytes-like object, not 'str'

Traceback (most recent call last):
  File "../../components/language/content/browser/ulp_language_code_locator/ulp_serialized_to_static_c.py", line 82, in <module>
    Main()
  File "../../components/language/content/browser/ulp_language_code_locator/ulp_serialized_to_static_c.py", line 75, in Main
    models = [ReadSerializedData(data_path) for data_path in args.data]
  File "../../components/language/content/browser/ulp_language_code_locator/ulp_serialized_to_static_c.py", line 75, in <listcomp>
    models = [ReadSerializedData(data_path) for data_path in args.data]
  File "../../components/language/content/browser/ulp_language_code_locator/ulp_serialized_to_static_c.py", line 37, in ReadSerializedData
    tree_serialized = [
  File "../../components/language/content/browser/ulp_language_code_locator/ulp_serialized_to_static_c.py", line 38, in <listcomp>
    sum((ord(tree_bytes[i+b]) << (8*b)) if i+b < len(tree_bytes) else 0
  File "../../components/language/content/browser/ulp_language_code_locator/ulp_serialized_to_static_c.py", line 38, in <genexpr>
    sum((ord(tree_bytes[i+b]) << (8*b)) if i+b < len(tree_bytes) else 0
TypeError: ord() expected string of length 1, but int found

Bug: 941669
Change-Id: Ib540c21eb63fc9407596a49e5114b8ab7e9a5a10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857123
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Alexandre Frechette <frechette@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712138}

https://webrtc.googlesource.com/src.git/+log/cc9bf6398c03..2b9317ad76b3

git log cc9bf6398c03..2b9317ad76b3 --date=short --no-merges --format='%ad %ae %s'
2019-11-04 brandtr@webrtc.org Stop checking VP8BaseHeavyTl3RateAllocation field trial on every frame.
2019-11-04 terelius@webrtc.org Return status instead of CHECKing in event log parser.

Created with:
  gclient setdep -r src/third_party/webrtc@2b9317ad76b3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None
Change-Id: Id0d6f1591b0732ecdb99141b93e522b80ff11f22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896762Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712137}

Change-Id: If5802f43bfe72982e38b47b7b1487536a6250aa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895889Reviewed-by: Ender <ender@google.com>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#712136}

This change follows the pattern of the CL adding SetExtraView. The few easy
overrides are removed in this CL as well, but followup work will be needed to
tackle the remaining ones individually and eventually get rid of
CreateFootnoteView.

Bug: 1011446
Change-Id: I1cb7e2f7bc6ffb1ace067d205475e0f8dee86b42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894033Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712135}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9a18bfc96038..8abbd40c2a27


Created with:
  gclient setdep -r src-internal@8abbd40c2a27

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I6fd7fc4444e4f9c56a8abecb98725564f4601658
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896763Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712134}

We currently reset transition type to ui::PAGE_TRANSITION_LINK in
DidCommitProvisionalLoad, but not in DidFinishSameDocumentNavigation.
This makes future usages of the stored transition type depend on
whether the initial navigation was same-document or cross-document,
which seems like a bug. This patch adds one more transtion type reset
to DidFinishSameDocumentNavigation for browser-initiated ones.

After this change, WillSendRequest retrieves transition type, which
is always equal to ui::PAGE_TRANSITION_LINK. This is because no
request happen before navigation commit, and we reset transition to
ui::PAGE_TRANSITION_LINK immediately after commit. Therefore, we can
just use link transition and simplify GetTransitionType.

Bug: none
Change-Id: I3aa71519300258d1357b4c66af3289b4111175d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887652Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712133}

https://chromium.googlesource.com/catapult.git/+log/5321943693c5..70d4ef304416

git log 5321943693c5..70d4ef304416 --date=short --no-merges --format='%ad %ae %s'
2019-11-04 dproy@chromium.org Implement timeout and retries for dev server tests
2019-11-04 perezju@chromium.org Reland "[Telemetry] Stop doing metric computation."

Created with:
  gclient setdep -r src/third_party/catapult@70d4ef304416

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC crouleau@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=crouleau@chromium.org

Bug: chromium:1015942,chromium:981349,chromium:1019888
Change-Id: Icc7eba3795b97e619b8cbea9252d4e7cbcc64eba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896764Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712132}

This patch adds the ability to resolve ESNI (TLS 1.3 Encrypted
Server Name Indication, draft 4) results concurrently with A and
AAAA records during connection establishment.

This is behind a base::Feature, disabled by default. When the
feature is enabled and DNS over HTTPS is in use, the built-in
resolver will make an additional ESNI transaction concurrently with
the usual ones of type A and AAAA. It also starts a timer (initially
set to the 50ms recommended by the spec) past which to abandon
the ESNI transaction without failing the DNS task.

R=ericorth

Bug: 1003494
Change-Id: Ia73b5e910f2a466b6384c7c73f09705e770ea39d
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879430
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712131}

- Use struct for AdjustPointerTrait.
- Replace TraceIfEnabled with TraceIfNeeded
- Avoid nullptr checks where the next call would anyways crash on
  dispatch

Bug: 1019191
Change-Id: Ib28d3b6c125623bac9a0bbbeda87dfa37528aa48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893061
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712130}

Bug: 1014044
Change-Id: I6361907375c981a567e12c95262bbd02d55c31f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895260
Commit-Queue: Leon Scroggins <scroggo@chromium.org>
Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712129}

When font scanning finished, Blink receives a Mojo IPC callback that
local font matching is now available in
notifies all WeakPtr's to LocalFontFaceSource's if those WeakPtrs are
individually still valid.

After consulting with haraken@ it turns out that using a WeakPtr and
WeakPtrFactory on a heap object is bad practice, as an object may remain
allocated for a little while after being marked for GC - but the WeakPtr
state does not reflect that yet. So when we have callbacks bound to the
WeakPtr they still get executed.

Instead, use WrapWeakPersistent() to in the Bind call in order to drop
the callbacks if the target object for the callback has been collected
by GC.

This should address the assumed GC race condition which is most likely
the underlying issue for issue 1017078.


FontUniqueNameLookupWin: :ReceiveReadOnlySharedMemoryRegion, then it
Bug: 1017078
Change-Id: I9812ec292f2986fc15a3d14cbbfe5381788634d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895334Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712128}

* Fix width of the dialog
* Move the next button to the bottom
* Adapt fonts according to specs
* Make content paddings adaptive

Bug: 1002102
Change-Id: Iad0a84d11ae20104685e4768a8c3805617b8978f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893880Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712127}

Bug: 1020514
Change-Id: Ifb16d619fa1fbd526073366ee749447ccaf7c9c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894009Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712126}

This CL adds the CacheStorageHighPriorityMatch feature.  When enabled
and a cache.match() is sent from a FetchEvent with a matching request
URL the resulting operation will be executed at high priority.  This
means the operation will be placed at the front of the cache_storage
scheduler queue.

This CL also adds a histogram for measuring cache match time in the
browser when the call was initiated from a related FetchEvent.

Note, this CL will result in some match operations completing in
running and completing in a different order than the methods were
called in.  For example,

  cache.add(url);
  cache.match(url);

The match may run before the add if you are in a relevant FetchEvent.

Order of execution and completion was never guaranteed, however.  In
this example the add would likely always write to disk after
the match runs because it has to buffer the response body in the
renderer.  In addition, ordering became even less deterministic when
we shipped executing operations in parallel.

To enforce ordering in this example the site can await the add
promise before proceeding to the match call.

Note, we believe these ordering changes are acceptable since the API
does not really provide transactions.  See here for some spec
discussion:

https://github.com/w3c/ServiceWorker/issues/823#issuecomment-417788337

Bug: 1018920
Change-Id: Ia1991a33db39568f98f0d40a110550174fa53bb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884932
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712125}

Change-Id: I16dd76160de8cec0642f395a87acb2191ba38733
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894419
Auto-Submit: Oliver Li <olivierli@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712124}

897636c9 removed its contents.

Bug: 958255
Change-Id: I6deab12399254f839385654814f8116aa2dbabd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896860
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712123}

This reverts commit fb110ec7.

Reason for revert: Widespread failures on GPU FYI waterfall.

Original change's description:
> Test Dawn on the chromium.gpu.fyi waterfall
> 
> The following bots:
>   Linux FYI Debug (NVIDIA)
>   Linux FYI GPU TSAN Release
>   Linux FYI Release (AMD R7 240 / Intel [U]HD 630 / NVIDIA)
> 
>   Mac FYI Debug (Intel)
>   Mac FYI Retina Debug (AMD / NVIDIA)
>   Mac FYI GPU ASAN Release
>   Mac FYI Release (Intel)
>   Mac FYI Retina Release (AMD / NVIDIA)
>   Mac Pro FYI Release (AMD)
> 
>   Win10 FYI x64 Release (NVIDIA GeForce GTX 1660)
>   Win10 FYI x64 Debug (NVIDIA)
>   Win10 FYI x64 Exp Release (Intel HD 630)
>   Win10 FYI x64 Release (AMD RX 550 / Intel [U]HD 630 / NVIDIA)
> 
> Will run the following tests:
>   dawn_end2end_tests
>   dawn_end2end_validation_layers_tests
>   dawn_end2end_wire_tests
> 
> On the DEPS version of Dawn
> 
> Bug: chromium:1016948
> Change-Id: I91029164d935e4d91d28eb3b802232a358645b0c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873288
> Commit-Queue: Austin Eng <enga@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#711908}

TBR=kbr@chromium.org,enga@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:1016948
Change-Id: I872eb71444d311919c81e81b0abf268a3c49f50d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897806Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712122}

https://chromium.googlesource.com/angle/angle.git/+log/6c7208f93d6e..b9ddfd577a20

git log 6c7208f93d6e..b9ddfd577a20 --date=short --no-merges --format='%ad %ae %s'
2019-11-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader fda994c63075..aaa64b76c0b4 (8 commits)
2019-11-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 618ee509421f..f1e5cd73f658 (3 commits)

Created with:
  gclient setdep -r src/third_party/angle@b9ddfd577a20

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jonahr@google.com

Bug: chromium:None,chromium:None
Change-Id: I53c85b0cef183e2cec60543c1fdcf53a005e8730
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897481Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712121}

This change introduces base::CheckedContiguousRange, which similarly to
base::span is a light-weight wrapper around a contiguous container
performing bound CHECKs.

However, in contrast to base::span this class keeps a pointer to the
underlying container, and thus is able to respond to changes to data()
and size(), which base::span can't do.

Furthermore, this change provides a constexpr overload of base::data()
for std::array and fixes a bug in CheckedContiguousIterator::operator-=.

Bug: 990059

Change-Id: I3fef91c7ef7874bf495ac2ab6dbaf3a8b02dab35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893858
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712120}

This reverts commit d1531b9a.

Reason for revert:
Findit (https://goo.gl/kROfz5) identified CL at revision 711796 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2QxNTMxYjlhYzVhNDlkMTlmOTQ5ZTlkOGY0MmRhZjM0NzBkMzEzMmEM

Sample Failed Build: https://ci.chromium.org/b/8897957936228871696

Sample Failed Step: browser_tests

Original change's description:
> CrOS Shelf: Start moving some hotseat logic into the hotseat widget
>
> The general idea here is to encapsulate more of the hotseat's behavior
> into its own class rather than have it all over the shelf layout
> manager. Eventually, I hope to get rid of the huge
> "CalculateHotseatState" method by setting the hotseat state to the
> appropriate values from the relevant places.
>
> Change-Id: I03bf50bc9f6fb68f7f22f1b6ec966f08f48220da
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893997
> Commit-Queue: Manu Cornet <manucornet@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#711796}

TBR=xiyuan@chromium.org,manucornet@chromium.org

Change-Id: I7dd2357dd075bee067c3bad1aa58db788ba1039e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893885Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712119}

Currently, cookie controls is hidden when the original third-party
cookie blocking is enforced or turned on by the user.
This change make it so that cookie controls always stays; in the above
situations, cookie controls is disabled, toggle set in accordance with
third-party cookie blocking, with an tooltip icon for more information.

Bug: 1019706
Change-Id: I3e7892bcda7eaf70c227a0280219307699cf3bd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881558
Commit-Queue: Huanzhong Huang <huanzhong@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712118}

https://dawn.googlesource.com/dawn.git/+log/314fd3513d04..6df81ebf1dcf

git log 314fd3513d04..6df81ebf1dcf --date=short --no-merges --format='%ad %ae %s'
2019-11-01 bryan.bernhart@intel.com Support for resource heap tier 2.

Created with:
  gclient setdep -r src/third_party/dawn@6df81ebf1dcf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
TBR=cwallez@google.com

Bug: None
Change-Id: I8233c5e6def6a7d217a9a95332a69681dc7c1441
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896680Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712117}

(Original commit failed due to a merge conflict.)

This CL adds logic processing ESNI DNS responses and surfacing the
results via ResolveHostRequest. It contains some nontrivial
functionality and some boilerplate.

The nontrivial functionality (host_resolver_manager.cc and unittests):
- adds the addresses from ESNI records to the
  *address list* contained in the HostCache entry, so that existing
  TCP connection logic will be able to connect to ESNI-accompanied addresses
  in the same manner as addresses without ESNI keys. Before sorting the
  addresses, partition them on whether or not they have accompanying ESNI
  keys, so that the stable sort in AddressSorter implicitly breaks ties
  in favor of addresses associated with ESNI keys.

The boilerplate (all changes except HostResolverManager):
- extends all "expect only one field is present" logic in prior
  host_resolver_manager unittests to reflect that there's now another
  field
- extends all switches on DnsQueryType to accommodate DnsQueryType::ESNI
- extends all subclasses of ResolveHostRequest to implement
  GetEsniContent()

Testing:
- Adds a new group of HostResolverManager unittests for ESNI queries.

Bug: 1003494
Change-Id: I6ec719d134940d281b2d5a6f366454315cbd2869
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895398
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Auto-Submit: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712116}

And adds support for BrowserFragmentControllerImpl containing multiple
BrowserControllers. This patch doesn't contain support for creating
more than one BrowserController in a BrowserFragment. That will come
next.

The reason I'm seperating the Views is to support multiple browsers,
and it seems as though we should support deleting the view, which
is easier with a self contained class.

BUG=none
TEST=none

Change-Id: Idc4a6b2405350b5f9f84d1c046c6d8f839a87ac6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894749
Auto-Submit: Scott Violet <sky@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712115}

https://android.googlesource.com/platform/external/perfetto.git/+log/26280ecc7991..5f25e481c49d

git log 26280ecc7991..5f25e481c49d --date=short --no-merges --format='%ad %ae %s'
2019-11-04 fmayer@google.com Merge "Count retained and uniquely retained bytes."
2019-11-04 treehugger-gerrit@google.com Merge "Add 'mojom' to ipc tracing and 'navigation' and 'browser' to navigation & loading."
2019-11-04 treehugger-gerrit@google.com Merge "TrackEvent: Migrate from legacy_event.name_iid to track_event.name_iid"

Created with:
  gclient setdep -r src/third_party/perfetto@5f25e481c49d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I6a891a4b735aed2c631e7a3746c7ba3efd1dd85d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896678Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712114}

https://chromium.googlesource.com/devtools/devtools-frontend/+log/8cfb8ccc1a..7789823ec9

TBR=yangguo@chromium.org

Change-Id: Ia6a3dd292950f61947c95f0ee6e78d226ade5312
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893883Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712113}

Using wpt-import in Chromium 97701892.
With Chromium commits locally applied on WPT:
1d5b803f "Add WebVTT support for inline styling - Web Platform Tests"
9be931cb "[WPT/common/security-features] Refactor navigable tests"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I0071333c67ac5c4d4fd339ecbb3528df7fe7a8e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897451Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712112}

The filename of metadata for a multiglobal test must match the name of the
FILE that the test originated from, not the name of the test itself.

So for a file like foo.any.js which generates foo.any.worker.html, the
metadata file must be foo.any.js.ini.

For this we must maintian a reverse-mapping from test name to test file in
WptManifest and allow lookups via the Port.

Bug: 937369
Change-Id: Ida16d68d6e0e4ea113b3cd0a1ce05ad9b5cbbc9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893141Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712111}

Bug: 1018135
Change-Id: I3f7694d208ed1cdc5064c8af2a2b7de70a172a2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893998Reviewed-by: Richard Knoll <knollr@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712110}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/53ede12e..557cb1d3

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Iba10c157b767737f872d8629f1f8bf383bb6bd29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897442Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#712109}

TabSuggestionsObserver is used by the orchestrator to broadcast
messages about new suggestion results and when tabContexts
become invalidated.

Bug: 1017896
Change-Id: I5ba99bd920a8fefccf94a3b7137e7dff8bb1074c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879600
Commit-Queue: David Maunder <davidjm@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Mei Liang <meiliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712108}

Following bot results are included.
156 158 162 164 165 168 169 170 171 174

22 lines were removed and 41 lines were deflaked by consecutive
results since 140.

TBR=yosin@chromium.org
NOTRY=true

Bug: 982194
Change-Id: Id0fcef100da11b89b85047ab9275fe246c334855
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892984Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712107}

Instead use base::DeleteSoon which enforces usage of TaskTraits.

This CL is a no-op as-is. It was recently discovered however that some
callers did BrowserThread::DeleteSoon() with pending tasks running on
different task queues (different traits  -- e.g.

TaskTraits to make this more obvious. Please review whether calls in
this CL can be migrated as-is or need additional traits to match
potentially pending tasks.

Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109
for cursory review.

This CL was uploaded by git cl split.

R=sergeyu@chromium.org


TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion...
BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/
Bug: 1019767
Change-Id: I4f27cfa3d6a83257fcbce08a7b85b82795a9baa0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894880
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712106}

Before this patch required and optional arguments part of a direct
action / AA script were not relayed through the direct actions layer.
This patch properly adds these args according to the proto definition
provided by the backend and forwards those args to the direct action
android stack.

R=szermatt@chromium.org

Bug: b/138833619
Change-Id: I964addd2822c81ccd01353f42085889bafa21ae0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895332
Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712105}

weblayer/OWNERS

Bug: n/a
Change-Id: I46cdc1bb985281a775f0dc01b95366594e3e7b45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873727Reviewed-by: Darin Fisher <darin@chromium.org>
Commit-Queue: Christian O. Andersson <cricke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712104}

The public API is not needed any more now that the WebRTC/Peerconnection
implementation resides solely in Blink.
Hence, this CL uses RtcOfferOptionsPlatform directly.

BUG=787254, 919392
R=guidou@chromium.org, haraken@chromium.org

Change-Id: Ic1d6c34e6d85523cdcd473f74c894e8043924fa4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884931
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712103}

The device cloud policy handlers vector holds unique_ptrs to
handlers.  It's more readable to call push_back rather than
emplace_back since the unique_ptr is created by std::make_unique
rather than a call to the unique_ptr constructor.

Bug: chromium:1020443
Change-Id: I28326d2a516099865959466c0a3b0522adcfa304
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891075
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Nikita Podguzov <nikitapodguzov@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Auto-Submit: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712102}

Instead use base::DeleteSoon which enforces usage of TaskTraits.

This CL is a no-op as-is. It was recently discovered however that some
callers did BrowserThread::DeleteSoon() with pending tasks running on
different task queues (different traits  -- e.g.

TaskTraits to make this more obvious. Please review whether calls in
this CL can be migrated as-is or need additional traits to match
potentially pending tasks.

Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109
for cursory review.

This CL was uploaded by git cl split.

R=dullweber@chromium.org


TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion...
BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/
Bug: 1019767
Change-Id: Ida079509147e988cddc134174315d8d24000a73f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895635
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712101}

ChromeTestCase exposes an EmbeddedTestServer property for use by tests,
and includes the header for that class in its own header. This means
that tests can (and do) use symbols from EmbeddedTestServer without
explicitly including them. To make this work, //net:test_support is
a public dependency of the egtest test_support targets, so the individual
egtest targets can link correctly.

This is in general not in line with our "include what you use" policy,
which would prefer that code which uses symbols from an API directly
includes the header for that API, and explicitly declares it as a dep
in gn.

This CL:

  - Makes the test_support dependencies on //net:test_support private.
  - Changes the EmbeddedTestServer header include in chrome_test_case.h
    to be a forward declaration.
  - Updates nineteen egtest.mm files to explicitly include the
    EmbeddedTestServer header.
  - Updates twenty-seven targets in BUILD.gn files to have add a
    //net:test_support as a dependency.


Change-Id: Iea336c66a1a7423732e3aaedcf865882b7ac3a0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892814
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712100}

Stops periodic background sync timers when the scheduler is destroyed.

Change-Id: Ic1d2412df473d74206347cfafbd0fb8c0771b846
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893882
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Auto-Submit: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712099}