- 02 Aug, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4f68ff26e4e9..1dc9ce56c488 git log 4f68ff26e4e9..1dc9ce56c488 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 bsheedy@chromium.org Reland "[Telemetry] Fix GetRecentMinidumpPathWithTimeout log spam" Created with: gclient setdep -r src/third_party/catapult@1dc9ce56c488 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:985530 Change-Id: Ib01952086415de6959032c39fd6b77c679e1907a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733515Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683714}
-
Ben Kirchman authored
Other build and distribution systems are not yet setup to handle another jar. To avoid having a missing target, move the util library target inside the common jar, so that it will build properly and be able to be found by the Java platform implementation of Cronet. Bug: 669707 Change-Id: I8b98d5f09fb789075734962934a5d9b52a9a561d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733433Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Benjamin Kirchman <kirchman@google.com> Cr-Commit-Position: refs/heads/master@{#683713}
-
Abhishek Bhardwaj authored
This change updates the property JSON to allow day of month the full range of values from 1 to 31. This reflects the existing implementation that handles monthly rollovers. BUG=924762 TEST=Unit tests. Change-Id: I9672ccc77a33118e9c668c9ff05459354889dbc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732433Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Cr-Commit-Position: refs/heads/master@{#683712}
-
Ken Rockot authored
This is a reland of 76c1237a with stale #includes removed (see PS1->PS2) Original change's description: > Remove "chrome" and "chrome_renderer" services > > This eliminates the existence of the "chrome" and "chrome_renderer" > services as well as general support for embedder-provided process-wide > browser and renderer Service Manager services. > > Remanining browser<->renderer interfaces which used these services have > been migrated to use direct receiver binding via > content.mojom.ChildProcess or content.mojom.ChildProcessHost messages. > > Change-Id: I74f012aafe77fdcbbba8d93d193d3ded8d63d445 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729968 > Reviewed-by: Luke Halliwell <halliwell@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#683650} NOPRESUBMIT=true Change-Id: I03c7a26fc2f5085078de12a4642837f8f7b28c8b Tbr: avi@chromium.org Tbr: boliu@chromium.org Tbr: halliwell@chromium.org Tbr: tsepez@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733577Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#683711}
-
Sam Maier authored
TBR: estevenson - OOO right now Bug: 990411 Change-Id: I43a64422eaa8345991fa255084b95e2e119fa494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733021 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#683710}
-
David Bertoni authored
This CL removes ExtensionService::GetExtensionById(). TBR=atwilson@chromium.org TBR=battre@chromium.org TBR=benwells@chromium.org TBR=dtrainor@chromium.org TBR=estade@chromium.org TBR=lazyboy@chromium.org TBR=reillyg@chromium.org TBR=sky@chromium.org TBR=stevenjb@chromium.org TBR=tapted@chromium.org TBR=thestig@chromium.org Bug: 489687 Change-Id: I3919bd1b0b76f32190750a63f3088cfe528e6a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704521 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#683709}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/149f3f197897..17b9d1d1deaf git log 149f3f197897..17b9d1d1deaf --date=short --no-merges --format='%ad %ae %s' 2019-08-02 fmalita@chromium.org [skottie] Initial Hue/Saturate effect support 2019-08-02 mtklein@google.com x86 store16 2019-08-02 robertphillips@google.com Increase specificity of GrColorType computed for YUV planes 2019-08-02 reed@google.com fix bicubic to not be confused by rotated ctms 2019-08-02 robertphillips@google.com More SkAutoPixmapStorage 2019-08-02 csmartdalton@google.com Extract a GrRenderTask base class from GrOpList 2019-08-02 mtklein@google.com x86, load16 2019-08-02 halcanary@google.com experimental/editor: cleanup 2019-08-02 mtklein@google.com x86 uniform8 Created with: gclient setdep -r src/third_party/skia@17b9d1d1deaf The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: Ie948c2ff528da2ba0399b78309b9818c0726ae78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733729Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683708}
-
Juanmi Huertas authored
We are now using SharedImage to hold the image for the video renderer, https://chromium-review.googlesource.com/c/chromium/src/+/1616978. That change, together with the change that made the video be deferred, and therefore, use the paintRecorder, let us safely remove the workaround. We are adding some comments to explain that removal, in case that this is stopped being deferred at any point. Bug: 974656 Change-Id: If050f1f12b098709e20547cb56709d4e5381af90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733438 Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#683707}
-
Michael Thiessen authored
Any CCT intents at this point are internal CCT intents, possibly coming from the WebApk itself opening a new tab, so we shouldn't redirect them back into the WebApk. Bug: 983769 Change-Id: If0fb0b3c3a9a2641955e6226709fcb01475ae050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732877Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#683706}
-
Robert Ogden authored
This is still used in integration testing. Bug: 969949 Change-Id: I5b89c617324f541fb7429748f4f7b7c2e1f76207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728435 Auto-Submit: Robert Ogden <robertogden@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#683705}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/59d55a331c46..029a36c7cbfc git log 59d55a331c46..029a36c7cbfc --date=short --no-merges --format='%ad %ae %s' 2019-08-02 capn@google.com Omit null initialization of sampler cache pointers Created with: gclient setdep -r src/third_party/swiftshader@029a36c7cbfc The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/137649247 Change-Id: I769884a0b1dceab9d31a1efd8f91b67678d1b996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733574Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683704}
-
David Benjamin authored
We currently rely on all SSLConfigService-managed parameters being passed into the socket pools identically from HttpNetworkSession. Instead, abstract that behind SSLClientContext. SSLClientContext now consumes the SSLConfigService OnSSLConfigChanged signal itself and exports its own signal for the callers. This means the socket pools can use one observer interface to invalidate everything. As part of this, split SSLConfig in two: SSLConfigService manages a smaller SSLContextConfig which is shared across the whole context, while SSLConfig is per-socket configuration. Bug: 951205 Change-Id: I018a26bbc2a57f954df48249a8e4bc8b55a1ad26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703205Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#683703}
-
Carlos Caballero authored
Remove references of MessageLoopForIO in /chrome/browser/data_reduction_proxy/data_reduction_proxy_settings_unittest_android.cc MessageLoopForIO will go away soon use ScopedTaskEnvironment instead. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=dtrainor@chromium.org Change-Id: Ie7b352f51f26993d3408a37ba1a88803d43f8151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733593 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#683702}
-
Istiaque Ahmed authored
Extensions that are run as an event page or as a SW based extension uses ContextType as test parameter. This CL moves the definition under ExtensionBrowserTest so that tests that uses the concept can reuse this and not have to redefine the enum. Bug: None Test: No visible changes expected. Change-Id: I43e7c32b4950d556789bae117a29e8660e24f30c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730866Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#683701}
-
Zhongyi Shi authored
The alerts are still quite noisy, and most of them are not actionable by Cronet sheriffs. Change-Id: Ib2bbd9abb2f852a206b3eb4c8a58ad7275212d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733027 Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#683700}
-
Matthias Körber authored
Change-Id: I20a1a803437e474f7071c0b8a5c6de3fb5ff6cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664140 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#683699}
-
Istiaque Ahmed authored
For SW extensions, this CL makes UpdatePermissions IPC to update bindings of all workers on an extension if the extension is Service Worker based extension. This CL moves some bindings update code from Dispatcher to NativeExtensionBindingsSystem. This CL enables "permissions" API to SW based extensions and adds a simple test for that. Bug: 986416 Change-Id: Iba9dcd45da5304afa3a72f051e345cadf66d565c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710130 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#683698}
-
Matt Mueller authored
Bug: 410574 Change-Id: I407332f05d591709f5602d92e5697caa48140ab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731102 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Doug Steedman <dougsteed@chromium.org> Cr-Commit-Position: refs/heads/master@{#683697}
-
Nina Satragno authored
Do not DCHECK on ChromeAuthenticatorRequestDelegate::DoesBlockRequestOnFailure if the authenticator is nullptr. This situation could arise if the user e.g. disconnects the authenticator while setting the pin. Bug: 990136 Change-Id: Iea8c509ef7ae2d74feabbc7d8e66cde51a266a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733023 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#683696}
-
Sammie Quon authored
Fix highlights not being positioned correctly if the shelf is not bottom aligned. This is because we use the mini-views layer target bounds, which are in local bounds, so we need to account for the parents target bounds, in this case the desk bar view. Fix highlights not repositioning after adding an item. Fix being able to highlight the new desk button even if it is disabled. Also fixes a crash when the highlight is on mini view, and a desk other than the highlighted one is deleted. Also the rounded corner of the highlight matches the new desk button when it is highlighting it. Test: added tests Bug: 988183, 988134, 988126, 989795 Change-Id: I6a44ded06bce1089946dcfdc793ac4b35be4ca4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722193 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#683695}
-
Lucas Gadani authored
Also record a crash key with the error so it's easier to debug. Bug: 881099 Change-Id: I79e44c0331fcb0a7924cb86efc88f72ece73be82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731669 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#683694}
-
Hazem Ashmawy authored
- Add methods to CrashFileManager to list files with certain upload states: forced uploads, skipped upload or ready for upload but not forced. - These methods match the suffix of file names which is used to record minidump file upload state. - Add UnuploadedFilesStateLoader which get the upload state of Unuploaded crash files. It uses the newly added methods in CrashFileManager. - This info should be combined with info collected from other logs then used in WebView crash UI. Bug: 964392 Change-Id: Id31013de2dd45235a4a1147591ef3636389b9e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617766 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#683693}
-
Min Qin authored
interrupt reasons for background mode This CL adds more UMA to analyze why download is interrupted in background mode. It also changes the target determination logic to generate a new file path in case the original target is no longer accessible. During target determination, chrome will try to preserve the existing target path and file name, and use public download storage as a backup. BUG=989670 Change-Id: I21ed2d65ce813f1537f5a92a011d6414171a1bd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729834 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#683692}
-
about://flagsAran Gilman authored
Cross-platform access to "forced dark mode" and its config options is currently available via the --blink-settings flag. This change simply provides easy access to specific sets of config options for testing. Bug: 985961 Change-Id: I733c2e7b896e8a5d5fffc1b9d783473db4056c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721002 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#683691}
-
Carlos Caballero authored
MessageLoopForIO is going away soon. Use SingleThreadTaskExecutor instead. This CL was uploaded by git cl split. R=nharper@chromium.org Bug: 891670 Change-Id: Ife2524ad96a7a7c3c7df99d996f6d101a3afa88b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733587 Auto-Submit: Carlos Caballero <carlscab@google.com> Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#683690}
-
Gang Wu authored
TBR=sky@chromium.org Bug: 990214 Change-Id: I551f7832f6345b854d33c3517d4675acab3a20b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732741Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Auto-Submit: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#683689}
-
Clark DuVall authored
Also removes the kNavigationLoaderOnUI feature. We can do more cleanup of the throttles/interceptors in separate CLs. chrome/ usages removed in http://crrev.com/c/1731919 Bug: 824840 Change-Id: I1038900a4f97449ceab152df24c49f0719a195d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732409 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#683688}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/825233007c7d..ad77f55e0183 git log 825233007c7d..ad77f55e0183 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 syoussefi@chromium.org Vulkan: Remove finish calls before BufferVk::mapImpl Created with: gclient setdep -r src/third_party/angle@ad77f55e0183 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: If078e165555d3d6c70304597e8465fc196531339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733571Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683687}
-
Sophie Chang authored
Bug: 986387 Change-Id: I482a439b8609a116a96c231b8a63ac891d6ea067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724578 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#683686}
-
Matt Menke authored
It's the only implementation (Other than a test-only subclass that this CL removes). To avoid a circular dependency, this CL also moves HttpServerPropertiesManager::PrefDelegate into HttpServerProperties. TBR=rohitrao@chromium.org TBR=seantopping@chromium.org Bug: 984996 Change-Id: I00b6d3633b16afb47b5f00738ea0e128f9dc69db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724586Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#683685}
-
Jimmy Gong authored
- Displays a message to users if there is no connection to the internet. - This CL adds cloud off icons for settings printers landing page. - Fixes a bug where cupsPrinters wasn't correctly checking for connectivity status. - Updates browserTests. - Updates fake network api's for testing. - This CL is hidden behind the enableUpdatedUi feature flag. Bug: 965721 Test: End to End manual, browserTests Change-Id: Ic0cec85aeba408a02d7ec1bb864a8ae00c31c915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715731 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#683684}
-
Chris Sharp authored
Test appears to be flaky. TBR: alemate@chromium.org Bug: 990362 Change-Id: Ifff26b1242e3d2621426d10a3c0cb808d16b345c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732736 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#683683}
-
Elly Fong-Jones authored
This change adds a new top-level menu to the system menu, used to manipulate and select tabs in the current window. This menu contains some static items, moved from the Window menu, and then a list of entries corresponding to open tabs in the current window. Specifically, this change: 1) Adds a new class, TabMenuBridge, which binds a TabStripModel to a NSMenu; 2) Adds a new menu item to the main menu named "Tab"; 3) Creates a TabMenuBridge for any tabbed browser window in the app controller. The motivation for this change was twofold: first, to allow easier access to commands that are currently only present in the tab's context menu, and second, to allow easier access to tabs in crowded tabstrips. The first purpose is well-defined and understood but the second is very much experimental. Testing: Build, run, and enjoy the new Tab menu :). There are some unit tests in TabMenuBridgeTest.* as well. Future work: * Renaming the static items to better fit their new context. This was not done here to avoid breaking existing user key equivalents, which identify items by their full name. * Exploring other orderings of tabs in this menu. * Adding other tab actions to this menu, like "Bookmark" or possibly page actions. * Adding a search bar to search within tab titles/origins? * Adding key equivalents for the static actions (which will resolve the actual accessibility bug this commit is for) Bug: 818261 Change-Id: I790cc2c5a4468719e42b782a318864ecd81bd1f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728718 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#683682}
-
Avery Musbach authored
When you press the Escape key, OverviewSession::OnKeyEvent checks for split view mode with no overview windows, to avoid ending overview then. This check is unnecessary because OverviewController::ToggleOverview will bail out. It will hide the virtual keyboard first, but when you press the Escape key in the first place, you must have an external keyboard and therefore no virtual keyboard. FALLTHROUGH between case ui::VKEY_BROWSER_BACK and case ui::VKEY_ESCAPE is also unnecessary, and is inconsistent with between case ui::VKEY_RIGHT and case ui::VKEY_TAB. Test: ash_unittests OverviewSessionTest.ExitOverviewWithKey Change-Id: I26e5d6ae752d040aaf1bc40c798f00548c4730fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733727Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#683681}
-
Brian White authored
Updates the expires_after attribute for 229 histograms that show frequent access in the past 90 days. These are the 30% most frequently used histograms over that time that do not already have a date later than or within 30 days of 2020-01-26. Change-Id: Ia73aa2bdbff267afa756fe663a2fbaac187ec762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732331 Commit-Queue: Brian White <bcwhite@google.com> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#683680}
-
Chris Sharp authored
This was causing flaky compile failures on Linux ChromiumOS Full bots. Example failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20Full/139037 TBR=xiaohuic@chromium.org Change-Id: I60b94045b5d55ff9c627351e25aa5bf25c199ead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732745Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#683679}
-
Daniel Rubery authored
Similar to the TwoPhaseUploader, add a factory for MultipartUploadRequest, so that consumers of the MultipartUploadRequest can mock out the network operations. This CL also fixes two minor problems with the MultipartUploadRequest, changing the callback structure and fixing tests. Bug: 980784 Change-Id: Iba9ebb1d985fd9df697c5b9f96e1b6d57bd1cbc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728541Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#683678}
-
Nate Fischer authored
WebView needs to add variations-specific headers to the CORS-exempt headers list, otherwise we may trigger excessive CORS preflight checks. Bug: 990072 Test: Enable "OutOfBlinkCors", WebView still seems to work Change-Id: I9ad69dd52fc53bbbce01a33724050322b642a70a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731555 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#683677}
-
Carlos Caballero authored
MessageLoopForIO is going away soon. Use SingleThreadTaskExecutor instead. This CL was uploaded by git cl split. R=lambroslambrou@chromium.org Bug: 891670 Change-Id: Id1c49577b98d4adc705d1eec6a164382fb5aba77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731848 Auto-Submit: Carlos Caballero <carlscab@google.com> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#683676}
-
Findit authored
This reverts commit 76c1237a. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 683650 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzc2YzEyMzdhYTBmY2RkZDA1MzZmZTE5OWQzMTBlNjVjM2JiOGY0M2EM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/win-archive-rel/3564 Sample Failed Step: compile Original change's description: > Remove "chrome" and "chrome_renderer" services > > This eliminates the existence of the "chrome" and "chrome_renderer" > services as well as general support for embedder-provided process-wide > browser and renderer Service Manager services. > > Remanining browser<->renderer interfaces which used these services have > been migrated to use direct receiver binding via > content.mojom.ChildProcess or content.mojom.ChildProcessHost messages. > > Change-Id: I74f012aafe77fdcbbba8d93d193d3ded8d63d445 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729968 > Reviewed-by: Luke Halliwell <halliwell@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#683650} Change-Id: I797753e6cb96874ca92a245bcb493b669689a981 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733026 Cr-Commit-Position: refs/heads/master@{#683675}
-