GitLab

4 flake occurrences of this test have been detected within the
past 24 hours. List of all flake occurrences can be found at:
https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyVQsSBUZsYWtlIkpjaHJvbWl1bUBpb3NfY2hyb21lX3VpX2VnMnRlc3RzX21vZHVsZUBPcGVuSW5NYW5hZ2VyVGVzdENhc2UvdGVzdE9wZW5JblBERgw.

Bug: 1152782
Change-Id: I9ed1a6ea0ea50ce447d1fa523ba880483a057625
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560268
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Auto-Submit: Ewann Pellé <ewannpv@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831077}

https://skia.googlesource.com/skia.git/+log/3e2e7b28b699..6e5079a280ed

2020-11-25 mtklein@google.com minor hash_fn() followups
2020-11-25 johnstiles@google.com Detect invalid boolean binary expressions.
2020-11-25 brianosman@google.com Reland "Move GL's SkSL::Compiler to the GPU (like all other backends)"
2020-11-25 jlavrova@google.com Heuristic for filtering out too big editing text cases
2020-11-25 johnstiles@google.com Code cleanup: Add isScalar/isVector/isMatrix helpers to Type.
2020-11-25 johnstiles@google.com Replace SPIR-V assertion with mixed-types error message.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: michaelludwig@google.com
Change-Id: Ic6d23656885a8974813cc5458f8d1d81376b7b78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560540Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#831076}

This is part of an effort to make CanonicalCookie's constructor private.

Since make_unique<T> will not compile if T's constructor is private, we
need to replace uses of make_unique in CanonicalCookie's implementation
with base::WrapUnique() and the "new" keyword.

Bug: 1102874
Change-Id: Ie5de0b4814cd8c39c5ff7484f2a8f880f2ec810d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559287Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Cr-Commit-Position: refs/heads/master@{#831075}

This adds CSS rules to the contact visibility page that will truncate
and elide the name or email of any contact if it is long enough to
overflow the given width.

Screenshot:
  https://screenshot.googleplex.com/siHhtdWNFVeEphM.png

Bug: b:168841167
Change-Id: Idaef4ea803b95b8ade014d30271474cc6806d9d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559235Reviewed-by: James Vecore <vecore@google.com>
Commit-Queue: Michael Hansen <hansenmichael@google.com>
Cr-Commit-Position: refs/heads/master@{#831074}

VpnServiceFactory::GetInstance() and
VpnServiceFactory::GetForBrowserContext() are declared at the extensions
layer but only defined by its embedders (chrome and shell). This is
incorrect since it means any targets depending on extensions without
defining these methods will fail to link. Prevent this by providing an
implementation at the extensions/ layer and removing the embedder
implementations.

BUG=981112

Change-Id: Ic6af1b8e95b7bf569fd5791031facd8e30f52ba1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557222
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831073}

This will make it easier to use this factory when testing code that uses
SetCanonicalCookie() and other methods that take unique_ptrs to
CanonicalCookies.

The factory method uses base::WrapUnique to create the unique_ptr so
that the constructor can be made private. I plan on updating the other
factory methods to use base::WrapUnique instead of make_unique in a
follow-up CL.

Bug: 1102874
Change-Id: I3e84fbc68ce95438a5adfdac46573df9efe4e38d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559311Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Cr-Commit-Position: refs/heads/master@{#831072}

Generate DIR_METADATA files and remove metadata from OWNERS files for
//components/polic

Change-Id: I997f3ab15d694f1e8a18e415ea70b2b75ce84b65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554297Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Norman Rosas <normando@google.com>
Cr-Commit-Position: refs/heads/master@{#831071}

Fixed: 1121509
Change-Id: I9b6919dfa12a31909d4cee9cbcc02638bbfe2813
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559645Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831070}

This CL is the result of running the proto_export script.

Change-Id: Ib08c5a7475c4f02c6a37eb18c9ef49e1548ee533
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559225Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Auto-Submit: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831069}

Generate DIR_METADATA files and remove metadata from OWNERS files for
//components/permissions...

Change-Id: I30b56f259921200689ecd498cbecbc40195cd47b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553858Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Norman Rosas <normando@google.com>
Cr-Commit-Position: refs/heads/master@{#831068}

Changed the font color to match that of test of the rest of InfoBar
description, and adjusted padding so that e-mail address is in-line with
the InfoBar description text.

Screenshot in light mode:
https://screenshot.googleplex.com/WvQjfXKKzEasV9e

Screenshot in dark mode:
https://screenshot.googleplex.com/6qGQsoDgHYMafde

Bug: 1152332
Change-Id: Ib5c25e83fac3f7d734bcb35ecfa78c6a15456f53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559714Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Anne Lim <annelim@google.com>
Cr-Commit-Position: refs/heads/master@{#831067}

Fix use-after-move (potential) bugs found by the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: I362e6fce1d3c456f313f9532a4d160d3bd660dd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555040
Commit-Queue: Yury Khmel <khmel@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Auto-Submit: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831066}

Generate DIR_METADATA files and remove metadata from OWNERS files for
//components/safe...

Bug: 1113033
Change-Id: Ie90bfbec0faaa8b4287e71434511880e7386ff1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555697Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Norman Rosas <normando@google.com>
Cr-Commit-Position: refs/heads/master@{#831065}

This reverts commit e0e81ba9.

Reason for revert: crbug.com/1152818

Original change's description:
> More inclusive terminology for chrome/browser/win/conflicts/.
>
> Bug: 1097283
> Change-Id: I570f98b1f42487aff2696c50f87fd0832667379b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547620
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Auto-Submit: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Reviewed-by: Jesse Doherty <jwd@chromium.org>
> Reviewed-by: Patrick Monette <pmonette@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: Chris Hamilton <chrisha@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#830830}

TBR=pkasting@chromium.org,chrisha@chromium.org,gab@chromium.org,jwd@chromium.org,tedchoc@chromium.org,pmonette@chromium.org

Change-Id: Iecaebbf4e63fb2d0c52aa87d5eca9ce7e424070d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1097283
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560807Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Commit-Queue: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831064}

Without this some metrics and trace events report jank for
deferred non-nestable tasks.
See bug for all expected side-effects of this change.

Drive-by: Fixed incoherent use of anonymous-namespaces in
          sequence_manager_impl_unittest.cc

R=altimin@chromium.org, fdoray@chromium.org

Bug: 1152095
Change-Id: I0ab9e52c508e6244e6263260918298deb70449a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555900
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831063}

This will enable a presubmit to prevent reintroduction of the deprecated
base::CancelableCallback and base::CancelableClosure in directories that
have been migrated. This follows on from crrev.com/c/2505963, which
ensures that all converted directories have been appropriately migrated.

Bug: 1142629
Change-Id: I2ad4ba9340d8023c34835120b84173de83265291
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506350Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Alex Turner <alexmt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831062}

On pressing Escape, the realbox input as well as the matches should be
cleared if the first match is selected or there are no selected matches.

Fixed: 1054481
Change-Id: I7f196555c0f735b1d5058bd633c2482b09624957
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559643Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831061}

This reverts commit 46c618aa.

Reason for revert: crbug.com/1152817

Original change's description:
> feed: Don't spin the spinner when its ancestors are hidden
>
> Currently, the spinner used in feed will only stop() its animation if
> the spinner view itself is hidden through setVisibility(). However, in
> reality, one of its ancestor views is hidden instead.
>
> This causes a continuous invisible animation to tick at the display's
> refresh rate (usually 60fps) if the spinner was ever shown, until it is
> destroyed (when the NTP views are eventually evicted).
>
> Instead, stop the animation also when any of the spinner's ancestors
> become hidden by listening for visibility changes and window attachment
> state changes.
>
> Bug: 1151391
> Change-Id: Ib7b7a8e56f083619420fd58f4340991253402535
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552781
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Reviewed-by: Jian Li <jianli@chromium.org>
> Commit-Queue: Eric Seckler <eseckler@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#830957}

TBR=dewittj@chromium.org,jianli@chromium.org,skyostil@chromium.org,eseckler@chromium.org

Change-Id: Iac8698c1bd7cf2eb5101e7a85811ab15ff929f5f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1151391
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560825Reviewed-by: Gang Wu <gangwu@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831060}

Since chromium:2559554 is still WIP, separating out this text asset to make it easier to track the strings deadline.

Bug: 1125150
Test: browser_tests --gtest_filter=Diagnostics*
Change-Id: I66c714b5fa46bd0b81452034b29f10b9924e4173
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559593
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Auto-Submit: Joon Ahn <joonbug@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831059}

Fix use-after-move (potential) bugs found by the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: I36d91b00183ce25f486dc42efb344cd537d63af8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556677
Auto-Submit: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831058}

Generate DIR_METADATA files and remove metadata from OWNERS files for
//components/payments

Bug: 1113033
Change-Id: I6ff2eed12a409143f15a7798407f44efd4ac1ff3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544869Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Norman Rosas <normando@google.com>
Cr-Commit-Position: refs/heads/master@{#831057}

https://webrtc.googlesource.com/src.git/+log/9db3ab201ec7..9a5e21da681d

2020-11-25 danilchap@webrtc.org in Vp8 encoder fill resolution into codec agnostic structure
2020-11-25 landrey@webrtc.org Revert "Filter out NaNs before uploading to the dasboard"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Ie515c4194c6a46214126d0ece983d6fd1003996a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561018Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#831056}

Background memory dumps are used for UMA reporting, and thread cache
stats are only reported for full ones. Collect them for all dumps, to
appear correctly in UMA.

Bug: 998048
Change-Id: I5810b839909ec94ed779d7b4034cbd53c13f0891
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553552
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831055}

There were no restrictions on which URLs could be used as the base URL
when using webview's loadDataWithBaseUrl API. This could allow for an
embedder to impersonate another extension through a webview.

We now restrict the base URL to HTTP(S) or the embedder's own origin.

Bug: 1108126
Change-Id: I093a3d2c75cfb2f307ceca43add513194df13854
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553704Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831054}

This removes the :all_java target that was added in
http://crrev.com/c/2463649.

Bug: 1126301
Change-Id: I63c5dee910310baa147269b6fa5bc97c791edb9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558923
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Auto-Submit: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831053}

https://chromium.googlesource.com/angle/angle.git/+log/bb4f496d2a32..732dc2952044

2020-11-25 jmadill@chromium.org Fix auto-generated export file comment.
2020-11-25 jmadill@chromium.org EGL: Auto-generate entry point headers.
2020-11-25 xinghua.cao@intel.com D3D: Fix wrong visit mode

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: jmadill@google.com
Change-Id: I6510885b73aa356861cf0b47279e7735760fa159
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560966Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#831052}

This CL migrate the target c.b.sigin to c.b.signin.ui target.

Bug: 1152505
Change-Id: I989ee366e81e8ede4ba66dd444088dfe75b6376a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560500
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831051}

BlobURLToken was passed as a raw message pipe due to legacy IPC, but
OpenURL() has since been migrated to Mojo.

Bug: 1093920
Change-Id: Ie5f3213010b43b11a4b3327b7e531afe8965a84d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559800Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831050}

Had to change some tests because of this:

WebFrameTest.SmartClipData and
WebFrameTest.SmartClipDataWithPinchZoom:
Force Android editing behavior, or else it would fail on Mac and UNIX.
CL:2552591 copied behavior from LayoutBlock::PositionForPoint(), where
we'd consider non-hit-test candidates if there were no actual hit-test
candidates. We now do this consistently, while in legacy layout we'll
only do it for block children. The test here has only floated children
(which means that ChildrenInline() will return true). (Adding an empty
regular block next to the floats would change the behavior completely
(since we'd then get the "block children behavior"), which is bogus).
Since the point is below the float, on Mac and UNIX the start offset
will now be at the end position inside the float that's just above the
rectangle (because the caret is moved to the element boundary), rather
than including the entire (parent) container. On Android and Windows
this doesn't happen (since the caret isn't moved to the element
boundary, and the caret happens to be exactly at offset 0, because of
the x position of the point).

editing/selection/click-on-block-image.html:
Since NG PositionForPoint() finds what actually is the closest box
(rather than doing it inaccurately in some cases, like legacy), we'll
hit the line boxes in the test more than before. Test a bit further down
to keep the test passing. Note that the manual version of the test
passes anyway (i.e. the caret is placed on the correct side of the
image, even when we hit the line boxes instead of the image).

editing/selection/continuations-with-move-caret-to-boundary.html:
Again, we now find the box that's actually the closest one, so aim
better.

editing/selection/offset-from-point.html:
Remove workaround for vertical writing modes, since it would make us
fail now.

fast/writing-mode/positionForPoint.html:
We now hit what's actually the closest box. This test is part of
https://bugs.webkit.org/show_bug.cgi?id=92202 , and there's nothing that
suggests that we depend on the old behavior.

Bug: 1150362, 829028
Change-Id: I733b154ef473ab3d8064554213dde2e9b948e040
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553547
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831049}

Step 2 for bug 1125106. This is a subset of the mega-patch in
https://chromium-review.googlesource.com/c/chromium/src/+/2462248.

In order to address crbug.com/1125106, we would like to enforce that we
do not call GetFrameHostForNavigation() with a same-document navigation.

In order to fix crbug.com/1018385, a conversion from same-document to
cross-document was introduced when a navigation request fails (for
example when it is blocked). This was added in CommitErrorPage() which
is called directly from OnRequestFailedInternal() or after that method
runs the NavigationThrottles which eventually call back to
NavigationRequest::OnFailureChecksComplete().

But since OnRequestFailedInternal() needs to first call
GetFrameHostForNavigation(), we want the NavigationRequest to be
converted to cross-document before that call, which means before we run
the NavigationThrottles instead of after. So we move the conversion from
CommitErrorPage() up to OnRequestFailedInternal().

R=alexmos@chromium.org, creis@chromium.org

Bug: 1125106
Change-Id: Iab3d1fb60433a0600c67c72da8f122fd75120802
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552943
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831048}

And include the stack when on throwIfDestroyed failure to make the
message more useful.

Change-Id: I4a801d7208cb35c44bf6fbd6d58f3f424eaefd61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561038
Auto-Submit: Bo <boliu@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831047}

Roll Chrome Win64 PGO profile from chrome-win64-master-1606283471-0c692a03b66417a93fe8e91b8a0c4f515aaad0a9.profdata to chrome-win64-master-1606293619-712b869bfc91985e78185bbfc14de73d07d8077a.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I9445236d2a9b588f9d9619c60d3d9f88302dce1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560866Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#831046}

Done with:

./gather_swarming_json_results.py \
  --step webgl_conformance_gl_passthrough_tests \
  --output=../data/gpu/webgl_conformance_tests_output.json

./gather_swarming_json_results.py \
  --step webgl2_conformance_gl_passthrough_tests \
  --output=../data/gpu/webgl2_conformance_tests_output.json

Updated documentation and defaults of gather_swarming_json_results.py.

Bug: 1152197
Change-Id: I6f4f2081af03e2be9936c41ee2d97eb02af558f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559316Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831045}

When a browsing context is opened with the noopener flag set, do not
clone its SessionStorage from the opener's SessionStorage

Bug: 771959
Change-Id: I3040d8c0f490198f3414fb9b9108cfccca0da486
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809006
Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831044}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/16534e267df0..d4403bdefc66

2020-11-25 alexrudenko@chromium.org Remove a redundant interface for persistent highlighters
2020-11-25 tvanderlippe@chromium.org Reland "Migrate elements/ extensions of type 'view'"
2020-11-25 patrick.brosset@microsoft.com Fix regression where color-picker isn't anchored on the color swatch
2020-11-25 tvanderlippe@chromium.org Cleanup package.json scripts
2020-11-25 tvanderlippe@chromium.org Remove custom Closure Compiler integration
2020-11-25 jacktfranklin@chromium.org [DataGrid] support filter parser input
2020-11-25 tvanderlippe@chromium.org Remove skip_compilation from module.json files
2020-11-25 tvanderlippe@chromium.org Remove Closure type definitions
2020-11-25 tvanderlippe@chromium.org Remove JSDoc validator

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1125968,chromium:1134103,chromium:1152347
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: If77bbd3b704d700c8bd1b7a15bc9cc2cc463c09c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560870Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#831043}

When there is a pending request and chip UI is used, after switching to
fullscreen mode bubble UI should be used if pending request is new (chip
haven't been collapsed yet). This prevents case when permission was
requested and shorty after that user switches to fullscreen mode and
cannot see pending request anymore.

When switching from fullscreen mode, if request should be shown with
chip UI, switch back to it with bubble opened. This provides visual
consistency and in regular mode with chip UI bubble is easily dismissable.

Bug: 1148332
Change-Id: I52886d95842db45ec72997127f25010585d97670
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540527
Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831042}

This is a reland of f7713274

Original change's description:
> Fix session restore after launching with PWA.
>
> The underlying issue is that the kProfilesLastActive pref gets
> cleared when Chrome is launched with a specific profile, which
> prevents Chrome from iterating over the last active profiles
> and calling session restore on each of them. This CL stops
> clearing the pref when launched with --app-id, and avoids
> restoring sessions for the last active profiles
> if launched with --app-id. Also, ignore browser opens and
> closes if the browser window is for a web app, in order to prevent
> kProfilesLastActive pref from getting overwritten.
>
> Bug: 1022795
> Change-Id: I350a54eaaf167dabb297b9bda9061fe965f0750e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984710
> Reviewed-by: Greg Thompson <grt@chromium.org>
> Reviewed-by: David Roger <droger@chromium.org>
> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#827876}

Bug: 1022795
Change-Id: Ia09ddd04dcd853f8bc7322ecf7767580f3076ccf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546841
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831041}

Also removed unused callback in EncryptionMigrationScreen

Bug: 1104120
Change-Id: I490f020fd7ce4ea6a3a9dbb6ef8fefb7796eca02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558237Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831040}

The only remaining uses are:
- blink_test_runner.cc: add a ResetForTesting to replace this usage
- web_frame_test.cc: use frame loader directly in a couple of places.

Change-Id: Ib0fd7ca413bb2cc2ef77d0e9e9b2c5c399d3b508
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198866
Auto-Submit: Fergal Daly <fergal@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831039}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1bb4e5eef6d3..3558df528adf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC etiennep@google.com,pmarko@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: etiennep@google.com,pmarko@google.com
Change-Id: I53962b196f638635141e3e0a3b6b5746fe4982a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560967Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#831038}