GitLab

BUG=73445
TEST=ExtensionPrefsAppDraggedByUser

Review URL: http://codereview.chromium.org/6543017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75497 0039d316-1c4b-4281-b951-d872f2087c98

To reduce the size of this change I've left stub header files in chrome/browser/dom_ui/options.

I'll updated the references and delete the stub files later.

BUG=59945, 59946
TEST=trybots

Review URL: http://codereview.chromium.org/6469067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75496 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75493 0039d316-1c4b-4281-b951-d872f2087c98

TBR=avi
Review URL: http://codereview.chromium.org/6543033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75491 0039d316-1c4b-4281-b951-d872f2087c98

: Increase the minimum interval for timers on background tabs to reduce
their CPU consumption.

The new interval is 1000 ms, or once per second. We can easily adjust
this value up or down, but this seems like a reasonable value to judge
the compatibility impact of this change.

BUG=66078
TEST=none (tested manually with minimal test case)

Review URL: http://codereview.chromium.org/6546021

TBR=kbr@google.com
Review URL: http://codereview.chromium.org/6538073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75490 0039d316-1c4b-4281-b951-d872f2087c98

TBR=avi
Review URL: http://codereview.chromium.org/6532073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75489 0039d316-1c4b-4281-b951-d872f2087c98

Patch by fischman@chromium.org:
http://codereview.chromium.org/6542029/

BUG=69218
TEST=none

TBR=scherkus@chromium.org
Review URL: http://codereview.chromium.org/6538070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75483 0039d316-1c4b-4281-b951-d872f2087c98

In preparation for attempting to support __stdcall, __fastcall, etc., break
apart the templates so that instead of having one set of InvokerNs per type
of function pointer, only have one per syntactic method of invocation.

This lets the number of template specializations scale better.  Previously,
for each type of function pointer, we needed sum(1...arity) InvokerN
specializations.  There were 3 types (function, method, const method).
The Windows calling conventions would have added another 2.

in this method, we have 2 sets of InvokerN templates, and 1 set of
FunctionTraits templates for each type.  We only need (arity) number of
FunctionTraits templates, so this is a net win.  For our 6-arity system,
it should go from

  5 types * (1+2+3+4+5+6) InvokerNs  = 105 specializations

to

  5 types * 6 FunctionTraits + 2 calling_syntaxes * (1+2+3+4+5+6) InvokerNs = 72 specializations

This puts a bit more work on the compiler, but...hey, better it than the reader of the code.

BUG=35223
TEST=none

Review URL: http://codereview.chromium.org/6538045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75482 0039d316-1c4b-4281-b951-d872f2087c98

Defend against selectCache() being called multiple times. There is a bug filed upstream to fix the HTML parser such that
it won't generate multiple calls to this, but given the complexity of the parser I'm putting this defense directly in the
appcache system.

BUG=72986,73118
TEST=manually run Poppit

Review URL: http://codereview.chromium.org/6546004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75481 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 1088003ee7026f2b830d2451f79ce772c44a7cea.

BUG=59945, 59946
TEST=trybots
TBR=avi@chromium.org

Original Review: http://codereview.chromium.org/6538053/

Review URL: http://codereview.chromium.org/6532069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75478 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Connect to a host and try moving the mouse and typing. Both inputs should be reflected correctly.

Review URL: http://codereview.chromium.org/6489031
Patch from Jamie Walch <jamiewalch@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75477 0039d316-1c4b-4281-b951-d872f2087c98

Patch by fischman@chromium.org:
http://codereview.chromium.org/6542029/

BUG=69218
TEST=none

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75476 0039d316-1c4b-4281-b951-d872f2087c98

BUG=41543,59732
TEST=Printing works on Linux and CrOS, Linux printing respect print dialog settings.
Review URL: http://codereview.chromium.org/6516022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75475 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6538048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75474 0039d316-1c4b-4281-b951-d872f2087c98

Collect as much GPU information as possible without creating a GL/D3D context.  If based on such partial information, a graphics card/driver is already blacklisted, we shouldn't even try to establish GPU channel.  This gives us the ability to blacklist REALLY BAD graphics card/driver that will crash during GPU info collection.

BUG=72979
TEST=none

Review URL: http://codereview.chromium.org/6531023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75473 0039d316-1c4b-4281-b951-d872f2087c98

Previously tests had to manually call MockFFmpeg::set() during test setup and teardown.  Now that operation is handled automatically via scoping.

BUG=72933
TEST=media_unittests

Review URL: http://codereview.chromium.org/6539021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75472 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: http://codereview.chromium.org/6542019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75471 0039d316-1c4b-4281-b951-d872f2087c98

We can re-inline later if it starts being an issue.

BUG=none
TEST=unit-tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75443

Review URL: http://codereview.chromium.org/6542026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75464 0039d316-1c4b-4281-b951-d872f2087c98

Converted from table-based layout to CSS positioning.

Cleaned up markup and styles.

Fixed some bugs in chrome_sync.js.

This is in preparation for putting the top-level divs in a tabbed view.

BUG=69500
TEST=

Review URL: http://codereview.chromium.org/6538047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75463 0039d316-1c4b-4281-b951-d872f2087c98

BUG=73466
Review URL: http://codereview.chromium.org/6541036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75460 0039d316-1c4b-4281-b951-d872f2087c98

There seemed to be a timing issue on Mac and non-views Linux build that
prevented the button handlers from being properly installed. By always
installing the handlers and basing their behavior on the visibility of the ui
instead, things work on all platforms.

BUG=none
TEST=Start up Mac Chromium with --enable-cloud-print-proxy, go to Under the Hood, and try to start cloud print - with this patch, the sign in UI will start.

Review URL: http://codereview.chromium.org/6541027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75458 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6541014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75457 0039d316-1c4b-4281-b951-d872f2087c98

BUG=59945, 59946
TEST=trybots

Review URL: http://codereview.chromium.org/6538053

TBR=tfarina@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75456 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6542031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75455 0039d316-1c4b-4281-b951-d872f2087c98

Regression was introduced in CL  http://codereview.chromium.org/6334101  

BUG=73353
TEST=None

Review URL: http://codereview.chromium.org/6544020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75454 0039d316-1c4b-4281-b951-d872f2087c98

BUG=59945, 59946
TEST=trybots

Review URL: http://codereview.chromium.org/6538053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75453 0039d316-1c4b-4281-b951-d872f2087c98

Previously tests had to manually call MockFFmpeg::set() during test setup and teardown.  Now that operation is handled automatically via scoping.

BUG=72933
TEST=media_unittests
Review URL: http://codereview.chromium.org/6539021

TBR=scherkus@chromium.org
Review URL: http://codereview.chromium.org/6541037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75448 0039d316-1c4b-4281-b951-d872f2087c98

This avoids abusing a histogram to keep both counts and times (this histogram stores only times) and lets us see the full distribution.

BUG=71256
TEST=

Review URL: http://codereview.chromium.org/6547001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75447 0039d316-1c4b-4281-b951-d872f2087c98

weakserverkey.patch have been upstreamed.  SSL_ERROR_WEAK_SERVER_KEY
has been renamed SSL_ERROR_WEAK_SERVER_EPHEMERAL_DH_KEY.  Pick up
fixes for two bugs:
- https://bugzilla.mozilla.org/show_bug.cgi?id=586697
- https://bugzilla.mozilla.org/show_bug.cgi?id=588698

R=agl
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6487026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75446 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r75443.

TBR=akalin

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75445 0039d316-1c4b-4281-b951-d872f2087c98

Previously tests had to manually call MockFFmpeg::set() during test setup and teardown.  Now that operation is handled automatically via scoping.

BUG=72933
TEST=media_unittests
Review URL: http://codereview.chromium.org/6539021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75444 0039d316-1c4b-4281-b951-d872f2087c98

We can re-inline later if it starts being an issue.

BUG=none
TEST=unit-tests

Review URL: http://codereview.chromium.org/6542026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75443 0039d316-1c4b-4281-b951-d872f2087c98

ChromeDriver. The args parameter should be a ListValue, not a string.
Also, the args parameter is not optional; if no args are
provided in the request, an error should be returned (the handler was
defaulting to an empty list).
Patch by jleyba@chromium.org.
Original review at http://codereview.chromium.org/6544003
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6542025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75442 0039d316-1c4b-4281-b951-d872f2087c98

Log the number of objects in a Pack when it is deleted in debug builds to help JS app developers find leaks.

TEST=used it in a JS app to help identify a leak
BUG=none
Review URL: http://codereview.chromium.org/6542028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75441 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6538060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75439 0039d316-1c4b-4281-b951-d872f2087c98

The AccessLog class was something we added to track down a crash,
which is no longer happening after that change. Reverting piece by
piece and waiting for the next canary build before doing the next
part.

Note that the use of the AccessLog class could have introduced slight
serialization to the method
URLRequestThrottlerManager::RegisterRequestUrl as it would call the
AccessLog::Add method which synchronized on a lock. So removing is not
100% safe; I will watch for crashes in the canary builds after this.

BUG=71721
TEST=none

Review URL: http://codereview.chromium.org/6538061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75438 0039d316-1c4b-4281-b951-d872f2087c98

BUG=73100
TEST=trybots

Review URL: http://codereview.chromium.org/6538008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75434 0039d316-1c4b-4281-b951-d872f2087c98

Creates a new internal page for listing recent reported crashes, to make it easier for users to report crashes, or get crash IDs when asked in bug reports.

Won't yet display any crashes on Windows, since the breakpad side is not yet done on Windows.

BUG=41106
TEST=Visit chrome://crashes; depending on the build type, platform, and metric pref state, it should display crashes or an informative message.

Review URL: http://codereview.chromium.org/6545001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75433 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/73137
TEST=see bug
TBR=sky


Review URL: http://codereview.chromium.org/6525055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75432 0039d316-1c4b-4281-b951-d872f2087c98

This results in some code duplication right now but this will be mitigated once all platforms use WidgetImpl.

http://crbug.com/72040
TEST=existing tests

Review URL: http://codereview.chromium.org/6507028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75431 0039d316-1c4b-4281-b951-d872f2087c98