- 05 Jan, 2021 40 commits
-
-
Adithya Srinivasan authored
This reverts commit 2a2699ae. Reason for revert: Reverting https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2159599 Original change's description: > Portals: Add regression test for console duplication > > Fix was landed in https://crrev.com/c/2159599. > > Bug: 1069487 > Change-Id: I88088ea07b76014e2cdb8c01ca0385f39470de10 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388480 > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Reviewed-by: Simon Zünd <szuend@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804997} TBR=adithyas@chromium.org,szuend@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1069487 Change-Id: I64c27b50153c607925e806540af7f12e1e177f27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595249Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#840148}
-
Alex Ilin authored
Creating a new profile under the force signin enterprise policy should be allowed even if `signInProfileCreationFlowSupported` is false. Bug: 1156096 Change-Id: Ie722cbe6cd186d61ce6672fa717649ba90b15d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597552Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#840147}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e17fd0f0e9bd..7adb896f3ba8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC schwering@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: schwering@google.com Change-Id: If29be127a4b74eebc36c849524828e4b89e68ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606642Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840146}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609821402-1a521f5068c0d6782637fa5e747428dbb99c8286.profdata to chrome-mac-master-1609847937-8a3dc54f6d6b8008f835ccf1ed36d98d27bfc95a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If573644eae7f1f18b6c704882ac44eae48189806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610806Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840145}
-
Alice Wang authored
This CL moves account picker MVC to signin.ui target Bug: 1150324 Change-Id: I5bf79154509797ed3464180a599f1788a0818a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597303 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#840144}
-
Robbie Gibson authored
The text zoom experiment is going on longer than expected, so the flags are still necessary. Fixed: 1159090, 1143362, 1143361 Change-Id: Ibd5f7aed10b774218ee1aebe7e010c7ece5cf2ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598847Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#840143}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609821402-4ffa353dbb439d0e8adf0e53cbe86a4c4b758321.profdata to chrome-linux-master-1609847937-af9ee8d51bc6a0aba5c9a2202bd2fb2e3011ef58.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie7e66a9e8bdd114b85648a002639fc056d54b3f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609882Reviewed-by:
-
Xida Chen authored
I believe that these layout tests were fixed by this CL: https://chromium-review.googlesource.com/c/chromium/src/+/2579949 Now there is only one test that needs investigation. Bug: 1150468 Change-Id: I4ea59de2068fa13890a4578450ec061c28b40cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605482Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#840141}
-
Eric Willigers authored
NavigatorSocket is a ExecutionContextLifecycleStateObserver, and thus UpdateStateIfNeeded() should be called after a NavigatorSocket is constructed. Without this call, a check fails during NavigatorSocket destruction. We also add a test for closing a TCP socket. Bug: 905818 Change-Id: Ib272e0630699ab50b3863aed740e310735862ab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610408Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#840140}
-
Alice Wang authored
This CL cleans up the ProfileDataSource#getProfileDataMap usage, as this method is not needed when we migrate to OneGoogle source for profile data. Bug: 1136452 Change-Id: I5fe3c13f478786a4b92755eaa989756035a80965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602426 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#840139}
-
Mirko Bonadei authored
The usrsctp library has a mechanism to enforce invariants (similar to CHECK or RTC_CHECK). In order to enable these checks, the macro INVARIANTS needs to be defined on all the usrsctp translation units. Maybe, this macro should be renamed into USRSCTP_ENABLE_CHECKS or at least into something with USRSCTP_ as prefix. This CL enables these runtime checks in debug builds and when the build is explicitly asking for them (dcheck_always_on=true). Bug: None Change-Id: Id63d78200ae2a762b86a4dc0c70d1a04e7d94350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600903Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#840138}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609821402-aadb54447d521b648e35bdaecfd53290f25cbd03.profdata to chrome-win64-master-1609837154-ace0713e1aa3951abed358afe7726a9f9d3a73a1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I92ee2c4f37327c54f853fa89f0eaa31695f6f902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606001Reviewed-by:
-
Mihai Sardarescu authored
UrlKeyedAnonymizedDataCollectionEnabled is enabled by the sync consent UI when the user opts in to sync. The tests rules should mirror this behavior and only enable sync when the sync is enabled (and not when sign-in is enabled). This CL removes enabling URL-keyed anonymized data collection on sign-in. Bug: None. Change-Id: I7cf437874d97359d033e71d17122daf8d927c59b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598903 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Reviewed-by:
-
Clemens Arbesser authored
Bug: b/173104767 Change-Id: Id500736a6c130a6f81368080980d1dffe9a1bf93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610096 Auto-Submit: Clemens Arbesser <arbesser@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#840135}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/bc804095bcad..ee8ca5255488 2021-01-05 primiano@google.com Merge "Update CHANGELOG for v11.0" 2021-01-05 treehugger-gerrit@google.com Merge "Minimal edits to heap_profile.h comments" 2021-01-05 fmayer@google.com Merge "Enable new clang-tidy checks & resolve for src/profiling." 2021-01-05 fmayer@google.com Merge changes I174d77b5,I114d9aa1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia68950e961fa95d0944e44cc852cd3686857ced7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609876Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/53386e30..3abec731 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I65faeedf3db0b60791cf2aba807f1f4310f3cee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610470Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840133}
-
arthursonzogni authored
Make sure sandbox flags are properly inherited when the initiator of the navigation isn't the parent. This checks both sandbox flags defined by the frame and by the HTTP response. Bug: 1041376 Change-Id: I3c0b808ef9ec3ebefde40ec7609a36a1f5edaf6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607790Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#840132}
-
dpapad authored
This is necessary so that up/down arrow keys trigger scrolling of the PDF document after exiting Presentation mode. Bug: 1148478 Change-Id: Ie64d1e3deb5763a43ef4dc7f094065992b5eb4c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597770 Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#840131}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a46fbf8fc541..90b6613019de 2021-01-05 jacktfranklin@chromium.org Reland "Add header context menu to data grid" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1150793 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia2900946e70b59db31b33a14691368911cb41a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606002Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I925d2ffca8985c2f0177f9d0af63466c48cab0db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610686Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#840129}
-
Mihai Sardarescu authored
It is not totally clear why the IdentityManager needs to update the account info for the primary account (the CoreAccountInfo is not expected to be updated when new user info is fetched by the AccountFetcherService). Nonetheless, it does not make much sense to only update this information for the sync account (the account info of the non sync account is fetched using the same logic the one for the sync account). This CL updates this information for the non-sync primary account as well. Bug: None Change-Id: Id67845cf4ee3cd3c5cd577f2d82341989d5d320e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602417 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#840128}
-
Jan Krcal authored
This CL adds another bucket in the histogram for signed-in profile creation flow (and renames the local bucket accordingly). The CL also updates naming for other buckets to be up to date with the current terminology. Bug: 1126913 Change-Id: I6423a6a64a601869e04da4f42c55a577a534113f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610598 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#840127}
-
Ramin Halavati authored
When ephemeral Guest profiles are enabled and a Guest browser is not opened, adds an option to sign-in intercept to open the new profile in a Guest browser. Screenshot: https://screenshot.googleplex.com/58aNLULBpJzdBa7.png Bug: 1157764 Change-Id: Ifdf5ec9f7050051e73b7989973790e96e0c03af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587062 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
-
Antonio Gomes authored
The way the logic is currently implemented prevents the delegate from being notified of state changes most of the time. This CL relaxes the sanity checks in WaylandToplevelWindow::HandleSurfaceConfigure(), causing DesktopWTHPlatform::OnWindowStateChanged() to get called more frequently, but holding now the correct state. This will allow DesktopWTHPlatform to react on state changes more reliably (eg lacros' immersive fullscreen behavior). Last, this CL changes the logic that sets and unsets fullscreen. Previously, UnSetFullscreen() was being called for all operations different than "enter fullscreen". This is needless and might mess compositors up. TEST=ozone_unittests adapted accordingly. BUG=1113900 R=msisov@igalia.com, nickdiego@igalia.com Change-Id: Iddffaf5d4f0e20898db0016320935904b9816e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601219 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#840125}
-
Viktor Semeniuk authored
This features allows obtaining Change Password URLs from the Affiliation Service. Also UseOfHashAffiliationFetcher enables usage of Affiliation Service for non-synced uses. Bug: 1154587 Change-Id: Ieab7624bf99ab645d33096b691b191b87e6fb71f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567391 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1609735837-0def2c604407494fb27ba623dbaed3c908ff2f3e.profdata to chrome-win32-master-1609821402-6004c61fe423c51f3b6973d79ebe11baae0b7161.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3e57816d260ea45c394c4bf150a1a9627606c45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609874Reviewed-by:
-
Vidhan Jain authored
This CL adds an input field for the honorific prefixes above the "Full Name" field, accessible from the Autofill Settings View. The field is visible only when the kAutofillEnableUIForHonorificPrefixesInSettings feature is enabled. The entered value will not be saved, because honorifics are temporarily disabled (crbug/1113617). Screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/aa5e881149c5eb8c425711c2f3cabad33a45c35e?authuser=0 Bug: 1141884 Change-Id: I353d3b65b96e3960bbf950455da049e0292477a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594749Reviewed-by:
Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Vidhan Jain <vidhanj@google.com> Cr-Commit-Position: refs/heads/master@{#840122}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fc1733482433..84cad4eea312 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7ef126e8468aafb94e2ab87d7fd60270170dab9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610246Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/026a067c38ef..07dea8371353 2021-01-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 094b96f7 to b5dfde1f (71 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I445458201fa0b9fb0621a31ac8074ca3b9308b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609872Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/84cad4eea312..bc804095bcad 2021-01-05 fmayer@google.com Merge "Move deobfuscate.h out of include." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib84ae7010a3226a03f031c84795b371687456b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606000Reviewed-by:
-
Robbie Gibson authored
Bug: 1094335 Change-Id: I81d6af8ae338f1ca2ee792dd9cdc7aa153228a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610094Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#840118}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fc1733482433..84cad4eea312 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I71363083228b6c60a80facdd61f7b630f84eb6ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608641Reviewed-by:
-
Rushan Suleymanov authored
Bug: 948661 Change-Id: Iee4c52a1523df9dfa36e4ef50cf3fa5dfd7ec4e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607304Reviewed-by:
Victor Vianna (OOO 21/12-05/01) <victorvianna@google.com> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#840116}
-
Stepan Khapugin authored
On a device with a biometric sensor which is disabled, LAContext's biometryType will be set to the type of the sensor, even if it's not set up. Check the error instead to see when a fallback to Passcode is required. Fixed: 1161175 Change-Id: I3db27208e46cd6aa11cf802e90086c1c040dc330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601356 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#840115}
-
Findit authored
This reverts commit 29ff7965. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 840082 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzI5ZmY3OTY1MmQ0YTRmMDIxNzc5ZjBlNGIyNDdkNTNiMjgxMDQzZGYM Sample Failed Build: https://ci.chromium.org/b/8858949956473740752 Sample Failed Step: ui_base_unittests Original change's description: > ime: Handle InsertTextCursorBehavior in InputMethodChromeOS. > > TextInputClients now support moving the cursor after committing some > text. This patch adds support for input engines to call the new API. > > There is a slight complication with multiple CommitText calls during > key event handling. Previously, when handling a key event, any calls > to CommitText will be coalesced together and executed once the key > event is handled. However, this coalescing logic doesn't handle > cursor movement. > > Add logic to handle cursor movement when coalescing commits by observing that > any sequence of CommitTexts with cursor movement can be implemented with two > separate CommitTexts. Note that this is a no-op change if the IME never uses > the new cursor movement parameter. > > Bug: 1155331 > Change-Id: I6c89ec1cde5624eca7bf0d5c803085f7d7803c71 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576067 > Reviewed-by: Keith Lee <keithlee@chromium.org> > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Commit-Queue: Darren Shen <shend@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840082} Change-Id: If06b84f85826520e8a65ebf908eba18ff7bd2428 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1155331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607068 Cr-Commit-Position: refs/heads/master@{#840114}
-
Tanmoy Mollik authored
This cl imports PrimaryAccountChangeEvent from c++ code to java code. Following cls will refactor IdentityManager.Observer.(onPrimaryAccountSet /Cleared) methods to onPrimaryAccountChanged method. That way signin code will be more consistent across all platforms. Bug: 1158855 Change-Id: I2c65e81a369540a9eadf85a9d1ba4c0c716853a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603747 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
-
Stepan Khapugin authored
Fixes the bug which was caused by a mistake in a refactoring. Add a test to prevent regression. Fixed: 1151035 Change-Id: I9f3d00cfdd13321dd289a9944e155c76bc8b6524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600821 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
-
Alice Wang authored
This CL adds a set of JUnit tests for the class ProfileDownloader. Bug: 1161437 Change-Id: Iead7068b730b5ca6c62b7edb8bf893aa7457e60e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607108 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
-
Stefan Zager authored
Instead, set contents_opaque directly on the cc::Layer. This makes it more straightforward to migrate the logic to PaintArtifactCompositor. Bug: 1069546 Change-Id: Ifa338b89bb2636b257b34e67e51c7a300c9e5754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607668 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#840110}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609735837-54f15795beeae1e22004c8135cf818a537813adc.profdata to chrome-win64-master-1609821402-aadb54447d521b648e35bdaecfd53290f25cbd03.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibcbe9d799408b988b991977b25cca9783c1e591f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608787Reviewed-by:
-
