1. 30 Oct, 2014 40 commits
    • kundaji's avatar
      Handle disabling data reduction proxy for all platforms. · ef948c02
      kundaji authored
      Disable data reduction proxy by deleting user level proxy prefs only if
      the proxy is known to be a data_reduction_proxy. Remove duplicate
      implementation in off_the_record_profile_impl.cc.
      
      BUG=426220
      
      Review URL: https://codereview.chromium.org/669163003
      
      Cr-Commit-Position: refs/heads/master@{#302156}
      ef948c02
    • kundaji's avatar
      Whitelist data savings prefs for the reduction proxy. · 3dc96085
      kundaji authored
      BUG=411543
      
      Review URL: https://codereview.chromium.org/691123002
      
      Cr-Commit-Position: refs/heads/master@{#302155}
      3dc96085
    • kjoswiak's avatar
      ffmpeg reset bitstream converters on Seek · 562c4aca
      kjoswiak authored
      We should not assume that the underlying decoders
      keep their state after a Seek.
      So for example, the SPS/PPS should be added again.
      
      BUG=140371
      
      Review URL: https://codereview.chromium.org/683573002
      
      Cr-Commit-Position: refs/heads/master@{#302154}
      562c4aca
    • morrita's avatar
      Blink roll f05984fee3be37b9e401b635885c67161aaaf123:20feb3edc199015a96b39c081d50a083cf39ac87 · 8908855a
      morrita authored
      TBR=vsevik
      BUG=
      
      Review URL: https://codereview.chromium.org/690553004
      
      Cr-Commit-Position: refs/heads/master@{#302153}
      8908855a
    • rouslan's avatar
      Add rouslan@ to OWNERS for Android password generation UI. · 86f88fe5
      rouslan authored
      BUG=412150
      
      Review URL: https://codereview.chromium.org/691883002
      
      Cr-Commit-Position: refs/heads/master@{#302152}
      86f88fe5
    • dmichael's avatar
      Revert of Windows video capture: Remove duplicated code from... · ceeb175a
      dmichael authored
      Revert of Windows video capture: Remove duplicated code from GetDeviceSupportedFormats* (patchset #3 id:200001 of https://codereview.chromium.org/558503003/)
      
      Reason for revert:
      See https://code.google.com/p/chromium/issues/detail?id=428958
      
      Original issue's description:
      > Windows video capture: Remove duplicated code from GetDeviceSupportedFormats*
      >
      > The code for GetDeviceSupportedFormatsMediaFoundation and GetDeviceSupportedFormatsDirectShow are already implemented in video_capture_device_mf_win.cc and video_capture_device_win.cc respectively. This CL refactors the implementation so that video_capture_device_factory_win.cc can make use of that code.
      >
      > Committed: https://crrev.com/b6dae80f8f10b8af1e3026de9f5af4f3128e812a
      > Cr-Commit-Position: refs/heads/master@{#301891}
      
      TBR=mcasas@chromium.org,perkj@chromium.org,tommi@chromium.org,magjed@chromium.org
      NOTREECHECKS=true
      NOTRY=true
      
      Review URL: https://codereview.chromium.org/691143002
      
      Cr-Commit-Position: refs/heads/master@{#302151}
      ceeb175a
    • jeremyim's avatar
      Make the proxy server HostPortPair available in document_state so that · ac77ecc7
      jeremyim authored
      we can determine whether the data_reduction_proxy was used or not for
      PLT UMA.
      
      BUG=374264
      
      Review URL: https://codereview.chromium.org/686313002
      
      Cr-Commit-Position: refs/heads/master@{#302150}
      ac77ecc7
    • reveman's avatar
      cc: Remove empty viewport check in GLRenderer::BeginDrawingFrame. · 8b8f3285
      reveman authored
      It's now up to the caller to avoid calls to
      ::Begin/FinishDrawingFrame when it makes sense to do so.
      
      BUG=428071
      R=danakj
      
      Review URL: https://codereview.chromium.org/678113004
      
      Cr-Commit-Position: refs/heads/master@{#302149}
      8b8f3285
    • mohsen's avatar
      Expand quick menu buttons to fit their content · 3f88ee90
      mohsen authored
      Currently, touch selection quick menu buttons have the fixed size of
      63x38. In some languages, texts need more space; so those buttons should
      be expanded to fit the whole text.
      
      BUG=417254
      
      Review URL: https://codereview.chromium.org/693583002
      
      Cr-Commit-Position: refs/heads/master@{#302148}
      3f88ee90
    • vadimt's avatar
      Adding instrumentation to locate the source of jankiness. · 76e9fa8f
      vadimt authored
      Previous instrumentations showed that TemplateURLService::ChangeToLoadedState
      alone is responsible for 2.74 janks per hour in UI thread in Win (8.15 on Mac). I need to instrument
      the code inside it to find out which part causes jank.
      
      This is a mechanical change that adds instrumentation required to locate the
      source of jankiness (i.e. a long-running fragment of code executed as a part of
      the task that causes jank) in the code. See the bug for details on what kind of
      jank we are after.
      A number of similar CLs were landed, and none of them caused issues. They've
      helped to find and fix janky code. The code of the instrumentation is highly
      optimized and is not expected to affect performance. The code simply creates a
      diagnostic task which is identical to ones created by PostTask or IPC message
      handlers.
      
      BUG=422460
      
      Review URL: https://codereview.chromium.org/684333002
      
      Cr-Commit-Position: refs/heads/master@{#302147}
      76e9fa8f
    • ajith.v's avatar
      Optimizing DateTimeAndroid and ColorChooserAndroid initializations. · 9e47ab57
      ajith.v authored
      Some of the functions are direct wrapper to WebContents methods. In this
      patch, taken care of removing those dependencies and added extra validation to prevent run time crashes.
      
      BUG=398263
      
      Review URL: https://codereview.chromium.org/639703004
      
      Cr-Commit-Position: refs/heads/master@{#302146}
      9e47ab57
    • skia-deps-roller's avatar
      Roll src/third_party/skia 6500760:058f01e · d3574dfb
      skia-deps-roller authored
      Summary of changes available at:
      https://chromium.googlesource.com/skia/+log/6500760..058f01e
      
      CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
      TBR=hcm@google.com
      
      Review URL: https://codereview.chromium.org/680833004
      
      Cr-Commit-Position: refs/heads/master@{#302145}
      d3574dfb
    • estade's avatar
      Autofill - Nordstroms test case. · 414c1eff
      estade authored
      TBR=isherman@chromium.org
      BUG=428892
      
      Review URL: https://codereview.chromium.org/682223005
      
      Cr-Commit-Position: refs/heads/master@{#302144}
      414c1eff
    • csharp's avatar
      Revert of Allow POSIX callers to specify a new file's mode. (patchset #1 id:1... · 8db8e88e
      csharp authored
      Revert of Allow POSIX callers to specify a new file's mode. (patchset #1 id:1 of https://codereview.chromium.org/689713006/)
      
      Reason for revert:
      This seems to have broken the Linux MSan test bot.
      
      [ RUN      ] FileUtilTest.WriteFileWithMode
      ../../base/files/file_util_unittest.cc:2164: Failure
      Value of: status.st_mode & 0777
        Actual: 384
      Expected: mode
      Which is: 420
      [  FAILED  ] FileUtilTest.WriteFileWithMode (1 ms)
      
      Original issue's description:
      > Allow POSIX callers to specify a new file's mode.
      >
      > Retain the tight 0640 mode for most existing callers, but honor the user's
      > umask for downloaded files.
      >
      > This is a re-land of https://codereview.chromium.org/639253004/.
      >
      > BUG=409416, 362887
      > TBR=asanka,mdempsky,rvargas
      >
      > Committed: https://crrev.com/931e35070097af9837f79ff19f8668e45b92ed3a
      > Cr-Commit-Position: refs/heads/master@{#302113}
      
      TBR=palmer@chromium.org
      NOTREECHECKS=true
      NOTRY=true
      BUG=409416, 362887
      
      Review URL: https://codereview.chromium.org/693493004
      
      Cr-Commit-Position: refs/heads/master@{#302143}
      8db8e88e
    • stevenjb's avatar
      Move network_connect code to ui/chromeos/network (Take 2) · d0502304
      stevenjb authored
      Original CL: Review URL: https://codereview.chromium.org/686503002
      
      BUG=425996
      TBR=oshima, sadrul, tbarzic
      
      Review URL: https://codereview.chromium.org/690943003
      
      Cr-Commit-Position: refs/heads/master@{#302142}
      d0502304
    • vadimgo's avatar
      Enable passing cast channel certificate authority keys. · df6b610e
      vadimgo authored
      BUG=417090
      
      Review URL: https://codereview.chromium.org/627573002
      
      Cr-Commit-Position: refs/heads/master@{#302141}
      df6b610e
    • vadimt's avatar
      Instrumenting AccountTracker::StartFetchingUserInfo to locate the source of jankiness. · e924411b
      vadimt authored
      Method AccountTracker::StartFetchingUserInfo is executed in browser's UI thread, and it causes jank.
      In Canary 40.0.2201.2 on Win, 19.9 jph is caused by AccountTracker::StartFetchingUserInfo,
      which average execution time in UI thread is 227 ms. On Mac, we have 17.7 jph and 71.1ms avg. I need to instrument
      the code inside it to find out which part causes jank.
      
      This is a mechanical change that adds instrumentation required to locate the
      source of jankiness (i.e. a long-running fragment of code executed as a part of
      the task that causes jank) in the code. See the bug for details on what kind of
      jank we are after.
      A number of similar CLs were landed, and none of them caused issues. They've
      helped to find and fix janky code. The code of the instrumentation is highly
      optimized and is not expected to affect performance. The code simply creates a
      diagnostic task which is identical to ones created by PostTask or IPC message
      handlers. The task gets created only in developer build and in Canary channel.
      
      BUG=422460
      
      Review URL: https://codereview.chromium.org/690073002
      
      Cr-Commit-Position: refs/heads/master@{#302140}
      e924411b
    • qyearsley's avatar
      Update style according to advice from pylint. · 0f7acf8e
      qyearsley authored
      BUG=
      
      Review URL: https://codereview.chromium.org/681103002
      
      Cr-Commit-Position: refs/heads/master@{#302139}
      0f7acf8e
    • newt's avatar
      Clearer error message when parsing Android XML resource fails. · fcd9c476
      newt authored
      Previously, when generate_v14_compatible_resources.py encountered an
      invalid XML file, it showed an error message that didn't tell which
      file it was processing. E.g.:
      
        Traceback (most recent call last):
          ...
          File "/usr/lib/python2.7/xml/dom/expatbuilder.py", line 207, in parseFile
            parser.Parse(buffer, 0)
        ExpatError: unbound prefix: line 6, column 0
      
      Now it also prints the name of the file that couldn't be parsed. E.g.
      
        Traceback (most recent call last):
          ...
          File "/usr/lib/python2.7/xml/dom/expatbuilder.py", line 207, in parseFile
            parser.Parse(buffer, 0)
        ExpatError: unbound prefix: line 6, column 0
        Failed to parse XML file: chrome/android/res/layout/my_layout.xml
      
      Review URL: https://codereview.chromium.org/661433005
      
      Cr-Commit-Position: refs/heads/master@{#302138}
      fcd9c476
    • mlerman's avatar
      Null checks to prevent occasional crash · 0794ea8d
      mlerman authored
      BUG=423229
      
      Review URL: https://codereview.chromium.org/686803003
      
      Cr-Commit-Position: refs/heads/master@{#302137}
      0794ea8d
    • finnur's avatar
      Add default allowed value of Ask for Push Notifications. · 6a641416
      finnur authored
      Push Notifications not only support Ask already, it is the default value, so this should match that reality.
      
      BUG=425698
      
      Review URL: https://codereview.chromium.org/689993002
      
      Cr-Commit-Position: refs/heads/master@{#302136}
      6a641416
    • dnicoara's avatar
      Refactor TouchTransformerConverter to allow support for Ozone · 8c3bd1e6
      dnicoara authored
      In Ozone the touch events are received in device coordinates. This
      change consolidates the different transformations into one function and
      makes it use the touchscreen size when computing the transformation for
      Ozone and the framebuffer size for X11.
      
      BUG=425258
      TESTS=Manually verified that X11 in single, mirror, extended and docked
      mode work with external touchscreen.
      
      Review URL: https://codereview.chromium.org/688183002
      
      Cr-Commit-Position: refs/heads/master@{#302135}
      8c3bd1e6
    • morrita's avatar
      Blink roll eacac493536b3feb666da91ef21b9072a6d2f5a1:f05984fee3be37b9e401b635885c67161aaaf123 · 636e0eb3
      morrita authored
      TBR=yurys
      BUG=
      
      Review URL: https://codereview.chromium.org/686643003
      
      Cr-Commit-Position: refs/heads/master@{#302134}
      636e0eb3
    • Chris Sharp's avatar
      Revert "Implement a JavaScript API for document scanning" · d3934451
      Chris Sharp authored
      This reverts commit ea73a785.
      
      TBR=pstew@chromium.org
      BUG=
      
      Review URL: https://codereview.chromium.org/655833007
      
      Cr-Commit-Position: refs/heads/master@{#302133}
      d3934451
    • thakis's avatar
      Add a few missing overrides found by a new clang warning. · be4d5882
      thakis authored
      Namely, -Winconsistent-missing-override. No behavior change.
      
      BUG=428099
      
      Review URL: https://codereview.chromium.org/687453006
      
      Cr-Commit-Position: refs/heads/master@{#302132}
      be4d5882
    • dmazzoni's avatar
      Hide focus ring when ChromeVox is unloaded. · fb33d59f
      dmazzoni authored
      BUG=421422
      
      Review URL: https://codereview.chromium.org/685403004
      
      Cr-Commit-Position: refs/heads/master@{#302131}
      fb33d59f
    • kbr's avatar
      Revert of Add Search Service in Enhanced Bookmark Bridge (patchset #6... · 1491f336
      kbr authored
      Revert of Add Search Service in Enhanced Bookmark Bridge (patchset #6 id:100001 of https://codereview.chromium.org/637323005/)
      
      Reason for revert:
      Broke compilation in http://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%207%29/builds/14002
      
      Original issue's description:
      > Add Search Service in Enhanced Bookmark Bridge
      >
      > A Search client is created during initialization of
      > EnhancedBookmarkBridge. And when the bridge destructs, search service is
      > also destroyed.
      >
      > BUG=415774
      >
      > Committed: https://crrev.com/e52346f194e9f2d097b4f6d3fbfa359eca7c92df
      > Cr-Commit-Position: refs/heads/master@{#302107}
      
      TBR=tedchoc@chromium.org,danduong@chromium.org,kkimlabs@chromium.org,noyau@chromium.org,lpromero@chromium.org,ianwen@chromium.org
      NOTREECHECKS=true
      NOTRY=true
      BUG=415774
      
      Review URL: https://codereview.chromium.org/688883002
      
      Cr-Commit-Position: refs/heads/master@{#302130}
      1491f336
    • oetuaho's avatar
      Update command buffer autogenerated files · 759a8354
      oetuaho authored
      This is needed to make more enums work with GlEnumToString, particularly
      CONTEXT_LOST_KHR.
      
      BUG=428332
      
      Review URL: https://codereview.chromium.org/690753005
      
      Cr-Commit-Position: refs/heads/master@{#302129}
      759a8354
    • kbr's avatar
      Revert of Wait 60s instead of 30s for browser to launch. (patchset #1 id:1 of... · c598228e
      kbr authored
      Revert of Wait 60s instead of 30s for browser to launch. (patchset #1 id:1 of https://codereview.chromium.org/691683002/)
      
      Reason for revert:
      Didn't help -- stuck subprocesses are still showing up.
      
      Original issue's description:
      > Wait 60s instead of 30s for browser to launch.
      >
      > There's a guess that the browser may be launching extremely slowly on
      > some bots and that when the browser main process is killed it's
      > leaking sub-processes that are in the middle of being spawned.
      > Increase the timeout to try to confirm this hypothesis.
      >
      > BUG=424024
      > R=tonyg@chromium.org
      >
      > Committed: https://crrev.com/7ef2c0036f70bdcc59dd7c8f23c8b7c5a3f114d9
      > Cr-Commit-Position: refs/heads/master@{#302087}
      
      TBR=tonyg@chromium.org,nednguyen@google.com
      NOTREECHECKS=true
      NOTRY=true
      BUG=424024
      
      Review URL: https://codereview.chromium.org/667733004
      
      Cr-Commit-Position: refs/heads/master@{#302128}
      c598228e
    • Ben Smith's avatar
      [NaCl SDK Docs] Fix many issues with the doc generator. · 7fba1592
      Ben Smith authored
      * It was broken after the git switch (it used SVN internally)
      * Generate Pepper indexes to
        c-api-{channel} instead of pepper_{channel}/c
      
      This relies on using Doxygen 1.7.6.1, which was installed by default on Lucid. Doxygen 1.8 does not work, and maybe never will.
      
      You can set the DOXYGEN environment variable to point to a good version of doxygen.
      
      No trybots because it is a documentation generation only change. I tested locally to ensure this wouldn't break stuff.
      
      BUG=none
      TEST=local
      NOTRY=true
      R=sbc@chromium.org
      
      Review URL: https://codereview.chromium.org/591683002
      
      Cr-Commit-Position: refs/heads/master@{#302127}
      7fba1592
    • nasko's avatar
      Convert tests to use GetURL(host, path) instead of redirector. · 30374c75
      nasko authored
      As discovered by japhet@, if we navigate cross-site in a browser test using the '/cross-site/' redirector syntax, the initial URL is relative to the embedded_test_server, which happens to also be the SiteInstance of the top-level page. This causes an extra process swap, which is unnecessary and can create unexpected effects in the test. I've added GetURL(hostname, path) method to EmbeddedTestServer to give us the proper URL directly without following a redirect path and this CL updates the tests to use this new method.
      
      BUG=418236
      
      Review URL: https://codereview.chromium.org/688363002
      
      Cr-Commit-Position: refs/heads/master@{#302126}
      30374c75
    • dongseong.hwang's avatar
      cc: check valid thread and resource origin for the resource rasterized. · 0eb995b9
      dongseong.hwang authored
      Review URL: https://codereview.chromium.org/690713002
      
      Cr-Commit-Position: refs/heads/master@{#302125}
      0eb995b9
    • georgesak's avatar
      Added UMA statistics for Chrome Cleaner. · d09466de
      georgesak authored
      BUG=425601
      
      Review URL: https://codereview.chromium.org/660563004
      
      Cr-Commit-Position: refs/heads/master@{#302124}
      d09466de
    • dbeam's avatar
      Make bookmark manager load tests work again. · af99b7dc
      dbeam authored
      Also just update some closure URLs.
      
      R=arv@chromium.org
      TBR=xians@chromium.org,zmo@chromium.org
      BUG=none
      
      Review URL: https://codereview.chromium.org/681303005
      
      Cr-Commit-Position: refs/heads/master@{#302123}
      af99b7dc
    • pstew's avatar
      Implement a JavaScript API for document scanning · ea73a785
      pstew authored
      Provide an API for callers to list available document scanners,
      and to acquire a single-page scan from one such device.  This
      currently takes advantage of the lorgnette scanning API in
      ChromeOS but can be extended to use native document acquisition
      APIs on other platforms.
      
      BUG=375334
      
      R=asargent@chromium.org, mef@chromium.org, asvitkine@chromium.org
      
      Review URL: https://codereview.chromium.org/286933006
      
      Cr-Commit-Position: refs/heads/master@{#302122}
      ea73a785
    • nednguyen's avatar
      [Telemetry] page_runner refactoring. · 2243a225
      nednguyen authored
      Move all the logic of handling wpr_mode into 1 place. This
      also update page_runner_unittest.TestUseLiveSiteFlag to
      assert the wpr_mode of network_controller instead of the browser_options.
      
      BUG=418278
      
      Review URL: https://codereview.chromium.org/671873003
      
      Cr-Commit-Position: refs/heads/master@{#302121}
      2243a225
    • bajones's avatar
      Rolling WebGL conformance test from 34ac01c7 to e10cfa45 · bcf556a7
      bajones authored
      BUG=386048
      NOTRY=true
      
      Review URL: https://codereview.chromium.org/694563002
      
      Cr-Commit-Position: refs/heads/master@{#302120}
      bcf556a7
    • lgenevet's avatar
      Make OnDeviceEvent and OnDispatcherListChanged protected to allow overload. · 59b25316
      lgenevet authored
      Only one event factory can exist. Make OnDeviceEvent/ OnDispatcherListChanged
      protected will allow to overload this implementation to add specific behaviour
      to the evdev input devices one.
      Add lgenevet@cisco.com in authors.
      
      Review URL: https://codereview.chromium.org/689933004
      
      Cr-Commit-Position: refs/heads/master@{#302119}
      59b25316
    • csharp's avatar
      Revert of Reduce frequency of requesting bookmark clusters. (patchset #8... · 8077169f
      csharp authored
      Revert of Reduce frequency of requesting bookmark clusters. (patchset #8 id:140001 of https://codereview.chromium.org/682933002/)
      
      Reason for revert:
      This appears to have broken Chromium Linux on Android Arm64 Builder (dbg).
      
      FAILED: /mnt/data/b/build/goma/gomacc /mnt/data/b/build/slave/Android_Arm64_Builder__dbg_/build/src/third_party/android_tools/ndk//toolchains/aarch64-linux-android-4.9/prebuilt/linux-x86_64/bin/aarch64-linux-android-g++ -MMD -MF obj/chrome/browser/android/enhanced_bookmarks/browser.enhanced_bookmarks_bridge.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC -DDISABLE_NACL -DCHROMIUM_BUILD -DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1 -DUSE_PROPRIETARY_CODECS -DENABLE_BROWSER_CDMS -DENABLE_CONFIGURATION_POLICY -DDISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY -DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DENABLE_AUTOFILL_DIALOG=1 -DCLD_VERSION=1 -DENABLE_PRINTING=1 -DENABLE_MANAGED_USERS=1 -DVIDEO_HOLE=1 -DENABLE_LOAD_COMPLETION_HACKS=1 -DNACL_WINDOWS=0 -DNACL_LINUX=1 -DNACL_OSX=0 -DNACL_ANDROID=1 -DFULL_SAFE_BROWSING -DMOJO_USE_SYSTEM_IMPL -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DAUTOFILL_ENABLE_SYNC -DPASSWORD_MANAGER_ENABLE_SYNC '-DPRECACHE_CONFIG_SETTINGS_URL="https://www.gstatic.com/chrome/wifiprefetch/precache_config"' '-DPRECACHE_MANIFEST_URL_PREFIX="https://www.gstatic.com/chrome/wifiprefetch/precache_manifest_"' -DAPPCACHE_USE_SIMPLE_CACHE -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1 -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT -DSK_FM_NEW_MATCH_FAMILY_STYLE_CHARACTER=1 -DSK_SUPPORT_LEGACY_TEXTRENDERMODE -DSK_LEGACY_NO_DISTANCE_FIELD_PATHS -DSK_BUILD_FOR_ANDROID -DSK_USE_POSIX_THREADS -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DANDROID -DPOSIX -DWEBRTC_POSIX -DLIBXML_STATIC -DPOSIX_AVOID_MMAP -DMEDIA_DISABLE_LIBVPX -DXML_STATIC -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_LINUX -DWEBRTC_ANDROID -DWEBRTC_ANDROID_OPENSLES -DMESA_EGL_NO_X11_HEADERS -DUSE_OPENSSL=1 -DUSE_OPENSSL_CERTS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__GNU_SOURCE=1 -DUSE_STLPORT=1 -D_STLP_USE_PTR_SPECIALIZATIONS=1 '-DCHROME_BUILD_ID=""' -DHAVE_SYS_UIO_H -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -Igen -I../.. -Iobj/chrome/browser.gen -I../../third_party/khronos -I../../gpu -I../../skia/config -I../../third_party/WebKit/Source -Igen/angle -Igen/protoc_out -I../../third_party/protobuf -I../../third_party/protobuf/src -I../../third_party/dom_distiller_js/package/proto_gen -Igen/chrome -Igen/components/strings -I../../third_party/WebKit -I../../third_party/skia/src/core -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../skia/ext -I../../third_party/cacheinvalidation/overrides -I../../third_party/cacheinvalidation/src -I../../third_party/cacheinvalidation/google/cacheinvalidation -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/webrtc/overrides -I../../third_party/libjingle/overrides -I../../third_party/libjingle/source -I../../testing/gtest/include -I../../third_party -I../../third_party/libxml/linux/include -I../../third_party/libxml/src/include -I../../third_party/zlib -Igen/ui/resources -I../../third_party/re2 -Igen/content/app/resources/ -I../../third_party/expat/files/lib -I../../third_party/leveldatabase/src/include -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase -I../../third_party/libyuv/include -I../../third_party/libyuv -I../../third_party/npapi -I../../third_party/npapi/bindings -Igen/ui/gl -I../../third_party/mesa/src/include -I../../v8/include -Igen/policy --param=ssp-buffer-size=4 -Werror -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wno-unused-local-typedefs -ffunction-sections -funwind-tables -g -fno-short-enums -finline-limit=64 -Wa,--noexecstack --sysroot=/mnt/data/b/build/slave/Android_Arm64_Builder__dbg_/build/src/third_party/android_tools/ndk//platforms/android-21/arch-arm64 -isystem/mnt/data/b/build/slave/Android_Arm64_Builder__dbg_/build/src/third_party/android_tools/ndk//sources/cxx-stl/stlport/stlport -Os -g -gdwarf-4 -fdata-sections -ffunction-sections -funwind-tables -g1 -fno-exceptions -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -std=gnu++11 -Wno-narrowing -Wno-literal-suffix  -c ../../chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc -o obj/chrome/browser/android/enhanced_bookmarks/browser.enhanced_bookmarks_bridge.o
      ../../chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc: In constructor 'enhanced_bookmarks::android::EnhancedBookmarksBridge::EnhancedBookmarksBridge(JNIEnv*, jobject, Profile*)':
      ../../chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc:52:67:error: invalid new-expression of abstract class type 'enhanced_bookmarks::BookmarkServerSearchService'
             EnhancedBookmarkModelFactory::GetForBrowserContext(profile_)));
                                                                         ^
      In file included from ../../chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h:12:0,
                       from ../../chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc:5:
      ../../components/enhanced_bookmarks/bookmark_server_search_service.h:21:7: note:   because the following virtual functions are pure within 'enhanced_bookmarks::BookmarkServerSearchService':
       class BookmarkServerSearchService : public BookmarkServerService {
             ^
      In file included from ../../components/enhanced_bookmarks/bookmark_server_service.h:11:0,
                       from ../../components/enhanced_bookmarks/bookmark_server_search_service.h:12,
                       from ../../chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h:12,
                       from ../../chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc:5:
      ../../components/enhanced_bookmarks/enhanced_bookmark_model_observer.h:29:16: note: 	virtual void enhanced_bookmarks::EnhancedBookmarkModelObserver::EnhancedBookmarkNodeChanged(const BookmarkNode*)
         virtual void EnhancedBookmarkNodeChanged(const BookmarkNode* node) = 0;
                      ^
      In file included from ../../storage/browser/fileapi/plugin_private_file_system_backend.h:13:0,
                       from ../../storage/browser/fileapi/file_system_context.h:20,
                       from ../../content/public/browser/content_browser_client.h:30,
                       from ../../chrome/browser/profiles/profile.h:17,
                       from ../../chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h:10,
                       from ../../chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc:5:
      ../../storage/browser/fileapi/file_system_backend.h: At global scope:
      ../../storage/browser/fileapi/file_system_backend.h:43:13:error: 'storage::kMaximumLength' defined but not used [-Werror=unused-variable]
       const int64 kMaximumLength = std::numeric_limits<int64>::max();
      
      Original issue's description:
      > Reduce frequency of requesting bookmark clusters.
      >
      > Currently, we fetch for bookmarks on SyncCycleCompleted.  We
      > actually just want to trigger a request for clusters when
      > bookmarks change due to a SyncCycle.  By watching for
      > ExtensiveChanges from the BookmarksModel and saving some
      > state, we can more accurately determine this.
      >
      > BUG=424254
      >
      > Committed: https://crrev.com/2d0c8cfc2d67eea473132d8582430c21529ce897
      > Cr-Commit-Position: refs/heads/master@{#302111}
      
      TBR=yfriedman@chromium.org,kkimlabs@chromium.org,noyau@chromium.org,mcolbert@chromium.org,danduong@chromium.org
      NOTREECHECKS=true
      NOTRY=true
      BUG=424254
      
      Review URL: https://codereview.chromium.org/693513003
      
      Cr-Commit-Position: refs/heads/master@{#302118}
      8077169f
    • reillyg's avatar
      Add API tests for the chrome.hid API. · e48477cd
      reillyg authored
      These test validate that the implementation of the chrome.hid API is using
      the API provided by //device/hid correctly. It does not talk to real devices
      or validate platform-specific functionality.
      
      BUG=
      
      Review URL: https://codereview.chromium.org/690473002
      
      Cr-Commit-Position: refs/heads/master@{#302117}
      e48477cd