- 24 Nov, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1606175959-14a3411953113a2fe64aa457a295c32153a3500e.profdata to chrome-linux-master-1606196878-64b7b1e8929e5613baadbfb35b6857cd242016c0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1205440d0ecc5eb6f147bd87957bf8a1b9928b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557341Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830502}
-
Mason Freed authored
The conversation [1] about the recent changes to setInnerHTML have led to the conclusion [2] that perhaps we shouldn't add a new XSS sink method at all. That would "fix" the declarative Shadow DOM problem, but would create a new sink that all security libraries would need to know about and handle. Seems like not a good trade. In the meantime, a polyfill can stand in for setInnerHTML: Element.prototype.setInnerHTML = function(content) { const fragment = (new DOMParser()).parseFromString(`<pre>${content}</pre>`, 'text/html', {includeShadowRoots: true}); this.replaceChildren(...fragment.body.firstChild.childNodes); }; [1] https://github.com/whatwg/dom/issues/912 [2] https://github.com/whatwg/dom/issues/912#issuecomment-732476002 Bug: 1042130 Change-Id: Ibaf15a3edf86be9a720225dea2ba2741f2882b8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555589 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#830501}
-
Yutaka Hirano authored
Bug: 1152249 Change-Id: Id21f5ec3531f3b3b03f163fe3d1f8d848ca3b8fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556887 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#830500}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I794e7484ccea4d900c1fd6ee77aa2281271f9ddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554982 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#830499}
-
Jinsuk Kim authored
A single factory instance for TabDelegate objects is enough for a ChromeActivity. This CL prevents multiple instantiations of the factory. This fixes a bug that logs MobileNTPOpenedInNewTab more often than expected due to numerous UMA reporter objects. Bug: 1014382 Change-Id: I7c28f6cd500bc58a835c16d7e5dbb6f9e90d82b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554274 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#830498}
-
Alice Wang authored
This CL migrates usage of signin.SigninPreferencesManager to the same class in signin.services target and remove the old class signin.SigninPreferencesManager. Bug: 1150862 Change-Id: I97f08bf0723ed8baf3d4757f1f01754c3eeb31c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553550Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#830497}
-
Risan authored
In the Android CLs, we allow this to happen and we prohibited the creation of the Android directories. So apps can access the MyFiles through Storage frameworks, but no default directories to be created. BUG=b:162793388 BUG=b:169537013 TEST=Manual test in Photos app, CtsAppSecurityHostTestCases, CtsProviderTestCases, part of CtsMediaTestCases Change-Id: I98ab33d6d68adfb1638bcdf07557817df257c6f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536424Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Risan <risan@chromium.org> Cr-Commit-Position: refs/heads/master@{#830496}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Ieab892a421c52a3dcc4e00bfd6a34b24eddeb963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546664Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#830495}
-
Yoshifumi Inoue authored
This patch extends expiry of WebCore.Editing.Commands* histogram and updates owner of WebCore.Editing.* histograms This is reland of the CL[1] with changing owner to yosin@ and kojii@ from editing-dev@ which is not valid for owner. [1] http://crrev.com/c/2550325 Bug: 1149518 TBR: schenney@chromium.org Change-Id: I46cc7e1db43c294a3dd7c0bc266266073535ec2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556891Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#830494}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I3b8b1179ee7a7cc44a8649514a13134ae2065ca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546388Reviewed-by:
-
Julie Jeongeun Kim authored
This CL returns nullopt if GetIndexInParent() is called on the WebView as it's not the child list in its parent if it has the WebContent. It fixes DCHECK error on GetIndexInParent(). AX-Relnotes: n/a. Bug: 1147007 Change-Id: I3def3ac9a4abb2abac8d2ae7702e8979a7c90e35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552310 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#830492}
-
Darren Shen authored
Add a new API for the IME to tell Chrome about autocorrects. Call the new autocorrect UI when there's an autocorrect. Bug: b/172969200 Change-Id: Iac1be66ff6c3eb6cfaff75ba96a388aa27d7a6ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531080 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
John Palmer <jopalmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#830491}
-
Ankit Kumar 🌪️ authored
Add AccessibilityCharInfo in pdf/ to replace usage of PP_PrivateAccessibilityCharInfo. PP_PrivateAccessibilityCharInfo is a Pepper struct. The new struct ensures that PP_PrivateAccessibilityCharInfo is scoped to parts specific to Pepper implementation. Bug: 1144444 Change-Id: I55ab25fd01a8b49976f936688a35de0ada1192a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554255 Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#830490}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I0f225f57e701f19705e46e5594528b5f1a82a56d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555419 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#830489}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/65fb101861ab..3df719619f0a 2020-11-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 546a7c98c897 to 03badec5d73a (3 revisions) 2020-11-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from ebf890fcf9f3 to 1b413197a6d7 (13 revisions) 2020-11-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 6d612051c083 to 43bb60e1fa11 (6 revisions) 2020-11-24 csmartdalton@google.com Return the contour's final point from SkPath::RangeIter in kClose If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC adlai@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: adlai@google.com Change-Id: I81c0dfa7358cacbc5f71ab5f4a0a088c5810118a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556920Reviewed-by:
-
Takuto Ikuta authored
This reverts commit 816bad6a. Reason for revert: This seems to cause https://crbug.com/1152235 Original change's description: > [DEPS] update luci-go > > Bug: 1143567 > Change-Id: I37f738d40c7a424440bf892405a0cca1ca2742cb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551867 > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Ye Kuang <yekuang@google.com> > Auto-Submit: Ye Kuang <yekuang@google.com> > Cr-Commit-Position: refs/heads/master@{#829620} TBR=tikuta@chromium.org,jwata@google.com,yekuang@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1143567, 1152235 Change-Id: Ib256257e24fd72b07ce3ebaa79ab9e6fac0ab3d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557118Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#830487}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c2a74cbb8ee1..1b413197a6d7 2020-11-24 jmadill@chromium.org generate_entry_points.py clean-ups. 2020-11-24 jmadill@chromium.org EGL: Add const to several methods. 2020-11-24 jmadill@chromium.org Use hard-coded year in generate_entry_points. 2020-11-24 jmadill@chromium.org EGL: Remove egl::Error from validation code. 2020-11-24 jmadill@chromium.org EGL: Expose device query as a client extension. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Change-Id: Ief9d82711b30118e3a885c26eb4329d3a8b7bdb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556385Reviewed-by:
-
Muhammad Hasan Khan authored
ProvisioningResult is used in UMA stats so we're not removing it but replacing most of its use with a new ArcProvisioningResult object that can represent all kinds of problems that can happen during provisioning. BUG=b:166322619 TEST=CQ TEST=unit_tests --gtest_filter='*ArcProvisioningResultTest*' Change-Id: Iec7192e05a84e1f4ae4d8e556a675d67fff1cd62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548841 Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#830485}
-
Kenneth Russell authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/1a111c2..3e3f152 Bug: 1136231, 1149176, 1152259 Tbr: jdarpinian@chromium.org Tbr: shrekshao@google.com Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64 Change-Id: I3ee0d2b7d598a836635d35fa812c4917f40d38b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552371 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#830484}
-
James Vecore authored
Nearby reuses the same notification id for all notifications so prior to this change, after the first share notification, new shares would not pop-up the accept/reject notification and it would get lost in the tray. This is a simple fix to just close the notification before an incoming share notification is displayed and also makes it high priority. Additionally we do the same for the success and failure notifications to ensure they pop-up. A more involved fix could separate out the stages of sharing into separate notifications or create a new id per share. Fixed: 1150648 Change-Id: I4523297fdd038a3904bd1358e0e671bb8b3a481e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556214Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Auto-Submit: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#830483}
-
Jan Wilken Dörrie authored
This reverts commit 5d1496e0. Reason for revert: https://bugs.llvm.org/show_bug.cgi?id=48048 got fixed. Original change's description: > Revert "[base] Use NO_UNIQUE_ADDRESS in flat_tree" > > This reverts commit f55e9981. > > Reason for revert: https://crbug.com/1144431 > > Bug: 1144431 > > Original change's description: > > [base] Use NO_UNIQUE_ADDRESS in flat_tree > > > > This change makes use of NO_UNIQUE_ADDRESS in flat_tree, allowing the > > removal of an internal class which just existed to make use of the empty > > base optimization. > > > > Bug: 682254 > > Change-Id: Iabf91d4acee95c7ba4e929d23528d95b0ced1612 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509757 > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#822948} > > TBR=dcheng@chromium.org,jdoerrie@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 682254 > Change-Id: If3b15e15241e8f8b5d99b80caadbb25153648f37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514147 > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823192} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1144431 Bug: 682254 Change-Id: I70549a9fa09c05c1528a3df6f317fe2ac042b814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553429Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#830482}
-
Yuki Yamada authored
Randomly crashes on Win 7 Tests x64 (1) https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/b8862779006945233296 TBR=rohitrao@chromium.org No-Try: true Bug: 1152289 Change-Id: I8007bb02997d230a66a78fda17b18c3c466f327b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557279 Commit-Queue: Yuki Yamada <yukiy@chromium.org> Reviewed-by:
Yuki Yamada <yukiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#830481}
-
Maksim Ivanov authored
Fix the bug found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ic33ba5a34435089eceda578014cd62b84350eef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555123 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#830480}
-
Minggang Wang authored
As part of the OnionSoup project, this patch moves request_peer.h to third_party/blink/public/platform/, which is needed when moving its sub class content::SyncLoadContext into blink and removing ResourceDispatcher finally. Change-Id: I874307b49a68ed2ea931db1e48faf02539551d7a Bug: 1110032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548648Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Minggang Wang <minggang.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#830479}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I86256d662153a26856323316978fa370a0cdc7ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550004 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#830478}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Ic46914d41965026956ec9adea34137fda5fdca16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550002 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
-
Yuki Yamada authored
Flakiness crash on Win 7 Tests x64 (1) https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29 TBR=dpapad@chromium.org No-Try: true Bug: 1152287 Change-Id: Iff9b50f7cf759b481ae1cac94ae7848e4d29d050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556621Reviewed-by:
-
Kunihiko Sakamoto authored
This replaces the usage of www2.127.0.0.1 with 127.0.0.1:8444. (There're no tests that actually access this host.) Bug: 1151384 Change-Id: I22d044943b40d8fffaea7dc7480e125c121dbe17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556739Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#830475}
-
Fergus Dall authored
This was incorrectly removed in CL:2537450 because it appeared to have no users. However, it was actually called directly by name (rather then by the constant defined in system_api) in vmc. Bug: 1151088 Change-Id: I95c4d10c8ab5656257bd72fd8d7fb47d07cef74c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551893Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#830474}
-
Robin Lewis authored
Bug: 1152214 Change-Id: I4d655c9f9103e560b5e8b5d3c4588601836ce344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556897 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#830473}
-
Yuki Yamada authored
This reverts commit ea3a00e5. Reason for revert: UIDevToolsServerTest.ConnectionToViewsServer crashes three builds in line: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29 Original change's description: > Enable CertVerifierService by default > > This relands commit a79726df and > commit aae065c3, which fix some > incompatibilities between the CertVerifierService and some unit tests > and enable the CertVerifierService feature by default. > > The Mac browser tests that caused the reverts are fixed by switching > SetCertVerifierServiceFactoryForTesting to just set a global > pointer rather than requiring SequenceLocalStorage which isn't > available when we need it. > > Bug: 1015134, 1094483, 1146899 > Change-Id: I1f60b9a59d19da39b1da2d8f11cc71fb523091cd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543199 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Caitlin Fischer <caitlinfischer@google.com> > Commit-Queue: Matthew Denton <mpdenton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830404} TBR=jam@chromium.org,mpdenton@chromium.org,caitlinfischer@google.com Change-Id: Ie1da129bfe10c21178dfbab0427c96785a52930a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1015134 Bug: 1094483 Bug: 1146899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557278Reviewed-by:
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I8a54ebb8aaf7257a13724fb41315abeef218680e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549022 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
-
tby authored
Right now, all generated event classes exist in the metrics::structured::events namespace. If two events from different projects have the same name (which is allowed), this will cause errors in recording. This CL moves the events for each project into a per-project namespace. Bug: 1148168 Change-Id: I421fa684efab61096d1b097ddd4efbfb20ef3a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554250Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#830470}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Ie85cdc1829094da969ce7987bff738afe3b1ba96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546668 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#830469}
-
Noel Gordon authored
- Piexloader.load has a catch() to handle all errors: thus throw a module failure there, instead of returning a Promise.reject. - Add finally() clause: to handle calling imageBuffer.close() if needed to free the {?ImageBuffer} resources. - No change in behavior. Bug: 1145029 Change-Id: Id6c50c447dc4ad31e34b7e6338f8c6b3c6a0a1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556885 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:Alex Danilo <adanilo@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#830468}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I50d7dd90d7b7c88130cd0e08ae60b93d48e9237f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551856Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606143477-736bd7cb1614be7da91ccc5efd0ee5b418913b13.profdata to chrome-win64-master-1606165050-a3d889677a06d0e206b82027c298bfd0cf0af279.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I76ea30d6a9af0cbf535916a5648175682e10c00e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556577Reviewed-by:
-
Changwan Ryu authored
The actual logic of getDisplayMode() is in the Java code, and therefore it is more straightforward if you plumb it through Java WCDA instead of individually plumbing it through native code. Especially so since we are trying to implement this for one more embedder, WebView. Bug: 1094366 Change-Id: I3d0ae3095ba23a09ebc0f3360ddfc5cd79c32a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542739 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830465}
-
Nektarios Paisios authored
This is a reland of 27401214 Test failures on Mac 10.14 don't appear to have anything to do with this change, because all of the non-experimental Mac bots are passing. Original change's description: > Fixes erroneous focus placement on Mac > > When using VoiceOver, focus is often erroneously placed in Chrome's toolbar instead of the web contents > as soon as the user navigates to a new page and after the page has loaded. > If the page includes logic that moves the focus to a specific item as soon as it loads, > that logic often has no effect on the location of the VoiceOver cursor. > For example, after visiting a user's Gmail inbox, VoiceOver often > neglects to automatically move to the list of emails, even though the page has logic to do that after load. > > The same problem often occurs when an iframe is inserted in the page and focus programmatically moves > to somewhere inside it. > For example if the user presses "h" and then "c" to focus the list of chat conversations in Gmail > and then selects and opens one of the conversations, the VoiceOver cursor might not move to the edit field in that conversation. > > This patch: > 1. Removes the logic that prevents the firing of a focus event if the page has not loaded, or has no content. > A) The page is marked as loaded as soon as the HTML is parsed, i.e. extremely quickly, so in 99% of cases this condition has no effect. > B) Even if the page is empty, user confusion does not occur, because everything happens too fast. > I tested with Jaws and NVDA, which were the AT for which this second condition was added in the first place. > C) This logic of preventing some focus events has caused bugs in the past, so I think simplifying it should > improve the health of our codebase, given that it doesn't cause any regressions. > 2. Adds accessibilityFocusedUIElement to BrowserAccessibilityCocoa. > It was implemented in Views, but was missing from Web. > > I suspect that the reason that this patch seems to fix the bug is because > VoiceOver monitors the load progress on the web contents, and expects a focus event to arrive as soon as the page has loaded. > > AX-Relnotes: VoiceOver focus should be in sync with browser focus, if the user has chosen this setting. > > R=dmazzoni@chromium.org, abigailbklein@chromium.org > > Change-Id: I9ae7b69fc3c7872bbbb39ffdd13562c97b8d1174 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551814 > Auto-Submit: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Abigail Klein <abigailbklein@google.com> > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830186} Change-Id: I0238bcdd331ee610cc4dd52403699b13f4ba5091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555497Reviewed-by:
Abigail Klein <abigailbklein@google.com> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#830464}
-
Yuki Yamada authored
This reverts commit 2f8a1a28. Reason for revert: Causing compile failure with expand_owners.Error: The histogram WebCore.Document.execCommand must have a valid primary owner, i.e. a Googler with an @google.com or @chromium.org email address. Original change's description: > Extend expiry of WebCore.Editing.Commands* histogram > > This patch extends expiry of WebCore.Editing.Commands* histogram and > updates owner of WebCore.Editing.* histograms > > Bug: 1149518 > Change-Id: I1924e8cf4ed51292a9fb6b940dc25b85f9acbcd8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550325 > Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> > Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830461} TBR=yosin@chromium.org,schenney@chromium.org Change-Id: I0b276c4668d826eb728591b0715452bab645a6b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1149518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556745Reviewed-by:
-
