- 18 Aug, 2020 40 commits
-
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I5cd6ab4d06b18ac8ade0eddbc9876e30b1dd9db1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362082Reviewed-by:
Krishna Govind <govind@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#799068}
-
Jinsuk Kim authored
This CL adopts SceneOverlay for overscroll glow effect. Previously the glow effect was rendered on a cc layer attached to the current WebContent's cc layer. This requires that the WebContents be used as View property, and swapped for every tab/WebContents change. Rendering it on scene overlay saves us from maintaining the logic above, and having to use the heavy object like WebContents for MVC view properties. Bug: 1112573 Change-Id: I0b80c7e78007051d2d94c76a14dcd265cb0607c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351267Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#799067}
-
dpapad authored
- Change border width to 4px (previously 6px). - Change color to google-blue-refresh-300 (previously google-blue-refresh-700) Both changes are according to the mocks. Bug: 1110756 Change-Id: I8b5fbac0f12448e80931d104e3af23eb51d687fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358887 Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#799066}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1756465158d3..b6a272ffee65 2020-08-18 hjd@google.com Git ignore libbase If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ifdf3eacf002ddf320a9e4e9566c89712ebc91cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362507Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799065}
-
Alice Wang authored
This CL sets up the sign-in general error UI screen when web sign-in encounters some general error like connection failed. Bug: 1114589 Change-Id: I5f2784283be1e49c715840ee03fab8b7af864cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360074Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#799064}
-
Takashi Toyoshima authored
As the fyi bots were turned down, this flag specific expectation is not needed any more. Bug: 1116928 Change-Id: I1f5f9498a7f6acc9dd338971002174bac0e659e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362064 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#799063}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1596045560-6c3207dc8f6ea5df1e0c422b4fa4d700088c0a24.profdata to chrome-win64-master-1597599037-37d4838cd87f22a0e9d22daa07afdb6346a7ed70.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I1cd60abe10854e0892ff6aa2e871acbddf5829e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360423 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Vasilii Sukhanov authored
The test should wait until the password value is autofilled instead of checking immediately. Bug: 1116886 Change-Id: I69c851d9cfa462d4638a763b079feb08eaaaafea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359082Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#799061}
-
Anatoliy Potapchuk authored
During profile startup, some of the a11y preferences were not reset -- those related to the mutualof tts engines used by extensions. Here we reset them as well. Bug: 1049566 Change-Id: If4c57cc3a165871eaa812af58e6d698c25be36e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360018Reviewed-by:
Anqing Zhao <anqing@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#799060}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/863115fb49d7..8150670ddd8d 2020-08-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from b8de4f57e983 to e28436f2b8a2 (3 revisions) 2020-08-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 527e67e9d933 to 30b3f3857835 (13 revisions) 2020-08-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from c1db3b8e7960 to 9d431ae2eeb4 (1 revision) 2020-08-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from abe07b943855 to 6f74415e2f74 (2 revisions) 2020-08-18 jmadill@chromium.org Vulkan: Clean up handleDirtyTexturesImpl. 2020-08-18 jmadill@chromium.org Vulkan: Clean up ImageHelper barrier functions. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I7163ccc4f979f41987326e8da920af8c145d2e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362547Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596045560-16c58258c8890a214570e6099d355ac47072ea3d.profdata to chrome-win32-master-1597611060-adf0ab6d7715dfdb592c8864718732c417ac4f3f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: If9dc8e7727d55351af0f5b5d88ecc0744c1bbf09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360424Reviewed-by:
-
Michael van Ouwerkerk authored
Change-Id: I75b5f69130559ad2cc70cc26aa61807f0697bc72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352947Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#799057}
-
Tamer Tas authored
R=johnchen@chromium.org CC=cbruni@chromium.org,jdecaires@twitter.com Bug: 1114635 Change-Id: I8d569776bd0f6fdbb656d70172f70c6f08ca3cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352939 Auto-Submit: Tamer Tas <tmrts@chromium.org> Commit-Queue: Tamer Tas <tmrts@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#799056}
-
Jan Krcal authored
This CL adds a 2px circular border around the avatar image (in the new design). To simplify the code, it also reimplements the margin between the avatar and the titles below. After this CL, it is a top margin of a new container around the titles. Bug: 1099286 Change-Id: I95081776193335e0d17a6b7451cbca40ec132d1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360276 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#799055}
-
Sergei Datsenko authored
Set up bidirectional communication between WebUI page and the backing browser and set up a "hello world" example. Bug: 1111229 Change-Id: I8a8ad38a02952a13a69723f33f5fbaa2fdf195d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353970 Commit-Queue: Sergei Datsenko <dats@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#799054}
-
Zhuoyu Qian authored
This CL rename Web IDL |Unforgeable| to |LegacyUnforgeable| to make its usage more clear. Bug: 1072773 Change-Id: I534ee3610f5e866ed4aa14ffcd6b6f6a90d648ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351603Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#799053}
-
Noel Gordon authored
Ensure entry names are in sort order before checking the entry values. Bot logs say (issue 1103147 #c16) test cannot assume sort order. Bug: 1103147 Change-Id: I3638298d7e016892def8ed61a3c0a0bc12dfc246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359976Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#799052}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b8de4f57e983..e28436f2b8a2 2020-08-17 andreperezmaselco.developer@gmail.com spirv-fuzz: Check termination instructions when donating modules (#3710) 2020-08-17 jackoalan@gmail.com Fix -Wrange-loop-analysis warning (#3712) 2020-08-17 andreperezmaselco.developer@gmail.com spirv-fuzz: Check header dominance when adding dead block (#3694) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC cnorthrop@google.com,radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: cnorthrop@google.com,radial-bots+chrome-roll@google.com Change-Id: I0fd8b6fb1e5e54ef96995d71bf73d7ab37b28487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361664Reviewed-by:
-
Hitoshi Yoshida authored
We are migrating IDL compilers, and IDL dictionaries have few behavior differences. This CL makes idl-dictionary-bindings test work with either of new/old IDL compilers. Bug: 839389 Change-Id: I42e90ba087d33619f84e8c04dec0958c589f6972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358712 Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Reilly Grant authored
This annotation is incorrect as the JNI bindings defined in this class are used from other classes and not just tests. Bug: 1107950 Change-Id: I07f33b11f8718d6fba1a3039b4bde85e31fc7451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360593 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#799049}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f926b0866fe4..1756465158d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia8c21e3002ae65fd4a6a06e61c6a109d23d6a7b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360516Reviewed-by:
-
Friedrich Horschig authored
With this CL, the save button is disabled while the new password is empty. Additionally, it displays a brief error text to inform the user about the required field. Screenshots in the bug. Bug: 1114720, 1092444 Change-Id: I0abb9582bdde093a69279a6887b74c0ddea68436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359995Reviewed-by:
-
Friedrich Horschig authored
Triggers the saving for non-empty passwords and closes the editing activity. This completes the editing flow (see screenshot in the linked bug). Bug: 1114720,1092444 Change-Id: Iee86d7d598aef0f4049925328398b643ca093c3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355945Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#799046}
-
Clemens Arbesser authored
This adds new settings to allow opting-out users who have explicitly canceled lite scripts a set number of times, as well as to allow distinguishing first time users to give them a better onboarding experience. See also the relevant launch bug: crbug.com/1110887 Bug: b/162224311 Bug: b/162223838 Bug: b/162572678 Change-Id: I07e8fc65daeead269ac2cecc1379a27594afd065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352904 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#799045}
-
Trent Apted authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/XU51Rj4Z6rGjyl18zltueVUb6Cpv4ey2XrfMw4NzyacC Release notes: http://go/media_app-x20/relnotes/Stable/media_app_202008170800_RC00.html Bug: b/162308416, b/164234229, b/163002455 Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: I402b531c1b951b31b62debc02b32ea75e5bd381d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358725Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#799044}
-
Boris Sazonov authored
Adds setLegacySyncAccountEmail/getLegacySyncAccountEmail to SigninPreferencesManager. These methods will be used until the downstream code is migrated to IdentityManager. Most of ChromeSigninController is removed - only get() and getSignedInAccountName are kept for now. The class will be removed completely as soon as downstream usages are migrated to SigninPreferencesManager. Bug: 10918587, 1046412 Change-Id: Ia297b48632ae9ec9e614024e50853981ce7fd156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339979Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#799043}
-
Dongjun Kim authored
"per-method-can-make-payment-quota" flag has expired and been removed from the chrome://flags UI. We are cleaning up the code that implements this flag. Bug: 1110716 Change-Id: Ie43d5ba68adcc47e6bb622efada47b7953d5d5a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339209Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: DongJun Kim <djmix.kim@samsung.com> Cr-Commit-Position: refs/heads/master@{#799042}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/807e4fa951b9..5988d0f33501 2020-08-17 tsepez@chromium.org No need to clear local variable in XFA_LoadImageFromBuffer(). 2020-08-17 tsepez@chromium.org Use fxcrt::AutoNuller<T> in CPDFXA_Context::LoadXFADoc(). 2020-08-17 tsepez@chromium.org Introduce fxcrt::AutoNuller<T>. 2020-08-17 pdfium-autoroll@skia-public.iam.gserviceaccount.com Roll MarkupSafe from 8f45f5cfa000 to f2fb0f21ef1e (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ia82800de6892788482795b5de31974b1b68c63e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361763Reviewed-by:
-
Cathie Chen authored
Bug: 721759 Change-Id: Ic2bfa6179e997c3db749ddba252bf720d587ce3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359849Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: cathie chen <cathiechen@igalia.com> Cr-Commit-Position: refs/heads/master@{#799040}
-
Ravjit Singh Uppal authored
JS parts of ExtensionContentSettingsApiTestWithWildcardMatchingDisabled have been cleaned up, and an additional native test is added to verify that trying to add a wildcarded pattern for `plugins` through the chrome.contentSettings API will print a console warning. Bug: 1073883 Change-Id: I010b1d3f25fb68110fc6f72b40ccf103c011731c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289423Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Auto-Submit: Ravjit Singh Uppal <ravjit@chromium.org> Cr-Commit-Position: refs/heads/master@{#799039}
-
Guido Urdaneta authored
This reverts commit 49422e89. Reason for revert: Speculative revert. Suspect of causing some failures that report Gpu issues with Wayland. https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/1109 Will reland if the revert does not fix the bot. Original change's description: > Reland "RELAND 2: media/gpu/vaapi_video_decoder: keep allocated VASurfaces alive" > > This is a reland of 02aec841 > > Speculative revert was incorrect > > Original change's description: > > RELAND 2: media/gpu/vaapi_video_decoder: keep allocated VASurfaces alive > > > > The relanded CL was reverted due to crashes when used from ARC++: > > Video Frames coming from this path are not GpuMemoryBuffers, so there's > > a DCHECK not verified, and then a crash. This CL addresses that > > situation, fixing `video_decode_accelerator_tests --use_vd_vda`: > > see crrev.com/c/2359734/1..3. > > > > Bug: b:163920993 > > > > Original RELAND description ------------------------------------------- > > > > The original CL was reverted due to crashes in betty initialization: > > betty is a VM which doesn't support VA, so the VideoDecoderPipeline > > constructed-destructed a VaapiVideoDecoder, hitting an unprotected > > nullptr |vaapi_wrapper_| in dtor. Fix in crrev.com/c/2339494/2..3. > > > > TBR=andrescj@chromium.org > > > > Original CL description ----------------------------------------------- > > > > Certain platforms and codecs suffer from horrible artifacts (Intel BYT, > > H264) or crashes (Intel BSW/BDW, VP9). This was traced to some kind of > > error in the tracking of the VASurfaces lifetime in the driver: every > > time we get a new resource from the pool to decode onto, this is > > imported into libva as a VASurface: this works fine almost everywhere > > but doesn't play well in these old platforms (see CreateSurface() body). > > > > This CL adds a map that keeps the ref-counted VASurfaces alive and > > indexed by the unique GpuMemoryBufferId until the VA Context is > > destroyed. In so doing, we're basically observing the "contract" of > > va.h vaDestroySurfaces() [1] "Surfaces can only be destroyed after all > > contexts using these surfaces have been destroyed". > > > > [1] https://github.com/intel/libva/blob/libva-2.0.0/va/va.h#L1134 > > > > Bug: b:142019786 b:143323596 > > Change-Id: I16e74eb2b483b892961eca27aed30112240aa8ba > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339494 > > Reviewed-by: Miguel Casas <mcasas@chromium.org> > > Commit-Queue: Miguel Casas <mcasas@chromium.org> > > Cr-Original-Commit-Position: refs/heads/master@{#795026} > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359734 > > Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> > > Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> > > Auto-Submit: Miguel Casas <mcasas@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#798931} > > TBR=mcasas@chromium.org,andrescj@chromium.org > > Bug: b:163920993 > Bug: b:142019786 b:143323596 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Change-Id: I6124e960d93f6985dbf9a546bc9d34372815e002 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359975 > Reviewed-by: Fergus Dall <sidereal@google.com> > Commit-Queue: Fergus Dall <sidereal@google.com> > Cr-Commit-Position: refs/heads/master@{#798968} TBR=mcasas@chromium.org,andrescj@chromium.org,sidereal@google.com Change-Id: I5a6c92e18abcfd4d16f67942fa882fdb6cbe4001 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:163920993 Bug: b:142019786 b:143323596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362247Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#799038}
-
David Jean authored
In MW mode, when on iPhones which isn't MW, the frame for a window is set multiple times by iOS private methods, but some of those do not take into account screen rotation and can end up passing in a frame that is in portrait sizes on a landscape device. When that happens, the frame is centered, hence the origin contains a negative coordinate. This CL skips setting the frame on the ChromeOverlayWindow's parent when it has a negative x (or y, in case the bug can be reproduced the inverse way). It applies to iOS 13 and 14. Bug: 1113187 Change-Id: I38b9f9f475502d5123ab381dbde01296416b22d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359137 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#799037}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/26ea611a4edb..0dca23916904 2020-08-18 jleconte@google.com Chrome Perf Dashboard UI links to Monorail bugs are missing project id. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1101773 Tbr: rmhasan@google.com Change-Id: I1cd4d9e70c4be9d06b57bfcf15a6ef8af8324307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360428Reviewed-by:
-
David Roger authored
Profile.Update and Profile.Delete are bumped by one year as they are still going to be useful in the short term. Gaia.Gaia.ResponseCodesForOAuth2AccessToken and Gaia.BadRequestTypeForOAuth2AccessToken are changed to never expire. Gaia.SuccessCountBeforeBadRequestForOAuth2AccessToken is obsolete. Fixed: 1104942, 1097911 Change-Id: Ibb8a8cad5b4745948b656b91f752fcf438607452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358832Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#799035}
-
Saurabh Nijhara authored
We want to improve the installation time for force installed extensions. For this, we need to first gather the statistics regarding which installation stages are time consuming. This CL adds the UMA statistics for the following installation stages: 1) Unpacking - Time taken to complete the unpacking of the extension archive. 2) Checking - Time taken to perform the final checks to confirm that the extension can be installed. 3) Finalizing - Time taken to install the extension. Following histograms are added: Extensions.ForceInstalledTime.UnpackingStartTo.CheckingStart Extensions.ForceInstalledTime.CheckingStartTo.FinalizingStart Extensions.ForceInstalledTime.FinalizingStartTo.CRXInstallComplete Bug: 1102369 Change-Id: I46ed872a2954edba51ebdaeab8ab0ca9e1f4703b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351996Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#799034}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/8f1c25394047..44b62e8d9182 2020-08-17 miu@chromium.org Fix zero-padding bug for IpV4 address operator<<(). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I04ede1e0672976200ec18c41973b522506ca8eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360945Reviewed-by:
-
Evan Stade authored
This affects: 1. desktop settings 2. android settings 3. desktop sync settings Bug: 1114258 Change-Id: Ia51d1b9684096d3d61bab5108e754fc63c87e9e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352039 Auto-Submit: Evan Stade <estade@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#799032}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I19d842d3530d1ba05c99557c0cc42b59421e6b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361767Reviewed-by:
-
Dominic Mazzoni authored
We considered making caret browsing reset on startup, but the final UX decision was that would just be more confusing. With this patch, the caret browsing preference persists like any normal preference - if it was enabled when you exit Chrome, it will still be enabled the next time you restart. The only exception is that if you pass the --enable-caret-browsing switch it will be enabled by default; this will keep things seamless for users who have already been using the switch for the past year. Bug: 1116659 Change-Id: I7653242fa2ee0a929855a3f9f77913a47f9eb9da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360335Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Jan Krcal authored
This CL changes the corner radius of a colored background inside a bubble dialog with the corner radius of the bubble itself, as requested by UX. Bug: 1099286 Change-Id: I47ade9c26e9ff1321e15c37d27aedeebcca65781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359085 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
-
