GitLab

Current the RegisterMainThreadDocumentPaintDefinition is taking a
std::unique_ptr<Vector<CSSSyntaxDescriptor>> because the
CrossThreadCopier doesn't yet know how to handle a Vectof of
CSSSyntaxDescriptor.

This CL adds a CrossThreadCopier template in the css_syntax_descriptor.h
so that we no longer need to wrap the Vector<CSSSyntaxDescriptor> into
a std::unique_ptr. We add this template in the specific header file
such that it won't pollute the cross_thread_copier.h.

This CL does not change behavior.

Bug: None
Change-Id: Idcad4f578f44605cf535598713e3c03c5035b7aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642957Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666089}

Bug: 922813
Change-Id: I9017954c687da3323127dd93b9afe63bfa9ee57b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643497
Commit-Queue: ericale <ericale@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666088}

OtaActivator objects are meant to be single-use with a single binding,
so there was never a need to use a BindingSet here.

Bug: 961084
Change-Id: I4b60cc7c556faed5acaec80a211aae1f22cf117d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641549Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666087}

Change-Id: I7714480b1369877a8164f57c22ab7bd43c9feb3a
Bug: 945963
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639742
Commit-Queue: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666086}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2c48f24c7f88..71c6bc07e67f


git log 2c48f24c7f88..71c6bc07e67f --date=short --no-merges --format='%ad %ae %s'
2019-06-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@71c6bc07e67f

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I4094fb46b4c81724733d3a603acd2db7dc0505d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643904Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#666085}

Add a localization concatenation check to the presubmit script that issues
an error when a disallowed concatenation is found. Concatenation to a
localizable string is only allowed when it's a string that doesn't
contain letters.

* Example (allowed): ls`Status code` + ': '
* Example (disallowed): ls`Status code: ` + statusCode
* Example (disallowed): ls`Status ` + 'code'

I also fixed the current violations.

Bug: 941561

Change-Id: I428a174f00ad4567a280756b13cfb44bc317d75a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637146Reviewed-by: Erik Luo <luoe@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Mandy Chen <mandy.chen@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#666084}

Some gpu bugs are related to the monitor refresh rate. Adding this display
information will help us on gpu debugging.

Bug: 964095
Change-Id: I4756a2f4f58383e966e3bbc73bfb2f6a858d690b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629761
Commit-Queue: Maggie Chen <magchen@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666083}

Non-renderer child processes must acquire interfaces from the global
system service instance; this is also true for many interfaces acquired
by renderers, and r660952 made the assumption that interfaces exposed to
all types of child processes were handled by shared code common to all
process host types.

However, the way CallStackProfileCollector is exposed specifically,
renderer processes must still acquire it from a browser service
instance. This restores that behavior.

Bug: 969742
Change-Id: Ib864b9220d73014b45a89cb92acc000766b606e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641548Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#666082}

Bug: 749276
Change-Id: I90a2e189371aae200b1271d8effb70b0ed66ba31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629694
Commit-Queue: Matt Mueller <mattm@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666081}

When overview, splitview and applist are active at the same time,
fallthrough to app list to handle the key events. Otherwise, it should
still be overview to handle the key events.

Bug: 970052, 969899
Change-Id: Ic090a5bc06aeb88ee286bfc35434cd19749e0221
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642740Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666080}

The feature_engagement component has a public API that requires clients
to add some configuration and boilerplate code within the component
itself, such as the base::Feature, and chrome://flags configuration.

This leads to clients having to add an additional reviewer without
necessarily adding value to the review process. twellington@ has for a
long time reviewed many such changes, but has lacked the ability to sign
off on the feature_engagement parts, even though they are well aware of
the requirements and typical usage patterns.

This CL therefore adds twellington@ as an OWNER for the relevant files
that clients typically have to edit.

Bug: None
Change-Id: Ibabef70bbe21c089d9a3a6043d2362edc7fb20ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642745Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666079}

This is in preparation of removing the custom cr.EventTarget
implementation in favor of native EventTarget.

Bug: 854268
Change-Id: I8f2b7ee6b3e3d9a4b409f82ddde22929d5b02754
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642756
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666078}

TBR=arthursonzogni@chromium.org

Bug: 970815
Change-Id: Ief201ab09e9d9ef873b46aa7640eccb18e3b3d91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642743Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666077}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9672bf6d..10dea84f

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I060b83a9216ece83b9843709bdc5743864a116ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643838Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#666076}

As part of the kernel uprev process devices may receive kernel support
for VMs. In these situations it would be nice to allow the user to
enable Crostini. However, while the kernel is in its experimental
rollout phase for a given device there is no guarantee the kernel won't
be reverted to a version without VM support. As a compromise, let's
still allow users to enable Crostini when supported, but guard it behind
an experiment flag so users are forced to acknowledge the possibility of
data loss.

BUG=b:133833983
TEST=start chrome with --kernelnext-restrict-vms, verify crostini is not
available. Enable enable-experimental-kernel-vm-support flag and verify
crostini is available.

Change-Id: If5727122e5d76f1a674ae96964d5eb6587eb5bf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639726
Commit-Queue: Jon Flatley <jflat@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666075}

These metrics currently use swap time which is the time the compositor
sends compositor frame to the display compositor. This CL changes the
metrics to use presentation time which is the time pixels actually
appear on screen, according to gpu.

BUG=899847

Change-Id: I5981fbc88a2cabebd5f4109e26f7e4cb152ea3fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598212Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666074}

In this template, we defined MediaValuesCached::MediaValuesCachedData to
be Type, so after that definition, we should just use Type instead of
MediaValuesCached::MediaValuesCachedData.

This CL does not introduce behavior change.

Bug: None
Change-Id: I7337cf2a1d87aeecc8ff1048e1a666753b0166c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643887Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666073}

I'm leaving Chrome and am transferring my Android Selection ownership
to Shimi.

Change-Id: I9dd6aa1d5837ce8bd17d1bbaa9bdb750bb1bef6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644378Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666072}

This got missed in crrev.com/c/1637611

TBR=dcheng@chromium.org

Bug: 850669
Change-Id: I0ef7db0eaa9d8e6de64786278d57a92bf91a689f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639818
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666071}

This patch removes the special casing code that converts card network
payment methods to "basic-card" in the Android implementation of
Payment Request.

With this patch, requests that use a card network as a supported
payment method will be rejected as unsupported payment methods. Tests
are updated to reflect this new expectation.

This deprecation has been approved for M64, but was never implemented.
Intent to deprecate:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/1udpnrlQK4Q/ot_E-htQAQAJ

A Blink counter was added to count actual usage of card network as
payment method in the wild. This is now practically 0.
See "PaymentRequestNetworkNameInSupportedMethods" in the histogram:
https://uma.googleplex.com/p/chrome/histograms?endDate=20190525&dayCount=7&histograms=Blink.UseCounter.Features&fixupData=true&showMax=true&filters=channel%2CEQ%2C4%2Cisofficial%2CEQ%2CTrue&implicitFilters=isofficial

Bug: 719526
Change-Id: Iad1e44039628f7fd64c71871b1643776a21dd257
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640778Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666070}

No behavior change, removing an un-necessary blank line only.

TBR=andruud@chromium.org

Bug: None
Change-Id: I378f66e0df75016b1d9848fe55ea8325d84e3556
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643889
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666069}

No change to production, only tests.

This aims to modify cookie expiration-related logic in tests, in a way
which is more obviously consistent with expectations:

* Cookies cannot be set with millisecond-level precision, so remove
  makeExpiringCookieMs().
* Use "Max-Age" directive instead of "Expires" directive. This ensures
  the expiration time is relative to when the cookie is set, rather than
  when "new Date()" was invoked, reducing opportunity for races.
* Named constants for cookie lifetimes, to clarify meaning.

Bug: 969912
Test: run_webview_instrumentation_test_apk --enable-features=NetworkService,NetworkServiceInProcess -f CookieManagerTest#*
Cq-Include-Trybots: luci.chromium.try:android_mojo
Change-Id: Ie2da4b4f92ec4bf8b26c6fc3b70d3086a7ba57b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636181Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666068}

Bug: 970344
Change-Id: I45371307ac8f985b2f09fcfb6bb9e14ce9f2f4bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643731Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666067}

This CL:
- Renames the resources in webapk/libs/common/res_splash to avoid
the need for merging resources with the same name prior to uploading
them to the Google storage build bucket.
- Adds a PRESUBMIT check to ensure that resource files names in
webapk/shell_apk/res differ from the resource file names in
webapk/libs/common/res_splash

BUG=969591

Change-Id: I8aa6062e8f9b37d008d185ea45dc4f04606d2c03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642976
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666066}

R=rbpotter@chromium.org
BUG=970161

Change-Id: If94827f9e3b0c17450c0ed6caed2b7ecb707151f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643991
Auto-Submit: Dan Beam <dbeam@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666065}

This is a fix for a crash in
~DataReductionProxyURLLoaderThrottle() that is caused by a
use-after-free of DataReductionProxyThrottleManager.  The lifetime of
the manager vs. the throttle is unfortunately not easy to determine
precisely, with these types of objects created in distinct places and
the manager sometimes owned by ref-counted objects.  To work around
this, the manager will now inform the associated throttles about its
destruction so they can drop references and behave accordingly.

Bug: 968513
Change-Id: I301555716b8bdf905d699662ef66f0524d0338ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638521
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666064}

These are still needed to track DWrite stability and work in progress
related to font src: local() matching.

Change-Id: I522adb5773bdaf50a749c61daefcc0e821a4e4b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642631
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Auto-Submit: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666063}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/29e2ec5aa31e..002d0e113a3b


Created with:
  gclient setdep -r src-internal@002d0e113a3b

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome

BUG=chromium:961548
TBR=harringtond@google.com,orphis@google.com,shend@google.com

Change-Id: Ibfa808277f2c1241d3a7732ebfd4f57eb5d98388
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643900Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#666062}

If the input is invalid UTF-8, both GetHFSDecomposedForm and
CFStringStringCreateWithBytesNoCopy will fail, the latter returning
nullptr. This nullptr is then dereferenced, creating the crash from the
bug. If this occurs, we fallback to strcmp, since case won't be
meaningfully defined for invalid UTF-8.

Bug: 960873
Change-Id: I50c551a5687e26fb777a8005b14e7f261051630f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627656Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666061}

See crrev.com/c/1590404 and the linked bug for context -- the goal is to
fix the broken memory-leak checking in Chromium's ASAN
(AddressSanitizer) trybots, which are supposed to also run LSAN
(LeakSanitizer).

Currently-leaking tests must be fixed or disabled before leak checking
can be enabled in the ASAN trybot.

WARNING: This will result in a loss of ASAN coverage for the affected
tests given that LSAN runs as part of the ASAN trybot.

If that's not acceptable, we can wait until the leaks are fixed before
fixing leak detection in trybots, but keep in mind that newly-introduced
leaks Chromium-wide won't be caught until then.

Bug: 960985,969555
Change-Id: I1971900a4cc893d3ef79491c2550b95e16c6802a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636863Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666060}

See crrev.com/c/1590404 and the linked bug for context -- the goal is to
fix the broken memory-leak checking in Chromium's ASAN
(AddressSanitizer) trybots, which are supposed to also run LSAN
(LeakSanitizer).

Currently-leaking tests must be fixed or disabled before leak checking
can be enabled in the ASAN trybot.

WARNING: This will result in a loss of ASAN coverage for the affected
tests given that LSAN runs as part of the ASAN trybot.

If that's not acceptable, we can wait until the leaks are fixed before
fixing leak detection in trybots, but keep in mind that newly-introduced
leaks Chromium-wide won't be caught until then.

Bug: 961023
Change-Id: I1899fbea3d1ce8288c954c97d4d486bd3cda3371
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638818
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666059}

TBR=mkwst@chromium.org

Bug: 970334
Change-Id: I10c31612c6623d50382f485fd26845a2f4c8faa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643498Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666058}

Delete myself from various OWNERS files. Also delete my
entries from WATCHLISTS and delete an old TODO.

Bug: none
Change-Id: Id226c2eb8ecf2aebe1c9dd2008f52de5f2050a34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643400
Commit-Queue: Dan Erat <derat@chromium.org>
Auto-Submit: Dan Erat <derat@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666057}

WPTs have not yet been updated to new spec requirement of expecting
"script timeout" when a script times out, resulting in failures that
actually adhere to the living spec.

Change-Id: Idc7543d01bb1fd83693240e74920bd3f48d5e6d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643839Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Rohan Pavone <rohpavone@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666056}

The test appears to already be enabled everywhere without generating
complaints about flakiness, and the MAYBE definition isn't used.

Bug: 806684
Change-Id: I02b61b79cfce047be4c021401f41298f9d1aef3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642673
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Auto-Submit: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666055}

The present CL moves ShowAppCannotSnapToast() from split_view_controller
to split_view_utils. The latter is a much more natural choice, because
the function is used outside split_view_controller, it does not use
anything inside split_view_controller, and it goes hand in hand with
CanSnapInSplitview() which is already in split_view_utils.

Test: manual
Bug: 970013
Change-Id: I6bd4e2044a0622d5604adbb287045befcdf20eaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639666Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666054}

CI/CQ builders migrated:
- Chromium Mac 10.13 / mac_chromium_10.13_rel_ng
- Mac ASAN Release
- Mac ASAN Release Media
- Mac ASan 64 Builder / mac_chromium_asan_rel_ng
- WebKit Mac10.13 (retina) / mac10.13_retina-blink-rel
- Libfuzzer Upload Mac ASan
- Site Isolation Android
- Android CFI / android_cfi_rel_ng
- Android x64 Builder (dbg) / android_compile_x64_dbg
- Android x86 Builder (dbg) / android_compile_x86_dbg
- Mojo Android / android_mojo
- Android WebView L (dbg)
- Android WebView M (dbg)
- Android WebView N (dbg) / android_unswarmed_pixel_aosp
- Android WebView O (dbg)
- Android WebView O NetworkService (dbg)

Bug: 950413
Change-Id: I2f08995a73a6d03ff9031a3833002cd717ca98fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642854Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666053}

Removes circular background behind Messages badge that existed when
it was selected. Removes methods that only serve to toggle the selected
state of the badge.

Change-Id: I255b98290223c955d24abf4cf44aef7dabb36225
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637592Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666052}

Bug: 968296
Change-Id: I893b369b466545e83a91a530e3b44be967934734
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644010
Auto-Submit: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666051}

This patch rolls the third_party/openscreen repository to include
changes to build macros, fixing the build inside Chromium.

Change-Id: I7418da93ea222383b98ab074c1e5b1d627e76db7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643890
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Auto-Submit: Jordan Bayles <jophba@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666050}