GitLab

Now it's unused. We can remove it.

BUG=677253

Review-Url: https://codereview.chromium.org/2619523003
Cr-Commit-Position: refs/heads/master@{#441906}

ArcContentFileSystemService is renamed to ArcFileSystemService, and it
will register two ARC file systems.

Also constants in arc_content_file_system_url_util.h are renamed
now that we have two ARC file systems.

BUG=chromium:671511
TEST=unit_tests --gtest_filter='Arc*'
TEST=trybot

Review-Url: https://codereview.chromium.org/2589643002
Cr-Commit-Position: refs/heads/master@{#441905}

Returning nullptr caused crash in fuzz testing when the call sites
attempts to create a string object out of it. Previously it was
returning an empty string(std::string()). This change makes it work
as it used to by changing the return type back to std::string.

BUG=678359

Review-Url: https://codereview.chromium.org/2619493002
Cr-Commit-Position: refs/heads/master@{#441904}

BUG=661105
TEST=Manual. Check that focus can move on a close button of an ARC
     notification by TAB.

Review-Url: https://codereview.chromium.org/2610853011
Cr-Commit-Position: refs/heads/master@{#441903}

Now that DOMWindowPerformance can access DOMWindow with host(),
DOMWindowPerformance doesn't need to observe ContextClient.

This CL removes DOMWindowPerformance::m_window.

BUG=610176

Review-Url: https://codereview.chromium.org/2615633011
Cr-Commit-Position: refs/heads/master@{#441902}

Now that DOMWindowStorage can access DOMWindow with host(),
DOMWindowStorage doesn't need to observe ContextClient.

BUG=610176

Review-Url: https://codereview.chromium.org/2617703003
Cr-Commit-Position: refs/heads/master@{#441901}

It's not needed.

BUG=610176

Review-Url: https://codereview.chromium.org/2611163003
Cr-Commit-Position: refs/heads/master@{#441900}

The StyleEngine for html import documents does not have a Frame which
means size media queries will always evaluate to true. We incorrectly
replaced a passed-in master document StyleEngine with the StyleEngine
from the DocumentStyleSheetCollection in https://crrev.com/90d4ea3d
That was wrong for evaluating media queries.

R=meade@chromium.org
BUG=677963

Review-Url: https://codereview.chromium.org/2618803002
Cr-Commit-Position: refs/heads/master@{#441899}

Now that Navigator's supplement can get a Navigator object via host().
Then Navigator's supplement doesn't need to observe ContextClient.

BUG=610176

Review-Url: https://codereview.chromium.org/2617583005
Cr-Commit-Position: refs/heads/master@{#441898}

It's not needed.

BUG=610176

Review-Url: https://codereview.chromium.org/2615163002
Cr-Commit-Position: refs/heads/master@{#441897}

ScriptController::updateDocument is unnecessarily complicated.

Assuming that ScriptController::updateDocument is never called after
the context is detached (I added a dcheck to verify the fact in WindowProxy::updateDocument()),
we can simplify ScriptController::updateDocument.

It also enables us to remove ScriptController::initializeMainWorld.

BUG=677253

Review-Url: https://codereview.chromium.org/2608163009
Cr-Commit-Position: refs/heads/master@{#441896}

This is a followup CL for [1] and does following things:

- documents lifetime of SharedWorkerHost.
- removes SharedWorkerHost::WorkerContextDestroyed that clears member fields.
  This is not meaningful because the host is destructed immediately after this
  function.
- removes |instance_| checks because it's always valid.

[1] https://codereview.chromium.org/2601893002/#msg39

BUG=612308

Review-Url: https://codereview.chromium.org/2614013004
Cr-Commit-Position: refs/heads/master@{#441895}

This allows CSSProperties.in to have unordered entries.

Generated code is now:

namespace blink {

bool CSSPropertyMetadata::isDescriptorOnly(CSSPropertyID property) {
  switch(property) {
    case CSSPropertyInvalid:
      ASSERT_NOT_REACHED();
      return false;
    case CSSPropertyFontDisplay:
    case CSSPropertyMinZoom:
    case CSSPropertyOrientation:
    case CSSPropertyUnicodeRange:
    case CSSPropertyMaxZoom:
    case CSSPropertyUserZoom:
    case CSSPropertySrc:
      return true;
    default:
      return false;
  }
}

BUG=677884

Review-Url: https://codereview.chromium.org/2614773007
Cr-Commit-Position: refs/heads/master@{#441894}

Now that Navigator's supplement can get a Navigator object via host().
Then Navigator's supplement doesn't need to observe ContextClient.

BUG=610176

Review-Url: https://codereview.chromium.org/2618773004
Cr-Commit-Position: refs/heads/master@{#441893}

It's unused.

BUG=610176

Review-Url: https://codereview.chromium.org/2616013002
Cr-Commit-Position: refs/heads/master@{#441892}

BUG=chromium:671511
TEST=unit_tests --gtest_filter='Arc*'
TEST=trybot

Review-Url: https://codereview.chromium.org/2580713004
Cr-Commit-Position: refs/heads/master@{#441891}

Now that Navigator's suppelemnt can access the Navigator object via host(),
it doesn't need to observe ContextClient.

BUG=610176

Review-Url: https://codereview.chromium.org/2615153002
Cr-Commit-Position: refs/heads/master@{#441890}

Note: This affects the sizing of the icons some, requiring a few layout changes, but they are mostly minor.

Tested in MD Settings, Options (old settiings), OOBE, and chrome://network.

BUG=611258
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2592383003
Cr-Commit-Position: refs/heads/master@{#441889}

Makes these callbacks visible from other .cpp files.

BUG=617892

Review-Url: https://codereview.chromium.org/2617933002
Cr-Commit-Position: refs/heads/master@{#441888}

The complexity of the old tests had gotten out of hand; Telemetry's
benchmark infrastructure was not a good match for what were ideally
imperative-style tests.

These tests were ported one-by-one and tested along the way. They
should be a 1:1 match in terms of functionality. In the new test
harness, skip expectations work properly and don't run the test body
on any platform, so some of the logic which avoided yielding certain
tests on certain platforms has instead been expressed as test
expectations.

Delete the has_transparent_visuals_gpu_process and
no_transparent_visuals_gpu_process tests, which had become no-ops.

This is the last reference to the python code in
content/test/gpu/page_sets. Delete it and the associated lint
presubmit check.

BUG=352807
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=zmo@chromium.org

Review-Url: https://codereview.chromium.org/2611263002
Cr-Commit-Position: refs/heads/master@{#441887}

Some of the failures are fixed and others are not mojo-loading specific.

BUG=670409, 670562, 610835, 678481, 678482, 678484, 678485, 678486, 678487, 678488, 678489, 678490, 678491, 678492, 678493, 678496, 678498, 678499
R=lukasza@chromium.org

Review-Url: https://codereview.chromium.org/2618523004
Cr-Commit-Position: refs/heads/master@{#441886}

This change refactors CSSValueInterpolationType to not override
CSSInterpolationType::maybeConvertSingle() and instead
use the more specific conversion functions as is the norm.

This change is part of supporting smooth interpolation of
registered custom properties. More complex behaviour will be
added to CSSInterpolationType::maybeConvertSingle() which must
be shared with the CSSValueInterpolationType subclass.

There are no changes in behaviour made by this patch.

BUG=671904

Review-Url: https://codereview.chromium.org/2614613002
Cr-Commit-Position: refs/heads/master@{#441885}

BUG=653398
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2618633002
Cr-Commit-Position: refs/heads/master@{#441884}

We no longer rely on setTimeout timing.

BUG=248938

Review-Url: https://codereview.chromium.org/2615123002
Cr-Commit-Position: refs/heads/master@{#441883}

BUG=

Review-Url: https://codereview.chromium.org/2617823003
Cr-Commit-Position: refs/heads/master@{#441882}

left/padding/width/height...
Replaced NGSizeIndefinite with Optional<LayoutUnit>

Fixed a couple of minor bugs where AvailableSize was incorrect.

Passing ~30 more tests.

BUG=635619

Review-Url: https://codereview.chromium.org/2616613003
Cr-Commit-Position: refs/heads/master@{#441881}

https://pdfium.googlesource.com/pdfium.git/+log/4a551f5570b3..469f6da247ff

$ git log 4a551f557..469f6da24 --date=short --no-merges --format='%ad %ae %s'
2017-01-05 tsepez use unique_ptr in cxfa_layoutprocessor.h

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2614103003
Cr-Commit-Position: refs/heads/master@{#441880}

Added CSSPropertyAPITextUnderlinePosition which implements
CSSPropertyAPI for the text-underline-position property.
Parsing logic is the same as before, just was moved from
CSSPropertyParser to the .cpp file. Added flag to
CSSProperties.in so that the .h file will be generated.

BUG=668012

Review-Url: https://codereview.chromium.org/2614903002
Cr-Commit-Position: refs/heads/master@{#441879}

Currently a callback passed on the second time is discarded when StopWorker
message is sent twice. This patch fixes it by not calling EWInstance::Stop twice
and not sending the StopWorker message before StartWorker message.

BUG=674443
TEST= ./third_party/WebKit/Tools/Scripts/run-webkit-tests  -t Master 'http/tests/serviceworker/chromium/resolve-after-window-close.html' --no-retry-failures --order=random --iterations=100 --exit-after-n-crashes-or-timeouts=1

Review-Url: https://codereview.chromium.org/2578023002
Cr-Commit-Position: refs/heads/master@{#441878}

NOTRY=true
TBR=sashab@chromium.org

BUG=663855

Review-Url: https://codereview.chromium.org/2617883003
Cr-Commit-Position: refs/heads/master@{#441877}

doesn't appear in test results (thanks to Alan for pointing it out).

Instead we should focus on writing good test descriptions.

BUG=

Review-Url: https://codereview.chromium.org/2617083002
Cr-Commit-Position: refs/heads/master@{#441876}

These UseCounters will allow an investigation into how often alert(),
confirm(), and prompt() are called for sites with different engagement
levels.

BUG=644268

Review-Url: https://codereview.chromium.org/2610813006
Cr-Commit-Position: refs/heads/master@{#441875}

BUG=348655

Review-Url: https://codereview.chromium.org/2568133007
Cr-Commit-Position: refs/heads/master@{#441874}

https://pdfium.googlesource.com/pdfium.git/+log/c4fcad23b143..4a551f5570b3

$ git log c4fcad23b..4a551f557 --date=short --no-merges --format='%ad %ae %s'
2017-01-05 tsepez Remove two unused members in cpdf_streamcontentparser.
2017-01-05 dsinclair Cleaning up memory allocation in CXFA_FM2JSContext - III

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2611163004
Cr-Commit-Position: refs/heads/master@{#441873}

If the window is in the trusted pinned mode,
we do not expect that can enter into another mode, e.g.
maximized/minimized/fulscreen mode, without explicit
unpin action by client.

BUG=665943
TEST=Ran trybots. Tested in ARC kiosk mode, and the apps can continue
     to run on a pinnded window.

Review-Url: https://codereview.chromium.org/2590123002
Cr-Commit-Position: refs/heads/master@{#441872}

IgnorableExceptionState is equivalent to DummyExceptionStateForTesting.
We should just use DummyExceptionStateForTesting.

BUG=

Review-Url: https://codereview.chromium.org/2614013003
Cr-Commit-Position: refs/heads/master@{#441871}

(1) Add counters for popup actions (desktop only in this CL.)
(2) Add unittest.

"Dismiss" is not counted, because it's not very meaningful for desktop
popup actions; There is no single dismiss button, and count in
destructor will count all the displays.

BUG=650132

Review-Url: https://codereview.chromium.org/2588273002
Cr-Commit-Position: refs/heads/master@{#441870}

This CL tests that the views external protocol dialog behaves correctly
when it is Accepted, Canceled, and Closed. In particular, the status of
the dialog's checkbox is verified; when the dialog is Closed without
a definite user choice of Accept or Cancel, it is ensured that the
checkbox is always reported as unchecked. This is to prevent dismissing
the dialog from accidentally persisting a permanent block on external
protocols.

The dialog is not used on ChromeOS, so the test is only run on Linux,
Windows, and MacViews.

BUG=671658

Review-Url: https://codereview.chromium.org/2610793002
Cr-Commit-Position: refs/heads/master@{#441869}

https://crrev.com/2558743002 fixed loading.mobile on Nexus5 WebView and
page_cycler_v2 on Nexus5/Nexus6 WebView, but loading.mobile on Nexus6
WebView is still failing.

BUG=676612
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2613153005
Cr-Commit-Position: refs/heads/master@{#441868}

We force a style recalc at the start, so a transition occurs.

We wait for the compositor before declaring the test complete.

BUG=248938

Review-Url: https://codereview.chromium.org/2614883005
Cr-Commit-Position: refs/heads/master@{#441867}