GitLab

Bug: 1028242
Change-Id: I6c0276a8e7b7930ae2e4af6e71117a9e323fec84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959785
Auto-Submit: Erik Staab <estaab@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723443}

Bug: 1021887
Change-Id: I09c1792a4e9d51c2336e0d00dad6350a41591409
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959037Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723442}

Updates the expires_after attribute for 222 histograms that show
frequent access in the past 90 days.  These are the 80% most
frequently used histograms over that time that do not already have a date later
than or within 60 days of 2020-06-07.

Change-Id: I038c7543b34c26d6b414b5dff87907f33f679bed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958254
Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723441}

Recording the MIME type of the main frame of a page will give us more
information about what the page contains. This will be useful to some
of the interventions like tab discarding who handle PDFs and regular
pages differently.

Bug: 1030399
Change-Id: I03cc93e913abb351f070a9cc68f808f601252656
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955033
Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723440}

base::JSONReader::Read() is a static method, so there is no need to
instantiate a base::JSONReader object. While making this change, also
stop using ReadDeprecated(), and make the code lint error free.

Change-Id: I4ba79d61af6c736e762cb926a04e28ef13fb63fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1476413Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723439}

Bug: 1011098
Change-Id: Ic8e0d3d5028004d7c980bf1b8b7e7a61ad4a5bf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956262Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723438}

Bug: 1032266
Change-Id: I6b0e0d3328444f24d0dbbd874ec8e951ef86ff20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959768Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723437}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3f57d6f9..a7b3b5fa

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ida9aabfd1c549ac1b7e3c20655a28503cfefd4f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960526Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#723436}

During AXTree::Unserialize, if an AXID was reparented then ultimately
removed from the tree, AXTree would notify that the node was being
reparented rather than removed.

https://crrev.com/c/1907774 fixed the crash this behavior caused by
more accurately notifying OnNodeDeleted and changing when nodes are
un-mapped by BrowserAccessibilityManager.

This change fixes the incorrect events being fired that previously
would have caused a crash with the following stack :
- ui::AXNodeData::HasState
- ui::IsIgnored
- ui::AXNode::GetUnignoredParent
- content::BrowserAccessibility::InternalGetParent
- content::BrowserAccessibility::PlatformIsChildOfLeafIncludingIgnored
- content::BrowserAccessibility::CanFireEvents
- content::BrowserAccessibilityManager::OnAccessibilityEvents

This was caused by firing OnNodeWillBeReparented rather than
OnNodeWillBeDeleted. The node was not un-mapped, but the AXNode was
deleted in DestroyNodeAndSubtree, causing a UAF crash.

* Removed IsPotentiallyReparentedNode and the set it tracked because
  PendingStructureChanges better captures this state.
* Rewrote IsReparentedNode so it can detect if a node is expected to
  be reparented after all updates have been applied.

Bug: 1030531
Change-Id: I82d53f2e16b42b6e8084989e5995a95dace072d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949674
Commit-Queue: Adam Ettenberger <adettenb@microsoft.com>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#723435}

Fuchsia uses ICU rather than POSIX functions for Exploded time, but the
ICU time zone was not being set, so this test was always comparing UTC
time to UTC time.
The tests relies on localtime_r() to obtain the local time for
comparison, but POSIX local time functions always use UTC on Fuchsia so
the test must manually account for the time offset.

time_exploded_icu.cc::CreateCalendar() is removed.

Bug: 985946
Test: TimeTest.LocalTimeT fails if the |is_local| check in
Change-Id: I69701c37f5eea1eedd5020d46a2401818e73da16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952524Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723434}

This CL removes a conditional that defends against a message reordering
bug, but introduces a target confusion, and hence message loss, in the
DevTools front-end for certain navigations (the test
oopif-elements-navigate-out-extra-info.js
exposes the bug).

We expect these tests to flake and expose the reordering bug, so we can
fix that one next.

Bug: chromium:1030329
Fixed: 1030329
Change-Id: I0f14d6dcfe4047ff252fa1b4dd956f4258e4e45b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948898
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723433}

Readonly storage buffer is fully implemented in Dawn. We should
enable the support for related enum.

BUG=dawn:180

Change-Id: I13ba9b61757b8c1e7f612c93f34947c510663cbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957744Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Yunchao He <yunchao.he@intel.com>
Cr-Commit-Position: refs/heads/master@{#723432}

This CL changes the way we process incoming SyncEntities when decryption
is pending. After the change:
 - PopulateUpdateResponseData() early returns and does not populate
   anything if decryption is pending.
 - ProcessGetUpdatesResponse() then stores the original SyncEntity
   instead of the previous (partially) populated UpdateResponseData.
 - DecryptStoredEntities() gets much simpler because it can now reuse
   PopulateUpdateResponseData() and does not have to duplicate the
   decryption logic.

As a result this CL reconciles all bookmarks adaptations into a single
place in PopulateUpdateResponseData().

This CL does not introduce any behavioral change.

Bug: 1007199
Change-Id: I5ebbfcbaf5dd6bd677aba1697e7ee8d8cd08d75f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827427
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723431}

Send a localized string that includes the selection state to
the VoiceOver announcement API.
VoiceOver will speak the string and render on a Braille display.

Bug: 939526
Change-Id: I4aedd89bc4b7c99133afd9ca99eeddfe90f771c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953286Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723430}

This category is chosen because it was found to be relevant to investigation of
an ongoing bug.

Bug: 1017889
Change-Id: I674a72bdf07529df33535149e57529c4bf9e0a4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959611Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Oliver Li <olivierli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723429}

https://android.googlesource.com/platform/external/perfetto.git/+log/49d99fe889d2..39a8168c4ee5

git log 49d99fe889d2..39a8168c4ee5 --date=short --first-parent --format='%ad %ae %s'
2019-12-10 primiano@google.com Merge "Fix GitHub repo links in docs"
2019-12-10 khokhlov@google.com Merge "trace_processor: fix tests in Chrome on Android"
2019-12-10 fmayer@google.com Merge "Convert time of heap snapshots."
2019-12-10 lalitm@google.com Merge "trace_processor: allow comparisions between doubles and ints"
2019-12-10 hjd@google.com Merge "Replace lite-server with serveit clone"
2019-12-10 fmayer@google.com Merge "Make "Perfetto CI" banner clickable."
2019-12-10 primiano@google.com infra: fix regex for mirror bot and update docs
2019-12-10 primiano@google.com Merge "infra: update git mirror bot to point to new github url"
2019-12-10 lalitm@google.com Merge "trace_processor: fix null dereference in ref_type mapping"
2019-12-10 khokhlov@google.com Merge changes I93bf64ce,Ib30d867e,Iab2e2b59,I4b7109d2,I511b1782, ...
2019-12-09 lalitm@google.com trace_processor: migrate slice table to new database tables

Created with:
  gclient setdep -r src/third_party/perfetto@39a8168c4ee5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:135177627
Tbr: perfetto-bugs@google.com
Change-Id: Ia49733b26e3cc4afb649da2a3526069c96fe830b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960489Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#723428}

This CL adds an overflow check to {buffered_amount_} in RTCDataChannel.

Here is some background about why I created this CL:
We (V8 team) prepare ArrayBuffers to be bigger than 4GB. Therefore we
changed the size field to size_t. Now we are changing all uses of
ByteLength to be able to deal with size_t, either by accepting a size_t,
or by throwing an exception if the size is too big.

The size of an ArrayBuffer is added to {buffered_amount_}, which is of
type {unsigned}. Therefore with a big enough ArrayBuffer an overflow
could potentially happen. I thought that if I already add an overflow
check for potentially too big ArrayBuffers, I could add the overflow
check everywhere.

R=guidou@chromium.org

Bug: chromium:1008840
Change-Id: I96385a52a357df1999c951c00307aea751e7a1fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953727Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723427}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome

BUG=762641
TBR=chrome-os-gardeners@google.com

Change-Id: Ibc206536ce3b72bda7e7e8ac4c99142a40659e2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959612Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#723426}

Removes unused kNaClLoader (was PROCESS_TYPE_NACL_LOADER)
from Windows as these are in fact Ppapi (PPAPI) sandbox types.

Removes unused values from SandboxType enum and replaces default cases.

SandboxType is not used for iteration so these boundary values are removed
from the SandboxType enum.

The kInvalid SandboxType is retained as it is used as an error case in
a couple of places. It might be possible to remove this in the future.

This removes default cases from switch statements where it might make
sense to have a notification in future when new sandbox types are added.
In these cases the default case is replaced with all otherwise
unchecked cases, so retaining the existing behavior.

Change-Id: I76ffc8ae617f3f8fa9aa68236551ebcfa4cce32f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938076Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723425}

AppInstance updates will be used to determine app usage time.

Bug: 1015658
Test: AppServiceWrapperTest
Change-Id: Idcb0232ecf80f02ac3fc3f1a3c2b7cb468db5152
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958894
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723424}

Was iso-latin-1-unix according to Emacs and wasn't utf-8 according to
python. This commit changes the offending \x92 to a real '.

Change-Id: Ia40e0ef1332ab7dbb3ce50419404320ed6dcfc5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956278
Auto-Submit: Alex Gough <ajgo@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723423}

Some Android flavors have less fonts than
the numbers assumed (IoT cases). Change
this to test for 10.

Bug: b/143273186
Test: Local test run.
Change-Id: If4c23ee990f1de28aceb2bf768dc815f4693ef7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957207Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Brett Kilty <brettk@google.com>
Cr-Commit-Position: refs/heads/master@{#723422}

https://dawn.googlesource.com/dawn.git/+log/ff8b3f439723..f15fc26d5bf5

git log ff8b3f439723..f15fc26d5bf5 --date=short --first-parent --format='%ad %ae %s'
2019-12-10 rharrison@chromium.org Rolling 4 dependencies

Created with:
  gclient setdep -r src/third_party/dawn@f15fc26d5bf5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I74ba296e3592eee0d245d9af0fb3ac55436a05e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960487Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#723421}

../../chromecast/media/cma/backend/android/java/src/org/chromium/chromecast/cma/backend/android/VolumeMap.java:173: warning: [MultiVariableDeclaration] Variable declarations should declare only one variable
        float dbLeft = dbMin, dbRight = dbMin;
              ^
    (see https://google.github.io/styleguide/javaguide.html#s4.8.2.1-variables-per-declaration)
  Did you mean 'float dbLeft = dbMin;float dbRight = dbMin;'?
1 warning

Bug: b/145737017

Change-Id: I78ce6063a36e86a6959e013a480a863792bfdc49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959797
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Auto-Submit: Michael Spang <spang@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723420}

googletest will no longer support empty prefix
for parameterized INSTANTIATE_TEST_SUITE_P.
Adding "All" prefix to existing empty prefix test suites.

This CL was uploaded by git cl split.

R=gogerald@chromium.org

Bug: 1023677
Change-Id: I8ab6717f2361191bf63b2cf74d0e092bdcbf65f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957552
Auto-Submit: Ilia Samsonov <isamsonov@google.com>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723419}

It's easy enough to know and set the process type statically early on in
startup, and not require callsites into the LibraryLoader to know which
process they're running in if they otherwise don't care.

Bug: 783819
Change-Id: I03e2a34a3e78cd06d5ceb1b958c4b2c15c802e99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944313Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723418}

Issue:
in PageInfoController, holding mContext is dangerous, because
WebContents' reparenting could cause mContext and mWindowAndroid to be
mismatched.

Change:
Remove mContext as a member of PageInfoController. Instead, get context
from mWindowAndroid when needed.

Bug: 999196

Change-Id: I373a1babdcb321b7d135f9eb22544e0b61fa675d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960485Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723417}

Change-Id: Ice42c58f9e23beefcf7ad11220844211d679f717
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959801
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723416}

The callback given to it is run once, with an id.

R=avi@chromium.org
TBR=servolk@chromium.org

Bug: 1007763
Change-Id: I5ecac2ffc1cf72caf690f8540bcc40e3b9aac00f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960546Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723415}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ab09a60e40ad..a58b81f6720d


Created with:
  gclient setdep -r src-internal@a58b81f6720d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: Iafd31a716fa38a69cf287a97bca2451558622c17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959543Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#723414}

Before this CL, when FCMInvalidationServiceBase triggered an InstanceID
(aka client ID) deletion, it didn't actually clear its |client_id_|
member, and it didn't propagate the deletion to its clients (via the
InvalidatorRegistrar).
This CL fixes these two things.

This *probably* didn't really have consequences in practice: Only the
SyncEngine actually used the InstanceID (for reflection blocking), and
in this case it anyway gets shut down as well. Still, let's not keep
obsolete IDs around.

Bug: 1028761
Change-Id: I5c09aff83845bebab1b4fb6b7d8fd963ae91501f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954475
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723413}

Fixes XRObjectSpace::MojoFromNative() returning incorrect (inverted)
results. Fixes XRSession::CreateAnchor() incorrectly assuming that
passed in initial pose is expressed relative to mojo, and creating
resolver too early in the method.

Other minor refactorings:
- XRHitTestResult::getPose() - no functional changes, clarified naming
- XRObjectSpace now assumes that T has MojoFromObject() method
- Changed XRPlane and XRAnchor - renamed poseMatrix() to
MojoFromObject() to match the changed expectations in XRObjectSpace.

Fixed: 1032070, 1031684
Change-Id: I5aeefec31c2f501c56cff5b419af9bdff3eb1159
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958428
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723412}

This builds on previous changes to (finally!) add the correct
static-positions within the NGFlexLayoutAlgorithm.

This takes into account the main-axis, and cross-axis
alignment/justification - and converts it to the correct
inline/block axis.

As we may not know the final block-size when we encounter an
OOF-positioned node, we "adjust" this within the fragment builder once
known.

This is important for block-end/block-center aligned OOF-positioned
nodes.

Bug: 845235
Change-Id: I45c89ae1f676ec06d742b86e4b744cfc3dbe6f75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841245
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723411}

To reduce usage of TabModelList, this CL removes all but two code
paths in the new_tab_page_uma:: helpers that map a browserState to a
single active WebState.

new_tab_page_uma::RecordAction now takes a WebState by default. In cases
where there isn't one to pass in, the deprecated (prior) version of the
function uses TabModelList to find the active WebState of the TabModel
associated with the current BrowserState.

The two remaining code paths for RecordAction that don't pass a WebState
are from ReadingListCoordinator (which doesn't yet have a Browser passed
in) and HistoryTableViewController (likewise).

Bug: 1032550
Change-Id: If0eee5c2fceed08357d806e973ce53e027d6ea2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960308
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723410}

Update the articles suggestions' header to show a Google branded title
when a non-default search engine is selected. This is to make it clear
to users that even though the search engine is different, the suggested
content is still being provided by Google.

Bug: 1031288
Change-Id: I550176d03ef9d9eeff442157a780467e5b2bc6cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959628
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723409}

TBR=kojii@chromium.org

Bug: 1025630
Change-Id: Iece505df711ba7d9c4b259df1bff81954781840d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959845Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723408}

Creation of the Android SharedPreferences object causes disk I/O.
Because there are execution paths that need that object on the UI thread
it makes sense to prewarm it in parallel during initialization.

Before creating a mechanism for off-UI-thread initialization work, just
initialize the object directly (with StrictMode violations suppressed).

Bug: 1029524
Change-Id: Ib2ea9e3ce9f4a84aceace95ce058dd0eeadf063f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959032Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723407}

Since the VizDisplayCompositor feature is always enabled now we no
longer need tests for the path when it's disabled. Also don't enable the
feature with ScopedFeatureList since it's already enabled.

Bug: 844469
Change-Id: Id550e68dfc5aca25c265794a4557ad023cb41690
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960391
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723406}

googletest will no longer support empty prefix
for parameterized INSTANTIATE_TEST_SUITE_P.
Adding "All" prefix to existing empty prefix test suites.

This CL was uploaded by git cl split.

R=estark@chromium.org

Bug: 1023677
Change-Id: I727b8a7caa8316441c9f496699db2312b8e988fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957551
Auto-Submit: Ilia Samsonov <isamsonov@google.com>
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723405}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f880a70cb757..d9b33e92da7f

git log f880a70cb757..d9b33e92da7f --date=short --first-parent --format='%ad %ae %s'
2019-12-10 aerotwist@chromium.org Migrates emulation/ to esm

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@d9b33e92da7f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1006759
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I65805d86f9a40ce9bce0112e9cd82c9d7640273a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959539Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#723404}