GitLab

https://skia.googlesource.com/skia.git/+log/c657fa6d44d3..db1e5c6474c1

$ git log c657fa6d4..db1e5c647 --date=short --no-merges --format='%ad %ae %s'
2018-02-27 kjlubick Port 3 API fuzzers to be oss-fuzz friendly
2018-02-27 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 6ae51611c..06a87ec83 (3 commits)
2018-02-27 angle-skia-autoroll Roll skia/third_party/externals/angle2/ b52fac03f..6ae51611c (1 commit)
2018-02-26 bsalomon Suppress CopySurface test on Nexus 7

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=benjaminwagner@chromium.org

Change-Id: I82764f84cf4d3d59e232caaedfd22c8d072c461f
Reviewed-on: https://chromium-review.googlesource.com/939441
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#539483}

This CL adds the new assets to be used for the UI refresh and use them.

Bug: 807284
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6cd1d1132a4552296fdefbcd488652a7cfd59ca2
Reviewed-on: https://chromium-review.googlesource.com/939394
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539482}

Since the SynchronousCompositorProxy (base class of SynchronousCompositorMojo)
holds onto a reference to the InputHandlerProxy it must be destroyed
before the InputHandlerProxy is destroyed.

BUG=816538

Change-Id: I990b5a427970b28219464267de41a28b1fabb5d0
Reviewed-on: https://chromium-review.googlesource.com/938485
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539481}

a patch[1] which is to fix jumbo build error was merged.
but g_instance_for_testing still keep in memory_dump_manager.cc.
that variable name looks like generic name which is some potential
to make same issue.
so it should be rename in order to void the same problem.

[1]https://chromium-review.googlesource.com/938821

Bug: 775547
Change-Id: Id7f3fc30a8118fb6f24f0e920ab530f44a27fa82
Reviewed-on: https://chromium-review.googlesource.com/938803Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539480}

This CL adds an occlusion state to allow delegates to be notified when
a window goest from hidden <-> occluded.

Bug: 668690
Change-Id: I3b16a699ab5d8e6050332e5146007766b0c3949f
Reviewed-on: https://chromium-review.googlesource.com/927205Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539479}

Bug:816647
Change-Id: Icbf574609b6aa1be953c5388407e5a8d4f587808

TBR=rockot@chromium.org

Change-Id: Icbf574609b6aa1be953c5388407e5a8d4f587808
Reviewed-on: https://chromium-review.googlesource.com/938368Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539478}

When one or more programs that injects code into Chrome are detected,
this subpage displays a list of actions that the user can take to either
remove those programs or follow a link to upgrade or learn more.

This card is only active if the ModuleDatabase and the
ProblematicProgramsWarning features are enabled.

Bug: 717696
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ibaff081d0f424080b2dba31cf6c5f2aaeab62214
Reviewed-on: https://chromium-review.googlesource.com/924522
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539477}

BUILD.gn file changes will be made in a follow-up.

TBR=jam@chromium.org,mek@chromium.org,jbroman@chromium.org

Bug: 809983
Change-Id: I19a8a1bd5d9126328cb6e7f478fd92eb44150434
Reviewed-on: https://chromium-review.googlesource.com/939206Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539476}

Since ClearBrowsingDataCommand is no longer used (removed by
http://crrev.com/c/934501), there is no need to support the
deprecated -chromeExecuteCommand:.

Remove it and all the legacy support (GenericChromeCommand,
old #import, ...).

Bug: 738881
Change-Id: I004e548733550824aca4e9f5d0609e7172d2da1a
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/934270
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539475}

An installing service worker can call importScripts('dupe.js');
importScripts('dupe.js');. The first call should install the script, and
the second call should read the installed script. This CL implements
that. We detect if the script is already installed, and if so we use
a simple URLLoader that reads the installed script.

This fixes WPT test import-scripts-resource-map.https.html.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I30c7532cedffaad3d62b12239ab230a0708bb49c
Bug: 814583
Reviewed-on: https://chromium-review.googlesource.com/934024
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539474}

The PushMessagingManager currently maintains its own subscription cache
in the Service Worker database, keeping track of the subscriptions it
thinks are valid. This means that the PushMessagingManager assumes that
the subscription is valid.

There are cases where the underlying push service, in our case Google
Cloud Messaging implemented through our GCM Driver, invalidates a
subscription. We need to find out about that when it happens, so change
the PushMessagingManager to *always* attempt to create a subscription,
upon which we rely on the push service client to return the same
information given the same input.

The GCM Driver has its own cache, so in the vast majority of cases these
calls won't hit the server. They will, however, on occasion.

Bug: 799483
Change-Id: I715c6f2eb8296b4512b6b7e9e31734ce9f254744
Reviewed-on: https://chromium-review.googlesource.com/932401
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539473}

The various callers of
BrowserNonClientFrameView::UpdateProfileIndicatorIcon() had
mostly-duplicated logic every where, which merited a refactor
in order to unify the common code in one place.

BUG=815031

Change-Id: I3ea46d9b0fca3eed4d491b5d5bf1da9289bd4c8e
Reviewed-on: https://chromium-review.googlesource.com/935882
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539472}

BUG=723764

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7284ca9ec0d291f51e13b9724d1e02aaedda870f
Reviewed-on: https://chromium-review.googlesource.com/936363
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Shenghua Zhang <shenghuazhang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539471}

This CL moves a TRACE_COUNTER1() counting input_buffers_.size()
from its current position to next to |input_buffers_| actions
(i.e. where it grows or shrinks).

It also renames s/GetInputBuffer_Locked/GetCurrInputBuffer_Locked/
to better reflect what the method does.

Cosmetic changes:
- removes .get() on checks for |curr_input_buffer_|
(bc unique_ptr<> has an operator boolean()).
- Removes unnecessary curly brackets.
- Removes superfluous comments.
- Escapes some variable names in comments.

TEST= simplechrome w/ crosvideos and v_d_a_unittests on soraka

Bug: 717265
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5b3d51fd1509f8d0ce87487a44d6c7a77b4a253b
Reviewed-on: https://chromium-review.googlesource.com/934403
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539470}

This CL adds support for the "back" and "forward" buttons (located on the side
of many mice) to the Linux and Windows hosts. macOS does not seem to have very
consistent support for these (the documentation only states that mouse buttons
beyond the standard three should be passed to the CGPostMouseEvent function
"in USB device order", which is driver-specific) so I haven't included support
for macOS in this CL.

Note that for this to work, Chrome's --enable-features="ExtendedMouseButtons"
flag must be used, at least until the feature is enabled by default.

Change-Id: I1a890c590b26da8c5f11185a2be68a22c7f06ec2
Reviewed-on: https://chromium-review.googlesource.com/938754Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539469}

Bug:816646
Change-Id: I9793d98d321fa3e5685d275f2e7d4c7d98fd1ddb

TBR=arthursonzogni@chromium.org

Change-Id: I9793d98d321fa3e5685d275f2e7d4c7d98fd1ddb
Reviewed-on: https://chromium-review.googlesource.com/938365Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539468}

BrowsingDataRemovalController is just a thin wrapper around
BrowsingDataRemover. As BrowsingDataRemover is a KeyedService
there is no need for the wrapper anymore.

Convert BrowsingDataRemovalController unit tests to instead
test BrowsingDataRemoverImpl (and fix a potential use after
free of a TaskRunner in the tests).

Bug: none
Change-Id: I59b0da2198f6c0375977436c6bfebc37398d7cf2
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/934502
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539467}

Instead of WindowPortMus and WindowPortLocal managing the FrameSinkId of
a Window separately, manage it in Window itself.

BUG=none

Change-Id: I9fea68af4cc8b2c185fd1ff26e5be5d965b3ab90
Reviewed-on: https://chromium-review.googlesource.com/930663Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539466}

This CL adds tests for:
* Partial write (insufficient disk space to export)
* Export should be offered only if there are passwords
* Export Passwords menu item opens the export dialog.
* The Try Again button restarts the export
* The start and error dialogs are dismissible.

Bug: 815137
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib8d971ac8eda5824ea80c397bd13a26a36a66277
Reviewed-on: https://chromium-review.googlesource.com/934823
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539465}

* Uses early-return style to avoid code reaching to end even if
  fonts are found in early stages, primarily for the readability.
* Uses AtomicString(const UChar*) ctor instead of wcslen(). These
  are the only place that use wcslen in WebKit/ directory.

Bug: 561873
Change-Id: If403eafaa57a9f00eddf053bb8c6fb1d1343a4a2
Reviewed-on: https://chromium-review.googlesource.com/938687Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539464}

Makes the names of a couple of functions clearer.

Change-Id: I8c7923f62b691b3cf93642e54f4afd8cb257c01f
Reviewed-on: https://chromium-review.googlesource.com/937924Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539463}

Bug: 813905
Change-Id: I7a0954620c62c7553397bdd13250f598589afb33
Reviewed-on: https://chromium-review.googlesource.com/928504Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539462}

BUG=696454, 802007

Change-Id: I32982c6c34a24f67cfbb7c8fe07b943efaf90822
Reviewed-on: https://chromium-review.googlesource.com/924373
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539461}

Much like for geometry attributes - of which these are a subset. Also
push the InvalidationGuard into the invalidation function.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ib9254d8ad930ef132c8074a7636eb57f18ae22d5
Reviewed-on: https://chromium-review.googlesource.com/932122
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539460}

This takes a url to an icon, and downloads it, in memory. It's not
currently storing it in disk, or resizing it, or even allowing selection
from a list of icons. This functionality will be added later.

And a unit test to verify expected behavior.

Bug: 813564
Change-Id: Ia00945d4f0c5f2b4bccd2fb03dcf289b265af110
Reviewed-on: https://chromium-review.googlesource.com/932121
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539459}

No change to logic.

Bug: None
Change-Id: I3eb4fc82108488ba87b40323e0afa643d9e96e86
Reviewed-on: https://chromium-review.googlesource.com/939003Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539458}

This update is required for work that is underway related to management
of Chrome browsers for enterprise users.

The google_update_idl.idl file was originally provided by the Google
Update team. It has been modified as described in the README.chromium
file in this CL.

The change was tested with Chrome-branded builds with target_cpu set to
"x86" and "x64". I followed these steps to make sure that this change
does not break Chrome updates.

1. Manully set the version of Chrome in src/chrome/VERSION to a version
   prior to that which is currently served on the Dev channel.
2. Compile with is_chrome_branded=true and target_cpu set to one of
   "x86" or "x64".
3. Install the build as a Dev-channel Chrome using setup.exe on a 64-bit
   Win10 machine.
4. Navigate to chrome://help and make sure that the update process works
   as expected.

Bug: 796270
Change-Id: I6962b8874a7e825d41834860de0eb0fe92f5a6e3
Reviewed-on: https://chromium-review.googlesource.com/924474
Commit-Queue: Ali Tofigh <alito@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539457}

The conversion is straightforward, getting the email address of the
primary account from IdentityManager rather than SigninManager and
AccountTrackerService.

Straightforward unittest conversions are also made.

NOTE: This CL was not tested manually as I don't know how to exercise
this functionality.

TBR=sdefresne@chromium.org

Bug: 809435
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7e145538b9e8634326a409c812b03a04c0254b05
Reviewed-on: https://chromium-review.googlesource.com/913390Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539456}

Create base/task/task_scheduler and base/task/sequence_manager
directories, add OWNERS files and README.md stub.

R=gab@chromium.org
BUG=783309

Change-Id: Ic30cfac8ce71e5f0553fcfb6c95e05750d15d265
Reviewed-on: https://chromium-review.googlesource.com/934444
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539455}

Screenshot: https://drive.google.com/file/d/1H0fFnEPwxOtIwXQ_XOyChjaR-V88klKq/view?usp=sharing

Bug: 803191
Change-Id: Ifdf428b592eb2c7bd497a40044e06a74338a247e
Reviewed-on: https://chromium-review.googlesource.com/938631Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539454}

Static WebView methods are implemented using the class
WebViewFactoryProvider.Statics, in this CL we implement the
corresponding class for the WebView support library.

Bug: 816506
Change-Id: I3909a8f1b78a79ed06895da0611ca643231e1716
Reviewed-on: https://chromium-review.googlesource.com/939391Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Gustav Sennton <gsennton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539453}

RenderThreadImpl::ClearMemory has been purging only font cache in Skia.
But, it would be good if we purge more cache data in RenderThreadImpl::ClearMemory,
because it has mainly called under out of memory. I found SkGraphics::PurgeAllCaches
purges more cache data, so this CL calls it instead of calling SkGraphics::SetFontCacheLimit.

    void SkGraphics::PurgeAllCaches() {
        SkGraphics::PurgeFontCache();
        SkGraphics::PurgeResourceCache();
        SkImageFilter::PurgeCache();
    }

Although I add a new test to measure if RenderThreadImpl::ClearMemory purges memory,
it's not completed yet. But, this CL can be covered by tests for MemoryPressureListener.
(i.e, RenderWidgetHostViewAuraTest.DiscardDelegatedFramesWithMemoryPressure.)

Bug: None
Change-Id: I6d702e02c84a04c98489bc3f20b52f55beed1452
Reviewed-on: https://chromium-review.googlesource.com/910732Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#539452}

https://chromium-review.googlesource.com/904992 added a new
AutofillClient::GetIdentityManager() interface. That CL mistakenly
had the ChromeAutofillClient and ChromeAutofillClientIOS implementations
return the IdentityManager instance associated with the current Profile.
It should actually be the IdentityManager instance associated with the
*original Profile* (/ChromeBrowserState) to be parallel with those
clients' constructions of the ProfileIdentityProvider instances whose
usage IdentityManager is replacing in //components/autofill.

Note that I verified that these are the only client implementations that
need this fix:

- AWAutofillClient returns nullptr for both the IdentityProvider and the
IdentityManager.
- WebViewAutofillClient (in //ios) doesn't use the original
  ChromeBrowserState for anything, I assume because it doesn't have
  incognito.

This bug was uncovered by the UBSanVptr bot. Thanks, UBSanVptr bot!

Bug: 798413, 814308
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I3e87888bc622204a29b4f9d3990fa39e8b165eb3
Reviewed-on: https://chromium-review.googlesource.com/928654Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539451}

This CL updates the promo strings in the user menu for
turning on sync. A new string is added for the case
when there are signed in web accounts.

Bug: 814979
Change-Id: I028514d8894a2f8372784f7ff3a69c34c0573bf0
Reviewed-on: https://chromium-review.googlesource.com/934286
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539450}

Plumbs through some additional WebRequestInfo fields in the Network
Service path to enable <webview> WebRequest (and declarative WebRequest)
APIs to work as expected.

Bug: 721414
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I78eda1c4f286623f1d82e3e5be60dd9beff517bc
Reviewed-on: https://chromium-review.googlesource.com/938675Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539449}

The CL:
1. Add BUILDFLAG::ENABLE_SPELLCHECK in aw_main_delegate.cc
2. Remove redundant include spellcheck_build_features.h

Bug: None
Change-Id: Idc77171292fd0515240e52d86ac83fbdb4744534
Reviewed-on: https://chromium-review.googlesource.com/939221Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539448}

This bubble is shown to a user when a relaunch is needed for an update
and the user's administrator has set the RelaunchNotification policy to
1 (recommended). The bubble is shown each time the UpgradeDetector moves
the UpgradeNotificationAnnoyanceLevel to LOW, ELEVATED, or HIGH; and is
shown on a recurring schedule while the level is at or above HIGH.

BUG=511300

Change-Id: Idd235ec0a3bef3b24484ab5cd40cb7b2a28bf450
Reviewed-on: https://chromium-review.googlesource.com/906774
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539447}

With the introduction of the 3p removal trigger, the concern is that
subtitles make the card too heavy, so we are simply removing them.

I will also send a follow-up CL to remove subtitle from the
"Reset settings" trigger. Not sending here, because I want to add other
people on that change for discussion.

Bug: 816666
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iae7c588c72f109e676212ceaf858177b21b22f5d
Reviewed-on: https://chromium-review.googlesource.com/938623
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539446}

We used OriginalStyleForLayoutObject which doesn't update animations or
stacking context.

This is a reland of [1] which was reverted because the added unit test
failed on Android because option elements do not create layout objects
with the platform's theme.

[1] https://crrev.com/4b96f800bd6d6c017ac14ab19e7b341c1a6efcc6

Bug: 813348, 813439, 813836
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I55d5f944e86ccaa326f01caa7f48606021f8df14
Reviewed-on: https://chromium-review.googlesource.com/939163
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539445}

The change makes SessionsSyncManager smaller which is good for our
upcoming changes to introduce an alternative implementation based on
USS.

Bug: 681921
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6e8ed8b3b588b6a8da5e9b6b90be6ed9f479b04c
Reviewed-on: https://chromium-review.googlesource.com/918863
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539444}