- 26 Jul, 2019 11 commits
-
-
Istiaque Ahmed authored
Holding onto an Extension using scoped_refptr is troubling with ExtensionBrowserTest::LoadExtension when the extension might get uninstalled right away. ASAN builds correctly shows this as UaF error. Fix this by holding a raw pointer to Extension*, this should be OK as we only use that for pointer equality check. Bug: 985936 Change-Id: I1cd188d4be7814dd013a929691748cb3e7f900b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717243Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#681093}
-
tby authored
This adds the chrome-side of user interactions with non-app results in the CrOS launcher. See go/cros-launcher-search-ranking-logging for more details. Bug: 972817 Change-Id: I602cd982a6972df93bdb920cc1f1bc793f6ab9e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706592 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#681092}
-
Aleks Totic authored
Bug is: <container overflow:scroll> <target transform:scale(1)> Initially, container's scrollbars are disabled. When target changes its scale and grows outside of container, scrollbars were not updated. Fix #1 is to call UpdateScrollbarEnabledState. This resulted in scrollbars being painted, but not clickable. Fix #2, calling UpdateScrollableAreaSet makes scrollbars clickable too. Fix #2 was an educated guess. Bug: 926167 Change-Id: I02454047c87aaecede9c56db1c02bbd1b21b15c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704218 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#681091}
-
Hiroshige Hayashizaki authored
As we've already merged `target_protocol` and `origin` into one `origin` value in underlying JavaScripts, this CL applies this conversion also in generators. Generated files will be updated after some more changes, not now. Also, changes needed in JavaScripts to handle new generated values are not included in this CL and will land later. spec.src.json changes are made by: originTypeConversion = { "same-origin-http": "same-http", "same-origin-https": "same-https", "cross-origin-http": "cross-http", "cross-origin-https": "cross-https" } for test_expansion in sum([s['test_expansion'] for s in spec["specification"]], []) + spec["excluded_tests"]: if 'target_protocol' in test_expansion: protocols = test_expansion['target_protocol'] origins = test_expansion['origin'] if protocols == '*': protocols = ['http', 'https'] if origins == '*': origins = ['same-origin', 'cross-origin'] if isinstance(protocols, unicode): protocols = [protocols] if isinstance(origins, unicode): origins = [origins] new_origins = [] for protocol in protocols: for origin in origins: new_origins.append(originTypeConversion[origin + '-' + protocol]) if len(set(new_origins)) == 4: new_origins = u"*" if len(new_origins) == 1: new_origins = new_origins[0] test_expansion['origin'] = new_origins del test_expansion['target_protocol'] spec['test_expansion_schema']['origin'] = [ "same-http", "same-https", "cross-http", "cross-https" ] del spec['test_expansion_schema']['target_protocol'] Bug: 906850 Change-Id: Iaf4af8c0b599f9cc843244658a2db7577dddeb4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717470 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#681090}
-
Joey Arhar authored
This clears network overrides for throttling and offline when InspectorNetworkAgent is closed in order to prevent navigator.onLine from returning "false" after DevTools is closed. This unifies the behavior we currently have for individual requests when we set offline because individual requests aren't throttled after DevTools is closed because we stop setting a throttling profile id on requests because an InspectorNetworkAgent instance is required to set the id. Bug: 972337 Change-Id: I83dee7147314f54441cd335565bc872a64a3ac3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652800 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#681089}
-
Julian Watson authored
BUG=chromium:987127 Change-Id: I5941380c70786e7c8d9f3b6c2d4a992944775a53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715170Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#681088}
-
Clark DuVall authored
These are from comments in http://crrev.com/c/1716098 Bug: 824840 Change-Id: Id7375a24d84af8a06c0bea6a19e82bed2acfb95e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719573Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#681087}
-
Lutz Justen authored
Adds the definition of the UMA stats reported by the Kerberos system daemon, see https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1704294. BUG=chromium:983950 TEST=None Change-Id: I828318782550554978e7a42bb31d696298066f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704761 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#681086}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/519a25f2a6a9..bf99f644ae32 git log 519a25f2a6a9..bf99f644ae32 --date=short --no-merges --format='%ad %ae %s' 2019-07-25 chrome-bot@chromium.org Update config settings by config-updater. 2019-07-25 miahsanchez@google.com vm_unittest: testing WaitForBoot() 2019-07-25 cjmcdonald@chromium.org chromeos_config: Remove amd64-generic-goma-full builder Created with: gclient setdep -r src/third_party/chromite@bf99f644ae32 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I3bb304d933f2b97f42cb9f97e5d143a755101809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719277Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681085}
-
Drew Stonebraker authored
The feature has been fully launched, so remove the feature flag and the conditions. Bug: 987712 Test: none Change-Id: I87de2af8976a70d44790b34ad97fa7fefba49b64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719465Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Drew Stonebraker <stonebraker@chromium.org> Cr-Commit-Position: refs/heads/master@{#681084}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5cd13415882e..2bac7da1349c git log 5cd13415882e..2bac7da1349c --date=short --no-merges --format='%ad %ae %s' 2019-07-25 steveanton@webrtc.org Optimize sending the MID and (R)RID header extensions 2019-07-25 mbonadei@webrtc.org Delete rtc_tools/barcode_tools. 2019-07-25 mbonadei@webrtc.org [readability-container-size-empty] Use empty() to check for emptiness. 2019-07-25 titovartem@webrtc.org Migrate 2 test with Vp9 SVC test on PC framework 2019-07-25 mbonadei@webrtc.org Add rtc_ prefix to the event_log_visualizer directory. 2019-07-25 srte@webrtc.org Fix for potential out of bounds reading in rtcp::RemoteEstimate parser. 2019-07-25 mbonadei@webrtc.org Fix some typos. 2019-07-25 sprang@webrtc.org New pacer: make FlexFEC and Video priority equal 2019-07-25 mbonadei@webrtc.org Switch neteq_rtpplay into an executable. Created with: gclient setdep -r src/third_party/webrtc@2bac7da1349c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:987507,chromium:None,chromium:None Change-Id: Ib3f166c3577a0f5f91c1b110c0e393b615f11721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718614Reviewed-by:
-
- 25 Jul, 2019 29 commits
-
-
Min Chen authored
Bug: 987003 Change-Id: If690111289c7ab6f03c94c7363e488641b8743dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716957Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#681082}
-
Shakti Sahu authored
For incognito profiles, we don't load history db. So we should not wait for history to be loaded and send the OnManagerInitialized callback as soon as the in-progress cache is ready. Without this initialization notification, the observers will fail to function correctly. TBR=qinmin@chromium.org Bug: 987535 Change-Id: Idf960e2b60dbec302b8be847ba0b784dfa884cf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718776 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#681081}
-
James Cook authored
Copy search_page_test.js to os_search_page_test.js. Update to use async / await. Bug: 967908 Test: browser_tests Change-Id: I3a780f72a0a4d9bdfc83c5b577c07daac66b67f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719147 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
Bug: 906850 Change-Id: I486eef6697a7ef5ff1360549321236add8e1c75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717499 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#681079}
-
Rakesh Soma authored
Orignal change was made in : https://chromium-review.googlesource.com/c/chromium/src/+/1190583 Bug: 984867 Change-Id: I8ea6b0a08372a2da4004f35f83a373735efc5e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709703Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Tien Mai <tienmai@chromium.org> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#681078}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1a460a20102b..6129e06e7f87 Created with: gclient setdep -r src-internal@6129e06e7f87 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None Change-Id: I5177468b40cf80b368b4e4699c6c239a97e40410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719276Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681077}
-
Hiroshige Hayashizaki authored
To use common structures and names in referrer-policy and mixed-content tests, this CL - Renames `referrer_policy` to `delivery_value`, and - Moves it under `test_expansion`, because in mixed-content tests `delivery_value` can be different among multiple `test_expansion` entries under a single `specification` entry. Accordingly, `referrer_policy_schema` is moved to `test_expansion_schema`'s `delivery_value`, and related checks in spec_validator are removed. Generated files will be updated after some more changes, not now. Bug: 906850 Change-Id: I28beb09ab2eb4c69ec598de415d81cd1c8f77765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717592Reviewed-by:
-
Misha Efimov authored
Native C API functions are already exported from the libcronet.so file. Change-Id: I3dd65103aa8ad7c9e48f08e7a1cbdcffeeac0fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718468 Commit-Queue: Misha Efimov <mef@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#681075}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d30014c6. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" ff9a2993 "[WPT/common/security-features] Sort keys of test config JSONs" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I242de766bb1b5688fe11996db84dabbc6057f8f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719105Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681074}
-
Ahmed Mehfooz authored
We now reduce the number of rows of FeaturePods based on the available height for the system tray. The number of rows can go down to 1, the maximum rows remain unchanged at 3. Bug: 984367 Change-Id: Ia59afeecd357d62042d07ba15b3b40cdf90781ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704039Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#681073}
-
James Cook authored
Specifically, in multidevice settings and Play Store. Bug: 987732 Test: manually paired phone, checked strings Change-Id: I774fb80d26250b219b4dfd255ac88828e693f2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716043Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#681072}
-
Nico Weber authored
This doesn't remove the global CHROMIUM_BUILD define yet, but it removes all references to it. I will remove the define in an (easy to revert, if necessary) follow-up. Depends on https://chromium-review.googlesource.com/c/chromium/src/+/1718785 Bug: 961769 Change-Id: Ibb920d1df7877a596d2d12df3b3ebf1d89d79c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715975 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#681071}
-
James Cook authored
* "Preferred search engine" * "Used by Chrome browser and <device> launcher" http://screen/zTiXifEKNT6 TODO: Style tooltip to spec. We should change all OS settings tooltips to use the same styling. Bug: 978464 Change-Id: If434d82607faaba0278da0a29112e8bd791281d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719268Reviewed-by:
-
Collin Baker authored
A unique_ptr<> was used inside a std::map, but std::map values are already stable in memory. We can directly store TabGroupData values without indirection and still hand out TabGroupData pointers. Bug: 905491 Change-Id: I250b156e56dc400a83374e57e06958fa5f06864f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719446 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#681069}
-
Hiroshige Hayashizaki authored
The values are always `top-level` and not used anywhere. Bug: 906850 Change-Id: Ia89f9b65cac935d65287a702f61f292513ca6189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717487 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Brian Geffon authored
The kernel may not bubble up the close always if you don't specify POLLIN. BUG=chromium:964569 TESTED=tested on dev device Change-Id: I21f54edf12a4dbec1d2b3ba5fef6c78410457338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715898Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Raymond Toy authored
When there are multiple tracks in a MediaStreamAudioSourceNode, the track to use is the first track after sorting the tracks based on a lexicographic ordering of the track ids using code unit values. Feature: https://www.chromestatus.com/feature/5749997033226240 Bug: 984994, 983790 Change-Id: I0c194caa98de1f0283927dc0206219ab7679c86d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706775Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#681066}
-
Hiroshige Hayashizaki authored
To align spec.src.json with other parts of common/security-features/ such as common.js. Generated files will be updated after some more changes, not now. Bug: 906850 Change-Id: I87479bcf8ec6cdbf08e10a38a79885940b51e457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716109 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Toby H authored
This CL sets up the build flags to exclude supervised user code from Linux/Mac/Windows platforms. Bug: 980869 Change-Id: I25a4a64c46a0e8ac6beb4a88d144571180bdc55d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713868 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#681064}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7a6d5b768672..7734ba9a7d52 git log 7a6d5b768672..7734ba9a7d52 --date=short --no-merges --format='%ad %ae %s' 2019-07-25 tsepez@chromium.org Avoid small mallocs for CPDF_Font::FormFactoryIface. 2019-07-25 tsepez@chromium.org Remove unused CFWL_WidgetTP::m_dwRefCount. 2019-07-25 tsepez@chromium.org Mark fxcrt::RetainPtr<>::m_nRefCount as mutable. Created with: gclient setdep -r src/third_party/pdfium@7734ba9a7d52 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Iea95fc25e2947341f6239b4d28f1038f57a6c368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717775Reviewed-by:
-
Yue Li authored
In order to prevent corner cases/timing issue related to session state change, adding a check when showing the opt-in dialog. Bug: 978267 Test: Run existing tests Change-Id: I9f84e5fc90ba8d50407fa44a29749406ae1b2db0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717464Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
To use common names in referrer-policy and mixed-content tests. The final goal is to rename all to `source_scheme` (which is done in https://chromium-review.googlesource.com/c/chromium/src/+/1718991). This CL renames first `source_scheme` to `source_protocol`, just to avoid rebasing in a long chain of commits. Generated files will be updated after some more changes, not now. Bug: 906850 Change-Id: Ic89e60e8a5f2f2780ad416ef189cfc5d1ad1b16e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717115 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Vladimir Levin authored
If we don't have tilings, then we will append a checkerboard quad. In those cases, use scale 1.f to have more stable to-screen-space mapping, eliminating error exaggeration we might get from layer size rounding. See the referenced bug for more details. R=enne@chromium.org Bug: 986110 Change-Id: I8781077c81442466b0e91b71c5d8149a2d2bda79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717917Reviewed-by:
enne <enne@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#681060}
-
Nate Fischer authored
No change to logic, only docs. This updates the class doc for AndroidStreamReaderURLLoader, since the doc was written back when it only supported shouldInterceptRequest. This adds documentation for the known subclasses of ResponseDelegate, to clarify which production cases they actually cover. Test: None Change-Id: Ib04e7dc6a43b548856d5bc2d41d9addabe824029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717440Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#681059}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I4324d438bb053cadc733abe0febb645c06dc0d16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700916Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#681058}
-
Hiroshige Hayashizaki authored
This CL rewrites `opt_in_method` so that both mixed-content and referrer-policy tests uses `delivery_type` and `delivery_value`. Mapping: | Before this CL | After this CL | | opt_in_method | delivery_type | delivery_value | +-------------------+---------------+----------------+ | "no-opt-in" | "meta" | null | | "meta-csp" | "meta" | "opt-in" | | "http-csp" | "http-rp" | "opt-in" | | "img-crossorigin" | Removed | "img-crossorigin" was removed because it was not implemented. Generated files will be updated after some more changes, not now. Bug: 906850 Change-Id: I4ea4571ee1c1312fe8fbc35590548a8021141258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717107 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Nico Weber authored
MEMORY_SANITIZER_INITIAL_SIZE is defined exactly if MEMORY_TOOL_REPLACES_ALLOCATOR is defined, so just use this instead. This reverts https://codereview.chromium.org/357603002/ which split this for deep memory profiler, but we haven't used that in years. While here, also change vector.h to no longer honor WTF_VECTOR_INITIAL_SIZE. This was added in https://chromiumcodereview.appspot.com/23804003 to be able to easily check different initial sizes back when it was difficult to change the value because blink was still in a different repo. The initial vector size was changed shortly after due to this experiment setup in https://codereview.chromium.org/23453040 , but it hasn't changed in the last 6 years since then -- also blink is now in src.git and if someone wants to change this value it's now very easy to do. No behavior change. Bug: 961767 Change-Id: I0e6fb5738a6f28fc833edaf90c110f4e4273e23d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718596 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#681056}
-
Hiroshige Hayashizaki authored
To use common names in referrer-policy and mixed-content tests. Generated files will be updated after some more changes, not now. Bug: 906850 Change-Id: Icdb979d429f08a908a74f7f6012b4c0b7dc50c8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717319Reviewed-by:
-
http://localhostStaphany Park authored
Issue #1: The "SecureContext" IDL attribute considers localhost to be secure, but the Cookie Store API assumed that it would only be exposed on cryptographically secure origins, so a DCHECK caused attempts to set/delete cookies on http://localhost to crash. This CL replaces the DCHECK with an exception that is thrown on attempts to set/delete secure cookies on cryptographically insecure origins. Issue #2: The "secure" cookie attribute defaulted to true. Setting/deleting a secure cookie on a cryptographically insecure origin is prohibited. The cookieStore.delete() API excluded the option to set the "secure" attribute, however, so there was no way to delete an insecure cookie. This CL defaults the "secure" attribute to true on cryptographically secure origins, and false otherwise. Bug: 956641 Change-Id: Iff7c22713e8604d60b68d42199a74b2d08235712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700357 Commit-Queue: Staphany Park <staphany@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#681054}
-
