GitLab

Adds a feature to suppress the Contextual Search UX when a Tap
occurs and various signals indicate that it's unlikely the user
will open the panel.

For this CL, the only two signals are:
1) Whether the user has Tapped N times without opening the panel.
2) Whether the previous Tap was in about the same location recently.

Signal #1 suppresses, signal #2 overrides the suppression by triggering.

Also minor cleanup to TapFarFromPreviousSuppression and
ContextualSearchTapState.

BUG=609918

Review-Url: https://codereview.chromium.org/2096203002
Cr-Commit-Position: refs/heads/master@{#403239}

This makes client code simpler, because all those things are passed through the same places.

This CL also cleans up a few things:
1- make (0, 0) a valid size for offscreen contexts more generally. It is already the case for GPU process contexts (CommandBufferProxyImpl), make it valid for the other types (GLInProcessContext, tests) by handling the logic it in GLES2DecoderImpl. This will also allow us to later remove allocating unneeded textures.
2- many callers were setting an arbitrary dummy size, even for onscreen contexts (where it's not used), or when the default framebuffer isn't used (most contexts except Pepper and EGL).
3- many callers were arbitrarily choosing the discrete GPU, when it doesn't matter (android, tests), whereas most of the code (compositor, helper contexts) should be choosing the integrated one, for consistency. In particular, pixel tests should be consistent with production.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/11f4e35b660f4f5cbaed65a0a7f181b8426e877e
Review-Url: https://codereview.chromium.org/2107783003
Cr-Original-Commit-Position: refs/heads/master@{#402955}
Cr-Commit-Position: refs/heads/master@{#403238}

*** NOTE TO SHERRIF ***
If there are failing tests in form of benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.*
please do not revert this CL but instead disabling failing
test by adding them into the _DISABLE_TESTS list in
tools/perf/benchmarks/system_health_smoke_test.py

1st patch from issue 2110653002 at patchset 160001 (http://crrev.com/2110653002#ps160001)
2nd patch disable more tests

BUG=615382
TBR=petrcermak@chromium.org

Review-Url: https://codereview.chromium.org/2115623002
Cr-Commit-Position: refs/heads/master@{#403237}

To compute the total size of site data in browsing data, this CL adds following classes.
  SiteDataSizeCollector: collects size information of site data from storage backends using BrowsingData*Helper.
  SiteDataCounter: works as a BrowsingDataCounter using the size collector above.

BUG=591958

Review-Url: https://codereview.chromium.org/2092663002
Cr-Commit-Position: refs/heads/master@{#403236}

This fixes a hypothetical issue where returning _URC_END_OF_STACK in phase two
of exception processing could confuse libunwind. If this personality routine
is called in phase two, it will now delegate back to the normal C++ personality
routine. See https://crbug.com/576941#c62 for details.

BUG=576941
R=mark@chromium.org

Review-Url: https://codereview.chromium.org/2119553002
Cr-Commit-Position: refs/heads/master@{#403235}

Cr-Commit-Position: refs/heads/master@{#403234}

Revert of Fix assert in Flash component install. (patchset #1 id:1 of https://codereview.chromium.org/2109873002/ )

Reason for revert:
Compilation failure in Google Chrome Mac

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/builds/11620

Detailed message:

In file included from ../../base/bind_internal.h:13:
../../base/bind_helpers.h:412:7: error: implicit instantiation of undefined template 'base::internal::DropTypeListItemImpl<1, base::internal::TypeList<> >'
    : DropTypeListItemImpl<n - 1, TypeList<List...>> {};
      ^
../../base/bind_helpers.h:426:1: note: in instantiation of template class 'base::internal::DropTypeListItemImpl<2, base::internal::TypeList<component_updater::ComponentUpdateService *> >' requested here
using DropTypeListItem = typename DropTypeListItemImpl<n, List>::Type;
^
../../base/bind_internal.h:395:23: note: in instantiation of template type alias 'DropTypeListItem' requested here
  using UnboundArgs = DropTypeListItem<sizeof...(BoundArgs), Args>;
                      ^
../../base/bind_internal.h:437:1: note: in instantiation of template class 'base::internal::MakeUnboundRunTypeImpl<void (*)(component_updater::ComponentUpdateService *), const base::FilePath &, const base::Version &>' requested here
using MakeUnboundRunType =
^
../../base/bind.h:50:23: note: in instantiation of template type alias 'MakeUnboundRunType' requested here
inline base::Callback<MakeUnboundRunType<Functor, Args...>>
                      ^
../../chrome/browser/component_updater/pepper_flash_component_installer.cc:113:7: note: while substituting deduced template arguments into function template 'Bind' [with Functor = void (*)(component_updater::ComponentUpdateService *), Args = <const base::FilePath &, const base::Version &>]
      base::Bind(&RegisterPepperFlashWithChrome, path, version));
      ^
../../base/bind_helpers.h:407:8: note: template is declared here
struct DropTypeListItemImpl;
       ^
../../base/bind_helpers.h:480:1: error: implicit instantiation of undefined template 'base::internal::MakeFunctionTypeImpl<void, int>'
using MakeFunctionType = typename MakeFunctionTypeImpl<R, ArgList>::Type;
^
../../base/bind_internal.h:396:16: note: in instantiation of template type alias 'MakeFunctionType' requested here
  using Type = MakeFunctionType<ReturnType, UnboundArgs>;
               ^
../../base/bind_internal.h:437:1: note: in instantiation of template class 'base::internal::MakeUnboundRunTypeImpl<void (*)(component_updater::ComponentUpdateService *), const base::FilePath &, const base::Version &>' requested here
using MakeUnboundRunType =
^
../../base/bind.h:50:23: note: in instantiation of template type alias 'MakeUnboundRunType' requested here
inline base::Callback<MakeUnboundRunType<Functor, Args...>>
                      ^
../../chrome/browser/component_updater/pepper_flash_component_installer.cc:113:7: note: while substituting deduced template arguments into function template 'Bind' [with Functor = void (*)(component_updater::ComponentUpdateService *), Args = <const base::FilePath &, const base::Version &>]
      base::Bind(&RegisterPepperFlashWithChrome, path, version));
      ^
../../base/bind_helpers.h:468:8: note: template is declared here
struct MakeFunctionTypeImpl;
       ^
../../chrome/browser/component_updater/pepper_flash_component_installer.cc:113:19: error: use of undeclared identifier 'RegisterPepperFlashWithChrome'
      base::Bind(&RegisterPepperFlashWithChrome, path, version));
                  ^
3 errors generated.

Original issue's description:
> Fix assert in Flash component install.
>
> BUG=
>
> Committed: https://crrev.com/df973871410891db6f94d224327d8c7cb4b8ae1e
> Cr-Commit-Position: refs/heads/master@{#403218}

TBR=sorin@chromium.org,waffles@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2114753002
Cr-Commit-Position: refs/heads/master@{#403233}

BUG=622854

Review-Url: https://codereview.chromium.org/2090283002
Cr-Commit-Position: refs/heads/master@{#403232}

If ARC has a fatal error during first initialization, the user will
never be notified. It might also cause a case where ARC would be stopped
and started infinitely without giving the user a chance to stop it. This
change adds some logic to stop automatically retrying to start ARC and
let the user decide to do so instead.

BUG=b/29833836
TEST=Kill ARC mid-initialization, "Service unavailable" is shown

Review-Url: https://codereview.chromium.org/2114463002
Cr-Commit-Position: refs/heads/master@{#403231}

Defines AssociatedGroupController, an interface for managing
endpoint lifetime within an associated group. This was extracted
from MultiplexRouter which now implements the interface.

This is a precursor to supporting an alternative binding implementation
to serve the unique requirements of Mojo IPC::Channel and other
interfaces associated with it.

BUG=612500

Review-Url: https://codereview.chromium.org/2100683002
Cr-Commit-Position: refs/heads/master@{#403230}

Rather than using a sub-directory per ChromeTabbedActivity instance,
use one shared director for all instances.

BUG=622143

Review-Url: https://codereview.chromium.org/2087893003
Cr-Commit-Position: refs/heads/master@{#403229}

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447

Review-Url: https://codereview.chromium.org/2105173004
Cr-Commit-Position: refs/heads/master@{#403228}

BUG=623727
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2103053006
Cr-Commit-Position: refs/heads/master@{#403227}

HTTP_SPDY_VIA_NPN and HTTPS_SPDY_VIA_ALT_SVC type tests use the same origin,
same port, same scheme.  The only different is the preloaded alternative service
record and the extra hanging socket.  There is really no added value, it is just
a burden on code complexity and test infrastructure.

Review-Url: https://codereview.chromium.org/2109593007
Cr-Commit-Position: refs/heads/master@{#403226}

* Change SpdyHttpStreamTest SpdySessionKey port from 80 to 443.
* In SpdyHttpStreamTest, BidirectionalStreamTest, and
  BidirectionalStreamSpdyImplTest, add GURL, HostPortPair, and SpdySessionKey
  members, and remove SdySessionKey argument from InitSession, for brevity.
* Add GURL member to HttpStreamFactoryBidirectionalQuicTest for brevity.
* Use kDefaultUrl instead of "https://www.example.org" in a whole bunch of
  tests.

Review-Url: https://codereview.chromium.org/2111953002
Cr-Commit-Position: refs/heads/master@{#403225}

This CL makes the following replacements in
base:

Before               After
----------------------------------------------------------
 x.PostTask()          x.task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

x->PostTask()         y->task_runner()->PostTask()
   PostDelayedTask()                    PostDelayedTask()
   ReleaseSoon()                        ReleaseSoon()
   DeleteSoon()                         DeleteSoon()

 x.Run()              RunLoop().Run()
 x.RunUntilIdle()     RunLoop().RunUntilIdle()

x->Run()              RunLoop().Run()
x->RunUntilIdle()     RunLoop().RunUntilIdle()
    If |x| isn't MessageLoopForUI::current() or
    MessageLoopForIO::current()
----------------------------------------------------------

|x| is a base::MessageLoop(ForUI|ForIO) or a pointer to
a base::MessageLoop(ForUI|ForIO).

This CL was generated using the MessageLoopDeprecatedMethods
clang-tidy fix available on the associated bug. Only files
that compile on Mac are affected. Follow-up CLs will make
these replacements for other platforms.

This CL doesn't change code behavior.

BUG=616447

Review-Url: https://codereview.chromium.org/2103333006
Cr-Commit-Position: refs/heads/master@{#403224}

This CL develops the new Mac UI for Desktop Capture Picker window.

The main changes are
1. Separate the items of different source types into different
browser view.
2. Use table view rather than image view for tab capture, because
we do not have HD preview for tab.

BUG=602478, 618796

Review-Url: https://codereview.chromium.org/2072003002
Cr-Commit-Position: refs/heads/master@{#403223}

TBR=nednguyen@google.com
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq

Review-Url: https://codereview.chromium.org/2110273002
Cr-Commit-Position: refs/heads/master@{#403222}

Currently IMM is not getting BACK key event correctly, hence the IMM
behavior on back key is not getting executed. Now made it sure that
IMM will get the key event first before reaching to view.

BUG=470001

Review-Url: https://codereview.chromium.org/2108333003
Cr-Commit-Position: refs/heads/master@{#403221}

Prior to this, the client ID was being counted on initial startup
as well as any cold start refocuses of the CustomTabs.  This moves
the tracking to match StartedInitially which checks for the
existence of getSavedInstanceState()

BUG=622366

Review-Url: https://codereview.chromium.org/2115613002
Cr-Commit-Position: refs/heads/master@{#403220}

Change b5fb4b43 introduced a new field
to `struct net::MockTransaction`, however there were few more
MockTransaction initializations that were not updated in that commit.

R=mmenke@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2112913002
Cr-Commit-Position: refs/heads/master@{#403219}

BUG=

Review-Url: https://codereview.chromium.org/2109873002
Cr-Commit-Position: refs/heads/master@{#403218}

BUG=624653

Review-Url: https://codereview.chromium.org/2116563002
Cr-Commit-Position: refs/heads/master@{#403217}

This change updates the tab switcher asset to minimize the visibility
of the inner border.

BUG=623571

Review-Url: https://codereview.chromium.org/2110683009
Cr-Commit-Position: refs/heads/master@{#403216}

Fix the issue that when shelf is switched from left-aligned shelf to
right-aligned shelf, the spacing between the edge of the screen to tray
items are not changed.

TEST=Manuel
- change shelf location left to right or right to left.
- change shelf location bottom to right or bottom to left.
- initialize shelf locating on left or right.

BUG=623438

Review-Url: https://codereview.chromium.org/2103113003
Cr-Commit-Position: refs/heads/master@{#403215}

Somehow totalDuration is still becoming negative, this change puts
a final check for negative values before updating the animation.

BUG=622540

Review-Url: https://codereview.chromium.org/2111203003
Cr-Commit-Position: refs/heads/master@{#403214}

Now that the PDF plug-in supports native accessibility, we can remove
the accessibility JSON interface and the ChromeVox code that calls it.

BUG=54724
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2103043003
Cr-Commit-Position: refs/heads/master@{#403213}

Apparently this is what the server sends back. It's a nicer format than
the timestamp struct, but a bit unexpected.

BUG=621090

Review-Url: https://codereview.chromium.org/2110393004
Cr-Commit-Position: refs/heads/master@{#403212}

Revert of Fix MultibufferDataSource::GetSize (patchset #1 id:1 of https://codereview.chromium.org/2110853006/ )

Reason for revert:
I believe this CL is causing flakyness in the video related tests on the GPU FYI waterfall.

Examples:
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28NVIDIA%29/builds/25925
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28ATI%29/builds/48492
https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Retina%20Release/builds/5019

Seeing this in the output log:
[27562:1287:0630/083352:WARNING:webmediaplayer_impl.cc(335)] Using MultibufferDataSource
[27562:34423:0630/083352:ERROR:ffmpeg_demuxer.cc(1510)] OnReadFrameDone result=-541478725 IsMaxMemoryUsageReached=0
[27562:1287:0630/083352:WARNING:webmediaplayer_impl.cc(335)] Using MultibufferDataSource
[27562:1287:0630/083352:FATAL:resource_multibuffer_data_provider.cc(75)] Check failed: byte_pos() < url_data_->length() (32768 vs. 10292) http://127.0.0.1:53903/resources/red-green.theora.ogv

Original issue's description:
> Fix MultibufferDataSource::GetSize
>
> When file loading is finished ResourceMultiBufferDataProvider count
> DataBuffer queue size twice, so GetSize returned incorrect value.
>
> BUG=
>
> Committed: https://crrev.com/bbaba3c8053a39f6d11d78a6e4770b37a9639067
> Cr-Commit-Position: refs/heads/master@{#403123}

TBR=hubbe@chromium.org,kostya-k@yandex-team.ru
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624853

Review-Url: https://codereview.chromium.org/2115483003
Cr-Commit-Position: refs/heads/master@{#403211}

When --touch-devices flag is used on X, we use TouchEvent(native_event)
constructor, which uses ui::GetTouchForceFromXEvent() to initialize the force
value. On Ozone we don't do this, and force gets initialized to NaN.

This CL makes Ozone on X consistent with X in that it uses GetTouchForceFromXEvent(xev)
to initialize the force value in the constructed TouchEvent.

BUG=NONE

Review-Url: https://codereview.chromium.org/2103823003
Cr-Commit-Position: refs/heads/master@{#403210}

Allows users to set the overridden network conditions of the session to preset values including 2G, 3G, 4G, Wifi, and Offline.

BUG=chromedriver:984

Review-Url: https://codereview.chromium.org/2065733002
Cr-Commit-Position: refs/heads/master@{#403209}

Empty usernames aren't supported by the partners. Therefore, every time we return it or show it in the account chooser we worsen the UX.

BUG=400674

Review-Url: https://codereview.chromium.org/2110993003
Cr-Commit-Position: refs/heads/master@{#403208}

This information will easily allow the server to use different
experiments in different channels and different versions.

BUG=622374

Review-Url: https://codereview.chromium.org/2103223002
Cr-Commit-Position: refs/heads/master@{#403207}

This new ChromeIdentityInteractionManager reauthenticate method is more
flexible and allow the implementation to do some internal cleanup based
on a unique identifier (the email can change).

BUG=623928

Review-Url: https://codereview.chromium.org/2110183006
Cr-Commit-Position: refs/heads/master@{#403206}

Revert of Eliminate the ChannelMojo channel for renderers (patchset #4 id:60001 of https://codereview.chromium.org/2109043002/ )

Reason for revert:
http://crbug.com/624556

Original issue's description:
> Eliminate the ChannelMojo channel for renderers, instead obtain Bootstrap interface from child connection.
>
> R=rockot@chromium.org
> http://crbug.com/623396
>
> BUG=
>
> Committed: https://crrev.com/9e883c385ccc47607a9341d618678b35195cc8fe
> Cr-Commit-Position: refs/heads/master@{#402812}

TBR=ben@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=

Review-Url: https://codereview.chromium.org/2111673006
Cr-Commit-Position: refs/heads/master@{#403205}

This page seems to be working again locally.

BUG=618708

Review-Url: https://codereview.chromium.org/2108313003
Cr-Commit-Position: refs/heads/master@{#403204}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ead31d8dd552..a9f8ed16a47c

$ git log ead31d8dd..a9f8ed16a --date=short --no-merges --format='%ad %ae %s'

BUG=621113

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2103053007
Cr-Commit-Position: refs/heads/master@{#403203}

BUG=504084

Review-Url: https://codereview.chromium.org/2104203003
Cr-Commit-Position: refs/heads/master@{#403202}

BUG=622374

Review-Url: https://codereview.chromium.org/2104143002
Cr-Commit-Position: refs/heads/master@{#403201}

media-fragment tests are not in a state to be upstreamed
to wpt. So removing the unneeded TODO's for now.

BUG=588956

Review-Url: https://codereview.chromium.org/2103003002
Cr-Commit-Position: refs/heads/master@{#403200}