- 05 Nov, 2020 40 commits
-
-
Austin Sullivan authored
Bug: 925306 Change-Id: I8aa9504c6ce8472101dbadf5e9f391971e5de1a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519427Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/master@{#824406}
-
Dominique Fauteux-Chapleau authored
This CL refactors tests in ContentAnalysisDelegate to use Connector policies directly instead of the indirect helpers that map to legacy policies. Bug: 1109242 Change-Id: I3f7f356ac5076a4f98a66c1fc8bac42c8401a70b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519200Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#824405}
-
Andrew Grieve authored
* Includes fix for L8 non-determinism * Enables proto enum unboxing * Includes fixes for tracereferences tool Bug: 1142530 Change-Id: Ifd09646ac296f85ef1102ed69541d04dd64b141f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519098 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#824404}
-
Marc Treib authored
...plus all the code for handling them. These were unused (outside of some tests), so this was all dead code. Bug: 1145589 Change-Id: Ic54a7fa293dc8cf5e785acb6cb137118f91f51d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518981Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#824403}
-
Nico Weber authored
This reverts commit b8222e3d. Reason for revert: Codebase doens't build with this change, https://crbug.com/1145992 Original change's description: > Treat CheckedPtr specially in FindBadConstructsConsumer > > Treat CheckedPtr specially in FindBadConstructsConsumer for now as discussed in: > https://groups.google.com/a/google.com/g/chrome-memory-safety/c/kw3i_zd3FW4/m/40FkyrLtAQAJ > This CL helps to avoid "Complex constructor has an inlined body" and similar errors during go/miracleptr experiments. > > Bug: 1080832 > Change-Id: Ibfb6b3b418f36e2c6868b0fbd579d1bf18226ceb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487023 > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824252} TBR=dcheng@chromium.org,keishi@chromium.org,lukasza@chromium.org,bartekn@chromium.org Change-Id: Ia1012a029e4b4b2b8a4ed6e65eaaeb45f0298cf3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1080832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520936Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#824402}
-
Friedrich [CET] authored
This reverts commit 67317286. Reason for revert: Compile failure not (or only very loosely) related to this CL. Local reland doesn't seem to affect reproduction of compile failure. Original change's description: > Revert "Nearby Share: Consolidate and autogenerate grd files" > > This reverts commit 5c7c88d7. > > Reason for revert: Most-likely suspect for CrOS compile failure: > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42591 > > Log: > [5898/61571] ACTION //ui/file_manager/file_manager/test:create_test_main(//build/toolchain/linux:clang_x64) > FAILED: gen/ui/file_manager/file_manager/test.html > /b/s/w/ir/cipd_bin_packages/cpython/bin/python ../../ui/file_manager/file_manager/test/scripts/create_test_main.py --output=gen/ui/file_manager/file_manager/test.html > Traceback (most recent call last): > File "../../ui/file_manager/file_manager/test/scripts/create_test_main.py", line 144, in <module> > write(GEN + R_GEN + colors, open(GEN + '../../' + colors).read()) > IOError: [Errno 2] No such file or directory: '/b/s/w/ir/cache/builder/src/out/Release/gen/ui/file_manager/file_manager/../../chromeos/colors/cros_colors.generated.css' > > Original change's description: > > Nearby Share: Consolidate and autogenerate grd files > > > > Bug: 1132403 > > Change-Id: I809b1a97e43457b92ac67fde208b200bfbf37d58 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507400 > > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: dpapad <dpapad@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#824322} > > TBR=avi@chromium.org,dpapad@chromium.org,rbpotter@chromium.org > > Change-Id: I275146470b9fc70dbff9203ee8f951eda7e624d8 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1132403 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517734 > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824345} TBR=avi@chromium.org,dpapad@chromium.org,rbpotter@chromium.org,fhorschig@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1132403 Change-Id: If7466f38cc0114c50adeef011c22c0c0cf2f437a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517446Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#824401}
-
Titouan Rigoudy authored
This change enables the test except when a conflicting feature is enabled. It improves on the status quo (test disabled everywhere) until the underlying failure can be fixed, letting the test run on all CI bots except for the offending Network Service bot. Bug: chromium:1142865 Change-Id: I4bb870d04c6b35961c1c32d9d3549d03afeaa3f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519693 Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824400}
-
Brian Ho authored
Enabling SkiaRenderer on Chrome OS currently fails a DCHECK [1] that asserts the backing GLSurface has a top-left origin. Since GetOrigin() returns the OS presentation API's origin, GbmSurfaceless should also return a top-left origin. For example, if you call gbm_bo_map with (x = 0, y = 0), the returned data pointer will correspond to the top-left of the buffer. [1] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display_embedder/output_presenter_gl.cc;l=223;drc=238120617b24d1856e0d66e2a6d3272a5e94f658 Change-Id: I0cdfa9d3414cb844dc33470c6342a3a944074d09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511879Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org> Cr-Commit-Position: refs/heads/master@{#824399}
-
Peng Huang authored
Because a mesa bug, the vulkan swapchain can hang with X11, fix the hang by using a one second timeout with vkWaitForFences() call. Bug: 1130495 Change-Id: Id9f36a3b087e9d7f6307e708a5cde41d631a9d63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518949Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#824398}
-
Sylvain Defresne authored
Since Chrome can be build for "catalyst" environment, add the key SUPPORTS_MACCATALYST to the generated Xcode project. Bug: 1138425 Change-Id: Idb56060a53266f5b9a4ab6a2328970cfa84973de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518858Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#824397}
-
Titouan Rigoudy authored
This move was suggested by droger@ in crrev.com/c/2490012. Bug: chromium:1124358 Change-Id: I2ab058c6e302f440bc643f0cbcd16ab848278d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518855 Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824396}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4cd11945c5a1..df4403112ffa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I4301e0d345b40f7188b07d7c69d87df8cc5a3ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519042Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824395}
-
Stephen McGruer authored
Bug: None Change-Id: Icc075456c6762fb8ae841ffccb743b3b8e9ddc5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519480Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#824394}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/aa14597ebcfa..771ac0bce101 2020-11-05 yangguo@chromium.org Add missing common owners 2020-11-05 aerotwist@chromium.org Move WebVitals out of experiments 2020-11-05 sigurds@chromium.org DevTools: Allow users to override storage quota size. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:945786 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iac45cf68e5009fa5fda05bc36d744e7168f39e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520796Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824393}
-
Mark Mentovai authored
This includes universalizer.py and the Widevine signing scripts. Depends on: https://chromium-review.googlesource.com/c/2515521 and https://chrome-internal-review.googlesource.com/c/3383223 https://chrome-internal-review.googlesource.com/c/3380436 (DEPS) https://chromium-review.googlesource.com/c/2520327 (DEPS) Code-Word: calamity Bug: 1142017 Change-Id: I83bc47a2edbd031f4d7f291a6b4922d3c862f1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518800 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#824392}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4cd11945c5a1..df4403112ffa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If3d9a1db7b8806feb72cad6b94732164cf0ddeab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520717Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824391}
-
Roberto Moura authored
Tapping the tab switcher button, after the tab grid had been revealed once, while on Peeked state would crash because the scene_controller's displayTabSwitcher would be called when self.tabSwitcherIsActive is YES. The proposed fix is to set self.tabSwitcherIsActive to NO whenever there is a transition from the Revealed state to another state. This CL adds a method to the ThumbStripCoordinatorDelegate protocol to inform that the tab grid has been dismissed. Bug: 1127604 Change-Id: I9ace9a2ff27143eb40774b7ff563c600bdfe4e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463822 Commit-Queue: Roberto Moura <mouraroberto@google.com> Auto-Submit: Roberto Moura <mouraroberto@google.com> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#824390}
-
Sylvain Defresne authored
The linker fails if any object file does not define LC_BUILD_VERSION when linking a binary for "catalyst" environment. As nasm does not create such a section, the build fail if using optimised version of libvpx. As a workaround, use generic implementation instead of the optimized one in that configuration (since it is still experimental anyway). Bug: 1145197, 1138425 Change-Id: I6bf02c499d8e35dcc0fe34f5bb53df230a8449cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517955 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#824389}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/df4403112ffa..744b988ae1b0 2020-11-05 treehugger-gerrit@google.com Merge "Fixed protobuf deprecated API" 2020-11-05 treehugger-gerrit@google.com Merge "Extend export_json to read from memory tables" 2020-11-04 fmayer@google.com Merge "Assert we don't stop reading the shmem." 2020-11-04 hjd@google.com Merge "Parse dpu and g2d" 2020-11-04 delphick@google.com Merge "trace_processor_shell: add .read command" 2020-11-03 treehugger-gerrit@google.com Merge "Improved flow navigation" 2020-11-03 simonmacm@google.com Merge "Work around b/169226092 where we see wrong or truncated process names." 2020-11-03 treehugger-gerrit@google.com Merge "base: Allow message() calls when status.ok() == true" 2020-11-03 fmayer@google.com Merge "Only send on socket when service stopped reading." 2020-11-03 primiano@google.com Merge "SDK: remove spurious ELOG when no error occurs" 2020-11-03 treehugger-gerrit@google.com Merge "Fix parsing of locations that have DEX in subfolder." 2020-11-03 primiano@google.com Merge "Update CHANGELOG for v9.0 release" 2020-11-03 primiano@google.com Merge "CI: fix Stats link" 2020-11-03 hjd@google.com Merge "trace_processor: Handle armv8l syscall traces" 2020-11-03 treehugger-gerrit@google.com Merge "docs: Fix trigger config instructions" 2020-11-03 treehugger-gerrit@google.com Merge "sdk: Rename kCatIndex in track event macro to highlight common error" 2020-11-03 hjd@google.com Merge "trace_processor: support fastrpc event" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I6f18d6c282ce69a9c6b564b2b725fbea523575c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520532Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824388}
-
Jérôme Lebel authored
Adding: * Signin.SSOIdentityListRequest.FetchIdentitiesWithCallback.Duration Time needed to fetch the identity list * Signin.SSOIdentityListRequest.RunAfterCacheIsPopulated.CacheState State of the identity cache before calling RunAfterCacheIsPopulated() * Signin.SSOIdentityListRequest.RunAfterCacheIsPopulated.Duration Time needed for the callback to be called for RunAfterCacheIsPopulated() * Signin.SSOIdentityListRequest.WaitUntilCacheIsPopulated.CacheState State of the identity cache before calling RunAfterCacheIsPopulated() * Signin.SSOIdentityListRequest.WaitUntilCacheIsPopulated.Duration Time blocked in WaitUntilCacheIsPopulated() Those metrics are implemented in crrev.com/i/3353162. Design doc: http://go/async-identityservice-api crrev.com/c/2489915 Adding methods in ChromeIdentityService crrev.com/i/3353161 Implementing in ChromeIdentityServiceImpl => crrev.com/c/2490110 Adding metrics crrev.com/i/3353162 Implementing the metrics crrev.com/c/2490010 Adding WaitUntilCacheIsPopulated calls crrev.com/i/3354983 Adding DCHECK for cache state Bug: 897470 Change-Id: I83744b7eaec3f7eb4c2515550e6a2638e5c0ec15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490110 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#824387}
-
Karandeep Bhatia authored
Autogenerated header: https://paste.googleplex.com/6624090682032128 Autogenerated cc file: https://paste.googleplex.com/6206455679025152 BUG=1113513 Change-Id: I1bb4adc0712430e94a1e7874e9ec7a20759f57e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419607 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824386}
-
Arthur Sonzogni authored
This reverts commit 46de280d. Reason for revert: still flaky. See https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel-non-cq/707 Original change's description: > enable FeedNewTabPageCardInstrumentationTest > > Bug: 1143781 > Change-Id: Ic7c1adad83cb472aeaeb8e82534288184a89d544 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518183 > Reviewed-by: Dan H <harringtond@chromium.org> > Commit-Queue: Arthur Wang <wuwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824229} TBR=harringtond@chromium.org,wuwang@chromium.org Change-Id: I9ccace6afc3b4193000d094392c78468887a6249 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1143781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519975Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#824385}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d9cecc6f..1028db2c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I441918cc39ef07cbaed3b55815787c9047acabf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520718Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824384}
-
Friedrich Horschig authored
The test has already been disabled for earlier iOS versions. Since it fails frequently, disable it for the remaining bots. TBR=sczs@chromium.org Bug: 1035764, 1145948 Change-Id: I2485c4c9691f302073b6acb89c3bd7dbf8c02509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517469Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#824383}
-
Guido Trotter authored
Currently the dialog refers to the device as "Chrome device" instead of "Chromebook/Chromebox/etc". This commit fixes it in three messages. R=rsorokin@google.com Signed-off-by:
Guido Trotter <ultrotter@chromium.org> Fixed: 1023388 Change-Id: I9f4e300587fc978e00e782f99031d55844786f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518854Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824382}
-
Arthur Sonzogni authored
This reverts commit ae52b2a4. Reason for revert: https://crbug.com/1145924 Original change's description: > [WebLayer] Change the return type of Fragment.getActivity() to Activity. > > This CL adds the ability to specify a script in an android_aar_prebuilt > rule that can modify prebuilt jar files, and adds a script to change > Fragment.getActivity() and Fragment.requireActivity() to return an > Activity instead of a FragmentActivity. > > This is the first CL in a chain that will allow us to remove the fake > activity we create when embedding Fragments that cross classloader > boundaries. > > Bug: 1123216 > Change-Id: I4b9d3ca5f9c3a4d86e08d64f49d601c08fca9a70 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432413 > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823582} TBR=twellington@chromium.org,agrieve@chromium.org,rmcelrath@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1123216 Change-Id: Ib07ea2150fea59649c50b19d1a27b115d6168627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517489Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#824381}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1d09ab6b6ebf..110009e66adc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1143321 Tbr: Change-Id: I61eb79ecbb4235856d77039ef4ba995c5510ecd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520411Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824380}
-
Joel Hockey authored
create_test_main.py script relies on cros_colors.generated.css, so add it as a dep via webui_resources_grd to catch a broader range of generated resources. No-Tree-Checks: true No-Try: true Bug: 1145902 Change-Id: I7fb1681dd7f6db58ca74255eeb5be9ba10b1fa27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520483 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#824379}
-
Sylvain Defresne authored
Building for "catalyst" environment requires some specific gn settings, so to facilitate the developers' job, add support for this environment to //ios/build/tools/setup-gn.py. Remove support for "fat" build as it is unsupported (since deployment target was bumped to 11.0+). Bug: 1138425 Change-Id: Ia40cb9a7b72a70e46b1a938285c0a020ea95f619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517732 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#824378}
-
Pâris MEULEMAN authored
This adds a few browser tests for policy container [1]. With the following objectives: - Verify that the policy container is properly populated (at this stage only the referrer policy is available within the policy container), from the header and from the meta tags. - Verify that the policy container is properly inherited in popups and iframes. - Verify that the inherited policy is the one applied. - Verify the behavior of policy container when an iframe is "created" by a sibling: Even if the script was executed by a sibling, the parent frame is always the creator. [1] https://docs.google.com/document/d/16-bbA-DsO1l3vZnWYemRhcaUJZ8g8SZhMo99MmGFRSs/edit#heading=h.o51zkgcv0thc Bug: 1130587 Change-Id: I37d4cbb9882f72ac041559f15fb06675bb88dd3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457186 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#824377}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1e494cae8d48..1e59a0e12e6d 2020-11-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 9c36b526 to 3c7580ad (415 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: If160f98aa3e284d4098f4998b8e49114317c7eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520525 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824376}
-
Ewann authored
This CL removes the legacy GetUIFont method. Bug: 1131056 Change-Id: I763c1cae6e8d1ce43517f5ba4745c0df961ad05b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517488 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#824375}
-
Ewann authored
This CL sets the leadingButton title during its initialization which allows the confirmation actionSheet to be correctly anchored. Previously the actionSheet was anchored before the title was configured, causing misalignment. Bug: 1140982 Change-Id: Ie35be2d119585b9512dff5cd9ed347ad02934254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517589 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#824374}
-
Tony Price authored
Bug: 982501 Change-Id: I5b25e2b8ce3d7e86527cbb59f9bce3d7e1a24dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498562 Commit-Queue: Tony Price <toprice@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824373}
-
Jeevan Shikaram authored
This CL adds versioning to the digital_godos.mojom file in the blink. This is required because some structs and enums are depended on by a mojom file that is in components/arc/mojom, which is used by the browser to talk to ARC++. There is a chance that the mojom files in ARC++ and Chrome will be out of sync. Bug: 1137688 Change-Id: I5716088509145cbe8c68fc9dfa879f44e1ff85cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503753Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#824372}
-
Arthur Sonzogni authored
This reverts commit b6fcf130. Reason for revert: https://crbug.com/1145937 Original change's description: > Reland "[AF] Add account indication footer to AutofillSaveCardInfoBar" > > This reverts commit 9e3dabc4. > > Reason for reland: This CL was not actually the cause of the test failures (https://crrev.com/c/2519333 fixed them). > > Original change's description: > > Revert "[AF] Add account indication footer to AutofillSaveCardInfoBar" > > > > This reverts commit ba7d8814. > > > > Reason for revert: SaveCardBubbleViewsFullFormBrowserTestWithAutofillUpstream.Upload_ClickingNoThanksClosesBubble and a bunch of other tests started failing in https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21164 > > > > > > Original change's description: > > > [AF] Add account indication footer to AutofillSaveCardInfoBar > > > > > > The footer is shown only to signed-in users have more than one account, and who do not sync. > > > > > > Screenshot with feature enabled in light mode: > > > https://screenshot.googleplex.com/ApVmkMVQakM6ai9 > > > > > > Screenshot with feature enabled in dark mode: > > > https://screenshot.googleplex.com/BJB2jUuGoH3T5jM > > > > > > Bug: 1135847 > > > Change-Id: Ia2e031a48920e44e66503fab62f26ed87b8e1d92 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496184 > > > Commit-Queue: Anne Lim <annelim@google.com> > > > Reviewed-by: Marc Treib <treib@chromium.org> > > > Reviewed-by: Matthew Jones <mdjones@chromium.org> > > > Reviewed-by: Jared Saul <jsaul@google.com> > > > Cr-Commit-Position: refs/heads/master@{#823710} > > > > TBR=treib@chromium.org,mdjones@chromium.org,jsaul@google.com,bsazonov@chromium.org,annelim@google.com > > > > Change-Id: I5f235bc5843acf4ea504a78762907a019576e656 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1135847 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518852 > > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#823942} > > TBR=treib@chromium.org,mdjones@chromium.org,jsaul@google.com,dullweber@chromium.org,bsazonov@chromium.org,annelim@google.com > > # Not skipping CQ checks because this is a reland. > > Bug: 1135847 > Change-Id: I7d1a7ad2bc6b5c30d2b859c9f68bfee34992ff95 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517530 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824006} TBR=treib@chromium.org,mdjones@chromium.org,jsaul@google.com,dullweber@chromium.org,bsazonov@chromium.org,annelim@google.com Change-Id: I51a081655c5102711932ea605078348c9503b931 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1135847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517468Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#824371}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d631a67cc8c7..aa14597ebcfa 2020-11-05 alexrudenko@chromium.org Show icons for align-content:start|end If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1139945 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I641b27595b27df5f53a0ca94af7a9cbc8050f6f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520526Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824370}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/6564890116fd..e87a8c466fb1 2020-11-05 jiawei.shao@intel.com DawnTest: only choose one adapter from those with same name and backendType If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ic328005542b70db9b9c769510cda2ba18cb969d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520621Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824369}
-
Ewann authored
This CL refactors the Open In toolbar and makes the following changes: - Updates constraints using autoLayout. - Replaces the MDCButton by an UIButton. - Button text is no longer in uppercase. - Cleans unused variables & methods. based on: https://crrev.com/c/2517483 Bug: 1145477, 1136837, 1117398 Change-Id: I636adc502df159c077f3dc44dbf8d86dc6c0cf97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517574 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#824368}
-
arthursonzogni authored
They are all failling on Android P bots: org.chromium.chrome.test.pagecontroller.tests... - NewTabPageControllerTest#testIsCurrentPageThis - NewTabPageControllerTest#testOmniboxSearch - NewTabPageControllerTest#testOpenChromeMenu - TabSwitcherControllerTest#testClickTabSwitcher - TabSwitcherControllerTest#testCloseAllTabs - TabSwitcherControllerTest#testNumberOfOpenTabs - TabSwitcherControllerTest#testOpenNewTab Builder: android-pie-x86-rel https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel First failing build: https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/b8864538237552640896 BUG=1130617,1141179 TBR=aluo@chromium.org Change-Id: Ica537957bf1142de5aa8183261bab49864842b54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519974 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#824367}
-