GitLab

BUG=380916

Review URL: https://codereview.chromium.org/312203005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278546 0039d316-1c4b-4281-b951-d872f2087c98

This partially fixes the ozone build.

Tested with:

$ gn gen out/Debug_gn --args='use_ozone=true'
$ ninja -C out/Debug_gn

BUG=None
TEST=see above
TBR=brettw@chromium.org,sadrul@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/338183006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278544 0039d316-1c4b-4281-b951-d872f2087c98

Add a test for this case.

TEST=unit tests
BUG=386220
R=binji@chromium.org, bradnelson@google.com

Review URL: https://codereview.chromium.org/344833005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278543 0039d316-1c4b-4281-b951-d872f2087c98

Don't signal a service is removed unless we've signaled it was added.

BUG=365835

Review URL: https://codereview.chromium.org/346873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278542 0039d316-1c4b-4281-b951-d872f2087c98

Code cleanup for the logic that generates the labels used by the about:gpu page
to report on the feature status. Also separates (and fixes) reporting for impl-side-painting
and gpu rasterization.

BUG=386420

Review URL: https://codereview.chromium.org/344653004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278541 0039d316-1c4b-4281-b951-d872f2087c98

BUG=386593

Review URL: https://codereview.chromium.org/346833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278540 0039d316-1c4b-4281-b951-d872f2087c98

> [Downloads] Retry renames after transient failures.
> 
> If the cause of a rename failure is suspected of being transient
> (sharing violations, suspected race conditions in the file system), then
> retry the rename with an exponential backoff.
> 
> BUG=368455
> 
> Review URL: https://codereview.chromium.org/319603003

TBR=asanka@chromium.org

Review URL: https://codereview.chromium.org/342233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278537 0039d316-1c4b-4281-b951-d872f2087c98

This ensures that windows created in ASH honor the shell work area etc.

We have bugs today where in the first maximized window in ASH does not honor the work area
leading to problems.

Changes as below:-
1. Added a function IsAshProcess for Windows in ash_init.cc. This returns true if the browser
   is launched to serve ASH.
2. In the DefaultTargetDisplayProvider::GetTargetDisplay function check if the browser is launched
   for ASH along with the check for whether ASH is to be opened on startup. If yes then we get the
   display for the root window created for ASH.

BUG=361776
R=sky

Review URL: https://codereview.chromium.org/348513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278534 0039d316-1c4b-4281-b951-d872f2087c98

Polling GL queries is taking ~7us each time on Android.  Processing
queries from ::DrawElements & ::DrawArrays may not be a good idea as
50 to 100 draw calls per-frame with GPU rendering is common
i.e. 350~700us, and more so as we aim for handling higher draw call
counts in the future.

Pending queries are still polled in the following cases:
 - After glFlush().
 - After glFinish().
 - After processing any GpuCommandBufferStub  IPC message.
 - As delayed work, at up to 1000Hz.

BUG=385937

Review URL: https://codereview.chromium.org/342923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278533 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357747

Review URL: https://codereview.chromium.org/310413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278532 0039d316-1c4b-4281-b951-d872f2087c98

Now that we rolled the DEPS for speex library, we can use the GN BUILD
file directory from src/third_party/speex.

BUG=None
TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn speex
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/343943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278531 0039d316-1c4b-4281-b951-d872f2087c98

Alter the design of the bootstrap sandbox to only take over the bootstrap port of children when necessary.

Rather than replacing the bootstrap port outright in the browser process, this
change merely registers the sandboxed bootstrap port with launchd. When a
sandboxed child is being launched with base::LaunchProcess(), a new
LaunchOptions can specify a bootstrap name to look up and use as a replacement
bootstrap port.

The bootstrap port in the new child is replaced after fork() but before exec().
The kernel clears the IPC space during both of these system calls, so no other
references to the original bootstrap port will exist after replacing the port
with the sandboxed one and exec()ing.

This change also partially reverts r276026, which introduced a permissive
policy for NPAPI plugins. Since those plugins are no longer affected by the
bootstrap sandbox, it can be removed.

BUG=367863,383513,383517,383791,386330
R=jam@chromium.org, mark@chromium.org

Review URL: https://codereview.chromium.org/347783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278530 0039d316-1c4b-4281-b951-d872f2087c98

R=navabi@chromium.org

Review URL: https://codereview.chromium.org/345793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278529 0039d316-1c4b-4281-b951-d872f2087c98

This was accidentally broken in r270074 when I added support
for the IAccessible2_2 interface; I got the confusing
COM_INTERFACE_ENTRY syntax subtly wrong.

BUG=386374

Review URL: https://codereview.chromium.org/343653005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278528 0039d316-1c4b-4281-b951-d872f2087c98

This is not longer used.

R=fgorski@chromium.org
TBR=arv@chromium.org
BUG=none
TEST=tests updated

Review URL: https://codereview.chromium.org/344033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278526 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383015
R=xiyuan@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/342053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278525 0039d316-1c4b-4281-b951-d872f2087c98

PosixPlatformBackend didn't have support for detecting if an app is
running.

BUG=None

Review URL: https://codereview.chromium.org/331843007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278524 0039d316-1c4b-4281-b951-d872f2087c98

contains failures due to invalid source address token client nonce and
server nonce. Will add UMA histogram in chrome when this CL is merged.

Send reject reason to client for debugging purposes. Protected behind
new flags: FLAGS_use_early_return_when_verifying_chlo and
FLAGS_send_quic_crypto_reject_reason

Merge internal change: 69227401

R=jar@chromium.org, wtc@chromium.org, avd@google.com

Review URL: https://codereview.chromium.org/331143006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278523 0039d316-1c4b-4281-b951-d872f2087c98

BUG=386709
NOTRY=true

Review URL: https://codereview.chromium.org/344933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278521 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Reland Window Control Animations for TouchView. (https://codereview.chromium.org/316693002/)

Reason for revert:
In Immersice Fullscreen, when a mouse hovers near the top of the screen the header animates in. This is done by animating TopContainerView. However this view does not contain all of the title bar, and forces a paint to its canvas. With FrameCaptionButtonContainerView painting to a layer it no longer paints to the canvas of TopContainerView. Due to z-order of the views FrameCaptionButtonContainer exists below the TopContainerView as well as below the ClientView of the browser.

Reverting the use of layers in M37.
For M38 the use of layers can be rexamined, however changes to the header views, or how immersive mode renders, will be needed before relanding this.

Original issue's description:
> Reland Window Control Animations for TouchView
> 
> The original change contained a use-after-free bug. This was caused by window crossfade animation during
> maximizing, combined with input event processing. The crossfade would take the current layer and delete it. 
> However the next input event to the window tree would attempt to access the now deleted layer.

> Original Code Review: https://codereview.chromium.org/271913002/
> Revert Review: https://codereview.chromium.org/309973002/
> Revert "Revert of Animate window control changes in TouchView (https://codereview.chromium.org/271913002/)"
> This reverts commit 8863218a.
> 
> TBR=jamescook@chromium.org
> TEST=FrameCaptionButtonContainerViewTest.AnimationUpdatesLayerTree
> BUG=363717
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276782

TBR=jamescook@chromium.org
BUG=384612, 363717

Review URL: https://codereview.chromium.org/343433009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278520 0039d316-1c4b-4281-b951-d872f2087c98

iOS 5 hasn't been supported for several releases, so this is always
true.

BUG=300130

Review URL: https://codereview.chromium.org/349453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278519 0039d316-1c4b-4281-b951-d872f2087c98

This enables policy-for-extensions running in Public Sessions, and for
extensions running as Kiosk Apps too.

TBR=bartfab@chromium.org
BUG=224596

Review URL: https://codereview.chromium.org/341043005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278518 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=True

Review URL: https://codereview.chromium.org/347893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278515 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=blundell@chromium.org

Review URL: https://codereview.chromium.org/336443004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278514 0039d316-1c4b-4281-b951-d872f2087c98

These are being landed in support of https://codereview.chromium.org/247223003/

BUG=329175
TEST=none
TBR=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/344973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278513 0039d316-1c4b-4281-b951-d872f2087c98

This suppresses a warning about the setuid sandbox API version on Linux.

BUG=385995

Review URL: https://codereview.chromium.org/335453009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278512 0039d316-1c4b-4281-b951-d872f2087c98

First cut at the landing page.
Missing debugger walk thru.

BUG=None
TEST=None
R=sbc@chromium.org, binji@chromium.org

Review URL: https://codereview.chromium.org/345703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278510 0039d316-1c4b-4281-b951-d872f2087c98

This also fixes a few bugs in the IDB/Blob stuff:
* Removed a DCHECK that could hit depending on test teardown order.
* Made ChainedBlobWriterImpl truly asynchronous, fixing a crash if a File write failed before the first Blob write was attempted.
* Fix a crash where we'd try to free a scoped_ptr twice in the event of an abort.

Note that most of the time we won't actually receive File metadata, as Files often aren't snapshotted; I've got a blink change in progress [https://codereview.chromium.org/325383002/] that will always send it.

BUG=

Review URL: https://codereview.chromium.org/333533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278509 0039d316-1c4b-4281-b951-d872f2087c98

Some of the code (e.g. virtual keyboard related code in RenderWidgetHostViewAura)
expects a non-null ScreenPositionClient on the root window. So install a simple
implementation of the client that provides implementation for a single display.

BUG=380215
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/330973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278508 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379862

Review URL: https://codereview.chromium.org/328363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278507 0039d316-1c4b-4281-b951-d872f2087c98

There's an addition to the PNaCl ABI in M37 (which will ship 13367), so
require this version to avoid translation failures.

R=jvoung@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/342193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278506 0039d316-1c4b-4281-b951-d872f2087c98

Currently the View created by PowerSaveBlocker has the same size as the parent
view. This is not acceptable at least for WebView applications, since such a
View can interfere with application logic in case when the application maintains
its own child Views for WebView.

The view must be visible (otherwise, KeepScreenOn has no effect), but we can
set it to have zero dimensions, thus minimizing interference.

BUG=270903,386087

Review URL: https://codereview.chromium.org/340763004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278505 0039d316-1c4b-4281-b951-d872f2087c98

The logging macros should be usable by anything that depends on
mojo/public/cpp/environment (i.e., everything except
mojo/public/cpp/{system,utility}).

The macros are a simplified version of the usual ones in base/logging.h,
omitting (D)CHECK_{EQ,NE,GT,...}. Also currently not present are
(D)VLOG, etc.

I'm considering also adding MOJO_(D)CHECK_OK(mojo_result) and
MOJO_(D)LOG_IF_NOT_OK(level, mojo_result), which might be used similarly
to (D)PCHECK and (D)PLOG (for errno/GetLastError()). But I'd do that
separately.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/342653004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278504 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370433
TEST=None
R=sky@chromium.org

Review URL: https://codereview.chromium.org/348563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278503 0039d316-1c4b-4281-b951-d872f2087c98

The FYI builders will set this to enforce using the latest revision.

BUG=82385
NOTRY=true

Review URL: https://codereview.chromium.org/336163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278500 0039d316-1c4b-4281-b951-d872f2087c98

PPB_TraceEvent should be available to developers who want to profile
their application on Dev channel or Canary.

BUG=386636

Review URL: https://codereview.chromium.org/349443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278499 0039d316-1c4b-4281-b951-d872f2087c98

> DevTools: Fix for Page.captureScreenshot
> 
> from https://chromiumcodereview.appspot.com/190693002/
> 
> This patch makes Page.captureScreenshot synchronize with the renderer.
> When fixed implementation hits Stable it will be possible to use Page.captureScreenshot in Telemetry instead of window.chrome.gpuBenchmarking.beginWindowSnapshotPNG and remove the latter.
> 
> BUG=242405
> 
> Review URL: https://codereview.chromium.org/311313003

TBR=vkuzkokov@chromium.org

Review URL: https://codereview.chromium.org/343033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278498 0039d316-1c4b-4281-b951-d872f2087c98

- Permit multiple concurrent LocalPredictor prerenders
- Permit local predictor prerenders to trigger prefetches (and only prerender as a control gruop)
- Force enable prefetch if local predictor prefetching is enabled

R=davidben@chromium.org, jkarlin@chromium.org

Review URL: https://codereview.chromium.org/330063004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278496 0039d316-1c4b-4281-b951-d872f2087c98

BluetoothRemoteGattServiceChromeOS now sends a GattServiceChanged observer event
when a new value for a characteristic property is received. This is needed when
the "Characteristic Extended Properties" descriptor is present for a
characteristic and its value is asynchronously read by bluetoothd, which results
in a PropertiesChanged signal for the "Flags" property of GattCharacteristic1.

BUG=382253

Review URL: https://codereview.chromium.org/346743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278495 0039d316-1c4b-4281-b951-d872f2087c98

Will sort out flakiness ASAP.

BUG=385475
TEST=test only change
R=jam@chromium.org
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/331313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278494 0039d316-1c4b-4281-b951-d872f2087c98