- 22 Jul, 2016 40 commits
-
-
sdefresne authored
Usually iOS framework bundle will be included in an application so have them define a ${target}+bundle target that can be used to depend and cause the copy into the application bundle. BUG=629867 Review-Url: https://codereview.chromium.org/2172733003 Cr-Commit-Position: refs/heads/master@{#407129}
-
fs authored
The <base> URL can change between the attribute (href) is updated and the shadow tree constructed. This causes confusion in the target resolving code since it can produce different results at different points in time. Only resolve the URL on changes (to 'href'), extract the fragment identifier and store whether the reference is local or not. Refactor the SVGUseElement target element lookup with an eye to future handling of "fragment-only" (local) URLs. This makes the externalDocument in SVGURIReference::targetElementFromIRIString unused, so remove that codepath and simplify the function accordingly. This changes behavior from resolving the URL and target element when needed (depending on when layouts happen), to only when the 'href' is mutated. This new behavior matches Edge, but not Gecko. BUG=601203, 470608 Review-Url: https://codereview.chromium.org/2173453002 Cr-Commit-Position: refs/heads/master@{#407128}
-
sdefresne authored
iOS framework requires a valid Info.plist file, so add support for generating it to ios_framework_bundle template. BUG=629867 Review-Url: https://codereview.chromium.org/2164393002 Cr-Commit-Position: refs/heads/master@{#407127}
-
fs authored
These two CSSValue classes are used to represent the same semantic, which is a reference to an element by means of a "url(...)" function. CSSSVGDocumentValue carries additional state to be able to handle references to external documents, by caching a DocumentResource. Move all the DocumentResource state to CSSURIValue, while also keeping the naming of the URL string (m_url). Also do some minor cleanup, for instance by removing "SVG" from the cachedSVGDocument() method name and dropping some unnecessary .get()s. This bloats CSSURIValue a bit for the cases where the DocumentResource is not utilized, but this bloat will be reduced (in relative terms) with future developments. On the "pro"-side is naturally that we now don't have to extend two CSSValue classes with additional functionality and state. BUG=470608, 405315 Review-Url: https://codereview.chromium.org/2165833006 Cr-Commit-Position: refs/heads/master@{#407126}
-
msramek authored
Revert of Roll buildtools 55638fe5c3..60f7f9a8b4 (patchset #1 id:1 of https://codereview.chromium.org/2166993002/ ) Reason for revert: Speculative revert - this probably broke the official build - see crbug.com/630514 for more details. Will reland if the suspicion was wrong. Original issue's description: > Roll buildtools 55638fe5c3..60f7f9a8b4 > > In order to roll GN af92718f..1f417360 (r405547:r406705) and pick up > the following changes: > > 267b1de9 Make `gn refs` handle files in data directories properly. > 5fc3fafd Add TaskPriority as a parameter to SequencedWorkerPool in preparation for TaskScheduler experiment. > aca08753 Make `gn refs` look at script files. > 05316e06 Re-land r406064 "[GN] Add JSON project writer". > 5a1b4b17 Revert of [GN] Add JSON project writer (patchset #11 id:200001 of https://codereview.chromium.org/2064533002/ ) > d2edeb9a [GN] Add JSON project writer > f0544fc6 Remove calls to MessageLoop::current() in tools. > d93e5cf4 Document GN invoker and target name variables. > > TBR=dpranke@chromium.org > > Committed: https://crrev.com/d8a18dc3820a4d54d8fc9ad8667d242798f10d33 > Cr-Commit-Position: refs/heads/master@{#406727} TBR=dpranke@chromium.org,brettw@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2171273002 Cr-Commit-Position: refs/heads/master@{#407125}
-
jkrcal authored
This CL adds a generic throttler of requests that - checks new requests against daily quota (configurable by Finch), - reports to UMA status of each request w.r.t. the quota, - reports to UMA the total count of request per day. As an example application, it adds throttler for NTPSnippetsFetcher. This throttler will be used in another CL. BUG=627073 Review-Url: https://codereview.chromium.org/2158843002 Cr-Commit-Position: refs/heads/master@{#407124}
-
Rebaseline Bot authored
https://chromium.googlesource.com/chromium/src/+/b856aa2c6 BUG=104922 TBR=tkent@chromium.org Review URL: https://codereview.chromium.org/2173763002 . Cr-Commit-Position: refs/heads/master@{#407123}
-
nednguyen authored
This CL also renames mobile_facebook_login.LoginAccount to facebook_login.LoginWithMobileSite. Motivation: later we will add a login method for facebook desktop, hence generalize this module to support both. BUG=589726 Review-Url: https://codereview.chromium.org/2166743005 Cr-Commit-Position: refs/heads/master@{#407122}
-
dgn authored
Original issue's description: > Changes the lines to go from always 2 to at most 2 by default, so that > we don't show empty lines on very large screens. > For smaller screens, the title can go up to 4 lines, and we then hide > the description. > On bigger screens, we add space on the side of the cards > > Measures used: > < 360dp: Narrow -> 4 lines title > >= 360dp: Regular -> 2 + 2 lines > >= 600dp: Wide -> 2 + 2 lines, 48dp gutters around the cards > > Preview: https://goo.gl/photos/prJ42tvP4jzwiCn3A Was reverted as https://codereview.chromium.org/2167973004/ Reason for revert: > Broke Android compile: > NewTabPageAdapterTest.java:162: error: constructor NewTabPageAdapter in > class NewTabPageAdapter cannot be applied to given types; > NewTabPageAdapter ntpa = new NewTabPageAdapter(mNewTabPageManager, null, mSnippetsBridge); > ^ > required: NewTabPageManager,NewTabPageLayout,SnippetsBridge,UiConfig > found: NewTabPageManager,<null>,SnippetsBridge > reason: actual and formal argument lists differ in length TBR=bauerb@chromium.org,mvanouwerkerk@chromium.org,peconn@chromium.org,dbeam@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. BUG=625628, 624333 Review-Url: https://codereview.chromium.org/2173723002 Cr-Commit-Position: refs/heads/master@{#407121}
-
msramek authored
Revert of Support early associated interface binding on ChannelMojo (patchset #7 id:120001 of https://codereview.chromium.org/2163633003/ ) Reason for revert: Probable cause of failures on Mac ASan. See crbug.com/630564 for more details. Original issue's description: > Support early associated interface binding on ChannelMojo > > Changes the associated bindings implementation for ChannelMojo > such that remote interfaces can be acquired immediately upon > ChannelMojo construction rather than having to wait for connection > on the IO thread. > > Simplifies the Channel bootstrapping process, removing a round-trip > Init message (and in fact the entire IPC::mojom::Boostrap interface) > since there's no need to actually exchange associated interface handles > over the pipe. Instead both sides can assume the other will use a fixed, > reserved endpoint ID for their IPC::mojom::Channel interface. > > This also removes the restriction that associated interfaces must be > added to a Channel after Init. Instead the same constraints apply as > with AddFilter: an associated interface, like a filter, may be added > at any time as long as either Init hasn't been called OR the remote > process hasn't been launched. > > The result of this CL is that any place it's safe to AddFilter, > it's also safe to AddAssociatedInterface; and any place it's safe to > Send, it's also safe to GetRemoteAssociatedInterface and begin using > any such remote interface immediately. > > Remote interface requests as well as all messages to remote interfaces > retain FIFO with respect to any Send calls on the same thread. Local > interface request dispatch as well as all messages on locally bound > associated interfaces retain FIFO with respect to any OnMessageReceived > calls on the same thread. > > BUG=612500,619202 > > Committed: https://crrev.com/e1037f997da9e1d44ca3b09d4ff32f0465673091 > Committed: https://crrev.com/508da24622f957a01b076ccd058bfdccc79068a4 > Cr-Original-Commit-Position: refs/heads/master@{#406720} > Cr-Commit-Position: refs/heads/master@{#407050} TBR=yzshen@chromium.org,rockot@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=612500,619202 Review-Url: https://codereview.chromium.org/2173753002 Cr-Commit-Position: refs/heads/master@{#407120}
-
ivoc authored
Also adds a timeout to the test, to prevent an infinite loop when no file is produced, or the filename is different than expected. BUG=webrtc:4741 Review-Url: https://codereview.chromium.org/2131133002 Cr-Commit-Position: refs/heads/master@{#407119}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/482fb9de..1a2021bc Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2176583002 Cr-Commit-Position: refs/heads/master@{#407118}
-
bugsnash authored
https://codereview.chromium.org/2053273002/ Review-Url: https://codereview.chromium.org/2175603002 Cr-Commit-Position: refs/heads/master@{#407117}
-
ehmaldonado authored
This is to make peerconnection-call.html and webrtc_browsertest.cc more readable BUG=6135 Review-Url: https://codereview.chromium.org/2167133002 Cr-Commit-Position: refs/heads/master@{#407116}
-
bugsnash authored
Review-Url: https://codereview.chromium.org/2171173002 Cr-Commit-Position: refs/heads/master@{#407115}
-
karandeepb authored
Crash reports beginning from Chrome V48 suggest that CreateUTIFromExtension may return nil. This causes a crash when the uti string is added to the NSMutableSet which holds the uti strings corresponding to the extension dropdown. This CL does a nil check before adding the string to the set, which should prevent the crash. BUG=630101 Review-Url: https://codereview.chromium.org/2164223003 Cr-Commit-Position: refs/heads/master@{#407114}
-
msramek authored
This reverts commit ea728cb1. Reason for revert: Broken Linux ChromiumOS Tests. TBR=bmcquade@chromium.org,shivanisha@chromium.org,isherman@chromium.org BUG=630549 Review-Url: https://codereview.chromium.org/2172183002 Cr-Commit-Position: refs/heads/master@{#407113}
-
kojii authored
W3C discussion[1] resolved to allow observing the style attribute. CEReactions are added to CSSStyleDeclaration interface[2]. Ported from a canceled patch for Custom Elements V0[3]. [1] https://github.com/w3c/webcomponents/issues/521 [2] https://drafts.csswg.org/cssom/#cssstyledeclaration [3] https://codereview.chromium.org/1446933002 BUG=594918 Review-Url: https://codereview.chromium.org/2166213002 Cr-Commit-Position: refs/heads/master@{#407112}
-
yoichio authored
Rename and sort variables, Extract function body to receive and return Position. TEST=No change in behavior. Review-Url: https://codereview.chromium.org/2177433002 Cr-Commit-Position: refs/heads/master@{#407111}
-
bzanotti authored
BUG=627675,627872 Review-Url: https://codereview.chromium.org/2159393003 Cr-Commit-Position: refs/heads/master@{#407110}
-
yukishiino authored
createClosure() is abused in ScriptPromise{,Resolver}Test, so, simply removes it. BUG=626266 Review-Url: https://codereview.chromium.org/2144413004 Cr-Commit-Position: refs/heads/master@{#407109}
-
hayato authored
HTMLElement::dirAttributeChaged() calls FlatTreeTraversal::parent(*this) unconditionally. Since Blink does not support "slots in a flat tree", we should return early here for a slot element. BUG=627385 Review-Url: https://codereview.chromium.org/2172133002 Cr-Commit-Position: refs/heads/master@{#407108}
-
jkrcal authored
The call to base::LinearHistogram::FactoryGet may simply look wrong without the explanation. Review-Url: https://codereview.chromium.org/2169863003 Cr-Commit-Position: refs/heads/master@{#407107}
-
machenbach authored
Remove chromium defaults for v8_optimized_debug and v8_use_external_startup_data. This is not needed after v8 provides these defaults: https://codereview.chromium.org/2025803003/ https://codereview.chromium.org/2024833002/ It also interferes if somebody tries to override the gn args with a different value. BUG=chromium:616034 TBR=alokp@chromium.org, brettw@chromium.org Committed: https://crrev.com/0fffeb2adaa3c284b760922c1aecce1516b998ce Review-Url: https://codereview.chromium.org/2058033002 Cr-Original-Commit-Position: refs/heads/master@{#406067} Cr-Commit-Position: refs/heads/master@{#407106}
-
tkent authored
-webkit-appearance:menulist, which is the default appearance of menulist SELECT, uses fixed font sizes, auto height, and the fixed font family. Ignoring such style was not good for platform-predictability. After this CL, -webkit-appearance:menulist automatically fallbacks to -webkit-appearnce:menulist-button by font-size, height, font-family CSS properties. This CL also changes the default rendering of <input type=color list> because it uses -webkit-appearance:menulist with a fixed height. The new rendering is better because its height is same as the default rendering of <input type=color>. BUG=104922 Review-Url: https://codereview.chromium.org/2171133003 Cr-Commit-Position: refs/heads/master@{#407105}
-
hayato authored
This DCHECK just rephrases the result of the previous line. BUG=630141 Review-Url: https://codereview.chromium.org/2174693002 Cr-Commit-Position: refs/heads/master@{#407104}
-
yamaguchi authored
.detail-checkmark creates a new containing block by position:absolute so that it is always clickable, but the thumbnail icons should not do that. BUG=630236 Review-Url: https://codereview.chromium.org/2166353002 Cr-Commit-Position: refs/heads/master@{#407103}
-
sdefresne authored
Allow to specify dependencies that are only used by the create_bundle target when using ios_app_bundle or ios_framework_bundle templates to increase parallelism. BUG=629867 Review-Url: https://codereview.chromium.org/2169973002 Cr-Commit-Position: refs/heads/master@{#407102}
-
lizeb authored
When a Custom Tabs client dies, the Android framework sends a notification to an IBinder.DeathRecipient. This is relayed by CustomTabsSessionToken to CustomTabsConnection#cleanUpSession(). If this method is called from a different thread than the UI thread, then this triggers a native crash. Avoid that crash by making sure that mClientManger#cleanupSession() (and then CustomTabsConnection#cancelPrerender()) is called from the UI thread. Also add a non-regression test. BUG=623128 Review-Url: https://codereview.chromium.org/2158843003 Cr-Commit-Position: refs/heads/master@{#407101}
-
yoichio authored
global functions. Make Node::isContentEditable and Node::isRichEditable global functions. This CL also re-introduce HTMLElement::isContentEditable because it is a web-exposed IDL attribute. This is a preparation to move these functions from core/dom to core/editing/ TEST=No change in behavior Review-Url: https://codereview.chromium.org/2121313003 Cr-Commit-Position: refs/heads/master@{#407100}
-
yosin authored
This patch converts "editing/deleting/delete-ws-fixup-00[1234].html" to use w3c test harness and consolidates into "delete_ws_fixup.html" to simplify test files. This patch is a preparation of getting rid of grammar checking feature. BUG=619452 TEST=n/a; this patch changes a test file Review-Url: https://codereview.chromium.org/2174683002 Cr-Commit-Position: refs/heads/master@{#407099}
-
yosin authored
This patch converts "editing/deleting/delete-trailing-ws-00[12].html" to use w3c test harness and consolidates into "delete_trailing_ws.html" to simplify test files. This patch is a preparation of getting rid of grammar checking feature. BUG=619452 TEST=n/a; this patch changes a test file Review-Url: https://codereview.chromium.org/2174673002 Cr-Commit-Position: refs/heads/master@{#407098}
-
yosin authored
This patch converts "editing/deleting/delete-to-select-table.html" to use w3c test harness and consolidates into "delete_tab.html" to simplify test files. This patch is a preparation of getting rid of grammar checking feature. BUG=619452 TEST=n/a; this patch changes a test file Review-Url: https://codereview.chromium.org/2169323002 Cr-Commit-Position: refs/heads/master@{#407097}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5bc62d66..482fb9de Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2169353002 Cr-Commit-Position: refs/heads/master@{#407096}
-
sdefresne authored
Keep the name of the target generating the executable in ios_app_bundle template the same whether the final binary is a fat or thin binary. BUG=629867 Review-Url: https://codereview.chromium.org/2167933003 Cr-Commit-Position: refs/heads/master@{#407095}
-
vasilii authored
BUG=629459 Review-Url: https://codereview.chromium.org/2166823004 Cr-Commit-Position: refs/heads/master@{#407094}
-
sdefresne authored
The XCTest support (used for EarlGrey tests) requires linking against XCTest.framework whose location is relative to sdk-platform-path, so propagate via ios_sdk_platform_path variable in gn. BUG=629867 Review-Url: https://codereview.chromium.org/2168873003 Cr-Commit-Position: refs/heads/master@{#407093}
-
groby authored
Clarify function call parameter. BUG=none R=esprehn@chromium.org Review-Url: https://codereview.chromium.org/2145613002 Cr-Commit-Position: refs/heads/master@{#407092}
-
joone.hur authored
Here is a DOM state when we only add a blockquote. <div contenteditable><blockquote>|<br></blockquote></div> After indenting the blockquote, the change is as follows: <div contenteditable> <blockquote> <blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;"> <blockquote>|<br></blockquote> </blockquote> </blockquote> </div> There is an unnecessary blockquote so the result should be as follows: <div contenteditable> <blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;"> <blockquote>|<br></blockquote> </blockquote> </div> This CL removes the additional blockquote. BUG=625802 TEST=editing/execCommand/indent-empty-quote.html Review-Url: https://codereview.chromium.org/2175433002 Cr-Commit-Position: refs/heads/master@{#407091}
-
chromeos-commit-bot authored
Cr-Commit-Position: refs/heads/master@{#407090}
-