GitLab

Add another experiment group to the Modern testing config so that Modern
isn't default enabled for tests. Enabling Modern requires restarting
Chrome twice, so having it default enabled for tests can lead to
flakiness.

BUG=

Change-Id: I822dfcdae7238782f9adf73a0ad0b65ac0a6e264
Reviewed-on: https://chromium-review.googlesource.com/1178900
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583912}

https://pdfium.googlesource.com/pdfium.git/+log/d5e282648a08..136342d950c9


git log d5e282648a08..136342d950c9 --date=short --no-merges --format='%ad %ae %s'
2018-08-16 tsepez@chromium.org Remove arguments from CPWL_Edit::SetAlignFormatV().
2018-08-16 tsepez@chromium.org Remove optional argument from CXFA_LayoutProcessor::StartLayout()
2018-08-16 tsepez@chromium.org Replace optional bool bDrawFocus with enum type.
2018-08-16 tsepez@chromium.org Remove optional argument from ResolveNodes_GetParent().


Created with:
  gclient setdep -r src/third_party/pdfium@136342d950c9

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I200b3a375574eeb0688a5be125b3907b203f5fc9
Reviewed-on: https://chromium-review.googlesource.com/1179161Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583911}

R=khorimoto@chromium.org

Bug: 850823
Change-Id: Ibca38ed4f647bfae91a692664709beffb7d41623
Reviewed-on: https://chromium-review.googlesource.com/1179070Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583910}

Change-Id: I8c76cf49161daf8cccaa1cfc32db8fcd930f01da
Reviewed-on: https://chromium-review.googlesource.com/1178692Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583909}

This condition was added originally in this patch:
https://codereview.chromium.org/27200003

That patch was trying to trigger early deadlines when the compositor
thread had work to do but the main thread had aborted.

In a world where we have begin frame acks even when frames aren't
produced, it's worth triggering early deadlines even when the compositor
thread doesn't have any work to do either so that the display compositor
can go ahead and do work earlier.

This is intended as a short-term fix to solve smoothness issues with
surface for video with 30fps videos.  Ideally the DisplayCompositor will
have some followups as well so that one client that is slow to respond
will not cause smoothness issues with another client.

Bug: 874676
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I8b6663570aba7d135c1f211a21c37b1e17d19577
Reviewed-on: https://chromium-review.googlesource.com/1176559
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583908}

https://chromium.googlesource.com/native_client/src/native_client.git/+log/cadf57874526..c43b409d9688


git log cadf57874526..c43b409d9688 --date=short --no-merges --format='%ad %ae %s'
2018-08-16 dschuff@chromium.org Only run 64 bit builds on mac


Created with:
  gclient setdep -r src/native_client@c43b409d9688

The AutoRoll server is located here: https://nacl-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:868204
TBR=mseaborn@chromium.org

Change-Id: If16532e2c0c00d46397143533d1b8321a971ca53
Reviewed-on: https://chromium-review.googlesource.com/1178543Reviewed-by: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583907}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/95fb6dc81034..15b1778c2c45


git log 95fb6dc81034..15b1778c2c45 --date=short --no-merges --format='%ad %ae %s'
2018-08-16 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@15b1778c2c45

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I2858367981054e1557c83956847866b82f5179ae
Reviewed-on: https://chromium-review.googlesource.com/1178944Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583906}

1. Skip HTML attributes created by Chrome in the xpath builder.
2. Made allowance for the edge case when a page hides the input element that triggers autofill.
3. Remove an unnecessary message exchange between the tab frame content script and the extension background script.
The background script has information on each tab frame.
When the background script sends a message to the content script to start recording, the content script
sends another message back to the background script to obtain the frame information. After this change,
the background script will send the frame information directly in the start recording message.

Bug: 855284
Change-Id: Ifd696f0e4617392ef989e5af0b5d38acd259f467
Reviewed-on: https://chromium-review.googlesource.com/1178306
Commit-Queue: Yiming Zhou <uwyiming@google.com>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#583905}

The "Passwords" item in the Clear Browser Data dialog
(DATA_TYPE_PASSWORDS) also covers WebAuthentication credentials stored
by the internal Touch ID platform authenticator, where available. (See
crrev.com/c/1125177). This updates the string to reflect that.

Change-Id: Iaea648c1f88dabb96deb7c0cefec4804b45fec71
Reviewed-on: https://chromium-review.googlesource.com/1174940Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#583904}

This CL workaround https://crbug.com/856818 . We don't know how we ended
up having a mask layer without an applicable mask or clip-path being
found during property tree building, but at least we should not crash.

BUG=856818

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib62e0ebd6fad4f52a05a57bb4277b4411f3fecfd
Reviewed-on: https://chromium-review.googlesource.com/1178988Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583903}

This uses the new PendingAppManager API to install the messages
PWA once setup has been successfully completed. Currently, the
API does not grab the app icon or properly launch in a standalone
window, but fixes for those will be coming shortly.

Bug: 873901
Change-Id: Ib42ef185c5a70fc5207a7bcf882ca54280e6e4bd
Reviewed-on: https://chromium-review.googlesource.com/1173737Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583902}

Some entries on the HSTS preload list are redundant and covered by a
parent domain or TLD (that has include_subdomains = true). This change
removes those redundant entries.

Change-Id: Ib20d7033d64d77394401ca271980ed1e829007bb
Reviewed-on: https://chromium-review.googlesource.com/1173144Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583901}

Made a minor change to make sure that SetupTestServer interacts
properly with the new _ConnectPortForwardingTask and ForwardingScheme
versions.

Change-Id: I16add737f7595fac416973c1296882f9f40d0dc1
Reviewed-on: https://chromium-review.googlesource.com/1178381Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583900}

This CL: https://chromium-review.googlesource.com/c/chromium/src/+/1162862 got rid of the icon highlight. This change brings back the behavior where the icon is highlighted when the corresponding bubble is active.

Bug: 855186
Change-Id: Ifda765890bbc181af67ef0a435501a329fdd8470
Reviewed-on: https://chromium-review.googlesource.com/1179124Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#583899}

And also skips WebStateObserver::OnNavigationItemCommitted() callback
if the navigation has a placeholder URL.

These changes are helpful to differentiate a new request that hasn't
started error handling state transitions, which means it may still
succeed, and a request that has already failed and is in the middle of
loading the error view. The differentiation is useful for integrating
offline reading list with slim nav (crbug.com/840782).

More directly, this change fixes VoiceSearchNavigationTest, which needs
a placeholder entry to be loaded into the WebView before calling
LoadHtml(), but the placeholder entry must not consume the
WillLoadVoiceSearchResult() flag, which is cleared in
OnNavigationItemCommitted callback. Parameterized
VoiceSearchNavigationTest on both navigation manager implementations.

This situation does not arise in production because LoadHtml() is a
test only API. In production, placeholder URLs are only triggered for
app-specific URL or error view, neither of which triggers
OnNavigationItemCommitted on the placeholder load.

Bug: 863026
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic4eda9f46b59886a2d24169b630aa8179373f7fb
Reviewed-on: https://chromium-review.googlesource.com/1176240
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583898}

Bug: 873866
Change-Id: I260aaf9bb1b7162e651d09595231b565d56c1958
Reviewed-on: https://chromium-review.googlesource.com/1173022Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583897}

https://webrtc.googlesource.com/src.git/+log/b005087a8cac..984f1a80c001


git log b005087a8cac..984f1a80c001 --date=short --no-merges --format='%ad %ae %s'
2018-08-16 buildbot@webrtc.org Roll chromium_revision 04aa516a..012c9b03 (583667:583774)


Created with:
  gclient setdep -r src/third_party/webrtc@984f1a80c001

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ie0cec04b56faf26e70c597914664ccbb9cd265d5
Reviewed-on: https://chromium-review.googlesource.com/1178905Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583896}

Previously, hosted apps were exempt from LockToOrigin() even in
--site-per-process mode.  That meant that hosted apps were not subject
to enforcements such as not allowing access to cookies, passwords, or
local storage of other sites.  Worse, it meant that hosted apps could
arbitrarily share a process (e.g., when over process limit), even if
they covered different web sites with --site-per-process.

This CL starts locking hosted apps to their underlying web origin.  If
a frame commits a navigation to URL http://foo.com, which is part of a
hosted app X's web extent, the process for that frame will be locked
to http://foo.com.  Note that the SiteInstance for this frame will
still use a site URL based on the effective URL (i.e.,
chrome-extension://<ext_id_for_X>/), but the origin lock will not be
based on effective URLs.  This requires plumbing to compute the origin
lock as a site URL that does not use an effective URL, and to plumb it
into various places that make process model decisions, such as
RPHI::IsSuitableHost().

Bug: 811939, 794315, 791796
Change-Id: Icc9b3c0a04253e581ea35953f3c566308305db59
Reviewed-on: https://chromium-review.googlesource.com/959346
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583895}

We are going to deprecate importScripts() of new scripts after
service worker installation as described in the intent to
deprecation[1]. This CL adds deprecation message for use of
such importScripts().

[1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/a6P-niHWgF4/CtJEHCnKDwAJ

Bug: 719052
Change-Id: I6630b5c436605ab4fdbc9fb783c166b96dc4d760
Reviewed-on: https://chromium-review.googlesource.com/1177202Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583894}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb6c3f056b91..f04be3a84fdd


Created with:
  gclient setdep -r src-internal@f04be3a84fdd

The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I5c36b488eb8781a719fab94482a31c6e2dda0a3f
Reviewed-on: https://chromium-review.googlesource.com/1178904Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583893}

Add sheet view to show when prompting users to use their phone as a
security key to authenticate via the WebAuthN API.

Bug: 847985
Change-Id: I0bb605bf470456f5f29111834f69a71abfbe0430
Reviewed-on: https://chromium-review.googlesource.com/1177445
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583892}

Without this CL breakpoints manager listens for UISourceCodeRemoved
and ProjectRemoved events to reset locations when UISourceCode is gone.
It should use live locations instead.

Drive-by: fixed bug with breakpoints when UISourceCode with formatted
source is gone.

R=lushnikov@chromium.org

Bug: none
Change-Id: I3d23ff9e1ba7452d5e005cbc74e27119cda6eac7
Reviewed-on: https://chromium-review.googlesource.com/1178223
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583891}

Switched Recurrent Interstitials to enabled by default, in pref mode
for Android and in memory mode for other platforms.

Bug: 840575
Change-Id: Iaa6b6b83312007f81ae28655070004777f7aba87
Reviewed-on: https://chromium-review.googlesource.com/1178991Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583890}

Add a level of indirection in shelf_constants to make it easier to
provide the right value between new/old UI.

Bug: 874180
Bug: 805612
Change-Id: Ied47fadba3e62b842060a83605aa073d400ec438
Reviewed-on: https://chromium-review.googlesource.com/1175443
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583889}

Future commits will need it, as installing web apps from their URL will
need to know whether or not those web apps (and their underlying
extensions) are already installed.

Bug: 855281
Change-Id: Ic147ca4c6ab01f33b06039168e59d7ec2bc28c1b
Reviewed-on: https://chromium-review.googlesource.com/1176884Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583888}

Separate content storage out of feed storage. This CL only implement
content storage part, but did not delete content code in storage yet.
Next CL will implement journal storage and delete feed storage.

Basically, copy content code from FeedStorageDatabase.h and .cc to
FeedContentDatabase.h and .cc, from feed_storage_bridge.h and .cc to
feed_content_bridge.h and .cc, from FeedStorageBridge.java to
FeedContentBridge.java, did not remove content code from
FeedStorageDatabase, will delete them in next CL.

Bug:871349

Change-Id: If75676267130838ccd03165d41517541705ce2a1
Reviewed-on: https://chromium-review.googlesource.com/1163077
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583887}

Some TextSuggestionsTouchBarController unit tests were missing
comments. Comments were added where necessary.

Bug: 717553
Change-Id: I5e41114a5618899bba61d4867d17634ab151fcfc
Reviewed-on: https://chromium-review.googlesource.com/1178575Reviewed-by: Sarah Chan <spqchan@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583886}

Previously on a non-Mac platform when JS dialog is dismissed by user
closing the tab, |DIALOG_BUTTON_CLICKED| is logged. This change
separates the case of the user replying to the dialog with the buttons
vs rejecting it.

Bug: 872795
Change-Id: I4b8781daeb3cead5ee4e975a67f79f94b7fa84e5
Reviewed-on: https://chromium-review.googlesource.com/1164647Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583885}

Make WebAuthN UI modals appear after all fields of
TransportAvailabilityInfo have been set by FidoRequestHandlerBase. Also,
Add rp_id to TransportAvailabilityInfo struct as rp id is shown in the
UI dialogs.

Bug: 847985
Change-Id: I0c5341dfd98a192553ebd868461df405a5c0a5b1
Reviewed-on: https://chromium-review.googlesource.com/1176701Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583884}

This reverts commit 7acc0647.

Reason for revert: The builder seems to work now. (Note: It currently
only compiles everything and doesn't run any tests yet.)

Original change's description:
> Remove win-asan from console view again for a bit.
> 
> Getting bots for the builder is taking longer than expected, and having a
> perma-purple bot on the main waterfall isn't so great.
> 
> I'll revert this again once hardware for the builder has been allocated and
> configured.
> 
> Bug: 869973
> Change-Id: I702c4694eb13cc39cc07bc01f19a6f7871e9f47c
> Reviewed-on: https://chromium-review.googlesource.com/1166170
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581400}

TBR=thakis@chromium.org,dpranke@chromium.org,sergeyberezin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 869973
Change-Id: Id4498b0cb964a22d33e5b7f76b135c8d560a7291
Reviewed-on: https://chromium-review.googlesource.com/1179001Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583883}

Defines a base::debug::WriteClangCoverageProfile() API which performs
an explicit call to __llvm_profile_dump() in CLANG_COVERAGE builds, with
locking to ensure thread-safety.

This API is invoked in the base::debug::BreakDebugger() and
base::Process::TerminateCurrentProcessImmediately() APIs, immediately
prior to them terminating the process, to mirror the coverage-writing
step that would be performed via an at-exit handler during a normal
process-exit.

This ensures that we get as complete coverage data as possible from
processes which fast-terminate/break (e.g. EXPECT_DEATH() sub-processes,
e.g. browser child processes, etc).

Bug: 849369
Change-Id: I38262334bb5abf8d5ba40c2c32352b38096905ec
Reviewed-on: https://chromium-review.googlesource.com/1172932Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583882}

Bug: b:112645619

Change-Id: I572cfdf4e58cb102666f59eb931fa95337404f69
Reviewed-on: https://chromium-review.googlesource.com/1175079Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Eyor Alemayehu <eyor@google.com>
Cr-Commit-Position: refs/heads/master@{#583881}

Strings to appear on Assistant suggestion chips.

Bug: b:111694337
Change-Id: Ia5bde63a25341e5083859329bade28648dd3df46
Reviewed-on: https://chromium-review.googlesource.com/1178934Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#583880}

Bug: 859052
Change-Id: Ic1113d8e4200f46bb3f49e1a2c72cbedaba1eef5
Reviewed-on: https://chromium-review.googlesource.com/1178890
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583879}

Bug: 874658
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I576d2877ec71df8e489d349916f758ba6fe74263
Reviewed-on: https://chromium-review.googlesource.com/1176725Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583878}

WebLocalFrame::ReportFindInPageMatchCount and ReportFindInPageSelection
are only called by plugin code. This CL changes the plugin code to call
those functions on FindInPage directly and removes the functions.

Bug: 819919
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I5df288ac6ce934ec0f6b27b47c17025005a73bad
Reviewed-on: https://chromium-review.googlesource.com/1176898Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583877}

Bug: 851163
Change-Id: I6a6aa135f9e1cab496ad6b7fe007bdc8e1ac94f0
Reviewed-on: https://chromium-review.googlesource.com/1178632Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Felipe Salazar <felipesalazar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583876}

Bug: 874758
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I31e474ab9736b96ed1da400dcca7206a650b87fb
Reviewed-on: https://chromium-review.googlesource.com/1178936Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583875}

Change-Id: I47afa414206783dfaf18997578a953c3f630c3ff
Reviewed-on: https://chromium-review.googlesource.com/1178742
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583874}

Use network quality tracker instead of network quality estimator (NQE)
in UKM page load metrics.

Network quality tracker can provide network service when network
service is enabled as well as when network service is disabled.

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Icffe39d2ae493934456ff911290bc50d53efab49
Bug: 819244
Reviewed-on: https://chromium-review.googlesource.com/1177199
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583873}