GitLab

TBR=ncbray@chromium.org
BUG=428838

Review URL: https://codereview.chromium.org/695493003

Cr-Commit-Position: refs/heads/master@{#302109}

BUG=414189
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/694583002

Cr-Commit-Position: refs/heads/master@{#302108}

A Search client is created during initialization of
EnhancedBookmarkBridge. And when the bridge destructs, search service is
also destroyed.

BUG=415774

Review URL: https://codereview.chromium.org/637323005

Cr-Commit-Position: refs/heads/master@{#302107}

The iOS whitelist was incomplete but things were still working due to
a bug in grit where some resources are being added even if they are not
in the whitelist. The fix for that grit bug is in
https://chromiumcodereview.appspot.com/669763002/

Also, the dependency on ui/native_theme is removed from iOS
because it is unused, allowing the resources to be omitted from the
.pak file.

BUG=None

Review URL: https://codereview.chromium.org/667223003

Cr-Commit-Position: refs/heads/master@{#302106}

Enabled a11y audit test.
Made the tests async in order to run the a11y audit after the UI is settled down.

Fix issue where decorative icon had no descriptive text. Added alt="".
Fix issue where margins were obscured by a warning dialog but were still accessible. When elements are obscured by the overlay, they are now hidden.

Cleaned up redundant code by moving it into functions.

BUG=423178

Review URL: https://codereview.chromium.org/601083004

Cr-Commit-Position: refs/heads/master@{#302105}

It is used to catch problem where the audio fails silently.

BUG=428706

Review URL: https://codereview.chromium.org/685403002

Cr-Commit-Position: refs/heads/master@{#302104}

This test checks that following a cross-site link with rel="nofererrer" does not create a new SiteInstance per https://crbug.com/24447.  However, the test expectations should change with --site-per-process, as we do expect a process swap in this mode.  This is similar to how DontSwapProcessWithOnlyTargetBlank behaves (https://codereview.chromium.org/635933002/).

BUG=417518

Review URL: https://codereview.chromium.org/692703002

Cr-Commit-Position: refs/heads/master@{#302103}

Namely, -Winconsistent-missing-override. No behavior change.

BUG=428099

Review URL: https://codereview.chromium.org/682413003

Cr-Commit-Position: refs/heads/master@{#302102}

TBR=dtseng@chromium.org
BUG=428813

Review URL: https://codereview.chromium.org/689883004

Cr-Commit-Position: refs/heads/master@{#302101}

R=sleevi@chromium.org,davidben@chromium.org
CC=cloudview-eng
BUG=

Review URL: https://codereview.chromium.org/691593002

Cr-Commit-Position: refs/heads/master@{#302100}

Roll src/third_party/WebKit 3c0b008b9a93ea227fb57d0d23b93e8affc3af08:eacac493536b3feb666da91ef21b9072a6d2f5a1 (svn 184648:184653)

BUG=None
TBR=morrita

Review URL: https://codereview.chromium.org/694523003

Cr-Commit-Position: refs/heads/master@{#302099}

BUG=395405

Review URL: https://codereview.chromium.org/691003002

Cr-Commit-Position: refs/heads/master@{#302098}

Rename BroadcastNotificationDelegate to ExpireHistoryBackendDelegate and change
the implementation in HistoryBackend to send the notification as part of the
NotifyURLs{Modified,Deleted} method implementation.

Delete BroadcastNofiticationDelegate::BroadcastNotifications as it is no longer
required.

BUG=373326

Review URL: https://codereview.chromium.org/690733002

Cr-Commit-Position: refs/heads/master@{#302097}

This reverts commit c49ac404.

TBR=stevenjb@chromium.org
BUG=

Review URL: https://codereview.chromium.org/693493003

Cr-Commit-Position: refs/heads/master@{#302096}

BUG=

Review URL: https://codereview.chromium.org/686423003

Cr-Commit-Position: refs/heads/master@{#302095}

The WebView swaps container views when transitioning
from/to fullscreen. This change ensures that
anchor views are transferred across container views too.

We also remove the PowerSaveBlocker attached to the
ContentVideoView because as a result it is not longer
needed. We now reuse the PowerSaveBlocker attached to
the WebContents which is implemented as an anchor
view. This has a number of advantages:
1. The PowerSaveBlocker now works correctly between
   transitions from/to fullscreen.
2. A PowerSaveBlocker is now also created for video
   elements contained inside a div (for these a
   ContentVideoView is not created when going
   fullscreen).

This change depends on:
https://codereview.chromium.org/639923003/

This change also adds comprehensive tests to verify the
new behaviour. For this we need a longer video, so we
replace the old one-frame test video. We also refactor
the tests to remove flakiness and unnecessary complexity.

BUG=398485

Review URL: https://codereview.chromium.org/639413002

Cr-Commit-Position: refs/heads/master@{#302094}

Revert of Disable WebRTC benchmark due to flakiness. (patchset #1 id:1 of https://codereview.chromium.org/684023002/)

Reason for revert:
Committed fix for flakiness: https://codereview.chromium.org/688163003/

Original issue's description:
> Disable WebRTC benchmark due to flakiness.
>
> TBR=tonyg@chromium.org, phoglund@chromium.org
> BUG=428157
>
> Committed: https://crrev.com/64709a0055eb91ceb5d29b4d6bfdaefa8380143d
> Cr-Commit-Position: refs/heads/master@{#301753}

TBR=phoglund@chromium.org,tonyg@chromium.org,dpranke@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=428157

Review URL: https://codereview.chromium.org/688343002

Cr-Commit-Position: refs/heads/master@{#302093}

BUG=425996

Review URL: https://codereview.chromium.org/686503002

Cr-Commit-Position: refs/heads/master@{#302092}

This makes it easier to interpret log messages that contain enum values.

BUG=none

Review URL: https://codereview.chromium.org/689903002

Cr-Commit-Position: refs/heads/master@{#302091}

The code for importing/exporting pkcs8/spki is not specific to RSA. Extracting it so it can be shared by the EC implementation.

BUG=399094

Review URL: https://codereview.chromium.org/685213004

Cr-Commit-Position: refs/heads/master@{#302090}

This state should be decided according to aria-expanded attribute.

BUG=98982

Review URL: https://codereview.chromium.org/665843002

Cr-Commit-Position: refs/heads/master@{#302089}

Layout tests were previously running with visible_viewport_size uninitialized,
causing layout tests to fail when running with virtual-viewport mode enabled.

BUG=

Review URL: https://codereview.chromium.org/649673005

Cr-Commit-Position: refs/heads/master@{#302088}

There's a guess that the browser may be launching extremely slowly on
some bots and that when the browser main process is killed it's
leaking sub-processes that are in the middle of being spawned.
Increase the timeout to try to confirm this hypothesis.

BUG=424024
R=tonyg@chromium.org

Review URL: https://codereview.chromium.org/691683002

Cr-Commit-Position: refs/heads/master@{#302087}

This CL fixes the documentation of CrosSettings::PrepareTrustedValues()
which had gotten out of sync with the method's actual return value.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/690753002

Cr-Commit-Position: refs/heads/master@{#302086}

BM devices are enumerated and manipulated via DeckLink SDK.
Intermingling use of DeckLink SDK and AVFoundation seems to
produce bad results. This CL avoids adding these devices to the
AVFoundation enumeration.

BUG=426398, 408493

TEST=After running Chrome, plug in a thunderbolt Blackmagic
device, for instance an UltraStudio Mini. Wait 4 seconds or so,
then enumerate devices, e.g. using http://goo.gl/r0lnFQ. There
should be a number of UltraStudio Mini entries (or similar,
depending on which actual BM device is plugged in) but no
generic "Blackmagic" camera (those are the removed ones).

Review URL: https://codereview.chromium.org/690653002

Cr-Commit-Position: refs/heads/master@{#302085}

We decompose matrix, containing scale.
So we lose precision and get rotation due to
multiplication on 1.0/x instead of divide on x.

R=vollick@chromium.org

TEST=XFormTest.DecomposeTransform

Review URL: https://codereview.chromium.org/692593003

Cr-Commit-Position: refs/heads/master@{#302084}

As you indicated - this one is a simple re-ordering and can be TBR.

BUG=424679
TBR=sky@chromium.org
TEST=Covered by existing unit tests

Review URL: https://codereview.chromium.org/692883002

Cr-Commit-Position: refs/heads/master@{#302083}

Also updated presubmit script to not complain about default_for_enterprise_users
key in policy.

BUG=424190

Review URL: https://codereview.chromium.org/689953002

Cr-Commit-Position: refs/heads/master@{#302082}

Roll src/third_party/WebKit d4f55f9ea99bccd3b0fb321affca5c8e8ec96d7b:3c0b008b9a93ea227fb57d0d23b93e8affc3af08 (svn 184632:184648)

BUG=None
TBR=morrita

Review URL: https://codereview.chromium.org/694503002

Cr-Commit-Position: refs/heads/master@{#302081}

The migration is in support of Athena. InputAPI renamed VirtualKeyboardAPI to be more explicit as part of the migration. The Ash specific implementation details have been updated to depend only on Aura.

BUG=425702

Review URL: https://codereview.chromium.org/670003002

Cr-Commit-Position: refs/heads/master@{#302080}

R=jam@chromium.org, oshima@chromium.org
TBR=jam@chromium.org, oshima@chromium.org

Review URL: https://codereview.chromium.org/692863002

Cr-Commit-Position: refs/heads/master@{#302079}

R=sadrul@chromium.org,mfomitchev@chromium.org,ananta@chromium.org
TBR=sadrul@chromium.org,mfomitchev@chromium.org,ananta@chromium.org

Review URL: https://codereview.chromium.org/687363005

Cr-Commit-Position: refs/heads/master@{#302078}

Roll src/third_party/WebKit 5d4e6a45858acb9904edad8ec8ff267713c2bc4f:d4f55f9ea99bccd3b0fb321affca5c8e8ec96d7b (svn 184626:184632)

BUG=None
TBR=morrita

Review URL: https://codereview.chromium.org/685383002

Cr-Commit-Position: refs/heads/master@{#302077}

Now that https://codereview.chromium.org/651063002/ has landed it's time to reenable cache tests on Windows.

BUG=425541

Review URL: https://codereview.chromium.org/664283006

Cr-Commit-Position: refs/heads/master@{#302076}

Cr-Commit-Position: refs/heads/master@{#302075}

BUG=424469
NOTRY=true

Review URL: https://codereview.chromium.org/674053002

Cr-Commit-Position: refs/heads/master@{#302074}

This patch improves performance of CheckValidity() by removing calls to
leveldb::DB::Get() from loops.

As a result the performance improved by 1.92x on Yoshi, for a testing account
with a lot of files.

Note, that base::hash_map is used, as its much faster in this case. Using
std::map gave only 1.39x performance gain over the former solution.

TEST=unit_tests: *ResourceMetadataStorageTest*, also tested manually.
BUG=418873

Review URL: https://codereview.chromium.org/638543002

Cr-Commit-Position: refs/heads/master@{#302073}

Put now calls Delete before CreateEntry, this requires a new callback PutDidDeleteEntry.

BUG=426562

Review URL: https://codereview.chromium.org/649203005

Cr-Commit-Position: refs/heads/master@{#302072}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/671913008

Cr-Commit-Position: refs/heads/master@{#302071}

Remove the constraint that tab.url has to match the tab's URL, because
this limitation prevents extension authors from using the media stream
in a frame whose origin differs from the top-level frame.

Updated the documentation to document this new behavior, and also added
a note about the validity (lifetime) of streamId because this important
piece of information was not documented. The expiry time is documented
to be "a few seconds" instead of the actual ten seconds, to encourage
extension authors to only call chooseDesktopMedia when they are prepared
to immediately handle the stream when it becomes available.

BUG=425344

Review URL: https://codereview.chromium.org/669623007

Cr-Commit-Position: refs/heads/master@{#302070}