GitLab

BUG=405531

Review URL: https://codereview.chromium.org/499243002

Cr-Commit-Position: refs/heads/master@{#291872}

BUG=374321

Committed: https://chromium.googlesource.com/chromium/src/+/ee8f4e4029c09ba77e7dbb8fddd85186642b3de8

R=jschuh@chromium.org, noamsml@chromium.org, thestig@chromium.org, yzshen@chromium.org

Review URL: https://codereview.chromium.org/478183005

Cr-Commit-Position: refs/heads/master@{#291871}

Cleaning up weak_ptr_factory destruction order in "src/gpu" module.
WeakPtrFactory should remain the last member so it'll be destroyed and
invalidate its weak pointers before any other members are destroyed.

BUG=303818

Review URL: https://codereview.chromium.org/468913010

Cr-Commit-Position: refs/heads/master@{#291870}

scoped_refptr previously got this for free since it implemented operator
T*, but the conversion operator is being removed. This prevents awkward
looking code like *my_favorite_pointer.get().

BUG=110610

Review URL: https://codereview.chromium.org/505943002

Cr-Commit-Position: refs/heads/master@{#291869}

Speedometer on Android timesout, each iteration takes ~75 seconds on N7.
Limiting the iterations count to 3 on android, and enabling the test.

BUG=382517

Review URL: https://codereview.chromium.org/505903002

Cr-Commit-Position: refs/heads/master@{#291868}

BUG=87553

Review URL: https://codereview.chromium.org/502993002

Cr-Commit-Position: refs/heads/master@{#291867}

A different approach will be taken, where the add to app launcher flow
is initiated from the page info dialog.

BUG=378171

Review URL: https://codereview.chromium.org/488373002

Cr-Commit-Position: refs/heads/master@{#291866}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/507483003

Cr-Commit-Position: refs/heads/master@{#291865}

With this change, it is possible to assign INFINITY, NEGATIVE_INFINITY or NAN as a default value for any double or float field.

BUG=402216

Review URL: https://codereview.chromium.org/474063002

Cr-Commit-Position: refs/heads/master@{#291864}

After issue https://codereview.chromium.org/227473009 there is no code for
create OnScreen surface for Mac which is using in compositor_unittests.
Result:
18 tests crashed:
    LayerWithDelegateTest.ConvertPointToLayer_Medium
    LayerWithDelegateTest.ConvertPointToLayer_Simple
    LayerWithDelegateTest.DelegatedLayer
    LayerWithDelegateTest.SchedulePaintFromOnPaintLayer
    LayerWithDelegateTest.SetBoundsWhenInvisible
    LayerWithNullDelegateTest.SetBoundsSchedulesPaint
    LayerWithNullDelegateTest.Visibility
    LayerWithRealCompositorTest.CompositorObservers
    LayerWithRealCompositorTest.Delegate
    LayerWithRealCompositorTest.Draw
    LayerWithRealCompositorTest.DrawPixels
    LayerWithRealCompositorTest.DrawTree
    LayerWithRealCompositorTest.Hierarchy
    LayerWithRealCompositorTest.HierarchyNoTexture
    LayerWithRealCompositorTest.ModifyHierarchy
    LayerWithRealCompositorTest.Opacity
    LayerWithRealCompositorTest.ScaleReparent
    LayerWithRealCompositorTest.ScaleUpDown

If surface is created then all tests passed.

R=sievers@chromium.org, ccameron1@chromium.org, danakj@chromium.org

TEST=compositor_unittests

Review URL: https://codereview.chromium.org/504933002

Cr-Commit-Position: refs/heads/master@{#291863}

The purpose is to make those APIs have the same semantics as before. And
then we can selectively turn fields into non-nullable.

Mojom files that are not included in this change:
- surface-related files: the owner (jamesr) has landed some non-nullable
  fixes. It is possible that he has fully reviewed them. (I will confirm
  with him.)
- test files: have been examined.

BUG=324170
TEST=None

Review URL: https://codereview.chromium.org/502853002

Cr-Commit-Position: refs/heads/master@{#291862}

In the context menu, disabled items are not required so can be removed
instead of disabling them, so user donot tap on it.

BUG=395551

Review URL: https://codereview.chromium.org/494093003

Cr-Commit-Position: refs/heads/master@{#291861}

This test was flaky because it modified system properties. Moving it to
interactive_ui_tests should allow it the system control guarantees it
needs to complete successfully.

BUG=396344

Review URL: https://codereview.chromium.org/492623003

Cr-Commit-Position: refs/heads/master@{#291860}

BUG=397393
TEST=manually tested

Review URL: https://codereview.chromium.org/506583002

Cr-Commit-Position: refs/heads/master@{#291859}

BUG=398959

Review URL: https://codereview.chromium.org/489643002

Cr-Commit-Position: refs/heads/master@{#291858}

TBR=vogelheim@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/503053004

Cr-Commit-Position: refs/heads/master@{#291857}

Previously, AppListViewDelegate manually parsed the manifest. We now
have a proper parser class that generates appropriate errors for invalid
launcher_page fields in a manifest, with full valid and invalid unit
tests.

BUG=399131

Review URL: https://codereview.chromium.org/489753002

Cr-Commit-Position: refs/heads/master@{#291856}

This CL makes the DummySearchBoxBackground the standard SearchBoxView
background when using the experimental app list.

BUG=406222

Review URL: https://codereview.chromium.org/493293003

Cr-Commit-Position: refs/heads/master@{#291855}

This CL makes the app list contents view scroll vertically for the
experimental app list rather than horiztonally.

BUG=406222

Review URL: https://codereview.chromium.org/504033002

Cr-Commit-Position: refs/heads/master@{#291854}

Linux: install-debian.wheezy.sysroot.py should use build/detect_host_arch.py to detect the host architecture.

Review URL: https://codereview.chromium.org/505933002

Cr-Commit-Position: refs/heads/master@{#291853}

Currently AppListViewDelegate can hold on to references to a destroyed
Profile*. It's managed to escape crashing in most cases so far because
the LocalState pref is updated for the next time the app launcher is
shown. However, if the profile the app launcher is first created for is
ever deleted in the same session, then a crash usually follows (but
doesn't always create a crash dump, due to a corrupt stack).

This decouples the Profile from the AppListViewDelegate constructor to
make it clear the lifetimes are not in step. Then "SetProfile" correctly
tears down any references to an old profile, before setting a new one.

When the app list's active profile is deleted, the AppListViewDelegate
is destroyed by forcibly closing/destroying the AppList's widget via a
new method AppListServiceImpl::DestroyAppList().

BUG=392763, 403647, 373689, 405827
TEST=(windows) Show the app list, right-click an app and "uninstall".
Leave the uninstall dialog open. Switch to a chrome://settings in a
browser and delete the profile being shown in the app list. App list
should close.

Review URL: https://codereview.chromium.org/492163002

Cr-Commit-Position: refs/heads/master@{#291852}

BUG=407467
TBR=bshe@chromium.org

Review URL: https://codereview.chromium.org/502183003

Cr-Commit-Position: refs/heads/master@{#291851}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/508433002

Cr-Commit-Position: refs/heads/master@{#291850}

This CL fixes font rendering for experimental app list tiles by setting
a background.

BUG=406989

Review URL: https://codereview.chromium.org/499983002

Cr-Commit-Position: refs/heads/master@{#291849}

Display the results for the individual benchmark suites, this is
acheived by storing the full results set and quering it after
the benchmark has finished.

BUG=389257

Review URL: https://codereview.chromium.org/503053005

Cr-Commit-Position: refs/heads/master@{#291848}

BUG=407452
TBR=xhwang@chromium.org

Review URL: https://codereview.chromium.org/501283002

Cr-Commit-Position: refs/heads/master@{#291847}

- Revived AsyncUtil.Aggregation, which was used to aggregate consecutive run requests into one.
- Aggregated consecutive re-scan request using the aggregator described above.

BUG=316050
TEST=confirmed manually

Review URL: https://codereview.chromium.org/488043003

Cr-Commit-Position: refs/heads/master@{#291846}

BUG=401028
TEST=browser_tests

Review URL: https://codereview.chromium.org/489333002

Cr-Commit-Position: refs/heads/master@{#291845}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/508513002

Cr-Commit-Position: refs/heads/master@{#291844}

Add OpenDevToolsWindow() and IsCurrentChannelOlderThanDev() to AppsClient.

BUG=387288

Review URL: https://codereview.chromium.org/494483006

Cr-Commit-Position: refs/heads/master@{#291843}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/502173004

Cr-Commit-Position: refs/heads/master@{#291842}

This class is simply unnecessary.

BUG=None
R=oshima@chromium.org
TEST=athena_unittests passes

Review URL: https://codereview.chromium.org/501183002

Cr-Commit-Position: refs/heads/master@{#291841}

This makes it harder to accidently use the wrong
macro.

Also, removes the D* variants of the macros and
associated DebugNow() function. These were rarely
used and removing them removes clutter from the
header file. Existing uses converted to be behind
NDEBUG ifdefs.

No functional changes except for a fix to the
code in content_based_thumbnailing_algorithm.cc
which was incorrectly using a ternary operator for
the histogram name (which doesn't work since the
macros cache the histogram object) and removal
of local histograms Spellcheck.SuggestTime and
Spellcheck.InitTime per groby@.

Since this is an API rename, TBR'ing downstream
owners.

BUG=311349
TBR=groby@chromium.org,zea@chromium.org,jeremy@chromium.org,reveman@chromium.org,agl@chromium.org,jam@chromium.org

Review URL: https://codereview.chromium.org/484603006

Cr-Commit-Position: refs/heads/master@{#291840}

This delegate isolates SearchProvider from chrome dependencies

Add AutocompleteProviderDelegate and its chrome implementation ChromeAutocompleteProviderDelegate.

BUG=388515
TBR=blundell@chromium.org for the new DEPS line

Review URL: https://codereview.chromium.org/500023002

Cr-Commit-Position: refs/heads/master@{#291839}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/503903004

Cr-Commit-Position: refs/heads/master@{#291838}

BUG=

Review URL: https://codereview.chromium.org/504003002

Cr-Commit-Position: refs/heads/master@{#291837}

BUG=407080

Review URL: https://codereview.chromium.org/473683005

Cr-Commit-Position: refs/heads/master@{#291836}

Crash reports indicate that the WindowAndroid's Compositor may be NULL
during |RenderWidgetHostViewAndroid::SetContentViewCore()|. While this
is a somewhat surprising result, it is in theory possible and should
probably not be fatal. Avoid creating the overscroll effect in this
case, instead creating it after the compositor is (re-)attached.

BUG=407208

Review URL: https://codereview.chromium.org/503813003

Cr-Commit-Position: refs/heads/master@{#291835}

Note that the Match() function copies the data into a memory blob.  This is of course only for demo purposes. This will soon be changed to use a streaming API. See bug 403493.

BUG=392621

Review URL: https://codereview.chromium.org/465463002

Cr-Commit-Position: refs/heads/master@{#291834}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/502203003

Cr-Commit-Position: refs/heads/master@{#291833}