- 26 Aug, 2020 40 commits
-
-
Zhenyao Mo authored
BUG=1117185 TEST=added tests R=sunnyps@chromium.org Change-Id: I88464603eff831c991100ca7ee37cc7c555bb553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368487 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#801669}
-
Marc Treib authored
After crrev.com/c/2374512, the reason for its flakiness should be gone. Bug: 1043899 Change-Id: Id33e945b5bd7eae3412146d008d9c344e039e987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375369Reviewed-by:
Victor Vianna <victorvianna@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#801668}
-
Austin Tankiang authored
Bug: 1007662 Change-Id: I8296336c501cdb4a4634d0c78545af123ef3d6c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374910Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#801667}
-
tby authored
As part of fixing the omnibox/launcher_search_provider file duplication issue, we're going to increase the maximum number of file search results that can be shown to the user. Bug: 1053637 Change-Id: Idf8126ab2eb648cb5d7b393bcff451e6f6c958b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376785Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#801666}
-
Tal Pressman authored
Add a pointer to the AgentSchedulingGroupHost in RenderWidgetHost, and route some initial calls through it instead of the RenderProcessHost. This is needed since in the future all widget-specific communication will be done directly at the agent scheduling group level, and not the process level. Bug: 1111231 Change-Id: I65bf4769bd9572046316a9f569651bcaf8e462aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358943 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#801665}
-
Lei Zhang authored
The feature has launched to Stable channel. Remove the feature flag, flag entry, and code that assumes the feature can be turned off. Bug: 477699 Change-Id: Ifde3a265ff44026a7479ccb56076bce03e4f1173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350196Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#801664}
-
tby authored
When retrieving the type of an omnibox search result, there is a NOTREACHED case for types that apparently shouldn't ever exist. We recently moved this check from a code path that was never run, to a code path that's run for every result. For now, let's remove the NOTREACHED while we figure out which result types are causing this. Bug: 1121386 Change-Id: Id5929f92ab2706fee2c35a510c5b4acff394d547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377026Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/090e3d5a3680..ac636dc7dfe0 2020-08-26 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I55456e881825c3d629c2d5758f2dfef5d7b1b27b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377205Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801662}
-
Mohsen Izadi authored
The experiment is launched on ToT (r801119) and the field trial testing config is not needed anymore. Bug: 993895 Change-Id: I0a339a75e0d239561f6944d64d3b2c3318f5bfbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370433Reviewed-by:
-
Miyoung Shin authored
This CL plumbs the ‘allow inspection’ variable from JavascriptInjectorImpl to RemoteObject to be checked in getMethods on the browser side. Bug: 1105933b Change-Id: I9e997366ec5266c343b62d4689993f027668e76e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352295Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#801660}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: Iab737d8f79ef9adeb21236f2df771d3e023ed19b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376872Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801659}
-
nancylingwang authored
Modify ExtensionProvider to observe AppRegistryCache to load the new standard icon from AppService when the adaptive icon feature is enabled. DD: go/appservice-adaptive-icon BUG=1121467 Change-Id: I711429d54ec64f6759b2f415fbf7064a548d52b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375009Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#801658}
-
Mark Mentovai authored
Change-Id: I9cff6f2a7bed9a6b2c2301bd9392de1dc82bcfac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375594 Commit-Queue: Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Mark Mentovai <mark@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#801657}
-
Melissa Zhang authored
This CL adds a secondary display label under targets to show activity_name for ARC apps. Bug: 1097623 Change-Id: I6588812328bee70ca83136a3bd4bf15a762f01ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367588 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#801656}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c5676b9e6c83..13e23939fb1a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hayato@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:912681 Tbr: hayato@google.com Change-Id: I0ce08c0cf565449023a3f414e311a259e7647ba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377145Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801655}
-
Avi Drissman authored
Chromium has required 64-bits on the Mac for a very long time now. Delete a memory test that only builds on 32-bits. Bug: none Change-Id: I8ebccc48e1597ead7a9a22791e7270b0f4170933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377225 Commit-Queue: Avi Drissman <avi@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#801654}
-
Min Qin authored
BUG=1121214 Change-Id: Ia847997e2f1b9ee9e7b98b0fb558d1e246e8f61d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375705Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#801653}
-
Antonio Gomes authored
In file included from ../../ui/base/clipboard/clipboard_unittest.cc:57: ../../ui/base/clipboard/clipboard_test_template.h:177:7: error: use of undeclared identifier 'features' if (features::IsUsingOzonePlatform()) { ^ 1 error generated. BUG=789065 R=sky@chromium.org Change-Id: I60a5322b70cf03e206ba0854dfe61115c71b0337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376129 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:Scott Violet <sky@chromium.org> Auto-Submit: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#801652}
-
Yulun Wu authored
A nudge will appear if a user performs a paste->copy->paste sequence within a 10 minute period. Note that this timer is reset upon performing additional pastes (paste -> paste -> paste will refresh the ten minute period). Nudges will appear a total of 3 times with a minimum of 24 hours in between. Bug: 1105541 Change-Id: I37a8ff75b0af9c6da1fa42c8ee3c1c98846e4687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341407Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#801651}
-
Yao Xiao authored
Bug: 1062736 Change-Id: I9b046938b41236fb07e005cdaa18385d1360257c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373400Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#801650}
-
Tal Pressman authored
The AgentSchedulingGroup is instantiated in response to a Mojo API called by AgentSchedulingGroupHost. It is owned by a set on RenderThreadImpl (dual of AgentSchedulingGroupHost owned by RenderProcessHost). For now, AgentSchedulingGroups (or their hosts) are only deleted when their RenderThreadImpl/RenderProcessHost are destroyed. Bug: 1111231 Change-Id: Ia3384fcedd200d0536c918933e2a86666cd93a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359950 Commit-Queue: Tal Pressman <talp@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#801649}
-
Xianzhu Wang authored
They have passed in the last 20 builds. TBR=pdr@chromium.org Bug: 524134, 1103138 Change-Id: I35efc63d3504e94216039d30c6effe4ff3ca6199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377226Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#801648}
-
Hayato Ito authored
This reverts commit 994f22b5. Reason for revert: Probably Tree closer. https://ci.chromium.org/p/chromium/builders/ci/Cast%20Android%20(dbg)/110678? Step compile failed. Error logs are shown below: [76/115] CXX obj/components/services/heap_profiling/public/cpp/cpp/profiling_client.o FAILED: obj/components/services/heap_profiling/public/cpp/cpp/profiling_client.o /b/s/w/ir/cache/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF...(too long) In file included from ../../components/services/heap_profiling/public/cpp/profiling_client.cc:11: In file included from ../../base/allocator/allocator_interception_mac.h:11: ../../third_party/apple_apsl/malloc.h:27:10: fatal error: 'mach/boolean.h' file not found #include <mach/boolean.h> ^~~~~~~~~~~~~~~~ 1 error generated. Original change's description: > Update Mac memory code references > > The Mac malloc interceptor relies on internals of macOS. > Update those internals and links to the 10.15 versions. > > There is no actual difference in the code that is relied on, > but the code references were to 10.7 and 10.9. > > Bug: none > Change-Id: I335007a338c4d3ce4e8297c325ac765a384510f0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376886 > Commit-Queue: Avi Drissman <avi@chromium.org> > Commit-Queue: Mark Mentovai <mark@chromium.org> > Auto-Submit: Avi Drissman <avi@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801644} TBR=avi@chromium.org,mark@chromium.org Change-Id: Ic868ec40c2622c763b37b4a4d8615e1a25dede60 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377030Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#801647}
-
Aleks Totic authored
Bug: 1005518 Change-Id: I218e27179aa9a616490a21c0e4fcc1c4c3dfefcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375944 Auto-Submit: Aleks Totic <atotic@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#801646}
-
Austin Tankiang authored
Bug: 1007654 Change-Id: Ifacc449deab06bd96b81816c3fb9dba2432aa1f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374326 Auto-Submit: Austin Tankiang <austinct@chromium.org> Reviewed-by:
-
Avi Drissman authored
The Mac malloc interceptor relies on internals of macOS. Update those internals and links to the 10.15 versions. There is no actual difference in the code that is relied on, but the code references were to 10.7 and 10.9. Bug: none Change-Id: I335007a338c4d3ce4e8297c325ac765a384510f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376886 Commit-Queue: Avi Drissman <avi@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Joel Hockey authored
If ever needed, the crosh settings page is the same as the terminal settings legacy page. Ctrl+Alt+T to open crosh, then Ctrl+Shift+P for preferences page. Or chrome-untrusted://crosh/html/nassh_preferences_editor.html Change-Id: I972c34be751ce5764e3625d03d235b2291800464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371770Reviewed-by:
Jason Lin <lxj@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#801643}
-
Maggie Cai authored
This CL adds browser tests for intent picker on Chrome OS. BUG=853604 Change-Id: If1543890d9e2b60de2a2fcb5e71f6baf4fcd85d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308621 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
-
kouhei authored
Bug: None Change-Id: I21c06e62379b241ef6e920037f595cb2646ea6ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377186Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#801641}
-
Tal Pressman authored
The test used FrameTreeNodeId instead of RoutingId when constructing the frame's global routing ID. Change-Id: Ie272ead039011bf905576acecae25877e0322350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376925 Commit-Queue: Tal Pressman <talp@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Tal Pressman <talp@chromium.org> Reviewed-by:
-
Henrik Boström authored
CL: https://webrtc-review.googlesource.com/c/src/+/180620 Has landed, it makes us pass more tests: external/wpt/webrtc/RTCPeerConnection-onnegotiationneeded.html -FAIL negotiationneeded event should fire only after signaling state goes back to stable after setLocalDescription assert_false: negotiationneeded should not fire until the next iteration of the event loop after SLD success expected false got true -FAIL negotiationneeded event should fire only after signalingstatechange event fires from setRemoteDescription assert_false: negotiationneeded should not fire before signalingstatechange fires expected false got true -FAIL negotiationneeded event should fire only after signalingstatechange event fires from setLocalDescription assert_false: negotiationneeded should not fire until the next iteration of the event loop after returning to stable expected false got true +PASS negotiationneeded event should fire only after signaling state goes back to stable after setLocalDescription +PASS negotiationneeded event should fire only after signalingstatechange event fires from setRemoteDescription +PASS negotiationneeded event should fire only after signalingstatechange event fires from setLocalDescription external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-rollback.html -FAIL when using addTransceiver, implicit rollback of a local offer should visit stable state, but not fire negotiationneeded until we settle in stable assert_true: There should be no negotiationneeded event right now expected true got false +PASS when using addTransceiver, implicit rollback of a local offer should visit stable state, but not fire negotiationneeded until we settle in stable I had forgotten to disable this so the roll is blocked on diffs in expectations... TBR=hta@chromium.org NOTRY=True # The chromium_presubmit bot seems to not be running atm, skipping. NOPRESUBMIT=True Bug: chromium:1060083 Change-Id: I71c7e9f27f7f09c989ec18f474363e4aa3e64e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376807Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#801639}
-
Stephen Chenney authored
Bug: 1121429 Change-Id: I3de12926cef958cdd248277f2f43deb768109a61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375598 Commit-Queue: Stephen Chenney <schenney@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#801638}
-
Greg Guterman authored
Bug: 1121834 Change-Id: Ic98a994d225795788e10c4b161f9de1b1bde60d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376572 Auto-Submit: Gregory Guterman <guterman@google.com> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#801637}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /services/device/usb This CL was uploaded by git cl split. R=odejesush@chromium.org Bug: 1110266 Change-Id: I368ba7aa63c20ff200577a3ba8bd8441d2cef1c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371300Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#801636}
-
Tibor Goldschwendt authored
Fixed: 1109838 Change-Id: Iaa54481988d9de3e4c6a318dacdf6aab7ef909ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376310 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
-
Karandeep Bhatia authored
Generated schema strings are primarily used by the renderers to generate bindings. Exclude 'manifest_keys' since the renderers wouldn't need these. BUG=1113513 TEST=Verify that the generated schema strings don't include 'manifest_keys'. Change-Id: Ibf750b27155b0f851bccb54d80a6093c6ed33458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369418 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#801634}
-
Thomas Lukaszewicz authored
Bug: 1099917 Change-Id: I488e14cd7389bd920d022c3e4d2394d30b292b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370737 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#801633}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /gpu/ipc/common/gpu_memory_buffer_support.h This CL was uploaded by git cl split. R=dcastagna@chromium.org Bug: 1110266 Change-Id: I5b10a6b731b816cbeacbb7a11916c93f33f40ae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370728Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
-
Oriol Brufau authored
Before running the grid track sizing algorithm, there is a prelayout step which takes care of the baseline alignment of the items. In order to do that, we estimate the size of the grid area, since we have not calculated the final size yet. The problem was that, when calculating this estimate, the available column space had not been set yet. So if a column had a percentage track sizing function, it would be treated as auto and the estimated size would be wrong. This patch sets the available column space so that we can resolve percentage track sizing functions and get a more correct estimate. Bug: 1121761 TEST=external/wpt/css/css-grid/alignment/self-baseline/grid-self-baseline-008.html Change-Id: Ic4410b0a80b92afa5adfd62187ec236bd4fd3ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375649 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#801631}
-
nancylingwang authored
The flaky issue has been fixed with CL:2371767, so enable this test case. BUG=1115762 Change-Id: Ia96b7e58c20470f2f0badcda9e13bff4bfdf1e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375011Reviewed-by:
-
