- 09 May, 2018 40 commits
-
-
Wez authored
This adds the necessary SDK library dependency for the Fuchsia build to compile in component mode. Bug: 756269 TBR: dpranke Change-Id: I110a4599273967aa99709ed20f187f2e2713b05a Reviewed-on: https://chromium-review.googlesource.com/1048633Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#557136}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6bb87810. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17180 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=danyao No-Export: true Change-Id: Ic649836c332f5c8c982594cc7ae682df3588b391 Reviewed-on: https://chromium-review.googlesource.com/1050453 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#557135}
-
Christian Dullweber authored
On every history deletion or expiration, both SiteEngagementService and MediaEngagementService request an OriginCountAndLastVisitMap from history_service. This map is expensive to create, so we prepopulate history::DeletionInfo with it to only do this calculation once. This CL will also remove the DeletionTimeRange for deletions due to expiration as these are not handled anyway and cause some unneccessary observer calls if deleted_rows is empty. Bug: 808031 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia31384dce4115b90d725279d2847ec118a952643 Reviewed-on: https://chromium-review.googlesource.com/1046945 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#557134}
-
tzik authored
libc++ starts using aligned new operator when it's in C++17 mode, but system libc++ on Mac doesn't have it, and that causes a link error. This CL turn on _LIBCPP_HAS_NO_ALIGNED_ALLOCATION to avoid using the unavailable aligned allocation. Bug: 752720 Change-Id: I89be50bcc26d23a43da3b807109a1271fcf141f0 Reviewed-on: https://chromium-review.googlesource.com/1049186 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#557133}
-
Erik Luo authored
Expanding an ElementsTreeElement used to immediately set a populated flag to true before requesting getChildNodes(). If a ChildNodeCountUpdated event arrives before the children are set, we may call updateModifiedParentNode() and try to create visibleChildren when they are null, breaking the tree. This CL moves the place where 'populated' is set, so that updateModifiedParentNode() does not update tree children before they are available. Bug: 829884 Change-Id: Id68e71fb7a58336d781207b298a53354af3e5cfc Reviewed-on: https://chromium-review.googlesource.com/1049113 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#557132}
-
David 'Digit' Turner authored
This modifies the internal crazy::SearchPathList class to support looking up libraries inside zip archives, in two ways: - First, by supporting paths with an exclamation mark, used as a delimiter between zip archive paths, and file sub-paths within it. For example, looking for: /path/to/archive.zip!libs/libfoo.so Will search the zip archive at /path/to/archive.zip for a file named libs/libfoo.so. Note that path items added through AddPaths() can also contain an exclamation mark. - Second, automatically support zip files stored with a 'crazy.' prefix (e.g. /path/to/archive.zip!libs/libfoo.so will match a file named 'libs/crazy.libfoo.so' in the archive too. This is useful to store uncompressed libraries inside Android APKs while preventing the system from extracting them when the application is installed or updated. Note that this does not modify the rest of the crazy linker to use this for now (e.g. to implement LoadLibraryFromZipFile()), since this will require more work (to be provided in a future CL). BUG=802068 R=agrieve@chromium.org,pasko@chromium.org,lizeb@chromium.org Change-Id: Ic8661332e4e4537a472e325b74c8c001ea2bc113 Reviewed-on: https://chromium-review.googlesource.com/1042394 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#557131}
-
Gauthier Ambard authored
This CL allows the toolbar to have non-zero height in fullscreen. It can be used with the UI Refresh and the Browser Container being fullscreen. Bug: 807572, 836730 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If292c787596be8d543142cdf75c5b1d27eb66e4c Reviewed-on: https://chromium-review.googlesource.com/1030393Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#557130}
-
Koji Ishii authored
The new approach to apply the 'text-transform' property to ::first-line pseudo element[1] has a known issue that, since it transforms at paint time, line breaking is measured against non-transformed text. The test fast/text/transform-text-first-line.html relies on line breaking is measured against small letters, but this issue does not exist in LayoutNG. This patch fixes the test by using Ahem. Because Ahem has different glyph but the same width for small letter 'p', it can test which letters are capitalized without line breaking being affected by the issue. [1] https://chromium-review.googlesource.com/603855 TBR=eae@chromium.org Bug: 129669, 644733, 636993 Change-Id: Ie0a14652c43d4b863ea0fd9bf40d8ab17f39d0ea Reviewed-on: https://chromium-review.googlesource.com/1051067Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#557129}
-
Hirokazu Honda authored
Always output thumbnails in thumbnail testcase. the output thumbanils file name contains "good" if the thumbnail test case is passed, and on failure it contains "bad." BUG=chromium:834170 TEST=VDA unittest on kevin TEST=VDA unittest on non-Chrome OS platforms in CQ. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I428793cd6428420495be9a3ab60170669e5f51fe Reviewed-on: https://chromium-review.googlesource.com/1039104 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#557128}
-
John Rummell authored
Add code so that media encrypted in 'cbcs' encryption scheme can be handled by AesDecryptor. This adds 2 new classes: aes_cbc_crypto.* handles AES-CBC-128 decryption using the BoringSSL code to allow for decryption without padding and to avoid extra copies of the data. cbcs_decryption.* supports pattern decryption. Both classes have unit tests to verify their basic functionality. BUG=657957,658026 TEST=content_browsertests pass Change-Id: Ia0a8db2859ff4f815a0cfcc705f7ea50d77a115c Reviewed-on: https://chromium-review.googlesource.com/1038725 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Kongqun Yang <kqyang@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#557127}
-
Kunihiko Sakamoto authored
This is a preparation for the CBOR certificate chain support, in which the CBOR parser requires input of type base::span<const uint8_t>. Bug: 803774 Change-Id: I16f96544b3accbf365a826d5c767e479aa7ef11b Reviewed-on: https://chromium-review.googlesource.com/1051187Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#557126}
-
Greg Thompson authored
This reverts commit 933cf169. Reason for revert: Handle leak causing test failures. Original change's description: > Win Native Notifications: Fix window activation. > > This fixes the issue with window activation not functioning correctly > when notifications are activated while Chrome is running but in the > background. > > Bug: 837796, 734095 > Change-Id: I8eac14403850a13d60e7a50c3c795fed96205d7e > Reviewed-on: https://chromium-review.googlesource.com/1049984 > Reviewed-by: Greg Thompson <grt@chromium.org> > Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556955} TBR=finnur@chromium.org,grt@chromium.org Change-Id: Ib0e0d132867555f822dc13061b63bca123c16df9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 837796, 734095 Reviewed-on: https://chromium-review.googlesource.com/1051385Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#557125}
-
Mikel Astiz authored
Tab sync entities are expected to have a valid |tab_id| field over the sync protocol, but clients should not crash if the received data is corrupt, e.g. committed by a buggy client. Prior to this patch, foreign sessions received in SessionsSyncManager, processed via UpdateTrackerWithSpecifics(), could trigger a CHECK failure in SyncedSessionTracker::GetTab(). Bug: 840876 Change-Id: Ie59cfb9c24934695a1b7b6187dbad48451f8c8ea Reviewed-on: https://chromium-review.googlesource.com/1051233Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#557124}
-
Patrik Höglund authored
This didn't end up quite right. I didn't realize chromium.webrtc doesn't have any debug bots, so I removed that category. Also sorted fyi debug-release consistently. Bug: chromium:840277 Change-Id: Ie8d174fa99504e576a78c75363bed8f10bb854ac Reviewed-on: https://chromium-review.googlesource.com/1049687Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#557123}
-
Pavol Marko authored
Bug: none Change-Id: Iac34093a83534359bcdad650a3475198a9fc576e Reviewed-on: https://chromium-review.googlesource.com/1050525Reviewed-by:
Georges Khalil <georgesak@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#557122}
-
Farah Charab authored
Upon task queue instantiation, populate frame_scheduler when task queue is associated to a frame. Bug: 839485 Change-Id: Iea60faf8dd5f015240a866e7189f252216982ce8 Reviewed-on: https://chromium-review.googlesource.com/1042577 Commit-Queue: Farah Charab <farahcharab@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557121}
-
Fredrik Söderquist authored
This reverts commit 3431b89c. Reason for revert: Tickled fuzzers Original change's description: > [CI] Convert SVG resources to use SVGResource > > From using AtomicString (for 'mask', 'marker-*', 'fill' and 'stroke') or > the string representation of SVGResources ('filter' and 'clip-path'), > convert to using SVGResources. > Add an implementation of SVGResourceClient (SVGElementResourceClient) > and register it with the existing resources. Invalidation code is moved > here. This makes the invalidation code slightly more homogeneous between > the various code-paths. > > The new SVGResourceClient implementation is stored in SVGElementRareData > as needed. > The various computed style representations are converted to use the new > StyleSVGResource, which is a ref-counted wrapper around an SVGResource > and its underlying string representation (which is needed for > serialization.) Style building is changed to produce this new wrapper > (rather than an AtomicString.) A helper for serialization is added to > ComputedStyleUtils. > The kHasPendingResources flag is removed since it no longer used, and > the hook in Element is removed. > All LayoutSVGResource* subclasses are changed to take SVGResourceClients > instead of LayoutObjects, and the |clients_| set is removed in favor of > the set in SVGResource. > A bunch of helpers are added for updating (adding/removing) the client > registrations. The various LayoutSVG subclasses are updated to call > these helpers. > > TBR=junov@chromium.org > > Bug: 769774 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I62418465251532240c4e895e5c4d253ed9e53b9a > Reviewed-on: https://chromium-review.googlesource.com/977965 > Commit-Queue: Fredrik Söderquist <fs@opera.com> > Reviewed-by: Fredrik Söderquist <fs@opera.com> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556743} TBR=pdr@chromium.org,fs@opera.com,junov@chromium.org,schenney@chromium.org Change-Id: I695b3eed793bb000b057bca52364265d201f0bae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 769774 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/1051345Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#557120}
-
Martijn Croonen authored
This updates from revision 0f3b07d9aab6d6c9fe74990af98316468d40f488 (2018-01-25) to revision 649d6339ff2748e94d076b44e2aecc047795a607(2018-05-08) Bug: 834407 Change-Id: I62d38242a534ff2d941d0320c5cd454b9ff8f955 Reviewed-on: https://chromium-review.googlesource.com/1023411Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Martijn Croonen <martijnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#557119}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9d15c6b6. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17179 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jinho.bang@samsung.com, mathp@chromium.org, rouslan@chromium.org: external/wpt/payment-handler TBR=danyao No-Export: true Change-Id: I3d196d1b9d0089616241e204ab5ca0273fdd3a15 Reviewed-on: https://chromium-review.googlesource.com/1050452 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#557118}
-
Fredrik Söderquist authored
Bug: 648179 Change-Id: I623023d6e195447381bf8b08124d7475bb0fe93d Reviewed-on: https://chromium-review.googlesource.com/1049629Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#557117}
-
Maksim Sisov authored
This change doesn't bring any functionality changes, but rather removes an accidentely added duplicate DCHECK. TBR=rjkroege@chromium.org Bug: 784836, 578890 Change-Id: I524178327c4f6131eb582b9de37afe799039a41e Reviewed-on: https://chromium-review.googlesource.com/1051226 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#557116}
-
Marina Ciocea authored
Notes: - Key press count is written to a share memory region and used by audio::InputStream implementation (audio service side was already landed in https://crrev.com/c/1011605/31). - AudioInputStreamBroker passes a readonly handle to the shmem over IPC to audio::InputStream. - Lock in UserInputMonitor was removed because Enable/Disable can only be called from UI thread in new audio service input stream implementation, or on audio thread in old implementation. - UserInputMonitor::EnableKeyPressMonitoring() returning void will be removed after switching to audio service input streams. Design doc: https://docs.google.com/document/d/1GHL4uMlIFox2eAqsjUQVA8eJ7HYU3g2AoyAqyx3pxMA/edit?usp=sharing Bug: 836226 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I75b5b4cb0ed49ce17df84a03300bb9da52d86846 Reviewed-on: https://chromium-review.googlesource.com/1032733 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557115}
-
Adam Rice authored
WebSocket bufferedAmount is defined in the HTML standard as being unsigned long long (https://html.spec.whatwg.org/#the-websocket-interface), but Blink has been using "unsigned long" for this value. Change to "unsigned long long". This also permits us to remove the check for overflow. BUG=631004 Change-Id: I6c6cc356d9b3c425306376e210b9df7a3be13998 Reviewed-on: https://chromium-review.googlesource.com/1037105 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#557114}
-
Koji Ishii authored
This patch moves Capitalize (titlecase) function from LayoutText to platform/text in order to share with LayoutNG. Bug: 636993 Change-Id: I1d0e78139424a20d4184976d1f920c75fc8190ac Reviewed-on: https://chromium-review.googlesource.com/1047925Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#557113}
-
Ryan Sleevi authored
Chrome is currently experimenting with using DNS as part of ensuring the Certificate Transparency logs provide globally consistent views. When using the Network Service, certificate verification is performed in the service/context, rather than the browser context, meaning that the consistency proof checking also needs to be moved into the Network Service. However, Certificate Transparency support is also being moved up into Chrome proper, rather than as part of //net, in order to ensure the ecosystem does not prematurely ossify. This CL moves the DNS portion from //chrome, and in particular, the IOThread, into the Network Service, while moving initialization of the logs up from //net and into //chrome, by way of explicit parameters in the NetworkContextParams. If the set of logs are not supplied, no CT support is initialized, and if they are supplied, then log consistency checking is enabled if the base::Feature is enabled. Bug: 702062, 769401, 803871, 835849 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I8befb033255366d8431922e29e18879d3cf1b7dc Reviewed-on: https://chromium-review.googlesource.com/1020304 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#557112}
-
Max Morin authored
Also add accessor to ForwardingAudioStreamFactory. Approximate diagram of stuff: https://docs.google.com/drawings/d/1_ZIKj6lihGKRjq4Mflduitmkn_REqpHFeqVNelBGHHk/edit Bug: 830493 Change-Id: I309aedf43fed5e646545eb94d00a77abc6ac66ea Reviewed-on: https://chromium-review.googlesource.com/1039707Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557111}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8cf7ea75d5ff..9520b5b98bd3 $ git log 8cf7ea75d..9520b5b98 --date=short --no-merges --format='%ad %ae %s' 2018-04-27 gmeinke Update cbuildbot to save install plan 2018-05-07 pprabhu sysmon: Report process metrics for lxc-start and lxc-attach. 2018-05-07 pprabhu sysmon: Extract _is_process_name Created with: roll-dep src/third_party/chromite BUG=chromium:838332,chromium:838332 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I88cdb791106cffc3aafeb0b8d3a97fbf8f26e524 Reviewed-on: https://chromium-review.googlesource.com/1051049 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557110}
-
Hajime Hoshi authored
scheduler: Replace kInternalAccessibility with kInternalDefault and deprectate kInternalAccessibility Following the guideline https://bit.ly/2vMAsQ4, we determined to use kInternalDefault as long as the tasks can run in the default way, that might be throttled or paused. This CL deprecates kInternalAccessibility whose task runner is a default task runner. Bug: 836410 Change-Id: Icaa3532e3ef2563b8baa6436566cc5f1ac036b86 Reviewed-on: https://chromium-review.googlesource.com/1032318 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#557109}
-
John Abd-El-Malek authored
TBR=mmenke@chromium.org Bug: 769401 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I40368e2ed5c01cb0234f7ba23bcf0f50ed4372da Reviewed-on: https://chromium-review.googlesource.com/1051251 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#557108}
-
Koji Ishii authored
Certain block boxes such as tables or flexbox define how they produce baselines when they are put in an inline-block. Before this patch, block boxes are assumed not to produce baselines. But because LayoutNG propagates baselines upwards (while legacy traverses children to find baselines,) block boxes need to propagate their inline-block baselines. This patch also contains LayoutNG support in LayoutBlockFlow:: FirstLineBoxBaseline(). This is needed when a LayoutNG parent needs to align baselines of old layout child (e.g., flexbox) but it has LayoutNG descendants. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ibc2ec7c257f44d210a209b8b8395ce19a47ce8d9 Reviewed-on: https://chromium-review.googlesource.com/1039208Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#557107}
-
Daniel Cheng authored
Mojo interface pointers are already nullable, so don't have double nullable pointers. Bug: 836564 Change-Id: Ia49842ed9549a0e22efc97fde1e852a17e4d7400 Reviewed-on: https://chromium-review.googlesource.com/1050911 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557106}
-
Guido Urdaneta authored
Drive-by: include build/build_config.h Bug: 840815 Change-Id: I1522f2947d4649cb5d9641d76a7115a1b4330c1f Reviewed-on: https://chromium-review.googlesource.com/1050287Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#557105}
-
Joel Hockey authored
* New fileManagerPrivate APIs: - isCrostiniEnabled: returns true if device supports crostini and termina/penguin container exists. This function is controlled by flag 'crostini-files'. - mountCrostiniContainer: starts and mounts container. * Created new root type NavigationModelSFTPMountItem which uses a FakeEntry, similar to 'Recent', to show the 'Linux Files' root. * Click handler for Linux Files will start and mount crostini container. * Code in NavigationModel to order roots detects when mounted volumes already contains an FSP-provided mount for fileSystemId='crostini'. In this case, the fake root is left out and the real volume should be in the same position. * Error handling code for SFTP mount/disconnect to be implemented when sshfs is available. Bug: 834103 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8a3bec948871dc9671ea513d7378035d89d565eb Reviewed-on: https://chromium-review.googlesource.com/1025545 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#557104}
-
Yoshifumi Inoue authored
This patch introduces |TextIterator::GetPosition{Before,After}()| as implementation of |CharacterIterator::GetPosition{Before,After}()| not to crash with block content. This is follow-up of the patch[1]. [1] http://crrev.com/c/1021430 Make CharacterIterator::GetPosition{After,Before}() to work with BR Change-Id: I0e5aae4cef69d6c1d902cbeb86e8e3552968c280 Reviewed-on: https://chromium-review.googlesource.com/1023502 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#557103}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/499a9b21087e..a2595f925596 $ git log 499a9b210..a2595f925 --date=short --no-merges --format='%ad %ae %s' 2018-05-08 khushalsagar fonts: Fix a trace name in SkRemoteGlyphCache Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I4f9882bdd941197920ec3c41a01844c2ed9ec12c Reviewed-on: https://chromium-review.googlesource.com/1050958 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557102}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9fa1ead4. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17178 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request TBR=danyao No-Export: true Change-Id: I70eef8c07915b0ff25b835f95b8cf58e1ffd3451 Reviewed-on: https://chromium-review.googlesource.com/1050829 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#557101}
-
https://webrtc.googlesource.com/src.git/+log/4e268edb533b..d6f86e8fca21 $ git log 4e268edb5..d6f86e8fc --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:526260 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I70f2fa2ca0407c0025353ce0dd2caf673dd78925 Reviewed-on: https://chromium-review.googlesource.com/1050962 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557100}
-
Ramin Halavati authored
The latest update of traffic_annotation_extractor clang tool returns absolute file paths in the reports instead of relative ones, and this breaks safe list checking. traffic_annotation_auditor is updated to convert the received file paths from absolute to relative (based on source folder) so that safe list checking would run. Bug: 690323 Change-Id: Iea610f6e3371923f4d1d9c19bd030cf859b8ac44 Reviewed-on: https://chromium-review.googlesource.com/1049547 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#557099}
-
Euisang Lim authored
1. Change breakpad path to third_party/breakpad - docs/testing/using_breakpad_with_content_shell.md moved in https://chromium-review.googlesource.com/681838 2. Change componetns/test_runner to content/shell_test_runner - docs/testing/writing_layout_tests.md moved in https://codereview.chromium.org/2707183003 3. Fix testharness api link - docs/testing/layout_tests_tips.md https://github.com/w3c/testharness.js is moved under https://github.com/w3c/web-platform-tests Bug: N/A Change-Id: I3c1024da6bc3ae9a785cb597e3b76dbd910b2593 Reviewed-on: https://chromium-review.googlesource.com/1049767Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#557098}
-
Chris Harrelson authored
At a 1-second aggregation period, the UKM team reports that there is too much data being collected, which causes too much user bandwidth. See internal b/79071304. Change-Id: I9553b56a0b8b2b32229c7ee11586640c4f0a0a6f Reviewed-on: https://chromium-review.googlesource.com/1050938Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#557097}
-