GitLab

Bug: 917477
Change-Id: Ibf881ccc9577a6aa380c07b613042395567fb39d
Reviewed-on: https://chromium-review.googlesource.com/c/1388751Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618645}

Adds two test cases covering:
- Encrytped()
- OnWaiting(WaitingReason::kNoDecryptionKey)

Bug: 858286
Test: New tests added.
Change-Id: I344aa85795c2a77d34d7cb5e41500902bb8bdbb1
Reviewed-on: https://chromium-review.googlesource.com/c/1388753Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618644}

This change adds a RequestForceSendMetadata method to
LayerTreeView/Host/Impl, which allows us to force sending RFM with
the next frame.

This ensures that CursorAnchorInfoController receives updates on any
frame with a text change.

Bug: 912309
Change-Id: I21185b57c2937c94d306d4ceed239d2f49bc824d
Reviewed-on: https://chromium-review.googlesource.com/c/1383533Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618643}

Running blink_tool.py rebaseline-cl output per
instructions.

TBR=foolip

Bug: 916899
Change-Id: I77b10bcf57a20c511bed0509acbe596ebb1d7526
Reviewed-on: https://chromium-review.googlesource.com/c/1388652Reviewed-by: Doug Turner <dougt@chromium.org>
Commit-Queue: Doug Turner <dougt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618642}

I was hitting an unexpected bug where one of the GWP-ASan tests was
failing on OS X but not Windows. I realized this was because the test
never ran on Windows in the component build (due to how the allocator
shim works on Windows) but was failing when I ported it to OS X. Save
a note to save future devs some debugging time.

Change-Id: I107113eab8e808d8837f5e56b15ca53006436c95
Reviewed-on: https://chromium-review.googlesource.com/c/1379182Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618641}

Bug: 897312
Change-Id: Ia5f70cc255b7e2a537e89a20fffa8b93f1305b68
Reviewed-on: https://chromium-review.googlesource.com/c/1388214
Commit-Queue: Doug Turner <dougt@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618640}

This is the first step to change Chrome's PaymentRequest implementation
to match the proposed spec change:
https://lists.w3.org/Archives/Public/public-payments-wg/2018Nov/0018.html

This CL aligns mojom::PaymentRequest API with the new spec proposal by
renaming CanMakePayment to HasEnrolledInstrument and leaving a stub for
CanMakePayment. Blink's canMakePayemnt is switched to using
HasEnrolledInstrument so there is no behavior change visible to the web
platform.

There will be a few subsequent changes:
- Implement new CanMakePayment behavior
- Expose hasEnrolledInstrument and new canMakePayment in Blink behind
  a runtime flag.

Bug: 915907
Change-Id: I137110de0077fb4e243b883d27c82109f8d2afbb
Reviewed-on: https://chromium-review.googlesource.com/c/1383445Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618639}

The layout test asserts visual caret positions, which is changed by the
bidi caret affinity flag. This patch adds new behavior under the flag to
make the test pass there.

Bug: 917165
Change-Id: I6bcbff036d8239c66e62c19bbc1170b725b11d89
Reviewed-on: https://chromium-review.googlesource.com/c/1387478
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618638}

Some of these configurations have relatively few machines, and the
default Swarming shard timeout of 1 hour is too short.

The following machines are affected:

  Mac FYI Experimental Release (Intel)
  Mac FYI Experimental Retina Release (AMD)
  Win10 FYI Exp Release (Intel HD 630)
  Win10 FYI Exp Release (NVIDIA)
  Win7 ANGLE Tryserver (AMD)
  Win7 FYI Debug (AMD)
  Win7 FYI Release (AMD)
  Win7 FYI Release (NVIDIA)
  Win7 FYI dEQP Release (AMD)
  Win7 FYI x64 Release (NVIDIA)

Bug: 917183
No-Try: True
Change-Id: I8e602e9713a378c9da43e1410644d214d00c7d24
Reviewed-on: https://chromium-review.googlesource.com/c/1388166
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618637}

The layout tests assert mapping between logical and visual caret
positions, which is changed by the bidi caret affinity flag. This patch
adds new behavior under the flag to make the tests pass there.

Bug: 917165
Change-Id: I273d1194e7f011deccb05d33d2a3304b03bfd90a
Reviewed-on: https://chromium-review.googlesource.com/c/1388810
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618636}

Remove virtual/bidi-caret-affinity/editing/selection/modify_extend/extend_by_character.html from "true failures"

The web test is already flaky on Mac and Win even without the bidi caret
affinity flag. Hence, this patch moves it from the "true failures"
section to the "already failing" section.

Bug: 917165
Change-Id: I01f06cbf13009504af6d3a908564b3e5a96f2d79
Reviewed-on: https://chromium-review.googlesource.com/c/1388719
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618635}

Currently, this path is avoided via an |if (false) { ... }| in
the code above it when SaturateFastAsmOp is not supported for a
given pair of types. However, instantiating the template for 64-bit
sources will give a truncation warning for arm (at the line where
we do |int32_t src = value;|) under strict compiler modes (even
though the path can't be reached).

Avoid the error by conditionalizing its instatiation for cases where
it is actually usable.

BUG=879657

Change-Id: I40bee5a4686b89c1d35c7b93804b215afe25dd68
Reviewed-on: https://chromium-review.googlesource.com/c/1387958Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618634}

Use a range iterator to avoid 64 bit truncation with size_t.

BUG=879657

Change-Id: Ic776d3aae635b47d24a0d548c0a260840e8c5656
Reviewed-on: https://chromium-review.googlesource.com/c/1387652Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618633}

Remove comment about shrink_to_fit() being missing in some STL deque
implementations, along with manual shrink_to_fit() equivalent.

Change-Id: I0b4443731755a98ea63b44830db3261577af6bfc
Reviewed-on: https://chromium-review.googlesource.com/c/1388394
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618632}

Move android_image_reader_utils to a new source set. This helps to
reduce unwanted dependencies in the places which needs to use
android_image_reader_utils* files.

Bug: 891060
Change-Id: I2557ca40d5ab011de800d842cf2ab18dcb238381
Reviewed-on: https://chromium-review.googlesource.com/c/1388389
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618631}

Bug: 899789
Change-Id: I28f538888f1bd041ffa31cc650d19245228e044f
Reviewed-on: https://chromium-review.googlesource.com/c/1388436
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618630}

The layout test asserts visual caret positions, which is changed by the
bidi caret affinity flag. This patch adds new behavior under the flag to
make the test pass there.

Bug: 917165
Change-Id: I801d11574658ab9efcd18d284187db08d669c1e3
Reviewed-on: https://chromium-review.googlesource.com/c/1388024
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618629}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I23a6b1f69dd61795ade84151a2beb65eea005a3e
Reviewed-on: https://chromium-review.googlesource.com/c/1388955Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#618628}

https://chromium.googlesource.com/angle/angle.git/+log/92b16ea26290..d50521fd068e


git log 92b16ea26290..d50521fd068e --date=short --no-merges --format='%ad %ae %s'
2018-12-21 ianelliott@google.com Only enable VK_KHR_maintenance1 when available.


Created with:
  gclient setdep -r src/third_party/angle@d50521fd068e

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: I9e4409ed196b8ad44ac816fc154ac7aee72d959a
Reviewed-on: https://chromium-review.googlesource.com/c/1388628Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#618627}

Some context from base/values.h:

base::Value is currently in the process of being refactored. Design doc:
https://docs.google.com/document/d/1uDLu5uTRlCWePxQUEHc8yNQdEoE1BDISYdpggWEABnw

Previously (which is how most code that currently exists is written), Value
used derived types to implement the individual data types, and base::Value
was just a base class to refer to them. This required everything be heap
allocated.

OLD WAY:

  std::unique_ptr<base::Value> GetFoo() {
    std::unique_ptr<DictionaryValue> dict;
    dict->SetString("mykey", foo);
    return dict;
  }

The new design makes base::Value a variant type that holds everything in
a union. It is now recommended to pass by value with std::move rather than
use heap allocated values. The DictionaryValue and ListValue subclasses
exist only as a compatibility shim that we're in the process of removing.

NEW WAY:

  base::Value GetFoo() {
    base::Value dict(base::Value::Type::DICTIONARY);
    dict.SetKey("mykey", base::Value(foo));
    return dict;
  }

Bug: 877281
Change-Id: Ia16fb806a3de551dc427ed6e9a8600f0f8e5acb7
Reviewed-on: https://chromium-review.googlesource.com/c/1384608Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618626}

And disable the one failing test.

Bug: 917086
Change-Id: I3abc37faef3b2c5fb182075b48737c3e512d8e72
Reviewed-on: https://chromium-review.googlesource.com/c/1387548Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618625}

This CL wires in the current_page and from_omnibox_focus autocomplete input
fields to the UI. Adding these fields allows the debug page to work with the
zero suggest provider, but they also affect other providers, such as search
provider.

Adds 'zero suggest' checkbox which controls the from_omnibox_focus autocomplete
input field. This field enables the zero suggest and clipboard providers while
also disabling the bookmarks, built in, history, history url, keyword, search,
and shortcut providers.

Also adds a 'current url' input box which controls the current_url autocomplete
input field. This field is essential for the zero suggest provider but may also
affect the search and clipboard providers.

To avoid redundant typing, when 'zero suggest' is checked, the 'current url'
input becomes disabled and auto-populated with the contents of the 'omnibox
text' input.

Lastly, changed the accesskey of 'current page context' from 'u' to 'o' in order
to use the accesskey 'u' for the 'current url' input.

Bug: 891303
Change-Id: I51f4815d9f837245b6b6fab03dcec5d009783b6b
Reviewed-on: https://chromium-review.googlesource.com/c/1378246Reviewed-by: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618624}

https://pdfium.googlesource.com/pdfium.git/+log/817c32843267..ae3945f4d219


git log 817c32843267..ae3945f4d219 --date=short --no-merges --format='%ad %ae %s'
2018-12-21 thestig@chromium.org Make FPDFPage_SetRotation() take effect immediately.
2018-12-21 thestig@chromium.org Add more resource params to CPDF_PageObjectHolder ctor.


Created with:
  gclient setdep -r src/third_party/pdfium@ae3945f4d219

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I95f3622cadb24348a75ff9c87a20dca5f15b7bf4
Reviewed-on: https://chromium-review.googlesource.com/c/1387851Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#618623}

Bug: 891303
Change-Id: If58334d48debc7c5e23717f4cd13f2a77bb2c286
Reviewed-on: https://chromium-review.googlesource.com/c/1388705Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618622}

The renderer is working in a nested message loop. Since the outer loop
is deliberately stuck, the hung-renderer detection mechanism triggers.

PrintViewManager already knows which RenderProcessHost is
starting/finishing window.print(). Call RenderProcessHost::SetBlocked()
as needed.

BUG=903296

Change-Id: Icf61083f840155f00878080959744e84f3e5cb62
Reviewed-on: https://chromium-review.googlesource.com/c/1368582Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618621}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/ccf97ef6bafc..89e50af847ea


git log ccf97ef6bafc..89e50af847ea --date=short --no-merges --format='%ad %ae %s'
2018-12-21 allenwebb@google.com cros_install_debug_syms: Temporary hack to fix crbug.com/917405.


Created with:
  gclient setdep -r src/third_party/chromite@89e50af847ea

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Iba04322da44392a3b113659f420f8f990e9af52e
Reviewed-on: https://chromium-review.googlesource.com/c/1388670Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#618620}

Before this patch, Chrome would crash after reading from disk a binary
dictionary file with Affix structure offsets very close to maximum integer
values. Adding up the Affix structure offset and size was overflowing
the integer into a value that is smaller than the size of the input,
thus bypassing Chrome's validity checks for the binary dictionary file.

This patch checks that the Affix structure offset is less than the
binary size, that adding the Affix structure offset to its size would
not cause an integer overflow, and that adding the Affix group offset to
the size of an integer would not cause an integer overflow either.

After this patch, Chrome invalidates a binary dictionary file with
invalid structure offsets.

Bug: 916873
Change-Id: I9aa7139a1dd610e23234339cb24d948b5f95b522
Reviewed-on: https://chromium-review.googlesource.com/c/1388150Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618619}

This UMA will allow us to understand hether we actually have long-
duration (but not hung) tear-downs.

Bug: 899705
Change-Id: If993447678821b8ec9a714448c94ba405d27fc74
Reviewed-on: https://chromium-review.googlesource.com/c/1388002Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618618}

We believe they still use OpenGL 3.3 and will be blacklisted anyway.

By explicitly blacklisting these GPUs instead of GL version will put them to
SwiftShader sooner, and hopefully this resolved the GPU process hang during
loading SwiftShader libs inside gpu_init.cc

BUG=902247
TEST=crash reports
R=kbr@chromium.org,ccameron@chromium.org

Change-Id: Ia93343c265052d83b8d5dae688ddf0b6f4eba5cd
Reviewed-on: https://chromium-review.googlesource.com/c/1385113Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618617}

I'm debugging a crash that looks like it should be a UAF but doesn't
have a free stack, it made me take a look at this code and reorder when
we write the slot metadata.

Bug: 896019
Change-Id: If06889feb86c2ff51107631ad573f3727a9e0044
Reviewed-on: https://chromium-review.googlesource.com/c/1388651
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618616}

Add posibility to disable these flows for autotests where it is racy or
add unwanted load that affect test stability.

BUG=b:119216406
BUG=b:121271177
TEST=test_that eve cheets_PlayStoreTest with modified test that accepts
these flag and confirm it is faster, and is not influenced by app sync
flow.

Change-Id: I3f839481d0dbfd738a89c82c93f1eaafba22cd34
Reviewed-on: https://chromium-review.googlesource.com/c/1385855Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618615}

TBR=kojii@chromium.org

Change-Id: Iff286b113ca670a27566af8a07f7809c0d59e648
Reviewed-on: https://chromium-review.googlesource.com/c/1388433Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618614}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1a7931e51783..6b69b658db67


Created with:
  gclient setdep -r src-internal@6b69b658db67

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Icfa441ab6fb1ba089c8152ebbef4e5ed42bb0dbe
Reviewed-on: https://chromium-review.googlesource.com/c/1388631Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#618613}

Add the infrastructure to run Proguard on the TrichromeLibrary APK, and
give it a basic configuration that preserves the one class that's loaded
from the library at present.

The final build config for Trichrome may not run Proguard in this way,
but doing it for now lets us treat the APKs uniformly (e.g. a .mapping
file is created, even though obfuscation is a no-op in practise).

Bug: 887078
Change-Id: If52ce4da3c054a27c17fbb7becc275d090f3f460
Reviewed-on: https://chromium-review.googlesource.com/c/1388823Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618612}

This CL fixes the case where the lookalike URL heuristics are triggered for non-web URLs such as chrome:// schemes. It also converts test cases to use non-private domains.

Bug: 843361
Change-Id: I2cb7cdc975ba330d547b604ba4fc9fe8c45969a6
Reviewed-on: https://chromium-review.googlesource.com/c/1388562Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618611}

When loading an extension in a test environment, wait for the content
scripts to fully load. This avoids a race condition where we would load
an extension and then navigate to a tab, but potentially have scripts
that should have injected not yet loaded.

This CL incorporates the waiting period into the common loading code; a
followup will remove other tests' ad hoc waits.

Bug: 898682

Change-Id: I2c6638bac5fae332854ea89226c7fc4633648f07
Reviewed-on: https://chromium-review.googlesource.com/c/1374691
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618610}

We don't yet compute min-width:auto though.

Bug: 845235
Change-Id: I74fff512b283647cad12406233fc8b68dccfb55e
Reviewed-on: https://chromium-review.googlesource.com/c/1381836Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618609}

GetSeparatorBounds and GetSeparatorOpacities were not used by clients of
TabStyle, only internally. This CL moves them to be private methods of
GM2TabStyle.

Change-Id: Ia5505a6faf576f77b0ccc5c6a0a48e8d2d2f1237
Reviewed-on: https://chromium-review.googlesource.com/c/1388213
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618608}

This CL renames ImageController::GetTasksForImagesAndRef to
ConvertNonPaintWorkletImagesToTasks, and the GetTasksForPaintWorkletImages
to ConvertPaintWorkletImagesToTasks, which is more clear what the
function is doing.

This Cl shold not introduce any behavior change.

Bug: 907897
Change-Id: I6be1db8fa61ee58588fa9507f6b82f7570a267ec
Reviewed-on: https://chromium-review.googlesource.com/c/1383539Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618607}

When the compositor touch action flag is enabled, we receive the ack
for touch events from the compositor thread, and then the main thread
touch action is sent from a separate IPC channel.

When we receive the ack from the compositor thread, we do not stop the
timeout monitor. Instead we should stop that when the main thread touch
action is received. This CL fix this issue.

Bug: 907959
Change-Id: Ia9b4706ec384c291be3f178a76dd449276f41566
Reviewed-on: https://chromium-review.googlesource.com/c/1382907
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618606}