- 30 Sep, 2019 40 commits
-
-
Rohit Rao authored
BUG=934252 Change-Id: Ic704622e78833816458d8b06d310eda8583fff59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827864 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#701201}
-
Eric Foo authored
See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I192c2ad0daab7ef35dbc24e669634caee810ff03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829248Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#701200}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1fab224fb263..cc55bdc0a75e git log 1fab224fb263..cc55bdc0a75e --date=short --no-merges --format='%ad %ae %s' 2019-09-30 ilkos@google.com Merge "Demangle symbols." 2019-09-30 taylori@google.com Merge changes I2d486952,I354b1b16 2019-09-30 treehugger-gerrit@google.com Merge "perfetto-ui: Make panning and zooming snappier" 2019-09-30 eseckler@google.com Merge "Abstract adb consumer port" Created with: gclient setdep -r src/third_party/perfetto@cc55bdc0a75e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I100cca818cfe3c424f2ee697fd07a153bc7bec2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829872Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701199}
-
liberato@chromium.org authored
Test is flaky. Bug: 1007006 Change-Id: If7e4b658336269e244894b50f228ca5e8720cd7a TBR: bsep@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831947Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#701198}
-
liberato@chromium.org authored
Test is flaky. Bug: 1006415 Change-Id: Ie4881fe7c47ad1b5c3226545f338d8eb204905cf TBR: dmurph@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831986Reviewed-by:
-
Nicolas Ouellet-Payeur authored
When disabled, built-in LBS deletes cache.dat on startup, even if the LBS extension is also installed. Depending on the order things happen in, this may cause built-in LBS to delete the extension's cache.dat file, which is needed for IE=>Chrome switching to work correctly. After this change, built-in LBS keeps cache.dat and sitelistcache.dat if the extension is enabled. Bug: 1000099 Change-Id: I2ecf2f0942fe5888da43b49927cf2734f6e4ae00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829478 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#701196}
-
Sergey Poromov authored
Failures: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/29732 TBR=alexilin@chromium.org Bug: 1006637 Change-Id: I3122de904ef45f55b464a4da6c5e064f6f9d234f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829712Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#701195}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/faa2a365b5c0..c475f5650417 git log faa2a365b5c0..c475f5650417 --date=short --no-merges --format='%ad %ae %s' 2019-09-30 amaiorano@google.com Regres: disable warnings as errors Created with: gclient setdep -r src/third_party/swiftshader@c475f5650417 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/141758871 Change-Id: I7b49bcf2ca05a53f944e5dd55abf503dea9bda17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832016Reviewed-by:
-
Ken Rockot authored
Bug: 1009022 Change-Id: I9efb96aff4b59ee331ea39d7bf158d1d4b708f7f Tbr: dom@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832047Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#701193}
-
Ken Rockot authored
Bug: 1009016 Change-Id: Iac8d8cb40f74c9c5d4c801cd569edd77cacebb02 Tbr: adithyas@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831982Reviewed-by:
-
liberato@chromium.org authored
Test is flaky. Bug: 1007069 Change-Id: I689be7bf4132231c2ba0012770c14e2b025c1e9c TBR: bsep@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831983Reviewed-by:
-
Vasiliy Telezhnikov authored
Some drivers report GL_KHR_debug extension but do not provide required functions. This CL checks if functions are present and removes it from extensions list for Skia. Bug: 1008125 Change-Id: I9f5aec0a26d3fe7c395bc815f9e6d8e7536bad3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829880 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#701190}
-
liberato@chromium.org authored
Test is flaky. Bug: 1009023 Change-Id: I9ffaa0dfae03530aefac43ef9dda0e035f23fdd3 TBR: dvadym@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829669Reviewed-by:
-
Yusuke Sato authored
This CL depends on CL:1814889 (platform2/debugd/). BUG=b:139752657 TEST=try Change-Id: I63b958f09455de6360c2e669dab23bf6b1751c7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815361 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Auto-Submit: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#701188}
-
Fernando Serboncini authored
Bug: 995235 Change-Id: I88c771e300577eea4cae77fd233e1bd866359b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829485 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#701187}
-
Rayan Kanso authored
Crash reports show that this was happening in the SkBitmap's copy constructor, which likely means that the Resize image operation sometimes returns a null icon. This CL adds an extra check. Bug: 1003293 Change-Id: If26c5a9a2690a6d0124dc2b7fcaaa487681dafce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805654 Auto-Submit: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#701186}
-
liberato@chromium.org authored
Test is flaky. Bug: 1008881 Change-Id: Idf42d7960122ad6aba9f34c57c0f5218fc0952f4 TBR: amistry@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831411Reviewed-by:
-
Jesse Schettler authored
This reverts commit c79e6751. Reason for revert: Fixing CTS for ToT Original change's description: > arc: Enable print-spooler-experiment feature flag by default > > Also, enable the flag for all channels except stable. > > Bug: b:130798103 > Test: android-sh -c getprop | grep ro.boot.arc_print_spooler > Change-Id: I4ca45c248737bbc0e5c90ed679bfe2b77ec9ed12 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784006 > Reviewed-by: Elijah Taylor <elijahtaylor@chromium.org> > Commit-Queue: Jesse Schettler <jschettler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693860} TBR=yusukes@chromium.org,elijahtaylor@chromium.org,jschettler@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:130798103 Change-Id: I400c7050bbf4c82ffba230b1900d14daa309c628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831273Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#701184}
-
Yulun Wu authored
Bug: 984365 Change-Id: I06da9bc0f3498696133b13dd1c724eb6ef2f1beb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827743Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#701183}
-
Fernando Serboncini authored
Bug: 995235 Change-Id: I2aaebe2c87f43a647e9b6823f13b64f890a7c7fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829483 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
-
Jae Hoon Kim authored
Instead of extension to the |GetEolStatus()| DBus method within update_engine, it is completely viable for addition of the EOL related fields into the |GetStatusAdvanced()| DBus method instead. Within Chrome, the |UpdateEngineClient| will still expose |GetEolStatus()| (will deprecate in the future crbug.com/1005511), but now has |GetEolInfo()| method which internally calls |GetStatsAdvanced()| instead of |GetEolStatus()| of update_engine to get EOL info. For eol_date field to be populated from CrOS please follow: chromium:1783897 Bug: 998983 Test: autoninja -C out_${SDK_BOARD}/Release chrome nacl_helper && deploy_chrome --build-dir=out_${SDK_BOARD}/Release --to=$IP Test: autoninja -C out/Default unit_tests && testing/xvfb.py ./out/Default/unit_tests Change-Id: I0d4d0e630336a374b3f4bdb546cfbab8ce7a89d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811185Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Cr-Commit-Position: refs/heads/master@{#701181}
-
Paul Lewis authored
This is a reland of 57ceafe5 Original change's description: > Rolls newer devtools-node-modules DEPS > > Change-Id: I1963ec832b036569e24cb4c09f95142318c0fe1f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827563 > Commit-Queue: Paul Lewis <aerotwist@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701091} TBR=yangguo@chromium.org Change-Id: I1ad081d0fcb7b37d009afd0ca30dc79fd8023eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831912Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#701180}
-
Raul Tambre authored
[2/51124] ACTION //:blink_web_tests(//build/toolchain/win:win_clang_x64) FAILED: bin/run_blink_web_tests.bat C:/Program Files/Python38/python.exe ../../build/util/generate_wrapper.py --executable @WrappedPath(../../third_party/blink/tools/run_web_tests.py) --wrapper-script bin/run_blink_web_tests.bat --output-directory . --script-language batch -- --debug File "../../build/util/generate_wrapper.py", line 104 os.chmod(args.wrapper_script, 0750) ^ SyntaxError: leading zeros in decimal integer literals are not permitted; use an 0o prefix for octal integers Bug: 941669 Change-Id: I283d4a74bc7ccc4c2f0828b237e39e04b9831ce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817877Reviewed-by:John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#701179}
-
Maks Orlovich authored
Blockfile's sparse format makes it inefficient to support all of 64-bit sparse offset address space, so it imposes a far lower limit. Refine how operations above/overlapping the limit work to make it easier for HttpCacheTransaction to recover from them being unsupported, by letting one read up to the limit, and having GetAvailableRange cleanly report "nothing found" for things beyond it. Also clarify how the limit relates to other config parameters, rather than have it as a magic number. Bug: 770694 Change-Id: I22312d1c5ac450e0ef5953a96d0b169355c77454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758434Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#701178}
-
Yue Zhang authored
Bug: 1008232 Change-Id: I0032cabd435015a8a54e19628c5444de3c0e2755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827491Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#701177}
-
Eric Karl authored
Missed these in https://chromium-review.googlesource.com/c/chromium/src/+/1810317 Bug: 995965 Change-Id: Ib6e58b7f91a2d1dca5b62a91efeb936e5bdf70d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827254 Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#701176}
-
liberato@chromium.org authored
Test is flaky. Bug: 1009347 Change-Id: Idd99519acf6cf0d0a8a10f7c04fb19fb4a9dd910 TBR: dimich@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831945Reviewed-by:
-
Nektarios Paisios authored
This is a speculative fix for the busy problem on Mac whereby some pages hit a DCHECK in AXPosition. On Mac there are some extra AXNodes that are only created for table columns. These have negative node IDs, and so using -1 as the invalid node ID might create a conflict with those nodes. Table columns are not created on any other platform. R=dmazzoni@chromium.org Bug: 1006842 Change-Id: I38da62f41c570cebfde197895fb6bebb16649cc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827999Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#701174}
-
Roger Tawa authored
When uploading files for deep scanning, chrome should use the trigger type FILE_UPLOAD so that the correct rules can apply. Bug: None Change-Id: Icef41bd726aac5d664aef699f10c06edc1f5c6f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827740 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#701173}
-
liberato@chromium.org authored
Test is flaky. Bug: 1009359 Change-Id: I63fbc1be9e65ce0ee4eb8b8c53f40270a2ffa8d7 TBR: michaelbai@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829581Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/31464956f9ed..5c101eb826b8 Created with: gclient setdep -r src-internal@5c101eb826b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1009419,chromium:None Change-Id: I601460b2309f5c7f3b54f7646e44f70b19bda617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829495Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701171}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d9d7419a45d6..ec36c06fb12c git log d9d7419a45d6..ec36c06fb12c --date=short --no-merges --format='%ad %ae %s' 2019-09-30 saklein@chromium.org chroot_lib: Fix goma env setup. Created with: gclient setdep -r src/third_party/chromite@ec36c06fb12c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I4fcd824c7cb3226f28d97eee4954160876527e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831782Reviewed-by:
-
Sergey Poromov authored
Failures: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/15481 TBR=newcomer@chromium.org Test: Run interactive_ui_tests with MSan. Bug: 1008744 Change-Id: I3e8a9775833f2f5810ef4687479c48eb8f7dd343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832261Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#701169}
-
Xiaocheng Hu authored
Two classes became redundant wrappers after crrev.com/c/1769554, so this patch removes them. Bug: 991672 Change-Id: I69a0131036563d1e90820381c711de91bd63a455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829783Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#701168}
-
Mikhail Khokhlov authored
Bug: 981349 Change-Id: I8faa2aa790327a838978d3f002ad706db70e9d18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829337 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#701167}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/45b176fc2289..32eae4c231b4 git log 45b176fc2289..32eae4c231b4 --date=short --no-merges --format='%ad %ae %s' 2019-09-30 saza@webrtc.org AEC3: use different seed for different channels in CNG 2019-09-30 mbonadei@webrtc.org Always pass arguments to INSTANTIATE_TEST_SUITE_P. Created with: gclient setdep -r src/third_party/webrtc@32eae4c231b4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ic10064ed715a2f9981da36f3692c7e6df1f36c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830316Reviewed-by:
-
liberato@chromium.org authored
Bug: 1009464 Change-Id: Idd6aa2b18ee7dcc6cead9050944ccfe1cb6f15c6 TBR: sky@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831449Reviewed-by:
-
liberato@chromium.org authored
Bug: 1009465 TBR: mdjones@chromium.org Change-Id: I40d0a3919d92e02d885648707569735f3cf80d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831448Reviewed-by:
-
Jeroen Dhollander authored
This is a reland of de88f517 Note: No changes were made in this reland, the only difference is that now the Assistant internal code has been uprev'ed to the correct edition. Original change's description: > Introduce AssistantServiceManager::State::STARTING state. > > Until now the |AssistantServiceManager::State| enum did not distinguish > between the state in which libassistant was started (but not ready yet) > and in which it is ready. > That distinction is needed to be able to add tests using libassistant, > as they have to wait until it is ready. > > So now there are 4 states: > - STOPPED: It has not started/it has been stopped (this is the same > as the old STOPPED state). > - STARTING: |AssistantServiceManager::Start| has been called and the > libassistant |AssistantManager::Start| call has not finished yet (this > is the same as the old STARTED state). > - STARTED: the libassistant |AssistantManager::Start| call has > finished, but libassistant has not signalled it is ready yet (this > is the same as the old RUNNING state). > - RUNNING: libassistant signalled it is ready (this state is new). > > As this CL also introduces the first unittests for > |AssistantServiceManagerImpl|, it also contains a bunch of fake/dummy > classes used for the unittests. > > This CL increases test coverage in //chromeos/services/assistant from 28% > to 41%. > > Change-Id: If38a6b70e22e6392537b6658e5f39eebf6dd9099 > BUG: b/141264108 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810019 > Commit-Queue: Jeroen Dhollander <jeroendh@google.com> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700410} Change-Id: Ifb9c7ebc235d2813fdb331408873a37791bc8d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828225 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#701163}
-
Nate Fischer authored
This permits createInvocationHandlerFor(null) to return null, and follows through with the related methods (supporting or not supporting nullable values as appropriate). The main advantage is this causes nullability mistakes to have clearer error messages. Instead of triggering an NPE inside BoundaryInterfaceReflectionUtil internals, we treat null InvocationHandlers as representing null instances, and calling methods on those instances will trigger NPE much more clearly. This should not change behavior, it should only make it clearer under conditions where we would have already hit NPE. This should be backwards and forwards compatible: * Old WebViews do not pass null InvocationHandlers, so new versions of the AndroidX library will treat these InvocationHandlers the same (nonnull). * If old WebViews receive a null InvocationHandler, they will NPE (but would have NPE'd anyway). * Same vice-versa for new WebViews and old versions of the AndroidX library. Bug: 1009056, 998001 Test: Manually cherry-pick this into AndroidX, verify it compiles with http://aosp/1129297 Test: Manually cherry-pick this into AndroidX, ./gradlew :webkit:connectedAndroidTest (against M76 and tip-of-tree) Change-Id: I3246d0b4a30ef752977d2e8dd4f51889006b7536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829770Reviewed-by:
Laís Minchillo <laisminchillo@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#701162}
-
