- 16 Apr, 2018 40 commits
-
-
Theresa authored
Use the native page's margin to translate the canvas used to capture the bitmap used in the tab switcher. Without explicitly considering margin, the snapshot is actually shorter than the tab content, causing the content to "jump" when entering and exiting the tab switcher. BUG=832588 Change-Id: Ifdd871369341877c80214fbe767a602ee1f80d23 Reviewed-on: https://chromium-review.googlesource.com/1013132Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#551043}
-
Corentin Wallez authored
BUG=chromium:815092 Change-Id: I31ba1343a53f3e0ca13442f24f6332d130fddf43 Reviewed-on: https://chromium-review.googlesource.com/1013858Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#551042}
-
Corentin Wallez authored
After the LUCI migration it is superseeded by angle.try. Also update the link that's shown in the MILO console. BUG=chromium:815092 Change-Id: I6c2dde882ee01e117cfac6695ac9773092a6b09c Reviewed-on: https://chromium-review.googlesource.com/1014172Reviewed-by:
-
Allen Vicencio authored
Adds "Native Network File Share (SMB)" as the name for "@smb" provider id in metrics. Bug: chromium:757625 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic99300e66d9e0007a8946661a4a24a4cfc9d1b4c Reviewed-on: https://chromium-review.googlesource.com/1011242Reviewed-by:
Steve McKay <smckay@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Allen Vicencio <allenvic@chromium.org> Cr-Commit-Position: refs/heads/master@{#551040}
-
Justin Novosad authored
This fixes rendering glitches in pages with videos in them on Android WebView. I do not yet understand why the GL state is being changed without going through the gpu command buffer, but this seems to be happening with Android WebView on pages that have video elements. This is a quick fix to resolve A release-blocking regression. Further investigation will be a part of follow-up work: crbug.com/832810 BUG=826636 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id9b620ffcf74fd674d53a2eadc6efc932e9505d8 Reviewed-on: https://chromium-review.googlesource.com/1012517Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#551039}
-
Joone Hur authored
This CL fixes the below build error: In file included from ../../components/download/downloader/in_progress/in_progress_cache_impl.cc:5: In file included from ../../components/download/downloader/in_progress/in_progress_cache_impl.h:15: In file included from ../../components/download/downloader/in_progress/download_entry.h:11: In file included from ../../components/download/public/common/download_url_parameters.h:25: In file included from ../../services/network/public/cpp/resource_request_body.h:18: ../../services/network/public/cpp/data_element.h:24:10: fatal error: 'services/network/public/mojom/chunked_data_pipe_getter.mojom.h' file not found ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Bug: None Change-Id: I5ed108749c6d8287d91400b4324927cd58e5cd6a Reviewed-on: https://chromium-review.googlesource.com/1013230Reviewed-by:Min Qin <qinmin@chromium.org> Commit-Queue: Joone Hur <joone.hur@intel.com> Cr-Commit-Position: refs/heads/master@{#551038}
-
Leonard Grey authored
Cocoa browser's logic for deciding whether to use the light (dark mode) or regular icon requires converting the theme frame color to an NSColor in NSCalibratedWhiteColorSpace and checking against an empirical threshold. To keep things in Views-land and maintain the same interface, this change uses the light icon iff color_utils::IsDark returns false for the given text color. In practice, I will venture that anywhere this disagrees with Cocoa is a borderline case anyway. Bug: 792610 Change-Id: I57b1c0cb90cf06fce4a8a3f31806dedd86791ebc Reviewed-on: https://chromium-review.googlesource.com/1012966Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#551037}
-
Sammie Quon authored
This is a reland of b9d68c49 Left the previously disabled test disabled in the reland. Will fix in a seperate cl. TBR=oshima@chromium.org Original change's description: > splitview: Grab app for splitscreen only happen on long press. > > The indicators and the item enlarging only happen after long press, or > if the item has been dragged. > > This is preparation for fling to dismiss. It also removes a flicker of > the indidcators when you tap to open a item. > > Also renables a previous flaky test. Tested locally and it is not flaky > no more. > > Test: ash_unittests SplitViewWindowSelectorTest.* > Bug: 817863 > Change-Id: I9c20f2fa9a3c0a9218b3072c5b3d25711ad9c655 > Reviewed-on: https://chromium-review.googlesource.com/996528 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550884} Bug: 817863 Change-Id: I0d6b255a89e69443af2e6509a0769622c8f64fb3 Reviewed-on: https://chromium-review.googlesource.com/1012735Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#551036}
-
Ian Vollick authored
If a transition was enqueued but not serviced and, much later, another transition is enqueued, it should transition from the final value of the earlier transition. Bug: 832650,830592 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I751c5d26101bfa197818ccd2f72188513ed044f2 Reviewed-on: https://chromium-review.googlesource.com/1014008 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#551035}
-
crystallambert@chromium.org authored
This article serves as a central location for best practices to write a high performance extension. Bug: none Change-Id: Ie458a57b48dd0213e9effca9b69dd7a67910227e Reviewed-on: https://chromium-review.googlesource.com/821690 Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551034}
-
Wez authored
- Enable CHECK against registration of new keep-alives during shutdown. - Promote some DLOG() checks to DCHECKs to make issues more visible. Bug: 720078 Change-Id: I11e24a8de0ec5ab9e0a71f776d4b7149bb847ad2 Reviewed-on: https://chromium-review.googlesource.com/1013394Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#551033}
-
Avi Drissman authored
This reverts commit 4df8a2dd. Reason for revert: Tests are broken on Ozone Linux https://ci.chromium.org/buildbot/chromium.linux/Ozone%20Linux/6600 PerfettoIntegrationTest.PacketsEndToEndProducerFirst PerfettoIntegrationTest.TracingRestarted PerfettoIntegrationTest.PacketsEndToEndConsumerFirst Original change's description: > Add a Mojo-based transportation layer for Perfetto > > This adds a base layer that individual logging protocols (like tracing) > can use to send their data to Perfetto, using Mojo messaging and > shared memory. > > First CL of several, after this comes the Chrome tracing layer: https://chromium-review.googlesource.com/c/chromium/src/+/981270 > > A preview of the full integration can be seen here: https://chromium-review.googlesource.com/c/chromium/src/+/852808 > > The design doc for the integration: https://docs.google.com/document/d/1a8lvN3zYWEyAsBjtuRRsy0fWOWdUdbw6bGnKLBscGdw/edit > > R=primiano@chromium.org,skyostil@chromium.org > > Change-Id: Ie1db5745ebffdcf1e2d74e2f6b12395f447c8552 > Reviewed-on: https://chromium-review.googlesource.com/980578 > Reviewed-by: oysteine <oysteine@google.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Primiano Tucci <primiano@chromium.org> > Commit-Queue: oysteine <oysteine@google.com> > Cr-Commit-Position: refs/heads/master@{#551019} TBR=dcheng@chromium.org,primiano@chromium.org,oysteine@chromium.org,skyostil@chromium.org Change-Id: Id212b8af28bd08276b6d0ccf48e59063bd7179de No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1013343Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#551032}
-
Avi Drissman authored
BUG=831577 Change-Id: Iaee76e352162b0afcbe61b9ee62c5db5ef9adc7f Reviewed-on: https://chromium-review.googlesource.com/1008544Reviewed-by:
Georges Khalil <georgesak@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#551031}
-
Elly Fong-Jones authored
This change: 1) Uses the system focus ring color even when SecondaryUiMd is enabled 2) Moves focus ring thickness and inset out to PlatformStyle 3) Adds Mac overrides of the default values Bug: 832306 Change-Id: I6c18d9d0431dc411a5cb95f9c0639e41f4aa1127 Reviewed-on: https://chromium-review.googlesource.com/1012163 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Matt Menke authored
In particular, unescape entire unicode characters at once, and then compare against unescape blacklists, rather than the other way around, to simplify code and avoid the tree structure of the old code. This will also allow the method to use icu's code point classification logic, at some point in the future. Also separate out comparing against the character blacklist and UTF-8 character decoding into separate methods, and add a few more test cases to unittest. The method itself should behave exactly the same as before. Bug: 824715 Change-Id: I5311f25bfda4132b122ec4a079740adf093099a3 Reviewed-on: https://chromium-review.googlesource.com/998014 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#551029}
-
Morten Stenshorne authored
There's no need to position pending floats at this point, since there should be none. Added a DCHECK. If a child knows its BFC offset, it has no reason to leave behind pending floats. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I288b0cbd0ce43e422eddfe331dc02a5ee3afd6a8 Reviewed-on: https://chromium-review.googlesource.com/1013486Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#551028}
-
Krishna Govind authored
R=cmasso@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib455f27786c09a9439a68f6a376584efdc8c9209 Reviewed-on: https://chromium-review.googlesource.com/1014288Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#551027}
-
Lukasz Anforowicz authored
The new UMA should help evaluate how often the spare is missing (e.g. because of low process limit on low-memory devices), mismatched (e.g. when simultaneously navigating in 2 profiles) or taken. The spare can only help improve performance of cross-site navigations if it is actually taken. Bug: 808114 Change-Id: Ic37cacf014de73f9adefc0407e60b4cfa246028b Reviewed-on: https://chromium-review.googlesource.com/1012510 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#551026}
-
Tommy C. Li authored
When the URL is un-elided, and then the Omnibox is blurred: a) If the text has not been edited, re-elide the URL. b) If the text has been edited, leave the complete edited text as-is. This CL adds two tests - one for each scenario. Bug: 797354 Change-Id: Ia70cf4357218e3b8f043be73716f067d7b287fd4 Reviewed-on: https://chromium-review.googlesource.com/1012778 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#551025}
-
Jérôme Lebel authored
Client secret is not use on Chrome iOS, and the API is removed from SSO. Related to crrev.com/c/975127 and crrev.com/i/480972. Bug: 516021 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If590ae3db2959b2146b6d27a606745ef749050ec Reviewed-on: https://chromium-review.googlesource.com/973229 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#551024}
-
Weidong Guo authored
Background: Long press on app icon in folder will enlarge the icon, but release will not reset it. The long press gesture event is not handled by AppListItemView, thus passed to AppsGridView which handles it. The gesture end event will thus be sent to AppsGridView directly without going through AppListItemView. This is caused by go/cgcl/987293 Change: Only handle the scroll begin event in AppsGridView if in folder instead of all gesture events. BUG=830982 Change-Id: I2ca5bddaf22cd198d6e9cca5ee5f04c9798153e8 Reviewed-on: https://chromium-review.googlesource.com/1008906Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#551023}
-
Brian Salomon authored
This reverts commit 56044665. Reason for revert: Fast paths for premul/unpremul RGBA added to new code paths to accelerate get/putImageData. Original change's description: > Revert "Use new Skia GPU read/write pixel code paths" > > This reverts commit f17c70fe. > > Reason for revert: > > It looks like this change: > > slowed down the file___static_top_25_weather.html rasterize_and_record time on the AndroidOne (crbug.com/825594) > > slowed down getImageData and putImageData for the HTML5 Canvas across the board (crbug.com/825585) > > Bug: 825594 > Bug: 825585 > > Original change's description: > > Use new Skia GPU read/write pixel code paths > > > > Change-Id: I8ea66d1b3bb8db174deab690a0cdacc39cf81992 > > Reviewed-on: https://chromium-review.googlesource.com/973267 > > Reviewed-by: Robert Phillips <robertphillips@google.com> > > Commit-Queue: Brian Salomon <bsalomon@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#544777} > > TBR=bsalomon@chromium.org,robertphillips@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: Icaee5a1afa55bc8aec4567687661dacef0ccf565 > Reviewed-on: https://chromium-review.googlesource.com/980292 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Robert Phillips <robertphillips@google.com> > Cr-Commit-Position: refs/heads/master@{#545787} TBR=bsalomon@chromium.org,robertphillips@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 825594, 825585 Change-Id: I82434eebb65257cf6a92225c2c862fe22aecf093 Reviewed-on: https://chromium-review.googlesource.com/1014140Reviewed-by:
Brian Salomon <bsalomon@chromium.org> Reviewed-by:
Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#551022}
-
James Hawkins authored
R=hansberry@chromium.org Bug: 829039 Test: none Change-Id: I4216ffa94963a3f2bfdab08b73dd135fd78f4007 Reviewed-on: https://chromium-review.googlesource.com/1012981 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#551021}
-
Ahmed Fakhry authored
This reverts commit 94f04868. Reason for revert: This doesn't work for PWAs, I will reland with a better fix so that it can be merged as a single CL. Original change's description: > Fix extensions badges and decorations positions > > The extensions browser actions badges and decorations should > be positioned at the corners of the icon area, rather than the > corners of the full button's area (i.e. ignoring the paddings). > > Screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=831946#c11 > > BUG=831946 > > Change-Id: I977883a3e6127e1f91779a7e73b4adb7fa7c6471 > Reviewed-on: https://chromium-review.googlesource.com/1013290 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550855} TBR=thestig@chromium.org,rdevlin.cronin@chromium.org,afakhry@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 831946 Change-Id: I718ab6842d4bf55f5f1cf6f833e3638974c2fea8 Reviewed-on: https://chromium-review.googlesource.com/1012734Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#551020}
-
Oystein Eftevaag authored
This adds a base layer that individual logging protocols (like tracing) can use to send their data to Perfetto, using Mojo messaging and shared memory. First CL of several, after this comes the Chrome tracing layer: https://chromium-review.googlesource.com/c/chromium/src/+/981270 A preview of the full integration can be seen here: https://chromium-review.googlesource.com/c/chromium/src/+/852808 The design doc for the integration: https://docs.google.com/document/d/1a8lvN3zYWEyAsBjtuRRsy0fWOWdUdbw6bGnKLBscGdw/edit R=primiano@chromium.org,skyostil@chromium.org Change-Id: Ie1db5745ebffdcf1e2d74e2f6b12395f447c8552 Reviewed-on: https://chromium-review.googlesource.com/980578Reviewed-by:
oysteine <oysteine@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: oysteine <oysteine@google.com> Cr-Commit-Position: refs/heads/master@{#551019}
-
Becca Hughes authored
If an extension has an <iframe> it should be allowed to autoplay. BUG=821284 Change-Id: I1e11cbdef6a81acf5ea3e6d3dcaadc8c13464c16 Reviewed-on: https://chromium-review.googlesource.com/962803Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#551018}
-
Pavel Feldman authored
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I7aa90dcc7026df4c14950b5f0aee21134fe9ddb0 Reviewed-on: https://chromium-review.googlesource.com/1013335Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#551017}
-
James Hawkins authored
In previous implementations of the login screen, a user with SmartLock enabled could press return with an empty password field in order to authenticate. This behavior appears to not have been carried over in the newer Views implementation. The fix is to special case the auth attempt and divert the attempt to the SmartLock flow in the case where the user has tap-to-unlock and the password field is empty. R=xiyuan@chromium.org Bug: 818400 Test: LoginAuthUserViewUnittest.PressReturnWithTapToUnlockEnabled Change-Id: I1ecaba0d285fd43b231ca8028c19b0682f073b77 Reviewed-on: https://chromium-review.googlesource.com/1013398 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#551016}
-
Raymond Toy authored
The class is named ConeEffect but the file was cone.h and cone.cc. Rename the files to cone_effect.h and cone_effect.cc Fix a blink style issue in cone_effects.cc too. Bug: 832708 Change-Id: I5acd880ba61cd1597c10e488aa318e939ac1c321 Reviewed-on: https://chromium-review.googlesource.com/1011455Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#551015}
-
Moe Ahmadi authored
This is a follow up CL to crrev.com/c/1011102. It removes the old header file that was kept around in order to avoid breaking ios downstream. TBR=pkl@ Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I53034903eeae0bfcae20cf048fd6ced845e02e06 Reviewed-on: https://chromium-review.googlesource.com/1014188Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#551014}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c90ccbc26d04..d88eaf5315d4 $ git log c90ccbc26..d88eaf531 --date=short --no-merges --format='%ad %ae %s' 2018-04-15 cmtice [release builders] Disable CFI on caroline & terra. Created with: roll-dep src/third_party/chromite BUG=chromium:830321 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I9289723920afdf2dda519c0cb1c750efadc2f29f Reviewed-on: https://chromium-review.googlesource.com/1014175Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551013}
-
Dmitry Gozman authored
- Expose LeakDetector interface in render process, remove unneeded plumbing. - Switch from IPCs to Mojo in layout test runner. - Move implementation to controller. - Migrate inspector usage to browser. - Merged two methods of LeakDetector into a single one. - Fixed leaks in existing tests. Needs a followup to not register fetchers in leak detector, but instead have a collection in ResourceFetcher. Change-Id: Iba0ffc95de5b8beb27409b4eb51435c5e1397951 Reviewed-on: https://chromium-review.googlesource.com/999170Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
We did not allow recalculating style for reattachment as part of RecalcStyle when we had custom style hooks because some elements had CustomStyleForLayoutObject() methods which depended on parent layout objects. This is no longer true, so we can now always recalc style for re-attachment. That means we'll also need to call custom style hooks WillRecalcStyle/DidRecalcStyle for re-attacment styles as well. Bug: 813057 Change-Id: I403c30e0f9f6934bd96d3da84488a6b3c489a50e Reviewed-on: https://chromium-review.googlesource.com/925702Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#551011}
-
Ian Vollick authored
Gives the omnibox a soft shadow. Bug: 833375 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I17b9bbf4fdd2d8830e0157ddfd6b9ef57008ecb2 Reviewed-on: https://chromium-review.googlesource.com/1014010 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
-
https://chromium.googlesource.com/catapult.git/+log/ac39bc379194..dc1e62593e6c $ git log ac39bc379..dc1e62593 --date=short --no-merges --format='%ad %ae %s' 2018-04-16 simonhatch Dashboard - Remove code/command_line from TestMetadata. 2018-04-16 simonhatch Dashboard - Remove debug log statement. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I7bd186e0b22267e61c73b1e0b0cbcaf1377a22a3 Reviewed-on: https://chromium-review.googlesource.com/1012731Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551009}
-
Amirhossein Simjour authored
This will make it easier to write tests and send events directly to the dialog. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib9a25666a213e1279a6491bd61331b4e7c8321e4 Reviewed-on: https://chromium-review.googlesource.com/1012917 Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#551008}
-
Bernhard Bauer authored
Change-Id: I839b4f520300b17e3ba22cf0ea62d2a03b376c5e Reviewed-on: https://chromium-review.googlesource.com/760419Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#551007}
-
Miguel Casas authored
This CL moves the call to VaapiPicture::DownloadFromSurface, which in turn calls VaapiWrapper::BlitSurface(), to be executed in the decoder thread of VaVDA. This considerable offloads the Gpu main thread for more urgent tasks, and anyway the said decoder thread is idle most of the time (seen in chrome:trace), so utilizing it more doesn't impact the overall performance but increases responsiveness. This Chrome:tracing details shows the change (soraka vp9 720p@30) before: https://i.imgur.com/CkqXqTp.png (https://imgur.com/a/pYVpf) after: https://i.imgur.com/o0c4ksW.png (https://imgur.com/a/wblx0) (the actual duration is inconsequential since it depends on the actual frame). nit: TRACE_EVENT1 is moved to the Vaapi*Picture because it results in easier syntax around the PostTaskAndReplyWithResult(). TEST= simplechrome+crosvideo and v_d_a_unittest h264/vp8/vp9 on soraka. No perf regression observed in the produced numbers. Bug: 717265 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Icc4af2ef96141cebf95ac8fbb89c6e386e194a30 Reviewed-on: https://chromium-review.googlesource.com/947341 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#551006}
-
Mostyn Bramley-Moore authored
CL https://chromium-review.googlesource.com/c/chromium/src/+/1008824 added two consts inside SessionStorageDataMap::GetOptions() that shadow existing consts and generate warnigs in jumbo builds. These consts were only used once each, so we may as well just use the values directly. TBR=dmurph@chromium.org Bug: 716490 Change-Id: I09505a9df50ef6d3cc2bc002254027cd791cdcdf Reviewed-on: https://chromium-review.googlesource.com/1013458Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#551005}
-
Boris Sazonov authored
This CL makes several changes to the layout of the streamlined sign-in screen: 1. Hide secondary TextView in the account picker widget if there's no full name available for the account. This includes changing IDs of TextViews, replacing RelativeLayout with two LinearLayouts and some changes in SigninFragmentBase code. See https://crrev.com/c/1010484 for similar changes in AccountPickerDialogFragment. 2. Revise text style for TextViews in SigninView: replace BlackHint2 with BlackBody. These two styles are identical, but used in different contexts. 3. Reorder some XML attributes to match AS ordering (it follows start-top-end-bottom ordering). Bug: 814728 Change-Id: I4a974e3e9360aaa3468f7410315ed8af8cfcdfe4 Reviewed-on: https://chromium-review.googlesource.com/1012841Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#551004}
-
