GitLab

The main use of the settings app is to switch profiles in the app
when you are signed out. For this to be useful it is important that the
sign in enforcement does not happen for the settings app.

BUG=347025

Review URL: https://codereview.chromium.org/190143003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255881 0039d316-1c4b-4281-b951-d872f2087c98

Removed the title to make the tabs start at the very top of the dialog.

Has 3 tabs: Summary, Permissions and Manage
- The Summary tab displays the app's icon, name, version and description.
- The Permissions tab displays the app's permissions as a scrollable list
- The Manage tab is currently empty.

BUG=266739

Review URL: https://codereview.chromium.org/180723010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255880 0039d316-1c4b-4281-b951-d872f2087c98

[IME] Removes the duplicated IMEs in chrome://settings/languages, and support async component IMEs loading in oobe network screen, and fix the wrong indicator issue.

BUG=345604,349829
TEST=None
TBR=nona@chromium.org

Review URL: https://codereview.chromium.org/190033005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255879 0039d316-1c4b-4281-b951-d872f2087c98

HeaderPainter::GetWindowBoundsForClientBounds() shifts the Y
coordinate of the window bounds to ensure it is not negative.
This causes NativeAppWindowViews::GetFrameInsets() to compute
the wrong insets.

Therefore we should leave the Y coordinate of the window bounds
negative in HeaderPainter::GetWindowBoundsForClientBounds().

BUG=349220
TEST=browser_tests (AppWindowBrowserTest.*)

Review URL: https://codereview.chromium.org/180803013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255878 0039d316-1c4b-4281-b951-d872f2087c98

Code in content always gets it now from ContentClient::GetUserAgent. In Chrome, there's a GetUserAgent function which returns it.

BUG=338338
R=isherman@chromium.org, pauljensen@chromium.org, scottmg@chromium.org, tfarina@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255858

Review URL: https://codereview.chromium.org/191093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255877 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255873 0039d316-1c4b-4281-b951-d872f2087c98

There are some browser_tests failures on the buildbots that don't reproduce locally. Reverting while I investigate.

> Simplify the user agent code some more since after r255534 it's not affected by the site's URL.
> 
> Code in content always gets it now from ContentClient::GetUserAgent. In Chrome, there's a GetUserAgent function which returns it.
> 
> BUG=338338
> R=isherman@chromium.org, pauljensen@chromium.org, scottmg@chromium.org, tfarina@chromium.org
> 
> Review URL: https://codereview.chromium.org/191093002

TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/192283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255867 0039d316-1c4b-4281-b951-d872f2087c98

Convert ContentMain to take a struct instead of parameters that vary depending on the platform. This helps reduce ifdef mess, and makes it easier to add extra optional parameters. In a followup cl, I'll move the ui_task parameter from MainFunctionParams to ContentMainParams.

BUG=350550
R=sky@chromium.org

Review URL: https://codereview.chromium.org/190853004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255866 0039d316-1c4b-4281-b951-d872f2087c98

Changing the UsersPerSession UMA metric to count relative user amount changes for sessions which can do multi profile

The old absolute UMA counter was stored upon shutdown. Unfortunately only one in 33 users is shutting down the system properly. As such only a fraction of sessions were accounted for => the values were useless. Furthermore we have decided to only count sessions which could be multi profile sessions.

The new values are recording state changes like e.g. going from one user to two in a single session. As such you might get a resulting stat counter list of:

1: 320 => 320 - 15 - 4 - 1 = 300 single user sessions
2: 15  =>       15 - 4 - 1 = 10  two user sessions
3: 4   =>            4 - 1 = 3   three user sessions
4: 1   =>                    1   four user session

Note that it is not possible for a single user to leave a multi profile session - so the counter will always count up.

BUG=349055
TEST=none

Review URL: https://codereview.chromium.org/180243025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255865 0039d316-1c4b-4281-b951-d872f2087c98

BUG=350421

Review URL: https://codereview.chromium.org/191003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255864 0039d316-1c4b-4281-b951-d872f2087c98

This is part of the "always maximized" feature. Windows which cannot be maximized - or cannot be made to cover the entire screen should have a backdrop behind them which covers the desktop.

Tried various ways to implement this and this seems to be the best solution.

BUG=337567, 337563

Review URL: https://codereview.chromium.org/169643005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255863 0039d316-1c4b-4281-b951-d872f2087c98

Code in content always gets it now from ContentClient::GetUserAgent. In Chrome, there's a GetUserAgent function which returns it.

BUG=338338
R=isherman@chromium.org, pauljensen@chromium.org, scottmg@chromium.org, tfarina@chromium.org

Review URL: https://codereview.chromium.org/191093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255858 0039d316-1c4b-4281-b951-d872f2087c98

Subclass overrides should match base class decls.
No other changes, just reordering functions.

BUG=131660
TEST=none
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/191783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255857 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/189543006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255856 0039d316-1c4b-4281-b951-d872f2087c98

Anchor the bubble to Chrome's app menu; fix the arrow.
Only try to show the bubble if the app menu exists.

BUG=350508
R=sky@chromium.org
TEST=When using the high-contrast-black theme, the chrome bubble shows anchored reasonable.

Review URL: https://codereview.chromium.org/189513007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255855 0039d316-1c4b-4281-b951-d872f2087c98

This makes talkback recognize the accessibility node as containing a link.

R=dmazzoni@chromium.org
BUG=348184

Review URL: https://codereview.chromium.org/184553009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255854 0039d316-1c4b-4281-b951-d872f2087c98

A backwards conditional could, in theory, result in dev tools not being able
to attach to extension background pages. I cannot reproduce a problem with
this but the code is clearly wrong.

BUG=none
TEST=none (QA - nothing to do here)

Review URL: https://codereview.chromium.org/191173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255852 0039d316-1c4b-4281-b951-d872f2087c98

Move quiescence test used by speed index so we can more easily reuse it in other parts of the code.

BUG=339180

Review URL: https://codereview.chromium.org/185413005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255851 0039d316-1c4b-4281-b951-d872f2087c98

BUG=350533

Review URL: https://codereview.chromium.org/189513006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255850 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
NOTRY=True

Review URL: https://codereview.chromium.org/191973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255849 0039d316-1c4b-4281-b951-d872f2087c98

This allows 'gclient sync' to respect use_system_yasm=1

BUG=350593

Review URL: https://codereview.chromium.org/189583010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255847 0039d316-1c4b-4281-b951-d872f2087c98

This implementation only use Chrome video classes for local rendering.
A libjingle representation is created once its connected to a PeerConnection.


BUG=334241

Review URL: https://codereview.chromium.org/155853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255846 0039d316-1c4b-4281-b951-d872f2087c98

BUG=337138

Review URL: https://codereview.chromium.org/190443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255845 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255844 0039d316-1c4b-4281-b951-d872f2087c98

BUG=350540

Review URL: https://codereview.chromium.org/191003008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255843 0039d316-1c4b-4281-b951-d872f2087c98

The AutofillMetrics unittests will be componentized. The infobar-related tests,
however, cannot be componentized, as infobars are currently a //chrome-level
concept. This CL splits out the infobar-related tests from AutofillMetricsTest
into a new AutofillCCInfobarDelegateTest.

BUG=303083

Review URL: https://codereview.chromium.org/177923004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255842 0039d316-1c4b-4281-b951-d872f2087c98

The other changes follow from that.

BUG=82098
TBR=haruki@chromium.org (for chrome/browser/chromeos/drive/drive_file_system_util.h)
TBR=hidehiko@chromium.org (for chrome/browser/chromeos/drive/webkit_file_stream_writer_impl.h)
TBR=noamsml@chromium.org (for chrome/browser/local_discovery/storage/privet_filesystem_attribute_cache_unittest.cc)
TBR=rvargas@chromium.org (for device/hid/hid_connection_linux.cc)
TBR=clamy@chromium.org (for net/disk_cache/simple/simple_test_util.cc)

Review URL: https://codereview.chromium.org/184583008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255841 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140315
Test=None, this bindings is not exposed yet.

Review URL: https://codereview.chromium.org/189923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255840 0039d316-1c4b-4281-b951-d872f2087c98

If the natural size is not set, the <video> tag will set its properties videoHeight and videoWidth to the original, uncropped width and height.If that is used for deciding the <video> render size- the aspect ratio will be wrong.

This cl allow setting the natural_size as well as the visible_rect when calling media::VideoFrame::WrapVideoFrame.

BUG=349450
R=fischman@chromium.org, tommi@chromium.org

Review URL: https://codereview.chromium.org/189513004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255839 0039d316-1c4b-4281-b951-d872f2087c98

Right now the param is always cast to int.

BUG=348810
TEST=ToT webgl conformance conformance/extensions/ext-texture-filter-anisotropic.html
R=kbr@chromium.org,bajones@chromium.org

Review URL: https://codereview.chromium.org/189133004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255836 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255835 0039d316-1c4b-4281-b951-d872f2087c98

The fact that each Get methods can be used with a NULL out-value simply to check that a value exists (and has the desired type) under a given key is used all over chrome, but isn't actually documented so this simply makes it official by documenting and testing this fact.

Also document the fact that GetDouble will succeed for TYPE_INTEGER as well as TYPE_DOUBLE (which was a surprise to me when I wrote the tests for this CL).

Review URL: https://codereview.chromium.org/191983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255834 0039d316-1c4b-4281-b951-d872f2087c98

Tested with NVIDIA, AMD, Intel HD 3000/4000

Actually I also tested with 10.8.5, but at this point I don't
think it's worth making any changes on 10.8.5.

BUG=349137
TEST=
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/189263017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255833 0039d316-1c4b-4281-b951-d872f2087c98

Randomize order in which ready component updates are applied. On demand updates still take precedence.

BUG=343686

Review URL: https://codereview.chromium.org/144523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255832 0039d316-1c4b-4281-b951-d872f2087c98

Now app::ShellMainDelegate initializes with chrome_100_percent.pak
by default. This patch is to remove this dependancy by add all
chrome-specific resources to app_shell.pak.

BUG=348484

Review URL: https://codereview.chromium.org/176873016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255830 0039d316-1c4b-4281-b951-d872f2087c98

Check --utility-enable-mdns before local_discovery::ServiceDiscoveryMessageHandler::PreSandboxStartup call.

BUG=350518

Review URL: https://codereview.chromium.org/191513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255829 0039d316-1c4b-4281-b951-d872f2087c98

Nothing in the spec - or Blink implementation - precludes empty names
for databases. Remove this bogus DCHECK.

Will add Blink-side layout tests once this lands.

BUG=350133
R=cmumford

Review URL: https://codereview.chromium.org/189413007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255828 0039d316-1c4b-4281-b951-d872f2087c98

Add UMA histograms for register promos.

BUG=350228

Review URL: https://codereview.chromium.org/189623004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255827 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338297

Review URL: https://codereview.chromium.org/180983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255826 0039d316-1c4b-4281-b951-d872f2087c98

Build URL for sending client-to-server cacheinvalidation messages.

BUG=325020
R=rlarocque@chromium.org

Review URL: https://codereview.chromium.org/182333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255825 0039d316-1c4b-4281-b951-d872f2087c98