GitLab

TBR=miu@chromium.org

Bug: 908611
Change-Id: I301ab697a2ec894067f62d95beada1fa5f45ba75
Reviewed-on: https://chromium-review.googlesource.com/c/1351800Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610976}

New versions of protoc require a java lite plugin to generate lite
protos. That will be added to the checkout inside
third_party/protoc_javalite using cipd.

Bug: 782237
Change-Id: I808b0acc14832c80e5efc4baacffb3323bc98653
Reviewed-on: https://chromium-review.googlesource.com/c/1338207
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Grace Kloba <klobag@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610975}

This reverts commit 7149ab70.
https://chromium-review.googlesource.com/c/chromium/src/+/1300038

TBR=nednguyen@google.com

Bug: 908515
Change-Id: I08a2b7adbf9fa20c8ccc2d8b6573981f0828c12d
Reviewed-on: https://chromium-review.googlesource.com/c/1351501Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610974}

This is a partial re-land of:
https://chromium-review.googlesource.com/c/1344097
"Read master preferences before create variations to allow
to migrate variations from master preferences to Local State"

That CL's diff is in patchset 1.

However, that CL caused a crash on first run in official builds
due to official build first run logic relying on ResourceBundle
being initialized.

That CL tried to move all first run master prefs import logic to
be earlier. This CL partially reverts that and only moves the
logic specific to variations' first run (which does not depend on
ResourceBundle) earlier, while keeping the rest of first run
import in the same place as before.

Confirmed that this fixes the crash on official builds while
still fixing variations first run.

Also adds a CHECK about ResourceBundle being initialized in the
non-official build codepath too, to match what official build
does.

TBR=cpu@chromium.org

Bug: 907434
Change-Id: I6ae4be40e376d61dd043e37fc4e35bce59473af0
Reviewed-on: https://chromium-review.googlesource.com/c/1351090
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610973}

Bug found coding/testing
https://chromium-review.googlesource.com/c/chromium/src/+/1350375

Bug: 878324
Change-Id: I800bf263f17370d43c7b8413cd6af9cd819bfd0c
Reviewed-on: https://chromium-review.googlesource.com/c/1350421Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610972}

Before this patch, entering an existing card into Payment Request sheet
would show an error "This card is already used". This happened for both
local cards, which are visible in Payment Request sheet, and for server
cards, which can be accessed only in tokenized form through Google Pay.

This patch allows re-entering existing cards.

After this patch, entering an existing card into Payment Request sheet
is allowed. This sheet may display two identical cards after the user
added the card. Autofill will deduplicate two identical local cards, so
the consequent autofill popups and Payment Request sheets will display
the card at most once. In settings, the user will see the card twice
only if one card is local (entered through Payment Request sheet) and
the other card is from the server (synced down from Google Payments
account).

Android already behaves this way.

Bug: 905396
Change-Id: I587e682855075f7035573f89dfd77711b45879ac
Reviewed-on: https://chromium-review.googlesource.com/c/1340377Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610971}

Adds the --output-dir option to sizes.py, which specifies a directory to
dump collected data to in the HistogramSet format. This is the first
step to getting the sizes step working on LUCI, which can't use the
older CharJSON data format for uploading due to it being tied to IP
whitelisting for authentication.

Bug: 906685
Change-Id: Ic4169c34c20d456144af5b15e50acb303affed4c
Reviewed-on: https://chromium-review.googlesource.com/c/1343344Reviewed-by: Ben Hayden <benjhayden@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610970}

When the filter option is selected, matches (rows) which do not match the search query are hidden; when the highlight option is selected, matches which do match the search query are highlighted (light blue).

Bug: 891303
Change-Id: I4c34dae1a1cef2c7baeffdd6de0355ef7ea53f0a
Reviewed-on: https://chromium-review.googlesource.com/c/1340904Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610969}

This splits out the python style guide from the root directory and
allows a better way to facilitate discussions surrounding python style.

This is especially useful as we are now starting to use the yapf
formatter. To reduce the delta from original doc, no mention of yapf was
added, but it will be added here in the future when it is turned on by
default.

Bug: None
Change-Id: Ib524512459cdc4e4872246457e414e0636979dc1
Reviewed-on: https://chromium-review.googlesource.com/c/1347029
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610968}

BUG=907805

Change-Id: I519ba858fdca946ba5541000b2b74359969a697d
Reviewed-on: https://chromium-review.googlesource.com/c/1350980Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610967}

* mash and single-process-mash are under active development
* show-taps and touch-hud-debug are used by developers for touch screen
  debugging

Bug: none
Change-Id: Ic4ce5ff34dd03f270ccfbe645dc321d7ed9b8b28
Reviewed-on: https://chromium-review.googlesource.com/c/1350963Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610966}

Bug: 889029
Change-Id: Ib83dc1fee266cbeef52a16ba19a77d259bfbcd9b
Reviewed-on: https://chromium-review.googlesource.com/c/1334005
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610965}

Clear the entire opt-in dictionary if a user clears cookies

Bug: 907929
Change-Id: I5ec68e09a8763be66b95109174b6281abe54d050
Reviewed-on: https://chromium-review.googlesource.com/c/1348793Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610964}

Needed to debug unexplained behavior seen in browser controls that
don't reproduce in a local Chrome build.

Bug: 861618
Change-Id: I9a6769cd47a3329313628bd714039ec532fc3d94
Reviewed-on: https://chromium-review.googlesource.com/c/1351272Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610963}

Bug: 751628
Change-Id: Ief50f500266330c5ecceff718001f92bd7d4f467
Reviewed-on: https://chromium-review.googlesource.com/c/1291840Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610962}

This is to prevent "directory traversal attack", e.g. when the
caller provides a path such as:
"../../../../../var/log/chrome/wp.jpg".

Bug: 908304
Test: Using the test extension provided in the bug.
Change-Id: I5fc699963cc32c85042d065d19e3842566cde5f1
Reviewed-on: https://chromium-review.googlesource.com/c/1351426Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610961}

Bug: 906357
Change-Id: I1fab7e52c71a7358a5f22e2fc99cda064b29918d
Reviewed-on: https://chromium-review.googlesource.com/c/1348257Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610960}

Latest UI - https://screenshot.googleplex.com/qqSuM2bvctM.png

UI + tool tip - https://screenshot.googleplex.com/RPZkrxgBdnN.png

Changes
1) Remove legal message from second screen as it is not needed
2) Add tool tip icon and adjust spacing for name.

UX is still working on final spaces to make it clean post Legal removal
message world. Would like to get this CL before M72 branch date,so dont need
to ask TPMs for merge. Small UI spacing fixes, can request TPMs.

Bug: 848955
Change-Id: Ia8a5cd4fe2c6751c1e169a58ac88123770838234
Reviewed-on: https://chromium-review.googlesource.com/c/1334509
Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#610959}

Bug: 908542
Change-Id: Ibf9b8f2ac2c5bcdd14dcf65483d576fe61a3bf8d
TBR: tedchoc@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1351428Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610958}

We weren't generated enum definitions for nested enums in interfaces.

Change-Id: Ib303509dd991f0555ceb4e092ce41a4da91d3640
Reviewed-on: https://chromium-review.googlesource.com/c/1350440Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610957}

This adds a handful of metrics:
- Number of navigations that trigger a switch
- Number of rules are in the various sitelists
- Time it takes to make a decision, on navigation
- Time it takes to start the alternate browser
- Success rate for alternate browser launch
- Whether the UrlList policy contains a wildcard

Bug: 898667
Change-Id: Ibc3d3d40725dcb84c685a9e59e3b28cd79ce860e
Reviewed-on: https://chromium-review.googlesource.com/c/1333872
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610956}

Add a method to InstantService to check if a custom background
has been set. Clean up a few places that were checking the
pref directly.

Bug: 873699
Change-Id: I755c6d26cb5fc6cce1239fd796fbfc5e3fb45ce5
Reviewed-on: https://chromium-review.googlesource.com/c/1338091Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610955}

There were two issues:

1. The new language::GetApplicationLocale() function that was
introduced as part of M71 changes to variations service did not
match the previous behavior - it had an early return when the
locale pref didn't exist - which would be hit when the user didn't
explicitly set their language in Chrome. But that's not sufficient
since l10n_util::GetApplicationLocale() actually does logic beyond
what's provided to it via the pref. On Mac, it gets the language
from the system. The changes to components/language were sufficient
to fix things on Mac.

2. On non-Mac platforms, the call to l10n_util::GetApplicationLocale()
also had a dependency on ResourceBundle being initialized, so this part
did not work correctly either. IsLocaleAvailable() was returning false
when there was no ResourceBundle. There was also a TODO to make the
LocaleDataPakExists() API static - which then could be used without
ResourceBundle being initialized. This was mostly straight-forward
except for use of delegate_->GetPathForLocalePack(). This delegate
API was only overridden (outside of tests) by CastResourceDelegate.
Given cast doesn't use the code path in question (variations), the
code is changed to only use that delegate if the resource bundle has
been initialized.

Also adds a check that the locale determined after resource bundle
has been loaded matches what was used to initialize variations.

Bug: 908114
Change-Id: Ief6bf3e370bf2773187387c1fd12fc4517b31a69
Reviewed-on: https://chromium-review.googlesource.com/c/1349770
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610954}

We are restricted to use functor-like objects that are part of the root
classloader. This means that changing from Callable is not practical.
However the fact that Callable#call can throw a checked exception is
inconvenient for code that uses getOrCreatePeer, especially as it is not
expected that the peer creation callable will ever actually throw.

For this reason, it's best if getOrCreatePeer rethrows the checked
exception wrapped in an unchecked RuntimeException.

Bug: 908269
Change-Id: I726d1cc75f13cafa9f62169069a237cc9e129b4d
Reviewed-on: https://chromium-review.googlesource.com/c/1349974Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610953}

This simplifies the test and allows it to pass in single process mash
due to extra setup in the test fixture.

(Technically, it also passes in single process mash without this change,
but would cease to do so after AuraTestSuite stops creating an
InputDeviceClient, which will soon happen.)

Bug: 905430
Change-Id: Ib85c034c9e83d9c6fbcbcece130401e37621609e
Reviewed-on: https://chromium-review.googlesource.com/c/1343283
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610952}

This is a reland of 2a5578c2

Fix the build failure in
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/9034

Add ASH_EXPORT on AssistantQueryHistory because it is included in ash_unittests,
or else build with is_debug = true fails.

Original change's description:
> Support key up/down to move through query history.
>
> We follow the behavior of linux shell:
> (1) Whenever there is a new query, the iterator is reset to the new
>     query.
> (2) Prev of the iterator moves till the first query and stick there.
> (3) Next of the iterator can move beyond last query and get an empty
>     query.
>
>
> Bug: b:119504796
> Change-Id: Iee1247359df78b8e2189fa86c3bd1b8b6ebfe612
> Reviewed-on: https://chromium-review.googlesource.com/c/1334271
> Commit-Queue: Yilei Li <yileili@google.com>
> Reviewed-by: Tao Wu <wutao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#609888}

Bug: b:119504796
Change-Id: I445b022caef9e82272a07c3a8949e1decc4aaeff
Reviewed-on: https://chromium-review.googlesource.com/c/1345811Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Yilei Li <yileili@google.com>
Cr-Commit-Position: refs/heads/master@{#610951}

This reverts commit 6822d5b7.

Reason for revert: https://crbug.com/908551

Original change's description:
> Add 10.13 as an optional dimension for layout tests
> 
> This will allow them to try 10.13 first and fall back to 10.12 if there
> aren't any hosts available.
> 
> Bug: 853356
> Change-Id: I0fd82376ebb2c4e501a78360bbbc675c90ee7d34
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/1330693
> Commit-Queue: Brad Hall <bradhall@google.com>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#609743}

TBR=jbudorick@chromium.org,bradhall@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 853356
Change-Id: I2d620fd3bec6b43ceda004de3925154a24986d8e
Reviewed-on: https://chromium-review.googlesource.com/c/1351503Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610950}

See the bug description for why we add this.

Bug: 907158
Change-Id: Ia28c1b5162dcf1e11435a12efdc9c64a3992c86e
Reviewed-on: https://chromium-review.googlesource.com/c/1345011
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610949}

A small refactoring. After the cl, the touchpad/keyboard is only
enabled/disabled when needed.

Bug: None
Change-Id: I1d247f48f8e65cb5345153cfca78efd321ea0280
Reviewed-on: https://chromium-review.googlesource.com/c/1344146
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610948}

This reverts commit 900ffcbd.

Reason for revert: Roll introduced significant netstack regression (though things were already flaky before that).

Original change's description:
> Roll Fuchsia SDK from ea00f9dcafd5 to 469421287ef1
>
>
> The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
>
> If the roll is causing failures, please contact the current sheriff, who should
> be CC'd on the roll, and stop the roller if necessary.
>
>
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
> TBR=cr-fuchsia+bot@chromium.org
>
> Change-Id: Ifab9496a837c590c6ca525402d0c24eed4aa0f9c
> Reviewed-on: https://chromium-review.googlesource.com/c/1347081
> Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#610293}

Bug: 908125
Change-Id: I168b641b747a5f909ef8dd0296bffb9fe898a5a0
Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Reviewed-on: https://chromium-review.googlesource.com/c/1351454
Commit-Queue: Wez <wez@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610947}

I recently added a few exports to chrome_elf.dll and I forgot to
update the arm64 .def file.

Change-Id: I977f61cd330d0059a652c639fdeb0b5506c40320
Reviewed-on: https://chromium-review.googlesource.com/c/1348857
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610946}

This CL encapsulates code that are related with overtime checking into
Timer class. This helps make the code cleaner and safer.

Bug: 228585
Change-Id: Id2d018b90a6976e39504914dd3f354a276b5601d
Reviewed-on: https://chromium-review.googlesource.com/c/1349714
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610945}

Bug: 903424
Test: steps in bug
Change-Id: I4ed9116d663da6da3c413dfd59efe2b7f83ba9a2
Reviewed-on: https://chromium-review.googlesource.com/c/1336057
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610944}

After a TWA client app is uninstalled or has its data cleared we show a
dialog that leads to Chrome site settings for the corresponding origin.
When there are multiple origins associated with the app, we go instead
to the "All sites" settings screen, where only the relevant origins are
displayed.

This is an alternative for the notification. For now, both solutions
are kept.

Change-Id: I4f970f7820812d6be7a7efba5996aedd0832d399
Reviewed-on: https://chromium-review.googlesource.com/c/1338106
Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610943}

Bug: None
Change-Id: Ic2a6e5cddc397f03e4cad5b6e93132812cd27f3e
Reviewed-on: https://chromium-review.googlesource.com/c/1351493Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610942}

Replace "text-shadow" with "filter: drop-shadow()". This lets us remove
the manual title truncation and use "text-overflow: ellipsis" instead.

Also increase the title container height to 24px in order to allow for
larger font sizes.

Screencast: https://screencast.googleplex.com/cast/NDgyOTcwNjE2MzU4NTAyNHwyOTk3MzhjZi1iNw

Bug: 894000
Change-Id: Ibe46ea6ed269615fb6bf59044ccccce10fd91721
Reviewed-on: https://chromium-review.googlesource.com/c/1337431
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610941}

Bug: 907673
Change-Id: I5c355e2cba9398b919e6a14d6fb817332c43a0d2
Reviewed-on: https://chromium-review.googlesource.com/c/1351284Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610940}

We no longer use gyp, and this confuses people, see thread
"[chromium-dev] how to resolve this problems", the reply from Nov 24 2018.

Setting checkout_nacl to false in .gclient still stops running this hook.
OS=android in GYP_DEFINES used to skip this step too; this is no longer the
case.

Bug: none
Change-Id: Ic59c21150dff04580cf76c141a43713df58eb555
Reviewed-on: https://chromium-review.googlesource.com/c/1350200Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610939}

This reverts commit 27bd2d6f.

Reason for revert: Broke this bot:
https://logs.chromium.org/logs/chrome/bb/internal.client.clank/arm-builder/18748/+/recipes/steps/compile/0/stdout

Original change's description:
> Cronet: Simplify Android GN logic for srcjars by not using them
> 
> No need to zip up the generated source just to unzip it again :P
> 
> Bug: 908479
> Change-Id: Iac6982eb4b436a7e33c53b79f239fe2954fa4f11
> Reviewed-on: https://chromium-review.googlesource.com/c/1349871
> Commit-Queue: agrieve <agrieve@chromium.org>
> Reviewed-by: Paul Jensen <pauljensen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610889}

TBR=pauljensen@chromium.org,agrieve@chromium.org

Change-Id: I9daab0436aa1ff7605f427ab815adff711c0d59d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 908479
Reviewed-on: https://chromium-review.googlesource.com/c/1351575Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610938}

Changes Url to URL and adds an -IsURLNewTabPage helper.

Change-Id: If80a6e41d9b2d74ed5449550b49de1cb670bed07
Reviewed-on: https://chromium-review.googlesource.com/c/1350191Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610937}