GitLab

The behavior that is expected is the current behavior. Remove todo.

Bug: 848732
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ifc0412d8b0cca13e1b1342195608c7daecdbd46c
Reviewed-on: https://chromium-review.googlesource.com/1125733Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Elodie Banel <lod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572582}

The fuzzer found another pathological case of repeated ZTF regions that
causes the patch size check to be violated due to a large number of
headers. The solution should be to increase this upper bound or remove
it entirely. I've gone with the former but if it continues to cause
trouble it might be worth removing as it only finds pathological cases
so far.

Bug: 860070
Change-Id: I276b51bc909ad0da46d9954aee9c98e03dc1973e
Reviewed-on: https://chromium-review.googlesource.com/1126164Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572581}

Previously ConsentAuditor did get UserEventService even when the
separate consents datatype was used. In this CL, the UserEventService is
just not requested from ConsentAuditor factory at all in this case (on
all platforms). Also DCHECKs in ConsentAuditor are adjusted to check only
the correct dependency based on the feature.

Bug: 851438
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I756e595b826e084d1b2f9905d2827cae1160fedd
Reviewed-on: https://chromium-review.googlesource.com/1124333Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572580}

Makes your browser history cleaner by replacing the current query string with
Javascript rather than making a new request with the form. Updates the UI inline
rather than reloading the page.

Additionally fixed the select element so it renders properly on Mac.

Bug: 847599
Change-Id: I709cb71b184f271fdcfb7561cc56f9e1d29d059a
Reviewed-on: https://chromium-review.googlesource.com/1125284
Commit-Queue: Tiger Oakes <tigero@google.com>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572579}

As a consequence we limit Chrome component updates to unmetered network
connections. By doing so, we will be able to update large components in
the background without depleting the user’s cellular data plan.
Additionally, the BackgroundTaskScheduler integrates well with Android’s
awake state and, thus, we hope it makes component updates more reliable.

More details at go/bts-component-updates

This feature is gated behind flag #background-task-component-update.

Bug: 801229
Change-Id: I3fb3c9850c32575267fd28d224810576631e48dc
Reviewed-on: https://chromium-review.googlesource.com/1113777
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572578}

A left shift resulting in truncation is undefined behavior on signed
int types in C++. It is fine to left shift an unsigned type because
there is no issues with two's complement representation or sign bits.
To get around this we need to perform the shift on the uint type and
recast it to a signed int type.

Bug: 860067
Change-Id: Ibace5aceb17c4435d6d37d5e37a16fa781c7dd99
Reviewed-on: https://chromium-review.googlesource.com/1126169Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572577}

They are implemented behind the CSSLogical runtime flag.

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/48OwfwZrbvI/A1XZFGkzAwAJ

Spec: https://drafts.csswg.org/css-logical/#box

BUG=850004

TEST=external/wpt/css/css-logical/logical-box-border-shorthands.html
TEST=external/wpt/css/css-logical/logical-box-border-color.html
TEST=external/wpt/css/css-logical/logical-box-border-style.html
TEST=external/wpt/css/css-logical/logical-box-border-width.html
TEST=external/wpt/css/css-logical/logical-box-margin.html
TEST=external/wpt/css/css-logical/logical-box-padding.html

The tests still have some failures because sideways writing modes have
not been implemented yet (http://crbug.com/680331).

Change-Id: Ibe3d7f39e1ce17de465aa635388b3f8510ed82a3
Reviewed-on: https://chromium-review.googlesource.com/1122872Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com>
Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#572576}

Bug: 775132
Change-Id: I0cd43942e4cf1c8347332e3c22fae5555b490e4b
Reviewed-on: https://chromium-review.googlesource.com/1124936
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572575}

Moving chromevox's closure-library into third_party so it
can be shared with chromecast.

Bug: 73240963
Test: Local build
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Idec6775a8b9a82d301b75261bac3dfd82e5f350c
Reviewed-on: https://chromium-review.googlesource.com/1108553
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572574}

Replace an enum with an enum class, as preferred.

Change-Id: I657373e7a4f0d245a930341db7feff27a2f8fda5
Reviewed-on: https://chromium-review.googlesource.com/1118552Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Sharon Yang <yangsharon@google.com>
Cr-Commit-Position: refs/heads/master@{#572573}

Previously we would allow worklet to access and act on all of worklet inputs.
This is bad since it can leak information between different animation
worklet global scopes.

Summary of the fix:
- Introduce WorkletAnimationId which can uniquely identify both the worklet and animation.
- Give each worklet animation its own Id generated using its underlying worklet's scope.
- Plumb this new Id to cc.
- AnimationHost produces input state which is bucketed per scope.
- CompositorMutatorImpl only passes to each compositor animator the input.
  bucket that matches that compositor animator's scope Id.
- For additional safety added DCHECK to verify that each scope is receiving only its
  own input.

TEST: compositor_mutator_impl_test.cc
Bug: 857479

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib4b8f610ef661bdbf09c4c0252a2b9c4ba04db16
Reviewed-on: https://chromium-review.googlesource.com/1120436Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572572}

Bug: 830892
Change-Id: Ib5d41a5b1a70f4f26752d97096437f489d2fe239
Reviewed-on: https://chromium-review.googlesource.com/1126168Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Commit-Queue: Oliver Li <olivierli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572571}

This reverts commit e6aa52bf.

Reason for revert: recent patches fix a related problem, in
23919ce6. We haven't been able
to confirm the fix being effective for the flakes observed in
bots because they no longer repro locally, but it is definitely
related so let's reenable the tests and monitor flakes.

Original change's description:
> Reland "[iOS] Disabling flaky sync tests"
> 
> This reverts commit 661767b9.
> 
> Reason for revert: tests still flaky.
> 
> Original change's description:
> > Revert "[iOS] Disabling flaky sync tests"
> > 
> > This reverts commit fb745f66.
> > 
> > Reason for revert: underlying issue no longer reproduces on
> > other platforms after recent improvements, so optimistically
> > assuming it was also fixed for iOS.
> > 
> > Original change's description:
> > > [iOS] Disabling flaky sync tests
> > > 
> > > Disabling EarlGrey tests from SigninInteractionControllerTestCase:
> > >  + testSignInSwitchAccountsAndKeepDataSeparate
> > >  + testSignInSwitchAccountsAndImportData
> > >  + testSignInSwitchManagedAccount
> > > 
> > > Those tests seem to trigger an issue in the sync code when doing enable
> > > disable enable too fast.
> > > 
> > > Bug: 854446
> > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> > > Change-Id: I76d10d272297e91650dbe91ef7acee500eac6c75
> > > Reviewed-on: https://chromium-review.googlesource.com/1107881
> > > Reviewed-by: Justin Cohen <justincohen@chromium.org>
> > > Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#568843}
> > 
> > TBR=justincohen@chromium.org,jlebel@chromium.org
> > 
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> > 
> > Bug: 854446
> > Change-Id: Ic809289ce4662d099250668d6f23100e52de9587
> > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> > Reviewed-on: https://chromium-review.googlesource.com/1114719
> > Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> > Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#570374}
> 
> TBR=justincohen@chromium.org,jlebel@chromium.org,mastiz@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 854446
> Change-Id: I2a0a2e9d60988783fca93ef8313594d57b7ab906
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Reviewed-on: https://chromium-review.googlesource.com/1117578
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570888}

TBR=justincohen@chromium.org,jlebel@chromium.org,mastiz@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 854446
Change-Id: I5874890bed60c173c35e49fe86933a06bd214120
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1126260Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572570}

Change-Id: Ife219da64894fd0d0ff0d299261a498b6f5eba76
Reviewed-on: https://chromium-review.googlesource.com/1125068
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572569}

Change-Id: Ic86d4993e9557bbdee628fe37c9631185acde28b
Reviewed-on: https://chromium-review.googlesource.com/1125065
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572568}

Removal of unnecessary includes and narrowing down DEPS come next.

Bug: 783309
Change-Id: If413b3d2d64e5a9ad71d613c18fc94fa9fb4988e
Reviewed-on: https://chromium-review.googlesource.com/1125852Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572567}

When removing tabs with mouse button, we'd like to know
the next active tab so that we can tailor available_width_for_tabs_.
But as PrepareForCloseAt() is called before the next tab is decided,
we don't know that. So move this logic to RemoveTabAt() where we
know it.
 And move other logic in PrepareCloseTabAt() is moved to CloseTab(),
 which triggered PrepareForCloseAt() via TabStripController::CloseTab().
As TabStripController::CloseTab() was invoked only by
TabStrip::CloseTab(), it's okay to move them to TabStrip::CloseTab().

Bug: 856289
Change-Id: I5eb7036da4214e92a218f20e8c09891ab9a11955
Reviewed-on: https://chromium-review.googlesource.com/1119616
Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572566}

Done using the "Edit in Gerrit" option in codesearch

Change-Id: I3a04b97abfcd67fb5d4a3eaa93f289341cb22f23
Reviewed-on: https://chromium-review.googlesource.com/1126142
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572565}

This CL adds the consent API that allows the various browser services to
check whether the user has consented for personalized URL-keyed data
collection (data collection that is keyed by URL and by Google account id).
As defined in the PRD, this decision is based on the sync state:
* If the Unified consent feature is disabled, then we consider that the
user has granted consent for personalized URL-keyed data collection iff sync
history is enabled.
* If the Unified consent feature is enabled, then we consider that the
user has granted consent for personalized URL-keyed data collection iff sync
user events is enabled (aka event logger is enabled).

BUG: 823809
Change-Id: Idf619b96010064020f36efbd90d54b720b45deec
Reviewed-on: https://chromium-review.googlesource.com/1123827
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572564}

Using wpt-import in Chromium db30d751.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20769

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=markdittmer

No-Export: true
Change-Id: I5fbf971594c4bdf3e0c3801c84b156adf5508ea0
Reviewed-on: https://chromium-review.googlesource.com/1126019
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572563}

Change-Id: I9a3a58b3ee2207816ac0f2f96fa21e464d1da866
Reviewed-on: https://chromium-review.googlesource.com/1125066
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572562}

fast/canvas/color-space/canvas-colorManaged-convertToBlob-roundtrip.html
virtual/gpu/fast/canvas/color-space/canvas-colorManaged-convertToBlob-roundtrip.html

They flakily time out.

TBR=fserb
NOTRY=true

Bug: 851746
Change-Id: Ib32001de56c74350a016e124fb5fa7e8906b5b04
Reviewed-on: https://chromium-review.googlesource.com/1126202Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572561}

Avoids run-tripping TimeDelta -> double -> TimeDelta.

Bug: 856082
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If4a6a0626be6341770ef01d368fc8a1ddf00de31
Reviewed-on: https://chromium-review.googlesource.com/1126115Reviewed-by: Daniel Bratell <bratell@opera.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#572560}

Bug: 859978
Change-Id: Ida88834a11f6b6aec2558e419d23abeabff529b6
Reviewed-on: https://chromium-review.googlesource.com/1125034Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572559}

This allows, for example, benchmarks in tools/perf/contrib to use
subsets of the system health stories.

Change-Id: I102722c6c4414e3d3921b288debd2db6a265c04d
Reviewed-on: https://chromium-review.googlesource.com/1125843Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572558}

Change-Id: I1a8ef527472d65b5f24b7357fe9ac6b153879d03
Reviewed-on: https://chromium-review.googlesource.com/1124848
Commit-Queue: vitaliii <vitaliii@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572557}

Tbr: xunjieli@chromium.org
Change-Id: I8376950bc4120bc8ed3397743fa343d7c849562e
Reviewed-on: https://chromium-review.googlesource.com/1125924
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572556}

The process of stopping a datatype is asynchronous by nature, most
prominently in USS where we want to take special care about sync
metadata being cleared.

Prior to this patch, ModelTypeController could silently drop stop
events, which could lead to the DataTypeManager (effectively the UI)
think a datatype is stopped, while in reality it could remain
running. This is problematic in multiple ways, most importantly due
to the risk of leaking sync metadata or even data.

Instead, what we want is that calls to OnSyncStarting() always have a
corresponding StopSync(), and guarantee that OnSyncStarting() is not
called twice without a StopSync() call in between.

In order to do that, ModelTypeController now enters state STOPPING
if the Stop() cannot be immediately executed, because it's currently
STARTING. Once the start is finalized, stop is immediately issued and
the corresponding callback informed, which allows
ModelAssociationManager to continue its job.

Bug: 855375
Change-Id: I6e22940fcb56816c43181c34e04c4a6e53c70a21
Reviewed-on: https://chromium-review.googlesource.com/1122863
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572555}

We plan to remove this code in the next release, but for now we'll keep
it behind a "live switch" so that we may re-enable in the server if
necessary.

Bug: 859097
Change-Id: I6c86e92de4b79c1a622a559b30840b9442f76716
Reviewed-on: https://chromium-review.googlesource.com/1122636
Commit-Queue: Bruno Kim Medeiros Cesar <brunokim@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572554}

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib286e9a2bb2e3f4d06e0bc1ddb7ee3c5854f333f
Reviewed-on: https://chromium-review.googlesource.com/1125290Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572553}

This CL completes full functionality for the sync bridge for
autofill_profile model type. The CL only converts applicable
unit-tests from AutofillProfileSyncableServiceTest. Tests corresponding
to ProfileSyncServiceAutofillTest will come in a later CL.

Bug: 836718
Change-Id: I5cf596e117d74c85d2ac40a356b0beaab98e1a1f
Reviewed-on: https://chromium-review.googlesource.com/1100762Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572552}

Allows users to navigate the tree view using the keyboard. The navigation
pattern follows the aria guide:
https://www.w3.org/TR/wai-aria-practices-1.1/examples/treeview/treeview-2/treeview-2a.html

- Pressing enter/space will expand the tree node.
- Pressing down navigates to the below tree node, up navigates to the above one.
- Pressing right will open the tree node, or go to its first child.
- Pressing left will close the tree node, or go to its parent.
- Pressing home goes to the root node, end goes to the last node on screen.
- Pressing a printable character (A-z, $, etc) will go to the node that starts
  with that character.

https://notwoods.github.io/chrome-supersize-reports/monochrome-2018-06-28/

Bug: 847599
Change-Id: I421909090ffff8f99f7ea1e851c4417cb8b26b57
Reviewed-on: https://chromium-review.googlesource.com/1119119Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Tiger Oakes <tigero@google.com>
Cr-Commit-Position: refs/heads/master@{#572551}

To enable useful formatting of the delta updates for the users default
corpus and each team drive we move the data into a table. This table
will have a row for the default corpus and then a row for each team drive.

Bug: 849813
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I966917d845cd2fb239a53afe0b209a2832c6f582
Reviewed-on: https://chromium-review.googlesource.com/1124128Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572550}

Schedules an kIncrementalV8FollowupGC instead of an PreciseGC when the HeapIncrementalMarking runtime flag is enabled.

Bug: 757440
Change-Id: I1d05afcc69508592d1e5f411dea1a3afa950baca
Reviewed-on: https://chromium-review.googlesource.com/1095200
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572549}

TBR=treib@chromium.org

Bug: 860200
Change-Id: Id0a9b33a4dc185ab7834fbf0dbf478ae3d6e8d26
Reviewed-on: https://chromium-review.googlesource.com/1126101Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572548}

Exits the preedit state upon appending a suggestion.

Bug: 859011
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I65809145b1f846157b24e1cc0b74035f235f834f
Reviewed-on: https://chromium-review.googlesource.com/1120025
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572547}

This reverts commit 4e4521b8.

Reason for revert: This broke the code search builder.

Reverting since everyone in the US is OOO, so this wouldn't be fixed for at least two days.

Bug: 860239

Original change's description:
> Reland "Add luci-go tool to be fetched via CIPD"
> 
> This is a reland of 3bcc71d8
> 
> Original change's description:
> > Add luci-go tool to be fetched via CIPD
> > 
> > Do not remove the adhoc mechanism on GCS that predates CIPD yet, as the recipes
> > need to be updated.
> > 
> > Change analyze to not ignore changes to isolate.
> > 
> > R=tandrii@chromium.org
> > 
> > Bug: 851596
> > Change-Id: Ic068db83dea4c3a0f17b55181de523b16c9838a5
> > Reviewed-on: https://chromium-review.googlesource.com/1097623
> > Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> > Reviewed-by: John Budorick <jbudorick@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#569688}
> 
> Bug: 851596
> Change-Id: I27382d97370376dcca8110c9225c16dada182256
> Reviewed-on: https://chromium-review.googlesource.com/1125000
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#572435}

TBR=maruel@chromium.org,tandrii@chromium.org,ehmaldonado@chromium.org,jbudorick@chromium.org

Change-Id: Ia95f851c24fab175827fc2a7d5d1472713b909af
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 851596
Reviewed-on: https://chromium-review.googlesource.com/1125900Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572546}

After https://chromium.googlesource.com/catapult.git/+/484f9f764dc58973a0466e4bdf1bfd50c75165e2 fix to set the correct value of traffic settings (and makes each of them 1024X slower),
many 3g tests are timed out after 166s.

For now disabling all those tests. Future fix would probably replace these with
better traffic settings like REGULAR_4G or Wifi.


NOTRY=true
TBR=kouhei@chromium.org, ksakamoto@chromium.org

Bug: 859597
Change-Id: I311d598c5e7e83475a5558c5f53d4a9953559a9d
Reviewed-on: https://chromium-review.googlesource.com/1126079Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#572545}

Most service workers will need CacheStoragePtr in a performance
sensitive way. We discovered there is slowness using InterfaceProvider
to get the ptr on first use after worker startup.

Bug: 854905
Change-Id: Iefcd8910d1b8b6ba1cfcc4df79c213abde0f9e3a
Reviewed-on: https://chromium-review.googlesource.com/1124130
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572544}

Bug 751952 has been fixed a while ago, so I think we can remove the
failure expectation for the forwardDelete.html test.

Additionally, there are some comments in bug 698135 that indicate the
crash is not reproducible anymore, which was the reason why there
was a failure entry for the delete.html test.

This CL removes the related entries in the TestExpectations file and
provides a new expected file for the delete.html test. It keeps,
though, a Failure entry for Mac only in the case of the delete.html,
since there are clear interoperability issues with Mac for these use
cases.

BUG=698135

Change-Id: I973b84eb1ea19fa72ba4011001aa750b73e87b0c
Reviewed-on: https://chromium-review.googlesource.com/1124461
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572543}