GitLab

BUG=141517
TBR=sail@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10830231

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150697 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10824186

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150696 0039d316-1c4b-4281-b951-d872f2087c98

I missed one include and somehow checkdeps.py didn't complain :/

BUG=125846
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10837179

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150694 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125846
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10828223

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150691 0039d316-1c4b-4281-b951-d872f2087c98

In seccomp-bpf unittest, we now call setSandboxPolicy even if we have no kernel
support for seccomp-bpf.

BUG=141545
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10837178

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150690 0039d316-1c4b-4281-b951-d872f2087c98

The kEnded state was used to protect against the case where both renderers executed their ended callbacks at the same time, resulting in two tasks posted to the pipeline message loop but the first task would poll each renderer's HasEnded() method and execute the ended logic before the second task executed.

Review URL: https://chromiumcodereview.appspot.com/10834236

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150689 0039d316-1c4b-4281-b951-d872f2087c98

auth.json was previously used to store authentication tokens. Now host config
will be used to store them instead. This script will automatically upgrade
config files on systems that still have auth.json

BUG=120950

Review URL: https://chromiumcodereview.appspot.com/10830225

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150688 0039d316-1c4b-4281-b951-d872f2087c98

TBR=cjhopman@chromium.org
BUG=141539, 141293
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10827243

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150687 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125846
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10826219

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150686 0039d316-1c4b-4281-b951-d872f2087c98

pages (iframes etc) exist in Dispatcher::ClassifyJavaScriptContext.

BUG=139869

Review URL: https://chromiumcodereview.appspot.com/10827239

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150685 0039d316-1c4b-4281-b951-d872f2087c98

* Replace FilePathUpdateCallback with FileMoveCallback, and move this typedef to gdata_files.h
* GDataDirectoryService::AddEntryToDirectory has been renamed to MoveEntryToDirectory, and now takes FileMoveCallback, and calls RemoveChild on the parent, as TakeEntry used to do. Also add a ui thread DCHECK and fix tests.
* Get rid of GDataDirectory::TakeEntry, replacing all invocations with GDataDirectoryService::MoveEntryToDirectory. 
* Introduce callbacks OnMoveEntryToDirectoryWithFileMoveCallback, and OnMoveEntryToDirectoryWithFileOperationCallback to call OnDirectoryChanged and run callbacks.
* Replace GDataFileSystem callbacks OnRenameResourceCompleted and OnRemoveEntryFromDirectoryCompleted with RenameFileOnFilesystem and RemoveEntryFromDirectoryOnFilesystem.
* Get rid of GDataFilesystem::AddEntryToDirectoryOnFilesystem.
* Make RemoveChildren, RemoveChildFiles, RemoveChildDirectories private.
* FromDocumentEntry should take parent NULL, as should GDataDirectory/GDataFile ctors. This will be more comprehensively fixed in a future patch. The fixes in this patch are necessary for unit tests.
* Replace FOR_EACH_OBSERVER(Observers OnDirectoryChanged) with OnDirectoryChanged, for brevity.
* Add gdata::test_util::CopyErrorCodeFromFileMoveCallback for gdata_files_unittest.

BUG=137725
TEST=unit tests, manual test moving files in the same directory and between directories.
Review URL: https://chromiumcodereview.appspot.com/10827211

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150684 0039d316-1c4b-4281-b951-d872f2087c98

Lack of XPS system on XP caused problems getting printer capabilities.
Use default settings for print preview in this case.

BUG=140044
TEST=On Windows XP (vanila install, no extras) go to a webpage and press Ctrl-P to bring up print preview. It should work.

Review URL: https://chromiumcodereview.appspot.com/10825256

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150683 0039d316-1c4b-4281-b951-d872f2087c98

We were only creating the compositing surface on XP, but it should be created in other circumstances where we aren't using the image transport surface.

BUG=140239
TBR=apatrick@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10830203

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150682 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140306
Tested: Added new browser tests!

Review URL: https://chromiumcodereview.appspot.com/10830072

TBR=fsamuel@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10832219

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150681 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141207

Review URL: https://chromiumcodereview.appspot.com/10832207

TBR=fsamuel@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10836169

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150679 0039d316-1c4b-4281-b951-d872f2087c98

Now that http://trac.webkit.org/changeset/124954 has landed, let's tell WebKit
that this plugin supports keyboard focus.

BUG=120263

Review URL: https://chromiumcodereview.appspot.com/10831215

TBR=fsamuel@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10831229

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150677 0039d316-1c4b-4281-b951-d872f2087c98

BUG=130377
TEST=chrome/ppapi/tests/test_image_data.cc
Review URL: https://chromiumcodereview.appspot.com/10823211

----
Failing on mac 10.6 bots:
http://build.chromium.org/p/chromium/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/25635


TBR=nfullagar@google.com
Review URL: https://chromiumcodereview.appspot.com/10832218

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150672 0039d316-1c4b-4281-b951-d872f2087c98

TBR=cpm@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10823248

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150671 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125846
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10823245

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150670 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137907


Review URL: https://chromiumcodereview.appspot.com/10824212

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150669 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141013
TEST=Existing test


Review URL: https://chromiumcodereview.appspot.com/10836159

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150668 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10495008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150667 0039d316-1c4b-4281-b951-d872f2087c98

Now that http://trac.webkit.org/changeset/124954 has landed, let's tell WebKit
that this plugin supports keyboard focus.

BUG=120263

Review URL: https://chromiumcodereview.appspot.com/10831215

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150666 0039d316-1c4b-4281-b951-d872f2087c98

In particular, add unit tests that would have caught bug 139424.

Dep-inject InvalidationClient into ChromeInvalidationClient.

Use the function name 'UpdateRegisteredIds' consistently.

Replace some mocks with fakes.

BUG=139424


Review URL: https://chromiumcodereview.appspot.com/10827133

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150665 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141207

Review URL: https://chromiumcodereview.appspot.com/10832207

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150664 0039d316-1c4b-4281-b951-d872f2087c98

91 is a keycode sent when Search key is pressed.
The issue these keycodes are added for (http://crosbug.com/14236) is no longer reproducible, so they are safely removed.

BUG=141211
TEST=Manual


Review URL: https://chromiumcodereview.appspot.com/10827234

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150663 0039d316-1c4b-4281-b951-d872f2087c98

Since it does not require any IO tasks, it should not involved posting a task. 

BUG=


Review URL: https://chromiumcodereview.appspot.com/10854019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150662 0039d316-1c4b-4281-b951-d872f2087c98

 I probably typed this garbage by accident before I land it.

TBR=atwilson@chromium.org
BUG=141255
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10854059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150661 0039d316-1c4b-4281-b951-d872f2087c98

AudioRenderSink::RenderCallback.

The first step towards unifying our pipeline on float.  Adds a
new AudioBus class for managing audio channel data.  Includes
helper methods for shared memory transfers and common tasks
such as zeroing the audio data.  Inspired by WebKit's AudioBus.

BUG=114700
TEST=Unit tests.


Review URL: https://chromiumcodereview.appspot.com/10829183

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150660 0039d316-1c4b-4281-b951-d872f2087c98

Fix for number of ChromeOS browser_tests that were failing in BVTs. Added extra logs for tracing test web server failures in browser_tests.

TEST=make sure ChromeOS BVT browser_tests pass
BUG=131915

Review URL: https://chromiumcodereview.appspot.com/10831204

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150659 0039d316-1c4b-4281-b951-d872f2087c98

Metrics collection for KioskMode has been replaced by data pulled from Analytics. Remove the current metrics reporting since it's broken and bloat.

Reviews requested:
satorux@ - Main reivew + OWNER's review for ChromeOS
sky@ - OWNER's review for everything else :)

R=satorux@chromium.org,sky@chromium.org
BUG=126878
TEST=Kiosk mode works as before.


Review URL: https://chromiumcodereview.appspot.com/10825257

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150657 0039d316-1c4b-4281-b951-d872f2087c98

When closing an incongito window, it is possible that the previously focused profile is already
destroyed. Since profile_->IsSameProfile(previous_focused_profile) is always true in this case, we
can just skip the check and dispatch the events against profile_.

BUG=139237
TEST=open an incognito window and close it and hope it doesn't crash.

Review URL: https://chromiumcodereview.appspot.com/10837170

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150656 0039d316-1c4b-4281-b951-d872f2087c98

BUG=126082
Review URL: https://chromiumcodereview.appspot.com/10834238

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150655 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140306
Tested: Added new browser tests!

Review URL: https://chromiumcodereview.appspot.com/10830072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150654 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150652 0039d316-1c4b-4281-b951-d872f2087c98

This is particularly needed because one of the WebDriver users wants to test
with shiftshader, which is disabled because of the skip-gpu-data-loading flag.
This change makes logical sense too, since ideally ProxyLauncher should
be limited to understanding how to launch and connect to Chrome.
BUG=chromedriver:125
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10825109

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150651 0039d316-1c4b-4281-b951-d872f2087c98

r1463: ninja: make cross-compilation use $CC/$CXX for the target compiler

Took over from http://codereview.chromium.org/9649016/

BUG=140900
TEST=set CC/CXX to cross-compiler, set GYP_CROSSCOMPILE to 1, run gyp, ninja chrome.

Review URL: https://chromiumcodereview.appspot.com/10836135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150650 0039d316-1c4b-4281-b951-d872f2087c98

23 is the atomic number of vanadium (next up Chromium...)
According to the birthday paradox, in a group of 23 (or more) randomly chosen people, the probability is more than 50% that some pair of them will have the same birthday.
23 is the width of the Arecibo message, sent to space in search for extraterrestrial intelligence.
Normal human reproductive cells have 23 chromosomes.
23 is the TCP/IP port used for telnet
Michael Jordan wore the number 23 when he played on the Chicago Bulls (and Washington Wizards)
The 1980s TV series Max Headroom was set at Network 23.
4, 8, 15, 16, 23*, and 42
The Number 23 is a 2007 film starring Jim Carrey.
The 23 enigma refers to the belief that most incidents and events are directly connected to the number 23.
http://www.youtube.com/watch?v=kiTScUKMZUw

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150649 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140040
TEST=Running chrome with --force-device-scale-factor=2 still loads 2x resources.


Review URL: https://chromiumcodereview.appspot.com/10837142

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150648 0039d316-1c4b-4281-b951-d872f2087c98

* Lets -Wunused-private-field find more stuff
* Fixes an ASan problem on precise
* Improves the plugin's handling of inner classes (off by default,
can be enabled with |-Xclang -plugin-arg-find-bad-constructs
-Xclang check-inner-classes|)
* Makes addr2line much faster on linux
* Fix for crash we saw on the valgrind bots after the last roll attempt
* The plugin now ignores cc/ by default

BUG=139346,139912
TBR=hans

Review URL: https://chromiumcodereview.appspot.com/10831219

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150647 0039d316-1c4b-4281-b951-d872f2087c98