- 28 Jun, 2018 40 commits
-
-
Xianzhu Wang authored
The cache generation mechanism was needed 1 to avoid cost of hashmap indexing of all remaining cached display items when searching for the matched cached display item of a newly appearing display item without any invalidation (e.g. when a scrolling contents layer is painted with a new interest rect); 2 to ensure correct caching of one display item client painting on multiple paint controllers. Now for 1, we have subsequence caching which can reduce the chance of full cached display item list indexing. For 2, we separate some code from PaintController::CommitNewDisplayItems() into FinishCycle() so that multiple PaintControllers can update the caching status of clients synchronously, so we can remove the cache generation mechanism for simplicity. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I08e3a1f8883584b3a30c4dfa498489df64be012c Reviewed-on: https://chromium-review.googlesource.com/1117712Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571251}
-
Martin Kreichgauer authored
The app at webauthndemo.appspot.com interprets the spec very literally and fails assertion operations if the counter is not strictly monotonic. Use a timestamp to work around that for now. Bug: 837392 Change-Id: I50ed0bc1b6f9822764b920e051970fb8430914b8 Reviewed-on: https://chromium-review.googlesource.com/1112798 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#571250}
-
James Cook authored
This makes spoken feedback work in the shortcut_viewer app. * AXHostService in the browser receives AX node trees and events from remote apps and forwards them to the ChromeVox extension * AXHostServiceClient sends the initial tree from the remote app when ChromeVox is enabled. It sends updates when MusViewsDelegate sees views events (similar to ChromeViewsDelegate in browser). * The node tree comes from the widget's client area because oop-ash creates a widget in both the window manager (for its frame) and in the client app (in case it wants to draw a frame). For now we assume the window manager owns the frame. TODOs: * Focus support * Multiple widgets in client app * Multiple client apps TBR=sky@chromium.org NOPRESUBMIT=true Bug: 851578 Change-Id: I92a9fb7dbead9b329b0e4ea12d238428a63b4212 Reviewed-on: https://chromium-review.googlesource.com/1099572 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#571249}
-
Christopher Cameron authored
Not all of RenderWidgetHostNSViewClient can be mojo-ified (e.g, the method that returns a raw pointer to the accessibility class), and some may not be a good idea to mojo-ify (event conversion ... which may not be as big a deal as I make it out to be). To handle this, create a RenderWidgetHostNSViewLocalClient interface, and two implementations: RenderWidgetHostViewMac, and ForwardingLocalClient (which stubs out functionality that isn't present in the app shim, and converts events to pass over mojo). Also remove the "OnNSView" prefix from all methods, because it was excessively verbose. Remove the stubbed-out NoopClient, because it can now be replaced with an un-bound mojo instance. Bug: 821651 Change-Id: I3c7ab0e910e448292f188001ef5a786d661afb51 Reviewed-on: https://chromium-review.googlesource.com/1116354 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#571248}
-
Stefan Zager authored
"Frame content" coordinates are no longer a thing. BUG=823365 R=skobes@chromium.org,chrishtr@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6e82c57a8bc9008402407639d4e2e4a60161e337 Reviewed-on: https://chromium-review.googlesource.com/1117889 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#571247}
-
Greg Thompson authored
I realized that there's some more nuance in the way DELETE_ON_CLOSE and the DeleteFile disposition work. BUG=none NOTRY=true Change-Id: Ie47f7da5ad9a84eac798841023aeee84a2da76d7 Reviewed-on: https://chromium-review.googlesource.com/1118232 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#571246}
-
Stephen Martinis authored
This reverts commit 9eeaba4e. Reason for revert: Will re-land with fix Original change's description: > Revert "gtest perf tests: Output well formed test results json" > > This reverts commit 71b865f4. > > Reason for revert: break many perf tests (see https://ci.chromium.org/buildbot/chromium.perf/linux-perf/307) > > Original change's description: > > gtest perf tests: Output well formed test results json > > > > This CL changes the run_gtest_perf_test.py script to output well formed > > test results json. > > > > Bug: 855234 > > Change-Id: Ia5ce6e258865e34a2aa37635c014cd54efa62796 > > Reviewed-on: https://chromium-review.googlesource.com/1112635 > > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#570943} > > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org > > Change-Id: Ia0aaff923014438005ebc0a8677c3bbbebb808ac > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 855234 > Reviewed-on: https://chromium-review.googlesource.com/1118238 > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Commit-Queue: Ned Nguyen <nednguyen@google.com> > Cr-Commit-Position: refs/heads/master@{#571083} TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org Change-Id: Idb255b1fafb7f254fd44d6554f93ff27608279f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 855234 Reviewed-on: https://chromium-review.googlesource.com/1118789 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#571245}
-
Jeffrey Kardatzke authored
This is to enable web development work where a webserver is running in a Crostini VM/container and then connected to from Chrome. penguin.linux.test will resolve to the default container's IP address and <container>.<vm>.linux.test will resolve to any container/VM that is running. Bug=849134 Test=Verified with service worker example Change-Id: I23d170e29747d0d1e660171f635b1ded9348ac32 Reviewed-on: https://chromium-review.googlesource.com/1118919Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#571244}
-
Brian Osman authored
This makes these tests fail, so mark them as such in TestExpectations Bug: chromium:857576 Change-Id: Id7e112322585c786bb4b66d0875fcd05b9c75763 Reviewed-on: https://chromium-review.googlesource.com/1118853 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#571243}
-
Antonio Gomes authored
This is a reland of ccd4ec08 Difference from the original CL is minor, but indeed the cause of failures on debug bots: - headers.AddHeadersFromString(request.all_headers); + for (auto it : request.headers) + headers.SetHeader(it.first, it.second); Basically, network::ResourceRequest::all_headers can contain lines that do not match the "key: value" syntax expected by net::HttpRequestHeaders. Hence, we iterate over network::ResourceRequest::headers instead. TBR=emaxx@chromium.org,sorin@chromium.org,rdevlin.cronin@chromium.org,droger@chromium.org,mmenke@chromium.org Original change's description: > Migrate client_update::SendProtocolRequest to SimpleURLLoader > > URLFetcher et al will stop working in the browser process with advent > of Network Service, and SimpleURLLoader is the replacement API > for most clients. CL migrates SendProtocolRequest to the new API. > > Major remarks: > > * URLRequestPostInterceptor is replaced by URLLoaderPostInterceptor although the public APIs > of the former is kept (are almost the same) in the later. This allows the extensive set of unit > tests to remain untouched. The replacement is needed because URLRequestPostInterceptor used > to intercept requests instantiated by URLFetcher, precisely the class we are moving away to use. > > * URLLoaderPostInterceptor operates in two modes: it supports working both with TestURLLoaderFactory > and EmbeddedTestServer. Two constructors are offered that control the 'mode' it operates on. > This is needed because of the nature of the tests: some tests manipulate the TestConfigurator > directly, hence the needed SharedURLLoaderFactory instance can be acquired directly from it, > eg PingManagerTest, UpdateCheckerTest and RequestSenderTest. > Some other tests, trigger the respective SimpleURLLoader machinery from upper layers, and then > have no access to TestConfigurator instances. In such cases, URLLoaderPostInterceptor operates > using EmbeddedTestServer in order to intercept URL loads. > > Note that this CL migrates components/update_client/utils.cc|h to SimpleURLLoader, but there > some other classes on the same directory that still use URLFetcher (eg UrlFetcherDownloader), > so we simply can not *yet* remove all the references to URLFetcher and URLRequestContextGetter. > It will be done in a follow up CL. > > BUG=773295,844973 > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I3d8be368818ba77b559907c0217995f8c6a95b04 > Reviewed-on: https://chromium-review.googlesource.com/1097337 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571097} Bug: 773295, 844973 Change-Id: I3a8252aecf687d08e41c0d09cb9bd245fe3f712b Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1118646Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#571242}
-
Avi Drissman authored
Use a base::NoDestructor rather than a LazyInstance. Connect the display link callback via display id rather than DisplayLinkMac to ensure that no stale pointer issues can cause crashes. In addition, "<= 0" was used on uints. Fixed. This reverts the speculative fix that was committed in 119ecfdd as it did not target the actual issue. BUG=564780 TEST=crashes go bye? Change-Id: I779bd50fb3ffd1a96c5e8bd1e89ac18b19b7bef8 Reviewed-on: https://chromium-review.googlesource.com/1117615 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#571241}
-
tzik authored
PassingTraits is a injection point to control base::Callback behavior around an internal value transfer. However as it doesn't have a user outside of the file, and is probably not worth exposing. This CL replaces the injection point with single std::conditional for simpler code. Change-Id: I0cc10ad148fbd9f041eb9a5a3097c5a8ef77b473 Reviewed-on: https://chromium-review.googlesource.com/1118061 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#571240}
-
Xiaocheng Hu authored
Currently, in both legacy and NG NodeAtPoint() variants, parameter |accumulated_offset| stands for the offset of the parent context or fragment in the paint layer, instead of the own offset of the object under hit test. This makes the parameter unintuitive, and also makes offset conversion complicated when crossing legacy/NG boundaries. This patch changes NG to use the own offset of the fragment under hit test to simplify offset calculation. This also eliminates the duplicated offset accumulation in both LayoutNGMixin and NGBoxFragmentPainter. Bug: 855279 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2256e95a7b948e107b10daf2c25206b2d32b090e Reviewed-on: https://chromium-review.googlesource.com/1117878Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#571239}
-
Stefan Zager authored
LocalFrameView no longer needs scrollbar modes. Also, move the autosize scrollbar mode logic in LayoutView. LayoutView::CalculateScrollbarModes is now the source of truth. BUG=823365 R=pdr@chromium.org,skobes@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie7bee820d189403c50d0b18d76bc14854e2998b8 Reviewed-on: https://chromium-review.googlesource.com/1117772 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#571238}
-
Michael Spang authored
This reverts commit 18e426c1. Reason for revert: ozone_demo --ozone-platform=headless crashes immediately and for multiple reasons Original change's description: > [ozone/headless] Add initial display fetch support for headless > > Each Ozone platform creates its own NativeDisplayDelegate to get > display information. Otherwise, 'display::FakeDisplayDelegate' is > used for NativeDisplayDelegate. > > Per bug, ozone headless is crashing because it uses > FakeDisplayDelegate and it doesn't invoke OnConfigurationChanged > before initialization completes so ScreenBase can't add the display. > Once NativeDisplayDelegate is initialized, DesktopScreenOzone > requires DisplayMode from DisplaySnapshot but FakeDisplayDelegate has > FakeDisplaySnapshot and it doesn't have DisplayMode. > > This CL creates HeadlessNativeDisplayDelegate which owns > DisplaySnapshot and DisplayMode for ozone/headless. > DesktopScreenOzone keeps it in delegate_ and communicates with it. > > To try this, compile with the following gn args > use_ozone = true > ozone_platform_headless = true > > TEST=./out/Debug/chrome --ozone-platform=headless > > Bug: 851375 > Change-Id: Ib0d6dc66e6d9c538db38e1c6f04c35b149f9b6e6 > Reviewed-on: https://chromium-review.googlesource.com/1094851 > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> > Cr-Commit-Position: refs/heads/master@{#567929} TBR=rjkroege@chromium.org,jkim@igalia.com Bug: 851375 Change-Id: Ib5b05d46652cb4e413f8d79bfe4d8fec2737b88a Reviewed-on: https://chromium-review.googlesource.com/1118787Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#571237}
-
Peter Boström authored
Fixes bug (and DCHECK) when the leading ToolbarButton (back) switches between maximized and and unmaximized windows. Maximizing the window adds leading margin to the view which changes its bounds and size. ToolbarButton overrides OnBoundsChanged but did not call the parent OnBoundsChanged. Therefore InkDropHostView did not resize the inkdrop and mask. This caused clipping in release and DCHECKs in debug due to layer/mask size mismatches. Bug: chromium:856515, chromium:857411 Change-Id: I6348b2cdef11a95e5800d337d60f5060b93c4d99 Reviewed-on: https://chromium-review.googlesource.com/1118972 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#571236}
-
Andrey Lushnikov authored
This patch introduces a new DOM.getContentQuads method. This method returns content quads for the given node. In case of inline elements this method might return multiple quads. BUG=857308 R=dgozman Change-Id: I347d399fd7592295e5ddc8ea1e93b16090423499 Reviewed-on: https://chromium-review.googlesource.com/1117920Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#571235}
-
Adithya Srinivasan authored
Using double to represent timestamps is error prone. Change-Id: Ia9d1f0ab110801d4b19c576777449a3b5fe1ebb2 Reviewed-on: https://chromium-review.googlesource.com/1117760 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#571234}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fcb04d853ec4..8849c9571022 git log fcb04d853ec4..8849c9571022 --date=short --no-merges --format='%ad %ae %s' 2018-06-28 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader b41a9d6f0bbc..539468cef869 (1 commits) 2018-06-28 enne@chromium.org Return nullptr from readFlattenable when invalid 2018-06-28 mtklein@chromium.org add --sync to adb push in bin/droid 2018-06-28 mtklein@google.com unify term/crash handlers, include SIGINT 2018-06-28 timliang@google.com added TextureRenderTarget to Metal gpu backend 2018-06-28 jvanverth@google.com Reland "Improve precision and speed of oval rendering." 2018-06-28 mtklein@chromium.org cut SkMaskBlurFilter code size by about half Created with: gclient setdep -r src/third_party/skia@8849c9571022 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium: 854947 TBR=jcgregorio@chromium.org Change-Id: I0a49c9a63772d399280b1766fea5045ebba98d31 Reviewed-on: https://chromium-review.googlesource.com/1118805Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571233}
-
David Reveman authored
Transient child should not be activatable unless it has an application id. This allows aura shell clients to create popup style windows without using the xdg popup API that requires the ability to dismiss a surface. Bug: 857465 Test: exo_unittest --gtest_filter=ShellSurface.SetParent Change-Id: I628e51af113ab7e3cd73925b9af7e339ef1442cd Reviewed-on: https://chromium-review.googlesource.com/1118855 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#571232}
-
Sky Malice authored
Specifics: +559,559 bytes normalized apk size +3 zip entries file count +16,644 bytes main lib size +376,028 bytes main dex size InstallSize: +183,531 bytes APK size +1,702,684.12 bytes Estimated installed size InstallBreakdown (+1,702,248.12 bytes): +1,571 bytes Non-compiled Android resources size +16,644 bytes Native code size +170 bytes Package metadata size +1,678,855.12 bytes Java code size +5,008 bytes Compiled Android resources size Dex: +1,856 entries fields +2,589 entries methods +638 entries types +1,291 entries strings Change-Id: I8985160524863216d52560bf66991669b1fcd2f5 Reviewed-on: https://chromium-review.googlesource.com/1118712Reviewed-by:Filip Gorski <fgorski@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#571231}
-
Min Qin authored
DownloadInfobarController depends on profile, which may not be available on startup. Lazily create this when needed. BUG=842245 Change-Id: Ieecc314dc6e3cf7d12b8209fa38f4c34385f5204 Reviewed-on: https://chromium-review.googlesource.com/1115347 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571230}
-
Yi Gu authored
This reverts commit cfb0eff9. Reason for revert: failing https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac/43110 due to adding a static const string16 in the anoymous namespace Original change's description: > [omnibox] Vertically center single line entity suggestions > > Omnibox entity suggestions with two lines of text will layout > as before, but now if the second line description is absent, > the primary content text line will be vertically centered. > > Bug: 856703 > Change-Id: Ie672ccece28be79d18bf6f7f07f9937af434178d > Reviewed-on: https://chromium-review.googlesource.com/1115760 > Commit-Queue: Orin Jaworski <orinj@chromium.org> > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571174} TBR=jdonnelly@chromium.org,orinj@chromium.org Change-Id: I2f7b31736edc2e66240717749961092875002e2a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 856703 Reviewed-on: https://chromium-review.googlesource.com/1118788Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571229}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3511a8352adf..37c0f8c6bbd2 git log 3511a8352adf..37c0f8c6bbd2 --date=short --no-merges --format='%ad %ae %s' 2018-06-28 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@37c0f8c6bbd2 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I0a54420ab21de18939d063cc8d88693d50f149cf Reviewed-on: https://chromium-review.googlesource.com/1118806Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571228}
-
Matt Reynolds authored
Adds --gamepad-polling-interval [INTERVAL], where INTERVAL is the delay in milliseconds between successive polls of gamepad button and axis inputs. Decreasing the interval improves latency, but may cause a loss in performance due to more CPU time spent in the input polling thread. The interval must be between 4 and 16 ms, inclusive. If no interval is specified the max value (16ms) is used. Also adds chrome://flags#gamepad-polling-rate to allow selection of the target polling rate from the flags page. BUG=855188 Change-Id: I9ec58c7320eff952c46bce263da8526459ad8a9b Reviewed-on: https://chromium-review.googlesource.com/1110742 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#571227}
-
Chris Blume authored
Currently, users of Vulkan need to get the global function pointer class. And calls into those functions look like: vulkan_function_pointers->vkCreateDevice(); Our OpenGL code hides that behind macros. This patch adds macros to mimic the OpenGL code in Chrome. Now that looks like: vkCreateDevice(); BUG=856360,848101 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If3aff1719b366748b9236a9e4c9e7ec69260be18 Reviewed-on: https://chromium-review.googlesource.com/1116195 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#571226}
-
Yi Gu authored
Add virtual/service-worker-servicification/external/wpt/service-workers/service-worker/about-blank-replacement.https.html to TestExpectation TBR=carlosk@chromium.org NOTRY=true Bug: 856330 Change-Id: Id82dc29562058664dc85265c3ddd1ed9559d988d Reviewed-on: https://chromium-review.googlesource.com/1119085Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571225}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ac9c7e7edefa..7ddf0ed7f771 git log ac9c7e7edefa..7ddf0ed7f771 --date=short --no-merges --format='%ad %ae %s' 2018-06-28 benjhayden@chromium.org Add 90th percentile to results.html. 2018-06-28 dtu@chromium.org [pinpoint] Fix and test JobState.Explore and Compare. Created with: gclient setdep -r src/third_party/catapult@7ddf0ed7f771 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I1917506f3df7ef62e8d1c331c3d7d9d22a5681f2 Reviewed-on: https://chromium-review.googlesource.com/1118758Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571224}
-
liberato@chromium.org authored
Previously, VDAVideoDecoder, MCVD and D3D11VideoDecoder used the validating GLES decoder's TextureRef (possibly indirectly, via GLES2DecoderHelper and CommandBufferHelper) to retain textures. This CL moves them all over to use AbstractTexture, in preparation for supporting the passthrough GLES decoder. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I13985223443b8e0897c1508f052d0f35d77746fe Reviewed-on: https://chromium-review.googlesource.com/1091649 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#571223}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9ca72e1a. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20301 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=markdittmer No-Export: true Change-Id: Iafc599cf98c6a79cddd0b14d42c74e127d5a1912 Reviewed-on: https://chromium-review.googlesource.com/1118623 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#571222}
-
Emil A Eklund authored
Optimize performance of ShapeResult offset and x-position computation by introducing a new data structure mapping from character index to advance from the logical start of the shape result. This allow for constant time lookup from offset to x-position and O(log n) mapping from x-position to offset using binary search. This speeds up blink_perf.layout::line-layout test by a factor of three. Currently only enabled for left to right text, right to left will follow in a later CL once the approach has been proven. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I38ebd605e9fbe74fc9d383776defce987cb34d0a Reviewed-on: https://chromium-review.googlesource.com/1092013 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#571221}
-
dpapad authored
Users of cr-slider rely on a bubbling immediate-value-changed event to be fired. In Polymer 2 this event does not bubble by default, and needs to be re-fired. As a result of this change CrSettingsSliderTest.All passes with Polymer 2. Bug: 738611 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ifc5bf914fe57c61a7ad7360e9ee0c6a2fb859daf Reviewed-on: https://chromium-review.googlesource.com/1117626 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#571220}
-
Ryan Sturm authored
This keyed service owns a blacklist and the blacklist is used in the triggering pipeline to prevent over triggering of the feature. Bug: 797981 Change-Id: Ib6afd870b48032363af9235184d1df24c51a195e Reviewed-on: https://chromium-review.googlesource.com/1114331 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#571219}
-
John Abd-El-Malek authored
Flash and other plugins with universal access can make cross-origin requests that bypass CORB. NaCl and other plugins without universal access make all cross-origin requests with CORS, and they should remain subject to CORB. TBR=nasko Bug: 853239 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I1dbae19fbced1b46eaa889708bda926da994903b Reviewed-on: https://chromium-review.googlesource.com/1117711 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#571218}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/01b356851646..f1ba1dcd5882 git log 01b356851646..f1ba1dcd5882 --date=short --no-merges --format='%ad %ae %s' 2018-06-28 dproy@google.com Add tslint presubmit Created with: gclient setdep -r src/third_party/perfetto@f1ba1dcd5882 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I8d3f0f69cf57dcba9dbec83a1c0ac490f07b168b Reviewed-on: https://chromium-review.googlesource.com/1118807 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571217}
-
Ryan Hamilton authored
Change-Id: Ie4175e128ae7ad4118b5ace086211abf69dca70a Reviewed-on: https://chromium-review.googlesource.com/1118283Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#571216}
-
Yi Gu authored
Update test expectation for http/tests/devtools/sources/debugger-breakpoints/event-listener-breakpoints-webaudio.js TBR=carlosk NOTRY=true Bug: 857477 Change-Id: I80a2157ff1b4bd94789497cd38cb436549a24932 Reviewed-on: https://chromium-review.googlesource.com/1118852Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571215}
-
Scott Chen authored
Bug: 832177 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I552d8ba9107b82aca3a24d24299181b788fc54d8 Reviewed-on: https://chromium-review.googlesource.com/1108918 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#571214}
-
Evan Stade authored
Go through CursorFactoryOzone to load the PlatformCursor (which confusingly could be CursorData, but for now is X11CursorOzone). Also set fields on the cross-platform Cursor type so that code which relies on it such as CursorWindowController::UpdateCursorImage will work. That code path can be exercised with --ash-enable-cursor-motion-blur although there is currently no use of custom cursors with ws2. Bug: 837705 Change-Id: I9f725c5a5350e28cf8bded6b53bf48759cb644f8 Reviewed-on: https://chromium-review.googlesource.com/1105562 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#571213}
-
Emily Hanley authored
This change also update the oauth token to generating ne per run to one per benchmark Bug:713357,854162 Change-Id: If06e71c53fe8083f82307584a6e92104e33b2f65 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:obbs_fyi Change-Id: If06e71c53fe8083f82307584a6e92104e33b2f65 Reviewed-on: https://chromium-review.googlesource.com/1114690 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#571212}
-