GitLab

All of the subclasses do the same thing for the polling part, so share
it. Not all of them use DispatchEventToCallback, so remove that part.

NOTRY=true

Review URL: https://codereview.chromium.org/561243002

Cr-Commit-Position: refs/heads/master@{#294446}

BUG=314889

Review URL: https://codereview.chromium.org/537893003

Cr-Commit-Position: refs/heads/master@{#294445}

https://skia.googlesource.com/skia/+log/33a30503d76fdd989358cedd78445ba96bb809dd..790ffe3feb90370318f42b28eb9c6af6e38cd4f9

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/564913002

Cr-Commit-Position: refs/heads/master@{#294444}

This is a useful debug aid and better matches the behavior of tabs.

BUG=none

Review URL: https://codereview.chromium.org/564933002

Cr-Commit-Position: refs/heads/master@{#294443}

BUG=347777

Review URL: https://codereview.chromium.org/538173002

Cr-Commit-Position: refs/heads/master@{#294442}

BUG=none
R=
TEST=none
NOTRY=true
(documentation only change)

Review URL: https://codereview.chromium.org/549043004

Cr-Commit-Position: refs/heads/master@{#294441}

Review URL: https://codereview.chromium.org/560253002

Cr-Commit-Position: refs/heads/master@{#294440}

There are a few MessagePipeReader sublcasses defined as inter-classes
of ChannelMojo. This makes it harder to hook them for unit testing.
This CL moves these classes their own file. Now unittest can
define subclasses of these to hook some behavor for testing.

This is a preparation for a crash fix.

BUG=410813
TEST=none
R=viettrungluu@chromium.org,yzshen@chromium.org

Review URL: https://codereview.chromium.org/559723002

Cr-Commit-Position: refs/heads/master@{#294439}

BUG=411927

Review URL: https://codereview.chromium.org/556243003

Cr-Commit-Position: refs/heads/master@{#294438}

This is a simple move, except that we move three functions out of
chrome/browser/extensions/api/web_request/web_request_api_helpers to
extensions/browser/api/web_request/web_request_api_utils in order
to remove the chrome/ dependency. A new namespace is introduced to avoid
confusion.

BUG=352293.

Review URL: https://codereview.chromium.org/562913002

Cr-Commit-Position: refs/heads/master@{#294437}

When printing dependency cycles, the old meticulously walked the list backwards and explained that this was because the list was in the reverse order of the dependencies.

This is wrong, the list is in the normal forward direction and doing that prints out the reverse cycle which is very confusing. Reverse the order of printing to get the correct cycle.

Review URL: https://codereview.chromium.org/557103003

Cr-Commit-Position: refs/heads/master@{#294436}

https://chromium.googlesource.com/chromium/blink/+log/f00fc1e323c6f7222c9a394187567b43e8589dc5..5af3948f23b6954c5f76bac93474432805751cae
TBR=jianli@chromium.org,loislo@chromium.org

Review URL: https://codereview.chromium.org/561133006

Cr-Commit-Position: refs/heads/master@{#294435}

As a temporary solution, use 2x assets on 3x screens.

BUG=413300

Review URL: https://codereview.chromium.org/563713003

Cr-Commit-Position: refs/heads/master@{#294434}

BUG=None
TBR=dpolukhin@chromium.org

Review URL: https://codereview.chromium.org/561283002

Cr-Commit-Position: refs/heads/master@{#294433}

This reverts commit 86823cbf.

BUG=407376
TBR=rsesek@chromium.org

Review URL: https://codereview.chromium.org/566593002

Cr-Commit-Position: refs/heads/master@{#294432}

Revert of Reenable DevToolsSanityTest.TestDeviceEmulation. (patchset #1 id:1 of https://codereview.chromium.org/564763002/)

Reason for revert:
Fails on the main waterfall on Windows and Linux:

https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(dbg)(2)/builds/22510
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20(dbg)(1)/builds/33246

Original issue's description:
> Reenable DevToolsSanityTest.TestDeviceEmulation.
>
> BUG=397889
> TBR=pfeldman@chromium.org
>
> Committed: https://crrev.com/8844a8eba4465ff5f66bff5b7db195a0192625c3
> Cr-Commit-Position: refs/heads/master@{#294375}

TBR=pfeldman@chromium.org,dgozman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=397889

Review URL: https://codereview.chromium.org/562343002

Cr-Commit-Position: refs/heads/master@{#294431}

BUG=387077, 387079
R=bauerb@chromium.org, jochen@chromium.org, markusheintz@chromium.org
TBR=abarth@chromium.org
TEST=build succeeds / components_unittests

Review URL: https://codereview.chromium.org/541813002

Cr-Commit-Position: refs/heads/master@{#294430}

When a window is being transformed, position of touch selection handles
might not be valid anymore, hence deactivating touch selection.

BUG=407659

Review URL: https://codereview.chromium.org/551883002

Cr-Commit-Position: refs/heads/master@{#294429}

NOTRY=true

Review URL: https://codereview.chromium.org/551433003

Cr-Commit-Position: refs/heads/master@{#294428}

BUG=413214
R=acolwell@chromium.org

Review URL: https://codereview.chromium.org/563773002

Cr-Commit-Position: refs/heads/master@{#294427}

OS_CHROMEOS is defined in //build/config/linux:sdk per brettw
recommendation.

Typo fixed in ui/ozone/BUILD.gn

Some source-list fixes in content/browser/BUILD.gn that take both
use_x11 and use_ozone into account.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/558343002

Cr-Commit-Position: refs/heads/master@{#294426}

Fix a bug when a QUIC session is closed during the call to InitializeSession. This seems to be able to happen if too much time elapses between the call to the constructor and the call to InitializeSession.

Also adds a histogram to monitor the frequency of this situation.

BUG=399147

Review URL: https://codereview.chromium.org/560913002

Cr-Commit-Position: refs/heads/master@{#294425}

Remove explicitly depending on a webrtc config now that it is correctly
exported from webrtc.

R=kjellander@chromium.org

Review URL: https://codereview.chromium.org/534813002

Cr-Commit-Position: refs/heads/master@{#294424}

This is our first attempt, mostly to feel this out.  Performance and
correctness problems are both possible.  Please revert this if a benchmark even
smells funny.

That said, we've been working on this a while, are pretty confident it's good
stuff, and have had Skia's internal testing entirely switched over for a week.
Parts of Chromium that serialize and deserialize SkPictures are already
switched over.  This CL finishes things off by switching the default
recorded-from-scratch SkPicture to use SkRecord too.

BUG=408985,409110,409138

Committed: https://chromium.googlesource.com/chromium/src/+/f7450daaf38f4951b23fabaaaf659c6af33a705c

Committed: https://chromium.googlesource.com/chromium/src/+/5f2a6ab31313eb2fc6e456f65c3863a77d2d0c30

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg;tryserver.chromium.linux:linux_browser_asan

Committed: https://chromium.googlesource.com/chromium/src/+/130033d6c732af90ed117f05517e4efffd23ae58

Committed: https://crrev.com/ba819aea3f302d89100dc89632fd225a40e65411
Cr-Commit-Position: refs/heads/master@{#293503}

Review URL: https://codereview.chromium.org/504823003

Cr-Commit-Position: refs/heads/master@{#294423}

In the baseline policy, we restrict setpriority() to
|which| == PRIO_PROCESS and (|who| == 0) || (|who| == current_pid).

This doesn't affect most policies which allow setpriority()
unconditionally but allows baseline unittests to pass on Android.

BUG=398611, 399473
R=mdempsky@chromium.org

Review URL: https://codereview.chromium.org/430363003

Cr-Commit-Position: refs/heads/master@{#294422}

Revert of [Mac] Shut down connections to WindowServer before engaging the sandbox. (patchset #1 id:20001 of https://codereview.chromium.org/561833006/)

Reason for revert:
Possibly caused blink test failures.

Original issue's description:
> [Mac] Shut down connections to WindowServer before engaging the sandbox.
>
> The connection is only needed during sandbox warmup to initialize the default
> color space. It was formerly needed by scrollbar NSAnimations, but that was
> replaced via https://codereview.chromium.org/529103002/.
>
> A similar CL was landed and reverted:
> https://chromium.googlesource.com/chromium/src.git/+/53ffdf90f4646dbde8df72007fbdc97f3f0220de
>
> BUG=397642, 306348
> TEST=Manually tested on 10.6-10.10.
>
> Committed: https://crrev.com/f3198fb3fc64878b8feb88cfae28ddb7e8bd71ec
> Cr-Commit-Position: refs/heads/master@{#294382}

TBR=jeremy@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=397642, 306348

Review URL: https://codereview.chromium.org/567693002

Cr-Commit-Position: refs/heads/master@{#294421}

BUG=352293

Review URL: https://codereview.chromium.org/567643002

Cr-Commit-Position: refs/heads/master@{#294420}

BUG=405441

Review URL: https://codereview.chromium.org/528333002

Cr-Commit-Position: refs/heads/master@{#294419}

R=engedy@chromium.org

Review URL: https://codereview.chromium.org/565673004

Cr-Commit-Position: refs/heads/master@{#294418}

This patch introduces a WebGL test that ensures we don't hit an
assertion failure in DrawingBuffer when the context is lost in a
background tab.

Depends on the Blink fix from https://codereview.chromium.org/556303002.

BUG=411372

Review URL: https://codereview.chromium.org/560023002

Cr-Commit-Position: refs/heads/master@{#294417}

Cr-Commit-Position: refs/heads/master@{#294416}

Which is what we do on the gyp side too. Going this route rather than a different BUILD.gn as there aren't a lot of files and we don't have separate components on the gyp side.

BUG=408648
TEST=none
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/552053005

Cr-Commit-Position: refs/heads/master@{#294415}

This code is only used by the Notification constructor, and doesn't have
to be a public method on a class that's otherwise unrelated to it.

Also get rid of caching the UI manager in the service. All callsites of
the constructor passed in NULL, and BrowserProcess::notification_ui_manager()
actually does the caching for us.

TBR=jochen
BUG=

Review URL: https://codereview.chromium.org/561813002

Cr-Commit-Position: refs/heads/master@{#294414}

The current ELF file rewrite alters both offsets and addresses.
Altering addresses affects debugging tools such as breakpad.

This change leaves addresses unchanged, and instead splits a single
LOAD segment into two, leaving a mapping hole at the point where
the hole was created in the ELF file.  It works by repurposing the
PT_GNU_STACK segment, unused on Android.

The split into two LOAD segments no longer requires relocation
packing to adjust relocations or the symbol table, and in particular
means the the call frame information extracted by Dwarf DIE data
extractors for breakpad from an unstripped (and not packed) library
will match the stripped and packed one.

BUG=385553

Review URL: https://codereview.chromium.org/535943002

Cr-Commit-Position: refs/heads/master@{#294413}

Ignore the context for process-wide incidents when waiting for the most
recent download finder to complete. Otherwise the service holds on to
state needlessly.

BUG=413253
R=robertshield@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/562223002

Cr-Commit-Position: refs/heads/master@{#294412}

GN visibility currently allows either string or list types, but this is causing
some problems for some templates, which don't know if the invoker set the
visibility to a list or a string. Since there is no type reflection, templates
don't know how to handle visibility if they need to add to or replace the list.

Adds a missing error check in the config visibility checker.

R=ajwong@chromium.org

Review URL: https://codereview.chromium.org/552843005

Cr-Commit-Position: refs/heads/master@{#294411}

https://chromium.googlesource.com/chromium/blink/+log/f0548820182fad9dd6c5f4b444e57d90d83eb605..f00fc1e323c6f7222c9a394187567b43e8589dc5
TBR=jianli@chromium.org,loislo@chromium.org

Review URL: https://codereview.chromium.org/566633002

Cr-Commit-Position: refs/heads/master@{#294410}

BUG=None

Review URL: https://codereview.chromium.org/564643002

Cr-Commit-Position: refs/heads/master@{#294409}

Reland of -fno-exceptions only on .cc files https://codereview.chromium.org/560873003/ with fix for ASAN LSAN

libc++ build removed from cflags, so wasn't removed.

I don't see any other instances of doing this in https://code.google.com/p/chromium/codesearch#search/&q=fno-exceptions&sq=package:chromium&type=cs

R=earthdok@chromium.org, thakis@chromium.org
BUG=335824

Review URL: https://codereview.chromium.org/561063002

Cr-Commit-Position: refs/heads/master@{#294408}

In software mirroring mode, there is one X root window and it should
be associated with both displays (touchscreens).

BUG=chrome-os-partner:31466
TEST=tested on Big with clone mode.

Review URL: https://codereview.chromium.org/557073002

Cr-Commit-Position: refs/heads/master@{#294407}