- 02 Mar, 2018 40 commits
-
-
Brian Sheedy authored
This reverts commit dbc48ca4. Reason for revert: Getting NoClassDefFoundError on Nougat https://chromium-swarm.appspot.com/task?id=3c01bdd86290b710&refresh=10&show_raw=1 Original change's description: > Exclude unused java classes from gvr_common_java aar > > As far as I can tell this filters the rest of the unused java classes. > > Please revert this CL if you see ClassNotFound Exceptions. > > diagnose_bloat summary: > MonochromePublic.apk_Breakdown (-4,097 bytes) > +1,731 bytes Zip Overhead > -1 bytes Package metadata size > -5,827 bytes Java code size > MonochromePublic.apk_Specifics > -15,137 bytes normalized apk size > -11,040 bytes main dex size > > Bug: 944791 > Change-Id: I53219489d0289655a72405ab1e06cbeeb065d4f4 > Reviewed-on: https://chromium-review.googlesource.com/944791 > Reviewed-by: Brandon Jones <bajones@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#540549} TBR=mthiesse@chromium.org,bajones@chromium.org Change-Id: I1b4b8c2d4acaaa9eafde507ceeb32293a164ac2b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 944791 Reviewed-on: https://chromium-review.googlesource.com/946653Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#540672}
-
Ken MacKay authored
BUG= internal b/71559266 Change-Id: Ia7d00e82bca0a50385c58b853b4cba05670e0dde Reviewed-on: https://chromium-review.googlesource.com/937812 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#540671}
-
Patrick Monette authored
This change adds a class to detect when a registry key is deleted, meaning that the associated application was deleted. The javascript receives the event via a Web UI callback and removes the application from the list. Also added a section that indicates to the user that there isn't any applications in the list. Finally fixed ThirdPartyConflictsManager to wait until the ModuleDatabase is idle before initializing the InstalledPrograms instance. Bug: 717696 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8cf6ea948d63dd38fe6bae9969f103b5b22ab513 Reviewed-on: https://chromium-review.googlesource.com/942375Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#540670}
-
Steven Bennetts authored
Currently if a policy does not specify UserAuthenticationType, Password and OTP will be stripped from merged ONC. Insead we should allow both if unspecified. Bug: 817617 Change-Id: I2c4a47fb5aa0faaba10d4a76e53bb54671e7f450 Reviewed-on: https://chromium-review.googlesource.com/944617Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#540669}
-
Shenghua Zhang authored
As chromium 10.9 Mac machines upgrading finished, we need to migrate all 10.9 tests on waterfall to 10.13. Remove the multiple dimension warming config for Mac10.9 Tests builder. Bug: 805475 Change-Id: I46df122e2c19a4aa44d8065eebc95aa51d93c85c Reviewed-on: https://chromium-review.googlesource.com/942234 Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#540668}
-
Jay Civelli authored
This CL fixes 2 ChildProcessLauncherTest tests (testLaunchServiceThatUsesConnectionAllocator and testLaunchServiceCreatedWithBoundConnection) that fail because they validate that ChildProcessServiceDelegate.onDestroy() is called after unbinding the last connection to a service, but it is not always the case: the system might kill the service process directly, as seems to be the case with Android O. Bug: 788826 Change-Id: I75eff836fc4b1c4136239fba1171dc273d3167c6 Reviewed-on: https://chromium-review.googlesource.com/946895Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#540667}
-
Dave Tapuska authored
In order to facilitate improving the virtual keyboard experience on Windows 10 RS1 separate the OnScreenKeyboardDisplayManager interface into a stub impl (that is used on devices less than Windows 8) and the tab tip impl (that is used on Windows 8 and above). A follow-up patch will introduce a new version that will use InputPane on Windows 10 RS1 and later. BUG=817501 Change-Id: Ib8c626d12e7014551af54c2b5d4d047d2ca2505b Reviewed-on: https://chromium-review.googlesource.com/941911 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#540666}
-
wutao authored
This cl converts the new overview animations switch to a base::Feature which is enabled by default. Bug: 801465, 795988 Test: the feature works properly Change-Id: I9a8a40033bc7a08edcb94cbd6777e0be42335fdb Reviewed-on: https://chromium-review.googlesource.com/946557Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#540665}
-
Sammie Quon authored
We should instead prevent Ctrl Shift U mode in overview somehow, but this will stop the crash in the meantime. Test: ash_unittests WindowSelectorTest.ExitInUnderlineMode Bug: 807517 Change-Id: Ie7d889937c110583454a281a318b682f62cd6084 Reviewed-on: https://chromium-review.googlesource.com/932547Reviewed-by:
-
Sylvain Defresne authored
Change PreloadController to register itself as WebStateObserver for Tab's WebState and CRWWebDelegate for Tab's CRWWebController. Move code cancelling the pre-rendering to PreloadController. There is one change that is quite subtle: the PreloadController need to forward CRWWebDelegate methods to Tab if Tab implement them as there can only be one CRWWebDelegate registered. It also needs to register Tab as CRWWebDelegate at the end of pre-render. Bug: 661663 Change-Id: I64655ed8deef1cbad1a02a40b4d4b5d6b853d2eb Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/941329Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#540663}
-
Saman Sami authored
This bug is fixed, so remove the workaround code. Bug: 817364 Change-Id: I2f62a77920c0ac869867ed96f7d50f53c535ddad Reviewed-on: https://chromium-review.googlesource.com/946863Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#540662}
-
Josh Horwich authored
Record ARC-related consents using consent_auditor. This includes Play ToS, Backup and Restore, and Location Services. Adds checks to existing unit tests for proper consent recording, as well as adding a unit test to cover a hybrid managed/unmanaged case. Also fix a trivial bug in arc_terms_of_service.js referring to an old name for a method in ArcTermsOfServiceScreen. Bug: 781765 Test: Opt in on device, run unit_tests Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibce048770f0479c2c87abd08dcfaf1fb19bf608c Reviewed-on: https://chromium-review.googlesource.com/930473Reviewed-by:
Elijah Taylor <elijahtaylor@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#540661}
-
Doug Mangini authored
Capture screen and verify Blue background to ensure we are in VR. Change-Id: I4db0af02b8bdd534c76877a6fbc76795b268b2aa Reviewed-on: https://chromium-review.googlesource.com/944664Reviewed-by:
-
Jialiu Lin authored
Capture sync password on SSO sign-in and change password page, if the user name matches the sync username. SSO sign-in and change password page is specified via enterprise policy and stored in prefs. Note: PasswordManagerClient::GetPrefs() is changed to a const function, this is because |client_| in SyncCredentialsFilter is marked as const, and can only call const function. Bug: 811459 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibc9240a6395d6e892fb1f8c5330895a615128ef9 Reviewed-on: https://chromium-review.googlesource.com/932743Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#540659}
-
Wei-Yin Chen (陳威尹) authored
The enabling bit is saved in SharedPref, so change that as well. TBR=tedchoc@chromium.org Bug: 818236 Change-Id: Idbbdf97d01e452d18db6b172cc709caa521146a7 Reviewed-on: https://chromium-review.googlesource.com/946881Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#540658}
-
Ryan Landay authored
The current implementation of StackLayout#computeInputMode() contains mysterious thresholds, misnamed variables (distanceToDownSqr is the square of the distance moved *in the current frame*, not the distance since touch down), and dubious logic (comparisons between misnamed variables and mysterious thresholds). Most importantly, when I add a third stack, with the current logic, quick horizontal drags actually cause the stack in the middle to start animating a tab discard. This CL rewrites the logic in computeInputMode() to be more clear about what's actually going on, and fix the problem I'm running into with a third stack. Now, right after a user starts moving their finger, we decide whether they're performing a horizontal or vertical drag, and ignore all movement in the other direction for as long as they have their finger down. This prohibits certain drag operations that are currently possible (e.g. scrolling up in a tab stack, then dragging horizontally to scroll over to another tab stack without lifting your finger), but these are not clearly useful, and seem more trouble than they're worth to support. Bug: 817885 Change-Id: I8959dffafb961de533d7d719c37a9b7c4ef0f333 Reviewed-on: https://chromium-review.googlesource.com/940188 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#540657}
-
Frank Barchard authored
Contains the following changes: 98a0a15 Expect YUV to RGB to match exactly for C and SIMD by Frank Barchard · 28 minutes ago master 29383c8 switch to static_assert for clang-tidy by Frank Barchard · 3 days ago 368ac76 clang-tidy fix for MJPEGToI420 and MJPEGToARGB by Frank Barchard · 3 days ago 85722f5 ByteToFloatRow_NEON to convert and scale bytes to floats by Frank Barchard · 7 days ago 0ea50cb NV21ToRGB24_NEON conversion by Frank Barchard · 8 days ago a96d1dd Roll chromium_revision ff3b3178..80f0c557 (503850:536678) by Patrik Höglund · 8 days ago 5f0354b clang-tidy and clang-format applied reland by Frank Barchard · 9 days ago 9c0663d Revert "clang-tidy and clang-format applied" by Frank Barchard · 9 days ago cfff527 clang-tidy and clang-format applied by Frank Barchard · 9 days ago 18c9ab1 Rotate ARGB using scale_row.h header by Frank Barchard · 10 days ago 29ba52e [build] Prepare removal of gyp-defines from landmine by Michael Achenbach · 14 days ago 3d6b565 AR30ToARGB using shifts and masking to vectorize by Frank Barchard · 2 weeks ago 9c9215b End swap 10 bit RGB by Frank Barchard · 2 weeks ago 6630558 10 bit YUV to 10 bit BGR by Frank Barchard · 2 weeks ago 439fc3c Revert "Revert "Fixing libyuv gn check."" by Frank Barchard · 3 weeks ago 8a00c2b Tidy applied with all safe checks on all arm, mips and intel, 32 and 64 bit by Frank Barchard · 3 weeks ago 724dbeb Revert "Fixing libyuv gn check." by Frank Barchard · 3 weeks ago 9a765f0 Revert "tidy applied with readability-*" by Frank Barchard · 3 weeks ago 7b9ff4a tidy applied with readability-* by Frank Barchard · 3 weeks ago Bug: libyuv:447, libyuv:782, libyuv:778, libyuv:779, libyuv:750, libyuv:777 Test: try bots Change-Id: I2a4c2e8ff05e539e8f83d4c0e6559f99b8cd933a Reviewed-on: https://chromium-review.googlesource.com/946743Reviewed-by:
Frank Barchard <fbarchard@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Frank Barchard <fbarchard@chromium.org> Cr-Commit-Position: refs/heads/master@{#540656}
-
James Hawkins authored
A follow-up CL will move the source files into chrome/browser/chromeos/signin. Bug: 817115 Test: Existing tests Change-Id: If4d47bfc1109d9b1b030d70e6e7b2fa3d7b3dbcf Reviewed-on: https://chromium-review.googlesource.com/942041 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#540655}
-
Jun Cai authored
The DeviceOrientation event: https://w3c.github.io/deviceorientation/spec-source-orientation.html has been refactored to use //services/device/generic_sensor instead of //device/sensors as its backend. So the //device/sensors directory is unused and can be removed. motion_data.* and orientation_data.* files have been moved from //device/sensors/ to //services/device/public/cpp/generic_sensor/. The issue 721427 page contains the design doc link for this change. Bug: 721427 Change-Id: I74876efe6fc4aa586e8c5b391817b02f48864993 Reviewed-on: https://chromium-review.googlesource.com/667784 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#540654}
-
kylechar authored
Move everything software compositing related into one function. Bug: 772576 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I110c9dd06b5e9a90a6667501aa2945c383a670ca Reviewed-on: https://chromium-review.googlesource.com/943723 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#540653}
-
Ken MacKay authored
Updated the unit test as well to catch the error (without MSAN). Bug: internal b/71559266 Change-Id: I7a433e4abacadb5396710b07b95be05c77cda6bc Reviewed-on: https://chromium-review.googlesource.com/946564Reviewed-by:
-
Tom Sepez authored
No functional changes. Change-Id: I6ca55603d574cdc91d7de2379631f0af8d76bdc9 Reviewed-on: https://chromium-review.googlesource.com/946857Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#540651}
-
bsheedy authored
The newly added bot seems to have been incorrectly running the VR tests. Since we don't gain anything from running there, disable the tests entirely instead of running them properly. Change-Id: Ic0ff6743390593c2fbbb8c1baa93ff3193ca0a17 Reviewed-on: https://chromium-review.googlesource.com/946552Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#540650}
-
Elad Alon authored
For remote-bound WebRTC event logs: * Set ~500MB as the maximum file size. * Set 65535 as the maximum metadata size. Fail StartEventLog() if either is exceeded. Bug: 775415 Change-Id: I35acec807086291120028f172a216fd42b9f0e8c Reviewed-on: https://chromium-review.googlesource.com/941801 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#540649}
-
spqchan authored
Bug: 818055 Change-Id: Ia0f8ee535c45ede4047e02f068def70e538b8524 Reviewed-on: https://chromium-review.googlesource.com/946740Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#540648}
-
Jun Cai authored
This is a follow-up CL that addresses the comment at: https://chromium-review.googlesource.com/c/chromium/src/+/938960/4/content/browser/loader/resource_dispatcher_host_impl.cc#2615 By making ResourceDispatcherHostImpl::RunAuthRequiredCallback() bind to request ID, we can safely verify the loader and the request are still valid before calling CancelAuth()/SetAuth(). Bug: 783990 Change-Id: Id45b16d08b2dbde3df4c1e2a13f0e780fcef68dd Reviewed-on: https://chromium-review.googlesource.com/942229Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#540647}
-
MinChen authored
Bug: 799524 Change-Id: Ia2a82e1e84cbeda504581fe290ea81dffcffebfa Reviewed-on: https://chromium-review.googlesource.com/940763 Commit-Queue: min c <minch@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#540646}
-
Jay Civelli authored
Making the Save Page code use the URLLoaderFactory instead of using the ResourceDispatcherHost directly. This means the resource downloads are triggered on the UI thread and download notifications also happen on the UI thread. Also removing a NOTREACHED in SimpleURLLoader::OnReceiveCachedMetadata that got hit when downloading some pages and is a valid call that we can ignore. Bug: 816644, 779210 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I3c4be94b253392ae6860f8c9e3f1e4fbb752b238 Reviewed-on: https://chromium-review.googlesource.com/944906 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
-
Zhongyi Shi authored
- MIGRATION_STATUS_PATH_DEGRADING_NOT_ENABLED - MIGRATION_STATUS_TIMEOUT to help us differentiate the case that connection failed after waiting for new network to connect for 10 seconds. This CL also changes labels associated with QuicConnectionMigrationStatus in histograms to make it more readable. Bug: 804048 Change-Id: Iee870ac45ca0a038f9838a585c120846521375a4 Reviewed-on: https://chromium-review.googlesource.com/942036 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#540644}
-
Xianzhu Wang authored
Bug: 813306 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I0d431f44cb0347d49445e749ca29d58fc8bd8024 Reviewed-on: https://chromium-review.googlesource.com/946629Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#540643}
-
Alexander Timin authored
Bug 813218 sounds like we fail to schedule PumpThrottledTasks and throttling machinery grinds to a halt. Reduce the probability of this by ensuring that a call to PumpThrottledTasks is always scheduled. R=skyostil@chromium.org BUG=813218 Change-Id: Ie963d1eae456e39266bc8b347fdae0fa2bd37e7e Reviewed-on: https://chromium-review.googlesource.com/946588 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#540642}
-
MinChen authored
changes in this cl: 1. Update the image of power off and sign out icons. 2. Move the icon and text to be 8dp lower to make them more centered vertically. Bug: 799524 Change-Id: I2d547c4d2b785e5b6e402b26702c5b975c11d28f Reviewed-on: https://chromium-review.googlesource.com/942228Reviewed-by:
-
chaopeng authored
For support Windows Precision Touchpad, we need to use Direct Manipulation. In this patch, we read the scale factor and translate offset from Direct Manipulation and convert them to ui::MouseWheelEvent. This patch not change touchpad scroll behaviour. But the scale will be too fast since we receive too much scale event and convert them to ctrl+wheel. I will fix the scale issue in following patch. Bug: 779372 Change-Id: I8fa9db0643390660e08afc1398828eb051177fe2 Reviewed-on: https://chromium-review.googlesource.com/653581 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#540640}
-
MinChen authored
This is no longer needed now since there is no lock animation if press power button for all the devices. Removed |forced_clamshell_power_button_| related logic in PowerButtonScreenshotController. Bug: 799524 Change-Id: Ief78819978461a66410936cd0c40a28a199798b3 Reviewed-on: https://chromium-review.googlesource.com/940624 Commit-Queue: min c <minch@chromium.org> Reviewed-by:
-
Yuke Liao authored
This CL does two things: 1. Simplify DownloadCoverageToolsIfNeeded() to not depend on target_os, and move the supported platforms assertions to the main function. 2. Fixed a bug that a logging statement was called in DownloadCoverageToolsIfNeeded() before logging is configured, which results in all the remaining log output are eaten, so this CL moves DownloadCoverageToolsIfNeeded() to execute after logging is configured. Change-Id: I5bc97d4db3711054018684b7390e3137455b4e9f Reviewed-on: https://chromium-review.googlesource.com/943932 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#540638}
-
Benjamin Pastene authored
No guarantee that this'll work right away, but it's a good start. Bug: 814935 Change-Id: Idbe672d5a52b36d484015e4f321ddb747a96b222 Reviewed-on: https://chromium-review.googlesource.com/945129Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#540637}
-
edchin authored
This sets a stub implementation of setTransitionContext so that tab grid can run on tablet. This implementation can eventually be removed when the iPad-specific TabSwitcher is removed. Bug: 804537 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3b5b8e7620d67c2d02a284b320df5ce003f78023 Reviewed-on: https://chromium-review.googlesource.com/946110Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540636}
-
Balazs Engedy authored
Multiple usages of relative `testing::*` references make it impossible to have a nested namespace `device::testing`; although this is likely to ultimately end up as just a clean-up CL because it seems more common to call the nested namespace `test` instead of `testing`. Bug: 785955 Change-Id: I59a31553a2436f0682cd9f4cb87071a81a5f0bca Reviewed-on: https://chromium-review.googlesource.com/946103 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#540635}
-
Penny MacNeil authored
- Enable MITIGATION_RESTRICT_INDIRECT_BRANCH_PREDICTION and MITIGATION_IMAGE_LOAD_PREFER_SYS32 on all child processes pre-startup. - Enable MITIGATION_IMAGE_LOAD_* on browser process, post-startup. IMPACT REMINDER: ---------------- - RESTRICT_INDIRECT_BRANCH_PREDICTION: spectre variant 2 hyper-thread mitigation on >= Win10 1709 (with Jan2018 security patches), given underlying hardware support (e.g.: Intel STIBP). - PREFER_SYS32: Forces image load preference to prioritize the Windows install System32 folder before dll load dir, application dir and any user dirs set. (Affects IAT resolution standard search path only, NOT direct LoadLibrary or executable search path.) - NO_REMOTE: Blocks mapping of images from remote devices. - NO_LOW_LABEL: Blocks mapping of images that have the low mandatory label. Bug=808526 Test=sbox_integration_tests.exe, ProcessMitigationsTest.* Change-Id: I88a75e1db1907e2c1f1b85f69b43ef73cf3ec5f5 Reviewed-on: https://chromium-review.googlesource.com/940528 Commit-Queue: Penny MacNeil <pennymac@chromium.org> Reviewed-by:
James Forshaw <forshaw@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#540634}
-
Eric Willigers authored
If the left/right/bottom/top length of the parent clip changes, we update the animation instead of using the old values. BUG=817697 Change-Id: If241065d2df321be59970dc2c40d391a2d7d7627 Reviewed-on: https://chromium-review.googlesource.com/942590Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#540633}
-
